@bongos/core 1.25.3 → 1.25.4

package/tests/hall_visor_profile.mjs

@@ -0,0 +1,150 @@
+// tests/hall_visor_profile.mjs — you on the visor (task 1005249).
+//
+// The owner's ask (2026-11-12): the Standing chip that sat top right of Home is gone;
+// the visor's bottom-left you-block shows your details on hover and opens your whole
+// profile, in the game's window over the place, on click. This runs the real visor,
+// the real shell-game window and the real dialog in a browser, plus the pure facts in
+// a vm, and checks Home's page no longer carries the chip.
+//
+// Run:  node --test tests/hall_visor_profile.mjs
+import assert from 'node:assert/strict';
+import { test, after } from 'node:test';
+import { createRequire } from 'node:module';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const HALL = path.join(ROOT, 'modules/hall-ui/public');
+const read = (f) => fs.readFileSync(path.join(HALL, f), 'utf8');
+
+// ---------- the facts, in a vm ----------
+function loadVisor(me) {
+  const doc = {
+    readyState: 'complete', body: null, documentElement: { dataset: {}, classList: { contains: () => false, toggle() {}, remove() {} } },
+    addEventListener() {}, querySelector: () => null, createElement: () => ({}),
+  };
+  const win = { document: doc, location: { pathname: '/', assign() {} }, addEventListener() {}, OTBCraftMode: { me: () => me } };
+  win.window = win;
+  vm.runInNewContext(read('visor.js'), win);
+  return win.OTBVisor;
+}
+
+test('the card\'s facts come from /me: name, handle, rank, credits, karma, preferred work', () => {
+  const me = { builder: { display_name: 'Percy Jackson', github_login: 'percy', rank: 'metic', total_credits: 14441, karma: 96.4, preferred_disciplines: ['artisan', 'ui'] } };
+  const f = JSON.parse(JSON.stringify(loadVisor(me).meFacts(me)));
+  assert.deepEqual(f, { name: 'Percy Jackson', handle: '@percy', rank: 'Metic', credits: 14441, karma: 96, prefs: 'artisan, ui' });
+  const bare = JSON.parse(JSON.stringify(loadVisor(null).meFacts({ builder: { github_login: 'x' } })));
+  assert.equal(bare.name, 'x', 'no display name: the login');
+  assert.equal(bare.karma, 0);
+  assert.equal(bare.prefs, '', 'no preference: empty, and the card says "Not set yet"');
+  assert.equal(loadVisor(null).meFacts(null), null, 'before /me answers there is nothing to show');
+});
+
+test('Home carries no Standing chip any more, and no sheet styles one', () => {
+  assert.doesNotMatch(read('index.html'), /hall-standing|home-standing-body/);
+  assert.doesNotMatch(read('style.css'), /\.hall-standing|\.home-who|\.home-facts/);
+  assert.doesNotMatch(read('hall-render.js'), /home-standing-body|hall-standing|leaderboardPlace/);
+});
+
+// ---------- in a browser ----------
+const lib = require(path.join(ROOT, 'modules', 'ui-design', 'kit', 'lib.js'));
+let browser = null;
+try { browser = await lib.launchBrowser(); } catch (e) { if (!(e instanceof lib.NoBrowserError)) throw e; }
+after(() => browser && browser.close());
+const skip = !browser && 'no system Edge or Chrome';
+
+const ORIGIN = 'http://hall.test';
+const TYPES = { '.js': 'text/javascript', '.css': 'text/css', '.png': 'image/png', '.svg': 'image/svg+xml' };
+const SCENE = `<script>
+  window.OTBCraftMode = { character() { return 'artisan'; }, current() { return null; },
+    me() { return { builder: { display_name: 'Percy Jackson', github_login: 'percy', rank: 'metic', total_credits: 14441, karma: 96, preferred_disciplines: [] } }; },
+    spriteSrc(id) { return '/builders/characters/' + id + '.png'; } };
+  window.__visorScene = { name: 'test', place: 'Test city', actions: [], keys: [] };
+</script>`;
+const PAGE = (withWindow) => `<!doctype html><html data-theme="dark" data-faces="helm"><head><meta charset="utf-8">
+<link rel="stylesheet" href="/builders/style.css"><link rel="stylesheet" href="/builders/visor.css"></head>
+<body>${SCENE}<script src="/builders/hall-dialog.js"></script>${withWindow ? '<script src="/builders/shell-game.js"></script>' : ''}<script src="/builders/visor.js"></script></body></html>`;
+
+async function open({ withWindow = true } = {}) {
+  const ctx = await browser.newContext({ viewport: { width: 1280, height: 800 } });
+  await ctx.route(ORIGIN + '/**', (route) => {
+    const p = new URL(route.request().url()).pathname;
+    if (p === '/') return route.fulfill({ contentType: 'text/html', body: PAGE(withWindow) });
+    if (p === '/profile') return route.fulfill({ contentType: 'text/html', body: '<!doctype html><title>profile</title><p id="pp">your profile</p><script src="/builders/shell-game.js"></script>' }); // the real page carries the game shell, which hands an Escape up
+    const f = path.join(HALL, p.replace(/^\/builders\//, ''));
+    if (p.startsWith('/builders/') && TYPES[path.extname(p)] && fs.existsSync(f)) return route.fulfill({ contentType: TYPES[path.extname(p)], body: fs.readFileSync(f) });
+    return route.fulfill({ status: 404, body: '' });
+  });
+  const page = await ctx.newPage();
+  const errors = [];
+  page.on('pageerror', (e) => errors.push(String(e.message)));
+  await page.addInitScript(() => { try { localStorage.setItem('hall-game', 'on'); document.documentElement.dataset.game = 'on'; window.OTB = { escapeHtml: (s) => String(s) }; } catch (_) { /* none */ } });
+  await page.goto(ORIGIN + '/');
+  await page.waitForFunction(() => !!document.querySelector('.visor__me'));
+  return { ctx, page, errors };
+}
+
+test('hovering you on the visor shows your details; at rest they are hidden', { skip }, async () => {
+  const { ctx, page, errors } = await open();
+  const shown = () => page.evaluate(() => getComputedStyle(document.querySelector('.visor__card')).visibility);
+  assert.equal(await shown(), 'hidden', 'nothing over the scene at rest');
+  await page.hover('.visor__me');
+  await page.waitForFunction(() => getComputedStyle(document.querySelector('.visor__card')).opacity === '1');
+  assert.equal(await shown(), 'visible');
+  const text = await page.evaluate(() => [...document.querySelectorAll('.visor__card > span')].map((s) => s.innerText.replace(/\s+/g, ' ').trim()));
+  assert.match(text[0], /Percy Jackson @percy/i);
+  assert.match(text[1], /Rank Metic/i);
+  assert.match(text[1], /Credits 14,441/i);
+  assert.match(text[1], /Karma 96/i);
+  assert.match(text[1], /Preferred work Not set yet/i);
+  assert.match(text[2], /Open your profile/i);
+  const box = await page.evaluate(() => { const r = document.querySelector('.visor__card').getBoundingClientRect(); return { top: r.top, left: r.left }; });
+  assert.ok(box.top >= 0 && box.left >= 0, 'the card stays on screen');
+  assert.deepEqual(errors, []);
+  await ctx.close();
+});
+
+test('clicking you opens your whole profile in the window over the place; Escape closes it', { skip }, async () => {
+  const { ctx, page, errors } = await open();
+  await page.click('.visor__me');
+  await page.waitForFunction(() => window.OTBOptionsOverlay.isOpen());
+  const w = await page.evaluate(() => ({
+    url: location.pathname,
+    src: document.querySelector('.opt-window__frame').getAttribute('src'),
+    label: document.querySelector('.opt-window__box').getAttribute('aria-label'),
+    close: document.querySelector('.opt-window__x').getAttribute('aria-label'),
+  }));
+  assert.equal(w.url, '/', 'the place stays: no navigation');
+  assert.equal(w.src, '/profile?embed=1');
+  assert.equal(w.label, 'Your profile');
+  assert.equal(w.close, 'Close your profile');
+  // the frame's own shell must be up before an Escape inside it can be handed up
+  await page.waitForFunction(() => { const f = document.querySelector('.opt-window__frame'); try { return !!(f && f.contentDocument.readyState === 'complete' && f.contentDocument.documentElement.dataset.embed === 'on'); } catch (_) { return false; } });
+  await page.keyboard.press('Escape');
+  await page.waitForFunction(() => !window.OTBOptionsOverlay.isOpen());
+  // the same window still opens Options under its own name
+  await page.evaluate(() => window.OTBOptionsOverlay.open(''));
+  assert.equal(await page.evaluate(() => document.querySelector('.opt-window__box').getAttribute('aria-label')), 'Options');
+  assert.equal(await page.evaluate(() => document.querySelector('.opt-window__frame').getAttribute('src')), '/settings?embed=1');
+  assert.deepEqual(errors, []);
+  await ctx.close();
+});
+
+test('with no window to draw, you are still a link to your profile', { skip }, async () => {
+  const { ctx, page, errors } = await open({ withWindow: false });
+  const r = await page.evaluate(() => {
+    const me = document.querySelector('.visor__me');
+    const ev = new MouseEvent('click', { bubbles: true, cancelable: true });
+    // stop the browser before it leaves, once the visor has had its say
+    window.addEventListener('click', (e) => { window.__left = !e.defaultPrevented; e.preventDefault(); });
+    me.querySelector('.visor__name').dispatchEvent(ev);
+    return { href: me.getAttribute('href'), followed: window.__left };
+  });
+  assert.equal(r.href, '/profile');
+  assert.equal(r.followed, true, 'the visor lets the link take you to the profile page');
+  assert.deepEqual(errors, []);
+  await ctx.close();
+});

package/tests/leaderboard_roles.mjs

@@ -16,7 +16,7 @@
 //      that craft earned, and a dash, not a 0, for a builder with no AI sessions.
 //      (Two crafts since task 1005141: the engineer is the artisan, and the
 //      ideator folded into the artist, so idea credits rank as artist credits.)
-//   4. THE STANDING CARD and 5. THE STATUS PAGE: the real functions, run.
+//   5. THE STATUS PAGE: the real function, run. (4, the Standing chip, went in task 1005249.)
 
 import { strict as assert } from 'node:assert';
 import { createRequire } from 'node:module';
@@ -234,7 +234,7 @@ await test('the Artists toggle shows only artists, ranked by the credits that cr
   assert.equal(r.rows.length, FIX.leaderboard.length, 'Everyone brings every builder back');
 });
 
-// ---- 4. the standing card ---------------------------------------------------------
+// ---- 4. (the standing card, gone; extract() serves section 5) ---------------------
 
 function extract(src, start, end) {
   const a = src.indexOf(start);
@@ -243,21 +243,7 @@ function extract(src, start, end) {
   return src.slice(a, b);
 }
 
-await test('the standing card adds the place inside the builder\'s main role, only when it says something new', () => {
-  const src = read('modules/hall-ui/public/hall-render.js');
-  const code = extract(src, 'const lbState = { rows: [] };', '    return { lbState');
-  const sandbox = { rows: FIX.leaderboard };
-  vm.createContext(sandbox);
-  vm.runInContext(`${code}; lbState.rows = rows; this.place = leaderboardPlace; this.text = rolePlaceText;`, sandbox);
-  const art = sandbox.place('builder-7');
-  assert.equal(art.role.craft, 'artist');
-  assert.equal(sandbox.text(art), `#2 as an artist`, 'fourth overall, second among artists: something new, so it is said');
-  const top = sandbox.place(FIX.leaderboard[0].github_login);
-  assert.equal(sandbox.text(top), '', 'the top artisan is #1 either way, so nothing is added');
-  // task 1005054: the stats strip (and its rank tile) left Home; the Standing chip's card carries the role place
-  assert.match(src, /\$\{rolePlaceText\(rollPlace\) \? `<span title="Your place among the/);
-  assert.match(read('modules/hall-ui/public/builders.js'), /getJSON\(`\$\{API\}\/public\/leaderboard`\)/, 'the hall reads the list with the roles');
-});
+// (Its test of the Standing chip's role place went with the chip in task 1005249.)
 
 // ---- 5. the status page -----------------------------------------------------------