@bongos/core 1.25.29 → 1.25.30

package/modules/hall-ui/public/craft-mode.js

@@ -265,6 +265,10 @@
     return false;
   }
   function homeHref(mode) {
+    // In game mode the street is not a place (shell-game.js would send it back
+    // home), so the patron's home there is Home itself (task 1005307).
+    var g = window.OTBShellGame;
+    if (g && typeof g.on === 'function' && g.on() === true) return '/';
     var street = mode === 'patron' && window.GovCity && window.GovCity.STREET_HREF;
     return street || '/';
   }

package/modules/hall-ui/public/home-city.js

@@ -355,9 +355,17 @@
   }
 
   // ---- the governor's Home is the street; tests swap the hop for a recorder ----
+  // Classic view only (task 1005307): in game mode the street is not a place, so
+  // shell-game.js sends it straight back here — hopping from Home made an endless
+  // reload loop. The game's patron stays on the city and walks on from the visor.
+  // shell-game.js is the one answer: a page without it is never in game mode.
+  function gameOn() {
+    const g = window.OTBShellGame;
+    return !!(g && typeof g.on === 'function' && g.on() === true);
+  }
   function streetHop() {
     const href = window.GovCity && window.GovCity.STREET_HREF;
-    if (document.documentElement.dataset.craft !== 'patron' || !href) return false;
+    if (document.documentElement.dataset.craft !== 'patron' || !href || gameOn()) return false;
     (window.OTBHomeStreetHop || ((h) => window.location.assign(h)))(href);
     return true;
   }

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.25.29",
+  "version": "1.25.30",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.25.29",
+      "version": "1.25.30",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.25.29",
+  "version": "1.25.30",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -11949,5 +11949,11 @@
       "id": "1005299",
       "text": "The city's sky clock no longer says \"hour 24\" in the last three minutes before midnight, and its check no longer fails at random late at night."
     }
+  ],
+  "1.25.30": [
+    {
+      "id": "1005307",
+      "text": "Choosing Patron in game mode no longer reloads the hall endlessly; it settles on the city."
+    }
   ]
 }

package/src/module-api.js

@@ -81,7 +81,7 @@ const { sleep } = require('./sleep');
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.25.29'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.25.30'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/craft_mode_home.mjs

@@ -31,7 +31,7 @@ function el() {
 }
 
 // One page: `page` is body[data-page], `active` the nav item the shell marked.
-function boot({ page, active = null, govCity = false }) {
+function boot({ page, active = null, govCity = false, game = false }) {
   const hops = [];
   const body = el();
   body.setAttribute('data-page', page);
@@ -55,6 +55,7 @@ function boot({ page, active = null, govCity = false }) {
     location: { search: '' },
   };
   if (govCity) window.GovCity = { STREET_HREF: '/builders/street' };
+  if (game) window.OTBShellGame = { on: () => true };
   window.window = window;
   vm.runInNewContext(CRAFT, { window, document, CustomEvent: function () {}, Promise, console });
   return { CM: window.OTBCraftMode, hops };
@@ -83,6 +84,16 @@ test('choosing Patron on another craft\'s page lands on the street', () => {
   assert.equal(boot({ page: 'studio' }).CM.homeHref('patron'), '/');
 });
 
+// task 1005307: in game mode the street is not a place (shell-game.js sends it back
+// Home, and Home sent a patron to the street again: an endless reload loop), so a
+// stranded page goes straight Home.
+test('in game mode, choosing Patron on another craft\'s page goes Home, never the street', () => {
+  const { CM, hops } = boot({ page: 'studio', active: 'studio', govCity: true, game: true });
+  assert.equal(CM.homeHref('patron'), '/');
+  CM.choose('patron');
+  assert.deepEqual(hops, ['/']);
+});
+
 test('a page the chosen craft also shows stays put', () => {
   // goals is in Artisan and Artist alike
   const { CM, hops } = boot({ page: 'goals', active: 'goals' });

package/tests/home_city_widget.mjs

@@ -48,12 +48,13 @@ const stubs = (status, craft) => `
   window.OTBCraftMode = { iconHtml: (k, cls) => '<svg class="' + cls + '" data-icon="' + k + '"></svg>', choose: (m) => window.__chosen.push(m), current: () => window.__craft };
   window.OTB = { contributeHallWidget(w) { window.__widget = w; } };`;
 
-async function boot({ status = 200, width = 1280, still = true, craft = null } = {}) {
+async function boot({ status = 200, width = 1280, still = true, craft = null, game = false } = {}) {
   const ctx = await browser.newContext({ viewport: { width, height: 900 }, reducedMotion: still ? 'reduce' : 'no-preference' });
   const page = await ctx.newPage();
   await page.clock.install();
   await page.setContent(`<!doctype html><html><head><style>${CSS}</style></head><body><section id="home-city" class="scroll home-city" hidden></section></body></html>`);
   await page.addScriptTag({ content: stubs(status, craft) });
+  if (game) await page.addScriptTag({ content: 'window.OTBShellGame = { on: () => true };' });
   await page.addScriptTag({ content: GOV });
   await page.addScriptTag({ content: DRAW });
   await page.addScriptTag({ content: WIDGET });
@@ -184,6 +185,16 @@ test('the governor\'s Home is the street: Patron on Home goes there, opened or c
   await ctx.close();
 });
 
+// task 1005307: in game mode the street is not a place — shell-game.js sends it back to
+// Home — so hopping there from Home was an endless reload loop. The game's patron stays.
+test('in game mode the patron stays on Home: no hop to the street, opened or chosen', { skip }, async () => {
+  const { ctx, page } = await boot({ craft: 'patron', game: true });
+  await page.waitForFunction(() => document.querySelectorAll('.hc-rung').length > 0);
+  const flipped = await page.evaluate(() => { document.dispatchEvent(new CustomEvent('otb:craft', { detail: { mode: 'patron' } })); return window.__hops.slice(); });
+  await ctx.close();
+  assert.deepEqual(flipped, [], 'Home with Patron in game mode builds the city and never leaves for the street');
+});
+
 test('a refused read leaves the section hidden: never an empty plate', { skip }, async () => {
   const { ctx, page } = await boot({ status: 401 });
   await page.evaluate(() => new Promise((r) => setTimeout(r, 0)));