@bongos/core 1.25.2 → 1.25.4

package/tests/hall_home_ships_bounded.mjs

@@ -7,9 +7,8 @@
 // table and a count. This pins the bounded shape:
 //
 //   1. the route answers a small page plus `total`, counting only when it must;
-//   2. hall-render.js keeps Home on that small page, and fetches the full ledger
-//      only when the Accomplishments view is open — and again only when the
-//      newest ships or the count moved.
+//   2. Home asks for no ships at all (task 1005249 removed the last count it
+//      showed); the Profile page reads its own ledger.
 //
 // (builders.js's own request is pinned in tests/hall_landing_boot.mjs, which
 // already boots the real page.) DB-free: vm + stubs.
@@ -120,31 +119,16 @@ function loadRender({ view = 'home' } = {}) {
   return { r, el, fetched, showView };
 }
 
-const homePage = (total, firstId = 3000) => ({ ships: [ship(firstId), ship(firstId - 1)], total });
-
-test('Home: the Standing chip\'s count comes from the small page, with no ledger fetch', async () => {
-  // task 1005054: the Shipped tile and the five-row table left Home with the stats
-  // strip and "Your work"; the small page still feeds the Standing chip's count.
-  const { r, el, fetched } = loadRender();
-  assert.equal(r.HOME_SHIPS_LIMIT, 5);
-  r.setRecentShips(homePage(3000));
-  await new Promise((done) => setTimeout(done, 0));
-  assert.deepEqual(fetched, [], 'Home never asks for the full history');
-  assert.equal(el('standing-shipped').textContent, '3000', 'the chip shows the server total, not rows held');
-  assert.equal(el('recent-ships tbody').innerHTML, '', 'the ledger is untouched until its view opens');
-});
-
-// task 1005050: the full ledger was the Accomplishments view's, and that view
-// folded into the Profile page (whose Works ledger reads its own record). Home
-// now NEVER asks for the whole history — not on a view change, not on a refresh.
-test('Home never downloads the whole history, whatever view event or refresh arrives', async () => {
-  const { r, el, fetched, showView } = loadRender({ view: 'standing' });
-  r.setRecentShips(homePage(3000));
+// task 1005249: the Standing chip, the last thing on Home that showed a shipped
+// count, is gone, so Home keeps no ships at all — not a small page, not a count —
+// and asks for none, whatever view event arrives.
+test('Home keeps and asks for no ships at all, whatever view event arrives', async () => {
+  const { r, fetched, showView } = loadRender({ view: 'home' });
+  assert.equal(r.setRecentShips, undefined, 'no ships setter');
+  assert.equal(r.HOME_SHIPS_LIMIT, undefined, 'no small page size');
+  assert.equal(r.loadShipLedger, undefined, 'no ledger loader');
   showView('standing');
-  r.setRecentShips(homePage(3001, 3001)); // this builder shipped
   await new Promise((done) => setTimeout(done, 0));
-  assert.deepEqual(fetched, [], 'no ?limit=all read from Home');
-  assert.equal(el('standing-shipped').textContent, '3001', 'the chip follows the newest total');
-  assert.equal(r.loadShipLedger, undefined, 'the ledger loader went with the view');
+  assert.deepEqual(fetched, [], 'no ships read from Home');
 });
 

package/tests/hall_landing_boot.mjs

@@ -91,10 +91,9 @@ async function boot({ meStatus, settle = false }) {
       wirePager: () => {},
     },
     OTBHallRender: () => ({
-      analyticsState: {}, lbState: {},
+      analyticsState: {},
       shipsPager: { page: 1 },
-      // task 1004854: Home asks for this many ships; the ledger's full read lives in hall-render.js.
-      HOME_SHIPS_LIMIT: 5, setRecentShips: spy('setRecentShips'), populateShipVersionFilter: spy('populateShipVersionFilter'),
+      populateShipVersionFilter: spy('populateShipVersionFilter'),
       mountHallWidgets: spy('mountHallWidgets'),
       renderLanding: spy('renderLanding'),
       renderCurveBody: spy('renderCurveBody'), renderGreeting: spy('renderGreeting'),
@@ -154,10 +153,10 @@ test('a signed-in builder still gets the hall', async () => {
 
 // task 1004854: Home used to download the builder's WHOLE ship history here, on
 // every load and every live refresh — ~3.4 s of database time for 3,000 ships, to
-// fill a five-row table and a count. It asks for the small page only.
-test('Home asks for its few newest ships, never the full history', async () => {
+// fill a five-row table and a count. Since task 1005249 it shows no ship count at
+// all (the Standing chip went), so it asks for no ships and no leaderboard.
+test('Home asks for no ships and no leaderboard', async () => {
   const calls = await boot({ meStatus: 200, settle: true });
-  const ships = calls.requests.filter((r) => r.includes('/me/recent-ships'));
-  assert.deepEqual(ships, ['GET /api/bongos/me/recent-ships?limit=5'], `ship requests were: ${ships.join(', ') || 'none'}`);
-  assert.ok(calls.rendered.includes('setRecentShips'), 'the small page is handed to the renderer');
+  const reads = calls.requests.filter((r) => r.includes('/me/recent-ships') || r.includes('/leaderboard'));
+  assert.deepEqual(reads, [], `Home still read: ${reads.join(', ')}`);
 });

package/tests/hall_nav.mjs

@@ -905,9 +905,9 @@ test('Accomplishments is gone from the sidebar, and every old link lands on your
   }
   // No view is left for them to open on the index.
   assert.ok(!/id="view-standing"/.test(fs.readFileSync(path.join(HALL, 'index.html'), 'utf8')), 'the view is gone');
-  // Home's Standing card still names the shipped count and links to the profile.
+  // Home's Standing card went in task 1005249: the visor's you-block opens the profile now
+  // (tests/hall_visor_profile.mjs runs it).
   const render = fs.readFileSync(path.join(HALL, 'hall-render.js'), 'utf8');
-  assert.match(render, /View full profile →/);
   assert.ok(!/\$\('#profile-body'\)/.test(render), 'the Accomplishments band is not drawn any more');
   const fn = render.slice(render.indexOf('  function renderProfile(builder) {'), render.indexOf('  function renderSystemNotices('));
   assert.match(fn, /renderSystemNotices\(\{ rebaseTasks, need, actionNeeds, cost \}\)/, 'Home still gets every notice');

package/tests/hall_visor.mjs

@@ -503,9 +503,16 @@ test('the glass is the kit\'s: the cut accent button, ice hints with no box, the
   assert.equal(g.placeShadow, 'none', 'type on a plate needs no halo');
   assert.equal(g.radius, '0px', 'no round thing on the glass');
   assert.match(g.spriteClip, /^polygon\(/, 'the sprite sits in a cut box');
+  // task 1005249: you (left of the foot row) are a link to your profile now, so the
+  // stops run in reading order: you, then the accent button. Both take the inset ring.
+  const focused = () => page.evaluate(() => { const a = document.activeElement; const s = getComputedStyle(a); return { cls: a.className, outline: s.outlineStyle, ring: s.boxShadow }; });
   await page.keyboard.press('Tab');
-  const f = await page.evaluate(() => { const a = document.activeElement; const s = getComputedStyle(a); return { cls: a.className, outline: s.outlineStyle, ring: s.boxShadow }; });
-  assert.equal(f.cls, 'visor__main', 'the accent button is the first stop');
+  const me = await focused();
+  assert.equal(me.cls, 'visor__me', 'you are the first stop, reading left to right');
+  assert.match(me.ring, /inset/, 'you take the inset ring too');
+  await page.keyboard.press('Tab');
+  const f = await focused();
+  assert.equal(f.cls, 'visor__main', 'the accent button is the next stop');
   assert.equal(f.outline, 'none');
   assert.match(f.ring, /inset/, 'focus is the inset two-tone ring (--press-focus)');
   await ctx.close();

package/tests/hall_visor_profile.mjs

@@ -0,0 +1,150 @@
+// tests/hall_visor_profile.mjs — you on the visor (task 1005249).
+//
+// The owner's ask (2026-11-12): the Standing chip that sat top right of Home is gone;
+// the visor's bottom-left you-block shows your details on hover and opens your whole
+// profile, in the game's window over the place, on click. This runs the real visor,
+// the real shell-game window and the real dialog in a browser, plus the pure facts in
+// a vm, and checks Home's page no longer carries the chip.
+//
+// Run:  node --test tests/hall_visor_profile.mjs
+import assert from 'node:assert/strict';
+import { test, after } from 'node:test';
+import { createRequire } from 'node:module';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const HALL = path.join(ROOT, 'modules/hall-ui/public');
+const read = (f) => fs.readFileSync(path.join(HALL, f), 'utf8');
+
+// ---------- the facts, in a vm ----------
+function loadVisor(me) {
+  const doc = {
+    readyState: 'complete', body: null, documentElement: { dataset: {}, classList: { contains: () => false, toggle() {}, remove() {} } },
+    addEventListener() {}, querySelector: () => null, createElement: () => ({}),
+  };
+  const win = { document: doc, location: { pathname: '/', assign() {} }, addEventListener() {}, OTBCraftMode: { me: () => me } };
+  win.window = win;
+  vm.runInNewContext(read('visor.js'), win);
+  return win.OTBVisor;
+}
+
+test('the card\'s facts come from /me: name, handle, rank, credits, karma, preferred work', () => {
+  const me = { builder: { display_name: 'Percy Jackson', github_login: 'percy', rank: 'metic', total_credits: 14441, karma: 96.4, preferred_disciplines: ['artisan', 'ui'] } };
+  const f = JSON.parse(JSON.stringify(loadVisor(me).meFacts(me)));
+  assert.deepEqual(f, { name: 'Percy Jackson', handle: '@percy', rank: 'Metic', credits: 14441, karma: 96, prefs: 'artisan, ui' });
+  const bare = JSON.parse(JSON.stringify(loadVisor(null).meFacts({ builder: { github_login: 'x' } })));
+  assert.equal(bare.name, 'x', 'no display name: the login');
+  assert.equal(bare.karma, 0);
+  assert.equal(bare.prefs, '', 'no preference: empty, and the card says "Not set yet"');
+  assert.equal(loadVisor(null).meFacts(null), null, 'before /me answers there is nothing to show');
+});
+
+test('Home carries no Standing chip any more, and no sheet styles one', () => {
+  assert.doesNotMatch(read('index.html'), /hall-standing|home-standing-body/);
+  assert.doesNotMatch(read('style.css'), /\.hall-standing|\.home-who|\.home-facts/);
+  assert.doesNotMatch(read('hall-render.js'), /home-standing-body|hall-standing|leaderboardPlace/);
+});
+
+// ---------- in a browser ----------
+const lib = require(path.join(ROOT, 'modules', 'ui-design', 'kit', 'lib.js'));
+let browser = null;
+try { browser = await lib.launchBrowser(); } catch (e) { if (!(e instanceof lib.NoBrowserError)) throw e; }
+after(() => browser && browser.close());
+const skip = !browser && 'no system Edge or Chrome';
+
+const ORIGIN = 'http://hall.test';
+const TYPES = { '.js': 'text/javascript', '.css': 'text/css', '.png': 'image/png', '.svg': 'image/svg+xml' };
+const SCENE = `<script>
+  window.OTBCraftMode = { character() { return 'artisan'; }, current() { return null; },
+    me() { return { builder: { display_name: 'Percy Jackson', github_login: 'percy', rank: 'metic', total_credits: 14441, karma: 96, preferred_disciplines: [] } }; },
+    spriteSrc(id) { return '/builders/characters/' + id + '.png'; } };
+  window.__visorScene = { name: 'test', place: 'Test city', actions: [], keys: [] };
+</script>`;
+const PAGE = (withWindow) => `<!doctype html><html data-theme="dark" data-faces="helm"><head><meta charset="utf-8">
+<link rel="stylesheet" href="/builders/style.css"><link rel="stylesheet" href="/builders/visor.css"></head>
+<body>${SCENE}<script src="/builders/hall-dialog.js"></script>${withWindow ? '<script src="/builders/shell-game.js"></script>' : ''}<script src="/builders/visor.js"></script></body></html>`;
+
+async function open({ withWindow = true } = {}) {
+  const ctx = await browser.newContext({ viewport: { width: 1280, height: 800 } });
+  await ctx.route(ORIGIN + '/**', (route) => {
+    const p = new URL(route.request().url()).pathname;
+    if (p === '/') return route.fulfill({ contentType: 'text/html', body: PAGE(withWindow) });
+    if (p === '/profile') return route.fulfill({ contentType: 'text/html', body: '<!doctype html><title>profile</title><p id="pp">your profile</p><script src="/builders/shell-game.js"></script>' }); // the real page carries the game shell, which hands an Escape up
+    const f = path.join(HALL, p.replace(/^\/builders\//, ''));
+    if (p.startsWith('/builders/') && TYPES[path.extname(p)] && fs.existsSync(f)) return route.fulfill({ contentType: TYPES[path.extname(p)], body: fs.readFileSync(f) });
+    return route.fulfill({ status: 404, body: '' });
+  });
+  const page = await ctx.newPage();
+  const errors = [];
+  page.on('pageerror', (e) => errors.push(String(e.message)));
+  await page.addInitScript(() => { try { localStorage.setItem('hall-game', 'on'); document.documentElement.dataset.game = 'on'; window.OTB = { escapeHtml: (s) => String(s) }; } catch (_) { /* none */ } });
+  await page.goto(ORIGIN + '/');
+  await page.waitForFunction(() => !!document.querySelector('.visor__me'));
+  return { ctx, page, errors };
+}
+
+test('hovering you on the visor shows your details; at rest they are hidden', { skip }, async () => {
+  const { ctx, page, errors } = await open();
+  const shown = () => page.evaluate(() => getComputedStyle(document.querySelector('.visor__card')).visibility);
+  assert.equal(await shown(), 'hidden', 'nothing over the scene at rest');
+  await page.hover('.visor__me');
+  await page.waitForFunction(() => getComputedStyle(document.querySelector('.visor__card')).opacity === '1');
+  assert.equal(await shown(), 'visible');
+  const text = await page.evaluate(() => [...document.querySelectorAll('.visor__card > span')].map((s) => s.innerText.replace(/\s+/g, ' ').trim()));
+  assert.match(text[0], /Percy Jackson @percy/i);
+  assert.match(text[1], /Rank Metic/i);
+  assert.match(text[1], /Credits 14,441/i);
+  assert.match(text[1], /Karma 96/i);
+  assert.match(text[1], /Preferred work Not set yet/i);
+  assert.match(text[2], /Open your profile/i);
+  const box = await page.evaluate(() => { const r = document.querySelector('.visor__card').getBoundingClientRect(); return { top: r.top, left: r.left }; });
+  assert.ok(box.top >= 0 && box.left >= 0, 'the card stays on screen');
+  assert.deepEqual(errors, []);
+  await ctx.close();
+});
+
+test('clicking you opens your whole profile in the window over the place; Escape closes it', { skip }, async () => {
+  const { ctx, page, errors } = await open();
+  await page.click('.visor__me');
+  await page.waitForFunction(() => window.OTBOptionsOverlay.isOpen());
+  const w = await page.evaluate(() => ({
+    url: location.pathname,
+    src: document.querySelector('.opt-window__frame').getAttribute('src'),
+    label: document.querySelector('.opt-window__box').getAttribute('aria-label'),
+    close: document.querySelector('.opt-window__x').getAttribute('aria-label'),
+  }));
+  assert.equal(w.url, '/', 'the place stays: no navigation');
+  assert.equal(w.src, '/profile?embed=1');
+  assert.equal(w.label, 'Your profile');
+  assert.equal(w.close, 'Close your profile');
+  // the frame's own shell must be up before an Escape inside it can be handed up
+  await page.waitForFunction(() => { const f = document.querySelector('.opt-window__frame'); try { return !!(f && f.contentDocument.readyState === 'complete' && f.contentDocument.documentElement.dataset.embed === 'on'); } catch (_) { return false; } });
+  await page.keyboard.press('Escape');
+  await page.waitForFunction(() => !window.OTBOptionsOverlay.isOpen());
+  // the same window still opens Options under its own name
+  await page.evaluate(() => window.OTBOptionsOverlay.open(''));
+  assert.equal(await page.evaluate(() => document.querySelector('.opt-window__box').getAttribute('aria-label')), 'Options');
+  assert.equal(await page.evaluate(() => document.querySelector('.opt-window__frame').getAttribute('src')), '/settings?embed=1');
+  assert.deepEqual(errors, []);
+  await ctx.close();
+});
+
+test('with no window to draw, you are still a link to your profile', { skip }, async () => {
+  const { ctx, page, errors } = await open({ withWindow: false });
+  const r = await page.evaluate(() => {
+    const me = document.querySelector('.visor__me');
+    const ev = new MouseEvent('click', { bubbles: true, cancelable: true });
+    // stop the browser before it leaves, once the visor has had its say
+    window.addEventListener('click', (e) => { window.__left = !e.defaultPrevented; e.preventDefault(); });
+    me.querySelector('.visor__name').dispatchEvent(ev);
+    return { href: me.getAttribute('href'), followed: window.__left };
+  });
+  assert.equal(r.href, '/profile');
+  assert.equal(r.followed, true, 'the visor lets the link take you to the profile page');
+  assert.deepEqual(errors, []);
+  await ctx.close();
+});

package/tests/leaderboard_roles.mjs

@@ -16,7 +16,7 @@
 //      that craft earned, and a dash, not a 0, for a builder with no AI sessions.
 //      (Two crafts since task 1005141: the engineer is the artisan, and the
 //      ideator folded into the artist, so idea credits rank as artist credits.)
-//   4. THE STANDING CARD and 5. THE STATUS PAGE: the real functions, run.
+//   5. THE STATUS PAGE: the real function, run. (4, the Standing chip, went in task 1005249.)
 
 import { strict as assert } from 'node:assert';
 import { createRequire } from 'node:module';
@@ -234,7 +234,7 @@ await test('the Artists toggle shows only artists, ranked by the credits that cr
   assert.equal(r.rows.length, FIX.leaderboard.length, 'Everyone brings every builder back');
 });
 
-// ---- 4. the standing card ---------------------------------------------------------
+// ---- 4. (the standing card, gone; extract() serves section 5) ---------------------
 
 function extract(src, start, end) {
   const a = src.indexOf(start);
@@ -243,21 +243,7 @@ function extract(src, start, end) {
   return src.slice(a, b);
 }
 
-await test('the standing card adds the place inside the builder\'s main role, only when it says something new', () => {
-  const src = read('modules/hall-ui/public/hall-render.js');
-  const code = extract(src, 'const lbState = { rows: [] };', '    return { lbState');
-  const sandbox = { rows: FIX.leaderboard };
-  vm.createContext(sandbox);
-  vm.runInContext(`${code}; lbState.rows = rows; this.place = leaderboardPlace; this.text = rolePlaceText;`, sandbox);
-  const art = sandbox.place('builder-7');
-  assert.equal(art.role.craft, 'artist');
-  assert.equal(sandbox.text(art), `#2 as an artist`, 'fourth overall, second among artists: something new, so it is said');
-  const top = sandbox.place(FIX.leaderboard[0].github_login);
-  assert.equal(sandbox.text(top), '', 'the top artisan is #1 either way, so nothing is added');
-  // task 1005054: the stats strip (and its rank tile) left Home; the Standing chip's card carries the role place
-  assert.match(src, /\$\{rolePlaceText\(rollPlace\) \? `<span title="Your place among the/);
-  assert.match(read('modules/hall-ui/public/builders.js'), /getJSON\(`\$\{API\}\/public\/leaderboard`\)/, 'the hall reads the list with the roles');
-});
+// (Its test of the Standing chip's role place went with the chip in task 1005249.)
 
 // ---- 5. the status page -----------------------------------------------------------