@bongos/core 1.24.93 → 1.24.95

package/modules/hall-ui/records/visor.md

@@ -4,7 +4,7 @@ Covers: `visor.js` + `visor.css`, loaded on Home, `/city`, `/goal-map` and `/thi
 
 ## The rule every game page keeps (ADR 0403, owner 2026-11-11)
 
-The visor is the control and the scene is the view: every main call to action in game mode is on the glass (the accent button, the key hints, the Actions sheet), and a scene carries none of its own. A scene that has something to do registers it with `OTBVisor.scene({ actions, keys })`. ADR 0403 §3 lists the scenes that do not keep it yet; the Governor City keeps it since task 1005209 and the sky since task 1005210 (below).
+The visor is the control and the scene is the view: every main call to action in game mode is on the glass (the accent button, the key hints, the Actions sheet), and a scene carries none of its own. A scene that has something to do registers it with `OTBVisor.scene({ actions, keys })`. ADR 0403 §3 lists the scenes that do not keep it yet; the Governor City keeps it since task 1005209 the sky since task 1005210, and Home's gallery since task 1005211 (below).
 
 ## A place's own buttons on the glass (task 1005209, the Governor City first)
 
@@ -20,6 +20,15 @@ The visor is the control and the scene is the view: every main call to action in
 - **A visor fix that came with it.** The sheet had a click listener of its own inside `#visor`'s, so every row ran twice; a toggle row undid itself. The sheet's listener is gone.
 - **Not done:** the tour still spots the pills it explains, which are off the glass in game mode. Tests: `tests/hall_sky_visor.mjs` (both pages' own markup, the real visor and sheets, in a real browser).
 
+## The glass wears your character’s colour (task 1005218, ADR 0405)
+
+The frame’s lines, the sight, your name, the rim of your picture and the accent on the glass (the one button, the segment being built) are the held character’s one colour, and the picture is your character’s head wearing the visor. Where the sections below say the lines are ice or the button is the accent, read "the character’s colour"; for an Artisan the two are the same. The detail is in `characters.md`.
+## Home's gallery on the glass (task 1005211)
+
+- **What left the gallery in game mode** (`home-gallery.css`, under `html.visor-on`): the order tabs (Most popular, Latest), the ways (The full gallery, Your studio), the two arrows and the full-screen button. A work's label, its heart and a piece in the full gallery stay: they are looking at the art, not leaving it.
+- **Where they went.** `home-gallery.js` gives Home its rows (`visorActions()`, and `onChange()` for when they change), each pressing the gallery's own control in its own words: the full gallery (or "Back to the bench") is the lead on G; the two tabs with "· on/off"; Previous work ←, Next work →, Full screen F, which hand the wall the keyboard so its own keys answer next; Your studio. `home-city.js` registers them as Home's scene, and none in a craft whose Home is not the gallery.
+- **Not done:** the attention cards and the Artist's idea box on Home are not the gallery's and still sit on the scene in game mode.
+
 ## The minimal visor (Helm look 3, task 1005195)
 
 The glass was redrawn to the owner's mock-up "Cloud city: in the visor, minimal". Look and layout only: every action, key, id, aria attribute, copy string and data source in `visor.js` is as task 1005148 left it. Where this section and the older bullets below disagree about the look or where a part sits, this section is current.

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.24.93",
+  "version": "1.24.95",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.24.93",
+      "version": "1.24.95",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.24.93",
+  "version": "1.24.95",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -11663,5 +11663,25 @@
       "id": "1005210",
       "text": "In game mode the sky (Goals and Thinking) no longer has buttons of its own: \"Write a thought\" is on the visor (press /), jumping is J, and the lens switch, the pills, the clock and the legend are rows in the visor's Actions li"
     }
+  ],
+  "1.24.94": [
+    {
+      "id": "1005247",
+      "text": "The V3 game plan now records the owner's eight answers from the task cleanup, so new work is written against them."
+    },
+    {
+      "id": "1005211",
+      "text": "In game mode the Artist's Home gallery no longer has tabs, links or arrows of its own: the full gallery is on the visor (press G), and the order tabs, previous/next work, full screen and Your studio are rows in the visor's Act"
+    },
+    {
+      "id": "1005220",
+      "text": "The game's parties now have one agreed design: any group that plays together gets the same voice channel, member list and chat, whether it's a party you form, a quest party or a meeting room."
+    }
+  ],
+  "1.24.95": [
+    {
+      "id": "1005218",
+      "text": "The three characters have a new look: space-faring aliens made of two animals each, drawn at a larger size. Each has its own colour, and in the game the visor now takes your character's colour and shows your character wearing"
+    }
   ]
 }

package/src/module-api.js

@@ -81,7 +81,7 @@ const { sleep } = require('./sleep');
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.24.93'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.24.95'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/src/module-seams.js

@@ -190,6 +190,9 @@ function listEvents() {
 //                         the slices merge into the GET /api/bongos/me payload.
 //                         (The client settings-panel seam is its browser twin,
 //                          window.OTB.contributeSettingsPanel in dom-utils.js.)
+//   • 'room.kinds'      — one plain object per kind of room (party, chain, scoping,
+//                         decision), contributed by the module that owns the group;
+//                         read with contributions('room.kinds'). ADR 0404.
 
 const contributors = new Map(); // point -> [contribution, ...] (registration order)
 

package/tests/character_creation.mjs

@@ -153,7 +153,7 @@ test('a held character is the only one offered, and the top bar wears its sprite
   const sw = t.C.switchHtml();
   assert.match(sw, /craft-switch--character/);
   assert.match(sw, /data-craft-me/);
-  assert.match(sw, /\/builders\/characters\/artisan\.png/);
+  assert.match(sw, /\/builders\/characters\/artisan-face\.png/, 'the chip is the head, its own picture (task 1005218)');
   assert.ok(!/data-craft-opt=/.test(sw), 'the three-way switch is gone');
   // A session's stored mode from before the character cannot override it.
   t.session['hall-craft'] = 'patron';
@@ -162,7 +162,7 @@ test('a held character is the only one offered, and the top bar wears its sprite
 
 test('the sprite is drawn on first paint from the last held character, before /me answers', () => {
   const t = boot({ store: { 'hall-character': 'patron' } });
-  assert.match(t.C.switchHtml(), /\/builders\/characters\/patron\.png/);
+  assert.match(t.C.switchHtml(), /\/builders\/characters\/patron-face\.png/);
 });
 
 test('an older core that says nothing about characters changes nothing', () => {
@@ -187,15 +187,52 @@ test('the character section never writes `hidden` onto the nav: a character only
   assert.ok(!/nav-item|app-sidebar/.test(section), 'the character code does not touch the nav itself; applyNav does');
 });
 
-test('the owner\'s three sprites are on disk, one per character', () => {
+// task 1005218: the second look. Three pictures per character, drawn by
+// docs/design/characters/v2/draw-characters.js --hall: the whole figure (64), the head for
+// the chip (32) and the head wearing the visor for the visor's corner (32).
+test('each character\'s three pictures are on disk, at their sizes', () => {
   for (const id of ['artisan', 'artist', 'patron']) {
-    const f = path.join(HALL, 'characters', id + '.png');
-    assert.ok(fs.existsSync(f), `${id}.png`);
-    const head = fs.readFileSync(f).subarray(0, 8);
-    assert.deepEqual([...head], [0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a], `${id}.png is a PNG`);
+    for (const [part, size] of [['', 64], ['-face', 32], ['-visor', 32]]) {
+      const f = path.join(HALL, 'characters', id + part + '.png');
+      assert.ok(fs.existsSync(f), `${id}${part}.png`);
+      const buf = fs.readFileSync(f);
+      assert.deepEqual([...buf.subarray(0, 8)], [0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a], `${id}${part}.png is a PNG`);
+      assert.deepEqual([buf.readUInt32BE(16), buf.readUInt32BE(20)], [size, size], `${id}${part}.png is ${size} by ${size}`);
+    }
   }
 });
 
+test('the hall\'s pictures are what the drawing script draws: nobody edited one by hand', async () => {
+  const { createRequire } = await import('node:module');
+  const draw = createRequire(import.meta.url)(path.join(ROOT, 'docs/design/characters/v2/draw-characters.js'));
+  const drawn = draw.hallFiles();
+  const onDisk = fs.readdirSync(path.join(HALL, 'characters')).sort();
+  assert.deepEqual(onDisk, Object.keys(drawn).sort(), 'nine files, three per character, and nothing else');
+  // Compared pixel for pixel, not byte for byte: two zlib builds may pack the same picture differently.
+  const zlib = await import('node:zlib');
+  const pixels = (png) => {
+    const parts = [];
+    for (let at = 8; at < png.length;) {
+      const len = png.readUInt32BE(at), type = png.toString('latin1', at + 4, at + 8);
+      if (type === 'IDAT') parts.push(png.subarray(at + 8, at + 8 + len));
+      at += 12 + len;
+    }
+    return zlib.inflateSync(Buffer.concat(parts));
+  };
+  for (const [name, buf] of Object.entries(drawn)) {
+    assert.ok(pixels(buf).equals(pixels(fs.readFileSync(path.join(HALL, 'characters', name)))), name + ' is stale or hand-edited: run node docs/design/characters/v2/draw-characters.js --hall');
+  }
+});
+
+test('the three characters\' colours are mixed from the hall\'s tokens, never typed in (ADR 0405)', () => {
+  const css = fs.readFileSync(path.join(HALL, 'style.css'), 'utf8');
+  const block = css.slice(css.indexOf('--char-artisan:'), css.indexOf('--char-patron:') + 120);
+  assert.match(block, /--char-artisan: var\(--accent\);/);
+  assert.match(block, /--char-artist: color-mix\(/);
+  assert.match(block, /--char-patron: color-mix\(/);
+  assert.ok(!/#[0-9a-fA-F]{3,8}/.test(block), 'no literal colour');
+});
+
 // ---------- the server half ----------
 test('core_297 adds the account column, and the CHECK names exactly the three characters', () => {
   const sql = fs.readFileSync(path.join(ROOT, 'migrations/core_297_builder_character.sql'), 'utf8');

package/tests/hall_visor.mjs

@@ -179,7 +179,7 @@ const SCENE = `<script>
   cv.addEventListener('pointerup', () => { drag = null; });
   addEventListener('keydown', (e) => { if (e.key === 'Escape' && window.picked) { e.preventDefault(); window.picked = false; } });
   window.OTBCraftMode = { held: 'artisan', character() { return this.held; }, current() { return null; },
-    me() { return { builder: { total_credits: 56021 } }; }, spriteSrc(id) { return '/builders/characters/' + id + '.png'; }, openTool(id) { window.toolOpened = id; } };
+    me() { return { builder: { total_credits: 56021 } }; }, spriteSrc(id) { return '/builders/characters/' + id + '.png'; }, portraitSrc(id) { return '/builders/characters/' + id + '-visor.png'; }, openTool(id) { window.toolOpened = id; } };
   window.__visorScene = { name: 'test', place: 'Test city', actions: [{ label: 'Back to centre', key: '0', run() { window.centred = true; } }], keys: [{ label: 'Look around', key: 'drag' }] };
 </script>`;
 // `helm` links the hall's real sheet (the token tier) instead of the stand-in colours.
@@ -240,7 +240,7 @@ test('in game mode the glass shows the place, the main action, the key hints, th
   // task 1005195: every other control is a quiet key hint. Actions kept its key and its sheet; nothing was dropped.
   assert.deepEqual(g.hints, ['TYour thinking', 'AActions', 'EscOptions']);
   assert.equal(g.arcs, 2, 'two arcs frame the glass');
-  assert.equal(g.sprite, '/builders/characters/artisan.png');
+  assert.equal(g.sprite, '/builders/characters/artisan-visor.png', 'your picture on the glass is you wearing the visor (task 1005218)');
   assert.deepEqual(errors, []);
   await ctx.close();
 });
@@ -366,6 +366,32 @@ for (const [width, height] of [[1440, 900], [390, 844], [320, 640]]) {
   });
 }
 
+// task 1005218 (ADR 0405): each character has one colour, and the glass wears the held one.
+test('the glass wears the held character\'s colour: the Artisan\'s is the accent, the Artist\'s and the Patron\'s are their own', { skip }, async () => {
+  const { ctx, page } = await open({ helm: true });
+  const g = await page.evaluate(() => {
+    const probe = (v) => { const d = document.createElement('i'); d.style.color = v; document.body.appendChild(d); const c = getComputedStyle(d).color; d.remove(); return c; };
+    const out = { accent: probe('var(--accent)') };
+    for (const id of ['artisan', 'artist', 'patron']) {
+      window.OTBCraftMode.held = id; window.OTBVisor.render();
+      const cs = (s) => getComputedStyle(document.querySelector(s));
+      out[id] = { char: probe('var(--char-' + id + ')'), main: cs('.visor__main').backgroundColor, name: cs('.visor__name').color,
+        line: cs('.visor__line:not(.visor__line--under)').stroke, rim: cs('.visor__sprite').borderTopColor, src: document.querySelector('.visor__sprite').getAttribute('src') };
+    }
+    return out;
+  });
+  assert.equal(g.artisan.main, g.accent, 'an Artisan\'s glass is the accent it always was');
+  for (const id of ['artisan', 'artist', 'patron']) {
+    assert.equal(g[id].main, g[id].char, id + ': the one button is the character\'s colour');
+    assert.equal(g[id].name, g[id].char, id + ': so is the name');
+    assert.equal(g[id].line, g[id].char, id + ': and the frame\'s lines');
+    assert.equal(g[id].rim, g[id].char, id + ': and the rim of the picture');
+    assert.equal(g[id].src, '/builders/characters/' + id + '-visor.png');
+  }
+  assert.equal(new Set([g.artisan.char, g.artist.char, g.patron.char]).size, 3, 'three characters, three colours');
+  await ctx.close();
+});
+
 test('the glass is the kit\'s: the cut accent button, ice hints with no box, the name voice, the inset focus ring', { skip }, async () => {
   const { ctx, page } = await open({ helm: true, width: 1440, height: 900 });
   const g = await page.evaluate(() => {

package/tests/home_gallery_widget.mjs

@@ -218,3 +218,46 @@ test('Home is the gallery only in Artist: the city\'s widget switches on the cra
   assert.equal(art.hidden, false);
   assert.notEqual(back, 'none', 'and comes back in another craft');
 });
+
+// ---- task 1005211 (ADR 0403): in game mode the gallery's controls are the visor's ----
+test("the gallery's rows for the visor: each in its control's own words, each pressing that control", { skip }, async () => {
+  const { ctx, page } = await boot();
+  const rows = () => page.evaluate(() => window.__g.visorActions().map((a) => [a.label, a.key || '', !!a.lead, !!a.bind]));
+  assert.deepEqual(await rows(), [
+    ['The full gallery', 'g', true, true], ['Most popular · on', '', false, false], ['Latest · off', '', false, false],
+    ['Previous work', '←', false, false], ['Next work', '→', false, false], ['Full screen', 'F', false, false], ['Your studio', '', false, false],
+  ], 'the full gallery is the lead, on G; the wall keeps its own arrow keys and F');
+  await page.evaluate(() => { window.__changes = 0; window.__g.onChange(() => { window.__changes += 1; }); });
+  await page.evaluate(() => window.__g.visorActions().find((a) => a.label === 'Next work').run());
+  assert.equal((await state(page)).count, `2 of ${N}`);
+  assert.equal(await page.evaluate(() => document.activeElement.className), 'hg-room', 'a row hands the wall the keyboard, so the arrows answer next');
+  await page.keyboard.press('ArrowRight');
+  assert.equal((await state(page)).count, `3 of ${N}`);
+  await page.evaluate(() => window.__g.visorActions()[0].run());
+  assert.deepEqual((await rows()).map((r) => r[0]), ['Back to the bench', 'Most popular · on', 'Latest · off', 'Your studio'], 'in the full gallery there is no wall to walk');
+  assert.ok(await page.evaluate(() => window.__changes) >= 1, 'Home is told the rows changed');
+  await page.evaluate(() => window.__g.visorActions().find((a) => a.label === 'Latest · off').run());
+  await page.waitForFunction(() => window.__g.visorActions().some((a) => a.label === 'Latest · on'));
+  await ctx.close();
+});
+
+test('game mode: the tabs, the ways, the arrows and full screen leave the wall; classic mode keeps them', { skip }, async () => {
+  const { ctx, page } = await boot();
+  const shown = () => page.evaluate(() => ['.hg-sort', '.hg-ways', '.hg-prev', '.hg-next', '.hg-fsbtn'].map((s) => getComputedStyle(document.querySelector(s)).display !== 'none'));
+  assert.deepEqual(await shown(), [true, true, true, true, true], 'classic');
+  await page.evaluate(() => document.documentElement.classList.add('visor-on'));
+  assert.deepEqual(await shown(), [false, false, false, false, false], 'with the visor up');
+  assert.ok(await page.evaluate(() => getComputedStyle(document.querySelector('.hg-heart')).display !== 'none'), 'a heart is the work\'s, and stays');
+  await ctx.close();
+});
+
+test('Home registers the gallery\'s rows as its scene in Artist, and none in another craft', { skip }, async () => {
+  const { ctx, page } = await boot({ city: true });
+  await page.evaluate(() => { window.__scenes = []; window.OTBVisor = { scene: (s) => window.__scenes.push(s) }; window.__widget.mount(document.getElementById('home-city')); });
+  await page.waitForFunction(() => document.querySelectorAll('.hc-rung').length > 0);
+  assert.deepEqual(await page.evaluate(() => window.__visorScene.actions.length), 0, 'the builder\'s Home: no gallery rows');
+  await page.evaluate(() => { document.documentElement.dataset.craft = 'artist'; document.dispatchEvent(new CustomEvent('otb:craft', { detail: { mode: 'artist' } })); });
+  await page.waitForFunction(() => window.__visorScene.actions.length > 0 && window.__visorScene.actions[0].label === 'The full gallery');
+  assert.equal(await page.evaluate(() => window.__visorScene.place), 'Home');
+  await ctx.close();
+});

package/tests/room_kinds_seam.mjs

@@ -0,0 +1,68 @@
+// tests/room_kinds_seam.mjs — ADR 0404 (task 1005220): rooms register as kinds
+// through the 'room.kinds' CONTRIBUTION POINT, because several modules own a kind
+// (lifecycle: party, chain, scoping; government: decision) and a port is
+// single-provider. Pins that choice: two kinds from two modules register side by
+// side and the boot check still passes, while the same pair as a port is refused.
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { createRequire } from 'node:module';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const seams = require(path.join(ROOT, 'src', 'module-seams.js'));
+
+function kind(name, owner, members) {
+  return {
+    kind: name,
+    owner,
+    cap: name === 'party' ? 8 : 40,
+    members: async () => members,
+    isMember: async (_roomId, builderId) => members.some((m) => m.builderId === builderId),
+  };
+}
+
+test('two kinds from two modules both register, and the boot check passes', async () => {
+  seams._reset();
+  seams.contribute('room.kinds', kind('scoping', 'lifecycle', [{ builderId: 1, joinedAt: 't' }]));
+  seams.contribute('room.kinds', kind('decision', 'government', [{ builderId: 2, joinedAt: 't' }]));
+
+  const kinds = seams.contributions('room.kinds');
+  assert.deepEqual(kinds.map((k) => k.kind), ['scoping', 'decision']);
+  assert.deepEqual(kinds.map((k) => k.owner), ['lifecycle', 'government']);
+
+  // a consumer finds a kind by name and calls it — it never reads the owner's tables
+  const decision = kinds.find((k) => k.kind === 'decision');
+  assert.equal(await decision.isMember('r1', 2), true);
+  assert.equal(await decision.isMember('r1', 1), false);
+
+  // the modules' manifests declare no port for rooms, so the boot check is clean
+  const manifests = [
+    { key: 'lifecycle', provides: [], consumes: [] },
+    { key: 'government', provides: [], consumes: [] },
+  ];
+  assert.deepEqual(seams.verifyPortsSatisfied(manifests), { ok: true, errors: [] });
+  seams._reset();
+});
+
+test('the rejected design: the same pair as one port is refused at boot and at registration', () => {
+  seams._reset();
+  const manifests = [
+    { key: 'lifecycle', provides: ['room.members'], consumes: [] },
+    { key: 'government', provides: ['room.members'], consumes: [] },
+  ];
+  const res = seams.verifyPortsSatisfied(manifests);
+  assert.equal(res.ok, false);
+  assert.match(res.errors.join('\n'), /room\.members.*more than one enabled module/);
+
+  seams.registerProvider('room.members', async () => []);
+  assert.throws(() => seams.registerProvider('room.members', async () => []));
+  seams._reset();
+});
+
+test('an instance with no room owners has no rooms, and nothing throws', () => {
+  seams._reset();
+  assert.deepEqual(seams.contributions('room.kinds'), []);
+  seams._reset();
+});