@bongos/core 1.24.89 → 1.24.91

package/modules/hall-ui/public/craft-mode.js

@@ -1063,6 +1063,8 @@
     spriteSrc: spriteSrc,
     // task 1005148: the visor's two reads — the /me the gate saw, and a tool by id.
     me: function () { return lastMe; },
-    openTool: function (id) { var t = toolFor(id); if (t) loadTool(t).then(function (api) { api.open(); }, function () { /* tool did not load */ }); },
+    // A tool opens only for the character whose tool it is (task 1005207): the
+    // review sheet is the Artist's, so no other character can open it this way.
+    openTool: function (id) { var t = toolFor(id); if (t && toolsFor(wearing()).indexOf(t) !== -1) loadTool(t).then(function (api) { api.open(); }, function () { /* tool did not load */ }); },
   };
 })();

package/modules/hall-ui/public/page-notes.css

@@ -58,6 +58,10 @@ html.pn-open { overflow: hidden; }
   box-shadow: 0 0 0 1px var(--craft, var(--rule)), var(--pn-shadow-pop);
   cursor: pointer;
 }
+/* Game mode (task 1005207): the glass shows only the visor, so the parked tab
+   is not drawn. The visor's "Review this page" (R) opens the sheet, and closing
+   it leaves nothing at the edge. Classic mode keeps the tab. */
+html[data-game="on"] .pn__tab { display: none; }
 .pn__tab:hover { background: var(--pn-glass); }
 .pn__tab:focus-visible { outline: 2px solid var(--focus); outline-offset: 1px; }
 .pn__tab-icon { width: 18px; height: 18px; }

package/modules/hall-ui/public/page-notes.js

@@ -361,7 +361,13 @@
     if (tab) {
       tab.setAttribute('aria-expanded', on ? 'false' : 'true');
       tab.setAttribute('aria-label', on ? 'Show the review panel' : 'Hide the review panel');
-      if (on && !quiet) tab.focus();
+      // In game mode the tab is not drawn (page-notes.css, task 1005207), so focus
+      // leaves the tucked panel for the page instead of a tab nobody can see.
+      if (on && !quiet) {
+        if (tab.getClientRects && tab.getClientRects().length === 0) {
+          if (sheet.contains(document.activeElement) && document.activeElement.blur) document.activeElement.blur();
+        } else tab.focus();
+      }
     }
     if (on) save();
     else if (state.pending) { state.pending = false; openDraft(); }

package/modules/hall-ui/public/shell-game.css

@@ -63,14 +63,15 @@ html.gs-open { overflow: hidden; }
 /* the ring sits inside the row: the focus colour on the edge, a band of the night inside it, so
    one of the two reads on the accent bar as well as on the panel */
 .gs__item:focus-visible { outline: 0; border-radius: var(--press-radius); box-shadow: var(--press-focus); }
-/* Start is the one thing lit: the accent bar under its dark ink, with the key that takes it */
-.gs__item[data-gs="start"] {
+/* One thing is lit: Start on the menu, the view Enter takes on the chooser (task 1005206).
+   The accent bar under its dark ink, with the key that takes it */
+.gs__item[data-gs="start"], .gs__item--lit {
   background: var(--accent); color: var(--accent-on); border-bottom-color: transparent;
   font-weight: var(--name-weight-lit); box-shadow: var(--accent-glow);
 }
-.gs__item[data-gs="start"]:hover { background: var(--accent-lift); color: var(--accent-on); }
-.gs__item[data-gs="start"]:focus-visible { box-shadow: var(--press-focus), var(--accent-glow); }
-.gs__item[data-gs="start"]::after {
+.gs__item[data-gs="start"]:hover, .gs__item--lit:hover { background: var(--accent-lift); color: var(--accent-on); }
+.gs__item[data-gs="start"]:focus-visible, .gs__item--lit:focus-visible { box-shadow: var(--press-focus), var(--accent-glow); }
+.gs__item[data-gs="start"]::after, .gs__item--lit::after {
   content: "Enter"; padding: 0 var(--ds-space-hair);
   border: var(--line-strong) solid currentColor;
   font-size: var(--ds-text-md); letter-spacing: var(--label-space);
@@ -85,16 +86,25 @@ html.gs-open { overflow: hidden; }
 .gs__foot { padding: var(--ds-space-md) var(--ds-space-lg) 0; border-top: var(--line-strong) solid var(--rule); }
 .gs__line, .gs__note { margin: 0; font-size: var(--ds-text-lg); line-height: 1.5; text-wrap: pretty; color: var(--ink-soft); }
 .gs__note { margin-top: var(--ds-space-xs); color: var(--ink); }
-/* the view chooser in front of the menu (task 1005200): Game or Classic as two rows in the
-   panel's own voice, each with one line saying what it is; the view chosen last time is lit
-   with the accent on its edge and says so */
-.gs__ask { margin: 0; padding: 0 var(--ds-space-lg) var(--ds-space-sm); font-size: var(--ds-text-lg); color: var(--ink-soft); }
+/* the view chooser in front of the menu (task 1005200), in the start menu's own shape (task
+   1005206, the Helm start-screen mock-up): Game or Classic as two rows, each with one line
+   saying what it is. The view Enter takes (last time's, else Game) is the accent bar with its
+   key, as Start is; the other is a quiet row on a hairline. Last time's says so. */
+.gs__ask {
+  margin: 0; padding: 0 var(--ds-space-lg) var(--ds-space-sm);
+  font-family: var(--name-face); font-size: var(--label-size); font-weight: var(--name-weight);
+  letter-spacing: var(--label-space); text-transform: var(--name-case); color: var(--ink-soft);
+}
 .gs__ask[hidden] { display: none; }
-.gs__item--view { flex-direction: column; align-items: flex-start; justify-content: center; gap: var(--ds-space-hair); padding-top: var(--ds-space-sm); padding-bottom: var(--ds-space-sm); }
-.gs__item--last { box-shadow: inset var(--line-strong) 0 0 var(--accent); }
+.gs__item--view {
+  position: relative; flex-direction: column; align-items: flex-start; justify-content: center;
+  gap: var(--ds-space-hair); padding-top: var(--ds-space-sm); padding-bottom: var(--ds-space-sm);
+}
+.gs__item--view.gs__item--lit::after { position: absolute; right: var(--ds-space-md); top: 50%; transform: translateY(-50%); }
 .gs__view { display: inline-flex; align-items: baseline; gap: var(--ds-space-sm); }
-.gs__sub { font-family: var(--font-body); font-size: var(--ds-text-md); letter-spacing: 0; text-transform: none; color: var(--ink-soft); }
-.gs__last { font-family: var(--font-body); font-size: var(--label-size); letter-spacing: var(--label-space); text-transform: uppercase; color: var(--accent); }
+.gs__sub { font-family: var(--font-body); font-size: var(--ds-text-md); font-weight: 400; letter-spacing: 0; text-transform: none; color: var(--ink-soft); }
+.gs__last { font-family: var(--font-body); font-size: var(--label-size); font-weight: 400; letter-spacing: var(--label-space); text-transform: uppercase; color: var(--accent); }
+.gs__item--lit .gs__sub, .gs__item--lit .gs__last { color: var(--accent-on); }
 .gs__note[hidden] { display: none; }
 
 /* the load screen: the week it is showing, a segment per week, the city, and the tip under it */

package/modules/hall-ui/public/shell-game.js

@@ -134,15 +134,16 @@
     return '<li><button type="button"' + inner + (m.id === 'extras' ? ' aria-expanded="false" aria-controls="gs-extras"' : '') + '>' + esc(m.label) + '</button></li>';
   }
   // The chooser in front of the start screen (task 1005200): game or classic, the view
-  // chosen last time marked and focused, so Enter keeps it.
+  // chosen last time marked and focused, so Enter keeps it. In the Helm look (task 1005206) the
+  // view Enter takes is the lit row, as Start is on the menu: last time's, else Game.
   var VIEWS = [
     { id: 'game', label: 'Game', sub: 'The city, full screen' },
     { id: 'classic', label: 'Classic', sub: 'The hall with its sidebar' },
   ];
   function lastView() { var v = read('localStorage', KEY); return v === 'on' ? 'game' : v === 'off' ? 'classic' : null; }
   function viewHtml(v) {
-    var last = lastView() === v.id;
-    return '<li><button type="button" class="gs__item gs__item--view' + (last ? ' gs__item--last' : '') + '" data-gs="view-' + v.id + '">' +
+    var last = lastView() === v.id, lit = (lastView() || 'game') === v.id;
+    return '<li><button type="button" class="gs__item gs__item--view' + (lit ? ' gs__item--lit' : '') + (last ? ' gs__item--last' : '') + '" data-gs="view-' + v.id + '">' +
       '<span class="gs__view">' + esc(v.label) + (last ? '<span class="gs__last">Last time</span>' : '') + '</span>' +
       '<span class="gs__sub">' + esc(v.sub) + '</span></button></li>';
   }
@@ -360,7 +361,7 @@
     document.addEventListener('keydown', onKey, true);
     document.body.appendChild(root);
     document.documentElement.classList.add('gs-open');
-    var first = root.querySelector('.gs__item--last') || root.querySelector('.gs__item');
+    var first = root.querySelector('.gs__item--lit') || root.querySelector('.gs__item');
     if (first && first.focus) first.focus();
     return true;
   }

package/modules/hall-ui/records/start-screen.md

@@ -27,3 +27,5 @@ Tests: `tests/hall_start_screen.mjs` (the hand-off and pure parts in a vm; both
 ## The view chooser (task 1005200, owner 2026-11-11)
 
 Every sign-in now opens on a chooser before the start screen: **Game** or **Classic**, each with one line saying what it is. The view chosen last time (the browser's `hall-game` copy) is marked "Last time", lit with the accent on its edge, and focused, so Enter keeps it. Game goes on to the start screen as before; Classic closes the screen and the hall is as it always was. Either choice is saved to the account (`PATCH /api/bongos/me/hall-view`). The Extras list lost The docs: it is not a game place. Tests: `tests/hall_start_screen.mjs`.
+
+**In the start menu's shape (task 1005206, owner 2026-11-11, from the V3 Helm start-screen mock-up).** The chooser is drawn like the menu it leads to: "How do you want to see it?" is a small label in the name voice, and the view Enter takes (last time's, else Game) is the accent bar with its "Enter" key, exactly as Start is (`.gs__item--lit` shares Start's rules); the other view is a quiet row on a hairline. Each row keeps its one line; on the lit bar the line and the "Last time" tag take `--accent-on`. Focus starts on the lit row.

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.24.89",
+  "version": "1.24.91",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.24.89",
+      "version": "1.24.91",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.24.89",
+  "version": "1.24.91",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -11637,5 +11637,17 @@
       "id": "1005203",
       "text": "In the game, the visor now shows four small bars for how much of the current version is built, and every main button in the game now belongs on the visor."
     }
+  ],
+  "1.24.90": [
+    {
+      "id": "1005207",
+      "text": "In the game view the Artist's feedback tab no longer sits on the screen; the Artist opens the feedback sheet from the visor, and only the Artist can open it."
+    }
+  ],
+  "1.24.91": [
+    {
+      "id": "1005206",
+      "text": "The screen you land on after signing in, where you pick Game or Classic, now looks like the V3 game start menu: your usual choice is the bright salmon bar with its Enter key, the other a quiet row."
+    }
   ]
 }

package/src/module-api.js

@@ -81,7 +81,7 @@ const { sleep } = require('./sleep');
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.24.89'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.24.91'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/hall_game_review_tab.mjs

@@ -0,0 +1,86 @@
+// tests/hall_game_review_tab.mjs — no parked review tab on the game's glass (task 1005207).
+//
+// Game mode (html[data-game="on"]) shows only the visor, so the Artist's docked review
+// sheet (page-notes.js + page-notes.css) draws no tab at the right edge. The visor's
+// "Review this page" (R) still opens the sheet, and closing it leaves nothing behind.
+// Classic mode keeps the tab exactly as it was. Driven in a real browser over the
+// REAL page-notes.js and the hall's real sheets.
+import assert from 'node:assert/strict';
+import { test, after } from 'node:test';
+import { createRequire } from 'node:module';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const HALL = path.join(ROOT, 'modules/hall-ui/public');
+
+const lib = require(path.join(ROOT, 'modules', 'ui-design', 'kit', 'lib.js'));
+let browser = null;
+try { browser = await lib.launchBrowser(); } catch (e) { if (!(e instanceof lib.NoBrowserError)) throw e; }
+after(() => browser && browser.close());
+const skip = !browser && 'no system Edge or Chrome';
+
+const ORIGIN = 'http://hall.test';
+const TYPES = { '.js': 'text/javascript', '.css': 'text/css' };
+const PAGE = (game) => `<!doctype html><html data-theme="dark"${game ? ' data-game="on"' : ''}><head><meta charset="utf-8">
+<link rel="stylesheet" href="/builders/style.css"></head>
+<body data-page="home"><button id="before">page</button>
+<script>window.OTB = { escapeHtml: (s) => String(s == null ? '' : s).replace(/[&<>"']/g, (c) => '&#' + c.charCodeAt(0) + ';') };</script>
+<script src="/builders/page-notes.js"></script></body></html>`;
+
+async function open(game) {
+  const ctx = await browser.newContext({ viewport: { width: 1280, height: 800 } });
+  await ctx.route(ORIGIN + '/**', (route) => {
+    const p = new URL(route.request().url()).pathname;
+    if (p === '/') return route.fulfill({ contentType: 'text/html', body: PAGE(game) });
+    // The sheet's reads: an empty draft and an empty list are enough to draw it.
+    if (p.startsWith('/api/bongos/page-notes')) return route.fulfill({ contentType: 'application/json', body: JSON.stringify({ note: { id: 1, body_md: '', status: 'draft' }, images: [], notes: [] }) });
+    const f = path.join(HALL, p.replace(/^\/builders\//, ''));
+    if (p.startsWith('/builders/') && TYPES[path.extname(p)] && fs.existsSync(f)) return route.fulfill({ contentType: TYPES[path.extname(p)], body: fs.readFileSync(f) });
+    return route.fulfill({ status: 404, body: '' });
+  });
+  const page = await ctx.newPage();
+  const errors = [];
+  page.on('pageerror', (e) => errors.push(String(e.message)));
+  await page.goto(ORIGIN + '/');
+  await page.waitForFunction(() => !!window.OTBPageNotes);
+  // What craft-mode.js does for the Artist: dock the sheet, tucked away behind its tab.
+  await page.evaluate(() => window.OTBPageNotes.dock());
+  return { ctx, page, errors };
+}
+const tabShown = (page) => page.evaluate(() => {
+  const t = document.querySelector('#page-notes .pn__tab');
+  return !!t && getComputedStyle(t).display !== 'none' && t.getClientRects().length > 0;
+});
+const panelShown = (page) => page.evaluate(() => getComputedStyle(document.querySelector('#page-notes .pn__panel')).visibility !== 'hidden'
+  && !document.getElementById('page-notes').classList.contains('pn--collapsed'));
+
+test('classic mode keeps the parked tab at the right edge', { skip }, async () => {
+  const { ctx, page, errors } = await open(false);
+  assert.equal(await tabShown(page), true);
+  assert.deepEqual(errors, []);
+  await ctx.close();
+});
+
+test('game mode: no parked tab; R opens the sheet, and closing leaves nothing at the edge', { skip }, async () => {
+  const { ctx, page, errors } = await open(true);
+  assert.equal(await tabShown(page), false, 'parked, nothing shows on the glass');
+  await page.waitForTimeout(350); // the slide-out
+  assert.equal(await panelShown(page), false);
+  // The visor's "Review this page" is OTBCraftMode.openTool('palette') → OTBPageNotes.open().
+  await page.evaluate(() => window.OTBPageNotes.open());
+  assert.equal(await panelShown(page), true, 'R still opens the sheet');
+  assert.equal(await tabShown(page), false, 'open, still no tab beside it');
+  await page.click('#page-notes [data-pn-close]');
+  await page.waitForTimeout(350);
+  assert.equal(await panelShown(page), false, 'closed, the sheet is gone');
+  assert.equal(await tabShown(page), false, 'and no tab is left behind');
+  assert.equal(await page.evaluate(() => document.getElementById('page-notes').contains(document.activeElement)), false,
+    'focus leaves the tucked sheet instead of landing on a tab nobody can see');
+  await page.evaluate(() => window.OTBPageNotes.open());
+  assert.equal(await panelShown(page), true, 'and R opens it again');
+  assert.deepEqual(errors, []);
+  await ctx.close();
+});

package/tests/hall_start_screen.mjs

@@ -128,7 +128,7 @@ test('Home loads the sheet and the script, and the sheet types in no size, corne
   assert.match(css, /\.gs__title \{[^}]*font-family: var\(--name-face\);[^}]*letter-spacing: var\(--name-space-wide\); text-transform: var\(--name-case\);/, 'the title is the name voice');
   assert.match(css, /\.gs__item \{[^}]*font-family: var\(--name-face\);[^}]*text-transform: var\(--name-case\);/, 'so is every choice');
   assert.match(css, /\.gs__menu, \.gs__load \{[^}]*background: var\(--night-glass\);/, 'both panels are the night over the art');
-  assert.match(css, /\.gs__item\[data-gs="start"\] \{\s*background: var\(--accent\); color: var\(--accent-on\);/, 'Start is the one thing lit, under the dark ink');
+  assert.match(css, /\.gs__item\[data-gs="start"\], \.gs__item--lit \{\s*background: var\(--accent\); color: var\(--accent-on\);/, 'Start, and on the chooser the view Enter takes, is the one thing lit, under the dark ink (task 1005206)');
   assert.match(css, /\.gs__item:focus-visible \{[^}]*box-shadow: var\(--press-focus\);/, 'a row rings inside itself, in two tones');
 });
 
@@ -278,6 +278,7 @@ test('choosing Classic at sign-in closes the screen, leaves game mode off, and s
   await page.evaluate(() => { const me = { authed: true, rank: 'metic', builder: { id: 7, display_name: 'Ada', github_login: 'ada' } }; window.OTBShell.applyAccess(me); window.OTBShell.applyAccess(me); });
   await page.waitForSelector('#game-start');
   assert.equal(await page.evaluate(() => document.activeElement.textContent), 'ClassicLast timeThe hall with its sidebar', 'the view chosen last time is focused and marked');
+  assert.deepEqual(await page.evaluate(() => [...document.querySelectorAll('.gs__item--lit')].map((e) => e.dataset.gs)), ['view-classic'], 'and it is the lit bar, the only one (task 1005206)');
   await page.keyboard.press('Enter');
   await page.waitForSelector('#game-start', { state: 'detached' });
   assert.equal((await state(page)).game, null);

package/tests/page_notes_panel.mjs

@@ -95,6 +95,26 @@ test('THE PANEL: docked at the edge in Artist alone, with no top-bar button, and
   assert.deepEqual(none.loaded, [], 'and nothing loads');
 });
 
+test('the review sheet is the Artist\'s alone: openTool (the visor\'s R) opens it for no other character (task 1005207)', async () => {
+  const a = boot({ session: { 'hall-craft': 'artist' } });
+  await flush();
+  a.craft.openTool('palette');
+  await flush();
+  assert.deepEqual(a.opened, ['dock', 'open'], 'the Artist opens it');
+  for (const m of ['artisan', 'patron']) {
+    const p = boot({ session: { 'hall-craft': m } });
+    await flush();
+    p.craft.openTool('palette');
+    await flush();
+    assert.deepEqual(p.opened, [], `${m}: nothing opens`);
+    assert.deepEqual(p.loaded, [], `${m}: the sheet's script never loads`);
+  }
+  const none = boot();
+  none.craft.openTool('palette');
+  await flush();
+  assert.deepEqual(none.opened, [], 'with no character, nothing opens');
+});
+
 test('a screen in the options menu frame docks no second panel: the menu around it has one', async () => {
   const p = boot({ session: { 'hall-craft': 'artist' }, embedded: true });
   await flush();