@bongos/core 1.24.89 → 1.24.90

package/modules/hall-ui/public/craft-mode.js

@@ -1063,6 +1063,8 @@
     spriteSrc: spriteSrc,
     // task 1005148: the visor's two reads — the /me the gate saw, and a tool by id.
     me: function () { return lastMe; },
-    openTool: function (id) { var t = toolFor(id); if (t) loadTool(t).then(function (api) { api.open(); }, function () { /* tool did not load */ }); },
+    // A tool opens only for the character whose tool it is (task 1005207): the
+    // review sheet is the Artist's, so no other character can open it this way.
+    openTool: function (id) { var t = toolFor(id); if (t && toolsFor(wearing()).indexOf(t) !== -1) loadTool(t).then(function (api) { api.open(); }, function () { /* tool did not load */ }); },
   };
 })();

package/modules/hall-ui/public/page-notes.css

@@ -58,6 +58,10 @@ html.pn-open { overflow: hidden; }
   box-shadow: 0 0 0 1px var(--craft, var(--rule)), var(--pn-shadow-pop);
   cursor: pointer;
 }
+/* Game mode (task 1005207): the glass shows only the visor, so the parked tab
+   is not drawn. The visor's "Review this page" (R) opens the sheet, and closing
+   it leaves nothing at the edge. Classic mode keeps the tab. */
+html[data-game="on"] .pn__tab { display: none; }
 .pn__tab:hover { background: var(--pn-glass); }
 .pn__tab:focus-visible { outline: 2px solid var(--focus); outline-offset: 1px; }
 .pn__tab-icon { width: 18px; height: 18px; }

package/modules/hall-ui/public/page-notes.js

@@ -361,7 +361,13 @@
     if (tab) {
       tab.setAttribute('aria-expanded', on ? 'false' : 'true');
       tab.setAttribute('aria-label', on ? 'Show the review panel' : 'Hide the review panel');
-      if (on && !quiet) tab.focus();
+      // In game mode the tab is not drawn (page-notes.css, task 1005207), so focus
+      // leaves the tucked panel for the page instead of a tab nobody can see.
+      if (on && !quiet) {
+        if (tab.getClientRects && tab.getClientRects().length === 0) {
+          if (sheet.contains(document.activeElement) && document.activeElement.blur) document.activeElement.blur();
+        } else tab.focus();
+      }
     }
     if (on) save();
     else if (state.pending) { state.pending = false; openDraft(); }

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.24.89",
+  "version": "1.24.90",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.24.89",
+      "version": "1.24.90",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.24.89",
+  "version": "1.24.90",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -11637,5 +11637,11 @@
       "id": "1005203",
       "text": "In the game, the visor now shows four small bars for how much of the current version is built, and every main button in the game now belongs on the visor."
     }
+  ],
+  "1.24.90": [
+    {
+      "id": "1005207",
+      "text": "In the game view the Artist's feedback tab no longer sits on the screen; the Artist opens the feedback sheet from the visor, and only the Artist can open it."
+    }
   ]
 }

package/src/module-api.js

@@ -81,7 +81,7 @@ const { sleep } = require('./sleep');
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.24.89'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.24.90'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/hall_game_review_tab.mjs

@@ -0,0 +1,86 @@
+// tests/hall_game_review_tab.mjs — no parked review tab on the game's glass (task 1005207).
+//
+// Game mode (html[data-game="on"]) shows only the visor, so the Artist's docked review
+// sheet (page-notes.js + page-notes.css) draws no tab at the right edge. The visor's
+// "Review this page" (R) still opens the sheet, and closing it leaves nothing behind.
+// Classic mode keeps the tab exactly as it was. Driven in a real browser over the
+// REAL page-notes.js and the hall's real sheets.
+import assert from 'node:assert/strict';
+import { test, after } from 'node:test';
+import { createRequire } from 'node:module';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const HALL = path.join(ROOT, 'modules/hall-ui/public');
+
+const lib = require(path.join(ROOT, 'modules', 'ui-design', 'kit', 'lib.js'));
+let browser = null;
+try { browser = await lib.launchBrowser(); } catch (e) { if (!(e instanceof lib.NoBrowserError)) throw e; }
+after(() => browser && browser.close());
+const skip = !browser && 'no system Edge or Chrome';
+
+const ORIGIN = 'http://hall.test';
+const TYPES = { '.js': 'text/javascript', '.css': 'text/css' };
+const PAGE = (game) => `<!doctype html><html data-theme="dark"${game ? ' data-game="on"' : ''}><head><meta charset="utf-8">
+<link rel="stylesheet" href="/builders/style.css"></head>
+<body data-page="home"><button id="before">page</button>
+<script>window.OTB = { escapeHtml: (s) => String(s == null ? '' : s).replace(/[&<>"']/g, (c) => '&#' + c.charCodeAt(0) + ';') };</script>
+<script src="/builders/page-notes.js"></script></body></html>`;
+
+async function open(game) {
+  const ctx = await browser.newContext({ viewport: { width: 1280, height: 800 } });
+  await ctx.route(ORIGIN + '/**', (route) => {
+    const p = new URL(route.request().url()).pathname;
+    if (p === '/') return route.fulfill({ contentType: 'text/html', body: PAGE(game) });
+    // The sheet's reads: an empty draft and an empty list are enough to draw it.
+    if (p.startsWith('/api/bongos/page-notes')) return route.fulfill({ contentType: 'application/json', body: JSON.stringify({ note: { id: 1, body_md: '', status: 'draft' }, images: [], notes: [] }) });
+    const f = path.join(HALL, p.replace(/^\/builders\//, ''));
+    if (p.startsWith('/builders/') && TYPES[path.extname(p)] && fs.existsSync(f)) return route.fulfill({ contentType: TYPES[path.extname(p)], body: fs.readFileSync(f) });
+    return route.fulfill({ status: 404, body: '' });
+  });
+  const page = await ctx.newPage();
+  const errors = [];
+  page.on('pageerror', (e) => errors.push(String(e.message)));
+  await page.goto(ORIGIN + '/');
+  await page.waitForFunction(() => !!window.OTBPageNotes);
+  // What craft-mode.js does for the Artist: dock the sheet, tucked away behind its tab.
+  await page.evaluate(() => window.OTBPageNotes.dock());
+  return { ctx, page, errors };
+}
+const tabShown = (page) => page.evaluate(() => {
+  const t = document.querySelector('#page-notes .pn__tab');
+  return !!t && getComputedStyle(t).display !== 'none' && t.getClientRects().length > 0;
+});
+const panelShown = (page) => page.evaluate(() => getComputedStyle(document.querySelector('#page-notes .pn__panel')).visibility !== 'hidden'
+  && !document.getElementById('page-notes').classList.contains('pn--collapsed'));
+
+test('classic mode keeps the parked tab at the right edge', { skip }, async () => {
+  const { ctx, page, errors } = await open(false);
+  assert.equal(await tabShown(page), true);
+  assert.deepEqual(errors, []);
+  await ctx.close();
+});
+
+test('game mode: no parked tab; R opens the sheet, and closing leaves nothing at the edge', { skip }, async () => {
+  const { ctx, page, errors } = await open(true);
+  assert.equal(await tabShown(page), false, 'parked, nothing shows on the glass');
+  await page.waitForTimeout(350); // the slide-out
+  assert.equal(await panelShown(page), false);
+  // The visor's "Review this page" is OTBCraftMode.openTool('palette') → OTBPageNotes.open().
+  await page.evaluate(() => window.OTBPageNotes.open());
+  assert.equal(await panelShown(page), true, 'R still opens the sheet');
+  assert.equal(await tabShown(page), false, 'open, still no tab beside it');
+  await page.click('#page-notes [data-pn-close]');
+  await page.waitForTimeout(350);
+  assert.equal(await panelShown(page), false, 'closed, the sheet is gone');
+  assert.equal(await tabShown(page), false, 'and no tab is left behind');
+  assert.equal(await page.evaluate(() => document.getElementById('page-notes').contains(document.activeElement)), false,
+    'focus leaves the tucked sheet instead of landing on a tab nobody can see');
+  await page.evaluate(() => window.OTBPageNotes.open());
+  assert.equal(await panelShown(page), true, 'and R opens it again');
+  assert.deepEqual(errors, []);
+  await ctx.close();
+});

package/tests/page_notes_panel.mjs

@@ -95,6 +95,26 @@ test('THE PANEL: docked at the edge in Artist alone, with no top-bar button, and
   assert.deepEqual(none.loaded, [], 'and nothing loads');
 });
 
+test('the review sheet is the Artist\'s alone: openTool (the visor\'s R) opens it for no other character (task 1005207)', async () => {
+  const a = boot({ session: { 'hall-craft': 'artist' } });
+  await flush();
+  a.craft.openTool('palette');
+  await flush();
+  assert.deepEqual(a.opened, ['dock', 'open'], 'the Artist opens it');
+  for (const m of ['artisan', 'patron']) {
+    const p = boot({ session: { 'hall-craft': m } });
+    await flush();
+    p.craft.openTool('palette');
+    await flush();
+    assert.deepEqual(p.opened, [], `${m}: nothing opens`);
+    assert.deepEqual(p.loaded, [], `${m}: the sheet's script never loads`);
+  }
+  const none = boot();
+  none.craft.openTool('palette');
+  await flush();
+  assert.deepEqual(none.opened, [], 'with no character, nothing opens');
+});
+
 test('a screen in the options menu frame docks no second panel: the menu around it has one', async () => {
   const p = boot({ session: { 'hall-craft': 'artist' }, embedded: true });
   await flush();