@bongos/core 1.24.80 → 1.24.82

package/tests/hall_view_prefs.mjs

@@ -0,0 +1,42 @@
+// tests/hall_view_prefs.mjs — the game-or-classic choice kept on the account
+// (task 1005200, modules/builder-settings/hall-view-prefs.js), and the two routes
+// that read and write it.
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import path from 'node:path';
+import { createRequire } from 'node:module';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = fileURLToPath(new URL('..', import.meta.url));
+const prefs = require('../modules/builder-settings/hall-view-prefs.js');
+
+test('never chosen is null, not a default view: the sign-in chooser asks', () => {
+  assert.equal(prefs.storedView({}), null);
+  assert.equal(prefs.storedView(null), null);
+  assert.equal(prefs.storedView({ hall_view: 'fullscreen' }), null, 'an unknown value is not a choice');
+  assert.deepEqual(prefs.describeForApi({ hall_view: 'game' }), { view: 'game', views: ['game', 'classic'] });
+});
+
+test('a PATCH takes exactly { view: game | classic }', () => {
+  assert.deepEqual(prefs.validatePatch({ view: 'classic' }), { ok: true, view: 'classic' });
+  assert.equal(prefs.validatePatch({}).ok, false, 'no view');
+  assert.equal(prefs.validatePatch({ view: 'both' }).ok, false);
+  assert.equal(prefs.validatePatch({ view: 'game', extra: 1 }).ok, false, 'unknown keys refused');
+  assert.equal(prefs.validatePatch([]).ok, false);
+});
+
+test('saving the view keeps every other behaviour preference', () => {
+  const before = { wandering: 2, widgets: 'rich', interaction: { verbosity: 'concise' } };
+  const after = prefs.applyView(before, 'game');
+  assert.deepEqual(after, { ...before, hall_view: 'game' });
+  assert.equal(before.hall_view, undefined, 'pure: the input is not changed');
+});
+
+test('the routes: own builder only, GET and PATCH on /me/hall-view', () => {
+  const src = fs.readFileSync(path.join(ROOT, 'modules/builder-settings/routes/settings.js'), 'utf8');
+  assert.match(src, /router\.get\('\/me\/hall-view', api\.requireBuilder,/);
+  assert.match(src, /router\.patch\('\/me\/hall-view', api\.requireBuilder,/);
+  assert.match(src, /hallViewPrefs\.applyView\(existing, v\.view\)/, 'writes through the pure shaper');
+});

package/tests/hall_visor.mjs

@@ -151,7 +151,7 @@ test('in game mode the glass shows the place, the main action, the sprite and th
   }));
   assert.equal(g.shown, 'block');
   assert.equal(g.place, 'Test city');
-  assert.match(g.main, /^Claim a task/);
+  assert.match(g.main, /^Goal sky/, 'Claim a task opens a classic page, so it is off the glass in game mode (task 1005200)');
   assert.equal(g.who, 'Artisan');
   assert.equal(g.credits, '56,021 credits');
   assert.equal(g.sprite, '/builders/characters/artisan.png');
@@ -189,7 +189,8 @@ test('the sheet lists the character\'s actions, then this place, and runs a scen
   const { ctx, page } = await open();
   await page.click('[data-visor-sheet]');
   const rows = await page.$$eval('.visor__sheet .visor__row', (r) => r.map((x) => [...x.children].map((c) => c.textContent).join(' ')));
-  assert.deepEqual(rows, ['Claim a task C', 'Blockers B', 'Goal sky G', 'Your thinking T', 'Back to centre 0', 'Look around drag', 'Options Esc']);
+  // task 1005200: Claim a task and Blockers open classic pages, so they are off the glass.
+  assert.deepEqual(rows, ['Goal sky G', 'Your thinking T', 'Back to centre 0', 'Look around drag', 'Options Esc']);
   await page.click('[data-visor-scene="0"]');
   assert.deepEqual(await page.evaluate(() => ({ centred: window.centred, open: OTBVisor.isOpen() })), { centred: true, open: false });
   await ctx.close();

package/tests/nav_permission_atoms.mjs

@@ -103,7 +103,7 @@ test('the hall-preview fixture carries every atom /me resolves', () => {
 // task 1005070: the remembered nav (the rail paints before /me).
 // task 1005088: the sidebar mark is drawn by reference to the one brand mark.
 // task 1005144: My agents, Project settings, Permissions and Modules left for the options menu.
-const SHELL_SHA = 'fb82186606e781b5';
+const SHELL_SHA = '89f6f166ed22a8ee';
 
 test('shell.js has not changed without its cache-bust being bumped', () => {
   const actual = crypto.createHash('sha256').update(SHELL).digest('hex').slice(0, 16);