@bongos/core 1.24.73 → 1.24.74

package/tests/hall_fullscreen.mjs

@@ -25,6 +25,8 @@ const HALL = path.join(ROOT, 'modules/hall-ui/public');
 const SHELL = fs.readFileSync(path.join(HALL, 'shell.js'), 'utf8');
 // task 1004492: the way back lives in shell-trail.js, which every page loads first.
 const TRAIL = fs.readFileSync(path.join(HALL, 'shell-trail.js'), 'utf8');
+// task 1005142: game mode, the hall-wide half of the switch; every page loads it before the shell.
+const GAME = fs.readFileSync(path.join(HALL, 'shell-game.js'), 'utf8');
 const read = (f) => fs.readFileSync(path.join(HALL, f), 'utf8');
 
 // Boot the shell once — one page load. `store` is the browser's localStorage and
@@ -125,11 +127,16 @@ function boot({ page = 'thinking', optIn = true, store = {}, storageThrows = fal
   };
   sandbox.globalThis = sandbox;
   vm.createContext(sandbox);
+  vm.runInContext(GAME, sandbox, { filename: 'shell-game.js' });
   vm.runInContext(TRAIL, sandbox, { filename: 'shell-trail.js' });
   vm.runInContext(SHELL, sandbox, { filename: 'shell.js' });
   const root = documentObj.documentElement;
   return {
     store,
+    game: () => windowObj.OTBShellGame,
+    gameStamp: () => root.dataset.game === 'on',
+    // The "how to leave" line: showing = the shell created it and it is not hidden.
+    hintShowing: () => els.has('fullscreen-hint') && els.get('fullscreen-hint').hidden === false,
     button: () => getElementById('fullscreen-toggle'),
     on: () => root.dataset.fullscreen === 'on',
     plain: () => root.dataset.fullscreenPlain === 'on',
@@ -477,3 +484,97 @@ test('source: full screen hides the sidebar and foot, and collapses the top bar
   assert.match(css, /html\[data-fullscreen="on"\] \.topbar-side > :not\(\.fullscreen-toggle\)/);
   assert.doesNotMatch(css, /html\[data-fullscreen="on"\] \.app-topbar \{ display: none/);
 });
+
+// GAME MODE (task 1005142, BONGOS-V3 R02). The spec's done-when: no page shows the
+// sidebar in game mode. Game mode is hall-wide — one key, read by the SAME switch
+// — so these drive the real shell-game.js + shell.js the way a reader moves
+// through the hall: page after page over one browser store.
+test('game mode: EVERY page opens without its bars — plain, laid-out, and one that remembers "off"', () => {
+  const store = { 'hall-game': 'on', 'hall-fullscreen:goals': 'off' };
+  for (const [page, optIn] of [['goals', false], ['work', false], ['thinking', true], ['city', true]]) {
+    const p = boot({ page, optIn, store });
+    assert.equal(p.on(), true, `${page} opens in full screen`);
+    assert.equal(p.gameStamp(), true, `${page}: html[data-game="on"]`);
+    assert.equal(p.plain(), optIn === false, `${page}: the plain mark still follows the page`);
+  }
+  assert.equal(boot({ page: 'goals', optIn: false, store: {} }).on(), false, 'and outside game mode nothing changed');
+});
+
+test('game mode: every hall page carries the switch — none opts out, and each loads shell-game.js before the shell', () => {
+  const pages = fs.readdirSync(HALL).filter((f) => f.endsWith('.html'));
+  assert.ok(pages.length >= 30, `found ${pages.length} hall pages`);
+  for (const f of pages) {
+    const html = read(f);
+    assert.doesNotMatch(html, /data-fullscreen-switch="off"/, `${f} must not opt out: it would keep its sidebar in game mode`);
+    assert.match(html, /id="app-topbar"/, `${f}: the top bar is where the shell renders the switch`);
+    const tags = [...html.matchAll(/<script src="\/builders\/([a-z-]+)\.js[^"]*"( defer)?><\/script>/g)].map((m) => [m[1], !!m[2]]);
+    const game = tags.findIndex((t) => t[0] === 'shell-game');
+    const shell = tags.findIndex((t) => t[0] === 'shell');
+    assert.ok(game >= 0 && game < shell, `${f} loads shell-game.js before shell.js`);
+    assert.equal(tags[game][1], tags[shell][1], `${f}: both load the same way, so the order holds`);
+  }
+});
+
+test('game mode: leaving brings the bars back for THIS page only, and never rewrites a page\'s own memory', () => {
+  const store = { 'hall-game': 'on', 'hall-fullscreen:thinking': 'on' };
+  const goals = boot({ page: 'goals', optIn: false, store });
+  goals.press('Escape');
+  assert.equal(goals.on(), false, 'Escape still leaves');
+  assert.equal(store['hall-fullscreen:goals'], undefined, 'nothing remembered for the page');
+  assert.equal(boot({ page: 'goals', optIn: false, store }).on(), true, 'the next load opens without bars again');
+  const sky = boot({ page: 'thinking', store });
+  sky.button().click();
+  assert.equal(sky.on(), false, 'the corner button leaves too');
+  assert.equal(store['hall-fullscreen:thinking'], 'on', 'the sky\'s own choice survives game mode');
+});
+
+test('game mode: the Escape hand-off is unchanged — a press the page used, or one in a field, does not leave', () => {
+  const p = boot({ page: 'goals', optIn: false, store: { 'hall-game': 'on' } });
+  p.press('Escape', { pageUses: true });
+  assert.equal(p.on(), true, 'a page listener that called preventDefault keeps the press');
+  p.press('Escape', { target: { tagName: 'TEXTAREA' } });
+  assert.equal(p.on(), true);
+});
+
+test('game mode: set() switches the page live, and turning it off hands each page back its own memory', () => {
+  const store = { 'hall-fullscreen:thinking': 'on' };
+  const goals = boot({ page: 'goals', optIn: false, store });
+  goals.game().set(true);
+  assert.equal(store['hall-game'], 'on');
+  assert.equal(goals.on(), true, 'on at once, no reload');
+  assert.ok(goals.resizes() >= 1, 'a page that sizes to its box is told to re-measure');
+  goals.game().set(false);
+  assert.equal(goals.on(), false, 'goals remembered nothing, so its bars return');
+  assert.equal(goals.gameStamp(), false);
+  assert.equal(store['hall-fullscreen:goals'], undefined, 'and switching the mode wrote nothing for the page');
+  const sky = boot({ page: 'thinking', store: Object.assign(store, { 'hall-game': 'on' }) });
+  sky.game().set(false);
+  assert.equal(sky.on(), true, 'the sky had chosen full screen itself, and keeps it');
+});
+
+test('game mode: ?game=on / ?game=off set it from the URL; anything else is ignored', () => {
+  const store = {};
+  assert.equal(boot({ page: 'work', optIn: false, store, search: '?game=on' }).on(), true);
+  assert.equal(store['hall-game'], 'on');
+  assert.equal(boot({ page: 'goals', optIn: false, store }).on(), true, 'and it holds on the next page');
+  assert.equal(boot({ page: 'work', optIn: false, store, search: '?game=off' }).on(), false);
+  boot({ page: 'work', optIn: false, store, search: '?game=%22%3E%3Cimg%3E' });
+  assert.equal(store['hall-game'], 'off', 'a value that is not on/off is not stored');
+});
+
+test('game mode: how to leave is said once per tab, not on every page; outside it the shell\'s rule stands', () => {
+  const store = { 'hall-game': 'on' };
+  const session = {};
+  assert.equal(boot({ page: 'goals', optIn: false, store, session }).hintShowing(), true, 'the first page says it');
+  assert.equal(boot({ page: 'work', optIn: false, store, session }).hintShowing(), false, 'the next does not repeat it');
+  const own = { 'hall-fullscreen:thinking': 'on' };
+  assert.equal(boot({ page: 'thinking', store: own, session: {} }).hintShowing(), true);
+  assert.equal(boot({ page: 'thinking', store: own, session: {} }).hintShowing(), true, 'a remembered page says it on every open, as before');
+});
+
+test('game mode: storage that throws leaves the hall out of game mode, with the switch working', () => {
+  const p = boot({ page: 'goals', optIn: false, storageThrows: true, search: '?game=on' });
+  assert.equal(p.on(), false);
+  p.button().click();
+  assert.equal(p.on(), true);
+});

package/tests/hall_my_agents.mjs

@@ -443,7 +443,7 @@ test('PAGE: in the hall family, with no prototype key', () => {
   assert.deepEqual(sheets, ['style.css', 'oversight.css', 'speciality-tools.css', 'my-agents.css'],
     'rides the oversight archetype; the shared speciality sheet (task 1005052) before its own, so the page skin wins');
   const scripts = [...html.matchAll(/src="\/builders\/([a-z-]+)\.js/g)].map((m) => m[1]);
-  assert.deepEqual(scripts.slice(0, 4), ['dom-utils', 'shell-trail', 'craft-mode', 'shell']); // dom-utils first: the shell escapes through it (task 1004876)
+  assert.deepEqual(scripts.slice(0, 5), ['dom-utils', 'shell-game', 'shell-trail', 'craft-mode', 'shell']); // dom-utils first: the shell escapes through it (task 1004876)
   for (const s of ['gov-living', 'gov-positions', 'my-agents', 'speciality-tools']) assert.ok(scripts.includes(s), `loads ${s}.js`);
   assert.doesNotMatch(html, /ma-key|data-proto|Prototype data/, 'nothing on the page is prototype data, so there is no key');
   assert.doesNotMatch(read('my-agents.js'), /governor-overlay/, 'and it reads no overlay');

package/tests/hall_street.mjs

@@ -490,7 +490,7 @@ test('the page holds the prototype\'s header, the street, the readings and the c
   assert.match(html, /<a class="street-mark" id="streetHome" href="\/builders\/city"[^>]*>\{\{productName\}\}</);
   for (const id of ['hudNeeds', 'hudMoving', 'hudShare', 'streetMode', 'streetSigns', 'streetPins', 'streetDoors', 'streetCard']) assert.match(html, new RegExp(`id="${id}"`), id);
   const scripts = [...html.matchAll(/<script src="\/builders\/([a-z-]+)\.js/g)].map((m) => m[1]);
-  assert.deepEqual(scripts.filter((s) => !/^street-(deck|office)$/.test(s)), ['dom-utils', 'shell-trail', 'craft-mode', 'shell', 'hall-dialog', 'palette', 'gov-living', 'gov-feeds', 'city-draw', 'street-draw', 'street-card', 'street-inside', 'street-depth', 'street-desk', 'street-amend', 'street'], 'the hall shell (task 1004544), the living model and its one reader (task 1004685: city-draw.js counts with it, so it loads first), the shared kit, then the card (task 1004528), the interiors (task 1004526), the living street\'s exterior (street-depth.js), the floor desk (task 1004558) and the drafted amendment (task 1004530); the deck rides beside them');
+  assert.deepEqual(scripts.filter((s) => !/^street-(deck|office)$/.test(s)), ['dom-utils', 'shell-game', 'shell-trail', 'craft-mode', 'shell', 'hall-dialog', 'palette', 'gov-living', 'gov-feeds', 'city-draw', 'street-draw', 'street-card', 'street-inside', 'street-depth', 'street-desk', 'street-amend', 'street'], 'the hall shell (task 1004544), the living model and its one reader (task 1004685: city-draw.js counts with it, so it loads first), the shared kit, then the card (task 1004528), the interiors (task 1004526), the living street\'s exterior (street-depth.js), the floor desk (task 1004558) and the drafted amendment (task 1004530); the deck rides beside them');
   assert.equal(City.STREET_HREF, '/builders/street', 'the city\'s door is this page');
 });
 

package/tests/nav_permission_atoms.mjs

@@ -102,7 +102,7 @@ test('the hall-preview fixture carries every atom /me resolves', () => {
 // task 1005051: Roadmap left it (folded into Goals; /roadmap redirects).
 // task 1005070: the remembered nav (the rail paints before /me).
 // task 1005088: the sidebar mark is drawn by reference to the one brand mark.
-const SHELL_SHA = '2845bfedfaf7846f';
+const SHELL_SHA = 'e9c13c142bcd2a95';
 
 test('shell.js has not changed without its cache-bust being bumped', () => {
   const actual = crypto.createHash('sha256').update(SHELL).digest('hex').slice(0, 16);