@bongos/core 1.24.7 → 1.24.9

package/release-notes.json

@@ -10877,5 +10877,17 @@
       "id": "1005003",
       "text": "The automatic tweak limit is now 200 rounds a month, and a project owner can change it, for the whole project and separately for each builder rank, on the project settings page."
     }
+  ],
+  "1.24.8": [
+    {
+      "id": "1004941",
+      "text": "Every member can now read the Market Watch rules step by step, propose a change with a reason, and the owner (or the government, by vote) approves it into a new rules version that the next weekly run uses."
+    }
+  ],
+  "1.24.9": [
+    {
+      "id": "1004989",
+      "text": "Modules can now only be priced in cash: credits can no longer price or buy one, and modules that still have an old credit price stay listed as \"price coming\" while their authors are asked to set a cash price."
+    }
   ]
 }

package/scripts/bongos/government-walk.js

@@ -84,6 +84,7 @@ const REQUESTS = Object.freeze({
   'PATCH /project-settings/tweak-autopickup': ['PATCH', '/project-settings/tweak-autopickup', { mode: 'sometimes' }],
   'PATCH /project-settings/spend-cap': ['PATCH', '/project-settings/spend-cap', { usd: 'lots' }],
   'PATCH /work-categories/:id': ['PATCH', `/work-categories/${BAD}`, {}],
+  'POST /market-watch/proposals/:id/decide': ['POST', `/market-watch/proposals/${BAD}/decide`, { decision: 'approve' }],
   'POST /security/reports/:id/confirm': ['POST', `/security/reports/${BAD}/confirm`, {}],
   'POST /security/reports/:id/dispute': ['POST', `/security/reports/${BAD}/dispute`, {}],
   'POST /security/reports/:id/fix': ['POST', `/security/reports/${BAD}/fix`, {}],
@@ -123,6 +124,7 @@ const MATTER_PLAN = Object.freeze([
   ['release', 'Approve override request 5', { type: 'approve_override', request_id: 5 }, 'request 5 approved'],
   ['review', 'Sign off criterion 9', { type: 'satisfy_criterion', criterion_id: 9 }, 'criterion 9 satisfied'],
   ['treasury', 'Dee gets $50 a month', { type: 'set_budget', builder_id: 45, monthly_usd: 50 }, 'Dee\'s limit is $50'],
+  ['rules', 'Market Watch: + bounty boards as a search', { type: 'market_watch_proposal', proposal_id: 12 }, 'proposal 12 approved'],
 ]);
 
 // Every router the walk drives, mounted as the server mounts them.
@@ -145,6 +147,8 @@ const ROUTERS = Object.freeze([
   // the new machinery's other doors: a blocker and its ask, a builder's settings
   'modules/ideas/routes/blockers.js',
   'modules/builder-settings/routes/settings.js',
+  // task 1004941: the owner's decide route (a Rules act) and the Rules matter act
+  'modules/market-watch/routes/rules.js',
 ]);
 
 // ── the in-memory government store ──────────────────────────────────────────
@@ -633,7 +637,17 @@ async function runWalk() {
   projectSettings.setSetting = async (k, v) => { settings.set(k, String(v)); return { key: k, value: String(v) }; };
 
   // What passed matters write into other modules, recorded.
-  const effects = { fence: null, allowedGoals: [], overrides: [], criteria: new Map([['9', false]]), budgets: new Map() };
+  const effects = { fence: null, allowedGoals: [], overrides: [], criteria: new Map([['9', false]]), budgets: new Map(), mwApproved: [] };
+  // task 1004941: a passed Rules matter approves a Market Watch proposal through the
+  // module's own decideProposal; here it is recorded instead of written.
+  const mwActs = req('modules/market-watch/matter-acts.js');
+  const mwProposals = req('modules/market-watch/proposals.js');
+  mwActs.runtime.project = () => 'https://walk.example';
+  mwActs.runtime.withTx = async (fn) => fn(null);
+  mwProposals.decideProposal = async ({ id, decision }) => {
+    if (decision === 'approve') effects.mwApproved.push(String(id));
+    return { ok: true, status: 'applied', applied: true };
+  };
   autoDb.setFenceEnabled = async ({ enabled }) => { effects.fence = enabled; return { enabled }; };
   autoDb.allowGoal = async ({ goalId }) => { effects.allowedGoals.push(String(goalId)); return { goal_id: goalId }; };
   lifeDb.decideOverrideRequest = async ({ requestId, decision }) => { effects.overrides.push([String(requestId), decision]); return {}; };
@@ -943,6 +957,7 @@ async function runWalk() {
   section('M Matters');
   const SITTINGS = {
     people: 'consent', automation: 'majority', release: 'unanimous', review: 'signoff', treasury: 'first',
+    rules: 'majority',
   };
   await check('Each acting building is put to the council by one passed amendment', Object.entries(SITTINGS).map(([a, r]) => `${a} ${r}`).join(', '), async () => {
     const out = await setRules(Object.entries(SITTINGS).map(([area, rule]) => ({ area, decided_by: 'rank:council', rule })));
@@ -971,12 +986,13 @@ async function runWalk() {
     'release.approve_override': () => effects.overrides.some(([id, d]) => id === '5' && d === 'approve'),
     'review.satisfy_criterion': () => effects.criteria.get('9') === true,
     'treasury.set_budget': () => effects.budgets.get('45') === 50,
+    'rules.market_watch_proposal': () => effects.mwApproved.includes('12'),
   };
   const MATTERS = MATTER_PLAN.map(([area, title, action, effect]) => [area, title, action, effect, HAPPENED[`${area}.${action.type}`]]);
   // How each building's sitting closes as Ben then Cy say yes, under its rule: the
   // two-member consent, majority and unanimous sittings need both; first yes and
   // sign-off (by someone who did not propose it) close on the first.
-  const CLOSES = { people: 'open, passed', automation: 'open, passed', release: 'open, passed', review: 'passed', treasury: 'passed' };
+  const CLOSES = { people: 'open, passed', automation: 'open, passed', release: 'open, passed', review: 'passed', treasury: 'passed', rules: 'open, passed' };
   await check('Someone the building\'s row does not seat cannot vote on its matter', '403 not_board_member', async () => {
     const r = await call(FOUNDER, 'POST', '/government/board/matters', { area: 'automation', title: 'Who may vote here?' });
     const itemId = r.json && r.json.item && r.json.item.id;

package/scripts/bongos/module-store-cli.js

@@ -63,13 +63,17 @@ function storeError(res) {
 // bongos module store — what the store lists (task 1003811)
 // ---------------------------------------------------------------------------
 
-const STORE_USAGE = 'usage: bongos module store [--sort <part>] [--max-cents N] [--max-credits N] [--json]';
+const STORE_USAGE = 'usage: bongos module store [--sort <part>] [--max-cents N] [--json]';
+
+// Credits never price or buy a module (task 1004989, ADR 0385 decision 2).
+const NO_CREDIT_PRICE = 'credits do not price modules: use cents';
 
 // The query GET /store/modules takes, from argv. Returns { query } or { error }.
 // The server checks the values too; this only refuses what is not a value at all.
 function storeQuery(args) {
+  if (args.includes('--max-credits')) return { error: NO_CREDIT_PRICE };
   const params = [];
-  for (const [flag, param] of [['--sort', 'sort'], ['--max-cents', 'max_cents'], ['--max-credits', 'max_credits']]) {
+  for (const [flag, param] of [['--sort', 'sort'], ['--max-cents', 'max_cents']]) {
     const i = args.indexOf(flag);
     if (i === -1) continue;
     const v = args[i + 1];
@@ -79,12 +83,12 @@ function storeQuery(args) {
   return { query: params.length ? `?${params.join('&')}` : '' };
 }
 
+// A cash price, "free", or "price coming" for a module that still carries only an
+// old credit price. Never a credit amount.
 function formatPrice(price) {
   if (!price || price.free) return 'free';
-  const parts = [];
-  if (price.cents != null) parts.push(`$${(price.cents / 100).toFixed(2)}`);
-  if (price.credits != null) parts.push(`${price.credits} credits`);
-  return parts.join(' or ') || 'free';
+  if (price.cents != null) return `$${(price.cents / 100).toFixed(2)}`;
+  return 'price coming';
 }
 
 function formatPlace(category) {
@@ -104,7 +108,7 @@ function formatStore(body) {
     out.push(`  sorted by ${part ? part.title : body.sort}`);
   }
   const max = body.max_price;
-  if (max) out.push(`  at most ${[max.cents != null ? `$${(max.cents / 100).toFixed(2)}` : null, max.credits != null ? `${max.credits} credits` : null].filter(Boolean).join(' or ')}`);
+  if (max && max.cents != null) out.push(`  at most $${(max.cents / 100).toFixed(2)}`);
   out.push('');
   const listed = body.listed || [];
   if (!listed.length) out.push('  Nothing is listed yet.');
@@ -141,22 +145,18 @@ async function cmdStore(args, { log = console.log, errlog = console.error, reque
 // bongos module price — the author sets a module's price (task 1004894)
 // ---------------------------------------------------------------------------
 
-const PRICE_USAGE = 'usage: bongos module price <key> [--cents N] [--credits N]   (0 in either makes it free)';
+const PRICE_USAGE = 'usage: bongos module price <key> --cents N   (0 makes it free)';
 
-// argv -> { key, cents, credits } or { error }. Pure.
+// argv -> { key, cents } or { error }. Pure.
 function priceArgs(args) {
   const key = args[0];
   if (!key || key.startsWith('--') || !KEY_RE.test(key)) return { error: 'name the module: a lowercase kebab-case key' };
-  const out = { key, cents: null, credits: null };
-  for (const [flag, field] of [['--cents', 'cents'], ['--credits', 'credits']]) {
-    const i = args.indexOf(flag);
-    if (i === -1) continue;
-    const v = args[i + 1];
-    if (!v || !/^\d{1,9}$/.test(v)) return { error: `${flag} needs a whole number, 0 or more` };
-    out[field] = Number(v);
-  }
-  if (out.cents === null && out.credits === null) return { error: 'give --cents, --credits or both' };
-  return out;
+  if (args.includes('--credits')) return { error: NO_CREDIT_PRICE };
+  const i = args.indexOf('--cents');
+  if (i === -1) return { error: 'give --cents' };
+  const v = args[i + 1];
+  if (!v || !/^\d{1,9}$/.test(v)) return { error: '--cents needs a whole number, 0 or more' };
+  return { key, cents: Number(v) };
 }
 
 async function cmdPrice(args, { log = console.log, errlog = console.error, request } = {}) {
@@ -166,10 +166,10 @@ async function cmdPrice(args, { log = console.log, errlog = console.error, reque
   try { call = request || storeRequest(); }
   catch (e) { errlog(`bongos module price: ${e.message}`); return 1; }
   let res;
-  try { res = await call('POST', `/store/modules/${encodeURIComponent(p.key)}/price`, { json: { cents: p.cents, credits: p.credits } }); }
+  try { res = await call('POST', `/store/modules/${encodeURIComponent(p.key)}/price`, { json: { cents: p.cents } }); }
   catch (e) { errlog(`bongos module price: the store could not be reached — ${e.message}`); return 1; }
   if (!res.ok) { errlog(`bongos module price: the store answered ${storeError(res)}`); return res.status === 400 ? 2 : 1; }
-  const withFree = (p) => ({ ...p, free: p.cents === 0 || p.credits === 0 });
+  const withFree = (p) => ({ ...p, free: p.cents === 0 });
   const shown = formatPrice(withFree(res.data.price));
   const was = res.data.previous ? formatPrice(withFree(res.data.previous)) : 'free (no price set)';
   log(`✓ "${p.key}" now costs ${shown} (was ${was}).`);

package/scripts/bongos/module.js

@@ -31,7 +31,7 @@
 //     model as the hall's Modules tab (src/module-loader/catalog.js), so the two
 //     surfaces cannot disagree about who built what.
 //
-//   bongos module store [--sort <part>] [--max-cents N] [--max-credits N] [--json]
+//   bongos module store [--sort <part>] [--max-cents N] [--json]
 //     Task 1003811 (criterion wa5-curated-listing) — the STORE from the terminal:
 //     what the catalog lists, in its order. It asks GET /store/modules, the same
 //     read the hall's "In the store" group makes, and never filters, ranks or caps
@@ -39,9 +39,9 @@
 //     sub-category live in one place (src/bongos/module-listing.js), so the hall
 //     and the terminal cannot disagree about which modules are the best.
 //
-//   bongos module price <key> [--cents N] [--credits N]
+//   bongos module price <key> --cents N   (credits never price a module)
 //     Task 1004894 — the module's author sets its price in the store, in money
-//     (cents), credits or both; 0 in either makes it free. The store keeps every
+//     (cents); 0 makes it free. A credit price is refused (task 1004989). The store keeps every
 //     change and shows the newest. A paid module is listed as not yet buyable until
 //     buying arrives (task 1003788).
 //
@@ -72,7 +72,7 @@
 //   bongos module new <key>            scaffold modules/<key>/
 //   bongos module new <key> --force    overwrite an existing modules/<key>/
 //   bongos module list [--catalog]     browse the module catalog (author + origin credit)
-//   bongos module store [--sort <part>] [--max-cents N] [--max-credits N]   what the store lists, best first
+//   bongos module store [--sort <part>] [--max-cents N]   what the store lists, best first
 //   bongos upgrade [--no-store]        pre-check enabled modules vs the core version + list store updates
 //   bongos module check <key> [--sign-off "Name <email>"]   AGPL/publish pre-check + DCO sign-off
 //   bongos module install <key> [--version X.Y.Z]   acquire from the store, verify, place (not enabled)
@@ -968,7 +968,7 @@ async function cmdPublish(args, {
   log = console.log, errlog = console.error,
   modulesDir = MODULES_DIR, pack, upload, writeFile = fs.writeFileSync, priceRequest,
 } = {}) {
-  const PUBLISH_USAGE = 'usage: bongos module publish <key> [--dry-run] [--out <dir>] [--cents N] [--credits N]';
+  const PUBLISH_USAGE = 'usage: bongos module publish <key> [--dry-run] [--out <dir>] [--cents N]';
   const VALUED = new Set(['--out', '--cents', '--credits']);
   const key = args.find((a, i) => !a.startsWith('-') && !VALUED.has(args[i - 1]));
   if (!key) {
@@ -1335,9 +1335,9 @@ function printHelp(out = console.log) {
   out('  bongos module new <key>     Scaffold modules/<key>/ (manifest + skeleton + sample route + HOWTO.md + CLAUDE.md)');
   out('  bongos module list [--catalog] [--search <text>] [--json]');
   out('                              Browse the module catalog — what you can enable, with author + origin credit');
-  out('  bongos module store [--sort <part>] [--max-cents N] [--max-credits N] [--json]');
+  out('  bongos module store [--sort <part>] [--max-cents N] [--json]');
   out('                              What the store lists, best first: above the quality floor, ranked, ten per sub-category');
-  out('  bongos module price <key> [--cents N] [--credits N]');
+  out('  bongos module price <key> --cents N');
   out('                              Set your module\'s price in the store (0 in either makes it free)');
   out('  bongos module remove <key>  Take a store module off this project (switch it off first; its folder is kept aside)');
   out('  bongos upgrade [--no-store] Pre-check enabled modules against the core version (fail-closed),');
@@ -1346,7 +1346,7 @@ function printHelp(out = console.log) {
   out('                              AGPL/publish pre-check before upstreaming + record a DCO-style sign-off');
   out('  bongos module submit <key> [--sign-off "Name <email>"]');
   out('                              Pre-check + sign-off, then file into the rank-gated upstreaming review queue');
-  out('  bongos module publish <key> [--dry-run] [--out <dir>] [--cents N] [--credits N]');
+  out('  bongos module publish <key> [--dry-run] [--out <dir>] [--cents N]');
   out('                              Pack a module version (tarball + hash manifest) and upload it to the module store');
   out('  bongos module install <key> [--version X.Y.Z]');
   out('                              Acquire a module from the store, verify it and place it under modules/ (not enabled)');

package/scripts/bongos/run-unit-tests.js

@@ -93,6 +93,9 @@ const INTEGRATION = new Set([
   // idempotent and a resumed run unable to record an item twice. DB-free sibling:
   // market_watch_data.
   'market_watch_data_db',
+  // task 1004941: a rules proposal round-trips to a new version the weekly run's loader
+  // reads, on real SQL (the one-active index, the CHECKs). DB-free sibling: market_watch_rules.
+  'market_watch_rules_db',
   // task 1004940: the weekly ask's SQL store — once per week by constraint, one pooled
   // proposal per similar answer, the project guard on an answer. DB-free sibling:
   // market_watch_ask.

package/src/bongos/module-listing.js

@@ -135,39 +135,57 @@ function sortByPart(entries, part) {
 // can both check in one sentence:
 //
 //   highest overall score first; between equal scores the cheaper module first
-//   (free first, then the lowest cash price, then the lowest credit price); then
-//   the key.
+//   (free first, then the lowest cash price, a module whose cash price is still
+//   coming last); then the key.
 //
 // Price never buys a better place: it only orders modules the score could not tell
 // apart (price is never an input to the score, ADR 0343 D6). A buyer may also set a
 // maximum price, which leaves out what costs more — a filter, not a ranking.
 const RANKING = 'Highest overall score first; between equal scores, free modules and then the cheapest come first.';
 
-// A module's current price row ({ price_cents, price_credits } or none) as the
-// catalog shows it. No row is free (isFreePrice, module-store.js); 0 in either
-// currency is free; null means not offered in that currency (core_257). Pure.
+// CREDITS NEVER PRICE A MODULE (task 1004989, ADR 0385 decision 2). Credits are a
+// contribution meter: a credit price would make them stored value. New price rows
+// carry cents only (core_287 refuses price_credits). An OLD row may still carry a
+// credit price; the owner's ruling (2026-10-29) is that such a module stays
+// VISIBLE with a "price coming" note and can NOT be bought with credits, while
+// its author is asked to set a cash price.
+//
+// A module's current price row as the catalog shows it: { cents, free, coming }.
+// Never a credit amount. No row is free (isFreePrice, module-store.js); a cash
+// price of 0 is free. An old row that offered it at 0 credits stays free, as it
+// was: its author offered it at nothing, and no credit moves to have it. An old row whose
+// only price was a positive number of credits is `coming` — no cash price yet,
+// so not free and not buyable. Pure.
 function priceOf(row) {
   const cents = row && row.price_cents != null ? Number(row.price_cents) : null;
-  const credits = row && row.price_credits != null ? Number(row.price_credits) : null;
-  return { cents, credits, free: !row || cents === 0 || credits === 0 };
+  const legacyCredits = row && row.price_credits != null ? Number(row.price_credits) : null;
+  const free = !row || cents === 0 || legacyCredits === 0;
+  return { cents, free, coming: !free && cents == null };
 }
 
-// Whether a module can be bought today. Buying arrives with task 1003788 (area 8's
-// wallet); until then only a free module can be had, and a paid one is listed with
-// its price and marked not yet buyable (owner, 2026-10-26). Flip BUYING_OPEN when
-// the buy action ships, and nothing else needs to change. Pure.
+// What the author of a "price coming" module is asked (task 1004989). One string,
+// so the listing read, the CLI and the hall say the same thing.
+const PRICE_COMING_PROMPT = 'This module still has a price in credits, and credits can no longer price or buy a module. '
+  + 'It stays listed with "price coming" until you set a cash price: bongos module price <key> --cents N (0 makes it free).';
+
+// Whether a module can be bought today. Buying arrives with task 1003788; until
+// then only a free module can be had, and a paid one is listed with its price and
+// marked not yet buyable (owner, 2026-10-26). Flip BUYING_OPEN when the buy action
+// ships. A module whose cash price is still coming stays unbuyable even then:
+// there is nothing to pay in but credits, and credits do not buy. Pure.
 const BUYING_OPEN = false;
 function buyableNow(price) {
-  return !!(price && (price.free || BUYING_OPEN));
+  return !!(price && (price.free || (BUYING_OPEN && price.cents != null)));
 }
 
-// Within a buyer's maximum ({ cents, credits }, either may be null): a free module
-// always is; a priced one is when it is offered at or under a cap the buyer set. Pure.
+// Within a buyer's maximum cash price ({ cents }, or null for no cap): a free
+// module always is; a priced one is when its cash price is at or under the cap.
+// A module whose price is still coming has no cash price to compare, so a cap
+// leaves it out. Pure.
 function withinMaxPrice(price, max) {
-  if (!max || (max.cents == null && max.credits == null)) return true;
+  if (!max || max.cents == null) return true;
   if (price.free) return true;
-  return (max.cents != null && price.cents != null && price.cents <= max.cents)
-    || (max.credits != null && price.credits != null && price.credits <= max.credits);
+  return price.cents != null && price.cents <= max.cents;
 }
 
 // The default order of `listed`, per RANKING. Returns a new array. Pure.
@@ -179,7 +197,6 @@ function rankListed(entries) {
     return ((b.overall ?? -1) - (a.overall ?? -1))
       || (Number(pb.free) - Number(pa.free))
       || (cheap(pa.cents) - cheap(pb.cents))
-      || (cheap(pa.credits) - cheap(pb.credits))
       || a.key.localeCompare(b.key);
   });
 }
@@ -292,8 +309,8 @@ async function buildCatalog({ db, floor = QUALITY_FLOOR, sort = null, maxPrice =
       signals.get(k).push(s);
     }
   }
-  const max = maxPrice && (maxPrice.cents != null || maxPrice.credits != null)
-    ? { cents: maxPrice.cents ?? null, credits: maxPrice.credits ?? null } : null;
+  // A cash cap only (task 1004989): credits are never a price, so never a cap.
+  const max = maxPrice && maxPrice.cents != null ? { cents: maxPrice.cents } : null;
   const cats = await readModuleCategories(newest.map((r) => r.module_key), { db: pool });
   const out = { floor, cap: CAP_PER_SUBCATEGORY, ranking: RANKING, sort: sort || null, sort_parts: SORT_PARTS, max_price: max, listed: [], new: [] };
   for (const r of newest.sort((a, b) => a.module_key.localeCompare(b.module_key))) {
@@ -421,14 +438,24 @@ async function readListing(key, { db, floor = QUALITY_FLOOR, viewerId = null } =
     if (held) placed = { placement: 'excluded', reason: 'over_cap' };
   }
   const overall = score && placed.placement !== 'new' ? score.overall : null;
+  // The price as the catalog shows it, and — to the author only — the ask to set a
+  // cash price when the module still carries only an old credit price (task
+  // 1004989; the owner's ruling, 2026-10-29). Read by idx_store_module_prices_current.
+  const { rows: [priceRow] } = await pool.query(
+    `SELECT price_cents, price_credits FROM store_module_prices
+      WHERE module_key = $1 ORDER BY set_at DESC, id DESC LIMIT 1`, [key]);
+  const price = priceOf(priceRow || null);
   return {
     ...head, version: newest.version, version_id: newest.version_id, overall,
     ...explainPlacement(placed, { overall, floor, security, weaknesses: reading.weaknesses, held }),
     security, ...reading,
+    price, buyable: buyableNow(price),
+    price_prompt: isAuthor && price.coming ? PRICE_COMING_PROMPT : null,
   };
 }
 
 module.exports = {
   QUALITY_FLOOR, STRONG_AT, SORT_PARTS, RANKING, CAP_PER_SUBCATEGORY, placeVersion, readParts,
   sortByPart, priceOf, withinMaxPrice, rankListed, applyCap, listCatalog, explainPlacement, readListing,
+  PRICE_COMING_PROMPT,
 };

package/src/bongos/module-scope-map.js

@@ -198,6 +198,8 @@ const MODULE_GLOBS = {
     'modules/market-watch/', 'tests/market_watch_module.mjs',
     'tests/market_watch_data.mjs', 'tests/market_watch_data_db.mjs',
     'tests/market_watch_run.mjs',
+    // task 1004941: the rules page (proposals, decisions, the run's prompt fence)
+    'tests/market_watch_rules.mjs', 'tests/market_watch_rules_db.mjs',
     'tests/market_watch_ask.mjs', 'tests/market_watch_ask_db.mjs',
   ],
   // --- builder prefs (wandering/skill/sound/render) + builder-needs ---

package/src/bongos/module-store.js

@@ -254,8 +254,11 @@ async function publishVersion(input, { db, beforeCommit } = {}) {
 // A module with NO price row is free. The owner decided this (2026-09-29): nothing
 // sets a price yet and who may sell is still open, so an unpriced module is
 // acquirable at no cost, and an entitlement taken then is kept if a price is added
-// later (ADR 0338 D2). A priced module is free when either currency it is offered in
-// is zero (0 = free, NULL = not offered in that currency; core_257).
+// later (ADR 0338 D2). A priced module is free when its cash price is zero. An old
+// row that offered it at 0 credits also stays free, as it was — its author offered
+// it at nothing and no credit moves to have it (task 1004989; module-listing.js priceOf
+// reads the same rule). An old row priced only in credits above 0 is NOT free:
+// its cash price is still coming, and credits never buy a module.
 function isFreePrice(priceRow) {
   if (!priceRow) return true;
   return priceRow.price_cents === 0 || priceRow.price_credits === 0;
@@ -387,20 +390,25 @@ async function latestVersions(keys, { db, channelsFor = null } = {}) {
 // author may, and a delisted module takes no new price (it can no longer be
 // acquired). The price is a HISTORY: each change appends a row and the newest is
 // current, which is what the catalog (module-listing.js priceOf) and acquire
-// (isFreePrice above) already read. `cents` / `credits`: a whole number of 0 or
-// more, or null for "not offered in that currency"; at least one must be given
-// (core_257's CHECK), and 0 in either is free. A paid price may be set before
+// (isFreePrice above) already read. `cents`: a whole number of 0 or more; 0 is
+// free. A paid price may be set before
 // buying exists (owner, 2026-10-26): the module is listed with it and marked not yet
 // buyable, and acquire keeps refusing it without an entitlement. Price is never an
 // input to the score (ADR 0343 D6). The history IS the audit of price changes:
 // every row names who set it and when, and the row before it is what it changed
 // from (the audit middleware also logs the request). One transaction, the module row
 // locked FOR UPDATE as publishVersion does, so two changes at once each report the
-// price they really replaced. Returns { ok: true, previous, price } (each
-// { cents, credits } or null) or { ok: false, status, code, message }.
-async function setPrice({ key, cents = null, credits = null, builderId }, { db } = {}) {
+// price they really replaced. Returns { ok: true, previous, price } or
+// { ok: false, status, code, message }.
+//
+// CASH ONLY (task 1004989, ADR 0385 decision 2): credits never price a module, so
+// a new row carries cents and nothing else (core_287 refuses price_credits in the
+// database too). `previous` reports the replaced row's cash price, and `coming:
+// true` when that row priced the module in credits only.
+async function setPrice({ key, cents, builderId }, { db } = {}) {
   const pool = db || require('./pool').pool;
   const refuse = (status, code, message) => ({ ok: false, status, code, message });
+  if (!Number.isInteger(cents) || cents < 0) return refuse(400, 'bad_price', 'A price is a whole number of cents, 0 or more. 0 makes the module free.');
   const client = await pool.connect();
   try {
     await client.query('BEGIN');
@@ -415,13 +423,13 @@ async function setPrice({ key, cents = null, credits = null, builderId }, { db }
       `SELECT price_cents, price_credits FROM store_module_prices
         WHERE module_key = $1 ORDER BY set_at DESC, id DESC LIMIT 1`, [key]);
     await client.query(
-      'INSERT INTO store_module_prices (module_key, price_cents, price_credits, set_by) VALUES ($1, $2, $3, $4)',
-      [key, cents, credits, builderId]);
+      'INSERT INTO store_module_prices (module_key, price_cents, set_by) VALUES ($1, $2, $3)',
+      [key, cents, builderId]);
     await client.query('COMMIT');
     return {
       ok: true,
-      previous: prev ? { cents: prev.price_cents, credits: prev.price_credits } : null,
-      price: { cents, credits },
+      previous: prev ? { cents: prev.price_cents, coming: prev.price_cents == null && Number(prev.price_credits) > 0 } : null,
+      price: { cents },
     };
   } catch (e) {
     try { await client.query('ROLLBACK'); } catch { /* the connection may be gone */ }

package/src/bongos/routes/modules.js

@@ -576,9 +576,9 @@ module.exports = function buildModulesRouter() {
     }));
 
   // POST /api/bongos/store/modules/:key/price — the module's author sets its price
-  // (task 1004894, criterion wa5-module-economy). Body: { cents?, credits? }, each a
-  // whole number of 0 or more, or null for "not offered in that currency"; at least
-  // one is given, and 0 in either is free. Appends a row to the price history; the
+  // (task 1004894, criterion wa5-module-economy). Body: { cents }, a whole number of
+  // 0 or more; 0 is free. A credit price is refused (task 1004989, ADR 0385
+  // decision 2: credits never price or buy a module). Appends a row to the price history; the
   // newest is what the catalog shows and what acquire charges. A paid price may be
   // set before buying exists (owner, 2026-10-26): the catalog marks it not yet
   // buyable. Price never moves the score (ADR 0343 D6). The audit middleware records
@@ -588,21 +588,24 @@ module.exports = function buildModulesRouter() {
   // author check inside setPrice: only the person who published the module prices it.
   router.post('/store/modules/:key/price', auth.requireBuilder, auth.requirePermission('module.submit'),
     asyncHandler('POST /store/modules/:key/price', async (req, res) => {
-      const AMOUNT = { type: 'integer', min: 0, max: 100000000 };
-      if (validateOrRespond(req, res, { cents: AMOUNT, credits: AMOUNT })) return;
+      const body = req.body || {};
+      // Refused before anything else, by name, so an older CLI that still sends
+      // credits is told why rather than seeing a generic validation error.
+      if (body.credits != null) {
+        return res.fail('credit_price_refused', { status: 400, message: 'Credits cannot price a module: they measure contribution and are never spent. Set a cash price in cents (0 makes it free).' });
+      }
+      if (validateOrRespond(req, res, { cents: { type: 'integer', min: 0, max: 100000000 } })) return;
       const { key } = req.params;
       if (!KEY_RE.test(key)) {
         return res.fail('bad_module_key', { status: 400, message: 'A module key is lowercase kebab-case.' });
       }
-      const body = req.body || {};
       const cents = body.cents ?? null;
-      const credits = body.credits ?? null;
-      if (cents === null && credits === null) {
-        return res.fail('bad_price', { status: 400, message: 'Give a price in cents, credits or both. 0 in either makes the module free.' });
+      if (cents === null) {
+        return res.fail('bad_price', { status: 400, message: 'Give a price in cents. 0 makes the module free.' });
       }
-      const out = await setPrice({ key, cents, credits, builderId: req.builder.id });
+      const out = await setPrice({ key, cents, builderId: req.builder.id });
       if (!out.ok) return res.fail(out.code, { status: out.status, message: out.message });
-      log.info({ key, builderId: req.builder.id, cents, credits }, `${key} price set`);
+      log.info({ key, builderId: req.builder.id, cents }, `${key} price set`);
       res.json({ ok: true, module_key: key, previous: out.previous, price: out.price });
     }));
 
@@ -772,9 +775,14 @@ module.exports = function buildModulesRouter() {
       let held = await checkEntitlement(holder);
       if (!held.entitled) {
         if (!r.free) {
+          // Never "pay with credits" (task 1004989): credits are never spent. A
+          // module still carrying only an old credit price has no cash price yet.
+          const coming = r.price && r.price.price_cents == null;
           return res.fail('payment_required', {
             status: 402,
-            message: `"${key}" is priced, and buying a module is not available yet (it arrives with the credit economy, area 8).`,
+            message: coming
+              ? `"${key}" has no cash price yet: its author has been asked to set one. Credits cannot buy a module.`
+              : `"${key}" is priced, and buying a module is not available yet.`,
           });
         }
         const g = await grantEntitlement({ ...holder, source: 'free', grantedBy: req.builder.id });
@@ -917,8 +925,7 @@ module.exports = function buildModulesRouter() {
   // `?sort=<part>` orders the listed modules by the part a buyer cares about
   // (task 1003800, sortByPart); the parts it accepts come back as sort_parts.
   // Without it the listed modules are ranked quality first, price breaking ties
-  // (task 1003808, rankListed); `?max_cents=` / `?max_credits=` leave out modules
-  // that cost more.
+  // (task 1003808, rankListed); `?max_cents=` leaves out modules that cost more.
   //
   // rank: any-builder — a read of public store metadata, like /store/modules/latest:
   // no entitlement taken, nothing changed.
@@ -930,16 +937,19 @@ module.exports = function buildModulesRouter() {
         const names = SORT_PARTS.map((p) => `${p.title} (${p.part})`).join(', ');
         return res.fail('bad_request', { status: 400, message: `The store can be sorted by one part of the score: ${names}.` });
       }
-      // An optional maximum price (task 1003808): ?max_cents= and/or ?max_credits=,
-      // each a whole number of at least 0. Free modules always pass.
+      // An optional maximum price (task 1003808): ?max_cents=, a whole number of at
+      // least 0. Free modules always pass. There is no credit cap (task 1004989):
+      // credits never price a module, so ?max_credits= is refused by name.
+      if (req.query && req.query.max_credits != null) {
+        return res.fail('bad_request', { status: 400, message: 'Credits do not price modules, so there is no maximum in credits. Use max_cents.' });
+      }
       const maxPrice = {};
-      for (const [param, field] of [['max_cents', 'cents'], ['max_credits', 'credits']]) {
-        const v = req.query && req.query[param];
-        if (v == null || v === '') continue;
+      const v = req.query && req.query.max_cents;
+      if (v != null && v !== '') {
         if (typeof v !== 'string' || !/^\d{1,9}$/.test(v)) {
-          return res.fail('bad_request', { status: 400, message: `${param} is a maximum price: a whole number, 0 or more.` });
+          return res.fail('bad_request', { status: 400, message: 'max_cents is a maximum price: a whole number, 0 or more.' });
         }
-        maxPrice[field] = Number(v);
+        maxPrice.cents = Number(v);
       }
       const listing = await listCatalog({ sort, maxPrice });
       res.set('Cache-Control', 'no-store');

package/src/bongos/serve-internal.js

@@ -1329,6 +1329,7 @@ function mountInternalSurfaces(app) {
   // The diagram image assets under /builders/diagrams/ ride the same tier as the
   // page that embeds them.
   const SIGNEDIN_BUILDERS_PREFIX_RE = /^\/builders\/diagrams\//;
+  const MARKET_WATCH_PAGE_RE = /^\/builders\/market-watch(?:-[a-z]+)?(?:\.html)?\/?$/; // task 1004941: every read behind them is requireBuilder
   app.use((req, res, next) => {
     if (isModuleSurfaceHost(req)) return next();
     // Cheap early-out: only /builders/* paths can ever be gated, so skip the
@@ -1342,7 +1343,7 @@ function mountInternalSurfaces(app) {
     // behind the proxy's path normalization.
     const norm = path.posix.normalize(req.path);
     if (SIGNEDIN_BUILDERS_PAGE_RE.test(norm) || SIGNEDIN_BUILDERS_PREFIX_RE.test(norm)
-      || TASK_DETAIL_PAGE_RE.test(norm) || IDEA_DETAIL_PAGE_RE.test(norm)) {
+      || TASK_DETAIL_PAGE_RE.test(norm) || IDEA_DETAIL_PAGE_RE.test(norm) || MARKET_WATCH_PAGE_RE.test(norm)) {
       return gdsAuth.requireBuilderPage(req, res, next);
     }
     next();

package/src/module-api.js

@@ -81,7 +81,7 @@ const { sleep } = require('./sleep');
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.24.7'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.24.9'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/government_act_alone_buildings.mjs

@@ -222,6 +222,7 @@ for (const rel of [
   'modules/security/routes/reports.js',
   'modules/onboarding/routes/access-requests.js',
   'modules/government/routes/government.js',
+  'modules/market-watch/routes/rules.js',
 ]) app.use(require(path.join(ROOT, rel))());
 const server = http.createServer(app);
 await new Promise((r) => server.listen(0, '127.0.0.1', r));
@@ -243,6 +244,8 @@ const REQUESTS = {
   'PATCH /project-settings/ship-mode': ['PATCH', '/project-settings/ship-mode', { mode: 'sometimes' }],
   'PATCH /project-settings/tweak-autopickup': ['PATCH', '/project-settings/tweak-autopickup', { mode: 'sometimes' }],
   'PATCH /work-categories/:id': ['PATCH', `/work-categories/${BAD}`, {}],
+  // task 1004941: the owner deciding a Market Watch proposal
+  'POST /market-watch/proposals/:id/decide': ['POST', `/market-watch/proposals/${BAD}/decide`, { decision: 'approve' }],
   'POST /security/reports/:id/confirm': ['POST', `/security/reports/${BAD}/confirm`, {}],
   'POST /security/reports/:id/dispute': ['POST', `/security/reports/${BAD}/dispute`, {}],
   'POST /security/reports/:id/fix': ['POST', `/security/reports/${BAD}/fix`, {}],

package/tests/government_decision_rules.mjs

@@ -475,7 +475,10 @@ test('a matter\'s act is checked when it is opened: People only, a custom rank o
     openBoardItem: async () => { throw new Error('must not be reached'); },
   }, async () => {
     const act = (a) => ({ type: 'assign_rank', builder_id: 7, rank_key: 'tester', ...a });
-    assert.equal((await board.openMatter({ area: 'rules', title: 't', action: act(), proposedBy: '42' })).reason, 'action_not_supported_here');
+    // task 1004941: Rules now carries one act of its own (a Market Watch proposal), so a
+    // People act there is the wrong act; a building with no acts still refuses any act
+    assert.equal((await board.openMatter({ area: 'rules', title: 't', action: act(), proposedBy: '42' })).reason, 'bad_action');
+    assert.equal((await board.openMatter({ area: 'planning', title: 't', action: act(), proposedBy: '42' })).reason, 'action_not_supported_here');
     assert.equal((await board.openMatter({ area: 'people', title: 't', action: act({ rank_key: 'metic' }), proposedBy: '42' })).reason, 'seeded_rank');
     assert.equal((await board.openMatter({ area: 'people', title: 't', action: act({ rank_key: 'ghost' }), proposedBy: '42' })).reason, 'unknown_rank');
     assert.equal((await board.openMatter({ area: 'people', title: 't', action: act({ type: 'promote' }), proposedBy: '42' })).reason, 'bad_action');