@bongos/core 1.24.45 → 1.24.46

package/tests/hall_tokens.mjs

@@ -82,6 +82,21 @@ const contractTier = declarations(bodyAt(src.indexOf('{', bareRoots[0].index)));
 const darkExplicit = declarations(blockAfter('html[data-theme="dark"] {'));
 const darkMedia = declarations(blockAfter('html:not([data-theme]) {'));
 
+// THE SHARED TOKEN SHEET (task 1005081). style.css @imports
+// modules/ui-design/public/tokens.css first, so its scales (--ds-*) sit UNDER the
+// hall's own declarations, and the hall's scale names (--radius, --sp-*, --z-*,
+// --shadow-pop, --line, --label-size) are aliases onto it. Its :root and its dark
+// switch rule are read here so the resolver sees what the browser sees.
+const SHARED_SRC = fs.readFileSync(path.join(ROOT, 'modules', 'ui-design', 'public', 'tokens.css'), 'utf8');
+const sharedBlock = (marker) => {
+  const at = SHARED_SRC.indexOf(marker);
+  assert.notEqual(at, -1, `tokens.css no longer contains ${marker} — update this test`);
+  const open = SHARED_SRC.indexOf('{', at);
+  return declarations(SHARED_SRC.slice(open + 1, SHARED_SRC.indexOf('}', open)));
+};
+const sharedRoot = sharedBlock(':root {');
+const sharedDark = sharedBlock('html[data-theme="dark"]');
+
 // THE CASCADE THAT ACTUALLY SHIPS. injectBrandingInto splices the pack's theme
 // <style> at the END of <head> — after style.css's <link> — as a plain :root.
 // Equal specificity, later in document order, so for the tokens the pack emits
@@ -112,8 +127,8 @@ const NIGHT_TINT = process.env.UI_DESIGN_TINT === '1'
   : {};
 
 const RAW = {
-  light: { ...contractTier, ...PACK },
-  dark: { ...contractTier, ...PACK, ...darkExplicit, ...NIGHT_TINT },
+  light: { ...sharedRoot, ...contractTier, ...PACK },
+  dark: { ...sharedRoot, ...contractTier, ...PACK, ...sharedDark, ...darkExplicit, ...NIGHT_TINT },
 };
 
 // ── color resolution ─────────────────────────────────────────────────────────
@@ -319,7 +334,10 @@ test('--line is a width, not a colour', () => {
   // DESIGN.md warns about this exact name: --line is a 1px WIDTH here and a
   // hairline COLOUR in the hub's sheet. Page sheets that treated it as a colour
   // were repointed at --rule / --rule-soft in task 1003303.
-  assert.match(contractTier['--line'], /^\d+px$/, '--line must resolve to a length');
+  // an alias onto the shared sheet since task 1005081 — follow it one step
+  const alias = /^var\((--[\w-]+)\)$/.exec(contractTier['--line']);
+  const line = alias ? sharedRoot[alias[1]] : contractTier['--line'];
+  assert.match(String(line), /^\d+px$/, '--line must resolve to a length');
   const sheets = fs.readdirSync(HALL).filter((f) => f.endsWith('.css'));
   const misuse = sheets.filter((f) => /var\(--line\s*,/.test(fs.readFileSync(path.join(HALL, f), 'utf8')));
   assert.deepEqual(misuse, [], 'a colour fallback on --line means the sheet thinks it is a colour');
@@ -346,6 +364,7 @@ test('every token a hall stylesheet references is defined', () => {
   const sheets = fs.readdirSync(HALL).filter((f) => f.endsWith('.css'));
   const defined = new Set([
     ...Object.keys(contractTier), ...Object.keys(darkExplicit), ...Object.keys(PACK),
+    ...Object.keys(sharedRoot), // the shared token sheet the hall @imports (task 1005081)
   ]);
   // A sheet may define its own private tokens (atlas.css's --ab-* family), and
   // a page script may set one inline on the element (roadmap.js writes

package/tests/ui_design_kit.mjs

@@ -125,6 +125,36 @@ test('the page argument survives Git Bash path conversion of a bare slash', () =
   assert.equal(lib.pageName('/'), 'index'); assert.equal(lib.pageName('/builders/ranks'), 'ranks'); assert.equal(lib.pageName('/projects?view=mine'), 'projects');
 });
 
+test('a page at the surface root reads index.states.json (task 1005080)', () => {
+  const hall = path.join(ROOT, 'modules', 'hall-ui', 'public');
+  assert.equal(lib.sidecarPath(hall, '/builders/', 'states'), path.join(hall, 'index.states.json'), 'the hall Home has no last segment of its own');
+  assert.equal(lib.sidecarPath(hall, '/builders/work', 'states'), path.join(hall, 'work.states.json'), 'a named page keeps its own file');
+  const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'kit-root-'));
+  assert.equal(lib.sidecarPath(tmp, '/builders/', 'states'), path.join(tmp, 'builders.states.json'), 'no index file: the old name stands, so the miss is reported by name');
+});
+
+test('storage: a states or probes file may seed browser storage, and a bad shape is refused (task 1005080)', () => {
+  const ok = { page: '/x', storage: { session: { a: '1' }, local: { b: 'x' } }, states: { s: { storage: { session: { c: '2' } } } } };
+  assert.deepEqual(lib.validateStatesFile(ok).errors, []);
+  assert.ok(lib.validateStatesFile({ page: '/x', storage: { cookie: {} }, states: { s: {} } }).errors.some((e) => /storage\.cookie/.test(e)), 'only session and local');
+  assert.ok(lib.validateStatesFile({ page: '/x', storage: { session: { a: 1 } }, states: { s: {} } }).errors.some((e) => /storage\.session/.test(e)), 'values are strings');
+  assert.ok(lib.validateStatesFile({ page: '/x', states: { s: { storage: [] } } }).errors.some((e) => /states\.s\.storage/.test(e)), 'a state may carry its own');
+  assert.ok(lib.validateProbesFile({ page: '/x', storage: 'yes', probes: [{ name: 'p', expect: { visible: ['a'] } }] }).errors.some((e) => /^storage/.test(e)), 'a probes file too');
+  assert.deepEqual(lib.mergeStorage({ session: { a: '1', b: '1' } }, undefined, { session: { b: '2' }, local: { c: '3' } }), { session: { a: '1', b: '2' }, local: { c: '3' } }, 'a state layers over the file');
+});
+
+test('every hall sidecar renders the page a returning builder sees, not the first-visit mode picker (task 1005080)', () => {
+  const hall = path.join(ROOT, 'modules', 'hall-ui', 'public');
+  const files = fs.readdirSync(hall).filter((n) => /\.(states|probes)\.json$/.test(n));
+  assert.ok(files.length > 30);
+  for (const n of files) {
+    const json = JSON.parse(fs.readFileSync(path.join(hall, n), 'utf8'));
+    assert.equal(json.storage && json.storage.session && json.storage.session['hall-craft-asked'], '1', `${n}: seeds the picker as already asked`);
+  }
+  // the key is craft-mode.js's own; a rename there must break this pin, not silently bring the picker back
+  assert.match(fs.readFileSync(path.join(hall, 'craft-mode.js'), 'utf8'), /var ASKED_KEY = 'hall-craft-asked';/);
+});
+
 // ── the mock checker: platform rules vs the instance's taste ──────────────────
 const GOOD_MOCK = `<!doctype html><html><head><style>
 body{--pad:8px;color:var(--ink);background:var(--bg)}

package/tests/welcome_boot_browser.mjs

@@ -89,6 +89,8 @@ test('first visit of the day: the welcome, not the craft picker; Skip brings the
   await signIn(page);
   assert.deepEqual(await state(page), { welcome: true, picker: false, craft: null, asked: '1' },
     'the welcome shows, the picker is marked asked and does not stack on it');
+  assert.equal(await page.evaluate(() => document.querySelector('.wb__banner').tagName), 'DIV',
+    'over a signed-in hall the shell keeps the one <header>; the banner is a plain block (task 1005080)');
   // The painting loads and its motion is laid over it.
   await page.waitForFunction(() => { const i = document.querySelector('#welcome-boot .wb__img'); return i && i.complete && i.naturalWidth === 1024; });
   assert.equal(await page.isVisible('[data-wb-skip]'), true);
@@ -135,9 +137,11 @@ test('a visitor who is not signed in gets the Welcome on Home with a sign-in but
     roles: !!document.querySelector('[data-wb-roles]'),
     keys: Object.keys(localStorage).filter((k) => k.startsWith('hall-welcome-day') || k === 'hall-welcome-signin'),
     picker: !!document.getElementById('craft-picker'),
+    banner: document.querySelector('.wb__banner').tagName,
   }));
   assert.match(s.hi, /^Welcome to /);
   assert.deepEqual([s.signin, s.roles, s.keys, s.picker], [true, false, [], false]);
+  assert.equal(s.banner, 'HEADER', 'for a visitor the welcome is the page, so its banner is the one <header> (task 1005080)');
   await ctx.close();
 });