@bongos/core 1.24.41 → 1.24.43

package/modules/hall-ui/public/builders.js

@@ -25,12 +25,11 @@
   const { moduleOn } = window.OTB;
 
   // ---- tiny helpers --------------------------------------------------------
-  // escapeHtml / $ / fmtNum / fmtDate / rankLabel / toast now come from the
-  // shared window.OTB toolkit (dom-utils.js, loaded first). Thin wrappers keep
-  // this file's exact variants (date-only fmtDate; '—' rankLabel empty; a
-  // 2200ms clearing toast). renderRankBadge + RANK_ORDER stay local below.
+  // escapeHtml / $ / fmtNum / rankLabel / toast now come from the shared
+  // window.OTB toolkit (dom-utils.js, loaded first). Thin wrappers keep this
+  // file's exact variants ('—' rankLabel empty; a 2200ms clearing toast).
+  // renderRankBadge + RANK_ORDER stay local below.
   const { escapeHtml, $, fmtNum } = window.OTB;
-  const fmtDate = (iso) => window.OTB.fmtDate(iso);
   const rankLabel = (rank) => window.OTB.rankLabel(rank);
   const toast = (msg) => window.OTB.toast(msg, { duration: 2200, clear: true });
 
@@ -64,16 +63,6 @@
     return res.data;
   }
 
-  async function patchJSON(path, body) {
-    const res = await api.request('PATCH', path, { body });
-    if (res.status === 401) {
-      window.location.assign(`${API}/auth/web/start`);
-      throw new Error('redirecting to auth');
-    }
-    if (!res.ok) throw new Error(`${path} → ${res.status}`);
-    return res.data;
-  }
-
   async function postJSON(path, body) {
     const res = await api.request('POST', path, { body });
     if (res.status === 401) {
@@ -104,36 +93,17 @@
     return res.data;
   }
 
-  // ---- shared render helpers (C10) ----------------------------------------
-
-  // emptyRow — the placeholder/error <tr> every ledger table renders when it has
-  // nothing (or failed) to show. `message` is plain copy (escaped defensively
-  // even though current callers pass static literals).
-  function emptyRow(colspan, message) {
-    return `<tr><td colspan="${colspan}" class="ledger__empty">${escapeHtml(message)}</td></tr>`;
-  }
-
-  // signClasses — the up/down/flat BEM modifier for a signed number. `prefix` is
-  // the block, e.g. signClasses(delta, 'karma-feed__delta') → 'karma-feed__delta--up'.
-  // The +/- TEXT differs per feed (fmtNum vs raw int vs '±0'), so callers format
-  // the displayed value themselves.
-  function signClasses(n, prefix) {
-    const v = Number(n) || 0;
-    return `${prefix}--${v > 0 ? 'up' : v < 0 ? 'down' : 'flat'}`;
-  }
-
-  // (task 2174: the hand-rolled renderPager the ships + roster tables shared is
-  // gone — both now use the OTBKit pager, which clamps, persists per-page and
-  // paints the bar from one implementation.)
+  // (task 1005050: emptyRow and signClasses went to profile-own.js with the
+  // ledgers and the karma feed that used them; nothing on Home draws one.)
 
-  // ---- repo info (the clone URL the welcome walkthrough hands a newcomer) ---
+  // ---- repo info (the clone URL the setup screen hands a newcomer) ---
   //
   // The /builder-* commands live INSIDE the repo (.claude/skills/, shelling out
   // to scripts/bongos/*.js). The old repo-clone walkthrough (and the
   // /public/repo-info fetch that fed it) was removed with the setup-first
-  // redesign (#777); the welcome panel's clone block now reads the instance's
-  // repo coords instead. The /public/repo-info surface still exists for other
-  // callers.
+  // redesign (#777); the setup screen's clone block (setup-gate.js, task 1005076)
+  // reads the instance's repo coords instead. The /public/repo-info surface
+  // still exists for other callers.
 
   // ---- rank badge (V3.R16 #240) -------------------------------------------
   // Three live ranks per ADR 0018: archon > metic > xenos. Missing rank
@@ -149,7 +119,7 @@
   // xenos — #692 / ADR 0034) to the entry rank. Reserved values still on the
   // citizen/divine ladder would otherwise render as a dashed "unknown" plaque
   // while the hall elsewhere shows them as xenos. Applied to the
-  // builder-facing standing surfaces — the welcome panel, the profile Standing
+  // builder-facing standing surfaces — the profile Standing
   // badge, and the public Roll — so they agree. NOT applied to the Archon-only
   // roster below, which intentionally shows the true stored rank so an Archon
   // can spot and fix a stray value. hall-render.js's "Where you stand" card
@@ -187,27 +157,10 @@
   // GATE new claims and whose reward is pending until they land on ship.
   let lastRebaseState = null;
 
-  // Cached /me payload from the most recent loadAll() call. Used by the
-  // welcome-chip reopen path (#408) so we can re-render the welcome panel
-  // from cached state without a fresh /me round-trip. Distinct from
-  // lastKarmaState: that one only stashes karma; this stashes the whole
-  // payload so renderWelcome's builder + onboarding args are available.
+  // Cached /me payload from the most recent loadAll() call, for re-renders
+  // that need the builder without a fresh /me round-trip.
   let lastMeState = null;
 
-  // Instance repo coords for the "get the code" clone block. The public instance
-  // manifest (GET /api/bongos/instance) is the channel for cross-instance repo coords
-  // — clientBranding deliberately omits `repo`, so window.__BRANDING__ can't carry
-  // it. Cached; the welcome re-renders when it lands so a fresh instance shows ITS
-  // OWN repo, never a hardcoded one (ADR 0062 §3, task 1705).
-  let instanceRepo = null;
-  async function loadInstanceRepo() {
-    try {
-      const inst = await getJSON(`${API}/instance`, { softAuth: true });
-      instanceRepo = inst && inst.repo && !inst.repo.error ? inst.repo : null;
-      if (instanceRepo && lastMeState) renderWelcome(lastMeState.builder, lastMeState.onboarding || null);
-    } catch (_) { /* best-effort — the clone block falls back to generic guidance */ }
-  }
-
   // ---- hall section nav (#408) --------------------------------------------
   //
   // Single source of truth for what appears in the sticky strip at top of
@@ -218,9 +171,6 @@
   //
   // Filter rules at render time:
   //   archonOnly: true → skip unless /me returns rank=archon.
-  //   welcomeChip:true → ALWAYS shown pre-graduation (even when the
-  //                      panel is dismissed) so the builder can re-open
-  //                      it. Hidden post-graduation just like the panel.
   //   default          → skip if the section's element is [hidden].
   //
   // Adding a new section: add a row here AND give the <section> a stable
@@ -242,31 +192,17 @@
   // per-widget gates (archonOnly) carried on the registry entry.
 
   // task 1723: which container a widget mounts into. A widget may declare
-  // `zone` (a fine-grained Home slot), `group` (a Standing rail section, task
-  // 2174) or `view` (home/standing); all default to the Home main
-  // zone so pre-redesign module widgets still land somewhere visible. Every
+  // `zone` (a fine-grained Home slot) or `view` (only 'home' since task 1005050
+  // folded the Standing view into the Profile page); both default to the Home
+  // main zone so pre-redesign module widgets still land somewhere visible. Every
   // container lives INSIDE <main>, so the `main .scroll` sweeps (newcomer gate,
   // landing hide-all) keep working.
 
-  // task 2174: Standing is an identity band + four rail sections grouped by the
-  // question they answer. This array is the rail's order and its labels; each
-  // entry gets a #standing-<key> anchor container inside #zone-standing that the
-  // group's widgets mount into. The Profile card declares no group, so it stays
-  // above them as the band.
-
-  // Create ALL four group containers the first time any group is asked for, so
-  // the rail's order is STANDING_GROUPS' — not whichever group's first widget
-  // happens to register earliest. Creating them on demand (rather than up front)
-  // is what keeps the Profile band on top: an ungrouped Standing widget appends
-  // straight to #zone-standing, so anything registered before the first grouped
-  // widget lands above the groups. Idempotent.
-
-
   // mountHallWidgets — stamp every registered widget's <section> into its view
   // container (falling back to <main>), in registry order, then render its
   // skeleton via mount(host). Idempotent: a second call (defensive) re-uses an
   // existing <section>. Runs once at bootstrap BEFORE wireEvents() so the static
-  // element ids the data-render + event-wiring code expects (#welcome-minimize,
+  // element ids the data-render + event-wiring code expects (#acclaim-feed,
   // #recent-ships, #lb-prev, …) are present. Each widget mount is
   // failure-isolated so one bad widget can't blank the hall.
   // task 2169: zone budgets — Home cannot grow unbounded again. Caps count
@@ -277,17 +213,9 @@
   // The budgets themselves become a CI fitness assertion in task 2177.
 
 
-  // task 2174: the Standing rail is an OTBKit sectionRail in scrollspy mode —
-  // the kit owns the IntersectionObserver that used to live here as
-  // setupNavObserver(). Built lazily on the first renderNav and refreshed after,
-  // so the same instance survives re-renders.
-  //   2. the Home re-open affordance for a dismissed welcome banner (the old
-  //      welcome chip's only job);
-  //   3. the Standing view's in-page section rail (#standing-rail) — task 2174:
-  //      one entry per GROUP that currently has something to show, not one per
-  //      widget. A group with every member hidden (a newcomer, an empty karma
-  //      feed) hides itself and drops off the rail.
-  // Keeps its (builder, onboarding) signature — all call sites pass them.
+  // (The Standing view's section rail lived in renderNav until task 1005050
+  // folded the view into the Profile page.) renderNav keeps its (builder,
+  // onboarding) signature — all call sites pass them.
 
   // #748: newcomer gate. A Xenos sees a deliberately spare hall — their
   // onboarding path and their Standing card — until they graduate to Thetes.
@@ -309,7 +237,7 @@
   // (which un-hide their own scroll on data) respect it; the section-hiding
   // sweep then runs before renderNav so the chip strip matches.
   const NEWCOMER_VISIBLE_SECTIONS = new Set([
-    'welcome-scroll', 'onboarding-scroll', 'profile-scroll',
+    'profile-scroll',
   ]);
   let newcomerGated = false;
 
@@ -325,21 +253,6 @@
     // gates. This function keeps only the widget-section sweep.
   }
 
-  function reopenWelcomeFromNav(e) {
-    e.preventDefault();
-    const id = window.__buildersSelfId;
-    if (!id || !lastMeState) return;
-    try {
-      window.localStorage.removeItem(welcomeDismissalKey(id));
-    } catch (_) { /* private mode — re-open in-memory only */ }
-    // Re-render welcome from cached /me state and refresh the nav so the
-    // chip drops its "dismissed" styling.
-    renderWelcome(lastMeState.builder, lastMeState.onboarding || null);
-    renderNav(lastMeState.builder, lastMeState.onboarding || null);
-    // Now scroll to the (newly-unhidden) welcome panel.
-    const target = document.getElementById('welcome-scroll');
-    if (target) target.scrollIntoView({ behavior: 'smooth', block: 'start' });
-  }
 
 
   // Wires the public landing's access-request form. Submits to the one public
@@ -353,445 +266,9 @@
   // renderDiscordLink / unlinkDiscord (F7, ADR 0033) moved to
   // public-builders/settings.js — these controls now live on /builders/settings.
 
-  async function saveDisciplines() {
-    const selected = Array.from(document.querySelectorAll('.disc-pref'))
-      .filter((el) => el.checked)
-      .map((el) => el.value);
-    const btn = $('#disc-save');
-    if (btn) { btn.disabled = true; btn.textContent = 'Saving…'; }
-    try {
-      const resp = await patchJSON(`${API}/me/disciplines`, { preferred_disciplines: selected });
-      renderProfile(resp.builder);
-      toast(selected.length ? `Preferred work: ${selected.join(', ')}` : 'Preference cleared.');
-    } catch (err) {
-      if (err && err.message === 'redirecting to auth') return;
-      console.error('[builders] save disciplines failed', err);
-      toast('Could not save your preference. Try again.');
-      if (btn) { btn.disabled = false; btn.textContent = 'Save'; }
-    }
-  }
-
-  // ---- first-visit welcome panel (V3.R77 #296) ----------------------------
-  // Greets a not-yet-graduated builder with their rank, what their rank
-  // unlocks, the next checklist step, and the two doors into the hall: the
-  // orientation maps and the /builder-start command. Dismissable. Reappears
-  // if the builder's onboarding stage regresses (rare — e.g. a stage row
-  // wipe in dev or an Archon-driven reset).
-  //
-  // Persistence: localStorage key `builders:welcome-dismissed:<builder_id>`
-  // stores the stage *index* (0-6) at the moment of dismissal. On every
-  // render we compute the builder's current stage index; if it's strictly
-  // less than the dismissed-at index, the panel reappears. Per-builder key
-  // so a shared browser doesn't carry one builder's dismissal to another.
-  //
-  // The panel only renders for the LOGGED-IN viewer (uses /me). It is not
-  // shown on profile pages of other builders — that's the read-only
-  // onboarding-list panel below, which is roster-visible.
-
-  // Canonical order of the onboarding stages, mirroring
-  // src/bongos/onboarding-state.js STAGES. 'graduated' is the terminal stage;
-  // when current === 'graduated' the panel hides entirely.
-
-
-
-  // task 2169 (banner budget): exactly one banner panel at a time. The
-  // checklist render runs before the welcome render in the boot pass, so after
-  // the welcome panel's visibility settles we re-evaluate the checklist —
-  // welcome visible → checklist waits; welcome dismissed/hidden → checklist
-  // takes the banner slot (renderOnboarding carries the mirror check).
-  function renderWelcome(builder, onboarding) {
-    renderWelcomeCore(builder, onboarding);
-    renderOnboarding(
-      onboarding || (lastMeState && lastMeState.onboarding) || null,
-      lastMeState && lastMeState.discord
-    );
-  }
-
-
-  // ---- onboarding checklist (V3.R75 #294; reshaped #777) ------------------
-  // Renders the "Path into the City" checklist for the CURRENT logged-in
-  // builder. Hidden once graduated (current_stage === 'graduated') so it
-  // doesn't clutter the hall for full citizens. The displayed list (#777) is a
-  // short, action-only orientation path: Join Discord → Choose craft → Run
-  // /builder-setup → Ship three (→ Thetes). Every step AUTO-detects server-side
-  // (#777, per Lars: no manual ticks). Only two carry a control:
-  //   * pick_disciplines — the craft picker (PATCH /me/disciplines).
-  //   * join_discord      — a Connect-Discord button (the existing OAuth flow,
-  //                         auto-joins + assigns rank role); clears when linked.
-  // cli_setup clears once the Bongos CLI is authenticated (db.hasCliSession) and
-  // ship_three on the 3rd ship — both passive. The terminal ship_three step
-  // shows the live "N of 3" counter (its `detail`). `discord` is the /me discord
-  // block ({ linked, configured }) — when Discord isn't configured server-side
-  // the Connect button is suppressed.
-
-
-  // V3 (2026-05-30): clear the pick_disciplines onboarding stage from the path
-  // checklist. Saves the chosen craft via the same PATCH /me/disciplines route
-  // the profile uses, then re-renders the checklist (and the profile picker) so
-  // both reflect the choice. The route echoes the updated onboarding state.
-  async function pickDiscipline(value) {
-    // Multi-select toggle: add the craft if not yet chosen, remove it if it is,
-    // then save the full set (any mix of engineer, artist, ideator).
-    const current = (lastMeState && lastMeState.builder && Array.isArray(lastMeState.builder.preferred_disciplines))
-      ? lastMeState.builder.preferred_disciplines : [];
-    const selected = current.includes(value)
-      ? current.filter((d) => d !== value)
-      : [...current, value];
-    const buttons = document.querySelectorAll('.onboarding-item__disc');
-    buttons.forEach((b) => { b.disabled = true; });
-    try {
-      const resp = await patchJSON(`${API}/me/disciplines`, { preferred_disciplines: selected });
-      if (resp.builder && lastMeState) {
-        // Keep the cached /me state and the profile picker in sync.
-        lastMeState.builder = resp.builder;
-        lastMeState.onboarding = resp.onboarding || lastMeState.onboarding;
-      }
-      if (resp.onboarding) renderOnboarding(resp.onboarding, lastMeState && lastMeState.discord);
-      if (resp.builder) renderProfile(resp.builder);
-      const axis = window.OTB.roleAxisLabel();
-      toast(selected.length ? `${axis}: ${selected.map((d) => window.OTB.roleLabel(d)).join(', ')}.` : `${axis} cleared.`);
-    } catch (err) {
-      if (err && err.message === 'redirecting to auth') return;
-      console.error('[builders] pick discipline failed', err);
-      toast('Could not save just now. Try again.');
-      buttons.forEach((b) => { b.disabled = false; });
-    }
-  }
-
-  // ---- achievements --------------------------------------------------------
-
-  function renderAchievements(all, unlocked, lockedWithProgress) {
-    const unlockedById = new Map(unlocked.map((u) => [u.achievement_id, u]));
-    // Map achievement_id → progress_text for locked entries. Falsy/empty
-    // progress just shows the credit-bonus line as before.
-    const progressById = new Map(
-      (lockedWithProgress || []).map((l) => [l.achievement_id, l.progress_text || '']),
-    );
-    const grid = $('#ach-grid');
-    if (!all.length) {
-      grid.innerHTML = `<div class="profile__placeholder">No achievements earned yet.</div>`;
-      return;
-    }
-    grid.innerHTML = all.map((a) => {
-      const got = unlockedById.get(a.id);
-      const cls = got ? 'ach' : 'ach ach--locked';
-      const bonus = a.credit_bonus ? `<p class="ach__bonus">+${fmtNum(a.credit_bonus)} ${(window.OTBBranding?.currencyLabel?.() ?? 'credits')}</p>` : '';
-      const when = got ? `<p class="ach__bonus">Won ${fmtDate(got.unlocked_at)}</p>` : '';
-      const progress = !got && progressById.has(a.id) && progressById.get(a.id)
-        ? `<p class="ach__progress">${escapeHtml(progressById.get(a.id))}</p>`
-        : '';
-      return `
-        <div class="${cls}" title="${escapeHtml(a.id)}">
-          <div class="ach__icon" aria-hidden="true">${escapeHtml(a.icon || '✦')}</div>
-          <div class="ach__body">
-            <p class="ach__name">${escapeHtml(a.name)}</p>
-            <p class="ach__desc">${escapeHtml(a.description || '')}</p>
-            ${when || bonus}
-            ${progress}
-          </div>
-        </div>
-      `;
-    }).join('');
-  }
-
-  // ---- recent ships --------------------------------------------------------
-
-  // All shipped works for this builder, fetched once via ?limit=all then
-  // filtered, sorted, and paged entirely client-side. Mirrors the status site's
-  // Lately Inscribed pattern (modules/status-ui/public/status.js renderShippedPage), with
-  // an additional version filter since a builder's history spans versions.
-  // task 2174: paging moved to the OTBKit pager (per-page select + persistence);
-  // 10 stays the default page size this table has always used.
-
-
-  // task 1957 — a shipped row's payout is the ACTUAL ledger figure (credits_awarded),
-  // not the creation-time estimate. taskCreditValue picks the right one by status.
-
-
-
-  // Re-render when filters change. Reset to page 1 so the new filter starts at
-  // the top — otherwise switching to a smaller window can leave you on page 9
-  // of a 2-page result.
-  function onShipsFilterChange() {
-    shipsPager.page = 1;
-    renderRecentShips();
-  }
-
-  // ---- recent grades (task 197) -------------------------------------------
-
-  function renderRecentGrades(grades) {
-    const tbody = $('#recent-grades tbody');
-    if (!tbody) return;
-    if (!grades || !grades.length) {
-      tbody.innerHTML = emptyRow(5, 'No work reviewed yet.');
-      return;
-    }
-    tbody.innerHTML = grades.map((g) => {
-      // A grader OUTAGE row (panel_outcome 'unavailable') carries a placeholder
-      // score of 0 — label it, never render it as a 0.0 fail (task 1002652).
-      const isOutage = g.panel_outcome === 'unavailable';
-      // A json-null gating axis (task 1003318 — the Quality worker never ran)
-      // is likewise not a judgment: the score is the surviving axis, not a fail.
-      const isLensOut = !isOutage && !!g.rubric_scores && g.rubric_scores.code_quality === null;
-      const score = isOutage || isLensOut ? '—' : Number(g.score).toFixed(1);
-      // A verdict is verification state: it wears the fixed vocabulary through
-      // .ledger__verdict--* (style.css), never an inline colour. The literals
-      // that stood here painted `passed` from a --olive that is not a token of
-      // the world, so every hall ever rendered it as the fallback (task 1003495).
-      const verdict = isOutage
-        ? `<span class="ledger__verdict--none">not graded (grader outage)</span>`
-        : isLensOut
-          ? `<span class="ledger__verdict--none">not graded (quality lens unavailable)</span>`
-          : g.passed
-          ? `<span class="ledger__verdict--ok">passed</span>`
-          : `<span class="ledger__verdict--danger">fell short</span>`;
-      return `
-        <tr>
-          <td class="ledger__num">#${g.task_id}</td>
-          <td>${escapeHtml(g.title || '')}</td>
-          <td class="ledger__drachmae">${isOutage || isLensOut ? '—' : `${score} / 10`}</td>
-          <td>${verdict}</td>
-          <td class="ledger__date">${fmtDate(g.graded_at)}</td>
-        </tr>
-      `;
-    }).join('');
-  }
-
-  function renderRollingNote(rolling) {
-    const note = $('#grades-rolling-note');
-    if (!note) return;
-    if (!rolling || !rolling.n || Number(rolling.n) === 0) {
-      note.hidden = true;
-      return;
-    }
-    const avg = Number(rolling.avg_score).toFixed(1);
-    const passed = Number(rolling.n_passed || 0);
-    const n = Number(rolling.n);
-    note.textContent = `Last 14 days: ${avg} / 10 average across ${n} graded work${n === 1 ? '' : 's'} (${passed} passed).`;
-    note.hidden = false;
-  }
-
-  // ---- the dev curve (V3.R72 #291, C5) ------------------------------------
-  //
-  // Per-builder historical analytics: ship rate, cost-per-task, duration, and
-  // grade pass-rate over time, plus a top-kinds fingerprint. Charts are inline
-  // SVG sparklines — no chart library (the task spec's explicit constraint).
-  // An Archon additionally gets a "You / All builders" scope toggle backed by
-  // the ecosystem aggregate (individuals stripped), satisfying the
-  // cross-builder view requirement without a per-builder roster on this page.
-
-
-  // Build a tiny SVG line sparkline from an array of numeric y-values. Returns
-  // a self-contained <svg> string. A flat/short series degrades to a baseline.
-
-
-
-  const pct = (v) => (v == null ? '—' : `${Math.round(Number(v) * 100)}%`);
-  const usd = (v) => `$${(Number(v) || 0).toFixed(2)}`;
-  const mins = (v) => (v == null ? '—' : `${Math.round(Number(v))}m`);
-
-  // Render the curve for whichever scope is active. `data` is either the self
-  // payload (/analytics/builder/:id) or the ecosystem payload, normalized below.
-
-  // Fire-and-forget loader: fetch the builder's own curve (and, for an Archon,
-  // the ecosystem aggregate) and render. A failed/empty feed simply leaves the
-  // section hidden rather than holding up the rest of the hall.
-  async function loadAnalytics(builder) {
-    const scroll = $('#analytics-scroll');
-    if (!scroll || !builder?.id) return;
-    analyticsState.builderId = builder.id;
-    analyticsState.scope = 'self';
-    analyticsState.kind = null;
-    try {
-      const self = await getJSON(`${API}/analytics/builder/${builder.id}?days=90`);
-      analyticsState.self = self;
-      // The picker's options come from THIS first, unfiltered load and are then
-      // left alone — see kindFilterHtml. A later filtered payload's top_kinds is
-      // deliberately not allowed to overwrite them.
-      analyticsState.kinds = Array.isArray(self?.top_kinds) ? self.top_kinds : [];
-      // A gated newcomer with nothing shipped: keep the section hidden.
-      if (!self || (self.headline?.total_shipped || 0) === 0) { scroll.hidden = true; return; }
-      scroll.hidden = false;
-      renderCurveBody();
-      renderNav(builder, lastMeState?.onboarding || null); // re-show the Curve chip now that the section is visible
-      // THE BENCHMARK IS FOR EVERY BUILDER, NOT JUST THE ARCHON (task 1004005).
-      // This fetch used to sit behind `if (analyticsState.isArchon)`, so the
-      // ecosystem average a builder is meant to measure themselves against was
-      // fetched for exactly one of them. The route is `rank: public` — no auth
-      // middleware, CORS '*', per-builder identity stripped server-side — and the
-      // unauthenticated status page already reads it, so the gate protected
-      // nothing and only withheld the comparison. Still fire-and-forget: the
-      // ecosystem feed is optional context, never a reason to hold up the curve.
-      getJSON(`${API}/public/analytics/ecosystem?days=90`)
-        // ALWAYS re-render, not only in the 'eco' scope. That condition was
-        // correct while the two scopes merely SWAPPED which single series was
-        // drawn; now the ecosystem series is also the benchmark overlaid on the
-        // 'self' view, so a self-scoped reader who arrived before this resolved
-        // would sit with no overlay until they touched an unrelated control.
-        .then((eco) => { analyticsState.eco = eco; renderCurveBody(); })
-        .catch(() => { /* ecosystem optional */ });
-    } catch (err) {
-      console.error('[builders] analytics load failed', err);
-      scroll.hidden = true;
-    }
-  }
-
-  // Re-fetch BOTH series under a kind filter (task 1004005). Both, always: an
-  // overlay that narrowed one side and not the other would compare one kind of
-  // work against all work and still look like a like-for-like benchmark — the
-  // failure this task's own text calls worse than no benchmark at all.
-  //
-  // `kinds` is deliberately not refreshed here; see kindFilterHtml.
-  let curveKindSeq = 0;
-  async function reloadCurveForKind(kind) {
-    const id = analyticsState.builderId;
-    if (!id) return;
-    analyticsState.kind = kind;
-    // A dropdown can be changed faster than a round trip returns, and the two
-    // fetches can land out of order. Only the newest request may write state.
-    const seq = ++curveKindSeq;
-    const q = kind ? `&kind=${encodeURIComponent(kind)}` : '';
-    renderCurveBody(); // reflect the new selection immediately
-    try {
-      const [self, eco] = await Promise.all([
-        getJSON(`${API}/analytics/builder/${id}?days=90${q}`),
-        getJSON(`${API}/public/analytics/ecosystem?days=90${q}`).catch(() => null),
-      ]);
-      if (seq !== curveKindSeq) return;
-      analyticsState.self = self;
-      if (eco) analyticsState.eco = eco;
-      renderCurveBody();
-    } catch (err) {
-      if (seq !== curveKindSeq) return;
-      console.error('[builders] curve kind filter failed', err);
-    }
-  }
-
-  // ---- karma feed (V3.R26 #246) -------------------------------------------
-  //
-  // The recent karma_log entries for the current builder. The /me payload
-  // already includes them under `karma.recent`. The scroll stays hidden when
-  // the builder has no history yet (zero karma is a common starting state,
-  // so we don't want to push an empty table at every new citizen).
-
-  function renderKarmaFeed(entries) {
-    const scroll = $('#karma-scroll');
-    const tbody = $('#karma-feed tbody');
-    if (!scroll || !tbody) return;
-    if (!Array.isArray(entries) || entries.length === 0) {
-      // Hide the scroll entirely if the builder has no karma history.
-      // Keeps the page tidy for fresh citizens; reappears the moment a
-      // karma_log row lands.
-      scroll.hidden = true;
-      return;
-    }
-    // #748: a gated newcomer never shows the karma feed, even if karma exists.
-    scroll.hidden = newcomerGated;
-    tbody.innerHTML = entries.map((k) => {
-      const delta = Number(k.delta) || 0;
-      const deltaCls = signClasses(delta, 'karma-feed__delta');
-      const deltaText = delta > 0 ? `+${fmtNum(delta)}` : fmtNum(delta);
-      const granted = k.granted_by
-        ? `@${escapeHtml(k.granted_by_login || k.granted_by_display_name || `builder #${k.granted_by}`)}`
-        : '<span style="opacity:0.6;">— all builders —</span>';
-      return `
-        <tr>
-          <td class="ledger__date">${escapeHtml(fmtDate(k.recorded_at))}</td>
-          <td class="karma-feed__delta ${deltaCls}">${deltaText}</td>
-          <td>${escapeHtml(k.reason || '')}</td>
-          <td>${granted}</td>
-        </tr>
-      `;
-    }).join('');
-  }
-
-  // ---- peer acclaim feed (V3.R25 #245) ------------------------------------
-  //
-  // Other builders' recently confirmed/shipped work, each with a +/- vote
-  // widget. Votes fold into the shipping builder's karma on a weekly tally,
-  // lagged 7 days (server-enforced). Metic+ may vote; the endpoint returns
-  // can_vote so Xenos see the tallies read-only. The endpoint already excludes
-  // the caller's own ships (anti-self-vote), so there's nothing to vote on that
-  // isn't a peer's work.
-
-  let acclaimCanVote = false;
-  // task 1002446: this was the hall's last unpaged list. The endpoint returns the
-  // whole feed in one call, so the rows are held here and the kit's client-side
-  // pager slices them — a page change re-renders without a refetch.
-  const acclaimState = { tasks: [] };
-  const acclaimPager = window.OTBKit.makePager('acclaim', 'otb.standing.acclaimPerPage', { defaultPerPage: 10 });
-
-  function renderAcclaimFeed(data) {
-    const scroll = $('#acclaim-scroll');
-    if (!scroll) return;
-    const tasks = (data && Array.isArray(data.tasks)) ? data.tasks : [];
-    acclaimState.tasks = tasks;
-    acclaimCanVote = !!(data && data.can_vote);
-    if (tasks.length === 0) {
-      // Nothing to acclaim yet (e.g. the only confirmed work so far is your
-      // own). Hide rather than show an empty ledger.
-      scroll.hidden = true;
-      return;
-    }
-    // #748: a gated newcomer never shows the acclaim feed.
-    scroll.hidden = newcomerGated;
-    // task 2174: this feed lands after loadAll built the rail, and it can be the
-    // only visible member of the Karma group (an empty karma feed hides itself).
-    // Re-run renderNav so the group — and its rail entry — appear.
-    if (lastMeState?.builder) renderNav(lastMeState.builder, lastMeState.onboarding || null);
-    renderAcclaimRows();
-  }
-
-  function renderAcclaimRows() {
-    const tbody = $('#acclaim-feed tbody');
-    if (!tbody) return;
-    const slice = window.OTBKit.paginate(acclaimState.tasks, acclaimPager);
-    tbody.innerHTML = slice.map((t) => {
-      // task 1004432: an approved page is its artist's; the applying session rides along as a helper.
-      const helperName = t.helper_display_name || (t.helper_login ? `@${t.helper_login}` : '');
-      const by = escapeHtml(t.display_name || (t.github_login ? `@${t.github_login}` : `builder #${t.shipped_by}`)) + (helperName ? ` <span class="acclaim__evidence">with help from ${escapeHtml(helperName)}</span>` : '');
-      // task 1004833: the votes are THE shared list control (vote-control.js),
-      // pre-painted from the feed's own net_votes/my_vote so it costs no extra
-      // read. A viewer below the vote floor sees the net alone.
-      const net = Number(t.net_votes) || 0;
-      const votes = acclaimCanVote && window.OTBVote
-        ? window.OTBVote.taskHtml(t)
-        : `<span class="vote__net" title="Metic rank and above may vote">${net > 0 ? `+${net}` : `${net}`}</span>`;
-      const title = escapeHtml(t.value_summary || t.title || `task #${t.id}`);
-      return `
-        <tr>
-          <td>${title}${acclaimEvidenceHtml(t)}</td>
-          <td>${by}</td>
-          <td>${votes}</td>
-        </tr>
-      `;
-    }).join('');
-  }
-
-  async function loadAcclaimFeed() {
-    try {
-      const data = await getJSON(`${API}/tasks/peer-votes/feed?limit=25`);
-      renderAcclaimFeed(data);
-    } catch (err) {
-      // Non-fatal: a feed failure shouldn't take down the hall.
-      console.warn('[hall] acclaim feed failed:', err.message);
-      const scroll = $('#acclaim-scroll');
-      if (scroll) scroll.hidden = true;
-    }
-  }
-
-  // task 1004833: the shared vote control casts the vote and repaints its own
-  // row; it then raises 'otb-vote' with the server's answer. The feed is paged,
-  // so the vote must land in the HELD rows too (task 1002446), or flipping to
-  // page 2 and back re-renders the stale tally over the one just cast.
-  function onAcclaimVote(ev) {
-    const d = ev && ev.detail;
-    if (!d || d.kind !== 'task') return;
-    const taskIdNum = Number(d.id);
-    acclaimState.tasks = acclaimState.tasks.map((t) => (Number(t.id) === taskIdNum
-      ? { ...t, net_votes: d.net_votes, my_vote: d.my_vote }
-      : t));
-  }
+  // (task 1005050: the achievements grid, the ship ledger, reviews, the dev curve
+  // and the karma and peer-recognition feeds were the Accomplishments view, which
+  // folded into the Profile page: profile-own.js draws the private half there.)
 
   // ---- task browser (removed #750) -----------------------------------------
   // The claimable-works list now lives solely on the /work Work Board (#748);
@@ -888,79 +365,6 @@
   // builder isn't on the roll). Matched by github_login (rows carry no id).
 
 
-  // ---- onboarding live-tick poll (task 1444) -------------------------------
-  //
-  // The onboarding checklist is rendered once from the page-load /me snapshot.
-  // But two of its steps clear from LIVE server signals that flip WITHOUT any
-  // local action or page reload while the hall sits open:
-  //   * cli_setup   — stamped when the Bongos CLI is first authenticated;
-  //   * join_discord — flips on the OAuth link (usually a full redirect, but can
-  //                    also land from another tab).
-  // Without a poll, a newcomer who signs the CLI in AFTER opening the hall sees
-  // the step stay unchecked until they manually reload — exactly the bug scootermack
-  // hit. "The city watches" only worked on the next full reload. So while any
-  // live-signal step is still uncleared, re-fetch /me on an interval and re-render
-  // the checklist; stop once they all clear (or the builder graduates).
-  let onboardingPollTimer = null;
-  const ONBOARDING_POLL_MS = 15000;
-
-  // True while at least one step that clears from a live signal (cli/discord)
-  // is still uncleared and the builder hasn't graduated. The pick_disciplines and
-  // ship_three steps flip via local action (PATCH re-renders) or shipping, so they
-  // don't need a poll — scoping to the live-signal steps bounds polling to the
-  // setup window rather than running forever for any non-graduated builder.
-  function onboardingNeedsLivePoll(onboarding) {
-    if (!onboarding || onboarding.graduated) return false;
-    const stages = Array.isArray(onboarding.stages) ? onboarding.stages : [];
-    return stages.some((s) =>
-      (s.source === 'cli' || s.source === 'discord') && !s.cleared);
-  }
-
-  function stopOnboardingPoll() {
-    if (onboardingPollTimer) { clearTimeout(onboardingPollTimer); onboardingPollTimer = null; }
-  }
-
-  function scheduleOnboardingPoll(onboarding) {
-    stopOnboardingPoll();
-    if (!onboardingNeedsLivePoll(onboarding)) return;
-    onboardingPollTimer = setTimeout(refreshOnboardingFromServer, ONBOARDING_POLL_MS);
-  }
-
-  async function refreshOnboardingFromServer() {
-    onboardingPollTimer = null;
-    // Don't poll a backgrounded tab — wait for it to come back (the
-    // visibilitychange listener re-arms from the cached state).
-    if (document.hidden) { scheduleOnboardingPoll(lastMeState && lastMeState.onboarding); return; }
-    let me;
-    try {
-      me = await getJSON(`${API}/me`, { softAuth: true });
-    } catch (err) {
-      // Session expired → stop (a redirect/landing will take over on next action).
-      if (err && err.code === AUTH_NEEDED) { stopOnboardingPoll(); return; }
-      // Transient (network blip / 5xx) → try again next interval so a single
-      // failure doesn't permanently kill the auto-tick.
-      scheduleOnboardingPoll(lastMeState && lastMeState.onboarding);
-      return;
-    }
-    if (!me || !me.builder) return;
-    const wasGraduated = !!(lastMeState && lastMeState.onboarding && lastMeState.onboarding.graduated);
-    lastMeState = me;
-    lastKarmaState = me.karma || lastKarmaState;
-    lastCostState = me.cost || lastCostState;
-    lastNeedsState = me.needs || lastNeedsState;
-    // ADR 0120 part 5: owed-rebase list is authoritative on every /me (an empty
-    // array means "nothing owed now"), so take it verbatim when present.
-    if (Array.isArray(me.needs_rebase_tasks)) lastRebaseState = me.needs_rebase_tasks;
-    renderOnboarding(me.onboarding || null, me.discord);
-    // If they graduated while watching, hide the welcome panel + rebuild the nav
-    // (drops the Welcome/Path chips) — the same transition loadAll would render.
-    if (me.onboarding && me.onboarding.graduated && !wasGraduated) {
-      renderWelcome(me.builder, me.onboarding);
-      renderNav(me.builder, me.onboarding || null);
-    }
-    scheduleOnboardingPoll(me.onboarding || null);
-  }
-
   // ---- bootstrap -----------------------------------------------------------
 
   // `prefetchedMe` is boot()'s already-resolved /me — the SAME payload, handed in
@@ -986,52 +390,22 @@
     lastCostState = me.cost || null;
     lastNeedsState = me.needs || null; // task 1013 / ADR 0073: action-needed banner
     lastRebaseState = Array.isArray(me.needs_rebase_tasks) ? me.needs_rebase_tasks : null; // ADR 0120 part 5: owed-rebase banner
-    // #408: stash the whole /me payload so reopenWelcomeFromNav can re-render
-    // the welcome panel without a fresh round-trip.
     lastMeState = me;
     // #748: decide the newcomer gate up front so the async karma/acclaim feeds
     // (which un-hide their own scroll on data arrival) honour it too.
     newcomerGated = normalizeRank(me.builder?.rank) === 'xenos';
-    // V3.R77 (#296): first-visit welcome panel. Renders above the profile and
-    // hides itself once dismissed or once the builder graduates. Computed
-    // before profile so the dismiss button is wired by the time the user
-    // sees the page.
-    // Cache self id on window so the dismiss-click handler can find it
-    // without re-fetching /me. Set BEFORE renderWelcome so the wired
-    // dismiss listener (attached once at bootstrap) can use it immediately.
+    // Cache self id on window for handlers wired once at bootstrap.
     window.__buildersSelfId = me.builder?.id ?? null;
-    renderWelcome(me.builder, me.onboarding || null);
     renderProfile(me.builder);
     renderGreeting(); // task 1003464: "Good morning, <name>" — the h1 — as soon as /me answers
     // #731: the CLI-token re-issue card (V3.R91 #401) and the Discord connect/
     // link card (F7, ADR 0033) moved to /builders/settings — the hall's Standing
     // card is identity-only now.
-    // V3.R75 (#294): auto-completing onboarding checklist. The /me payload
-    // carries the builder's own state directly so this is a render-only call.
-    renderOnboarding(me.onboarding || null, me.discord);
-    // task 1444: keep the checklist live — re-fetch /me on an interval while a
-    // cli/discord step is still uncleared, so it ticks itself without a manual
-    // reload the moment the CLI or Discord links.
-    scheduleOnboardingPoll(me.onboarding || null);
-    renderRecentGrades(me.grades?.recent || []);
-    renderRollingNote(me.grades?.rolling || null);
-    // V3.R72 (#291, C5): the dev curve. Loaded fire-and-forget — a slow or
-    // empty analytics feed must not hold up the rest of the hall, and the
-    // section un-hides itself (and re-renders the nav) only when there's data.
-    loadAnalytics(me.builder);
-    // V3.R26 (#246): karma feed — the recent karma_log entries powering the
-    // "why did my karma move" answer. The /me payload bundles this so the
-    // page doesn't need a follow-up call.
-    renderKarmaFeed(me.karma?.recent || []);
-    // V3.R25 (#245): peer acclaim feed — a separate endpoint (not bundled in
-    // /me because it spans all builders' work), loaded fire-and-forget so a
-    // slow/failed feed can't hold up the rest of the hall.
-    loadAcclaimFeed();
     // #408: build the sticky nav now that every section has settled its
-    // hidden state (welcome → karma → onboarding → security/roster).
+    // hidden state (karma → security/roster).
     // The renderNav call also wires the IntersectionObserver for active-
-    // section highlighting. Idempotent — safe to call again on dismiss/re-open.
-    // #748: collapse the hall to the newcomer view (onboarding + Standing) for
+    // section highlighting. Idempotent — safe to call again.
+    // #748: collapse the hall to the newcomer view (Standing) for
     // a Xenos BEFORE building the nav, so the chip strip matches what's shown.
     applyNewcomerGate();
     renderNav(me.builder, me.onboarding || null);
@@ -1046,41 +420,15 @@
     // down the page — log and show an inline placeholder.
     // #726: the per-skill model picker (Voices) moved to /builders/settings,
     // so the hall no longer fetches /me/skill-prefs here.
-    const [achAll, ships, versionsResp, lb] = await Promise.allSettled([
-      getJSON(`${API}/achievements`),
-      // task 1004854: Home's newest few + a count — never the whole history,
-      // which only the Accomplishments ledger fetches (hall-render.js loadShipLedger).
+    const [ships, lb] = await Promise.allSettled([
+      // task 1004854: Home's newest few + a count — never the whole history
+      // (the Profile page's Works ledger reads that, since task 1005050).
       getJSON(`${API}/me/recent-ships?limit=${HOME_SHIPS_LIMIT}`),
-      getJSON(`${API}/versions`),
       getJSON(`${API}/public/leaderboard`), // task 1004437: the list with each builder's roles
     ]);
 
-    if (achAll.status === 'fulfilled') {
-      // Show top 10 by sort_order — already ordered server-side. (Set is locked at 8
-      // for V2, so the slice is defensive.) Unlocked + locked-with-progress come
-      // straight from the enriched /me payload.
-      renderAchievements(
-        (achAll.value.achievements || []).slice(0, 10),
-        me.unlocked || [],
-        me.locked_with_progress || [],
-      );
-    } else {
-      $('#ach-grid').innerHTML = `<div class="profile__placeholder">Achievements could not be loaded.</div>`;
-    }
-
-    if (ships.status === 'fulfilled') {
-      setRecentShips(ships.value);
-    } else {
-      $('#recent-ships tbody').innerHTML = emptyRow(4, 'Your work history could not be loaded.');
-    }
-
-    if (versionsResp.status === 'fulfilled') {
-      const versions = versionsResp.value.versions || [];
-      // Populate the Works Wrought version filter — limited to versions this
-      // builder has actually shipped to, so the dropdown can't offer empty
-      // options. (The old claimable-works version filter moved to /work, #750.)
-      populateShipVersionFilter(versions);
-    }
+    // Only the Standing chip's shipped count reads this; a failure leaves its dash.
+    if (ships.status === 'fulfilled') setRecentShips(ships.value);
 
     if (lb.status === 'fulfilled') {
       lbState.rows = lb.value.leaderboard || [];
@@ -1097,78 +445,6 @@
   }
 
   function wireEvents() {
-    // #profile-body is re-rendered after load, so delegate the save click.
-    $('#profile-body').addEventListener('click', (e) => {
-      if (e.target.closest('#disc-save')) saveDisciplines();
-    });
-
-    // V3.R72 (#291): the dev-curve scope toggle. Delegated because
-    // renderCurveBody replaces the toggle's innerHTML — and from the whole
-    // Progress section, NOT #curve-body: the controls render into
-    // #curve-scope-note in the section's lede, a sibling of #curve-body, so a
-    // listener there never heard them (task 1004079).
-    $('#analytics-scroll')?.addEventListener('click', (e) => {
-      const btn = e.target.closest('.curve__scope-btn[data-scope]');
-      if (!btn) return;
-      const scope = btn.dataset.scope === 'eco' ? 'eco' : 'self';
-      if (scope === analyticsState.scope) return;
-      analyticsState.scope = scope;
-      renderCurveBody();
-    });
-
-    // The kind filter (task 1004005). Delegated like the scope toggle, and for
-    // the same reason: renderCurveBody replaces the control's innerHTML, so a
-    // listener bound to the element itself would not survive the first render.
-    // 'change', not 'input' — a keyboard user arrowing through a native select
-    // fires input per option, and each one would be a pair of round trips.
-    $('#analytics-scroll')?.addEventListener('change', (e) => {
-      const sel = e.target.closest('#curve-kind');
-      if (!sel) return;
-      const kind = sel.value ? sel.value : null;
-      if (kind === analyticsState.kind) return;
-      reloadCurveForKind(kind);
-    });
-
-    // task 1723: the Home "show the setup guide again" link re-opens a dismissed
-    // welcome banner (the old welcome chip's job) — clears the dismissal flag,
-    // re-renders the panel, refreshes the nav, then scrolls to it.
-    document.getElementById('welcome-reopen')?.addEventListener('click', (e) => {
-      reopenWelcomeFromNav(e);
-    });
-
-    // V3.R75 (#294): the onboarding list re-renders on each /me load, so the
-    // inline craft picker is wired by delegation to the list container. (The
-    // primer-read ack button that also lived here was removed in #766.)
-    $('#onboarding-list')?.addEventListener('click', (e) => {
-      const disc = e.target.closest('.onboarding-item__disc[data-disc]');
-      if (disc) { pickDiscipline(disc.dataset.disc); return; }
-      // #777: the only other control is the Connect-Discord anchor, which is a
-      // real link (full-page nav into the OAuth flow) — nothing to handle here.
-      // Both new steps (join_discord, cli_setup) auto-detect server-side.
-    });
-
-    // Welcome panel minimize toggle (replaces full dismiss).
-    $('#welcome-minimize')?.addEventListener('click', () => {
-      const scroll = $('#welcome-scroll');
-      const btn = $('#welcome-minimize');
-      if (!scroll) return;
-      const minimized = scroll.classList.toggle('scroll--welcome--minimized');
-      if (btn) btn.textContent = minimized ? '+' : '−';
-    });
-
-    // task 1004833: the shared vote control reports each landed vote to the feed.
-    $('#acclaim-feed')?.addEventListener('otb-vote', onAcclaimVote);
-
-    $('#f-ships-window')?.addEventListener('change', onShipsFilterChange);
-    $('#f-ships-version')?.addEventListener('change', onShipsFilterChange);
-    $('#f-ships-sort')?.addEventListener('change', renderRecentShips);
-    // task 2174: the kit wires prev/next/per-page for both tables against the
-    // #ships-*/#lb-* ids its own pagerBarHtml() stamped in hall-widgets.js.
-    window.OTBKit.wirePager(shipsPager, renderRecentShips);
-
-    window.OTBKit.wirePager(acclaimPager, renderAcclaimRows);
-
-
     // Sign-out is wired centrally in shell.js (doLogout + a delegated click
     // listener on the sign-out anchors), so it runs the real POST -> cookie-clear
     // -> bounce-home on EVERY hall page, not only this index. It used to live
@@ -1273,9 +549,8 @@
   // reads what this page holds NOW rather than what it held at boot. Everything
   // else is stable for the life of the page. This call sits AFTER every
   // declaration it passes — moving it earlier is a temporal-dead-zone crash.
-  const { acclaimEvidenceHtml, analyticsState, lbState, mountHallWidgets, renderCurveBody, renderGreeting, renderLanding, renderSessionRefused, renderNav, renderOnboarding, renderProfile, renderRecentShips, renderWelcomeCore, HOME_SHIPS_LIMIT, populateShipVersionFilter, setRecentShips, shipsPager, welcomeDismissalKey } = window.OTBHallRender({
-    API, RANK_ORDER, api, brandWorld, curLabel, emptyRow, fmtDate, getJSON, mins, normalizeRank, pct, postJSON, rankLabel, rankWeight, signClasses, toast, usd,
-    get instanceRepo() { return instanceRepo; },
+  const { lbState, mountHallWidgets, renderGreeting, renderLanding, renderSessionRefused, renderNav, renderProfile, HOME_SHIPS_LIMIT, setRecentShips } = window.OTBHallRender({
+    API, RANK_ORDER, api, brandWorld, curLabel, normalizeRank, postJSON, rankLabel, rankWeight, toast,
     get lastCostState() { return lastCostState; },
     get lastKarmaState() { return lastKarmaState; },
     get lastMeState() { return lastMeState; },
@@ -1318,9 +593,6 @@
     // which only exist once the registry has mounted them.
     mountHallWidgets();
     wireEvents();
-    // Fetch the instance's repo coords (public) so the welcome "get the code"
-    // clone block shows this instance's own repository (ADR 0062 §3, task 1705).
-    loadInstanceRepo();
     // #731: the Discord connect/link card moved to /builders/settings, and the
     // OAuth callback now lands there — so the ?discord=joined|linked toast is
     // handled by settings.js, not here.