@bongos/core 1.24.32 → 1.24.34

package/tests/craft_mode_home.mjs

@@ -0,0 +1,114 @@
+// tests/craft_mode_home.mjs — choosing a craft leaves another craft's page for Home
+// (task 1005067, goal 1000095).
+//
+// Owner, 2026-11-04: a governor on the city who picked Artistry, Ideating or Building
+// stayed in the governor's city. Each craft's home is its own dashboard (Home draws it;
+// the street is Governing's for now), so a page that belongs ONLY to other crafts is
+// left for Home, while a shared page, a page no craft owns, and Home itself stay put.
+// These cases run the REAL craft-mode.js and drive its own choose(), recording where
+// the hop would go instead of navigating.
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+import { realOTB } from './helpers.mjs';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const CRAFT = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/craft-mode.js'), 'utf8');
+
+function el() {
+  const attrs = {};
+  return {
+    id: '', dataset: {}, children: [],
+    classList: { toggle() {}, add() {}, remove() {} },
+    setAttribute(k, v) { attrs[k] = String(v); }, getAttribute(k) { return k in attrs ? attrs[k] : null; },
+    hasAttribute(k) { return k in attrs; }, removeAttribute(k) { delete attrs[k]; },
+    appendChild(c) { this.children.push(c); return c; },
+    querySelector() { return null; }, querySelectorAll() { return []; },
+  };
+}
+
+// One page: `page` is body[data-page], `active` the nav item the shell marked.
+function boot({ page, active = null, govCity = false }) {
+  const hops = [];
+  const body = el();
+  body.setAttribute('data-page', page);
+  const sidebar = el();
+  sidebar.querySelector = (sel) => {
+    if (sel !== '.nav-item--active' || !active) return null;
+    const a = el(); a.id = 'nav-' + active; return a;
+  };
+  const document = {
+    body, head: el(), documentElement: el(), readyState: 'complete',
+    getElementById: (id) => (id === 'app-sidebar' ? sidebar : null),
+    querySelector: () => null, querySelectorAll: () => [],
+    createElement: () => el(), createComment: () => el(),
+    addEventListener() {}, removeEventListener() {}, dispatchEvent() { return true; },
+  };
+  const store = () => { const o = {}; return { getItem: (k) => (k in o ? o[k] : null), setItem: (k, v) => { o[k] = String(v); }, removeItem: (k) => { delete o[k]; } }; };
+  const window = {
+    OTB: realOTB(), sessionStorage: store(), localStorage: store(),
+    OTBCraftHop: (h) => hops.push(h),
+    matchMedia: () => ({ matches: false }),
+    location: { search: '' },
+  };
+  if (govCity) window.GovCity = { STREET_HREF: '/builders/street' };
+  window.window = window;
+  vm.runInNewContext(CRAFT, { window, document, CustomEvent: function () {}, Promise, console });
+  return { CM: window.OTBCraftMode, hops };
+}
+
+test('leaving the governor\'s city for any other craft goes to Home', () => {
+  for (const mode of ['building', 'artistry', 'ideating']) {
+    const { CM, hops } = boot({ page: 'city', active: 'city' });
+    CM.choose(mode);
+    assert.deepEqual(hops, ['/'], `${mode} from the city goes Home`);
+  }
+});
+
+test('the street is Governing\'s own page, so other crafts leave it too', () => {
+  const { CM, hops } = boot({ page: 'street' });
+  assert.equal(CM.strandedBy('governing'), false);
+  CM.choose('ideating');
+  assert.deepEqual(hops, ['/']);
+});
+
+test('choosing Governing on another craft\'s page lands on the street', () => {
+  const { CM, hops } = boot({ page: 'studio', active: 'studio', govCity: true });
+  CM.choose('governing');
+  assert.deepEqual(hops, ['/builders/street']);
+  // without the street's script on the page, Home itself hops to the street
+  assert.equal(boot({ page: 'studio' }).CM.homeHref('governing'), '/');
+});
+
+test('a page the chosen craft also shows stays put', () => {
+  // goals is in Building, Artistry and Ideating alike
+  const { CM, hops } = boot({ page: 'goals', active: 'goals' });
+  CM.choose('ideating');
+  CM.choose('artistry');
+  assert.deepEqual(hops, []);
+});
+
+test('a page every craft keeps, and a page no craft owns, stay put', () => {
+  for (const [page, active] of [['roster', 'roster'], ['my-agents', 'my-agents'], ['task', null], ['idea', null]]) {
+    const { CM, hops } = boot({ page, active });
+    CM.choose('governing');
+    CM.choose('artistry');
+    assert.deepEqual(hops, [], `${page} stays`);
+  }
+});
+
+test('Home redraws itself for the craft, so it never hops from here', () => {
+  const { CM, hops } = boot({ page: 'home', active: 'home' });
+  CM.choose('artistry');
+  CM.choose('governing');
+  assert.deepEqual(hops, []);
+});
+
+test('the nav item wins over the page name (Economy is drachmae.html)', () => {
+  const { CM } = boot({ page: 'drachmae', active: 'economy' });
+  assert.equal(CM.strandedBy('artistry'), true);
+  assert.equal(CM.strandedBy('building'), false);
+});

package/tests/craft_mode_looks.mjs

@@ -86,25 +86,33 @@ test('each looked mode frames its own door scene under the brand, and names itse
     const plate = p.plates()[0];
     assert.equal(p.brand.nextSibling, plate, `${m}: the plate sits right under the brand`);
     assert.equal(plate.getAttribute('data-plate'), m);
-    assert.equal(plate.getAttribute('aria-hidden'), 'true', 'the plate is decoration');
-    assert.equal(plate.innerHTML, p.craft.artHtml(m), `${m}: the plate IS the picker's door art, not a second copy`);
+    assert.equal(plate.tagName, 'A', `${m}: the plate is a link`);
+    assert.equal(plate.getAttribute('href'), '/', `${m}: the plate goes Home`);
+    assert.equal(plate.getAttribute('aria-label'), 'Home', `${m}: named Home for a screen reader`);
+    assert.ok(plate.innerHTML.startsWith(p.craft.artHtml(m)), `${m}: the plate IS the picker's door art, not a second copy`);
+    assert.match(plate.innerHTML, /class="craft-plate__home" aria-hidden="true"/, `${m}: a home mark sits over the scene`);
     assert.equal(p.marks().length, 1, `${m}: exactly one eyebrow`);
     assert.equal(p.title.nextSibling, p.marks()[0], `${m}: the eyebrow sits right after the page title`);
     assert.equal(p.marks()[0].textContent, WORDS[m], `${m}: in the prototype's own words`);
   }
 });
 
-test('BUILDING AND NO MODE WEAR NO LOOK: no plate, no eyebrow, and switching to them takes the look away', () => {
+test('BUILDING AND NO MODE WEAR NO LOOK: no eyebrow; Building keeps only the Home plate, showing the city', () => {
   const none = boot();
   assert.equal(none.root.dataset.craft, undefined);
   assert.equal(none.plates().length + none.marks().length, 0, 'no mode draws nothing');
   for (const m of ['building']) {
     const p = boot({ 'hall-craft': m });
-    assert.equal(p.plates().length + p.marks().length, 0, `${m} at boot draws nothing`);
+    assert.equal(p.marks().length, 0, `${m} at boot names no look`);
+    assert.equal(p.plates().length, 1, `${m}: the Home plate is there too (task 1005065)`);
+    assert.equal(p.plates()[0].getAttribute('data-plate'), m);
+    assert.ok(p.plates()[0].innerHTML.startsWith(p.craft.artHtml('governing')), `${m}: its plate shows the city`);
     p.craft.choose('governing');
     assert.equal(p.plates().length, 1);
+    assert.equal(p.plates()[0].getAttribute('data-plate'), 'governing', 'switching mode swaps the plate');
     p.craft.choose(m);
-    assert.equal(p.plates().length + p.marks().length, 0, `switching to ${m} removes the plate and the eyebrow`);
+    assert.equal(p.marks().length, 0, `switching to ${m} removes the eyebrow`);
+    assert.equal(p.plates()[0].getAttribute('data-plate'), m, 'and swaps the plate back');
   }
   assert.deepEqual(Object.keys(none.craft.LOOKS).sort(), [...LOOKED].sort(), 'only the three crafts have a look');
 });
@@ -112,7 +120,7 @@ test('BUILDING AND NO MODE WEAR NO LOOK: no plate, no eyebrow, and switching to
 test('the art is drawn once: craft-mode.js has one artHtml and exports it', () => {
   assert.equal(CRAFT.match(/function artHtml\(/g).length, 1);
   assert.match(CRAFT, /artHtml: artHtml,/);
-  assert.match(CRAFT, /plate\.innerHTML = artHtml\(mode\);/);
+  assert.match(CRAFT, /plate\.innerHTML = artHtml\(art\) \+ HOME_MARK;/);
 });
 
 // Every selector in style.css that names a craft mode.
@@ -163,6 +171,8 @@ test('the shared treatment, the eyebrow and the plate are written as the directi
   }
   assert.match(CSS, /@media \(max-width: 640px\) \{ \.craft-eyebrow \{ display: none; \} \}/, 'the eyebrow is hidden on a phone');
   assert.match(CSS, /\.craft-plate \{[^}]*height: 40px;/, '40px in the closed rail');
+  assert.match(CSS, /\.craft-plate__home \{[^}]*width: 24px;[^}]*height: 24px;/, 'the home mark clears the 24px floor');
+  assert.match(CSS, /\.craft-plate:focus-visible \{ outline: 2px solid var\(--focus\);/, 'the Home plate shows keyboard focus');
   assert.match(CSS, /\.app-sidebar:focus-within \.craft-plate \{ height: 64px;/, '64px when the rail opens');
   assert.match(CSS, /html\[data-theme="light"\] \.craft-plate \.craft-art__city \{ filter: invert\(1\) hue-rotate\(180deg\); \}/,
     'the light city is the dark one inverted, not a second drawing');

package/tests/hall_sitemap.mjs

@@ -0,0 +1,70 @@
+// tests/hall_sitemap.mjs — the builders hall's generated sitemap stays fresh, and no hall
+// link is broken (task 1005068, goal 1000095).
+//
+// docs/hall-sitemap.md is written by scripts/bongos/gen-hall-sitemap.js from the real
+// sources: the page files, shell.js NAV, craft-mode.js's tabs (run, not read) and every
+// in-hall link. It is maintained by regeneration, never by hand, so this fails the moment
+// a page, a nav item, a craft's tabs or a link changes without a regenerate, and the
+// moment any link points at a URL the hall does not serve.
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import fs from 'node:fs';
+import path from 'node:path';
+import { createRequire } from 'node:module';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const require = createRequire(import.meta.url);
+const gen = require('../scripts/bongos/gen-hall-sitemap.js');
+const model = gen.build();
+
+test('the parse found the hall, so nothing below passes against an empty map', () => {
+  const files = fs.readdirSync(path.join(ROOT, 'modules/hall-ui/public')).filter((f) => f.endsWith('.html'));
+  assert.equal(model.pages.length, files.length, 'one row per page file');
+  assert.ok(model.nav.length >= 25, `expected the shell's nav, found ${model.nav.length} items`);
+  for (const c of ['building', 'artistry', 'ideating', 'governing']) {
+    assert.ok(model.crafts.tabs[c].length > model.crafts.always.length, `${c} lists tabs of its own`);
+  }
+  assert.ok(model.chrome.includes('shell.js') && model.chrome.includes('craft-mode.js'), 'the chrome is the shell');
+  assert.ok(model.pages.reduce((n, p) => n + p.out.length, 0) >= 40, 'the pages link to each other');
+});
+
+test('docs/hall-sitemap.md is what the generator writes now', () => {
+  const committed = fs.readFileSync(path.join(ROOT, gen.OUT), 'utf8');
+  assert.ok(committed === gen.render(model),
+    `${gen.OUT} is stale — run: node scripts/bongos/gen-hall-sitemap.js`);
+});
+
+test('no hall link points at a URL the hall does not serve', () => {
+  assert.deepEqual(model.findings.broken, [],
+    'fix the link, or name the server route in ROUTES in scripts/bongos/gen-hall-sitemap.js');
+});
+
+test('every craft tab is a real nav item', () => {
+  assert.deepEqual(model.findings.dangling, []);
+});
+
+test('a link is read the ways the hall writes one, and an unknown one is broken', () => {
+  const urls = new Set(model.pages.map((p) => p.url));
+  const found = gen.linksIn([
+    '<a href="/goals">', "x.innerHTML = '<a href=\"/builders/roster?id=2\">';",
+    "a.href = '/work';", "{ href: '/profile' }", "location.assign('/settings#x')",
+    "const STREET_HREF = '/builders/street';", '`<a href="${hallBase()}/idea/${id}">`',
+    "function itemHref(id) { return '/market-watch-item?id=' + id; }",
+    '`<a href="${hub}/connections">`', "fetch(API + '/goals')",
+  ].join('\n')).map((h) => gen.classify(h, urls));
+  assert.deepEqual(found.sort(), ['/goals', '/idea', '/market-watch-item', '/profile', '/roster', '/settings', '/street', '/work'].sort(),
+    'each written form is a link to its page; a hub page and an API path are not hall links');
+  assert.equal(gen.classify('/no-such-page', urls), false, 'an unknown target is broken');
+  assert.equal(gen.classify('/task/12', urls), '/task', 'a task id lands on the task page');
+  assert.equal(gen.classify('/people', urls), '/roster', 'a retired URL follows its redirect');
+  assert.equal(gen.classify('/builders/style.css?v=1', urls), null, 'an asset is not a page link');
+});
+
+test('the street is Governing\'s home: no nav item, reached by clicking from the city', () => {
+  const street = model.pages.find((p) => p.url === '/street');
+  assert.ok(street, 'the street is a hall page');
+  assert.deepEqual(street.nav, []);
+  assert.ok(street.reachIn.includes('governing'));
+  assert.ok(street.in.includes('/city'), 'the city links to the street');
+});