@bongos/core 1.24.28 → 1.24.29

package/tests/hall_settings_world.mjs

@@ -41,6 +41,7 @@ import assert from 'node:assert/strict';
 import fs from 'node:fs';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
+import { createRequire } from 'node:module';
 
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
 const HALL = path.join(ROOT, 'modules', 'hall-ui', 'public');
@@ -153,120 +154,83 @@ test('the switch clears the floor: a 46x38 target drawing a 44x24 track', () =>
   assert.match(on, /background:\s*var\(--accent-tint\)/, 'on is the tint, the accent arrives on the knob');
 });
 
-test('the wandering pick is a radio row, wired on change', () => {
-  const render = settingsJs.match(/function renderWandering\([\s\S]*?\n  \}\n/);
-  assert.ok(render, 'renderWandering is a whole function');
-  assert.match(render[0], /<label class="prow prow--pick" for="\$\{id\}"/, 'the whole row is the radio\'s label');
-  assert.match(render[0], /<input class="pradio" type="radio" name="wandering"/, 'a real radio group');
-  assert.match(render[0], /locked \? ' disabled' : ''/, 'a level above the rank ceiling is a disabled radio');
-  assert.doesNotMatch(render[0], /Rank-locked<\/button>|Choose<\/button>/, 'the four "Choose" buttons are gone');
-  const load = settingsJs.match(/async function loadWandering\([\s\S]*?\n  \}\n/);
-  assert.match(load[0], /addEventListener\('change'/, 'a radio fires change, not click');
-  assert.match(load[0], /closest\('\.pradio'\)/);
+test('the family radio clears the floor: a native radio is 13px, the family one is 24', () => {
   const radio = ruleOf(panelCss, '.pradio');
   assert.match(radio, /width:\s*24px/);
   assert.match(radio, /height:\s*24px/, 'a native radio is 13px; the floor is 24');
 });
 
-// ---- the interaction panel (task 1002514) ----------------------------------
+// ---- the five agent settings live on My agents only (task 1005044) ----------
 //
-// Three facts a browser is silent about: the panel is rendered by a script that
-// is not settings.js, so the wiring between the two halves is the thing that can
-// silently break; and the carve exists because settings.js is against the
-// 1500-line ratchet, which is a fact a reader will otherwise undo.
-
-test('the interaction panel is wired end to end across its two files', () => {
+// How Claude talks to you, Wandering, Rendering (session cards), Skill voices and
+// Your specialities used to be edited on BOTH pages, on the same routes, with no
+// hint that the two were one setting. The owner kept them on My agents only. What
+// each old panel promised a builder is now proven on My agents instead
+// (tests/hall_my_agents.mjs "MOVED:", tests/speciality_offer_ui.mjs,
+// tests/speciality_walkthrough_ui.mjs); this pins that Settings no longer carries
+// them, says where they went, and sends every old link there.
+
+const MOVED_SECTIONS = ['interaction-scroll', 'specialities-scroll', 'wandering-scroll', 'render-scroll', 'voices-scroll'];
+const requireHall = (f) => createRequire(import.meta.url)(path.join(HALL, f));
+
+test('Settings carries none of the five agent settings: no section, no script, no write', () => {
   const html = read('settings.html');
-  const panelJs = read('settings-interaction.js');
-
-  // The markup half lives in settings.html and must join a group that already
-  // exists — the rail renders groups, so a section in an unknown data-group is
-  // markup nothing ever shows.
-  const section = html.match(/<section class="scroll" id="interaction-scroll"[^>]*>/);
-  assert.ok(section, 'the panel has a section');
-  assert.match(section[0], /data-group="preferences"/, 'it joins a group the rail already renders');
-  assert.match(section[0], /\bhidden\b/, 'hidden until its own read succeeds, like every other panel');
-  assert.match(html, /<script src="\/builders\/settings-interaction\.js/, 'the page loads the panel script');
-
-  // The script half self-boots and reveals the section. If it stopped doing
-  // either, the panel would simply never appear and no test would notice.
-  assert.match(panelJs, /\$\('#interaction-scroll'\)\.hidden = false/, 'the script reveals its own section');
-  assert.match(panelJs, /setup\(\);/, 'it self-boots — settings.js does not call it');
-
-  // settings.js keeps ONLY the anchor entry, so /settings#interaction activates
-  // the group before the panel paints.
-  assert.match(settingsJs, /'interaction': 'interaction-scroll'/, 'the deep-link anchor stays in settings.js');
-  assert.doesNotMatch(settingsJs, /function renderInteraction\(/, 'the renderer moved out and must not come back inline');
+  for (const id of MOVED_SECTIONS) assert.doesNotMatch(html, new RegExp(`id="${id}"`), `${id} is gone from Settings`);
+  for (const f of ['settings-interaction.js', 'settings-render.js', 'settings-law-locks.js', 'speciality-tools.js', 'speciality-tools.css']) {
+    assert.doesNotMatch(html, new RegExp(f.replace('.', '\\.')), `Settings no longer loads ${f}`);
+  }
+  for (const f of ['settings-interaction.js', 'settings-render.js', 'settings-law-locks.js']) {
+    assert.ok(!fs.existsSync(path.join(HALL, f)), `${f} had one host, Settings, and went with its panel`);
+  }
+  for (const route of ['/me/skill-prefs', '/me/wandering', '/me/interaction', '/me/render', '/specialities']) {
+    assert.ok(!settingsJs.includes(route), `settings.js no longer reads or writes ${route}`);
+  }
+  assert.doesNotMatch(settingsJs, /function (renderVoices|renderWandering|loadVoices|loadWandering)\(/);
 });
 
-test('the interaction panel stays out of settings.js, which is against the size ratchet', () => {
-  // Not style: inlining this panel put settings.js at 1601 lines and regressed
-  // oversized_file_count 0→1 and excess_lines_total 0→102 (fitness-ratchets.js,
-  // OVERSIZE_LINES = 1500). The settings-sessions.js precedent, same reason.
-  const lines = settingsJs.split('\n').length;
-  assert.ok(lines < 1500, `settings.js is ${lines} lines — at or over the 1500 ratchet; carve the next panel out too`);
+test('Settings says where they went: one line to My agents in Preferences and one in Sound', () => {
+  const html = read('settings.html').replace(/<!--[\s\S]*?-->/g, '');
+  for (const [group, anchor] of [['preferences', '#talk'], ['sound', '#skills']]) {
+    const m = html.match(new RegExp(`<section class="scroll[^"]*" id="agents-moved-${group}"[^>]*>[\\s\\S]*?</section>`));
+    assert.ok(m, `a section in ${group} points to My agents`);
+    assert.match(m[0], new RegExp(`data-group="${group}"`), `it sits in the ${group} group`);
+    assert.doesNotMatch(m[0].match(/<section[^>]*>/)[0], /\bhidden\b/, 'drawn without waiting on any read');
+    assert.match(m[0], new RegExp(`href="/my-agents${anchor}"`), `it links to /my-agents${anchor}`);
+  }
+  // Sound still carries the sounds-off note (task 1004554), revealed at boot
+  assert.match(html, /id="sounds-off-scroll"[^>]*data-group="sound"/);
+  assert.match(settingsJs, /\$\('#sounds-off-scroll'\)\.hidden = false/);
 });
 
-// ---- the Rendering panel, carved out the same way (task 1002518) -----------
-//
-// Same two-file shape as the interaction panel above, and the same reason: the
-// knob became a four-rung ladder with a DERIVED default, which is more UI than
-// settings.js has room for. The extra fact this panel has to keep true is that
-// its "default" row explains itself — the default is computed from another
-// panel's answers, so a bare "default" tag would name a choice without naming
-// who made it.
-
-test('the rendering panel is wired end to end across its two files', () => {
+test('every old link to those sections lands on My agents', () => {
+  const Moved = requireHall('settings-moved.js');
+  const expect = {
+    interaction: '/my-agents#talk', rendering: '/my-agents#talk', render: '/my-agents#talk',
+    wandering: '/my-agents#work', voices: '/my-agents#skills', specialities: '/my-agents#knows',
+  };
+  for (const [anchor, to] of Object.entries(expect)) {
+    assert.equal(Moved.movedTarget('#' + anchor), to, `/settings#${anchor}`);
+  }
+  // the old section ids resolved as deep links too (resolveHash falls back to an element id)
+  for (const id of MOVED_SECTIONS) assert.match(String(Moved.movedTarget('#' + id)), /^\/my-agents#/, `/settings#${id}`);
+  for (const kept of ['', '#preferences', '#sound', '#cli', '#art-key', '#software-update', '#account']) {
+    assert.equal(Moved.movedTarget(kept), null, `${kept || 'no hash'} stays on Settings`);
+  }
+  // the anchors it sends to are ones My agents lands
+  const MyAgents = requireHall('my-agents.js');
+  for (const to of new Set(Object.values(expect))) assert.ok(MyAgents.anchorFor(to.slice(to.indexOf('#'))), `${to} is a My agents anchor`);
+  // settings.js asks before it draws anything, and on every later hash
   const html = read('settings.html');
-  const panelJs = read('settings-render.js');
-
-  const section = html.match(/<section class="scroll" id="render-scroll"[^>]*>/);
-  assert.ok(section, 'the panel has a section');
-  assert.match(section[0], /data-group="preferences"/, 'it joins a group the rail already renders');
-  assert.match(section[0], /\bhidden\b/, 'hidden until its own read succeeds');
-  assert.match(html, /<script src="\/builders\/settings-render\.js/, 'the page loads the panel script');
-
-  assert.match(panelJs, /\$\('#render-scroll'\)\.hidden = false/, 'the script reveals its own section');
-  assert.match(panelJs, /setup\(\);/, 'it self-boots — settings.js does not call it');
-
-  // settings.js keeps ONLY the anchor entry.
-  assert.match(settingsJs, /'rendering': 'render-scroll'/, 'the deep-link anchor stays in settings.js');
-  assert.doesNotMatch(settingsJs, /function renderRender\(/, 'the renderer moved out and must not come back inline');
-  assert.doesNotMatch(settingsJs, /loadRender\(\)/, 'and settings.js no longer calls it');
-});
-
-test('the rendering panel is a radio group, wired on change, and can clear the override', () => {
-  const panelJs = read('settings-render.js');
-  const render = panelJs.match(/function render\([\s\S]*?\n  \}\n/);
-  assert.ok(render, 'render is a whole function');
-  assert.match(render[0], /<input class="pradio" type="radio" name="render-level"/, 'a real radio group');
-  assert.match(render[0], /<label class="prow prow--pick"/, 'the whole row is the radio\'s label');
-  const setup = panelJs.match(/async function setup\([\s\S]*?\n  \}\n/);
-  assert.match(setup[0], /addEventListener\('change'/, 'a radio fires change, not click');
-  assert.match(setup[0], /closest\('\.pradio'\)/);
-  // The sentinel row must send null, not a level: pinning the rung that happens
-  // to be derived today would silently stop tracking the interaction profile.
-  assert.match(panelJs, /widgets: value === USE_DEFAULT \? null : value/,
-    'choosing "match my profile" CLEARS the override rather than pinning a level');
+  assert.ok(html.indexOf('settings-moved.js') > 0 && html.indexOf('settings-moved.js') < html.indexOf('/builders/settings.js'), 'loaded before settings.js');
+  assert.match(settingsJs, /location\.replace\(/, 'a replace, so Back does not bounce through Settings');
+  assert.doesNotMatch(settingsJs, /'(interaction|wandering|rendering|voices)': '[a-z-]+-scroll'/, 'no PANEL_ANCHORS entry for a section that left');
 });
 
-test('the derived default explains itself, because it is computed elsewhere', () => {
-  // Unlike every other picker on the page, "default" here is not a constant —
-  // render-prefs.js derives it from the interaction profile. A row that said
-  // only "default" would name a choice the reader never made and cannot see.
-  const panelJs = read('settings-render.js');
-  assert.match(panelJs, /derived_reason/, 'the row states WHY the default landed where it did');
-  assert.match(panelJs, /derived_level/, 'and WHICH rung that is');
-});
-
-test('a default value is named once, by the API, not twice by the row', () => {
-  // The first render read "Non-technical (default) · DEFAULT": interaction-prefs.js
-  // already ends every default value's LABEL with "(default)", and the row also
-  // carried the wandering picker's .prow__tag. One source for the word.
-  const panelJs = read('settings-interaction.js');
-  const render = panelJs.match(/function render\([\s\S]*?\n  \}\n/);
-  assert.ok(render, 'render is a whole function');
-  assert.doesNotMatch(render[0], /prow__tag/, 'the row must not re-state "default" beside a label that already says it');
+test('settings.js stays under the size ratchet', () => {
+  // Not style: inlining a panel once put settings.js at 1601 lines and regressed
+  // oversized_file_count 0→1 (fitness-ratchets.js, OVERSIZE_LINES = 1500).
+  const lines = settingsJs.split('\n').length;
+  assert.ok(lines < 1500, `settings.js is ${lines} lines — at or over the 1500 ratchet; carve the next panel out too`);
 });
 
 test('.craft-pref is a 24px target with a 14px drawn box — it was 13x13, the smallest control in the hall', () => {

package/tests/helpers.mjs

@@ -1016,13 +1016,14 @@ export function bootSkyPage({
 }
 
 // bootSpecialityTools — boot THE SPECIALITY TOOLS for real on a page's OWN markup
-// (task 1005052). One component, modules/hall-ui/public/speciality-tools.js, is
-// mounted by Settings and by My agents, and it finds every host by id. So, on the
+// (task 1005052). One component, modules/hall-ui/public/speciality-tools.js, was
+// mounted by Settings and by My agents; since task 1005044 My agents is its only
+// host (Settings links there). It finds every host by id. So, on the
 // bootSkyPage rule, the DOM here is the page's own: its specialities section
 // (`#specialities-scroll`) is parsed out of `<page>.html` into the mini-DOM above,
 // an id the page does not carry is null here too, and an id the component renders
 // itself (the create form's skills picker) exists only once its markup says so. A
-// host lost from either page fails that page's run.
+// host lost from a page fails that page's run.
 //
 // The fake API keeps the builder's adoptions as STATE: adopt adds one, abandon
 // drops it, the walkthrough's PUT sets its enabled skills, so a reload after a
@@ -1034,7 +1035,7 @@ export function bootSkyPage({
 //   await h.click('#specialities-rows button[data-act="adopt"]');
 //   h.writes()   → the non-GET requests, with their bodies
 //   h.text('specialities-rows'), h.toasts, h.events (the DOM events it dispatched)
-export const SPECIALITY_PAGES = ['settings', 'my-agents'];
+export const SPECIALITY_PAGES = ['my-agents'];
 function specialitySection(page) {
   const html = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public', `${page}.html`), 'utf8').replace(/<!--[\s\S]*?-->/g, '');
   const at = html.indexOf('id="specialities-scroll"');
@@ -1043,7 +1044,7 @@ function specialitySection(page) {
   return html.slice(start, html.indexOf('</section>', at) + '</section>'.length);
 }
 export function bootSpecialityTools({
-  page = 'settings', catalog = [], adoptions = [], suggestions = [], skills = {}, installed = [], answer = null,
+  page = 'my-agents', catalog = [], adoptions = [], suggestions = [], skills = {}, installed = [], answer = null,
 } = {}) {
   const src = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/speciality-tools.js'), 'utf8');
   let focused = null;

package/tests/interaction_posture.mjs

@@ -81,7 +81,9 @@ test('CLAUDE.md expresses the posture through the knob instead of restating it',
   const handWritten = claude.slice(0, b) + claude.slice(e + gen.END.length);
   // Clause 2: the kernel must NAME the knob (it named only the wandering one before)...
   assert.match(handWritten, /interaction profile/i, 'the kernel must reference the knob');
-  assert.match(handWritten, /interaction-prefs\.js|\/settings#interaction/, 'and say where it lives');
+  // ...and say where it lives: on My agents since task 1005044 (Settings no longer edits it)
+  assert.match(handWritten, /\/my-agents/, 'and say where it lives');
+  assert.doesNotMatch(handWritten, /\/settings#interaction/, 'not the Settings panel it left');
   // ...and must not carry a hand-written second copy of the posture beside the generated one.
   assert.doesNotMatch(handWritten, /Don't assume software-engineering vocabulary/,
     'the old §2 prose copy is what drifted — it must not come back outside the generated block');

package/tests/speciality_offer_ui.mjs

@@ -10,11 +10,12 @@
 // and that training adds a document in one request, refused inline when a field
 // is empty.
 //
-// TWO PAGES, ONE COMPONENT (task 1005052). modules/hall-ui/public/speciality-tools.js
-// is mounted by Settings and by My agents, and it renders its own create form, so
-// neither page carries a second copy of that markup. Every case runs once per
-// page, booted on THAT page's own markup (tests/helpers.mjs bootSpecialityTools),
-// so a host lost from either page fails that page's run.
+// ONE COMPONENT, ONE HOST. modules/hall-ui/public/speciality-tools.js was mounted
+// by Settings and by My agents (task 1005052); since task 1005044 My agents is the
+// only page that edits a speciality, and Settings links there. Every case runs on
+// each page in SPECIALITY_PAGES, booted on THAT page's own markup
+// (tests/helpers.mjs bootSpecialityTools), so a host lost from it fails its run.
+// tests/hall_settings_world.mjs pins that Settings no longer mounts it.
 //
 // Run:  node tests/speciality_offer_ui.mjs
 import assert from 'node:assert/strict';

package/tests/speciality_walkthrough_ui.mjs

@@ -12,12 +12,14 @@
 //
 // THE SAFETY STEP. A speciality someone else wrote puts their prose into your
 // sessions, so its full instructions are on the card, open, before the control
-// that adopts it — pinned below on both pages.
+// that adopts it — pinned below on My agents.
 //
-// TWO PAGES, ONE COMPONENT (task 1005052). modules/hall-ui/public/speciality-tools.js
-// is mounted by Settings and by My agents. Every case runs once per page, booted
-// on THAT page's own markup (tests/helpers.mjs bootSpecialityTools), so a host
-// lost from either page fails that page's run.
+// ONE COMPONENT, ONE HOST. modules/hall-ui/public/speciality-tools.js was mounted
+// by Settings and by My agents (task 1005052); since task 1005044 My agents is the
+// only page that edits a speciality, and Settings links there. Every case runs on
+// each page in SPECIALITY_PAGES, booted on THAT page's own markup
+// (tests/helpers.mjs bootSpecialityTools), so a host lost from it fails its run.
+// tests/hall_settings_world.mjs pins that Settings no longer mounts it.
 //
 // Run:  node tests/speciality_walkthrough_ui.mjs
 import assert from 'node:assert/strict';

package/modules/hall-ui/public/settings-interaction.js

@@ -1,132 +0,0 @@
-// modules/hall-ui/public/settings-interaction.js — the "How Claude talks to you"
-// panel on /builders/settings (task 2010's profile, delivered by task 1002514).
-//
-// WHY THE PANEL EXISTS. The interaction profile shipped complete except for a
-// way to set it: interaction-prefs.js stored it, GET/PATCH /me/interaction served
-// it, and the conductor hook already injected the resolved contract into every
-// session — but settings.js had 18 `wandering` references and 0 `interaction`
-// ones, so the profile was reachable only by a raw API call. In practice that
-// meant nobody had one.
-//
-// Its own file rather than more of settings.js, on the settings-sessions.js
-// precedent and for the same stated reason: settings.js sits against the
-// 1500-line size ratchet (adding this inline pushed it to 1601 and regressed the
-// budget). The panel is self-contained — it shares nothing with the rest of the
-// page but the `window.OTB` toolkit and the generated API client, both globals
-// loaded before it.
-//
-// THE ONE SHAPE DIFFERENCE FROM WANDERING, which is the sibling to read first:
-// wandering is a single level, so it is one radiogroup. This payload is a FIELD
-// CATALOG — several independent fields, each with its own value set — so each
-// field is its own single-select and a PATCH carries only the field that changed
-// ({ <field>: <value> }). The route merges, so the untouched fields keep their
-// values and a field never explicitly set keeps falling back to its default.
-
-(() => {
-  'use strict';
-
-  const API = '/api/bongos';
-  const { escapeHtml, $ } = window.OTB;
-  const toast = (msg) => window.OTB.toast(msg);
-  const api = window.BongosClient.createClient({ baseUrl: '', credentials: 'same-origin', throwOnError: false });
-
-  const toAuth = () => window.location.assign(`${API}/auth/web/start`);
-  // the project's laws on these fields (task 1004724): settings-law-locks.js
-  const Laws = window.OTBSettingsLaws || { lockFor: () => null, allows: () => true, lawLine: () => '', tagFor: () => '' };
-
-  function render(data) {
-    const wrap = $('#interaction-rows');
-    if (!wrap) return;
-    const fields = Array.isArray(data && data.fields) ? data.fields : [];
-    const eff = (data && data.effective) || {};
-    if (fields.length === 0) {
-      wrap.innerHTML = window.OTBKit.emptyStateHtml('No interaction settings registered.');
-      return;
-    }
-    // A fieldset per field so the field's label is its radiogroup's accessible
-    // name — four independent single-selects, not one flat list of radios.
-    wrap.innerHTML = fields.map((f) => {
-      const chosenValue = eff[f.field];
-      const lock = Laws.lockFor(data, f.field);
-      const rows = (f.values || []).map((v) => {
-        const id = `interaction-${f.field}-${v.value}`;
-        const chosen = v.value === chosenValue;
-        const barred = !Laws.allows(lock, v.value);
-        // No "default" tag here, deliberately: interaction-prefs.js already ends
-        // every default value's LABEL with "(default)", so adding the row tag the
-        // wandering picker uses rendered "Non-technical (default) · DEFAULT".
-        // One source for the word, and it is the label the API already ships.
-        return (
-          `<label class="prow prow--pick" for="${id}"${barred ? ' aria-disabled="true"' : ''}>` +
-          `<input class="pradio" type="radio" name="interaction-${escapeHtml(f.field)}" id="${id}"` +
-          ` value="${escapeHtml(v.value)}" data-field="${escapeHtml(f.field)}"${chosen ? ' checked' : ''}${barred ? ' disabled' : ''}>` +
-          '<span class="prow__main">' +
-          `<span class="prow__label">${escapeHtml(v.label)}</span>` +
-          '</span></label>'
-        );
-      }).join('');
-      return (
-        `<fieldset class="pgroup" id="interaction-field-${escapeHtml(f.field)}">` +
-        `<legend class="prow__label">${escapeHtml(f.label)}</legend>` +
-        `<p class="prow__desc">${escapeHtml(f.blurb || '')}</p>` +
-        (lock ? `<p class="prow__desc prow__law" data-law="${escapeHtml(String(lock.law_no || ''))}">${escapeHtml(Laws.lawLine(lock))}</p>` : '') +
-        rows +
-        '</fieldset>'
-      );
-    }).join('');
-  }
-
-  // The human label for a saved value, for the status line — falls back to the
-  // raw value rather than going blank if the catalog and the payload disagree.
-  function labelFor(data, field, value) {
-    const f = (Array.isArray(data && data.fields) ? data.fields : []).find((x) => x.field === field);
-    const v = f && (f.values || []).find((x) => x.value === value);
-    return (v && v.label) || value;
-  }
-
-  async function save(field, value, input) {
-    const status = $('#interaction-status');
-    if (status) status.textContent = 'Saving…';
-    if (input) input.disabled = true;
-    try {
-      const res = await api.request('PATCH', `${API}/me/interaction`, { body: { [field]: value } });
-      if (res.status === 401) { toAuth(); return; }
-      if (!res.ok) throw new Error(`interaction PATCH → ${res.status}`);
-      render(res.data);
-      const msg = `Saved — ${labelFor(res.data, field, value)}.`;
-      if (status) status.textContent = msg;
-      toast(msg);
-    } catch (err) {
-      console.error('[settings] save interaction failed', err);
-      if (status) status.textContent = 'Could not save. Try again.';
-      toast('Could not save your interaction profile. Try again.');
-      if (input) input.disabled = false;
-    }
-  }
-
-  async function setup() {
-    try {
-      const res = await api.request('GET', `${API}/me/interaction`);
-      if (res.status === 401) { toAuth(); return; }
-      if (!res.ok) throw new Error(`interaction GET → ${res.status}`);
-      render(res.data);
-      $('#interaction-scroll').hidden = false;
-      // Delegate the change so post-render radios stay wired.
-      $('#interaction-rows').addEventListener('change', (e) => {
-        const r = e.target.closest('.pradio');
-        if (!r || r.disabled || !r.checked) return;
-        const field = r.getAttribute('data-field');
-        if (field) save(field, r.value, r);
-      });
-    } catch (err) {
-      // Its own try/catch, like every other section: a failing endpoint shows this
-      // panel's own error rather than taking the settings page down with it.
-      console.error('[settings] failed to load interaction', err);
-      $('#interaction-scroll').hidden = false;
-      $('#interaction-rows').innerHTML =
-        '<p class="voices-empty">Your interaction profile could not be loaded. Reload the page to try again.</p>';
-    }
-  }
-
-  setup();
-})();

package/modules/hall-ui/public/settings-law-locks.js

@@ -1,53 +0,0 @@
-// modules/hall-ui/public/settings-law-locks.js — the project's LAWS on the
-// /builders/settings rows (task 1004724).
-//
-// A law passed by the project's government may lock a personal setting: FIX it
-// to one value, or CAP it. The server enforces the lock (law-locks.js, task
-// 1004707) and every settings read already reports it as `law_locks` — this file
-// is only how the page SAYS so: a value the lock does not allow is a disabled
-// row tagged with the law, and the setting carries one line naming the law.
-// Shared by the "How Claude talks to you" panel (settings-interaction.js) and the
-// wandering picker (settings.js). The page decides nothing; a write the law
-// forbids is refused by the route either way (409 locked_by_law).
-//
-// PURE: no DOM, no fetch. tests/settings_law_locks.mjs requires it in node.
-
-(function (root) {
-  'use strict';
-
-  const str = (v) => (v == null ? '' : String(v));
-
-  // The lock a law puts on `setting`, from a settings read's `law_locks`, or null.
-  // Only an ENFORCED lock counts: one naming no real value locks nothing.
-  function lockFor(data, setting) {
-    const locks = data && Array.isArray(data.law_locks) ? data.law_locks : [];
-    return locks.find((l) => l && l.enforced === true && str(l.setting) === str(setting)) || null;
-  }
-
-  // May `value` still be picked under `lock`? No lock: yes.
-  function allows(lock, value) {
-    if (!lock) return true;
-    if (!Array.isArray(lock.allowed)) return true;
-    return lock.allowed.map(str).includes(str(value));
-  }
-
-  // The one line the setting carries: which law, and what it does to the row.
-  function lawLine(lock) {
-    if (!lock) return '';
-    const n = lock.law_no != null ? 'Law ' + str(lock.law_no) : 'A law';
-    const text = str(lock.law_text).trim();
-    const what = Object.prototype.hasOwnProperty.call(lock, 'value')
-      ? ' sets this for every agent in the project'
-      : ' caps this for every agent in the project';
-    return n + what + (text ? ': "' + text + '".' : '.') + ' Only a vote can change it.';
-  }
-
-  // The tag a row the lock rules out wears.
-  function tagFor(lock) {
-    return lock ? 'set by ' + (lock.law_no != null ? 'law ' + str(lock.law_no) : 'a law') : '';
-  }
-
-  const api = { lockFor, allows, lawLine, tagFor };
-  root.OTBSettingsLaws = api;
-  if (typeof module !== 'undefined' && module.exports) module.exports = api;
-}(typeof window !== 'undefined' ? window : globalThis));

package/modules/hall-ui/public/settings-render.js

@@ -1,138 +0,0 @@
-// modules/hall-ui/public/settings-render.js — the "Rendering" panel on
-// /builders/settings: how rich the deterministic session cards should be
-// (task 1279's on/off toggle, a four-rung ladder since task 1002518).
-//
-// WHY ITS OWN FILE. It began as one row with one switch inside settings.js. As a
-// ladder it needs a labelled option per rung plus a line explaining what the
-// default resolved to and why — and settings.js sits against the 1500-line size
-// ratchet, so the panel moved out on the settings-sessions.js / settings-
-// interaction.js precedent. Extracting it took settings.js from 1493 to 1425.
-//
-// THE SHAPE WORTH KNOWING: unlike every other picker on this page, "default"
-// here is not a constant — it is DERIVED from the builder's interaction profile
-// (render-prefs.js maps technical level, machinery and reply length onto a
-// rung). So the default option cannot just say "default"; it has to say which
-// rung it landed on and which profile fields put it there, or the reader sees a
-// choice the system made for reasons it never stated. The server ships both
-// facts (`derived_level`, `derived_reason`) precisely so this panel can.
-//
-// PATCH body is { widgets: <level> | null } — null clears the override and
-// returns the builder to the derived rung. The route still accepts the legacy
-// boolean, which is what lets an older hall build keep working against a newer
-// core; this panel only ever sends levels or null.
-
-(() => {
-  'use strict';
-
-  const API = '/api/bongos';
-  const { escapeHtml, $ } = window.OTB;
-  const toast = (msg) => window.OTB.toast(msg);
-  const api = window.BongosClient.createClient({ baseUrl: '', credentials: 'same-origin', throwOnError: false });
-
-  const toAuth = () => window.location.assign(`${API}/auth/web/start`);
-
-  // The "let the profile decide" option carries the sentinel value '' rather
-  // than a level, so the change handler can tell "clear my override" from
-  // "pin me to the rung that happens to be the derived one today". They differ:
-  // a pinned rung survives a later change to the interaction profile.
-  const USE_DEFAULT = '';
-
-  function labelForLevel(data, level) {
-    const found = (Array.isArray(data && data.levels) ? data.levels : []).find((l) => l.value === level);
-    return (found && found.label) || level;
-  }
-
-  function render(data) {
-    const wrap = $('#render-rows');
-    if (!wrap) return;
-    const levels = Array.isArray(data && data.levels) ? data.levels : [];
-    if (levels.length === 0) {
-      wrap.innerHTML = window.OTBKit.emptyStateHtml('No rendering options registered.');
-      return;
-    }
-    const override = data.override_level || null;
-    const derived = data.derived_level;
-
-    // The default row first, so the reader meets "you already have a sensible
-    // answer, here is what it is" before the list of ways to overrule it.
-    const defaultRow =
-      `<label class="prow prow--pick" for="render-default">` +
-      `<input class="pradio" type="radio" name="render-level" id="render-default"` +
-      ` value="${USE_DEFAULT}"${override === null ? ' checked' : ''}>` +
-      '<span class="prow__main">' +
-      `<span class="prow__label">Match my interaction profile` +
-      `<span class="prow__tag">default (${escapeHtml(labelForLevel(data, derived))})</span></span>` +
-      `<span class="prow__desc">${escapeHtml(data.derived_reason || '')} Change that profile and this follows it.</span>` +
-      '</span></label>';
-
-    const rows = levels.map((l) => {
-      const id = `render-level-${l.value}`;
-      return (
-        `<label class="prow prow--pick" for="${id}">` +
-        `<input class="pradio" type="radio" name="render-level" id="${id}"` +
-        ` value="${escapeHtml(l.value)}"${override === l.value ? ' checked' : ''}>` +
-        '<span class="prow__main">' +
-        `<span class="prow__label">${escapeHtml(l.label)}</span>` +
-        `<span class="prow__desc">${escapeHtml(l.blurb)}</span>` +
-        '</span></label>'
-      );
-    }).join('');
-
-    wrap.innerHTML =
-      '<fieldset class="pgroup" id="render-level-group">' +
-      '<legend class="prow__label">Session card richness</legend>' +
-      '<p class="prow__desc">How much the claim and ship cards show. Richer cards explain more and cost more tokens; the confirmation line is always there whichever you pick.</p>' +
-      defaultRow + rows +
-      '</fieldset>';
-  }
-
-  async function save(value, input) {
-    const status = $('#render-status');
-    if (status) status.textContent = 'Saving…';
-    if (input) input.disabled = true;
-    try {
-      // The sentinel becomes an explicit null — the route's clear-the-override
-      // signal. Anything else is a level and is stored as the override.
-      const body = { widgets: value === USE_DEFAULT ? null : value };
-      const res = await api.request('PATCH', `${API}/me/render`, { body });
-      if (res.status === 401) { toAuth(); return; }
-      if (!res.ok) throw new Error(`render PATCH → ${res.status}`);
-      render(res.data);
-      const msg = value === USE_DEFAULT
-        ? `Saved — following your interaction profile (${labelForLevel(res.data, res.data.derived_level)}).`
-        : `Saved — ${labelForLevel(res.data, value)}.`;
-      if (status) status.textContent = msg;
-      toast(msg);
-    } catch (err) {
-      console.error('[settings] save render failed', err);
-      if (status) status.textContent = 'Could not save. Try again.';
-      toast('Could not save your rendering preference. Try again.');
-      if (input) input.disabled = false;
-    }
-  }
-
-  async function setup() {
-    try {
-      const res = await api.request('GET', `${API}/me/render`);
-      if (res.status === 401) { toAuth(); return; }
-      if (!res.ok) throw new Error(`render GET → ${res.status}`);
-      render(res.data);
-      $('#render-scroll').hidden = false;
-      // Delegate the change so post-render radios stay wired.
-      $('#render-rows').addEventListener('change', (e) => {
-        const r = e.target.closest('.pradio');
-        if (!r || r.disabled || !r.checked) return;
-        save(r.value, r);
-      });
-    } catch (err) {
-      // Its own try/catch, like every other section: a failing endpoint shows
-      // this panel's own error rather than taking the settings page down.
-      console.error('[settings] failed to load render', err);
-      $('#render-scroll').hidden = false;
-      $('#render-rows').innerHTML =
-        '<p class="voices-empty">Your rendering preference could not be loaded. Reload the page to try again.</p>';
-    }
-  }
-
-  setup();
-})();