@bongos/core 1.24.23 → 1.24.24

package/tests/funded_project_pays_proof_db.mjs

@@ -0,0 +1,181 @@
+// tests/funded_project_pays_proof_db.mjs — task 1003186 (goal 1000092 M07; criterion
+// money-cannot-outrun). Real DB: the integration lane's fully migrated database.
+//
+// THE PROOF, end to end, on the real schema and the real code paths — no stand-in tables:
+//   1. the project is funded (a `funding` movement, as the fund-project transfer books it);
+//   2. a builder claims a cash task through the real claimTask: the funding wall holds its pay;
+//   3. a second claim the balance cannot cover is refused with the reason and the shortfall;
+//   4. the first task ships through the real resolveClaim → confirmTask → shipTask, and its pay
+//      STAYS held until the builder is paid — the hole this proof found: the hold used to go at
+//      the ship, so the same money could be promised to another task before anyone was paid;
+//   5. the owner approves the payout (the real append-only approval log), the builder clears the
+//      real payout gates, and the first transfer fails: the debt is on record, owed, with why;
+//   6. the owner's outflow view shows the debt as owed-but-unpaid and the balance after it;
+//   7. pay is pressed again, twice at once: money leaves the account exactly once, and a third
+//      press sends nothing;
+//   8. the owner sees the payout, the per-builder total and nothing left owed;
+//   9. the balance is drained by one more claim, and the next is refused with its shortfall.
+//
+// WHAT IS NOT REAL. The processor. No payment-rail adapter exists yet (ADR 0397: Stripe
+// Connect, and only an adapter may name it; payout-approvals.js passes `processor = null`), so
+// step 5/7's transfers go to a test rail at the one port builder-payouts.js defines,
+// { transfer(req) → { ref } }, which remembers each idempotency key as a processor does. Every
+// other step is the code a live instance runs. No real money moves here.
+//
+// The tables it writes are append-only by design (the movements, debts, attempts, approvals),
+// so it cleans up nothing: its rows use ids unique to the run and it measures the account
+// relative to the balance it finds. Run it only against a throwaway database (the CI lane's).
+// Self-skips without a reachable Postgres.
+// Run:  DATABASE_URL=... node tests/funded_project_pays_proof_db.mjs
+import { createRequire } from 'node:module';
+import { strict as assert } from 'node:assert';
+const require = createRequire(import.meta.url);
+const { Pool } = require('pg');
+
+process.env.NODE_ENV = 'test';
+const pool = new Pool({ connectionString: process.env.DATABASE_URL || undefined });
+try {
+  await pool.query('SELECT 1');
+} catch (e) {
+  console.log(`funded_project_pays_proof_db.mjs SKIPPED — no reachable Postgres (${e.code || e.message}).`);
+  await pool.end().catch(() => {});
+  process.exit(0);
+}
+
+const seams = require('../src/module-seams.js');
+const A = require('../modules/economy/project-account.js');
+if (!seams.hasProvider('reward')) seams.registerProvider('reward', require('../modules/economy/reward.js'));
+if (!seams.hasProvider('economy.account')) {
+  seams.registerProvider('economy.account', { recordMovement: A.recordMovement, lockAccount: A.lockAccount, releaseSettledHolds: A.releaseSettledHolds, readAvailable: A.readAvailable });
+}
+const db = require('../modules/lifecycle/db.js');
+const P = require('../modules/lifecycle/pay-terms.js');
+const settings = require('../src/bongos/project-settings.js');
+const approvals = require('../src/bongos/payout-approvals.js');
+const gates = require('../src/bongos/payout-gates.js');
+const payouts = require('../src/bongos/builder-payouts.js');
+const { readOutflow } = require('../modules/economy/outflow.js');
+
+const USD = 1_000_000;
+const RUN = Date.now() % 1_000_000;
+const BASE = 930_000_000 + RUN * 10;
+const OWNER = BASE, ADA = BASE + 1;
+const TASK_A = BASE, TASK_B = BASE + 1, TASK_C = BASE + 2;
+const VER = `ZZZ-M07-${RUN}`;
+const WALL_KEY = settings.SETTING_KEYS.FUNDING_WALL;
+const q = (sql, params) => pool.query(sql, params).then((r) => r.rows);
+let pass = 0;
+const ok = (c, m) => { assert.ok(c, m); pass++; console.log(`  ok - ${m}`); };
+const available = async () => (await A.readAvailable(pool)).available_micro;
+const claim = async (taskId) => {
+  try { return { claim: await db.claimTask({ taskId: String(taskId), builderId: String(ADA), worktreeName: `m07-${RUN}-${taskId}` }) }; } catch (e) { return { err: e }; }
+};
+const cash = (taskId, amount) => P.setPayTerms({ taskId, terms: [{ pay_type: 'cash', amount, unit: 'USD', note: null }], builderId: OWNER }, { db: pool });
+
+// The test rail: a processor that keeps one transfer per idempotency key, and declines the first.
+const rail = {
+  transfers: new Map(), calls: 0, declineNext: true,
+  async transfer(req) {
+    this.calls += 1;
+    if (this.declineNext) { this.declineNext = false; throw Object.assign(new Error('the bank declined the transfer'), { code: 'declined' }); }
+    if (!this.transfers.has(req.idempotencyKey)) this.transfers.set(req.idempotencyKey, { ref: `tr_m07_${RUN}`, amountCents: req.amountCents });
+    return { ref: this.transfers.get(req.idempotencyKey).ref };
+  },
+};
+
+const priorWall = await settings.getSetting(WALL_KEY);
+try {
+  await q(`INSERT INTO versions (id,name,status,track) VALUES ($1,'m07 proof','building','internal') ON CONFLICT (id) DO NOTHING`, [VER]);
+  await q(`INSERT INTO builders (id,github_id,github_login,display_name,rank) VALUES ($1,$2,$3,'M07 Owner','archon'), ($4,$5,$6,'Ada','archon')`,
+    [OWNER, `m07-o-${RUN}`, `m07-owner-${RUN}`, ADA, `m07-a-${RUN}`, `m07-ada-${RUN}`]);
+  for (const [id, title] of [[TASK_A, 'Build the paid thing'], [TASK_B, 'Build the second thing'], [TASK_C, 'Build the last thing']]) {
+    await q(`INSERT INTO tasks (id,version_id,title,status,credits_reward,kind,discipline) VALUES ($1,$2,$3,'ready',10,'feature','engineer')`, [id, VER, title]);
+  }
+  await cash(TASK_A, '100'); await cash(TASK_B, '80'); await cash(TASK_C, '40');
+  await settings.setSetting(WALL_KEY, 'hold_at_claim', OWNER);
+
+  // 1. fund the project so $150 is available (relative to whatever the database already holds)
+  const before = await available();
+  if (before < 150 * USD) await A.recordMovement(pool, { kind: 'funding', amountMicro: 150 * USD - before, processorRef: `ch_m07_${RUN}` });
+  if (before > 150 * USD) await A.recordMovement(pool, { kind: 'fee', amountMicro: before - 150 * USD, processorRef: `fee_m07_${RUN}`, note: 'M07 proof: start from $150' });
+  ok(await available() === 150 * USD, 'the project is funded: $150 available');
+  const out0 = await readOutflow(pool, { months: 1 });
+  const otherCommitted = out0.balance.available_micro - out0.balance.after_commitments_micro;
+
+  // 2. a funded claim passes and holds the task's pay
+  const a = await claim(TASK_A);
+  ok(a.claim && !a.err, `Ada claims the $100 task (${a.err ? a.err.code : 'claimed'})`);
+  ok(await available() === 50 * USD, 'its $100 pay is held: $50 left to promise');
+
+  // 3. an underfunded claim is refused, with the reason and the shortfall
+  const b = await claim(TASK_B);
+  ok(b.err && b.err.code === 'FUNDING_SHORTFALL', `the $80 task is refused (${b.err && b.err.code})`);
+  ok(/\$30\.00 short/.test(b.err.message), `and the refusal says by how much: "${b.err.message}"`);
+  ok((await q('SELECT status FROM tasks WHERE id = $1', [TASK_B]))[0].status === 'ready', 'the refused task stays in the queue, unclaimed');
+
+  // 4. the task ships through the real state machine, and its pay stays held until it is paid
+  await db.resolveClaim({ claimId: a.claim.id, builderId: String(ADA), outcome: 'shipped', notesMd: 'M07 proof', force: true });
+  await db.confirmTask({ taskId: String(TASK_A), builderId: String(OWNER) });
+  await db.shipTask({ taskId: String(TASK_A), builderId: String(ADA), landAssurance: { kind: 'proof', reason: 'test fixture: land proven' } });
+  ok((await q('SELECT status FROM tasks WHERE id = $1', [TASK_A]))[0].status === 'shipped', 'the task shipped');
+  ok(await available() === 50 * USD, 'shipped but not yet paid, its $100 is still held');
+  const b2 = await claim(TASK_B);
+  ok(b2.err && b2.err.code === 'FUNDING_SHORTFALL', 'so the $80 task is still refused: money owed to Ada cannot be promised again');
+
+  // 5. the owner approves; Ada clears the gates; the first transfer is declined
+  const person = { id: OWNER, rank: 'archon', session_id: 1, session_source: 'web' };
+  const approval = await approvals.insertEvent({ kind: 'payout_approved', actor: person, recipient_id: ADA, amount_cents: 10000, currency: 'USD' }, { pool });
+  const o = { pool };
+  await gates.recordAge({ builderId: ADA, tier: 'adult', basis: 'verified_by_person', recordedBy: OWNER }, o);
+  await gates.recordScreening({ builderId: ADA, result: 'clear', screenedBy: 'person:owner', validUntil: new Date(Date.now() + 86_400_000).toISOString(), recordedBy: OWNER }, o);
+  await gates.recordNda({ builderId: ADA, status: 'on_file', ndaVersion: 'beta-v1', reference: `m07-${RUN}`, recordedBy: OWNER }, o);
+  await gates.recordTaxDetails({ builderId: ADA, status: 'collected', collectedBy: 'person:owner', reference: `onb-m07-${RUN}`, recordedBy: OWNER }, o);
+  const press = () => payouts.payForTask({ approvalId: approval.id, taskId: String(TASK_A), actorId: String(OWNER) }, { pool, processor: rail });
+  const first = await press();
+  ok(first.status === 'failed' && /declined/.test(first.reason), `a declined transfer is recorded, not lost (${first.status}: ${first.reason})`);
+  ok(await available() === 50 * USD, 'nothing left the account, and the pay is still held');
+
+  // 6. the owner sees the debt as owed but unpaid, and the balance after it
+  const out1 = await readOutflow(pool, { months: 1 });
+  const owedRow = out1.committed.owed.find((r) => r.task_id === String(TASK_A));
+  ok(owedRow && owedRow.amount_micro === 100 * USD && /declined/.test(owedRow.last_reason), 'the owner sees $100 owed to Ada, and why it is unpaid');
+  ok(owedRow.held_micro === 100 * USD, 'already covered by the hold');
+  ok(out1.balance.after_commitments_micro === 50 * USD - otherCommitted, 'so the balance after commitments counts it once, not twice');
+
+  // 7. pressed again, twice at once: paid exactly once; a third press sends nothing
+  const [p1, p2] = await Promise.all([press(), press()]);
+  ok([p1, p2].every((p) => p.status === 'paid' && p.processor_ref === `tr_m07_${RUN}`), 'both presses answer paid, with one transfer reference');
+  ok(rail.transfers.size === 1, 'the rail made one transfer');
+  const third = await press();
+  ok(third.status === 'paid' && third.already === true, 'a third press finds it paid and sends nothing');
+  const moved = await q("SELECT amount_micro FROM economy_project_account_movements WHERE kind = 'payout' AND task_id = $1", [TASK_A]);
+  ok(moved.length === 1 && Number(moved[0].amount_micro) === 100 * USD, 'one $100 payout left the account');
+  ok(await available() === 50 * USD, 'the balance fell by $100 and the hold went with it: still $50 to promise');
+
+  // 8. the owner sees the burn, the per-builder total, nothing owed
+  const out2 = await readOutflow(pool, { months: 1 });
+  const ada = out2.by_builder.find((r) => r.builder_id === String(ADA));
+  ok(ada && ada.paid_micro === 100 * USD && ada.owed_micro === 0, 'Ada reads $100 paid, nothing owed');
+  ok(!out2.committed.owed.some((r) => r.task_id === String(TASK_A)), 'nothing is left owed for the task');
+  ok(out2.burn.months[0].payouts_micro - out0.burn.months[0].payouts_micro === 100 * USD, 'this month\'s burn carries the $100 payout');
+
+  // 9. drain the balance: one more claim fits, the next is refused with its shortfall
+  const c = await claim(TASK_C);
+  ok(c.claim && !c.err, 'the $40 task fits and is claimed');
+  ok(await available() === 10 * USD, '$10 left');
+  const b3 = await claim(TASK_B);
+  ok(b3.err && b3.err.code === 'FUNDING_SHORTFALL' && b3.err.shortfall_micro === 70 * USD, `the $80 task is refused, $70 short (${b3.err && b3.err.message})`);
+
+  console.log(`funded_project_pays_proof_db.mjs: ${pass} passed`);
+} catch (e) {
+  console.error('funded_project_pays_proof_db.mjs FAILED:', e.stack || e.message);
+  process.exitCode = 1;
+} finally {
+  if (priorWall) await settings.setSetting(WALL_KEY, priorWall.value, priorWall.updated_by).catch(() => {});
+  else await q('DELETE FROM project_settings WHERE key = $1', [WALL_KEY]).catch(() => {});
+  await q('UPDATE claims SET released_at = now() WHERE task_id = ANY($1::bigint[]) AND released_at IS NULL', [[TASK_A, TASK_B, TASK_C]]).catch(() => {});
+  await q("UPDATE tasks SET status = 'abandoned' WHERE id = ANY($1::bigint[]) AND status <> 'shipped'", [[TASK_B, TASK_C]]).catch(() => {});
+  await pool.end();
+  const { pool: corePool } = require('../src/bongos/pool.js');
+  await corePool.end().catch(() => {});
+}

package/tests/funding_wall.mjs

@@ -0,0 +1,205 @@
+// tests/funding_wall.mjs — the funding wall (task 1003185, goal 1000092 M06; ADR 0386).
+// Behaviour of modules/lifecycle/funding-wall.js, with the account port and the pay-terms
+// read stubbed:
+//   - a task that pays no cash is never walled, and the rule and account are not even read;
+//   - under hold_at_claim a short project refuses with the REASON and the SHORTFALL, and a
+//     funded one holds the task's cash pay; a batch is judged cumulatively;
+//   - the dry run never locks or holds; an unreadable price and a switched-off account
+//     refuse rather than guess;
+//   - refuse_at_completion lets the claim through and refuses the "done" instead;
+//     carry_on refuses nothing;
+//   - the three claim surfaces, the resolve path and the routes are wired to it.
+// The SQL is proven against real Postgres in tests/funding_wall_db.mjs.
+
+import { test } from 'node:test';
+import { strict as assert } from 'node:assert';
+import { createRequire } from 'node:module';
+import { readFileSync } from 'node:fs';
+
+const require = createRequire(import.meta.url);
+const W = require('../modules/lifecycle/funding-wall.js');
+const { cardFor } = require('../scripts/bongos/plain-cards.js');
+const read = (rel) => readFileSync(new URL(`../${rel}`, import.meta.url), 'utf8').replace(/\r\n/g, '\n');
+
+const USD = 1_000_000;
+const cash = (amount, unit = null) => ({ source: 'task', terms: [{ pay_type: 'cash', amount, unit }] });
+const terms = (byId) => async (ids) => new Map(ids.map((id) => [id, byId[id] || { source: 'none', terms: [] }]));
+const mode = (m) => async () => ({ mode: m, chosen: true });
+
+function fakeAccount({ balance = 0, held = 0 } = {}) {
+  const calls = [];
+  return {
+    calls,
+    async lockAccount() { calls.push('lock'); },
+    async releaseSettledHolds() { calls.push('release'); return []; },
+    async readAvailable(_db, opts = {}) { calls.push(['read', opts]); return { balance_micro: balance, held_micro: held, available_micro: balance - held }; },
+    async recordMovement(_db, m) { calls.push(['hold', m]); return { recorded: true, row: m }; },
+  };
+}
+const failNow = () => { throw new Error('must not be read'); };
+
+test('the rule parses three modes and nothing else', () => {
+  assert.deepEqual(W.FUNDING_WALL_MODES, ['hold_at_claim', 'refuse_at_completion', 'carry_on']);
+  assert.equal(W.DEFAULT_FUNDING_WALL, 'hold_at_claim', 'a project that sets nothing is protected at claim (ADR 0386)');
+  assert.equal(W.parseFundingWall(' Carry_On ').mode, 'carry_on');
+  assert.ok(W.parseFundingWall('halt').reason);
+  assert.ok(W.parseFundingWall('').reason);
+});
+
+test('only a plain dollar figure is read as a price; nothing is guessed', () => {
+  assert.equal(W.dollarsMicro('250', null), 250 * USD);
+  assert.equal(W.dollarsMicro('$1,250.50', null), 1250.5 * USD);
+  assert.equal(W.dollarsMicro('40', 'USD'), 40 * USD);
+  assert.equal(W.dollarsMicro('USD 40', null), 40 * USD);
+  assert.equal(W.dollarsMicro('0.05', 'dollars'), 50_000);
+  for (const [a, u] of [['250', 'EUR'], ['negotiable', null], ['about 200', null], ['1.234', null], ['-5', null], [null, null], ['12,34', null]]) {
+    assert.equal(W.dollarsMicro(a, u), null, `${a} ${u} is not a dollar figure`);
+  }
+  assert.equal(W.usd(1250.5 * USD), '$1,250.50');
+  assert.equal(W.usd(-3 * USD), '-$3.00');
+});
+
+test('a task whose pay is not cash is never walled', () => {
+  assert.deepEqual(W.cashPrice({ terms: [{ pay_type: 'credit_pool', amount: '5' }, { pay_type: 'self_managed', amount: '900' }] }), { cash: false });
+  assert.deepEqual(W.cashPrice({ terms: [{ pay_type: 'cash', amount: '10' }, { pay_type: 'cash', amount: '5', unit: 'usd' }] }), { cash: true, micro: 15 * USD });
+  assert.equal(W.cashPrice({ terms: [{ pay_type: 'cash', amount: 'a lot' }] }).unreadable, 'a lot');
+});
+
+test('no cash pay: the rule and the account are not even read', async () => {
+  const out = await W.fundingWallFailures({
+    client: {}, tasks: [{ id: 7 }], place: true,
+    deps: { readPayTerms: terms({}), resolveFundingWall: failNow, account: { lockAccount: failNow } },
+  });
+  assert.deepEqual(out, []);
+});
+
+test('hold at claim: a short project refuses, naming the price, the balance, what is held and the shortfall', async () => {
+  const account = fakeAccount({ balance: 180 * USD, held: 80 * USD });
+  const out = await W.fundingWallFailures({
+    client: {}, tasks: [{ id: 7 }], place: true,
+    deps: { readPayTerms: terms({ 7: cash('250') }), resolveFundingWall: mode('hold_at_claim'), account },
+  });
+  assert.equal(out.length, 1);
+  const r = out[0].refusal;
+  assert.equal(r.code, 'FUNDING_SHORTFALL');
+  assert.equal(r.price_micro, 250 * USD);
+  assert.equal(r.available_micro, 100 * USD);
+  assert.equal(r.shortfall_micro, 150 * USD);
+  for (const figure of ['$250.00', '$100.00', '$180.00', '$80.00', '$150.00 short']) assert.ok(r.message.includes(figure), `the message names ${figure}`);
+  assert.ok(r.hint, 'the refusal names the way forward');
+  assert.ok(!account.calls.some((c) => c[0] === 'hold'), 'nothing is held when the claim is refused');
+});
+
+test('hold at claim: a funded project takes the lock, lets go of settled holds, then holds the pay', async () => {
+  const account = fakeAccount({ balance: 300 * USD });
+  const out = await W.fundingWallFailures({
+    client: {}, tasks: [{ id: 7 }], place: true,
+    deps: { readPayTerms: terms({ 7: cash('250') }), resolveFundingWall: mode('hold_at_claim'), account },
+  });
+  assert.deepEqual(out, []);
+  assert.deepEqual(account.calls.slice(0, 2), ['lock', 'release'], 'the lock comes first, so two claims cannot read the same balance');
+  const hold = account.calls.find((c) => c[0] === 'hold')[1];
+  assert.equal(hold.kind, 'hold');
+  assert.equal(hold.amountMicro, 250 * USD);
+  assert.equal(hold.taskId, '7');
+});
+
+test('a batch is judged cumulatively, so it cannot over-commit one balance', async () => {
+  const account = fakeAccount({ balance: 100 * USD });
+  const out = await W.fundingWallFailures({
+    client: {}, tasks: [{ id: 1 }, { id: 2 }], place: true,
+    deps: { readPayTerms: terms({ 1: cash('60'), 2: cash('60') }), resolveFundingWall: mode('hold_at_claim'), account },
+  });
+  assert.equal(out.length, 1);
+  assert.equal(out[0].task_id, 2);
+  assert.equal(out[0].refusal.held_micro, 60 * USD, 'the second task sees the first one held');
+  assert.equal(out[0].refusal.shortfall_micro, 20 * USD);
+  assert.ok(!account.calls.some((c) => c[0] === 'hold'), 'a refused batch holds nothing');
+});
+
+test('the dry run reads only: no lock, no release, no hold', async () => {
+  const account = fakeAccount({ balance: 300 * USD });
+  await W.fundingWallFailures({
+    client: {}, tasks: [{ id: 7 }],
+    deps: { readPayTerms: terms({ 7: cash('250') }), resolveFundingWall: mode('hold_at_claim'), account },
+  });
+  assert.deepEqual(account.calls.map((c) => (Array.isArray(c) ? c[0] : c)), ['read']);
+});
+
+test('an unreadable price and a switched-off account refuse rather than guess', async () => {
+  const unreadable = await W.fundingWallFailures({
+    client: {}, tasks: [{ id: 7 }], place: true,
+    deps: { readPayTerms: terms({ 7: cash('negotiable') }), resolveFundingWall: mode('hold_at_claim'), account: fakeAccount({ balance: 1e12 }) },
+  });
+  assert.equal(unreadable[0].refusal.code, 'FUNDING_PRICE_UNREADABLE');
+  assert.ok(unreadable[0].refusal.message.includes('"negotiable"'), 'it says what it read');
+  const noAccount = await W.fundingWallFailures({
+    client: {}, tasks: [{ id: 7 }], place: true,
+    deps: { readPayTerms: terms({ 7: cash('5') }), resolveFundingWall: mode('hold_at_claim'), account: null },
+  });
+  assert.equal(noAccount[0].refusal.code, 'FUNDING_NO_ACCOUNT');
+});
+
+test('refuse at completion and carry on let the claim through and hold nothing', async () => {
+  for (const m of ['refuse_at_completion', 'carry_on']) {
+    const account = fakeAccount({ balance: 0 });
+    const out = await W.fundingWallFailures({
+      client: {}, tasks: [{ id: 7 }], place: true,
+      deps: { readPayTerms: terms({ 7: cash('250') }), resolveFundingWall: mode(m), account },
+    });
+    assert.deepEqual(out, [], `${m} never refuses a claim`);
+    assert.deepEqual(account.calls, [], `${m} never touches the account at claim`);
+  }
+});
+
+test('refuse at completion: declaring a short task done is refused with the shortfall; its own hold counts for it', async () => {
+  const account = fakeAccount({ balance: 100 * USD });
+  const deps = { readPayTerms: terms({ 7: cash('250') }), resolveFundingWall: mode('refuse_at_completion'), account };
+  await assert.rejects(W.fundingWallOnResolve({}, 7, 'shipped', deps), (e) => {
+    assert.equal(e.code, 'FUNDING_SHORTFALL_AT_COMPLETION');
+    assert.equal(e.shortfall_micro, 150 * USD);
+    assert.ok(e.message.includes('marked done'));
+    return true;
+  });
+  assert.deepEqual(account.calls.find((c) => c[0] === 'read')[1], { exceptTaskId: 7 });
+  await W.fundingWallOnResolve({}, 7, 'shipped', { ...deps, account: fakeAccount({ balance: 250 * USD }) });
+});
+
+test('at completion, the other rules refuse nothing; a let-go task releases its hold', async () => {
+  for (const m of ['hold_at_claim', 'carry_on']) {
+    await W.fundingWallOnResolve({}, 7, 'shipped', { readPayTerms: terms({ 7: cash('250') }), resolveFundingWall: mode(m), account: fakeAccount() });
+  }
+  const account = fakeAccount();
+  await W.fundingWallOnResolve({}, 7, 'abandoned', { readPayTerms: failNow, resolveFundingWall: failNow, account });
+  assert.deepEqual(account.calls, ['release']);
+  await W.fundingWallOnResolve({}, 7, 'abandoned', { account: null }); // no account: nothing to release, no throw
+});
+
+test('the rule is read from the project setting; a bad or unreadable value falls to the protective default', async () => {
+  assert.equal((await W.resolveFundingWall({ getSetting: async () => ({ value: 'carry_on' }) })).mode, 'carry_on');
+  const bad = await W.resolveFundingWall({ getSetting: async () => ({ value: 'never' }) });
+  assert.equal(bad.mode, 'hold_at_claim');
+  assert.ok(bad.invalid && bad.invalid.raw === 'never');
+  assert.equal((await W.resolveFundingWall({ getSetting: async () => { throw new Error('db down'); } })).mode, 'hold_at_claim');
+  const none = await W.resolveFundingWall({ getSetting: async () => null });
+  assert.equal(none.chosen, false);
+  assert.ok(/has not chosen/.test(W.describeFundingWall(none)));
+});
+
+test('wiring: all three claim surfaces, the resolve path, the routes and the cards', () => {
+  const claims = read('modules/lifecycle/db-claims.js');
+  assert.equal((claims.match(/await fundingWallFailures\(/g) || []).length, 3, 'claimTask, claimTasksBatch and validateClaimBatch each ask the wall');
+  assert.equal((claims.match(/fundingWallFailures\(\{ client, tasks: [^}]*place: true \}\)/g) || []).length, 2, 'both real claim paths place the hold');
+  assert.match(claims, /fundingWallFailures\(\{ client: pool, tasks: taskRows \}\)/, 'the dry run only reads');
+  assert.match(read('modules/lifecycle/db-ship.js'), /fundingWallOnResolve\(client, claim\.task_id, outcome\)/);
+  const routes = read('modules/lifecycle/routes/claims.js');
+  for (const code of ['FUNDING_SHORTFALL', 'FUNDING_SHORTFALL_AT_COMPLETION', 'FUNDING_PRICE_UNREADABLE', 'FUNDING_NO_ACCOUNT']) {
+    assert.match(routes, new RegExp(`'${code}' \\? 409`), `${code} answers 409`);
+    assert.ok(cardFor(code), `${code} has a plain card`);
+  }
+  const settings = read('modules/lifecycle/routes/project-settings.js');
+  assert.match(settings, /router\.patch\('\/project-settings\/funding-wall', api\.requireBuilder, api\.requirePermission\('project\.settings\.manage'\)/);
+  assert.match(settings, /insertAuditLog\(/, 'a change to the rule is audited');
+  assert.match(settings, /funding_wall: \{ mode: wall\.mode/, 'the rule rides beside a task\'s pay terms');
+  assert.match(read('modules/economy/routes/project-account.js'), /lockAccount, releaseSettledHolds, readAvailable[,} ]/);
+});

package/tests/funding_wall_db.mjs

@@ -0,0 +1,174 @@
+// tests/funding_wall_db.mjs — task 1003185 (goal 1000092 M06; ADR 0386). Real DB.
+//
+// Applies the REAL project-account migration (economy_002) and pay-terms migration
+// (lifecycle_018), then drives the real funding wall (modules/lifecycle/funding-wall.js)
+// against the real account functions (modules/economy/project-account.js) and the real
+// pay-terms read:
+//   - a funded claim books a `hold` row; an underfunded one is refused with the shortfall;
+//   - a task let go has its hold released by state (a `hold_release` row) at the next claim;
+//   - a shipped task keeps its hold until a payout is booked for it (task 1003186);
+//   - a task with no pay terms is not walled; the project's standing cash terms are;
+//   - the owner view's held figure counts only work in flight;
+//   - refuse_at_completion counts a task's own hold for it;
+//   - TWO SIMULTANEOUS CLAIMS cannot both hold the last of one balance: the second waits
+//     on the account lock and then sees the first one's hold.
+//
+// Self-skips without a reachable Postgres.
+// Run:  DATABASE_URL=... node tests/funding_wall_db.mjs
+import { createRequire } from 'node:module';
+import { readFileSync } from 'node:fs';
+import { fileURLToPath } from 'node:url';
+import { dirname, join } from 'node:path';
+import { strict as assert } from 'node:assert';
+const require = createRequire(import.meta.url);
+const { Pool } = require('pg');
+const A = require('../modules/economy/project-account.js');
+const W = require('../modules/lifecycle/funding-wall.js');
+const P = require('../modules/lifecycle/pay-terms.js');
+const here = dirname(fileURLToPath(import.meta.url));
+const sql = (...p) => readFileSync(join(here, '..', ...p), 'utf8');
+// economy_004 (task 1004910) adds module_share_id, which recordMovement writes.
+const ACCOUNT_MIGRATION = sql('modules', 'economy', 'migrations', 'economy_002_project_account.sql')
+  + sql('modules', 'economy', 'migrations', 'economy_004_module_share_payouts.sql');
+const HOLDS_INDEX_MIGRATION = sql('modules', 'economy', 'migrations', 'economy_005_project_account_holds_index.sql');
+const TERMS_MIGRATION = sql('modules', 'lifecycle', 'migrations', 'lifecycle_018_pay_terms.sql');
+
+const pgPool = new Pool({ connectionString: process.env.DATABASE_URL || undefined, max: 3 });
+let client;
+try { client = await pgPool.connect(); } catch (e) {
+  console.log(`funding_wall_db.mjs SKIPPED — no reachable Postgres (${e.code || e.message}).`);
+  await pgPool.end().catch(() => {});
+  process.exit(0);
+}
+const SCHEMA = `t1003185_${process.pid}`;
+const USD = 1_000_000;
+let pass = 0;
+const ok = (c, m) => { assert.ok(c, m); pass++; console.log(`  ok - ${m}`); };
+const account = { lockAccount: A.lockAccount, releaseSettledHolds: A.releaseSettledHolds, readAvailable: A.readAvailable, recordMovement: A.recordMovement };
+const rule = (mode) => ({ account, resolveFundingWall: async () => ({ mode, chosen: true }) });
+const claim = (db, ids, mode = 'hold_at_claim', place = true) =>
+  W.fundingWallFailures({ client: db, tasks: ids.map((id) => ({ id })), place, deps: rule(mode) });
+const setStatus = (db, id, status) => db.query('UPDATE tasks SET status = $2 WHERE id = $1', [id, status]);
+const cash = (db, taskId, amount) => P.setPayTerms({ taskId, terms: [{ pay_type: 'cash', amount, unit: 'USD', note: null }], builderId: 1 }, { db });
+const holdsFor = async (db, taskId) => (await db.query(
+  "SELECT kind, amount_micro::bigint AS a FROM economy_project_account_movements WHERE task_id = $1 AND kind IN ('hold','hold_release') ORDER BY id", [taskId])).rows
+  .map((r) => `${r.kind}:${Number(r.a) / USD}`);
+
+try {
+  await client.query(`CREATE SCHEMA ${SCHEMA}`);
+  await client.query(`SET search_path TO ${SCHEMA}`);
+  await client.query('CREATE TABLE builders (id bigserial PRIMARY KEY, display_name text, github_login text)');
+  await client.query("CREATE TABLE tasks (id bigserial PRIMARY KEY, title text, status text NOT NULL DEFAULT 'ready')");
+  await client.query('CREATE TABLE schema_migrations (version text PRIMARY KEY)');
+  await client.query("INSERT INTO builders (display_name, github_login) VALUES ('Owner', 'owner')");
+  await client.query("INSERT INTO tasks (title) SELECT 'task ' || g FROM generate_series(1, 8) g");
+  await client.query(ACCOUNT_MIGRATION);
+  await client.query(TERMS_MIGRATION);
+  await client.query(HOLDS_INDEX_MIGRATION);
+  // schemaname: a migrated database has the same index in its own schema too (task 1003186)
+  ok((await client.query("SELECT 1 FROM pg_indexes WHERE schemaname = $1 AND indexname = 'economy_project_account_holds'", [SCHEMA])).rows.length === 1, 'the hold read has its partial index');
+  await A.recordMovement(client, { kind: 'funding', amountMicro: 300 * USD, processorRef: 'ch_seed' });
+  await cash(client, 1, '250');
+  await cash(client, 2, '100');
+
+  // 1. a funded claim holds its pay
+  await client.query('BEGIN');
+  ok((await claim(client, [1])).length === 0, 'a funded claim passes the wall');
+  await setStatus(client, 1, 'active');
+  await client.query('COMMIT');
+  ok((await holdsFor(client, 1)).join() === 'hold:250', 'the claim booked a hold for the task\'s cash pay');
+
+  // 2. the next claim sees it: the project is short and the refusal says by how much
+  await client.query('BEGIN');
+  const short = await claim(client, [2]);
+  await client.query('ROLLBACK');
+  ok(short.length === 1 && short[0].refusal.code === 'FUNDING_SHORTFALL', 'a claim the project cannot cover is refused');
+  ok(short[0].refusal.shortfall_micro === 50 * USD && /\$50\.00 short/.test(short[0].refusal.message), 'the refusal names the shortfall: $50.00');
+  ok(short[0].refusal.held_micro === 250 * USD, 'and what is already held');
+
+  // 3. a task with no pay terms is never walled
+  ok((await claim(client, [3])).length === 0, 'a task that pays no cash is not walled');
+
+  // 4. task 1 is let go: its hold is released BY STATE at the next claim, and that claim fits
+  await setStatus(client, 1, 'ready');
+  ok((await A.readAvailable(client)).held_micro === 0, 'a let-go task\'s hold no longer counts, even before its release row');
+  await client.query('BEGIN');
+  ok((await claim(client, [2])).length === 0, 'with the hold gone, the claim fits');
+  await setStatus(client, 2, 'active');
+  await client.query('COMMIT');
+  ok((await holdsFor(client, 1)).join() === 'hold:250,hold_release:250', 'the next claim wrote the hold_release row');
+  const view = await A.readAccount(client);
+  ok(view.held_micro === 100 * USD && view.available_micro === 200 * USD, 'the owner view shows only work in flight as held');
+
+  // 5. the project's standing cash terms price a task with none of its own
+  await P.setPayTerms({ taskId: null, terms: [{ pay_type: 'cash', amount: '$500', unit: null, note: null }], builderId: 1 }, { db: client });
+  const standing = await claim(client, [3], 'hold_at_claim', false);
+  ok(standing.length === 1 && standing[0].refusal.price_micro === 500 * USD, 'standing cash terms are walled too');
+
+  // 6. a batch is judged cumulatively in one transaction
+  await cash(client, 4, '150'); await cash(client, 5, '150');
+  await client.query('BEGIN');
+  const batch = await claim(client, [4, 5]);
+  await client.query('ROLLBACK');
+  ok(batch.length === 1 && batch[0].task_id === 5 && batch[0].refusal.shortfall_micro === 100 * USD, 'a batch cannot over-commit: the second task is $100 short');
+  ok((await holdsFor(client, 4)).length === 0, 'a refused batch, rolled back, left no hold');
+
+  // 7. refuse at completion: the task's own hold counts for it
+  await cash(client, 6, '200');
+  await client.query('BEGIN');
+  await claim(client, [6]);
+  await setStatus(client, 6, 'active');
+  await client.query('COMMIT');
+  ok((await A.readAvailable(client)).available_micro === 0, 'two holds take the whole balance');
+  await client.query('BEGIN');
+  await W.fundingWallOnResolve(client, 6, 'shipped', rule('refuse_at_completion'));
+  await client.query('ROLLBACK');
+  ok(true, 'a task held at claim can be marked done under refuse_at_completion: its own hold covers it');
+  await cash(client, 7, '50');
+  await setStatus(client, 7, 'active');
+  let refused = null;
+  await client.query('BEGIN');
+  try { await W.fundingWallOnResolve(client, 7, 'shipped', rule('refuse_at_completion')); } catch (e) { refused = e; }
+  await client.query('ROLLBACK');
+  ok(refused && refused.code === 'FUNDING_SHORTFALL_AT_COMPLETION' && refused.shortfall_micro === 50 * USD, 'an unheld task marked done while short is refused with the shortfall');
+
+  // 8. a shipped task keeps its hold until its builder is paid (task 1003186)
+  await setStatus(client, 2, 'shipped');
+  await setStatus(client, 6, 'shipped');
+  ok((await A.readAvailable(client)).held_micro === 300 * USD, 'shipped but unpaid, both holds still count');
+  ok((await A.releaseSettledHolds(client)).length === 0, 'and neither is released');
+  await A.recordMovement(client, { kind: 'payout', amountMicro: 100 * USD, builderId: 1, taskId: 2, processorRef: 'tr_2' });
+  ok((await A.readAvailable(client)).held_micro === 200 * USD, 'a payout booked for a task lets its hold go at once');
+  await A.recordMovement(client, { kind: 'payout', amountMicro: 200 * USD, builderId: 1, taskId: 6, processorRef: 'tr_6' });
+  ok((await A.releaseSettledHolds(client)).length === 2, 'and the next release writes both hold_release rows');
+  await A.recordMovement(client, { kind: 'funding', amountMicro: 300 * USD, processorRef: 'ch_refill' }); // balance 300, nothing in flight
+
+  // 9. two simultaneous claims on the last of one balance: one wins, one is told it is short
+  await cash(client, 8, '200');
+  const other = await pgPool.connect();
+  try {
+    await other.query(`SET search_path TO ${SCHEMA}`);
+    await client.query('BEGIN');
+    await other.query('BEGIN');
+    ok((await claim(client, [4])).length === 0, 'the first claim takes the lock and holds $150');
+    let second = null;
+    const pending = claim(other, [8]).then((f) => { second = f; });
+    await new Promise((r) => setTimeout(r, 300));
+    ok(second === null, 'the second claim waits on the account lock');
+    await setStatus(client, 4, 'active');
+    await client.query('COMMIT');
+    await pending;
+    await other.query('ROLLBACK');
+    ok(second.length === 1 && second[0].refusal.code === 'FUNDING_SHORTFALL' && second[0].refusal.shortfall_micro === 50 * USD,
+      'then sees the first hold and is refused, $50 short — the balance was not committed twice');
+  } finally {
+    await other.query('ROLLBACK').catch(() => {});
+    other.release();
+  }
+  console.log(`funding_wall_db.mjs: ${pass} passed`);
+} finally {
+  await client.query('ROLLBACK').catch(() => {});
+  await client.query(`DROP SCHEMA IF EXISTS ${SCHEMA} CASCADE`).catch(() => {});
+  client.release();
+  await pgPool.end().catch(() => {});
+}

package/tests/government_act_alone_buildings.mjs

@@ -244,6 +244,7 @@ const REQUESTS = {
   'PATCH /project-settings/ship-mode': ['PATCH', '/project-settings/ship-mode', { mode: 'sometimes' }],
   'PATCH /project-settings/tweak-autopickup': ['PATCH', '/project-settings/tweak-autopickup', { mode: 'sometimes' }],
   'PATCH /project-settings/pay-terms': ['PATCH', '/project-settings/pay-terms', { terms: 'not a list' }],
+  'PATCH /project-settings/funding-wall': ['PATCH', '/project-settings/funding-wall', { mode: 'sometimes' }],
   'PATCH /work-categories/:id': ['PATCH', `/work-categories/${BAD}`, {}],
   // task 1004941: the owner deciding a Market Watch proposal
   'POST /market-watch/proposals/:id/decide': ['POST', `/market-watch/proposals/${BAD}/decide`, { decision: 'approve' }],