@bongos/core 1.24.19 → 1.24.20

package/release-notes.json

@@ -10999,5 +10999,15 @@
       "id": "1005030",
       "text": "A mockup of the Builders leaderboard now shows the circuit-trace divider from the owner's Studio idea between the column headings and the table. The live page is unchanged."
     }
+  ],
+  "1.24.20": [
+    {
+      "id": "1005031",
+      "text": "The Studio now shows what a picture will cost and asks before it starts, shows the final cost, and writes its answers in readable headings and lists."
+    },
+    {
+      "id": "1005032",
+      "text": "The Builders page now has the circuit-trace divider from the owner's Studio idea between the column headings and the first row, in light and dark and on phones."
+    }
   ]
 }

package/src/module-api.js

@@ -81,7 +81,7 @@ const { sleep } = require('./sleep');
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.24.19'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.24.20'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/hall_ai_studio.mjs

@@ -53,13 +53,37 @@ test('the receipt: our key splits the provider and our markup; an own key charge
   const ours = lib.receipt(done, 1.08);
   assert.deepEqual(ours.rows, [['Paid with', 'your balance'], ['OpenRouter', '$0.0390'], ['Our 8%', '$0.0031'], ['You paid', '$0.0421']]);
   const gemini = lib.receipt(dated(fixture('ai-studio__requests__own')).request, 1.08);
-  assert.deepEqual(gemini.rows, [['Paid with', 'your own Gemini key'], ['Cost', 'not reported']]);
+  assert.deepEqual(gemini.rows, [['Paid with', 'your own Gemini key'], ['Cost', 'about $0.0640']]);
+  assert.match(gemini.note, /estimate/);
   assert.match(gemini.note, /We charged nothing/);
   const openrouter = lib.receipt({ status: 'done', key_source: 'own', provider_cost_micro: 39000 }, 1.08);
   assert.deepEqual(openrouter.rows, [['Paid with', 'your own OpenRouter key'], ['Cost', '$0.0390']]);
   assert.deepEqual(lib.receipt(dated(fixture('ai-studio__requests__failed')).request, 1.08).rows, [], 'a failed run has no receipt');
 });
 
+test('the estimate is the median of finished runs, capped at the ceiling; the cost line reads plainly', () => {
+  assert.deepEqual(lib.estimate([], 500000), { typical: null, max: 500000, basis: 0 });
+  const runs = [{ status: 'done', key_source: 'ours', price_micro: 40000 }, { status: 'done', key_source: 'ours', price_micro: 20000 }, { status: 'done', key_source: 'ours', price_micro: 90000 }, { status: 'failed', key_source: 'ours', price_micro: 999999 }, { status: 'done', key_source: 'own', provider_cost_micro: 30000, price_micro: 0 }];
+  assert.deepEqual(lib.estimate(runs, 500000, true), { typical: 40000, max: 500000, basis: 3 });
+  assert.deepEqual(lib.estimate(runs, 500000, false), { typical: 30000, max: 500000, basis: 1 }, 'an own-key guess uses the provider cost, no markup');
+  assert.equal(lib.estimate([{ status: 'done', key_source: 'ours', price_micro: 900000 }], 500000, true).typical, 500000);
+  assert.equal(lib.costHeadline({ status: 'done', key_source: 'ours', price_micro: 41000 }), 'This cost $0.0410, taken from your balance.');
+  assert.match(lib.costHeadline({ status: 'done', key_source: 'own', provider_cost_micro: null }), /about \$0\.0640 on your Gemini key/);
+  assert.equal(lib.geminiEstimate(3), 142000, 'a reply plus each picture');
+  assert.equal(lib.costHeadline({ status: 'failed', key_source: 'ours', price_micro: 1 }), '');
+});
+
+test('the reply reads as headings, a list and folded code, never raw markup', () => {
+  const fence = '`'.repeat(3);
+  const md = ['### What works', '* **Feel:** the `rule` line', '* Second', '--', `${fence}xml`, '<svg a="1"/>', fence, 'Done <b>x</b>'].join('\n');
+  const html = lib.replyHtml(md, escapeHtml);
+  assert.ok(html.includes('<h3 class="ais-rh">What works</h3>'), html);
+  assert.ok(html.includes('<ul><li><b>Feel:</b> the <code>rule</code> line</li><li>Second</li></ul>'), html);
+  assert.ok(html.includes('<summary>Code from the answer</summary><pre>&lt;svg a=&quot;1&quot;/&gt;</pre></details>'), html);
+  assert.ok(html.includes('<p>Done &lt;b&gt;x&lt;/b&gt;</p>'), html);
+  assert.ok(!html.includes('###') && !html.includes(fence) && !html.includes('<p>--'), html);
+});
+
 test('the month: added, spent, money back and own-key requests, from the ledger', () => {
   const bal = dated(fixture('ai-studio__balance'));
   const sum = lib.monthSummary(bal.ledger, new Date());
@@ -368,6 +392,9 @@ test('page: step 3 sends the request on the card pressed, with copies of the car
   assert.match(p.page.innerHTML, /\$12\.40 left/);
   const ours = p.page.querySelectorAll('[data-pay]').find((b) => b.getAttribute('data-pay') === 'ours');
   await ours.fire('click');
+  assert.match(p.page.querySelector('#ais-confirm').innerHTML, /to make this/, 'the cost is shown before anything is sent');
+  assert.equal(p.calls.filter((c) => c.method === 'POST').length, 0, 'nothing is sent until the artist says yes');
+  await p.page.querySelector('#ais-confirm').querySelector('#ais-confirm-go').fire('click');
   await settle();
   const uploads = p.calls.filter((c) => c.method === 'POST' && c.url.endsWith('/ai-studio/uploads'));
   assert.equal(uploads.length, 3, 'a file goes with one request only, so each carried file is uploaded again');
@@ -470,6 +497,19 @@ test('walls: the studio home shows the AI door only where the module is on', ()
   assert.match(js, /loadAi\(\)\]/);
 });
 
+test('page: Not yet closes the confirm box and sends nothing', async () => {
+  const p = bootPage('?step=make&from=1001');
+  await settle();
+  const ours = p.page.querySelectorAll('[data-pay]').find((b) => b.getAttribute('data-pay') === 'ours');
+  await ours.fire('click');
+  const box = p.page.querySelector('#ais-confirm');
+  assert.ok(box.innerHTML.includes('It will never cost more than $0.50.'), box.innerHTML);
+  await box.querySelector('#ais-confirm-cancel').fire('click');
+  assert.equal(box.innerHTML, '');
+  assert.equal(box.hidden, true);
+  assert.equal(p.calls.filter((c) => c.method === 'POST').length, 0);
+});
+
 test('page: with both own keys saved, step 3 offers one card each and sends the one pressed', async () => {
   const both = { keys: [{ provider: 'openrouter', set: true, last4: '4f2a' }, { provider: 'gemini', set: true, last4: '9c1d' }] };
   assert.deepEqual(lib.ownKeys(both).map((k) => k.provider), ['openrouter', 'gemini']);
@@ -480,6 +520,9 @@ test('page: with both own keys saved, step 3 offers one card each and sends the
   assert.match(p.page.innerHTML, /My Gemini key/);
   const gem = p.page.querySelectorAll('[data-pay]').find((b) => b.getAttribute('data-pay') === 'gemini');
   await gem.fire('click');
+  assert.match(p.page.querySelector('#ais-confirm').innerHTML, /to make this/, 'the cost is shown before anything is sent');
+  assert.equal(p.calls.filter((c) => c.method === 'POST').length, 0, 'nothing is sent until the artist says yes');
+  await p.page.querySelector('#ais-confirm').querySelector('#ais-confirm-go').fire('click');
   await settle();
   const sent = p.calls.find((c) => c.method === 'POST' && c.url.endsWith('/ai-studio/requests'));
   assert.equal(sent.body.pay_with, 'gemini');

package/tests/hall_roster_world.mjs

@@ -302,3 +302,13 @@ test('the states files exercise the redesign\'s new states', () => {
   const sessions = JSON.parse(read('sessions.states.json'));
   assert.deepEqual(sessions.states.ledger.expect.visible, ['#stats-scroll', '#sessions-scroll']);
 });
+
+test('the roster draws the circuit divider in CSS, on the first row\'s cell and not the row', () => {
+  const css = read('roster.css');
+  const rule = css.slice(css.indexOf('the circuit divider'));
+  assert.match(rule, /tr:first-child:not\(:has\(\.ledger__empty\)\) td:first-child::before/, 'the traces hang on the first cell');
+  assert.match(rule, /td:first-child::after/, 'and so do the nodes');
+  assert.doesNotMatch(rule, /:has\(\.ledger__empty\)\)::(before|after)/, 'never on the tr itself: a tr pseudo becomes a table cell and shifts the row');
+  assert.match(rule, /background: var\(--ink-faint\)/, 'traces spend the faint ink token');
+  assert.match(rule, /background: var\(--accent\)/, 'nodes spend the accent token');
+});