@bongos/core 1.24.16 → 1.24.18

package/tests/builder_payouts_db.mjs

@@ -0,0 +1,109 @@
+// tests/builder_payouts_db.mjs — task 1003183 (goal 1000092 M04). Real DB.
+//
+// Applies the REAL economy_002 and core_290 migrations and proves what Postgres itself
+// refuses: a second debt for one builder and task, a second debt on one approval, a second
+// `sent` attempt for one debt, a sent attempt with no transfer reference, a failed one with
+// no reason, and any UPDATE or DELETE. Then drives the real payForTask and listPayouts over
+// the real tables: held with no processor, paid once, the movement booked, a re-press a no-op.
+//
+// payout_approvals is a minimal stand-in here (its own triggers are core_283's, proven in
+// tests/payout_approvals_db.mjs); the authority is stubbed, as the gates are core's.
+//
+// Self-skips without a reachable Postgres.
+// Run:  DATABASE_URL=... node tests/builder_payouts_db.mjs
+import { createRequire } from 'node:module';
+import { readFileSync } from 'node:fs';
+import { fileURLToPath } from 'node:url';
+import { dirname, join } from 'node:path';
+import { strict as assert } from 'node:assert';
+const require = createRequire(import.meta.url);
+const { Pool } = require('pg');
+const P = require('../src/bongos/builder-payouts.js');
+const ACCOUNT = require('../modules/economy/project-account.js');
+const here = dirname(fileURLToPath(import.meta.url));
+const mig = (...p) => readFileSync(join(here, '..', ...p), 'utf8');
+
+const pgPool = new Pool({ connectionString: process.env.DATABASE_URL || undefined, max: 1 });
+let client;
+try { client = await pgPool.connect(); } catch (e) {
+  console.log(`builder_payouts_db.mjs SKIPPED — no reachable Postgres (${e.code || e.message}).`);
+  await pgPool.end().catch(() => {});
+  process.exit(0);
+}
+const SCHEMA = `t1003183_${process.pid}`;
+let pass = 0;
+const ok = (c, m) => { assert.ok(c, m); pass++; console.log(`  ok - ${m}`); };
+const rejects = async (sql, params) => {
+  await client.query('SAVEPOINT s');
+  let err = null;
+  try { await client.query(sql, params); } catch (e) { err = e; }
+  await client.query('ROLLBACK TO SAVEPOINT s');
+  return err;
+};
+const code = (e) => e && e.code;
+const OWED = 'INSERT INTO builder_payouts_owed (builder_id, task_id, approval_id, amount_cents, currency, recorded_by) VALUES ($1,$2,$3,$4,$5,$6) RETURNING id';
+const TRY = 'INSERT INTO builder_payout_attempts (owed_id, outcome, processor_ref, reason) VALUES ($1,$2,$3,$4)';
+
+try {
+  await client.query(`CREATE SCHEMA ${SCHEMA}`);
+  await client.query(`SET search_path TO ${SCHEMA}`);
+  await client.query('CREATE TABLE builders (id bigserial PRIMARY KEY, display_name text)');
+  await client.query('CREATE TABLE tasks (id bigserial PRIMARY KEY, title text)');
+  await client.query('CREATE TABLE schema_migrations (version text PRIMARY KEY)');
+  await client.query(`CREATE TABLE payout_approvals (id bigserial PRIMARY KEY, kind text NOT NULL, recipient_id bigint,
+                       amount_cents bigint, currency text)`);
+  await client.query("INSERT INTO builders (display_name) VALUES ('Ada'), ('Owner')");
+  await client.query("INSERT INTO tasks (title) VALUES ('Build the thing'), ('Build another')");
+  await client.query(`INSERT INTO payout_approvals (kind, recipient_id, amount_cents, currency)
+                      VALUES ('payout_approved', 1, 12500, 'USD'), ('payout_approved', 1, 300, 'USD'), ('payout_approved', 1, 400, 'USD')`);
+  await client.query(mig('modules', 'economy', 'migrations', 'economy_002_project_account.sql'));
+  await client.query(mig('migrations', 'core_290_builder_payouts.sql'));
+  await client.query('BEGIN');
+
+  // ── what the database refuses ──
+  const owedId = (await client.query(OWED, [1, 2, 3, 400, 'USD', 2])).rows[0].id;
+  ok(code(await rejects(OWED, [1, 2, 2, 300, 'USD', 2])) === '23505', 'a second debt for one builder and task is refused');
+  ok(code(await rejects(OWED, [1, 1, 3, 400, 'USD', 2])) === '23505', 'a second debt on one approval is refused');
+  ok(code(await rejects(OWED, [1, 1, 2, 0, 'USD', 2])) === '23514', 'a debt of zero is refused');
+  ok(code(await rejects(OWED, [1, 1, 2, 300, 'usd', 2])) === '23514', 'a currency that is not a three-letter code is refused');
+  ok(code(await rejects(TRY, [owedId, 'sent', null, null])) === '23514', 'a sent attempt with no transfer reference is refused');
+  ok(code(await rejects(TRY, [owedId, 'failed', null, null])) === '23514', 'a failed attempt with no reason is refused');
+  ok(code(await rejects(TRY, [owedId, 'paid', 'tr_x', null])) === '23514', 'an unknown outcome is refused');
+  await client.query(TRY, [owedId, 'sent', 'tr_a', null]);
+  ok(code(await rejects(TRY, [owedId, 'sent', 'tr_b', null])) === '23505', 'a second sent attempt for one debt is refused');
+  ok(code(await rejects('UPDATE builder_payouts_owed SET amount_cents = 1')) === 'P0001', 'a debt is never edited');
+  ok(code(await rejects('DELETE FROM builder_payouts_owed')) === 'P0001', 'a debt is never deleted');
+  ok(code(await rejects("UPDATE builder_payout_attempts SET outcome = 'failed', reason = 'x'")) === 'P0001', 'an attempt is never edited');
+  ok(code(await rejects('DELETE FROM builder_payout_attempts')) === 'P0001', 'an attempt is never deleted');
+
+  // ── the real writer over the real tables ──
+  const db = { query: (s, p) => client.query(s, p) };
+  const allow = { checkApproval: async () => ({ ok: true, pay_to: 'self' }) };
+  const calls = [];
+  const processor = { async transfer(req) { calls.push(req); return { ref: 'tr_real_1' }; } };
+
+  const held = await P.payForTask({ approvalId: 1, taskId: 1, actorId: 2 }, { pool: db, account: ACCOUNT, authority: allow });
+  ok(held.status === 'held' && held.reason === 'no_processor', 'with no processor the debt is recorded and held');
+  const paid = await P.payForTask({ approvalId: 1, taskId: 1, actorId: 2 }, { pool: db, account: ACCOUNT, authority: allow, processor });
+  ok(paid.status === 'paid' && paid.processor_ref === 'tr_real_1', 'the same debt is then paid');
+  const again = await P.payForTask({ approvalId: 1, taskId: 1, actorId: 2 }, { pool: db, account: ACCOUNT, authority: allow, processor });
+  ok(again.status === 'paid' && again.already === true && calls.length === 1, 'pressing again sends nothing');
+  const mv = await client.query("SELECT amount_micro, builder_id, task_id FROM economy_project_account_movements WHERE kind = 'payout'");
+  ok(mv.rows.length === 1 && Number(mv.rows[0].amount_micro) === 125_000_000 && String(mv.rows[0].task_id) === '1',
+    'one payout movement, in micro-dollars, naming the task');
+
+  const list = await P.listPayouts(db, {});
+  const row = list.payouts.find((x) => x.approval_id === '1');
+  ok(list.total === 2 && row.status === 'paid' && row.processor_ref === 'tr_real_1' && row.builder_name === 'Ada',
+    'the owner list reads it as paid, with the person and the transfer');
+  const other = list.payouts.find((x) => x.approval_id === '3');
+  ok(other.status === 'paid', 'a debt with a sent attempt reads paid');
+
+  await client.query('ROLLBACK');
+  console.log(`builder_payouts_db.mjs: ${pass} passed`);
+} finally {
+  await client.query('ROLLBACK').catch(() => {});
+  await client.query(`DROP SCHEMA IF EXISTS ${SCHEMA} CASCADE`).catch(() => {});
+  client.release();
+  await pgPool.end();
+}

package/tests/hall_ai_studio.mjs

@@ -469,3 +469,18 @@ test('walls: the studio home shows the AI door only where the module is on', ()
   assert.match(js, /mods\.enabled\['ai-studio'\] !== true\) return;/, 'off by default: a missing flag hides the door');
   assert.match(js, /loadAi\(\)\]/);
 });
+
+test('page: with both own keys saved, step 3 offers one card each and sends the one pressed', async () => {
+  const both = { keys: [{ provider: 'openrouter', set: true, last4: '4f2a' }, { provider: 'gemini', set: true, last4: '9c1d' }] };
+  assert.deepEqual(lib.ownKeys(both).map((k) => k.provider), ['openrouter', 'gemini']);
+  const p = bootPage('?step=make&from=1001', { routes: { 'GET /api/bongos/ai-studio/keys': both } });
+  await settle();
+  const pays = p.page.querySelectorAll('[data-pay]').map((b) => b.getAttribute('data-pay'));
+  assert.deepEqual(pays, ['openrouter', 'gemini', 'ours']);
+  assert.match(p.page.innerHTML, /My Gemini key/);
+  const gem = p.page.querySelectorAll('[data-pay]').find((b) => b.getAttribute('data-pay') === 'gemini');
+  await gem.fire('click');
+  await settle();
+  const sent = p.calls.find((c) => c.method === 'POST' && c.url.endsWith('/ai-studio/requests'));
+  assert.equal(sent.body.pay_with, 'gemini');
+});