@bongos/core 1.23.9 → 1.23.11

package/tests/landing_legal_pages.mjs

@@ -193,7 +193,11 @@ for (const p of PAGES) {
     assert.deepEqual(bandLinks(bandOf(html, 'menuProjects')), [
       ['Sky', '/projects?view=map'], ['Table', '/projects?view=map&sub=table'],
       ['Your projects', '/projects?view=mine'], ['New project', '/projects?view=new'],
+      // the Community menu's three sub-pages, folded into the band under 480px (task 1003363); apex-only
+      ['Leaderboard', '/community'], ['Find a builder', '/community/find'], ['Open to recruiters', '/community/recruiters'],
+      ['Builders you may know', '/connections#connSuggest'],
     ], 'this page has no views of its own, so every item names /projects in full');
+    assert.deepEqual(bandLinks(bandOf(stripApexOnly(html, false), 'menuProjects')).map((l) => l[0]), ['Sky', 'Table', 'Your projects', 'New project'], 'a child has no /community');
     assert.deepEqual(bandLinks(bandOf(html, 'menuProfile')), [
       ['My projects', '/projects?view=mine'], ['Invitations', '/invitations'], ['Connections', '/connections'], ['Account', '/account'], ['Sign out', '/api/bongos/auth/logout'],
     ]);
@@ -261,6 +265,8 @@ function bootBar(html, answer, pathname) {
     els.set(m[3], el(m[3], /\shidden\b/.test(m[2] + m[4]), attrs));
   }
   const trigs = [...els.values()].filter((e) => /\btrig\b/.test(e.attrs.class || ''));
+  // the signed-in-only "Builders you may know" cells (task 1004256), by class; a child has none
+  const knowCells = [...html.matchAll(/<li class="bandCell(?: bandFold)? knowCell" hidden>/g)].map(() => ({ hidden: true }));
   const bands = [...html.matchAll(/<div class="menuBand" id="(\w+)"[\s\S]*?\n<\/div>/g)].map((m) => {
     const band = els.get(m[1]);
     band.items = [...m[0].matchAll(/<li class="bandCell"(?: id="(\w+)")?><a class="([^"]+)" href="([^"]+)"([^>]*)>([^<]+)<\/a>/g)].map((a) => ({
@@ -284,7 +290,7 @@ function bootBar(html, answer, pathname) {
   const event = (extra) => ({ prevented: false, preventDefault() { this.prevented = true; }, ...extra });
   const calls = [];
   const dom = {
-    els, calls, assigned: null,
+    els, calls, knowCells, assigned: null,
     active: () => document.activeElement,
     band: (id) => els.get(id),
     item: (id, text) => els.get(id).items.find((i) => i.text === text),
@@ -309,6 +315,7 @@ function bootBar(html, answer, pathname) {
     querySelectorAll(sel) {
       if (sel === '.trig') return trigs;
       if (sel === '.menuBand') return bands;
+      if (sel === '.knowCell') return knowCells;
       throw new Error(`unstubbed selector: ${sel}`);
     },
   };
@@ -338,6 +345,7 @@ for (const p of PAGES) {
       assert.equal(out.els.get('who').hidden, true, 'no chip without a session');
       assert.equal(out.els.get('signinTop').hidden, false);
       assert.equal(out.els.get('mineCell').hidden, true, 'and the Projects band offers no Your projects');
+      assert.deepEqual(out.knowCells.map((c) => c.hidden), hub ? [true, true] : [], 'nor Builders you may know; a child has no community menu at all');
       assert.equal(await out.window.HubBar.ready, null);
 
       const dom = bootBar(served, signedIn, p.route);
@@ -349,6 +357,7 @@ for (const p of PAGES) {
       assert.equal(dom.els.get('who').getAttribute('aria-label'), 'Account, octocat');
       for (const id of ['whoImg', 'bandWhoImg']) assert.equal(dom.els.get(id).src, 'https://avatars.example/u/1');
       assert.equal(dom.els.get('mineCell').hidden, false);
+      assert.deepEqual(dom.knowCells.map((c) => c.hidden), hub ? [false, false] : []);
       assert.deepEqual(dom.band('menuProfile').items.map((i) => i.text), hub ? ['My projects', 'Invitations', 'Connections', 'Account', 'Sign out'] : ['My projects', 'Sign out']);
     });
   }

package/tests/landing_page.mjs

@@ -594,7 +594,7 @@ test('the bands are one disclosure: Escape returns focus, arrows cycle, Tab out
   assert.match(CODE, /else openMenu\(t, ev\.detail === 0\);/, 'a keyboard-fired click is told apart from a pointer');
   assert.match(CODE, /if \(ev\.key === 'Escape'\) \{ closeMenus\(\); return; \}/);
   assert.match(CODE, /if \(ev\.key !== 'ArrowDown' && ev\.key !== 'ArrowUp'\) return;/);
-  assert.match(CODE, /return !a\.closest\('\[hidden\]'\);/, 'the arrows skip the hidden Your-projects cell');
+  assert.match(CODE, /return !a\.closest\('\[hidden\]'\) && a\.offsetParent !== null;/, 'the arrows skip the hidden Your-projects cell, and the Community cell above 900px, which CSS does not draw (task 1003363)');
   assert.match(CODE, /b\.addEventListener\('focusout', function \(ev\) \{[\s\S]*?if \(!to \|\| b\.contains\(to\) \|\| \(to\.closest && to\.closest\('\.trig'\)\)\) return;[\s\S]*?closeMenus\(\);/, 'Tab out closes; a null relatedTarget is left alone');
   assert.match(CODE, /if \(ev\.target\.closest && \(ev\.target\.closest\('\.menuBand'\) \|\| ev\.target\.closest\('\.trig'\)\)\) return;[\s\S]*?closeMenus\(\);/, 'a click outside closes');
   assert.doesNotMatch(HTML, /role="menu"|aria-haspopup/, 'plain links in a disclosure — what is announced is what ships');

package/tests/render_check.mjs

@@ -25,8 +25,8 @@ test('a shared asset reaches every page in its dir whose HTML names it', () => {
   assert.deepEqual(names(['modules/hall-ui/public/sky-data.js']), ['goal-map.states.json', 'thinking.states.json']);
   assert.deepEqual(names(['modules/hall-ui/public/text-fit.js']), ['goals.states.json']);
   // the account page links the hub's sheet too since task 1004259, the guild page since task 1002301,
-  // the invitations page since task 1004276, and the connections page since task 1004278
-  assert.deepEqual(names(['modules/public-landing/public/assets/cosmos.css']), ['account.states.json', 'connections.states.json', 'guild.states.json', 'invitations.states.json', 'projects.states.json']);
+  // the invitations page since task 1004276, the connections page since task 1004278, and the community page since task 1003363
+  assert.deepEqual(names(['modules/public-landing/public/assets/cosmos.css']), ['account.states.json', 'community.states.json', 'connections.states.json', 'guild.states.json', 'invitations.states.json', 'projects.states.json']);
 });
 
 test('the page a builder changed comes before the pages a shared file reaches, so the render cap never drops it', () => {

package/tests/ui_design_kit.mjs

@@ -43,14 +43,14 @@ test('the shipped states files validate and sit beside the page they name', () =
   }
   // the apex is dark only (task 1003336): its states files name the one mode, and
   // render.js reads it as the default so a plain `--page /` never renders light
-  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/index.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/guild.states.json', 'modules/public-landing/public/invitations.states.json', 'modules/public-landing/public/connections.states.json', 'modules/public-landing/public/connections-empty.states.json', 'modules/public-landing/public/connections-inactive.states.json']) {
+  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/index.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/guild.states.json', 'modules/public-landing/public/invitations.states.json', 'modules/public-landing/public/connections.states.json', 'modules/public-landing/public/connections-empty.states.json', 'modules/public-landing/public/connections-inactive.states.json', 'modules/public-landing/public/community.states.json', 'modules/public-landing/public/community-empty.states.json', 'modules/public-landing/public/community-recruiter.states.json']) {
     assert.deepEqual(readJson(rel).modes, ['dark'], `${rel}: the apex renders dark only`);
     assert.equal(readJson(rel).modeQuery, false, `${rel}: no query walks a second mode`);
   }
 });
 
 test('the shipped probes files validate', () => {
-  for (const rel of ['modules/public-landing/public/projects.probes.json', 'modules/public-landing/public/index.probes.json', 'modules/public-landing/public/account.probes.json', 'modules/public-landing/public/guild.probes.json', 'modules/public-landing/public/invitations.probes.json', 'modules/public-landing/public/connections.probes.json']) {
+  for (const rel of ['modules/public-landing/public/projects.probes.json', 'modules/public-landing/public/index.probes.json', 'modules/public-landing/public/account.probes.json', 'modules/public-landing/public/guild.probes.json', 'modules/public-landing/public/invitations.probes.json', 'modules/public-landing/public/connections.probes.json', 'modules/public-landing/public/community.probes.json']) {
     const v = lib.validateProbesFile(readJson(rel));
     assert.deepEqual(v.errors, [], `${rel}: ${v.errors.join('; ')}`);
   }