@bongos/core 1.23.22 → 1.24.1

package/scripts/bongos/smoke-dependencies.sh

@@ -1,143 +0,0 @@
-#!/usr/bin/env bash
-# Smoke test for the dependency + auto-promotion system (ADR 0015 / migration 020).
-#
-# Round-trip:
-#   1. Create task A with status='backlog', kind='feature'
-#   2. Create task B with status='ready'
-#   3. Wire A.dependencies = [B]    (A's status stays backlog — auto-promotion only
-#                                    fires when B SHIPS, not when the edge is added)
-#   4. Try to claim A — must fail 409 DEPS_NOT_SHIPPED (manual promote test)
-#   5. Promote A manually (the route allows it; the gate is at claim time)
-#   6. Try to claim A — still 409 DEPS_NOT_SHIPPED
-#   7. Claim B, ship B (active → completed → confirmed → shipped)
-#   8. Verify C — a second dependent of B that NOTHING ever promoted by hand —
-#      flipped backlog→ready. This is the only assertion that can fail if the
-#      auto-promotion trigger is broken (task 1004191): A was already 'ready'
-#      from the manual step, so A's status proves nothing about the trigger.
-#   9. Claim A — succeeds
-#  10. Release A, abandon A and C (B is shipped and cannot be abandoned)
-#
-# Run from any environment with a valid CLI session (/builder-setup).
-# Requires curl.
-set -euo pipefail
-
-# Token + API base both come from lib.sh, which resolves them through
-# instance-config the way every /builder-* command does. The literals that used
-# to live here were doubly broken: a macOS-only /Users/$USER path and a baked-in
-# founder host, so this smoke could not run on any other OS or instance
-# (task 1002567).
-# shellcheck source=scripts/bongos/lib.sh
-source "$(dirname "$0")/lib.sh"
-
-TOKEN="$(gds_resolve_token)" || exit $?
-BASE="${GDS_BASE:-$(gds_api_base)}"
-SUFFIX="$(date +%s)"
-
-echo "=== 1. Create task B (depends-on target, status=ready) ==="
-B=$(curl -sS -X POST "$BASE/api/bongos/tasks" \
-  -H "Authorization: Bearer $TOKEN" -H "Content-Type: application/json" \
-  --data "{\"version_id\":\"GDS-V3\",\"title\":\"__smoke__ dep-test B $SUFFIX\",\"description\":\"smoke\",\"status\":\"ready\",\"kind\":\"feature\",\"discipline\":\"engineering\",\"priority\":5,\"touches\":[\"smoke-dep-B-$SUFFIX/\"],\"source\":\"smoke\",\"source_ref\":\"smoke-dep-B-$SUFFIX\"}")
-B_ID=$(echo "$B" | python3 -c "import json,sys; print(json.load(sys.stdin)['task']['id'])")
-echo "  B id=$B_ID"
-
-echo "=== 2. Create task A (dependent, status=backlog) ==="
-A=$(curl -sS -X POST "$BASE/api/bongos/tasks" \
-  -H "Authorization: Bearer $TOKEN" -H "Content-Type: application/json" \
-  --data "{\"version_id\":\"GDS-V3\",\"title\":\"__smoke__ dep-test A $SUFFIX\",\"description\":\"smoke\",\"status\":\"backlog\",\"kind\":\"feature\",\"discipline\":\"engineering\",\"priority\":5,\"touches\":[\"smoke-dep-A-$SUFFIX/\"],\"source\":\"smoke\",\"source_ref\":\"smoke-dep-A-$SUFFIX\"}")
-A_ID=$(echo "$A" | python3 -c "import json,sys; print(json.load(sys.stdin)['task']['id'])")
-echo "  A id=$A_ID"
-
-echo "=== 2b. Create task C (dependent, status=backlog, NEVER promoted by hand) ==="
-# task 1004191 (finding 62 of the task 1000379 audit): A is promoted manually in
-# step 4, so "A is ready after B ships" held whether or not the auto-promotion
-# trigger fired. C exists to be the dependent only the trigger can flip.
-C=$(curl -sS -X POST "$BASE/api/bongos/tasks" \
-  -H "Authorization: Bearer $TOKEN" -H "Content-Type: application/json" \
-  --data "{\"version_id\":\"GDS-V3\",\"title\":\"__smoke__ dep-test C $SUFFIX\",\"description\":\"smoke\",\"status\":\"backlog\",\"kind\":\"feature\",\"discipline\":\"engineering\",\"priority\":5,\"touches\":[\"smoke-dep-C-$SUFFIX/\"],\"source\":\"smoke\",\"source_ref\":\"smoke-dep-C-$SUFFIX\"}")
-C_ID=$(echo "$C" | python3 -c "import json,sys; print(json.load(sys.stdin)['task']['id'])")
-echo "  C id=$C_ID"
-
-echo "=== 3. Wire A → depends_on B, and C → depends_on B ==="
-curl -sS -X POST "$BASE/api/bongos/tasks/$C_ID/dependencies" \
-  -H "Authorization: Bearer $TOKEN" -H "Content-Type: application/json" \
-  --data "{\"depends_on_task_id\": $B_ID}" >/dev/null
-C_PRE=$(curl -sS -H "Authorization: Bearer $TOKEN" "$BASE/api/bongos/tasks/$C_ID" | python3 -c "import json,sys; print(json.load(sys.stdin)['task']['status'])")
-[ "$C_PRE" = "backlog" ] && echo "  PASS: C is backlog before B ships" || (echo "  FAIL: C is '$C_PRE' before B ships — the auto-promotion check below would prove nothing"; exit 1)
-curl -sS -X POST "$BASE/api/bongos/tasks/$A_ID/dependencies" \
-  -H "Authorization: Bearer $TOKEN" -H "Content-Type: application/json" \
-  --data "{\"depends_on_task_id\": $B_ID}" | python3 -m json.tool
-
-echo "=== 4. Manually promote A (testing claim-time gate, not auto-promote) ==="
-curl -sS -X POST "$BASE/api/bongos/tasks/$A_ID/promote" -H "Authorization: Bearer $TOKEN" | python3 -m json.tool
-
-echo "=== 5. Attempt claim A — MUST 409 DEPS_NOT_SHIPPED ==="
-CLAIM_RESP=$(curl -sS -X POST "$BASE/api/bongos/claims" \
-  -H "Authorization: Bearer $TOKEN" -H "Content-Type: application/json" \
-  --data "{\"task_id\": $A_ID, \"worktree_name\": \"smoke-$SUFFIX\"}")
-echo "$CLAIM_RESP" | python3 -m json.tool
-echo "$CLAIM_RESP" | grep -q "DEPS_NOT_SHIPPED" && echo "  PASS: claim refused with DEPS_NOT_SHIPPED" || (echo "  FAIL: claim was not refused"; exit 1)
-
-echo "=== 6. Claim + ship B (the dep) ==="
-node scripts/bongos/claim.js "$B_ID" --worktree "smoke-$SUFFIX-B"
-# Move through completed → confirmed → shipped using direct API calls (skip the
-# scanner/grader by going straight at /resolve + /confirm + /ship)
-curl -sS -X POST "$BASE/api/bongos/claims/by-task/$B_ID/resolve" \
-  -H "Authorization: Bearer $TOKEN" -H "Content-Type: application/json" \
-  --data '{"outcome":"completed","verification":{"passed":true,"smoke_ok":true}}' >/dev/null
-curl -sS -X POST "$BASE/api/bongos/tasks/$B_ID/confirm" -H "Authorization: Bearer $TOKEN" >/dev/null
-curl -sS -X POST "$BASE/api/bongos/tasks/$B_ID/ship"    -H "Authorization: Bearer $TOKEN" >/dev/null
-
-echo "=== 7. Verify the auto-promotion trigger fired: C backlog → ready ==="
-# C was never promoted by hand, so only promote_dependents_on_ship can have made
-# it 'ready'. (A is 'ready' from the manual step 4 regardless, so A is not asserted
-# here — that is the assertion that used to pass with the trigger broken.)
-C_STATUS=$(curl -sS -H "Authorization: Bearer $TOKEN" "$BASE/api/bongos/tasks/$C_ID" | python3 -c "import json,sys; print(json.load(sys.stdin)['task']['status'])")
-echo "  C status: $C_STATUS"
-[ "$C_STATUS" = "ready" ] && echo "  PASS: C auto-promoted" || (echo "  FAIL: C is '$C_STATUS' — B shipped but the auto-promotion trigger did not flip its dependent"; exit 1)
-
-echo "=== 8. Claim A — must succeed now ==="
-node scripts/bongos/claim.js "$A_ID" --worktree "smoke-$SUFFIX-A"
-
-echo "=== 9. Cleanup — abandon A and C; B is shipped and stays ==="
-# task 1004026: this step used to ANNOUNCE "release A; mark both abandoned" and then
-# only release A. Neither task reached a terminal state, so every run leaked two
-# __smoke__ rows into the live tasks table — invisibly, because anyone grepping the
-# cleanup step read a line saying both were handled.
-#
-# "mark both abandoned" was never possible. B is SHIPPED by step 6, and the abandon
-# route refuses shipped work (cannot_abandon_shipped) because shipped rows are
-# immutable history. Only A can reach a terminal state here, so the echo now states
-# what the code does instead of the reverse.
-#
-# Follows scripts/bongos/smoke-write.sh's cleanup (task 1002018): abandon is the right
-# terminal state for a smoke row, and cleanup is STRICTLY best-effort. task.abandon is
-# floor-metic (ADR 0152), so a Xenos/Thetes token gets a 403 here while every assertion
-# above genuinely passed — a cleanup that cannot run must never turn a passing smoke
-# into a failing one. Hence the `|| true` and the reported-not-raised status codes.
-# Reaching this line at all means every assertion passed: the script is `set -e` and
-# each check above exits non-zero on failure, so a FAILED run stops earlier and leaves
-# both rows in place for inspection, which is the same deliberate choice smoke-write makes.
-node scripts/bongos/release.js "$A_ID" --reason "smoke cleanup" || true
-
-A_CLEANUP_CODE=$(curl -sS -o /dev/null -w '%{http_code}' -X POST \
-  -H "Authorization: Bearer $TOKEN" -H "Content-Type: application/json" \
-  --data '{"reason":"smoke cleanup (task 1004026) - dependency smoke passed; the throwaway row has served its purpose"}' \
-  "$BASE/api/bongos/tasks/$A_ID/abandon") || true
-case "${A_CLEANUP_CODE:-000}" in
-  2*)  echo "  PASS cleaned up throwaway task #$A_ID (abandoned)" ;;
-  403) echo "  SKIP cleanup — task.abandon needs Metic+ (ADR 0152); task #$A_ID left in the ledger" ;;
-  000) echo "  SKIP cleanup — POST /tasks/$A_ID/abandon got no response; task #$A_ID left in the ledger" ;;
-  *)   echo "  SKIP cleanup — POST /tasks/$A_ID/abandon returned HTTP $A_CLEANUP_CODE; task #$A_ID left in the ledger" ;;
-esac
-C_CLEANUP_CODE=$(curl -sS -o /dev/null -w '%{http_code}' -X POST \
-  -H "Authorization: Bearer $TOKEN" -H "Content-Type: application/json" \
-  --data '{"reason":"smoke cleanup (task 1004191) - auto-promotion witness; the throwaway row has served its purpose"}' \
-  "$BASE/api/bongos/tasks/$C_ID/abandon") || true
-case "${C_CLEANUP_CODE:-000}" in
-  2*) echo "  PASS cleaned up throwaway task #$C_ID (abandoned)" ;;
-  *)  echo "  SKIP cleanup — POST /tasks/$C_ID/abandon returned HTTP ${C_CLEANUP_CODE:-000}; task #$C_ID left in the ledger" ;;
-esac
-echo "  NOTE task #$B_ID is SHIPPED and is deliberately left in the ledger — the abandon route refuses shipped work (cannot_abandon_shipped)."
-
-echo
-echo "ALL SMOKE STEPS PASSED."

package/scripts/gds/backfill-disciplines.js

@@ -1,7 +0,0 @@
-#!/usr/bin/env node
-// scripts/gds/backfill-disciplines.js — @bongos-forwarder (task 1004848). Generated by
-// scripts/bongos/codemod-rename-scripts-gds.js; do not edit.
-// The real script is scripts/bongos/backfill-disciplines.js. This forwarder keeps callers that still name
-// the old path working, and warns once so they get repointed. Task 1003706 removes it.
-'use strict';
-require('../bongos/forwarder.js').forward(module, 'backfill-disciplines.js');

package/scripts/gds/backfill-session-earnings.js

@@ -1,7 +0,0 @@
-#!/usr/bin/env node
-// scripts/gds/backfill-session-earnings.js — @bongos-forwarder (task 1004848). Generated by
-// scripts/bongos/codemod-rename-scripts-gds.js; do not edit.
-// The real script is scripts/bongos/backfill-session-earnings.js. This forwarder keeps callers that still name
-// the old path working, and warns once so they get repointed. Task 1003706 removes it.
-'use strict';
-require('../bongos/forwarder.js').forward(module, 'backfill-session-earnings.js');

package/scripts/gds/backfill-session-types.js

@@ -1,7 +0,0 @@
-#!/usr/bin/env node
-// scripts/gds/backfill-session-types.js — @bongos-forwarder (task 1004848). Generated by
-// scripts/bongos/codemod-rename-scripts-gds.js; do not edit.
-// The real script is scripts/bongos/backfill-session-types.js. This forwarder keeps callers that still name
-// the old path working, and warns once so they get repointed. Task 1003706 removes it.
-'use strict';
-require('../bongos/forwarder.js').forward(module, 'backfill-session-types.js');

package/scripts/gds/cleanup-orphans.js

@@ -1,7 +0,0 @@
-#!/usr/bin/env node
-// scripts/gds/cleanup-orphans.js — @bongos-forwarder (task 1004848). Generated by
-// scripts/bongos/codemod-rename-scripts-gds.js; do not edit.
-// The real script is scripts/bongos/cleanup-orphans.js. This forwarder keeps callers that still name
-// the old path working, and warns once so they get repointed. Task 1003706 removes it.
-'use strict';
-require('../bongos/forwarder.js').forward(module, 'cleanup-orphans.js');

package/scripts/gds/seed-bongos-v1-idea-routing-tasks.js

@@ -1,6 +0,0 @@
-// scripts/gds/seed-bongos-v1-idea-routing-tasks.js — @bongos-forwarder (task 1004848). Generated by
-// scripts/bongos/codemod-rename-scripts-gds.js; do not edit.
-// The real script is scripts/bongos/seed-bongos-v1-idea-routing-tasks.js. This forwarder keeps callers that still name
-// the old path working, and warns once so they get repointed. Task 1003706 removes it.
-'use strict';
-require('../bongos/forwarder.js').forward(module, 'seed-bongos-v1-idea-routing-tasks.js');

package/scripts/gds/seed-bv1-profiles-tasks.js

@@ -1,6 +0,0 @@
-// scripts/gds/seed-bv1-profiles-tasks.js — @bongos-forwarder (task 1004848). Generated by
-// scripts/bongos/codemod-rename-scripts-gds.js; do not edit.
-// The real script is scripts/bongos/seed-bv1-profiles-tasks.js. This forwarder keeps callers that still name
-// the old path working, and warns once so they get repointed. Task 1003706 removes it.
-'use strict';
-require('../bongos/forwarder.js').forward(module, 'seed-bv1-profiles-tasks.js');

package/scripts/gds/seed-bv2-ideator-surface-tasks.js

@@ -1,6 +0,0 @@
-// scripts/gds/seed-bv2-ideator-surface-tasks.js — @bongos-forwarder (task 1004848). Generated by
-// scripts/bongos/codemod-rename-scripts-gds.js; do not edit.
-// The real script is scripts/bongos/seed-bv2-ideator-surface-tasks.js. This forwarder keeps callers that still name
-// the old path working, and warns once so they get repointed. Task 1003706 removes it.
-'use strict';
-require('../bongos/forwarder.js').forward(module, 'seed-bv2-ideator-surface-tasks.js');

package/scripts/gds/smoke-batch-claim.sh

@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-# scripts/gds/smoke-batch-claim.sh — @bongos-forwarder (task 1004848). Generated by
-# scripts/bongos/codemod-rename-scripts-gds.js; do not edit.
-# The real script is scripts/bongos/smoke-batch-claim.sh. This forwarder keeps callers that still name
-# the old path working, and warns once so they get repointed. Task 1003706 removes it.
-if [ -z "${BONGOS_FORWARDER_WARNED:-}" ]; then echo "[bongos] scripts/gds/smoke-batch-claim.sh has moved to scripts/bongos/smoke-batch-claim.sh. This old path still works for now, but update whatever called it. The forwarders in scripts/gds/ are removed in a later release." >&2; fi
-export BONGOS_FORWARDER_WARNED=1
-exec bash "$(dirname "$0")/../bongos/smoke-batch-claim.sh" "$@"

package/scripts/gds/smoke-batch-release.sh

@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-# scripts/gds/smoke-batch-release.sh — @bongos-forwarder (task 1004848). Generated by
-# scripts/bongos/codemod-rename-scripts-gds.js; do not edit.
-# The real script is scripts/bongos/smoke-batch-release.sh. This forwarder keeps callers that still name
-# the old path working, and warns once so they get repointed. Task 1003706 removes it.
-if [ -z "${BONGOS_FORWARDER_WARNED:-}" ]; then echo "[bongos] scripts/gds/smoke-batch-release.sh has moved to scripts/bongos/smoke-batch-release.sh. This old path still works for now, but update whatever called it. The forwarders in scripts/gds/ are removed in a later release." >&2; fi
-export BONGOS_FORWARDER_WARNED=1
-exec bash "$(dirname "$0")/../bongos/smoke-batch-release.sh" "$@"

package/scripts/gds/smoke-claim-consistency.sh

@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-# scripts/gds/smoke-claim-consistency.sh — @bongos-forwarder (task 1004848). Generated by
-# scripts/bongos/codemod-rename-scripts-gds.js; do not edit.
-# The real script is scripts/bongos/smoke-claim-consistency.sh. This forwarder keeps callers that still name
-# the old path working, and warns once so they get repointed. Task 1003706 removes it.
-if [ -z "${BONGOS_FORWARDER_WARNED:-}" ]; then echo "[bongos] scripts/gds/smoke-claim-consistency.sh has moved to scripts/bongos/smoke-claim-consistency.sh. This old path still works for now, but update whatever called it. The forwarders in scripts/gds/ are removed in a later release." >&2; fi
-export BONGOS_FORWARDER_WARNED=1
-exec bash "$(dirname "$0")/../bongos/smoke-claim-consistency.sh" "$@"

package/scripts/gds/smoke-dependencies.sh

@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-# scripts/gds/smoke-dependencies.sh — @bongos-forwarder (task 1004848). Generated by
-# scripts/bongos/codemod-rename-scripts-gds.js; do not edit.
-# The real script is scripts/bongos/smoke-dependencies.sh. This forwarder keeps callers that still name
-# the old path working, and warns once so they get repointed. Task 1003706 removes it.
-if [ -z "${BONGOS_FORWARDER_WARNED:-}" ]; then echo "[bongos] scripts/gds/smoke-dependencies.sh has moved to scripts/bongos/smoke-dependencies.sh. This old path still works for now, but update whatever called it. The forwarders in scripts/gds/ are removed in a later release." >&2; fi
-export BONGOS_FORWARDER_WARNED=1
-exec bash "$(dirname "$0")/../bongos/smoke-dependencies.sh" "$@"

package/tests/smoke_dependencies_witness.mjs

@@ -1,46 +0,0 @@
-// tests/smoke_dependencies_witness.mjs
-//
-// task 1004191 (finding 62 of the task 1000379 audit): scripts/bongos/smoke-dependencies.sh
-// is the only round-trip for the auto-promotion trigger, and its status check used
-// to assert on task A — which the script itself promotes BY HAND in an earlier
-// step. "A is ready after B ships" therefore passed with the trigger broken.
-//
-// The fix adds C: a dependent of B that nothing ever promotes by hand, checked to
-// be 'backlog' before B ships and 'ready' after. This pins that shape statically
-// (the smoke itself writes live tasks, so CI cannot run it).
-//
-// Run:  node tests/smoke_dependencies_witness.mjs
-
-import { strict as assert } from 'node:assert';
-import { readFileSync } from 'node:fs';
-import { makeRunner } from './helpers.mjs';
-
-const { test, summary } = makeRunner();
-const src = readFileSync(new URL('../scripts/bongos/smoke-dependencies.sh', import.meta.url), 'utf8');
-const code = src.split('\n').filter((l) => !/^\s*#/.test(l)).join('\n');
-
-await test('a second dependent C is created at backlog and wired to B', () => {
-  assert.match(code, /__smoke__ dep-test C [^"]*\\",\\"description\\":\\"smoke\\",\\"status\\":\\"backlog\\"/);
-  assert.match(code, /tasks\/\$C_ID\/dependencies"[\s\S]*depends_on_task_id\\": \$B_ID/);
-});
-
-await test('C is never promoted by hand', () => {
-  assert.doesNotMatch(code, /tasks\/\$C_ID\/promote/);
-});
-
-await test('C is asserted backlog BEFORE B ships and ready AFTER', () => {
-  const pre = code.indexOf('[ "$C_PRE" = "backlog" ]');
-  const ship = code.indexOf('tasks/$B_ID/ship');
-  const post = code.indexOf('[ "$C_STATUS" = "ready" ]');
-  assert.ok(pre >= 0 && ship > pre && post > ship, 'pre-check, ship, post-check in that order');
-});
-
-await test('the post-ship status assertion is not made on the hand-promoted A', () => {
-  assert.doesNotMatch(code, /\[ "\$A_STATUS" = "ready" \]/);
-});
-
-await test('C is cleaned up (abandoned) like A', () => {
-  assert.match(code, /tasks\/\$C_ID\/abandon/);
-});
-
-summary();