@bongos/core 1.23.17 → 1.23.19

package/tests/privacy_matrix.mjs

@@ -154,7 +154,11 @@ function identitySentinels(acct) {
 //                the past weeks (task 1002981, spec D5): a row IS stats, so the board's rule.
 //                Every fixture account has won a recorded week, so the read's own predicate
 //                decides: 'listed' | 'absent'
-//   directory  GET /scouting                Recruiter — 'full' | 'name-only' | 'absent'
+//   crowns     GET /community/crowns        Anon · Builder · Recruiter — the builders of the month,
+//                the year so far and last year (task 1004902): a crown IS stats, so the board's
+//                rule. Each account in turn is made the winner of all three, so the reads'
+//                own predicates decide: 'listed' | 'absent'
+//   directory  GET /scouting               Recruiter — 'full' | 'name-only' | 'absent'
 //   sliver     GET /scouting/:handle        Recruiter — 'full' (D3) | 'name-only' (D3, hidden) | 404
 //   self       GET /me/cross-project        Self — 'own' (own numbers, any flags) | 'n/a' (no session exists)
 //   guild      GET /guilds/:slug            Anon · Builder · Recruiter · Self — the guild page's PUBLIC
@@ -170,13 +174,13 @@ function identitySentinels(acct) {
 //                people the guild page already shows them — shown_publicly AND existence;
 //                hide_stats never hides membership, and private or provisional is never listed
 const MATRIX = {
-  PROV: { profile: 404, search: 'absent', board: 'absent', week: 'absent', directory: 'absent', sliver: 404, self: 'n/a', guild: 'absent', members: 'absent', invite: 'absent' },
-  PUB: { profile: 'full', search: 'listed', board: 'listed', week: 'listed', directory: 'full', sliver: 'full', self: 'own', guild: 'listed', members: 'listed', invite: 'listed' },
-  SHY: { profile: 'identity', search: 'name-only', board: 'absent', week: 'absent', directory: 'name-only', sliver: 'name-only', self: 'own', guild: 'listed', members: 'listed', invite: 'listed' },
-  PRIV: { profile: 404, search: 'absent', board: 'absent', week: 'absent', directory: 'absent', sliver: 404, self: 'own', guild: 'absent', members: 'listed', invite: 'absent' },
-  PRIVD: { profile: 404, search: 'absent', board: 'absent', week: 'absent', directory: 'absent', sliver: 'full', self: 'own', guild: 'absent', members: 'listed', invite: 'absent' },
-  PRIVDH: { profile: 404, search: 'absent', board: 'absent', week: 'absent', directory: 'absent', sliver: 'name-only', self: 'own', guild: 'absent', members: 'listed', invite: 'absent' },
-  OPTOUT: { profile: 'full', search: 'listed', board: 'listed', week: 'listed', directory: 'absent', sliver: 404, self: 'own', guild: 'listed', members: 'listed', invite: 'listed' },
+  PROV: { profile: 404, search: 'absent', board: 'absent', week: 'absent', crowns: 'absent', directory: 'absent', sliver: 404, self: 'n/a', guild: 'absent', members: 'absent', invite: 'absent' },
+  PUB: { profile: 'full', search: 'listed', board: 'listed', week: 'listed', crowns: 'listed', directory: 'full', sliver: 'full', self: 'own', guild: 'listed', members: 'listed', invite: 'listed' },
+  SHY: { profile: 'identity', search: 'name-only', board: 'absent', week: 'absent', crowns: 'absent', directory: 'name-only', sliver: 'name-only', self: 'own', guild: 'listed', members: 'listed', invite: 'listed' },
+  PRIV: { profile: 404, search: 'absent', board: 'absent', week: 'absent', crowns: 'absent', directory: 'absent', sliver: 404, self: 'own', guild: 'absent', members: 'listed', invite: 'absent' },
+  PRIVD: { profile: 404, search: 'absent', board: 'absent', week: 'absent', crowns: 'absent', directory: 'absent', sliver: 'full', self: 'own', guild: 'absent', members: 'listed', invite: 'absent' },
+  PRIVDH: { profile: 404, search: 'absent', board: 'absent', week: 'absent', crowns: 'absent', directory: 'absent', sliver: 'name-only', self: 'own', guild: 'absent', members: 'listed', invite: 'absent' },
+  OPTOUT: { profile: 'full', search: 'listed', board: 'listed', week: 'listed', crowns: 'listed', directory: 'absent', sliver: 404, self: 'own', guild: 'listed', members: 'listed', invite: 'listed' },
 };
 
 // ===========================================================================
@@ -296,6 +300,9 @@ function weekOf(key) {
   }
   return weeksWon[key];
 }
+// THE ACCOUNT that won the month, the year so far and last year (task 1004902); the
+// crowns test makes each fixture account the winner in turn.
+let CROWNED = 'PUB';
 
 const pool = {
   query: async (text, params = []) => {
@@ -370,6 +377,39 @@ const pool = {
       return { rows, rowCount: rows.length };
     }
 
+    // THE CROWNS (task 1004902): history began long ago, every month and year is already
+    // recorded, and CROWNED names the account that won all three — so each read's own
+    // predicate decides who is shown. The projections are pinned: a new column is a new
+    // disclosure.
+    if (/^SELECT reported_at FROM platform_identity_activity_snapshots ORDER BY id ASC LIMIT 1$/.test(sql)) return { rows: [{ reported_at: '2020-01-01T00:00:00.000Z' }], rowCount: 1 };
+    if (/^SELECT 1 FROM platform_identity_period_features WHERE /.test(sql)) return { rows: [{ '?column?': 1 }], rowCount: 1 };
+    if (/FROM platform_identity_period_features f JOIN platform_identity_accounts pa/.test(sql)) {
+      const cols = (/^SELECT (.+?) FROM /.exec(sql) || [, ''])[1];
+      if (cols !== 'f.credits_delta, f.ships_delta, pa.handle, pa.github_login, pa.display_name, pa.avatar_url') throw new Error(`fake pool: the crowned-period read selects something new — ${cols}`);
+      const where = lift(sql, /AND f\.period_start = \$2::date AND (.+)$/, 'crowned period');
+      const rows = ACCOUNTS.filter((a) => a.key === CROWNED).filter(accountFilter(where, [])).map((a) => ({
+        credits_delta: String(ROLLUP[a.github_id].credits), ships_delta: String(ROLLUP[a.github_id].works_shipped),
+        handle: a.handle, github_login: a.github_login, display_name: a.display_name, avatar_url: a.avatar_url,
+      }));
+      return { rows, rowCount: rows.length };
+    }
+    // ... the year so far: computeWinner's act CTE carries the floor, then the leader's re-read
+    if (/^WITH act AS/.test(sql) && /\) f ON true/.test(sql)) {
+      const where = lift(sql, /JOIN platform_identity_accounts pa ON pa\.github_id = a\.github_id WHERE (.+?) \), per_project AS/, 'year so far');
+      const rows = ACCOUNTS.filter((a) => a.key === CROWNED).filter(accountFilter(where, [])).map((a) => ({
+        github_id: a.github_id, credits: String(ROLLUP[a.github_id].credits), tasks_shipped: String(ROLLUP[a.github_id].works_shipped),
+      }));
+      return { rows, rowCount: rows.length };
+    }
+    if (/FROM platform_identity_accounts pa WHERE pa\.github_id = \$1::bigint AND /.test(sql)) {
+      const cols = (/^SELECT (.+?) FROM /.exec(sql) || [, ''])[1];
+      if (cols !== 'pa.handle, pa.github_login, pa.display_name, pa.avatar_url') throw new Error(`fake pool: the year leader read selects something new — ${cols}`);
+      const where = lift(sql, /WHERE pa\.github_id = \$1::bigint AND (.+)$/, 'year leader');
+      const rows = ACCOUNTS.filter((a) => a.github_id === String(params[0])).filter(accountFilter(where, []))
+        .map((a) => ({ handle: a.handle, github_login: a.github_login, display_name: a.display_name, avatar_url: a.avatar_url }));
+      return { rows, rowCount: rows.length };
+    }
+
     // THE LEADERBOARD's totals: the rollup floor sits on the act CTE's join.
     if (/platform_identity_activity_snapshots/.test(sql)) {
       const where = lift(sql, /JOIN platform_identity_accounts pa ON pa\.github_id = a\.github_id WHERE (.+?) \), per_project AS/, 'leaderboard totals');
@@ -809,6 +849,25 @@ test('the builder of the week — only shown, public, active winners, on the cro
   assert.doesNotMatch(seen[0].text, /github_id/, 'github_id never crosses');
 });
 
+test('the crowns — the month, the year so far and last year only for shown, public, active winners, the same for every viewer', async () => {
+  const { clearCrownsMemo } = require('../modules/platform-identity/community-crowns.js');
+  try {
+    for (const k of KEYS) {
+      CROWNED = k;
+      clearCrownsMemo(); // the year's leader is memoised: a new winner is a new computation
+      const seen = [];
+      for (const who of [ANON, STRANGER, RECRUITER]) seen.push(await get(who, '/api/bongos/community/crowns'));
+      for (const r of seen.slice(1)) assert.equal(r.text, seen[0].text, `${r.who} got different crowns with ${k} crowned`);
+      const { month, year } = seen[0].json;
+      const shown = { month: month.winner, year: year.winner, last: year.last && year.last.winner };
+      for (const [which, w] of Object.entries(shown)) {
+        assert.equal(!!w && w.handle === ACCT[k].handle, MATRIX[k].crowns === 'listed', `${k} as ${which}: expected ${MATRIX[k].crowns}`);
+      }
+      assert.doesNotMatch(seen[0].text, /github_id/, 'github_id never crosses');
+    }
+  } finally { CROWNED = 'PUB'; }
+});
+
 test('the recruiting directory — the recruiter sees the full and name-only tiers; Anon and Builder are refused', async () => {
   const r = await get(RECRUITER, '/api/bongos/scouting');
   assert.equal(r.status, 200);
@@ -851,7 +910,7 @@ function disclosed(r) {
 }
 
 test('the walk covered every surface for every row (so the claims below are about something)', () => {
-  for (const p of ['/profiles/', '/me/cross-project', '/community/search', '/community/leaderboard', '/community/builder-of-the-week', '/scouting', '/guilds/mx-guild', '/guilds/mx-guild/members', '/projects/invite-guild']) {
+  for (const p of ['/profiles/', '/me/cross-project', '/community/search', '/community/leaderboard', '/community/builder-of-the-week', '/community/crowns', '/scouting', '/guilds/mx-guild', '/guilds/mx-guild/members', '/projects/invite-guild']) {
     assert.ok(SEEN.some((r) => r.path.includes(p) && r.status === 200), `no 200 from ${p} — the sweep below would be vacuous for it`);
   }
   assert.ok(SEEN.length >= KEYS.length * 6, `only ${SEEN.length} responses recorded`);