@bongos/core 1.23.16 → 1.23.17

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/bongos/package-core.js",
-  "core_version": "1.23.16",
-  "core_contract": "1.23.16",
-  "source_commit": "6e661df1836bf2b9f9e4574d98a7fc05b05fb98a",
+  "core_version": "1.23.17",
+  "core_contract": "1.23.17",
+  "source_commit": "4a502e79527cf82113e88b2023d3008dfbae984f",
   "source_ref": "HEAD",
-  "built_at": "2026-10-28T00:12:52.362Z",
+  "built_at": "2026-10-28T00:35:19.416Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 616,
     "agent_docs_stubbed": 29,
-    "functional_verbatim": 3584,
+    "functional_verbatim": 3587,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 4230,
-  "tree_sha256": "7ebfe9f3a223ab157c483e0e2bf97c093ff0225711fdbc542c9a572075287574",
+  "file_count": 4233,
+  "tree_sha256": "99139b31ab3e5e0d6fb9464e6ad1295547d3b7dad361ee272235333df79fc8a2",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2937,7 +2937,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "31d8127f92c9fc127bf1ba774ad14e116e66ad5b9a7ef2625721fb9f675d5841"
+      "sha256": "4bc6873970f7d2632aea896316a31aaef5a2cc6fd51cfa69f1609974b999cb67"
     },
     {
       "path": "docs/modules-contract.md",
@@ -4484,6 +4484,11 @@
       "mode": "0000644",
       "sha256": "6bf4b2a9b9468ca6a5d077a5e01584c66e2ba3a82af3039ee7b9d4be7bc4dbde"
     },
+    {
+      "path": "modules/copy-desk/auto-close.js",
+      "mode": "0000644",
+      "sha256": "e27d2856bdc6e61116e486c053a353bde07c36ac5d850dce278e5d3c1e4135d0"
+    },
     {
       "path": "modules/copy-desk/docx.js",
       "mode": "0000644",
@@ -4517,7 +4522,7 @@
     {
       "path": "modules/copy-desk/module.json",
       "mode": "0000644",
-      "sha256": "0d98abbe640a1fa9326d29ebc44678b0d05e87d6455548f64bcd80c51ea747d1"
+      "sha256": "e5885c9524764cd3e5a1cafc5d352b47e8b1773509854f53c989570c3d02be5d"
     },
     {
       "path": "modules/copy-desk/page-data.js",
@@ -4539,6 +4544,11 @@
       "mode": "0000644",
       "sha256": "595946a1ef88b65612779de0f3dafa0b44b2a02e2b3652f0e026863a9ef4d60c"
     },
+    {
+      "path": "modules/copy-desk/pollers/auto-close-rounds.js",
+      "mode": "0000644",
+      "sha256": "1f370c827350735270704e0e1c7bd5c4427449709c071e3917b1251acfc8dc52"
+    },
     {
       "path": "modules/copy-desk/pollers/stuck-page-digest.js",
       "mode": "0000644",
@@ -4592,7 +4602,12 @@
     {
       "path": "modules/copy-desk/tests/copy_no_cms.mjs",
       "mode": "0000644",
-      "sha256": "7d03e68af010a2c2dd8dead6157c3e80643d0ef5956b45359eb1461d224a59e4"
+      "sha256": "3c5401ec7fbf0aa8a255f0a20ce4a25e285b5c7b3ceb90b88ba1434a837f17b6"
+    },
+    {
+      "path": "modules/copy-desk/tests/copy_page_auto_close.mjs",
+      "mode": "0000644",
+      "sha256": "ec7b6b3ec7f974f79abe5ffdcfb08668ec11477599b021303335374b3e7c59ec"
     },
     {
       "path": "modules/copy-desk/tests/copy_page_draft.mjs",
@@ -10942,12 +10957,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "9812601e19d98dc57f1c6327750d37d3f1ba5e9a2e77fcc7aa5efcafeb0c1889"
+      "sha256": "22b8b7bf76a70bbd3bbb57ed0ab3f53657cf2a989eb6acc8578022311932e5c1"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "8c6f24f0e4d27bb040f8ca7a1a5f8a438638bb94632870110aa18f82662ca9a2"
+      "sha256": "a9218f9cc690dc0c929a5fe7b6a4fccb6a0103f08c1637d09be5c2d23b96b035"
     },
     {
       "path": "public-docs/index.html",
@@ -10967,7 +10982,7 @@
     {
       "path": "release-notes.json",
       "mode": "0000644",
-      "sha256": "46ad6e108a8bdf1681a0a79efacf6c5bbe83adbe06bfb6bf554d8bfedf8dffc4"
+      "sha256": "d1193b47af93db407c4fe4ec5a227fdd5c97bd8ebeaa5d1f2c9b0a4c0fab32ca"
     },
     {
       "path": "scripts/bongos/CLAUDE.md",
@@ -14842,7 +14857,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "84676e50d010ed084fe27550fc614a050d3d794b2bacadfaed0b6cd9b87b9140"
+      "sha256": "e28e39ed8813e02cf4f2689fdf369d45ea3631a6fb6f2994cfaa0089eb4898c1"
     },
     {
       "path": "src/module-loader/catalog.js",

package/docs/module-api-changelog.md

@@ -3247,5 +3247,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.23.14 with no explicit bump. run 40604630697. (task 1002620)
   1.23.16 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.23.15 with no explicit bump. run 40607196561. (task 1002620)
+  1.23.17 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.23.16 with no explicit bump. run 40609586769. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/copy-desk/auto-close.js

@@ -0,0 +1,67 @@
+'use strict';
+
+// auto-close.js — a page round with nothing in it closes itself (task 1004899).
+//
+// WHY. A round only moves when a person or a runner acts on it, so a round that
+// holds nothing to act on sat in the Studio as "Needs a look" (or "Submitted,
+// waiting to be applied") forever: someone had to notice it and abandon it by
+// hand. Two shapes hold nothing:
+//
+//   blank             `ready`, no draft and no frozen batch: opened in the
+//                     studio, nothing written, the claim dropped.
+//   nothing_to_apply  `ready` with a frozen batch whose `lines` is empty: every
+//                     rewrite left the batch for an engineer task at submit
+//                     (unplaced, shared or removed lines), so /tweak has no line
+//                     to apply and the round can never move on its own.
+//
+// Both are abandoned through the lifecycle port's releaseStuckTweak (no compose,
+// so the note is the reason and nothing is written to the description). The
+// engineer tasks a submit filed are untouched: they carry the artist's words.
+//
+// `closeReason` is pure; `runAutoClose` is the I/O the poller calls. A round
+// someone holds, or one touched within GRACE_MS, is never closed: an artist who
+// just released a draft to come back to it in a minute keeps it.
+
+const api = require('../../src/module-api');
+const pages = require('./pages');
+
+const GRACE_MS = Number(process.env.COPY_AUTO_CLOSE_GRACE_MS) || 60 * 60_000;
+
+const NOTES = Object.freeze({
+  blank: 'Closed by itself: the round was opened but nothing was written in it.',
+  nothing_to_apply: 'Closed by itself: every rewritten line went to an engineer task, so nothing was left to apply on the page.',
+});
+
+function closeReason(task, { now = Date.now(), graceMs = GRACE_MS } = {}) {
+  if (!task || task.status !== 'ready' || task.holder_id != null) return null;
+  const touched = Date.parse(task.updated_at || task.created_at || '');
+  if (!Number.isFinite(touched) || now - touched < graceMs) return null;
+  const p = pages.blockPresence(task.description);
+  if (!p.batch) return p.draft ? null : 'blank';
+  const b = pages.parseBatchBlock(task.description);
+  if (b.ok && b.batch.lines.length === 0) return 'nothing_to_apply';
+  return null;
+}
+
+// One sweep. Returns what happened per round, so the poller and the tests read
+// the same outcome. The actor is the project owner (a system act, recorded on
+// the task as its abandon reason); no owner, no sweep.
+async function runAutoClose({ now = Date.now(), resolve = (k) => (api.resolveOptional ? api.resolveOptional(k) : null), founder = () => api.getFoundingBuilder() } = {}) {
+  const lifecycle = resolve('lifecycle');
+  if (!lifecycle || typeof lifecycle.listPageTweakTasks !== 'function' || typeof lifecycle.releaseStuckTweak !== 'function') {
+    return { closed: [], skipped: 'no_lifecycle' };
+  }
+  const tasks = await lifecycle.listPageTweakTasks();
+  const due = tasks.map((t) => ({ t, why: closeReason(t, { now }) })).filter((x) => x.why);
+  if (!due.length) return { closed: [] };
+  const owner = await founder();
+  if (!owner) return { closed: [], skipped: 'no_owner' };
+  const closed = [];
+  for (const { t, why } of due) {
+    const r = await lifecycle.releaseStuckTweak({ taskId: t.id, builderId: owner.id, expectedStatus: 'ready', note: NOTES[why] });
+    closed.push({ task_id: String(t.id), why, outcome: r.outcome });
+  }
+  return { closed };
+}
+
+module.exports = { closeReason, runAutoClose };

package/modules/copy-desk/module.json

@@ -7,7 +7,7 @@
   "category": { "parent": "quality" },
   "default": true,
   "maintenance": { "status": "core-maintained" },
-  "contributes": { "routes": ["copy-desk", "copy-desk-artist", "copy-desk-release"], "migrations": true, "skills": ["tweak"], "pollers": ["stuck-page-digest"] },
+  "contributes": { "routes": ["copy-desk", "copy-desk-artist", "copy-desk-release"], "migrations": true, "skills": ["tweak"], "pollers": ["stuck-page-digest", "auto-close-rounds"] },
   "provides": ["copy-desk.artistStats", "copy-desk.stuckPageTweaksFor"],
   "consumes": ["lifecycle"]
 }

package/modules/copy-desk/pollers/auto-close-rounds.js

@@ -0,0 +1,32 @@
+'use strict';
+
+// modules/copy-desk/pollers/auto-close-rounds.js — closes page rounds that hold
+// nothing to act on (task 1004899). Loader-started (contributes.pollers); the
+// rule lives in ../auto-close.js. Every 15 minutes by default
+// (COPY_AUTO_CLOSE_MS); COPY_AUTO_CLOSE_DISABLED=1 turns it off. Best-effort: a
+// failed sweep logs and tries again next interval.
+
+const api = require('../../../src/module-api');
+const autoClose = require('../auto-close');
+
+const log = api.logger('copy-desk');
+const INTERVAL_MS = Number(process.env.COPY_AUTO_CLOSE_MS) || 15 * 60_000;
+let timer = null;
+
+function tick() {
+  autoClose.runAutoClose()
+    .then((r) => { if (r.closed.length) log.info(`[auto-close-rounds] closed ${r.closed.length} empty page round(s)`); })
+    .catch((e) => log.error(e, '[auto-close-rounds] sweep failed'));
+}
+
+module.exports = {
+  start() {
+    if (process.env.COPY_AUTO_CLOSE_DISABLED === '1' || timer) return;
+    timer = setInterval(tick, INTERVAL_MS);
+    if (timer.unref) timer.unref();
+  },
+  stop() {
+    if (timer) clearInterval(timer);
+    timer = null;
+  },
+};

package/modules/copy-desk/tests/copy_no_cms.mjs

@@ -70,7 +70,7 @@ const stripComments = (src) => src
 // Task 1004435 added routes/copy-desk-artist.js (one artist's approved pages, a
 // read) and artist-stats.js's readArtistPages under it.
 const ROUTE_FILES = fs.readdirSync(path.join(MODULE_DIR, 'routes')).filter((f) => f.endsWith('.js')).sort().map((f) => `routes/${f}`);
-const MODULE_FILES = ['registry.js', 'flags.js', 'proposals.js', 'pages.js', 'page-status.js', 'page-data.js', 'docx.js', 'page-decisions.js', 'artist-stats.js', ...ROUTE_FILES];
+const MODULE_FILES = ['registry.js', 'flags.js', 'proposals.js', 'pages.js', 'page-status.js', 'page-data.js', 'docx.js', 'page-decisions.js', 'artist-stats.js', 'auto-close.js', ...ROUTE_FILES];
 
 console.log('copy-desk: NO LIVE CMS');
 
@@ -310,6 +310,10 @@ await test('the module manifest declares no seam another module could write copy
   assert.deepEqual(manifest.provides, ['copy-desk.artistStats', 'copy-desk.stuckPageTweaksFor'], 'a provided port here would be a copy write path for every other module');
   const stuckSrc = stripComments(read('stuck-tweaks.js'));
   assert.equal(/writeFile|\.query\(|UPDATE |INSERT /.test(stuckSrc), false, 'the stuck-tweaks port writes nothing');
+  // task 1004899: the auto-close sweep only ABANDONS an empty round through the
+  // lifecycle port; it never hands a compose, so it cannot write a description.
+  const closeSrc = stripComments(read('auto-close.js'));
+  assert.equal(/writeFile|\.query\(|UPDATE |INSERT |compose/.test(closeSrc), false, 'the auto-close sweep abandons and writes nothing');
   const stats = read('artist-stats.js');
   assert.equal(/\b(pool|query|writeFile|appendFile|INSERT|UPDATE|DELETE)\b/.test(stats.replace(/\/\/.*$/gm, '')), false,
     'the artist-stats port reads through other ports and writes nothing');

package/modules/copy-desk/tests/copy_page_auto_close.mjs

@@ -0,0 +1,92 @@
+// modules/copy-desk/tests/copy_page_auto_close.mjs — a page round with nothing in
+// it closes itself (task 1004899).
+//
+// The done-when: a blank round and a round whose batch has no lines left are
+// abandoned by the sweep; a round with real lines, a draft, a held round, a
+// round waiting for its artist and a freshly touched one are never touched.
+
+import { strict as assert } from 'node:assert';
+import { createRequire } from 'node:module';
+
+const require = createRequire(import.meta.url);
+const pages = require('../pages.js');
+const autoClose = require('../auto-close.js');
+
+let passed = 0;
+let failed = 0;
+async function test(name, fn) {
+  try { await fn(); passed++; console.log(`  ok  ${name}`); }
+  catch (err) { failed++; console.log(`  FAIL ${name}`); console.log(`     ${err.stack || err.message}`); }
+}
+
+const NOW = Date.parse('2026-10-27T12:00:00.000Z');
+const OLD = '2026-10-20T12:00:00.000Z';
+const PAGE = 'builders:collab';
+
+const line = { key: 'L0001', section: 'Top', before: 'Archive', after: 'Past Collabs', placement: 'placed' };
+const draft = pages.composeDraftBlock({ page_id: PAGE, reading_hash: 'h', saved_at: OLD, lines: [line] });
+const batch = (lines) => pages.composeBatchBlock({ page_id: PAGE, reading_hash: 'h', submitted_at: OLD, lines, unplaced_tasks: lines.length ? [] : ['1004692'] });
+
+const round = (over) => ({ id: '1', status: 'ready', description: 'Page tweak round 1.', holder_id: null, updated_at: OLD, created_at: OLD, ...over });
+
+const ROUNDS = {
+  blank: round({ id: '11' }),
+  empty_batch: round({ id: '12', description: `${draft}\n\n${batch([])}` }),
+  real_batch: round({ id: '13', description: `${draft}\n\n${batch([line])}` }),
+  draft_only: round({ id: '14', description: draft }),
+  held: round({ id: '15', status: 'active', holder_id: '7' }),
+  waiting: round({ id: '16', status: 'completed', description: `${draft}\n\n${batch([line])}` }),
+  fresh_blank: round({ id: '17', updated_at: new Date(NOW - 5 * 60_000).toISOString() }),
+  ready_but_held: round({ id: '18', holder_id: '7' }),
+};
+
+console.log('copy-desk: empty page rounds close themselves');
+
+await test('a blank round and an empty batch are the only two that close', () => {
+  const got = Object.fromEntries(Object.entries(ROUNDS).map(([k, t]) => [k, autoClose.closeReason(t, { now: NOW })]));
+  assert.deepEqual(got, {
+    blank: 'blank',
+    empty_batch: 'nothing_to_apply',
+    real_batch: null,
+    draft_only: null,
+    held: null,
+    waiting: null,
+    fresh_blank: null,
+    ready_but_held: null,
+  });
+});
+
+await test('the grace period is honoured: a round touched within it stays', () => {
+  const t = round({ updated_at: new Date(NOW - 59 * 60_000).toISOString() });
+  assert.equal(autoClose.closeReason(t, { now: NOW, graceMs: 60 * 60_000 }), null);
+  assert.equal(autoClose.closeReason(t, { now: NOW, graceMs: 30 * 60_000 }), 'blank');
+});
+
+await test('the sweep abandons through the lifecycle port, as the owner, with a plain note and no rewrite', async () => {
+  const calls = [];
+  const lifecycle = {
+    listPageTweakTasks: async () => Object.values(ROUNDS),
+    releaseStuckTweak: async (args) => { calls.push(args); return { outcome: 'abandoned' }; },
+  };
+  const r = await autoClose.runAutoClose({ now: NOW, resolve: () => lifecycle, founder: async () => ({ id: '1' }) });
+  assert.deepEqual(r.closed.map((c) => [c.task_id, c.why, c.outcome]), [['11', 'blank', 'abandoned'], ['12', 'nothing_to_apply', 'abandoned']]);
+  for (const c of calls) {
+    assert.equal(c.builderId, '1');
+    assert.equal(c.expectedStatus, 'ready');
+    assert.equal('compose' in c, false, 'no compose: the round is abandoned, never rewritten');
+    assert.ok(c.note.length >= pages.MIN_NOTE_CHARS && c.note.length <= pages.MAX_NOTE_CHARS, 'the note fits the release note floor and cap');
+  }
+});
+
+await test('nothing due, no owner read; no owner, no sweep; no lifecycle, no sweep', async () => {
+  let asked = 0;
+  const quiet = { listPageTweakTasks: async () => [ROUNDS.real_batch], releaseStuckTweak: async () => { throw new Error('must not run'); } };
+  assert.deepEqual(await autoClose.runAutoClose({ now: NOW, resolve: () => quiet, founder: async () => { asked++; return { id: '1' }; } }), { closed: [] });
+  assert.equal(asked, 0);
+  const due = { listPageTweakTasks: async () => [ROUNDS.blank], releaseStuckTweak: async () => { throw new Error('must not run'); } };
+  assert.equal((await autoClose.runAutoClose({ now: NOW, resolve: () => due, founder: async () => null })).skipped, 'no_owner');
+  assert.equal((await autoClose.runAutoClose({ now: NOW, resolve: () => null })).skipped, 'no_lifecycle');
+});
+
+console.log(`\n${passed} passed, ${failed} failed`);
+process.exit(failed ? 1 : 0);

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.23.16",
+  "version": "1.23.17",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.23.16",
+      "version": "1.23.17",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.23.16",
+  "version": "1.23.17",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -10485,5 +10485,11 @@
       "id": "1004900",
       "text": "An artist's rewritten page words are now approved in the Studio before anything changes on the page. Only approved words go on to be applied, and words sent back become a draft the artist can change again."
     }
+  ],
+  "1.23.17": [
+    {
+      "id": "1004899",
+      "text": "Page tweak rounds that hold nothing to do now close themselves after an hour, so the Studio no longer shows empty rounds as needing a look forever."
+    }
   ]
 }

package/src/module-api.js

@@ -81,7 +81,7 @@ const { sleep } = require('./sleep');
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.23.16'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.23.17'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');