@bongos/core 1.23.15 → 1.23.17

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.23.15",
+  "version": "1.23.17",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -10479,5 +10479,17 @@
       "id": "1002981",
       "text": "The community pages now have a Builder of the week: each Monday the builder who earned the most in the week before, among those who shipped something, is crowned and kept on record. It has its own page, with the rule spelled o"
     }
+  ],
+  "1.23.16": [
+    {
+      "id": "1004900",
+      "text": "An artist's rewritten page words are now approved in the Studio before anything changes on the page. Only approved words go on to be applied, and words sent back become a draft the artist can change again."
+    }
+  ],
+  "1.23.17": [
+    {
+      "id": "1004899",
+      "text": "Page tweak rounds that hold nothing to do now close themselves after an hour, so the Studio no longer shows empty rounds as needing a look forever."
+    }
   ]
 }

package/src/module-api.js

@@ -81,7 +81,7 @@ const { sleep } = require('./sleep');
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.23.15'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.23.17'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/copy_desk_page_approve.mjs

@@ -288,6 +288,59 @@ try {
     assert.equal(pages.parseSentBackBlocks(task(5002).description).length, 2, 'send-backs append');
   });
 
+  // task 1004900: the WORDS of a submitted batch are reviewed before anything is
+  // applied. Approve puts the round in the /tweak queue; send-back withdraws the
+  // batch so the round is a draft its artist can change.
+  await test('words first: a submitted batch is in the queue as words, not applied, and only an approval sends it to /tweak', async () => {
+    const STUDIO = '/copy-desk/pages/builders:studio';
+    const line = { key: 'L0001', section: 'top', before: 'Welcome home', after: 'Welcome back', placement: 'placed', file: 'x.html', line: 1, string_id: 'abc' };
+    const desc = () => [
+      'Page tweak round 1 for builders:studio.',
+      pages.composeDraftBlock({ page_id: 'builders:studio', reading_hash: 'h', saved_at: '2026-09-23T00:00:00Z', lines: [line] }),
+      pages.composeBatchBlock({ page_id: 'builders:studio', reading_hash: 'h', submitted_at: '2026-09-23T00:00:00Z', lines: [line] }),
+    ].join('\n\n');
+    db.tasks.push({ id: '7001', status: 'ready', title: 'Tweak: Studio', description: desc(), source: 'page-tweak', source_ref: pages.roundSourceRef('builders:studio', 1), touches: [], version_id: 'V9', goal_id: '77' });
+    db.claims.push({ id: String(++db.seq.claim), task_id: '7001', builder_id: ALICE, worktree_name: null, creator_session_id: null, claimed_at: stamp(), released_at: stamp(), outcome: 'partial' });
+
+    assert.equal((await call('GET', STUDIO, ALICE)).body.open_round.state, 'words_review');
+    const q = (await call('GET', '/copy-desk/approvals', BOB)).body;
+    const item = q.queue.find((x) => x.task_id === '7001');
+    assert.ok(item, 'the submitted words are in the queue');
+    assert.equal(item.kind, 'words');
+    assert.equal(item.applied_at, null);
+    assert.deepEqual(item.lines.map((l) => [l.before, l.after]), [['Welcome home', 'Welcome back']]);
+    assert.equal(q.not_applied.some((r) => r.task_id === '7001'), false, 'not listed as approved-and-waiting');
+
+    const dan = await call('POST', `${STUDIO}/approve`, DAN, { task_id: '7001' });
+    assert.equal(errCode(dan.body), 'not_an_artist');
+    const short = await call('POST', `${STUDIO}/send-back`, BOB, { note: 'nope' });
+    assert.equal(errCode(short.body), 'note_too_short');
+
+    const ok = await call('POST', `${STUDIO}/approve`, BOB, { task_id: '7001' });
+    assert.equal(ok.status, 200, JSON.stringify(ok.body));
+    assert.equal(ok.body.outcome, 'words_approved');
+    assert.deepEqual(ok.body.round, { task_id: '7001', state: 'submitted', status: 'ready' });
+    assert.equal(task(7001).status, 'ready', 'nothing applied or landed: the task only gained the approval');
+    assert.deepEqual(pages.parseWordsApprovedBlocks(task(7001).description).map((a) => a.by), [BOB]);
+    assert.equal((await call('GET', STUDIO, ALICE)).body.open_round.state, 'submitted', 'now in the /tweak queue');
+    const after = (await call('GET', '/copy-desk/approvals', BOB)).body;
+    assert.equal(after.queue.some((x) => x.task_id === '7001'), false);
+    assert.equal(after.not_applied.some((r) => r.task_id === '7001'), true, 'listed as approved, waiting to be applied');
+    const twice = await call('POST', `${STUDIO}/approve`, BOB);
+    assert.equal(errCode(twice.body), 'not_waiting', 'an approved batch is not decided again');
+
+    // A second round of words, sent back: the batch goes, the draft stays, the note rests on the task.
+    task(7001).description = desc();
+    const back = await call('POST', `${STUDIO}/send-back`, ALICE, { note: 'I want to say this differently.', task_id: '7001' });
+    assert.equal(back.status, 200, JSON.stringify(back.body));
+    assert.equal(back.body.outcome, 'words_sent_back');
+    assert.equal(pages.parseBatchBlock(task(7001).description).ok, false, 'the batch is withdrawn');
+    assert.equal(pages.parseDraftBlock(task(7001).description).ok, true, 'the draft stays for its writer');
+    assert.deepEqual(pages.parseSentBackBlocks(task(7001).description).map((s) => s.note), ['I want to say this differently.']);
+    assert.equal((await call('GET', STUDIO, ALICE)).body.open_round.state, 'draft', 'a draft again, open for writing');
+    assert.equal(pages.roundOpenForWriting(task(7001)), true);
+  });
+
   await test('an ordinary task and a failed grade are never moved through the port', async () => {
     db.tasks.push({ id: '6001', status: 'completed', title: 'x', description: '', source: 'planning-session', source_ref: 'x', touches: [] });
     db.grades.set('6001', true);

package/tests/copy_desk_page_editor.mjs

@@ -144,10 +144,10 @@ try {
     writeReadings(readingsWith('studio-h1'));
   });
 
-  await test('after submit the round reads submitted and nobody holds it', async () => {
+  await test('after submit the round waits for its words to be reviewed and nobody holds it', async () => {
     assert.equal((await call('POST', `${STUDIO}/submit`, ALICE)).body.outcome, 'submitted');
     const r = await call('GET', `${STUDIO}/draft`, ALICE);
-    assert.equal(r.body.round.state, 'submitted');
+    assert.equal(r.body.round.state, 'words_review', 'task 1004900: reviewed before it is applied');
     assert.equal(r.body.round.held_by_you, false);
     assert.equal(r.body.round.holder, null);
   });

package/tests/copy_desk_page_next.mjs

@@ -154,7 +154,7 @@ try {
     round.status = 'ready';
     round.description += '\n\n' + pages.composeBatchBlock({ page_id: 'status:explore', reading_hash: 'h', submitted_at: 'x', lines: [{ key: 'L0001', section: 'hero', before: 'Explore', after: 'Look around', placement: 'placed', file: 'x', line: 1, string_id: 'a' }] });
     const next = (await getNext(ALICE)).body;
-    assert.deepEqual(next.skipped, [{ page_id: 'status:explore', reason: 'page_in_flight', state: 'submitted' }]);
+    assert.deepEqual(next.skipped, [{ page_id: 'status:explore', reason: 'page_in_flight', state: 'words_review' }]);
     const refused = await call('POST', '/copy-desk/pages/status:explore/claim', ALICE, {});
     assert.equal(errCode(refused.body), 'page_in_flight');
   });

package/tests/copy_desk_page_release.mjs

@@ -104,7 +104,7 @@ try {
     const flight = Object.fromEntries(r.body.in_flight.map((f) => [f.page_id, f]));
     assert.deepEqual([flight['landing:index'].state, flight['landing:index'].stuck, flight['landing:index'].task_id], ['unknown', true, '7001']);
     assert.deepEqual([flight['landing:projects'].state, flight['landing:projects'].stuck], ['unknown', true]);
-    assert.equal(flight['status:explore'].state, 'submitted');
+    assert.equal(flight['status:explore'].state, 'words_review');
     assert.equal(flight['status:explore'].stuck, false);
   });
 

package/tests/copy_desk_page_submit.mjs

@@ -188,7 +188,7 @@ try {
     const r = await call('POST', `${STUDIO}/submit`, ALICE);
     assert.equal(r.status, 200, JSON.stringify(r.body));
     assert.equal(r.body.outcome, 'submitted');
-    assert.deepEqual(r.body.round, { task_id: studioTask().id, state: 'submitted', status: 'ready' });
+    assert.deepEqual(r.body.round, { task_id: studioTask().id, state: 'words_review', status: 'ready' });
     assert.equal(r.body.batch.line_count, 2);
     assert.deepEqual(r.body.next, { path: '/copy-desk/next' });
 
@@ -229,7 +229,7 @@ try {
   await test('the page reads submitted, and nobody can claim it back into writing', async () => {
     const page = await call('GET', STUDIO, BOB);
     assert.equal(page.status, 200);
-    assert.equal(page.body.open_round.state, 'submitted');
+    assert.equal(page.body.open_round.state, 'words_review');
     const claim = await call('POST', `${STUDIO}/claim`, BOB);
     assert.equal(errCode(claim.body), 'page_in_flight');
   });

package/tests/copy_stuck_page_tweaks.mjs

@@ -23,7 +23,8 @@ const ago = (d) => new Date(NOW.getTime() - d * 86400000).toISOString();
 const pg = (id, title = id) => ({ id, surface: id.split(':')[0], title, path: '/', files: [] });
 const PAGES = [pg('landing:index', '{{productName}}: {{tagline}}'), pg('landing:account', 'Account'), pg('builders:studio', 'Studio'), pg('landing:projects', 'Projects')];
 const INVENTORY = { surfaces: [{ id: 'landing' }, { id: 'builders' }], pages: PAGES };
-const batch = (id) => pages.composeBatchBlock({ page_id: id, reading_hash: 'h', submitted_at: ago(9), lines: [] });
+// Approved words (task 1004900): the round waits to be applied.
+const batch = (id) => `${pages.composeBatchBlock({ page_id: id, reading_hash: 'h', submitted_at: ago(9), lines: [] })}\n\n${pages.composeWordsApprovedBlock({ at: ago(9), by: '7' })}`;
 const round = (n, id, extra) => ({ id: String(n), source: 'page-tweak', source_ref: pages.roundSourceRef(id, 1), description: pages.roundTaskBody(pg(id), 1), artist_id: '7', ...extra });
 const ARTIST = '7';
 const TASKS = [
@@ -45,6 +46,14 @@ await test('the composer: only stuck pages, each with where it sits, how long, a
   ]);
 });
 
+await test('submitted words left unreviewed wait on their artist, not the appliers (task 1004900)', () => {
+  const words = round(9, 'landing:projects', { status: 'ready', description: `${pages.roundTaskBody(pg('landing:projects'), 1)}\n\n${pages.composeBatchBlock({ page_id: 'landing:projects', reading_hash: 'h', submitted_at: ago(4), lines: [] })}`, updated_at: ago(4) });
+  const got = status.stuckPageTweaks({ inventory: INVENTORY, tasks: [words], now: NOW });
+  assert.deepEqual(got.map((s) => [s.page_id, s.state, s.waits_on]), [['landing:projects', 'words_review', 'artist']]);
+  assert.deepEqual(status.stuckPageTweaksFor({ builderId: ARTIST, rank: 'xenos', stuck: got }).map((s) => s.page_id), ['landing:projects']);
+  assert.deepEqual(status.stuckPageTweaksFor({ builderId: '99', rank: 'metic', stuck: got }), [], 'an applier is not asked to review words');
+});
+
 await test('Home: the artist sees their own review; a Metic+ builder sees what waits to be applied', () => {
   const forArtist = status.stuckPageTweaksFor({ builderId: ARTIST, rank: 'thetes', stuck: stuck() });
   assert.deepEqual(forArtist.map((s) => s.page_id), ['landing:account']);
@@ -57,7 +66,7 @@ await test('the real needs roster: one Needs-attention line per page, where and
   const r = needs.computeNeeds({ rank: 'archon', ownKeySet: true, stuckPageTweaks: status.stuckPageTweaksFor({ builderId: ARTIST, rank: 'archon', stuck: stuck() }) });
   const lines = r.items.filter((n) => n.id.startsWith('page_tweak_stuck:'));
   assert.deepEqual(lines.map((n) => [n.id, n.title, n.message, n.state, n.action.href]), [
-    ['page_tweak_stuck:landing:index', 'Page tweak stuck: landing:index', 'Submitted, waiting to be applied for 26 days.', 'action_needed', '/studio'],
+    ['page_tweak_stuck:landing:index', 'Page tweak stuck: landing:index', 'Approved, waiting to be applied for 26 days.', 'action_needed', '/studio'],
     ['page_tweak_stuck:landing:account', 'Page tweak stuck: Account', 'Waiting for your review for 5 days.', 'action_needed', '/studio'],
   ]);
 });
@@ -82,7 +91,7 @@ await test('the real digest: page names only, never copy, to the ship channel, a
   assert.equal(posts[0].channel, 'ship_feed');
   assert.equal(posts[0].text, [
     'Page tweaks stuck (2). Open the Studio to move them:',
-    '- landing:index: submitted, waiting to be applied, 26 days',
+    '- landing:index: approved, waiting to be applied, 26 days',
     '- Account: waiting for your review, 5 days',
   ].join('\n'));
   const again = await stuckTweaks.runDigest({ nowMs: NOW.getTime() + 3600_000, state, post, readStuckImpl });

package/tests/hall_approval_queue.mjs

@@ -141,8 +141,8 @@ await test('lib: the artboard\'s words, from the route\'s own shape', () => {
   assert.equal(lib.displayTitle(home), 'Home', 'an apex template title is Home, the artboard\'s own word');
   assert.equal(lib.subLine(home), '· landing · 1 line rewritten, applied · 1 not applied');
   assert.equal(lib.subLine(projects), '· landing · 1 line rewritten, applied');
-  assert.equal(lib.doorDetail(2), '2 pages applied, waiting for you');
-  assert.equal(lib.doorDetail(1), '1 page applied, waiting for you');
+  assert.equal(lib.doorDetail(2), '2 pages waiting for you');
+  assert.equal(lib.doorDetail(1), '1 page waiting for you');
   assert.equal(lib.doorDetail(0), 'nothing waiting for you');
   assert.equal(lib.approvedLine(home, { status_after: 'Text tweaked 3x', next: { page: { title: 'Contact' } } }),
     'Approved. It ships now, and Home reads text tweaked 3x. Next in the queue: Contact.', 'the artboard line, word for word');
@@ -346,22 +346,22 @@ await test('submitted but not applied: listed apart, marked, how long, no verbs,
   const submitted = {
     id: 60, status: 'ready', holder_id: null, artist_id: ME, artist_login: 'me', updated_at: '2026-09-29T08:00:00Z',
     source_ref: pages.roundSourceRef('landing:projects', 2),
-    description: ['Page tweak round 2.', pages.composeBatchBlock({ page_id: 'landing:projects', reading_hash: 'h', submitted_at: '2026-09-29T08:00:00Z', lines: [{ key: 'L0002', section: 'list', before: 'Every project', after: 'All of them', placement: 'placed', file: 'x.html', line: 1, string_id: 'a' }] })].join('\n\n'),
+    description: ['Page tweak round 2.', pages.composeBatchBlock({ page_id: 'landing:projects', reading_hash: 'h', submitted_at: '2026-09-29T08:00:00Z', lines: [{ key: 'L0002', section: 'list', before: 'Every project', after: 'All of them', placement: 'placed', file: 'x.html', line: 1, string_id: 'a' }] }), pages.composeWordsApprovedBlock({ at: '2026-09-29T09:00:00Z', by: ME })].join('\n\n'),
   };
   const tasks = [...TASKS.filter((t) => t.id !== 42), submitted];
   const data = pageStatus.composeApprovals({ inventory: INVENTORY, tasks, builderId: ME, crafts: ['artist'], now: NOW });
   assert.equal(data.count, 1, 'the door counts reviewable rounds only');
   assert.deepEqual(data.queue.map((q) => q.task_id), ['41']);
   assert.deepEqual(data.not_applied.map((r) => [r.page_id, r.task_id, r.state_word, r.waited_days, r.line_count]),
-    [['landing:projects', '60', 'Submitted, waiting to be applied', 21, 1]]);
+    [['landing:projects', '60', 'Approved, waiting to be applied', 21, 1]]);
 
   const b = bootPanel({ answers: { [APPROVALS]: { ok: true, ...data }, [vis(41)]: slotsFor(41) } });
   await b.panel.open(); await settle(); await settle();
-  assert.equal(text(b.q('.aq-pending__h')), 'Submitted, not applied yet (1)');
+  assert.equal(text(b.q('.aq-pending__h')), 'Approved, not applied yet (1)');
   const row = b.q('.aq-pending__row');
   assert.match(text(row), /Projects/);
   assert.match(text(row), /not applied yet/);
-  assert.match(text(row), /Submitted, waiting to be applied · waiting 21 days\. The words are waiting to be applied/);
+  assert.match(text(row), /Approved, waiting to be applied · waiting 21 days\. The words are approved and waiting to be put on the page/);
   assert.equal(row.querySelectorAll('button').length, 0, 'no approve or send-back on a page nobody applied');
   assert.deepEqual(b.counts, [1]);