@bongos/core 1.23.12 → 1.23.14

package/tests/welcome_boot_browser.mjs

@@ -43,6 +43,7 @@ async function hall({ art = true, reducedMotion = 'no-preference', time = null }
   await ctx.route(ORIGIN + '/**', (route) => {
     const p = new URL(route.request().url()).pathname;
     if (p === '/' || p === '/index.html') return route.fulfill({ contentType: 'text/html', body: PAGE });
+    if (p === '/api/bongos/auth/web/start') return route.fulfill({ contentType: 'text/html', body: '<!doctype html><title>github</title><p id="auth">sign in</p>' });
     if (p === '/thinking' || p === '/city') return route.fulfill({ contentType: 'text/html', body: '<!doctype html><title>room</title><p id="room">' + p + '</p>' });
     const ext = path.extname(p);
     if (ext === '.webp' && !art) return route.fulfill({ status: 404, body: '' });
@@ -123,12 +124,53 @@ test('once a day: the next load the same day gets no welcome (and the picker is
   await ctx.close();
 });
 
-test('a visitor who is not signed in is never greeted, and nothing is remembered', { skip }, async () => {
+test('a visitor who is not signed in gets the Welcome on Home with a sign-in button, and no day is remembered', { skip }, async () => {
   const ctx = await hall();
   const { page } = await open(ctx);
   await page.evaluate(() => window.OTBShell.applyAccess({ authed: false }));
-  const s = await page.evaluate(() => ({ welcome: !!document.getElementById('welcome-boot'), keys: Object.keys(localStorage).filter((k) => k.startsWith('hall-welcome-day')) }));
-  assert.deepEqual(s, { welcome: false, keys: [] });
+  await page.waitForSelector('#welcome-boot');
+  const s = await page.evaluate(() => ({
+    hi: document.getElementById('wb-hi').textContent,
+    signin: !!document.querySelector('[data-wb-signin]'),
+    roles: !!document.querySelector('[data-wb-roles]'),
+    keys: Object.keys(localStorage).filter((k) => k.startsWith('hall-welcome-day') || k === 'hall-welcome-signin'),
+    picker: !!document.getElementById('craft-picker'),
+  }));
+  assert.match(s.hi, /^Welcome to /);
+  assert.deepEqual([s.signin, s.roles, s.keys, s.picker], [true, false, [], false]);
+  await ctx.close();
+});
+
+test('every fresh sign-in is welcomed again the same day, whichever sign-in link was clicked', { skip }, async () => {
+  for (const link of ['[data-wb-signin]', '#shell-signin']) {
+    const ctx = await hall();
+    const first = await open(ctx);
+    await signIn(first.page);
+    await first.page.waitForSelector('#welcome-boot');
+    await first.page.close();   // the day is now seen
+    const out = await open(ctx);
+    await out.page.evaluate(() => window.OTBShell.applyAccess({ authed: false }));
+    await out.page.waitForSelector('#welcome-boot');
+    // The welcome's own button, or the shell's top-bar link, leaves the flag and heads for GitHub.
+    await out.page.evaluate((sel) => document.querySelector(sel).click(), link);
+    await out.page.waitForSelector('#auth');
+    const { page } = await open(ctx);
+    await signIn(page);
+    await page.waitForSelector('#welcome-boot');
+    assert.equal(await page.evaluate(() => localStorage.getItem('hall-welcome-signin')), null, link + ': the flag is spent');
+    await ctx.close();
+  }
+});
+
+test('a link that only mentions the sign-in path on another site sets no flag', { skip }, async () => {
+  const ctx = await hall();
+  const { page } = await open(ctx);
+  await page.evaluate(() => {
+    const a = document.createElement('a');
+    a.id = 'far'; a.href = 'https://elsewhere.test/auth/web/start'; a.addEventListener('click', (e) => e.preventDefault());
+    document.body.appendChild(a); a.click();
+  });
+  assert.equal(await page.evaluate(() => localStorage.getItem('hall-welcome-signin')), null);
   await ctx.close();
 });