@bongos/core 1.23.11 → 1.23.12

package/tests/hub_community_page.mjs

@@ -78,6 +78,7 @@ test('no top block: one visually hidden h1, then one section per sub-page, only
   assert.match(MAIN, /<ol class="commRows" id="boardList" data-unit="\{\{currency\}\}" aria-labelledby="boardH"><\/ol>/, 'the unit is the instance’s own word, stamped by the server');
   assert.match(MAIN, /<p class="projMsg err" id="boardFailed" role="alert" hidden><\/p>/);
   assert.match(MAIN, /<form class="mineJoinRow commFind" id="findForm" role="search"/);
+  for (const id of ['boardFor', 'findFor']) assert.match(MAIN, new RegExp(`<div class="commFor" id="${id}" hidden></div>`), `${id}: the Recruit door’s line waits for GET /my-projects (task 1002292)`);
   assert.match(MAIN, /<h2 id="recruitH">Open to recruiters<\/h2>/, 'the hide flag is "hidden", never "private" (ADR 0337)');
   assert.match(MAIN, /<a class="btn" id="recruitSignin" href="\/api\/bongos\/auth\/web\/start\?return=\/community\/recruiters&amp;repos=1">/);
   for (const id of ['recruitDoor', 'recruitClosed', 'recruitFailed', 'recruitEmpty']) assert.match(MAIN, new RegExp(` id="${id}"[^>]*hidden`), `${id} waits for the route’s answer`);
@@ -100,11 +101,12 @@ test('the window dropdown and the query limits are the routes’ own (boundary-f
   assert.match(MAIN, new RegExp(`<input id="findQ" type="search"[^>]* maxlength="${max}"`));
 });
 
-test('the script builds no markup from strings, reads only the three routes, and never re-ranks or reads the ranked tier', () => {
+test('the script builds no markup from strings, reads only the four routes, and never re-ranks or reads the ranked tier', () => {
   assert.doesNotMatch(SCRIPT, /innerHTML|insertAdjacentHTML|outerHTML|document\.write/);
-  // every path literal in the code: the API base, the three reads, the three sub-pages and the sign-in door
+  // every path literal in the code: the API base, the four reads, the three sub-pages, the
+  // sign-in door and the hall's invite box the Recruit door opens (task 1002292)
   const paths = [...new Set([...CODE.matchAll(/'(\/[^'?]*)/g)].map((m) => m[1]))];
-  assert.deepEqual(paths.sort(), ['/api/bongos', '/api/bongos/auth/web/start', '/community', '/community/find', '/community/leaderboard', '/community/recruiters', '/community/search', '/scouting']);
+  assert.deepEqual(paths.sort(), ['/api/bongos', '/api/bongos/auth/web/start', '/builders/watch', '/community', '/community/find', '/community/leaderboard', '/community/recruiters', '/community/search', '/my-projects', '/scouting']);
   assert.doesNotMatch(CODE, /method:/, 'it only reads');
   assert.doesNotMatch(CODE, /'\/me\b/, 'who is signed in is the bar’s question');
   assert.doesNotMatch(CODE, /\.sort\(|\.count\b|_count\b/, 'the server ranks; every count is a list’s length');
@@ -173,7 +175,9 @@ async function boot({ pathname = '/community', me = null, reads = READS() } = {}
     requests.push({ url, credentials: init.credentials });
     const a = reads[url.replace(/^\/api\/bongos/, '')];
     if (!a || a.reject) return Promise.reject(new Error('offline'));
-    return Promise.resolve({ ok: a.status >= 200 && a.status < 300, status: a.status, json: () => Promise.resolve(a.body) });
+    const res = { ok: a.status >= 200 && a.status < 300, status: a.status, json: () => Promise.resolve(a.body) };
+    // `slow`: answers on a timer, after every microtask-settled read (the order a slow network gives)
+    return a.slow ? new Promise((resolve) => setTimeout(() => resolve(res), 5)) : Promise.resolve(res);
   };
   const document = {
     title: 'Cloud Bongos — Community',
@@ -225,7 +229,8 @@ test('the leaderboard, signed out: the all-time board in the server’s order wi
   assert.equal(find(bo, 'mineRow__hint').textContent, '1 work shipped · 0 karma');
   assert.equal(ui.$('boardNote').textContent, 'Credits earned across every project, since each builder started.');
   const signedIn = await boot({ me: { github_login: 'someone' } });
-  assert.deepEqual(signedIn.gets(), ['/api/bongos/community/leaderboard?window=all'], 'signed in, the same one read: viewing is ungated');
+  assert.deepEqual(signedIn.gets(), ['/api/bongos/community/leaderboard?window=all', '/api/bongos/my-projects'], 'signed in, the same board read: viewing is ungated, and the one more read is the Recruit door’s');
+  assert.equal(signedIn.$('boardList').textContent, ui.$('boardList').textContent, 'the same rows for every viewer');
 });
 
 test('the window dropdown and a craft are each one read; the pressed craft follows the pick', async () => {
@@ -320,6 +325,114 @@ test('recruiters: a door signed out, a refusal on a 403, rows only from a 200 as
   assert.equal(failed.$('recruitFailed').textContent, 'This list could not be read. Reload the page to try again.');
 });
 
+// ── 2b. the Recruit door (task 1002292; spec D6, owner 2026-10-27) ───────────
+// A project OWNER gets a Recruit link on each row: the hub cannot read a project's
+// `project.recruit` (ADR 0335 D1), so GET /my-projects' `owned` stands in. The link is the
+// project's own hall invite box with the GitHub login filled in (ADR 0353), and the
+// project decides.
+
+const OWNED = (...ps) => ({ status: 200, body: {
+  owned: ps.map(([client_id, origin, name]) => ({ client_id, name, origin, hall_origin: null, membership_kind: 'owner' })),
+  building: [{ client_id: 'zed', name: 'Zed', origin: 'https://zed.example', hall_origin: null, membership_kind: 'member' }],
+  applied: [],
+} });
+const recruitOf = (row) => find(row, 'commRecruit');
+
+test('recruit: an owner gets a Recruit link on every row but their own, opening their project’s hall invite box with the GitHub login filled in', async () => {
+  const reads = READS();
+  reads['/my-projects'] = OWNED(['mercury', 'https://mercury.example/x?y=1', 'Mercury']);
+  const ui = await boot({ me: { github_login: 'BO' }, reads });
+  assert.deepEqual(ui.gets(), ['/api/bongos/community/leaderboard?window=all', '/api/bongos/my-projects']);
+  const [ana, bo] = kids(ui.$('boardList'));
+  const a = recruitOf(ana);
+  assert.equal(a.tag, 'a');
+  assert.equal(a.textContent, 'Recruit');
+  assert.equal(a.attrs.href, 'https://mercury.example/builders/watch?invite=ana', 'the project’s origin and nothing else of the address');
+  assert.equal(a.attrs.target, '_blank', 'the board stays open behind it');
+  assert.equal(a.attrs.rel, 'noopener');
+  assert.equal(a.attrs['aria-label'], 'Recruit ANA to Mercury (opens in a new tab)', 'the new tab is said, not sprung');
+  assert.equal(recruitOf(bo).tag, 'span', 'your own row: an invisible twin keeps the credits in line');
+  assert.equal(recruitOf(bo).attrs['aria-hidden'], 'true');
+  assert.match(ui.$('boardList').className, /\bcanRecruit\b/);
+  assert.equal(ui.$('boardFor').hidden, false);
+  assert.equal(ui.$('boardFor').textContent, 'Recruit opens Mercury’s hall with their name filled in, and you send the invite there.');
+  await ui.pick('30d');
+  assert.equal(recruitOf(kids(ui.$('boardList'))[0]).attrs.href, 'https://mercury.example/builders/watch?invite=cy', 'a new window’s rows carry it too');
+  reads['/community/leaderboard?window=all'].slow = true;
+  const late = await boot({ me: { github_login: 'BO' }, reads });
+  assert.equal(kids(late.$('boardList')).length, 0, 'the board has not answered yet');
+  assert.equal(late.$('boardFor').hidden, false, 'the owner’s line is up before the board');
+  await new Promise((resolve) => setTimeout(resolve, 20));
+  await settle();
+  assert.equal(recruitOf(kids(late.$('boardList'))[0]).attrs.href, 'https://mercury.example/builders/watch?invite=ana', 'a board that answers after GET /my-projects draws its doors as it paints');
+  delete reads['/community/leaderboard?window=all'].slow;
+  reads['/community/leaderboard?window=all'].body.results[0].github_login = 'a b&c';
+  const odd = await boot({ me: { github_login: 'x' }, reads });
+  assert.equal(recruitOf(kids(odd.$('boardList'))[0]).attrs.href, 'https://mercury.example/builders/watch?invite=a%20b%26c', 'the login is encoded into the query');
+});
+
+test('recruit: none for a builder who owns no project, signed out, on a failed read, or for a project with no web address; the rows stay the same', async () => {
+  const reads = READS();
+  reads['/my-projects'] = OWNED();
+  const member = await boot({ me: { github_login: 'someone' }, reads });
+  assert.equal(member.gets().pop(), '/api/bongos/my-projects');
+  assert.ok(kids(member.$('boardList')).every((r) => !recruitOf(r)), 'building on a project is not owning one');
+  assert.equal(member.$('boardFor').hidden, true);
+  assert.doesNotMatch(member.$('boardList').className, /canRecruit/);
+  const out = await boot({ reads });
+  assert.deepEqual(out.gets(), ['/api/bongos/community/leaderboard?window=all'], 'signed out, nobody is asked about projects');
+  for (const answer of [{ status: 500, body: {} }, { status: 401, body: {} }, { reject: true }, OWNED(['evil', 'javascript:alert(1)', 'Evil'], ['none', null, 'None'])]) {
+    reads['/my-projects'] = answer;
+    const ui = await boot({ me: { github_login: 'someone' }, reads });
+    assert.ok(kids(ui.$('boardList')).every((r) => !recruitOf(r)), 'no door, and the board is drawn all the same');
+    assert.equal(kids(ui.$('boardList')).length, 2);
+    assert.equal(ui.$('boardFailed').hidden, true, 'a failed projects read is never the board’s failure');
+    assert.equal(ui.$('boardFor').hidden, true);
+  }
+});
+
+test('recruit: several projects are one “Recruit to” choice, and picking one re-points every row', async () => {
+  const reads = READS();
+  reads['/my-projects'] = OWNED(['mercury', 'https://mercury.example', 'Mercury'], ['venus', 'http://venus.example:8080', 'Venus']);
+  const ui = await boot({ me: { github_login: 'nobody' }, reads });
+  const pick = find(ui.$('boardFor'), 'commForPick');
+  assert.equal(pick.tag, 'select');
+  assert.equal(pick.id, 'boardForPick');
+  assert.deepEqual(kids(pick).map((o) => [o.value, o.textContent]), [['0', 'Mercury'], ['1', 'Venus']]);
+  assert.equal(kids(ui.$('boardFor'))[0].attrs.for, 'boardForPick', 'the choice is labelled');
+  assert.match(ui.$('boardFor').textContent, /^Recruit to/);
+  assert.equal(recruitOf(kids(ui.$('boardList'))[0]).attrs.href, 'https://mercury.example/builders/watch?invite=ana', 'the first project, as the server listed them');
+  pick.value = '1';
+  for (const f of pick._on.change || []) f({});
+  await settle();
+  const [ana, bo] = kids(ui.$('boardList'));
+  assert.equal(recruitOf(ana).attrs.href, 'http://venus.example:8080/builders/watch?invite=ana');
+  assert.equal(recruitOf(bo).attrs['aria-label'], 'Recruit bo to Venus (opens in a new tab)');
+  assert.equal(find(ui.$('boardFor'), 'commForPick'), pick, 'the choice is not redrawn, so it keeps the focus');
+  pick.value = '7';
+  for (const f of pick._on.change || []) f({});
+  assert.equal(recruitOf(kids(ui.$('boardList'))[0]).attrs.href, 'http://venus.example:8080/builders/watch?invite=ana', 'a value it never offered changes nothing');
+});
+
+test('recruit: found builders carry it too; the recruiter list never asks', async () => {
+  const reads = READS();
+  reads['/my-projects'] = OWNED(['mercury', 'https://mercury.example', 'Mercury']);
+  const ui = await boot({ pathname: '/community/find', me: { github_login: 'ph' }, reads });
+  assert.deepEqual(ui.gets(), ['/api/bongos/my-projects'], 'nothing searched until asked');
+  assert.equal(ui.$('findFor').hidden, false);
+  assert.equal(ui.$('findFor').textContent, 'Recruit opens Mercury’s hall with their name filled in, and you send the invite there.');
+  assert.equal(ui.$('boardFor').hidden, true, 'only the shown sub-page’s line');
+  ui.$('findQ').value = 'pri';
+  await ui.submit();
+  const [priya, hidden] = kids(ui.$('findList'));
+  const acts = find(priya, 'mineRow__actions');
+  assert.equal(recruitOf(acts).attrs.href, 'https://mercury.example/builders/watch?invite=priyan', 'by GitHub login, never the handle');
+  assert.equal(recruitOf(hidden), null, 'your own row: no door, and no twin in a row that keeps no columns');
+  assert.equal(ui.$('findStatus').textContent, '2 builders found.');
+  const recruiters = await boot({ pathname: '/community/recruiters', me: { github_login: 'owner' }, reads });
+  assert.deepEqual(recruiters.gets(), ['/api/bongos/scouting'], 'the recruiter list draws no Recruit door');
+});
+
 // ── 3. every bar carries the Community menu ──────────────────────────────────
 
 const SERVES_A_CHILD = ['privacy.html', 'terms.html', 'contact.html', 'index.html', 'projects.html'];
@@ -437,11 +550,20 @@ test('the kit renders each sub-page for everyone, the empty board, and a project
   assert.equal(states.states['out-find'].url, '/community/find');
   assert.equal(states.states['in-recruiters'].url, '/community/recruiters');
   assert.ok(states.states['in-recruiters'].expect.visible.includes('#recruitClosed'), 'signed in but not admitted: told, shown no one');
-  for (const [file, name, fixture] of [['community-empty.states.json', 'community-leaderboard', 'community-leaderboard-empty'], ['community-recruiter.states.json', 'scouting', 'scouting-recruiter']]) {
+  for (const [file, name, fixture] of [['community-empty.states.json', 'community-leaderboard', 'community-leaderboard-empty'], ['community-recruiter.states.json', 'scouting', 'scouting-recruiter'], ['community-owner.states.json', 'my-projects', 'my-projects-owner'], ['community-owner-two.states.json', 'my-projects', 'my-projects-owner-two']]) {
     assert.equal(json(file).stub.fixtures[name], fixture);
     assert.ok(fs.existsSync(path.join(ROOT, 'modules', 'ui-design', 'kit', 'fixtures', fixture + '.json')), `fixture ${fixture}`);
   }
   assert.equal(json('community-recruiter.states.json').states['in-recruiter'].url, '/community/recruiters');
+  // the Recruit door (task 1002292): an owner of one project on the board and the search, and of two with the choice
+  assert.ok(json('community-owner.states.json').states['in-owner'].expect.count.some(([sel, n]) => sel === '#boardList a.commRecruit' && n === 6));
+  assert.equal(json('community-owner.states.json').states['in-owner-find'].url, '/community/find');
+  assert.ok(json('community-owner-two.states.json').states['in-owner-two-picked'].actions.some((a) => a[0] === 'select' && a[1] === '#boardForPick'));
+  for (const f of ['my-projects-owner', 'my-projects-owner-two']) {
+    const owned = JSON.parse(fs.readFileSync(path.join(ROOT, 'modules', 'ui-design', 'kit', 'fixtures', f + '.json'), 'utf8')).owned;
+    assert.ok(owned.length && owned.every((p) => p.membership_kind === 'owner' && /^https:\/\//.test(p.origin)), `${f}: owned projects with web addresses`);
+  }
+  assert.deepEqual(JSON.parse(fs.readFileSync(path.join(ROOT, 'modules', 'ui-design', 'kit', 'fixtures', 'my-projects.json'), 'utf8')).owned, [], 'the default builder owns nothing, so every other state draws no door');
 });
 
 function stub(env = {}) {