@bongos/core 1.23.10 → 1.23.11

package/tests/hub_connections_page.mjs

@@ -128,6 +128,7 @@ function el(tag) {
   n.appendChild = (c) => { c.parent = n; n.children.push(c); return c; };
   n.setAttribute = (k, v) => { n.attrs[k] = String(v); };
   n.addEventListener = (t, f) => { (n._on[t] ||= []).push(f); };
+  n.scrollIntoView = () => { n.scrolled = (n.scrolled || 0) + 1; };
   return n;
 }
 const settle = async () => { for (let i = 0; i < 60; i++) await Promise.resolve(); };
@@ -161,7 +162,7 @@ const GRAPH = () => ({
   ], count: 2 } },
 });
 
-async function boot({ me = { builder: { github_login: 'builder' } }, reads = GRAPH(), writes = [] } = {}) {
+async function boot({ me = { builder: { github_login: 'builder' } }, reads = GRAPH(), writes = [], hash = '' } = {}) {
   const ids = new Map();
   for (const id of [...PAGE.matchAll(/ id="([^"]+)"/g)].map((m) => m[1])) {
     const n = el('x');
@@ -180,15 +181,18 @@ async function boot({ me = { builder: { github_login: 'builder' } }, reads = GRA
     return Promise.resolve({ ok: a.status >= 200 && a.status < 300, status: a.status, json: () => (a.body === undefined ? Promise.reject(new SyntaxError('no body')) : Promise.resolve(a.body)) });
   };
   const document = { getElementById: (id) => ids.get(id) || null, createElement: el };
-  const window = { HubBar: { paint: () => {}, ready: Promise.resolve(me) } };
-  const sandbox = { window, document, fetch, console, Promise, JSON, String, Object, Array, URL, Date, isNaN, encodeURIComponent };
+  const winOn = {};
+  const window = { HubBar: { paint: () => {}, ready: Promise.resolve(me) }, addEventListener: (t, f) => { (winOn[t] ||= []).push(f); } };
+  const location = { hash };
+  const sandbox = { window, document, fetch, location, console, Promise, JSON, String, Object, Array, URL, Date, isNaN, encodeURIComponent };
   vm.createContext(sandbox);
   vm.runInContext(SCRIPT, sandbox, { filename: 'connections.html' });
   await settle();
   const click = async (b) => { for (const f of b._on.click || []) f({}); await settle(); };
   const key = async (n, k) => { const e = { key: k, preventDefault() { e.prevented = true; } }; for (const f of n._on.keydown || []) f(e); await settle(); return e; };
   const gets = () => requests.filter((r) => r.method === 'GET').map((r) => r.url);
-  return { ids, requests, gets, click, key, $: (id) => ids.get(id) };
+  const hashTo = async (h) => { location.hash = h; for (const f of winOn.hashchange || []) f({}); await settle(); };
+  return { ids, requests, gets, click, key, hashTo, $: (id) => ids.get(id) };
 }
 const button = (row, label) => all(row, 'btn').find((b) => b.textContent === label);
 
@@ -283,6 +287,51 @@ test('a failed suggestions read drops only that panel', async () => {
   assert.equal(kids(ui.$('connList')).length, 2);
 });
 
+test('opened by the Community menu’s item (#connSuggest): scrolled to once, and an empty panel says so', async () => {
+  // the panel draws after the browser's own jump to the fragment, so the page makes it, once
+  let ui = await boot({ hash: '#connSuggest', writes: [{ status: 201, body: { status: 'pending' } }] });
+  assert.equal(ui.$('connSuggest').hidden, false);
+  assert.equal(ui.$('suggestNone').hidden, true, 'suggestions need no explaining');
+  assert.equal(ui.$('connSuggest').scrolled, 1);
+  await ui.click(button(kids(ui.$('suggestList'))[0], 'Connect'));
+  assert.equal(ui.gets().length, 6);
+  assert.equal(ui.$('connSuggest').scrolled, 1, 'a re-read after Connect does not jump the page again');
+
+  const none = GRAPH();
+  none['/connections/suggestions'].body = { suggestions: [] };
+  ui = await boot({ hash: '#connSuggest', reads: none });
+  assert.equal(ui.$('connSuggest').hidden, false, 'asked for by name, the panel answers rather than vanishing');
+  assert.equal(ui.$('suggestNone').hidden, false);
+  assert.match(PAGE, /<p class="mineEmpty" id="suggestNone" hidden>No one to suggest yet\. Suggestions come from the connections and projects you have in common with other builders\.<\/p>/);
+
+  const failed = GRAPH();
+  failed['/connections/suggestions'] = { status: 500, body: {} };
+  ui = await boot({ hash: '#connSuggest', reads: failed });
+  assert.equal(ui.$('connSuggest').hidden, true, 'an unread list is not "no one to suggest"');
+  assert.equal(ui.$('connSuggest').scrolled, undefined);
+});
+
+test('the menu item pressed while already on the page: the hash change is answered as an arrival', async () => {
+  const none = GRAPH();
+  none['/connections/suggestions'].body = { suggestions: [] };
+  let ui = await boot({ reads: none });
+  assert.equal(ui.$('connSuggest').hidden, true, 'a plain visit: no suggestions, no empty shell');
+  await ui.hashTo('#connSuggest');
+  assert.equal(ui.gets().length, 6, 'one re-read');
+  assert.equal(ui.$('connSuggest').hidden, false);
+  assert.equal(ui.$('suggestNone').hidden, false);
+
+  ui = await boot();
+  await ui.hashTo('#connSuggest');
+  assert.equal(ui.$('connSuggest').scrolled, 1, 'scrolled to once the panel is drawn');
+  await ui.hashTo('#connList');
+  assert.equal(ui.gets().length, 6, 'any other hash reads nothing');
+
+  ui = await boot({ me: null });
+  await ui.hashTo('#connSuggest');
+  assert.deepEqual(ui.requests, [], 'signed out, the door stands and nothing is read');
+});
+
 test('Accept, Decline, Remove and Withdraw: one call each, then the page re-reads', async () => {
   const cases = [
     ['incomingList', 'Accept', 'POST', '/api/bongos/connections/51/accept', { status: 200, body: { status: 'accepted' } }, 'Connected.'],

package/tests/hub_guild_page.mjs

@@ -216,6 +216,7 @@ function boot({ pathname = '/g/forge-crew', me = null, answer = () => NOT_FOUND,
     querySelectorAll(sel) {
       if (sel === '.trig') return trigs;
       if (sel === '.menuBand') return bands;
+      if (sel === '.knowCell') return [];
       const m = sel.match(/^input\[name="(\w+)"\]$/);
       if (!m) throw new Error(`unstubbed selector: ${sel}`);
       return radios.filter((r) => r.name === m[1]);

package/tests/landing_legal_pages.mjs

@@ -195,6 +195,7 @@ for (const p of PAGES) {
       ['Your projects', '/projects?view=mine'], ['New project', '/projects?view=new'],
       // the Community menu's three sub-pages, folded into the band under 480px (task 1003363); apex-only
       ['Leaderboard', '/community'], ['Find a builder', '/community/find'], ['Open to recruiters', '/community/recruiters'],
+      ['Builders you may know', '/connections#connSuggest'],
     ], 'this page has no views of its own, so every item names /projects in full');
     assert.deepEqual(bandLinks(bandOf(stripApexOnly(html, false), 'menuProjects')).map((l) => l[0]), ['Sky', 'Table', 'Your projects', 'New project'], 'a child has no /community');
     assert.deepEqual(bandLinks(bandOf(html, 'menuProfile')), [
@@ -264,6 +265,8 @@ function bootBar(html, answer, pathname) {
     els.set(m[3], el(m[3], /\shidden\b/.test(m[2] + m[4]), attrs));
   }
   const trigs = [...els.values()].filter((e) => /\btrig\b/.test(e.attrs.class || ''));
+  // the signed-in-only "Builders you may know" cells (task 1004256), by class; a child has none
+  const knowCells = [...html.matchAll(/<li class="bandCell(?: bandFold)? knowCell" hidden>/g)].map(() => ({ hidden: true }));
   const bands = [...html.matchAll(/<div class="menuBand" id="(\w+)"[\s\S]*?\n<\/div>/g)].map((m) => {
     const band = els.get(m[1]);
     band.items = [...m[0].matchAll(/<li class="bandCell"(?: id="(\w+)")?><a class="([^"]+)" href="([^"]+)"([^>]*)>([^<]+)<\/a>/g)].map((a) => ({
@@ -287,7 +290,7 @@ function bootBar(html, answer, pathname) {
   const event = (extra) => ({ prevented: false, preventDefault() { this.prevented = true; }, ...extra });
   const calls = [];
   const dom = {
-    els, calls, assigned: null,
+    els, calls, knowCells, assigned: null,
     active: () => document.activeElement,
     band: (id) => els.get(id),
     item: (id, text) => els.get(id).items.find((i) => i.text === text),
@@ -312,6 +315,7 @@ function bootBar(html, answer, pathname) {
     querySelectorAll(sel) {
       if (sel === '.trig') return trigs;
       if (sel === '.menuBand') return bands;
+      if (sel === '.knowCell') return knowCells;
       throw new Error(`unstubbed selector: ${sel}`);
     },
   };
@@ -341,6 +345,7 @@ for (const p of PAGES) {
       assert.equal(out.els.get('who').hidden, true, 'no chip without a session');
       assert.equal(out.els.get('signinTop').hidden, false);
       assert.equal(out.els.get('mineCell').hidden, true, 'and the Projects band offers no Your projects');
+      assert.deepEqual(out.knowCells.map((c) => c.hidden), hub ? [true, true] : [], 'nor Builders you may know; a child has no community menu at all');
       assert.equal(await out.window.HubBar.ready, null);
 
       const dom = bootBar(served, signedIn, p.route);
@@ -352,6 +357,7 @@ for (const p of PAGES) {
       assert.equal(dom.els.get('who').getAttribute('aria-label'), 'Account, octocat');
       for (const id of ['whoImg', 'bandWhoImg']) assert.equal(dom.els.get(id).src, 'https://avatars.example/u/1');
       assert.equal(dom.els.get('mineCell').hidden, false);
+      assert.deepEqual(dom.knowCells.map((c) => c.hidden), hub ? [false, false] : []);
       assert.deepEqual(dom.band('menuProfile').items.map((i) => i.text), hub ? ['My projects', 'Invitations', 'Connections', 'Account', 'Sign out'] : ['My projects', 'Sign out']);
     });
   }