@bongos/core 1.21.93 → 1.21.94

package/tests/wizard_github_feedback.mjs

@@ -69,7 +69,8 @@ test('publicGithubApp: effective status, failure only on error, started_at, and
 
 // ── 2. the words for each stage ─────────────────────────────────────────────
 
-const RS = SCRIPT.indexOf('    /* oauth-app — the ADR 0133 one-click GitHub-App manifest flow');
+// from the shared helpers of the four GitHub steps (task 1004649) to the next step
+const RS = SCRIPT.indexOf('    /* The four GitHub steps of part 03');
 const RE = SCRIPT.indexOf('    /* device-flow', RS);
 const RENDER = SCRIPT.slice(RS, RE);
 
@@ -80,7 +81,8 @@ test('the GitHub step region is still findable (a rename must fail loudly)', ()
 
 function stage(live, { stale = false } = {}) {
   const sandbox = {
-    live: { manifest: null, manifestMsg: '', manifestCode: '', manifestFailure: null, appSlug: null, instStatus: 'active', addrReady: true, ...live },
+    live: { manifest: null, manifestMsg: '', manifestCode: '', manifestFailure: null, appSlug: null, setup: null, installUrl: null, instStatus: 'active', addrReady: true, ...live },
+    state: { name: 'Mercury', slug: 'mercury' },
     manifestStale: stale,
     autoOpenArmed: false,
     resolvedDomain: () => 'mercury.example.com',
@@ -109,7 +111,8 @@ test('pending: waiting for approval, and says where a missing GitHub tab went',
 test('converting is the SAME stage as code_received — approved, placing credentials — never "waiting for approval"', () => {
   for (const m of ['code_received', 'converting']) {
     const html = stage({ manifest: m });
-    assert.match(html, /GitHub’s part is done/, m);
+    assert.match(html, /Approved on GitHub/, m);
+    assert.match(html, /goes on to installing it on your repo/, `${m}: the trip carries on to the install (task 1004649)`);
     assert.match(html, /<prog now=1 done=1/, `${m}: the strip is past the approval stage`);
     assert.doesNotMatch(html, /Waiting for your approval/, m);
   }
@@ -161,8 +164,8 @@ const SEED = SCRIPT.slice(SS, SE);
 test('the reload regions are still findable (a rename must fail loudly)', () => {
   assert.ok(WS > 0 && WE > WS, 'wait-timer boundaries found');
   assert.ok(SS > 0 && SE > SS, 'instance-read seed boundaries found');
-  assert.match(SCRIPT, /if \(!terminal \|\| manifestInFlight\(\)\) pollTimer = setTimeout\(tick, 5000\);/,
-    'a GitHub leg in flight keeps the instance read alive once the project is up — after a reload it is the only watcher');
+  assert.match(SCRIPT, /if \(!terminal \|\| manifestInFlight\(\) \|\| setupOpen\(\)\) pollTimer = setTimeout\(tick, 5000\);/,
+    'a GitHub leg in flight — or an install not yet verified (task 1004649) — keeps the instance read alive once the project is up');
 });
 
 // A page that RELOADED: no click in this tab, no manifest poll, just the instance read.