@bongos/core 1.21.83 → 1.21.85

package/modules/provisioning/birth.js

@@ -21,6 +21,11 @@
 // that came and went would leave a stale line behind.
 
 const BIRTH_KEY = 'founding_birth';
+// The wizard's ship-mode answer (task 1004629): auto | manual, stamped beside the birth on
+// the row the create route just made. Reserved like the birth (out of SETTINGS_VOCAB): the
+// instance's own project_settings['ship.mode'] is where the setting LIVES and where the
+// owner changes it later; this is only what the project was born with.
+const SHIP_MODE_KEY = 'ship_mode';
 const ISO = /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}(\.\d+)?Z$/;
 
 const storedOf = (row) => (row && row.settings && typeof row.settings === 'object' && !Array.isArray(row.settings) ? row.settings : {});
@@ -43,11 +48,18 @@ function demoBox(row) {
   return { people, hours_each: hours };
 }
 
+// The closed ship-mode list is the core's own (src/bongos/project-settings.js), never retyped here.
+const parseShipMode = (raw) => require('../../src/module-api').projectSettings.parseShipMode(raw);
+
+// bornShipMode(row) — PURE. The ship mode the wizard asked for, or '' for none (or junk).
+const bornShipMode = (row) => parseShipMode(storedOf(row)[SHIP_MODE_KEY]).mode || '';
+
 // The companion env (SETTINGS_COMPANION_ENV). src/branding.js maps them onto founding.*.
 const BIRTH_COMPANION_ENV = Object.freeze({
   FOUNDING_BIRTH: bornAt,
   DEMO_PEOPLE: (row) => { const d = demoBox(row); return d ? String(d.people) : ''; },
   DEMO_HOURS: (row) => { const d = demoBox(row); return d ? String(d.hours_each) : ''; },
+  SHIP_MODE: bornShipMode,
 });
 
 // stampBirth(db, instanceId, now) — the create route's one write, on the row it just
@@ -61,4 +73,19 @@ async function stampBirth(db, instanceId, now = new Date()) {
   );
 }
 
-module.exports = { BIRTH_KEY, BIRTH_COMPANION_ENV, stampBirth };
+// stampShipMode(db, instanceId, raw) — the wizard's ship-mode answer, on the row the create
+// route just made. An absent or unusable answer writes nothing, so the instance reads "never
+// chosen" and asks at its first ship (task 1004630). Write-once, like the birth.
+async function stampShipMode(db, instanceId, raw) {
+  const { mode } = parseShipMode(raw);
+  if (!mode) return false;
+  await db.query(
+    `UPDATE provisioning_instances
+        SET settings = COALESCE(settings, '{}'::jsonb) || jsonb_build_object($2::text, $3::text)
+      WHERE id = $1 AND NOT (COALESCE(settings, '{}'::jsonb) ? $2::text)`,
+    [instanceId, SHIP_MODE_KEY, mode],
+  );
+  return true;
+}
+
+module.exports = { BIRTH_KEY, BIRTH_COMPANION_ENV, SHIP_MODE_KEY, stampBirth, stampShipMode };

package/modules/provisioning/routes/provisioning.js

@@ -359,7 +359,7 @@ module.exports = function provisioningRoutes() {
       // exactly the set the panel preselected. An explicit [] is the different
       // answer "none of them". maxItems is a sanity ceiling well above a catalog
       // that is three modules wide today.
-      modules: { type: 'array', itemsType: 'string', maxItems: 50 }, terms_acknowledged: { type: 'boolean' }, demo: { type: 'object' },   // the wizard's terms tick (task 1004417, ../terms-ack.js); the demo route's { people, hours_each } (task 1004420, ../demo.js)
+      modules: { type: 'array', itemsType: 'string', maxItems: 50 }, terms_acknowledged: { type: 'boolean' }, demo: { type: 'object' }, ship_mode: { type: 'string', enum: ['auto', 'manual'] },   // the wizard's terms tick (task 1004417, ../terms-ack.js); the demo route's { people, hours_each } (task 1004420, ../demo.js)
     })) return;
     const body = req.body || {};
     const detailFault = badProjectDetail(body.detail);
@@ -475,6 +475,8 @@ module.exports = function provisioningRoutes() {
       // provision intent exists, so the runner's web.env already carries the marker and the demo's box.
       // Best-effort: a project that misses its marker opens as an ordinary hall; the create still stands.
       if (created) await birth.stampBirth(pool, instance.id).catch((err) => log.error('[provisioning] birth marker not stamped', err));
+      // The wizard's ship mode (task 1004629) rides beside it; a miss means the project asks at its first ship.
+      if (created) await birth.stampShipMode(pool, instance.id, body.ship_mode).catch((err) => log.error('[provisioning] ship mode not stamped', err));
       const demoRow = created && demoAsk.demo ? await demo.startDemoProject(pool, provisioning, instance.id, demoAsk.demo) : null;
       // Enqueue the provision intent (idempotent: an already-open intent is returned)
       // — but ONLY when the instance actually needs standing up. Blindly enqueueing on

package/modules/public-landing/public/projects.html

@@ -1950,6 +1950,31 @@ summary{min-height:24px;padding:3px 0;}
                   </div>
                   <span class="acts"><button type="button" class="rowChg" data-row-chg aria-expanded="false">Edit</button></span>
                 </div>
+
+                <!-- how finished work ships (task 1004629, ADR 0369): Auto unless the owner
+                     says otherwise. It rides the create as ship_mode and becomes the project's
+                     own ship mode, which its settings page can change any time. -->
+                <div class="setRow" data-row="ship">
+                  <span class="k">Shipping</span>
+                  <div class="v"><span class="rowV" data-row-v></span><small class="rowS" data-row-s></small>
+                    <div class="opts" hidden>
+                      <fieldset class="appOpts" id="shipOpts">
+                        <legend>When the AI finishes a task</legend>
+                        <label class="appOpt">
+                          <input type="radio" name="shipMode" value="auto" checked>
+                          <span><b>Auto (recommended)</b>
+                            <span>The AI ships finished work on its own. You don’t run any commands.</span></span>
+                        </label>
+                        <label class="appOpt">
+                          <input type="radio" name="shipMode" value="manual">
+                          <span><b>Manual</b>
+                            <span>The AI stops before each ship and waits for you to approve it.</span></span>
+                        </label>
+                      </fieldset>
+                    </div>
+                  </div>
+                  <span class="acts"><button type="button" class="rowChg" data-row-chg aria-expanded="false">Edit</button></span>
+                </div>
               </div>
               <div class="hint" id="h-review">&nbsp;</div>
               <div class="nav">
@@ -4476,7 +4501,7 @@ summary{min-height:24px;padding:3px 0;}
        request omits the field), [] = the owner switched them all off, [...] =
        what they picked. Never seed it with the preselect — that would store an
        answer nobody gave. */
-    var state = { step: 0, name: '', projType: null, description: '', teamShape: null, modules: null, mode: 'greenfield', owner: '', ownerTouched: false, repo: '', repoTouched: false, slug: '', slugTouched: false, domain: '', noAddress: false, appPlatform: 'later', physics: null, demo: null, look: null, termsAck: false, confirmed: {} };
+    var state = { step: 0, name: '', projType: null, description: '', teamShape: null, modules: null, mode: 'greenfield', owner: '', ownerTouched: false, repo: '', repoTouched: false, slug: '', slugTouched: false, domain: '', noAddress: false, appPlatform: 'later', shipMode: 'auto', physics: null, demo: null, look: null, termsAck: false, confirmed: {} };
     try { Object.assign(state, JSON.parse(sessionStorage.getItem(DRAFT_KEY) || '{}')); } catch (e) {}
     var authKnown = false;   /* flips true when the boot's /me settles, either way */
 
@@ -5956,7 +5981,6 @@ summary{min-height:24px;padding:3px 0;}
     if (appOptsEl) appOptsEl.addEventListener('change', function (ev) {
       if (ev.target && ev.target.name === 'appPlatform' && !ev.target.disabled) { state.appPlatform = ev.target.value; saveDraft(); syncRenderSetup(); paintSetup(); }
     });
-
     /* ── Render (task 1004352, ADR 0348) ──
        The flow itself is renderConnect(), shared with an existing project's page (task
        1004184). Here it reads and writes the draft (`state`), so every answer but the key
@@ -6073,7 +6097,14 @@ summary{min-height:24px;padding:3px 0;}
       return 'Workspace ' + ws + ' — a new app (' + runtimeLabel(state.renderRuntime || 'node') + ', ' + plan + ')' + db + '. Render bills you directly.';
     }
 
-    var ROWS = ['code', 'address', 'app', 'extras', 'team', 'rewards', 'run'];
+    /* the ship row (task 1004629): anything but 'manual' — an older draft has none — is Auto */
+    function shipModeChoice() { return state.shipMode === 'manual' ? 'manual' : 'auto'; }
+    function syncShipStep() {
+      var pick = shipModeChoice();
+      root.querySelectorAll('#shipOpts input[name=shipMode]').forEach(function (i) { i.checked = i.value === pick; });
+    }
+
+    var ROWS = ['code', 'address', 'app', 'extras', 'team', 'rewards', 'run', 'ship'];
     function rowEl(key) { return root.querySelector('#reviewRows .setRow[data-row="' + key + '"]'); }
     function confirmedRows() {
       if (!state.confirmed || typeof state.confirmed !== 'object') state.confirmed = {};
@@ -6118,6 +6149,7 @@ summary{min-height:24px;padding:3px 0;}
       if (key === 'extras') renderModules();
       if (key === 'code') syncHome();
       if (key === 'app') { syncAppStep(); syncRenderSetup(); }
+      if (key === 'ship') syncShipStep();
     }
     function closeRow(key) {
       var row = rowEl(key);
@@ -6182,6 +6214,8 @@ summary{min-height:24px;padding:3px 0;}
        controls' own handlers run first (they are on the targets), then the row repaints */
     ['input', 'change'].forEach(function (type) {
       $('reviewRows').addEventListener(type, function (ev) {
+        /* the ship row's radios have no handler of their own (task 1004629) */
+        if (type === 'change' && ev.target.name === 'shipMode') { state.shipMode = ev.target.value; saveDraft(); }
         if (ev.target.closest && ev.target.closest('.setRow.open .opts')) {
           var row = ev.target.closest('.setRow'), t = rowText(row.getAttribute('data-row'));
           row.querySelector('[data-row-v]').textContent = t.v;
@@ -6247,6 +6281,11 @@ summary{min-height:24px;padding:3px 0;}
         if (a.framing === 'open-source') return { v: 'Free core only', s: 'The free core, on your own machines.' };
         return { v: 'Everything, for you', s: 'Hosting, payouts and the starter kit, managed.' };
       }
+      if (key === 'ship') {
+        return shipModeChoice() === 'manual'
+          ? { v: 'Manual', s: 'The AI waits for you to approve each ship. You can change this later in your project’s settings.' }
+          : { v: 'Auto (recommended)', s: 'The AI ships finished work on its own. You can change this later in your project’s settings.' };
+      }
       return { v: '', s: '' };
     }
     /* paint every row from the draft, and the locked Continue under them */
@@ -6407,7 +6446,9 @@ summary{min-height:24px;padding:3px 0;}
                existing history instead of pushing a fresh tree, which a repo that already
                has commits rejects as unrelated history. state.mode already tracked
                greenfield|adopt for the UI — it has to reach the server too. */
-            onboard_mode: state.mode === 'adopt' ? 'adopt' : 'greenfield'
+            onboard_mode: state.mode === 'adopt' ? 'adopt' : 'greenfield',
+            /* the ship row (task 1004629): becomes the new project's own ship mode */
+            ship_mode: shipModeChoice()
           })
         });
       }).then(function (res) {
@@ -7175,7 +7216,7 @@ summary{min-height:24px;padding:3px 0;}
          is three-valued and null is its "nothing said" sentinel; leaving the key out
          left it UNDEFINED, which is not null — so pickedModules() reached .slice()
          on it and the second project's Modules step threw. */
-      state = { step: 1, name: '', projType: null, description: '', teamShape: null, modules: null, mode: 'greenfield', owner: '', ownerTouched: false, repo: '', repoTouched: false, slug: '', slugTouched: false, domain: '', noAddress: false, appPlatform: 'later', physics: null, demo: null, look: null, termsAck: false, confirmed: {} };
+      state = { step: 1, name: '', projType: null, description: '', teamShape: null, modules: null, mode: 'greenfield', owner: '', ownerTouched: false, repo: '', repoTouched: false, slug: '', slugTouched: false, domain: '', noAddress: false, appPlatform: 'later', shipMode: 'auto', physics: null, demo: null, look: null, termsAck: false, confirmed: {} };
       $('newName').value = ''; $('f-owner').value = ''; $('f-repo').value = ''; $('f-slug').value = ''; $('f-domain').value = '';
       $('f-noaddr').checked = false; $('f-desc').value = '';
       $('termsAck').checked = false; paintDoors(); demoShow('intro'); checksShow('main');

package/modules/public-landing/public/projects.states.json

@@ -55,6 +55,7 @@
     "in-new-review-extras": {"auth":true,"url":"/projects?view=new","actions":[["wait",600],["click","#termsAck"],["wait",100],["click","#wizStart"],["wait",400],["fill","#newName","Mercury"],["click","#typeCards .tpill[data-type=\"game\"]"],["fill","#f-desc","A co-op farming game where the seasons never repeat."],["click","#panel-what button[type=submit]"],["wait",400],["select","#physCountry","US"],["wait",100],["click","[data-phys=\"builder_geography\"][data-val=\"global\"]"],["click","[data-phys=\"minors_on_board\"][data-val=\"false\"]"],["click","[data-phys=\"entity\"][data-val=\"intent-solo\"]"],["click","#physNext"],["wait",700],["click","#reviewRows .setRow[data-row=\"extras\"] [data-row-chg]"],["wait",900]],"expect":{"visible":["#modQ","#modCards .tpill","#modCoreNote"]}},
     "in-new-review-team": {"auth":true,"url":"/projects?view=new","actions":[["wait",600],["click","#termsAck"],["wait",100],["click","#wizStart"],["wait",400],["fill","#newName","Mercury"],["click","#typeCards .tpill[data-type=\"game\"]"],["fill","#f-desc","A co-op farming game where the seasons never repeat."],["click","#panel-what button[type=submit]"],["wait",400],["select","#physCountry","US"],["wait",100],["click","[data-phys=\"builder_geography\"][data-val=\"global\"]"],["click","[data-phys=\"minors_on_board\"][data-val=\"false\"]"],["click","[data-phys=\"entity\"][data-val=\"intent-solo\"]"],["click","#physNext"],["wait",700],["click","#reviewRows .setRow[data-row=\"team\"] [data-row-chg]"],["wait",300],["click","[data-phys-solo=\"many\"]"],["wait",600]],"expect":{"visible":["#physTeam","#physGuessLine","#teamCards","#reviewRows .setRow[data-row=\"rewards\"]"]}},
     "in-new-review-run": {"auth":true,"url":"/projects?view=new","actions":[["wait",600],["click","#termsAck"],["wait",100],["click","#wizStart"],["wait",400],["fill","#newName","Mercury"],["click","#typeCards .tpill[data-type=\"game\"]"],["fill","#f-desc","A co-op farming game where the seasons never repeat."],["click","#panel-what button[type=submit]"],["wait",400],["select","#physCountry","US"],["wait",100],["click","[data-phys=\"builder_geography\"][data-val=\"global\"]"],["click","[data-phys=\"minors_on_board\"][data-val=\"false\"]"],["click","[data-phys=\"entity\"][data-val=\"intent-solo\"]"],["click","#physNext"],["wait",700],["click","#reviewRows .setRow[data-row=\"run\"] [data-row-chg]"],["wait",300],["click","[data-phys=\"framing\"][data-val=\"hybrid\"]"],["wait",600]],"expect":{"visible":["#physSuite"]}},
+    "in-new-review-ship": {"auth":true,"url":"/projects?view=new","actions":[["wait",600],["click","#termsAck"],["wait",100],["click","#wizStart"],["wait",400],["fill","#newName","Mercury"],["click","#typeCards .tpill[data-type=\"game\"]"],["fill","#f-desc","A co-op farming game where the seasons never repeat."],["click","#panel-what button[type=submit]"],["wait",400],["select","#physCountry","US"],["wait",100],["click","[data-phys=\"builder_geography\"][data-val=\"global\"]"],["click","[data-phys=\"minors_on_board\"][data-val=\"false\"]"],["click","[data-phys=\"entity\"][data-val=\"intent-solo\"]"],["click","#physNext"],["wait",700],["click","#reviewRows .setRow[data-row=\"ship\"] [data-row-chg]"],["wait",300],["click","#shipOpts input[value=\"manual\"]"],["wait",300]],"expect":{"visible":["#shipOpts"]}},
     "in-new-review-confirmed": {"auth":true,"url":"/projects?view=new","actions":[["wait",600],["click","#termsAck"],["wait",100],["click","#wizStart"],["wait",400],["fill","#newName","Mercury"],["click","#typeCards .tpill[data-type=\"game\"]"],["fill","#f-desc","A co-op farming game where the seasons never repeat."],["click","#panel-what button[type=submit]"],["wait",400],["select","#physCountry","US"],["wait",100],["click","[data-phys=\"builder_geography\"][data-val=\"global\"]"],["click","[data-phys=\"minors_on_board\"][data-val=\"false\"]"],["click","[data-phys=\"entity\"][data-val=\"intent-solo\"]"],["click","#physNext"],["wait",700],["click","#reviewRows .setRow[data-row=\"address\"] [data-row-chg]"],["wait",200],["fill","#f-slug","mercury"],["wait",900],["fill","#f-domain","mercury.example.com"],["wait",200],["click","#reviewRows .setRow[data-row=\"address\"] [data-row-chg]"],["wait",200]],"expect":{"visible":["#reviewGo","#reviewRows .setRow.done"],"text":[["#reviewGo","Looks right, continue"]]}},
     "in-new-look": {"auth":true,"url":"/projects?view=new","actions":[["wait",600],["click","#termsAck"],["wait",100],["click","#wizStart"],["wait",400],["fill","#newName","Mercury"],["click","#typeCards .tpill[data-type=\"game\"]"],["fill","#f-desc","A co-op farming game where the seasons never repeat."],["click","#panel-what button[type=submit]"],["wait",400],["select","#physCountry","US"],["wait",100],["click","[data-phys=\"builder_geography\"][data-val=\"global\"]"],["click","[data-phys=\"minors_on_board\"][data-val=\"false\"]"],["click","[data-phys=\"entity\"][data-val=\"intent-solo\"]"],["click","#physNext"],["wait",700],["click","#reviewRows .setRow[data-row=\"address\"] [data-row-chg]"],["wait",200],["fill","#f-slug","mercury"],["wait",900],["fill","#f-domain","mercury.example.com"],["wait",200],["click","#reviewRows .setRow[data-row=\"address\"] [data-row-chg]"],["wait",200],["click","#reviewGo"],["wait",500]],"expect":{"visible":["#panel-look","#wizLook","#wizRecap","#doCreate"],"hidden":["#panel-review"],"attr":[["#wizRoom","data-screen","look"]]}},
     "in-new-done": {"auth":true,"url":"/projects?view=new","actions":[["wait",600],["click","#termsAck"],["wait",100],["click","#wizStart"],["wait",400],["fill","#newName","Mercury"],["click","#typeCards .tpill[data-type=\"game\"]"],["fill","#f-desc","A co-op farming game where the seasons never repeat."],["click","#panel-what button[type=submit]"],["wait",400],["select","#physCountry","US"],["wait",100],["click","[data-phys=\"builder_geography\"][data-val=\"global\"]"],["click","[data-phys=\"minors_on_board\"][data-val=\"false\"]"],["click","[data-phys=\"entity\"][data-val=\"intent-solo\"]"],["click","#physNext"],["wait",700],["click","#reviewRows .setRow[data-row=\"address\"] [data-row-chg]"],["wait",200],["fill","#f-slug","mercury"],["wait",900],["fill","#f-domain","mercury.example.com"],["wait",200],["click","#reviewRows .setRow[data-row=\"address\"] [data-row-chg]"],["wait",200],["click","#reviewGo"],["wait",500],["click","#doCreate"],["wait",1500]],"expect":{"visible":["#panel-done","#hop","#hopCanvas","#hopStatus","#hopJump"],"hidden":["#panel-look","#qWrap","#wizBack","#wizInvite","#liveProgress","#humanSteps","#wizInviteLater","#stepPager"]}},

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.83",
+  "version": "1.21.85",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.21.83",
+      "version": "1.21.85",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.83",
+  "version": "1.21.85",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -9324,5 +9324,17 @@
       "id": "1004646",
       "text": "Project invites now reach people on cloudbongos.com. Before, an invite sent by GitHub username was silently lost if the person had never signed in to a project through cloudbongos.com, which is almost every new invitee, so the"
     }
+  ],
+  "1.21.84": [
+    {
+      "id": "1004629",
+      "text": "New projects now ask how finished work should ship: Auto (recommended) or Manual. The answer becomes the project's ship mode, which the owner can change later on the settings page."
+    }
+  ],
+  "1.21.85": [
+    {
+      "id": "1004379",
+      "text": "A page tweak that passed its grade and is waiting for its artist no longer reports itself as a failed grade: the closing card, the PR description and the credits line now all say it passed and is waiting for the artist's appro"
+    }
   ]
 }

package/scripts/gds/ship-finish.js

@@ -244,7 +244,8 @@ async function finishHeld({ taskId, summary, postGradeStatus, card }, deps = {})
     console.error(`  Re-run to publish it again (the grade is not re-run): node scripts/gds/ship.js ${taskId}`);
   }
   const usage = await (deps.postShipSync || postShipSync)(taskId, 'confirmed');
-  await (deps.printCompletionCard || printCompletionCard)({ taskId, postGradeStatus, card, usage, land });
+  // task 1004379: name the stage — at 'completed' the card would otherwise read a failed grade.
+  await (deps.printCompletionCard || printCompletionCard)({ taskId, postGradeStatus, card, usage, land, stage: 'held' });
   return land;
 }
 
@@ -270,7 +271,7 @@ function diffstatFor(baseline) {
 // in-feed HTML to a temp file and prints an [otb-card-html] marker the
 // builder-ship skill picks up to render it in the chat feed. Every step is
 // best-effort — a summary card must NEVER fail or undo a completed ship.
-async function printCompletionCard({ taskId, postGradeStatus, card, usage, land = null }) {
+async function printCompletionCard({ taskId, postGradeStatus, card, usage, land = null, stage = undefined }) {
   if (!card) return;
   try {
     const shipCard = require('../../modules/lifecycle/ship-card');
@@ -329,6 +330,7 @@ async function printCompletionCard({ taskId, postGradeStatus, card, usage, land
     }
 
     const cardInputs = {
+      stage, // task 1004379: 'held' from finishHeld; undefined ⇒ derived from postGradeStatus
       postGradeStatus,
       taskId,
       title: card.title,

package/scripts/gds/ship-flow.js

@@ -722,7 +722,7 @@ async function shipMain() {
 
   printCreditsAndAchievements({
     postGradeStatus, credits, creditsRaw, creditsMultiplier, ideaBonusInfo,
-    justUnlocked: postGradeJustUnlocked,
+    justUnlocked: postGradeJustUnlocked, held,
   });
 
   // ---- Step 3: confirmed→shipped tail (merge + deploy → memory/session sync →
@@ -1107,6 +1107,7 @@ async function regradeMain() {
   const g = gradePost.data.grade;
   recordGradeOutcome({ taskId, grade: g });
   const postGradeStatus = gradePost.data.taskStatus;
+  const held = gradePost.data.held === true; // task 1004322: a page tweak's pass waits for its artist
   printGradeOutcome(g, taskId);
   printCreditsAndAchievements({
     postGradeStatus,
@@ -1115,13 +1116,14 @@ async function regradeMain() {
     creditsMultiplier: gradePost.data.creditsMultiplier ?? null,
     ideaBonusInfo: gradePost.data.ideaBonus ?? null,
     justUnlocked: gradePost.data.just_unlocked || [],
+    held, // task 1004379: a held pass is not 'grade not passed'
   });
 
   // On a pass the task is now confirmed — run the SAME confirmed→shipped tail as a
   // normal ship (finishShip, #1093/C9) so a re-grade lands identically.
   await finishShip({
     taskId, summary, advanceToMerge: gradePost.data.advanceToMerge, skipMerge, dbOnly,
-    held: gradePost.data.held === true, // task 1004322: a page tweak's pass waits for its artist
+    held,
     postGradeStatus,
     doneLine: g.passed ? 'Done — re-grade passed.' : 'Done — re-grade still failing; fix and try again.',
     // task 1270: completion card for the re-grade path too.

package/scripts/gds/ship-grade-steps.js

@@ -478,9 +478,14 @@ function printGradeOutcome(g, taskId) {
 
 // Print the credits line + multiplier breakdown + idea bonus + unlocked
 // achievements from a grade/confirm response.
-function printCreditsAndAchievements({ postGradeStatus, credits, creditsRaw, creditsMultiplier, ideaBonusInfo, justUnlocked }) {
+function printCreditsAndAchievements({ postGradeStatus, credits, creditsRaw, creditsMultiplier, ideaBonusInfo, justUnlocked, held = false }) {
   console.log('');
-  if (postGradeStatus === 'completed') {
+  if (held) {
+    // task 1004379: a page tweak's PASS waits at completed for its artist (ADR
+    // 0341 D7). Reading 'completed' as 'grade not passed' told the reader the
+    // opposite of what happened.
+    console.log(`Credits awarded: ${credits} (none yet — the grade passed; credits land when the artist approves and it merges)`);
+  } else if (postGradeStatus === 'completed') {
     console.log(`Credits awarded: ${credits} (none — task at completed, grade not passed)`);
   } else if (postGradeStatus === 'confirmed') {
     console.log(`Credits awarded: ${credits} (none yet — credits land when the task merges to main)`);

package/scripts/gds/ship-land.js

@@ -19,6 +19,7 @@ const { plainCardLines } = require('./plain-cards.js');
 // The server's own reader of a PR's check rollup (task 1003988), reused so the laptop
 // poll names a red PR exactly the way publish-status does (task 1003764). Dependency-free.
 const { readCheckRollup, UNIT_REPORT_CONTEXT } = require('../../modules/lifecycle/check-rollup.js');
+const { prMergeSentence } = require('../../modules/lifecycle/page-tweak-hold.js');
 
 // ---------- the land outcome (task 1002541, part 1) ----------
 //
@@ -927,8 +928,7 @@ async function ciLandLocal(taskId, branch, valueSummary, { hold = false } = {})
     `Auto-opened by ship.js (deploy mode: ci) for task ${taskId}.\n\n` +
     `${sanitizeGitHubRefs(valueSummary) || '(no value summary)'}\n\n` +
     `Merging this PR triggers .github/workflows/deploy-prod.yml to deploy to ` +
-    `${deployTargetNote}. Auto-merge is enabled — GitHub lands it once the ` +
-    `required checks pass.`;
+    `${deployTargetNote}. ${prMergeSentence(hold)}`; // task 1004379: a held round's PR says it waits
   if (!existing || existing.state === 'CLOSED' || existing.state === 'MERGED') {
     console.log('  ci-land: opening PR -> main...');
     if (!ghArgvOk(buildPrCreateArgv(branch, title, body))) {

package/src/bongos/project-settings.js

@@ -226,14 +226,26 @@ function parseShipMode(raw) {
 // resolveShipMode() — the project's ship mode and where it came from.
 // Returns { mode, source, chosen, invalid }:
 //   mode    — always 'auto' or 'manual'
-//   source  — 'project_settings' | 'default'
+//   source  — 'project_settings' | 'wizard' | 'default'
 //   chosen  — true only when someone actually SET a usable value. "Never chosen" is
 //             a real answer the first-ship prompt (task 1004630) asks about, so it
 //             must not be confused with "chose the default".
 //   invalid — null, or { where, raw, reason } for a stored value that is unusable.
 // A database that cannot be read answers the default rather than failing a ship —
 // the same reporting posture as resolveRotDays.
-async function resolveShipMode() {
+//
+// 'wizard' (task 1004629): the founder picked a mode in the project-creation wizard,
+// which reaches this instance as the server-only branding value founding.shipMode
+// (the hub cannot write this database). It counts as chosen, but only while no row
+// exists: the settings page and the CLI write the row, so a later change always wins.
+// `deps.branding` is the test seam; production reads the process's own pack.
+function wizardShipMode(deps) {
+  let pack;
+  try { pack = deps.branding ? deps.branding() : require('../branding').branding(); } catch (_) { return null; }
+  return parseShipMode(pack && pack.founding && pack.founding.shipMode).mode || null;
+}
+
+async function resolveShipMode(deps = {}) {
   let row = null;
   try {
     row = await getSetting(SETTING_KEYS.SHIP_MODE);
@@ -251,6 +263,8 @@ async function resolveShipMode() {
       invalid: { where: `project_settings['${SETTING_KEYS.SHIP_MODE}']`, raw: String(row.value), reason: got.reason },
     };
   }
+  const fromWizard = wizardShipMode(deps);
+  if (fromWizard) return { mode: fromWizard, source: 'wizard', chosen: true, invalid: null };
   return { mode: DEFAULT_SHIP_MODE, source: 'default', chosen: false, invalid: null };
 }
 

package/src/branding.js

@@ -103,6 +103,9 @@ const ENV_OVERRIDES = [
   ['FOUNDING_BIRTH', ['founding', 'birth']],
   ['DEMO_PEOPLE', ['founding', 'demoPeople']],
   ['DEMO_HOURS', ['founding', 'demoHours']],
+  // The ship mode the founder picked in the wizard (task 1004629), empty when none was.
+  // resolveShipMode reads it only while project_settings['ship.mode'] is unset.
+  ['SHIP_MODE', ['founding', 'shipMode']],
 ];
 
 const isObj = (v) => v && typeof v === 'object' && !Array.isArray(v);

package/src/module-api.js

@@ -75,7 +75,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.21.83'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.21.85'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/held_tweak_reporting.mjs

@@ -0,0 +1,164 @@
+// tests/held_tweak_reporting.mjs — a held page tweak is reported as a PASS that
+// waits for its artist, never as a failed grade (task 1004379, ADR 0341 D7).
+//
+// WHY. The first live Tweak Mode rounds (1004345, 1004348) passed their grade and
+// held at completed for the artist, as designed — and then three surfaces told the
+// reader the opposite: the closing card said "grade failed" and offered --regrade,
+// the PR the server opened said "Auto-merge is enabled", and a passing --regrade
+// printed "Credits awarded: 0 (grade not passed)". Each case below drives the real
+// code a held round runs through:
+//   1. finishHeld hands the card a 'held' stage, and that card reads as a pass;
+//   2. the publish route's PR body names the hold (and an ordinary PR is unchanged);
+//   3. the credits line a passing (re-)grade prints on a held round says it passed.
+
+import { strict as assert } from 'node:assert';
+import { createRequire } from 'node:module';
+import http from 'node:http';
+import { makeRunner } from './helpers.mjs';
+
+process.env.NODE_ENV = 'test';
+const require = createRequire(import.meta.url);
+const { test, summary } = makeRunner();
+
+const shipCard = require('../modules/lifecycle/ship-card.js');
+const shipFinish = require('../scripts/gds/ship-finish.js');
+const shipLand = require('../scripts/gds/ship-land.js');
+const { printCreditsAndAchievements } = require('../scripts/gds/ship-grade-steps.js');
+
+const capture = async (fn) => {
+  const out = [];
+  const orig = console.log;
+  console.log = (...a) => out.push(a.join(' '));
+  try { await fn(); } finally { console.log = orig; }
+  return out.join('\n');
+};
+
+// ---- 1. the closing card --------------------------------------------------
+
+const twelveMinor = Array.from({ length: 12 }, (_, i) => ({ severity: 'minor', file: `f${i}`, summary: 'nit' }));
+
+await test('finishHeld names the held stage to the card, even though the task sits at completed', async () => {
+  let cardArgs = null;
+  await capture(() => shipFinish.finishHeld({ taskId: 5001, summary: 's', postGradeStatus: 'completed', card: { title: 't' } }, {
+    publishHeld: async () => shipLand.landHeld({ prUrl: 'https://github.com/o/r/pull/77' }),
+    postShipSync: async () => null,
+    printCompletionCard: async (a) => { cardArgs = a; },
+  }));
+  assert.equal(cardArgs.stage, 'held');
+  assert.equal(cardArgs.postGradeStatus, 'completed');
+});
+
+await test('a held pass prints a hold card: no "grade failed", no --regrade, a passing grade row', () => {
+  const model = shipCard.buildCardModel({
+    stage: 'held', postGradeStatus: 'completed', taskId: 5001, title: 't',
+    grade: { passed: true, issues: twelveMinor, panel: 4 },
+    credits: { awarded: 0 },
+  });
+  const text = shipCard.renderMonospaceCard(model);
+  const html = shipCard.renderCardHtml(model);
+  assert.equal(model.stage, 'held');
+  assert.match(model.cfg.headline(5001), /waiting for the artist/);
+  for (const out of [text, html]) {
+    assert.doesNotMatch(out, /grade failed/i, 'the card must not call a pass a failure');
+    assert.doesNotMatch(out, /Needs fixes/);
+    assert.doesNotMatch(out, /--regrade/);
+    assert.doesNotMatch(out, /fail · 12 issues/);
+    assert.match(out, /awaiting artist/);
+  }
+  const row = (k) => (model.rows.find((r) => r.k === k) || {}).v;
+  assert.match(row('Grade'), /^pass/);
+  assert.match(row('Deploy'), /artist/);
+  assert.match(row('Credits'), /artist approves/);
+  assert.equal(model.action.cmd, '/builder-start');
+});
+
+await test('an ordinary stop at completed (a real failed grade) still reads as a failed grade', () => {
+  const model = shipCard.buildCardModel({
+    postGradeStatus: 'completed', taskId: 5002, title: 't',
+    grade: { passed: false, issues: twelveMinor },
+  });
+  assert.equal(model.stage, 'failed');
+  assert.match(shipCard.renderMonospaceCard(model), /grade failed/);
+  assert.match(model.action.cmd, /--regrade/);
+});
+
+// ---- 2. the PR body -------------------------------------------------------
+
+const express = require('express');
+const api = require('../src/module-api.js');
+const db = require('../modules/lifecycle/db.js');
+const gp = require('../modules/lifecycle/github-push.js');
+const prAssign = require('../modules/lifecycle/pr-assign.js');
+const pageTweakReads = require('../modules/lifecycle/page-tweak-reads.js');
+const hold = require('../modules/lifecycle/page-tweak-hold.js');
+
+let heldNow = false;
+let prBody = null;
+api.requireBuilder = (req, res, next) => { req.builder = { id: 1, rank: 'archon', github_login: 'the-archon' }; next(); };
+db.getLastClaimHolder = async () => ({ builder_id: 5, github_login: 'some-builder' });
+db.setClaimPublishedSha = async () => {};
+gp.isConfigured = () => true;
+gp.pushBundle = async () => ({ head_sha: 'a'.repeat(40) });
+gp.openOrFindPullRequest = async ({ body }) => { prBody = body; return { number: 77, url: 'https://github.com/o/r/pull/77', node_id: 'N' }; };
+gp.enableAutoMergeDetailed = async () => ({ ok: true });
+gp.setCommitStatus = async () => true;
+prAssign.assignPullRequest = async () => ({ assigned: true });
+pageTweakReads.heldForArtistFailClosed = async () => heldNow;
+
+const app = express();
+app.use((req, res, next) => { res.fail = (code, status, extra) => res.status(typeof status === 'number' ? status : (status && status.status) || 500).json({ error: code, ...(extra || {}) }); next(); });
+app.use(require('../modules/lifecycle/routes/tasks.js')());
+const server = http.createServer(app);
+await new Promise((r) => server.listen(0, '127.0.0.1', r));
+const base = `http://127.0.0.1:${server.address().port}`;
+const publish = async () => {
+  prBody = null;
+  const res = await fetch(`${base}/tasks/5001/publish-branch`, {
+    method: 'POST', headers: { 'Content-Type': 'application/json' },
+    body: JSON.stringify({ branch: 'task-5001', head_sha: 'a'.repeat(40), bundle_b64: Buffer.from('b').toString('base64'), value_summary: 'Page tweak.' }),
+  });
+  return { status: res.status, body: await res.json() };
+};
+
+await test("a held round's PR body says it waits for the artist, and never promises auto-merge", async () => {
+  heldNow = true;
+  const r = await publish();
+  assert.equal(r.status, 201, JSON.stringify(r.body));
+  assert.equal(r.body.auto_merge, false);
+  assert.ok(prBody.endsWith(hold.HELD_PR_SENTENCE), prBody);
+  assert.match(prBody, /artist/);
+  assert.doesNotMatch(prBody, /Auto-merge is enabled/);
+});
+
+await test('every other PR body keeps the auto-merge sentence it always had', async () => {
+  heldNow = false;
+  const r = await publish();
+  assert.equal(r.status, 201);
+  assert.equal(r.body.auto_merge, true);
+  assert.match(prBody, /Auto-merge is enabled — GitHub lands it once the required checks pass\.$/);
+});
+server.close();
+
+// ---- 3. the credits line after a passing (re-)grade -----------------------
+
+await test('a passing grade on a held round prints a pass, not "grade not passed"', async () => {
+  const text = await capture(() => printCreditsAndAchievements({ postGradeStatus: 'completed', credits: 0, justUnlocked: [], held: true }));
+  assert.doesNotMatch(text, /grade not passed/);
+  assert.match(text, /grade passed/);
+  assert.match(text, /artist approves/);
+});
+
+await test('a real failed grade at completed still says the grade did not pass', async () => {
+  const text = await capture(() => printCreditsAndAchievements({ postGradeStatus: 'completed', credits: 0, justUnlocked: [] }));
+  assert.match(text, /grade not passed/);
+});
+
+await test('both grade paths (ship and --regrade) hand the hold to the credits line', () => {
+  const fs = require('node:fs');
+  const src = fs.readFileSync(new URL('../scripts/gds/ship-flow.js', import.meta.url), 'utf8');
+  const calls = src.split('printCreditsAndAchievements({').slice(1).map((c) => c.slice(0, c.indexOf('});')));
+  const withHold = calls.filter((c) => /\bheld\b/.test(c));
+  assert.equal(withHold.length, 2, 'the ship grade and the re-grade both pass held');
+});
+
+summary();

package/tests/page_tweak_hold.mjs

@@ -206,8 +206,7 @@ await test('finishShip routes a held pass away from mergeAndDeploy (the source s
   const mergeAt = body.indexOf('await mergeAndDeploy(');
   assert.ok(holdAt > 0 && mergeAt > holdAt, 'the hold is decided BEFORE any merge is attempted');
   const flow = fs.readFileSync(require.resolve('../scripts/gds/ship-flow.js'), 'utf8');
-  assert.equal((flow.match(/held = gradePost\.data\.held === true/g) || []).length, 1, 'shipMain reads the hold off the grade response');
-  assert.equal((flow.match(/held: gradePost\.data\.held === true/g) || []).length, 1, 'regradeMain does too');
+  assert.equal((flow.match(/\bheld = gradePost\.data\.held === true/g) || []).length, 2, 'shipMain and regradeMain both read the hold off the grade response');
   assert.match(flow, /tweakHold\.isHeldForArtist\(task, tRes\.data\.grade/, 'a re-run of a held task re-publishes instead of re-grading');
 });
 

package/tests/projects_hub.mjs

@@ -729,7 +729,7 @@ test('the About answers travel on the create request, and an empty one is OMITTE
   // wizard PREFILLED, and the sentence is never prefilled, so it has no row there — its
   // cost is stated on its own field (pinned above)
   assert.doesNotMatch(SCRIPT, /function renderReview\(|\$\('reviewList'\)/, 'no ledger review is left');
-  assert.match(SCRIPT, /var ROWS = \['code', 'address', 'app', 'extras', 'team', 'rewards', 'run'\];/,
+  assert.match(SCRIPT, /var ROWS = \['code', 'address', 'app', 'extras', 'team', 'rewards', 'run', 'ship'\];/,
     'the review rows are the seven prefilled answers');
 });
 

package/tests/projects_hub_app_step.mjs

@@ -168,7 +168,7 @@ test('the row is real markup: Render and Decide later, Decide later the default'
 
 test("the row sits in the review, between Address and Extras, and its checks are the old step's (task 1004504)", () => {
   assert.match(HUB, /var panels = \{ 0: 'panel-gate', 1: 'panel-fork', 2: 'panel-what', 3: 'panel-checks', 4: 'panel-review', 5: 'panel-look', 6: 'panel-done' \};/);
-  assert.match(HUB, /var ROWS = \['code', 'address', 'app', 'extras', 'team', 'rewards', 'run'\];/);
+  assert.match(HUB, /var ROWS = \['code', 'address', 'app', 'extras', 'team', 'rewards', 'run', 'ship'\];/);
   assert.doesNotMatch(HUB, /<li[^>]*data-step="\d+"/, 'no rail beat names the step any more');
   assert.match(HUB, /if \(step === 4\) \{[^}]*syncAppStep\(\); syncRenderSetup\(\);\r?\n\s*paintSetup\(\);\r?\n\s*\}/, 'entering the review repaints the row, Render setup included');
   assert.match(HUB, /if \(key === 'app'\) \{ syncAppStep\(\); syncRenderSetup\(\); \}/, 'opening the row repaints it too');