@bongos/core 1.21.80 → 1.21.81

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.21.80",
-  "core_contract": "1.21.80",
-  "source_commit": "b836a5577c82fe4d7594fc0a26a3e4f13076750a",
+  "core_version": "1.21.81",
+  "core_contract": "1.21.81",
+  "source_commit": "cf13896f2510e85aa87ab7ad8fbe400a57f37d54",
   "source_ref": "HEAD",
-  "built_at": "2026-10-09T00:19:50.271Z",
+  "built_at": "2026-10-09T00:28:08.709Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 590,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 3611,
-  "tree_sha256": "669bec1b067c38b5bf3b4bc4dd955774f73039820ab806892e1f5a05305813d8",
+  "tree_sha256": "ae8df2494a02571e7e6cdc50e626b98cf07fbb4e76b8c8d9f7f851518dc121e8",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2862,7 +2862,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "32d825702934aa11e29c66c61e8cc5d3b7ba8133217227656308140c05315062"
+      "sha256": "b32998694f39731350f5e5eff315a2732e48be195f458ccc3de891de9c2442a7"
     },
     {
       "path": "docs/modules-contract.md",
@@ -4802,7 +4802,7 @@
     {
       "path": "modules/economy/credits.js",
       "mode": "0000644",
-      "sha256": "37eac58e02d10d734513251857e92050ab8c5c62844ad156bc005b274dbd5147"
+      "sha256": "50c51a283fc75facdce611db04c97cef6ec048a080e10f446716a841a449d8aa"
     },
     {
       "path": "modules/economy/earnings.js",
@@ -4902,7 +4902,7 @@
     {
       "path": "modules/government/board.js",
       "mode": "0000644",
-      "sha256": "d95e53c9aec8dc4614aec18da37644da44256d0977195ae32ad5951a1d50ba09"
+      "sha256": "d3009a87799108ab8bc58022b74ddb7cbd2f6cad44e7c767bf6bdfc396021f15"
     },
     {
       "path": "modules/government/catalog.js",
@@ -10087,12 +10087,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "12eba8a8f76736d82a5a1cf8f991f43415491163325465b2197cac227c6c3544"
+      "sha256": "f8c13471f23a50668aa5ec8c79f68f3e039be8e38ec84510551b69637b16f699"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "186a539924b6c2d566c4c23a84d99b3574567b41babe3eddc4e8f3406480e96e"
+      "sha256": "257169d46b1ec312f90e5062c1dc92d85f865608a14f06173cf2110b6b3abe79"
     },
     {
       "path": "public-docs/index.html",
@@ -10112,7 +10112,7 @@
     {
       "path": "release-notes.json",
       "mode": "0000644",
-      "sha256": "fced1b5988cd7b0496a0f28a532cec8d233d2889b4ca667f2dc0485bf62fb678"
+      "sha256": "4aca4ff0ed7bb607cde50892af1d128ac444fe5e8f823b8587f559414f14da01"
     },
     {
       "path": "scripts/cron/style_guide_audit.sh",
@@ -12362,7 +12362,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "5e3a905a711427b31f0965112e50a85872a8d45c3bcf8e2c7f4c6b436206d436"
+      "sha256": "02c4342378ad3dd61bd2bb44b0c2e8077a45d1388cbe16cabce84038ac188f56"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -15137,7 +15137,7 @@
     {
       "path": "tests/idea_task_ship_credit.mjs",
       "mode": "0000644",
-      "sha256": "e7f0807491c094fddedd518380af73a98c7ac17ac9d42736d9ed9a7cd6d4bf51"
+      "sha256": "beadb4d87a4fcab2437f85746f5d2943ab55a3a0725a24d1b6bdc0cbc8076f62"
     },
     {
       "path": "tests/idea_templates.mjs",
@@ -16157,7 +16157,7 @@
     {
       "path": "tests/profile_earnings.mjs",
       "mode": "0000644",
-      "sha256": "f6d853c7c9d75027fb7f64cba76242726a68f69be8d0a3501d4b80d8b6ee32a3"
+      "sha256": "cab6e081d224a192df1d8d1834ddf4b6cdfeeb1be2a1fde520faa39edb04da18"
     },
     {
       "path": "tests/profile_fields.mjs",

package/docs/module-api-changelog.md

@@ -2992,5 +2992,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.21.78 with no explicit bump. run 37838546662. (task 1002620)
   1.21.80 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.21.79 with no explicit bump. run 37864152237. (task 1002620)
+  1.21.81 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.21.80 with no explicit bump. run 37864877677. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/economy/credits.js

@@ -602,10 +602,36 @@ async function awardIdeaTaskShipCredit(client, { taskId, config = rewardConfig()
       LIMIT 1`,
     [taskId]
   );
-  if (rows.length === 0 || rows[0].captured_by == null) {
+  // THE GOAL AN IDEA BECAME (task 1004442). A Full Idea ratified into a goal
+  // writes ideas_goal_ratifications and NO lineage row, so every task later
+  // filed under that goal shipped paying the idea nothing. With no lineage row
+  // the goal's idea is the source, at the same full share; a lineage row wins.
+  let source = rows[0];
+  let viaGoalId = null;
+  if (!source) {
+    const born = await client.query(
+      `SELECT r.idea_id,
+              r.goal_id,
+              i.captured_by,
+              COALESCE(g.grade, 'quick')        AS grade,
+              g.completeness_score              AS completeness,
+              g.developed_by                    AS developed_by
+         FROM tasks t
+         JOIN ideas_goal_ratifications r ON r.goal_id = t.goal_id
+         JOIN idea_inbox i               ON i.id = r.idea_id
+         LEFT JOIN ideas_grades g        ON g.idea_id = r.idea_id
+        WHERE t.id = $1
+        ORDER BY r.ratified_at ASC, r.idea_id ASC
+        LIMIT 1`,
+      [taskId]
+    );
+    source = born.rows[0];
+    viaGoalId = source ? source.goal_id : null;
+  }
+  if (!source || source.captured_by == null) {
     return { credited: 0, reason: 'no_source_idea', ideaId: null, authorId: null };
   }
-  const { idea_id: ideaId, captured_by: authorId, grade, completeness, developed_by: developedBy } = rows[0];
+  const { idea_id: ideaId, captured_by: authorId, grade, completeness, developed_by: developedBy } = source;
   const factor = ideaGradeFactor(grade, completeness);
   const delta = Math.round(IDEA_TASK_SHIP_BASE * factor);
   if (delta <= 0) {
@@ -625,7 +651,7 @@ async function awardIdeaTaskShipCredit(client, { taskId, config = rewardConfig()
     payees,
     reason,
     taskId,
-    describe: (p) => `Task #${taskId} shipped under idea #${ideaId} (${gradeLabel}) → ${p.delta}c to its ${p.role.replace(/_/g, ' ')} (ideator lane stream 1, ADR 0172${p.role === 'developer' || p.role === 'spark_author' ? '; split ADR 0185' : ''})`,
+    describe: (p) => `Task #${taskId} shipped under ${viaGoalId != null ? `goal #${viaGoalId}, ratified from ` : ''}idea #${ideaId} (${gradeLabel}) → ${p.delta}c to its ${p.role.replace(/_/g, ' ')} (ideator lane stream 1, ADR 0172${p.role === 'developer' || p.role === 'spark_author' ? '; split ADR 0185' : ''})`,
   });
   return credited > 0
     ? { credited, reason: 'paid', ideaId: Number(ideaId), authorId: Number(authorId), payees: booked }

package/modules/government/board.js

@@ -556,10 +556,10 @@ function passPayload(closed, { authorId, completenessScore, passedAt }) {
 // credit is booked through the `reward` PORT inside the same transaction that
 // writes the outcome — if the credit write fails, the close rolls back and the
 // item stays open, so the vote is retried rather than silently unpaid.
-// `resolveOptional` returning null (no economy module), or a reward port that
-// does not yet carry awardIdeaGovernancePassCredit (IC5 unbuilt), is a CLEAN
+// The payout is economy's `awardIdeaGovernancePassCredit` (stream 3, IC5). A null
+// `resolveOptional` (no economy), or a port without it (an older one), is a CLEAN
 // NO-OP: the item still closes, nothing is booked, and the durable
-// `outcome = 'passed'` row lets IC5's re-drive sweep pay later. The port is
+// `outcome = 'passed'` row is what a re-drive sweep would pay from. The port is
 // resolved and the payload's reads happen BEFORE the transaction opens.
 //
 // `board.item.passed` is then emitted AFTER commit, emitAsync, for non-money

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.80",
+  "version": "1.21.81",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.21.80",
+      "version": "1.21.81",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.80",
+  "version": "1.21.81",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -9306,5 +9306,11 @@
       "id": "1004393",
       "text": "The tweak editor is ready to show landing and status pages side by side with the words, instead of in a separate window. It stays off until a small web-server change is made on the host; those steps are waiting in the owner's"
     }
+  ],
+  "1.21.81": [
+    {
+      "id": "1004442",
+      "text": "When the board turns someone's idea into a goal, every task later finished under that goal now pays the idea's author, as promised. Before this, only work promoted straight from the idea paid them, so a goal full of finished w"
+    }
   ]
 }

package/src/module-api.js

@@ -75,7 +75,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.21.80'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.21.81'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/idea_task_ship_credit.mjs

@@ -113,5 +113,50 @@ await test('the lane opted out, or a task with no source idea, pays nothing', as
   assert.equal(r.reason, 'no_source_idea');
 });
 
+// task 1004442: a Full Idea ratified into a GOAL writes no lineage row, so a
+// task filed later under that goal is found through the goal instead.
+function goalStubClient(lineage, born) {
+  const c = stubClient(lineage);
+  const inner = c.query;
+  c.goalAsked = 0;
+  c.query = async (sql, params) => {
+    if (/FROM tasks t\s+JOIN ideas_goal_ratifications/i.test(sql)) {
+      c.goalAsked++;
+      assert.equal(params[0], 100, 'asks about the shipping task');
+      assert.match(sql, /r\.goal_id = t\.goal_id/, 'joined on the task\'s own goal');
+      return { rows: born ? [born] : [] };
+    }
+    return inner(sql, params);
+  };
+  return c;
+}
+
+await test('a task filed under a goal RATIFIED FROM an idea pays that idea, at the full share', async () => {
+  const c = goalStubClient(null, { idea_id: 9, goal_id: 55, captured_by: 4, grade: 'full', completeness: 80 });
+  const r = await credits.awardIdeaTaskShipCredit(c, { taskId: 100, config: ON });
+  assert.equal(r.credited, 4, '5 × 0.80, the same as a lineage task');
+  assert.equal(r.ideaId, 9);
+  assert.equal(c.credited[0].builder_id, 4);
+  assert.equal(c.credited[0].reason, 'idea.credit.task_ship:9:100', 'the stream-1 key, so size and the trail count it');
+  const again = await credits.awardIdeaTaskShipCredit(c, { taskId: 100, config: ON });
+  assert.equal(again.credited, 0, 'once per (idea, task)');
+});
+
+await test('a lineage row WINS: the goal is not asked and its idea is not paid as well', async () => {
+  const c = goalStubClient({ idea_id: 7, captured_by: 3, grade: 'full', completeness: 80 },
+    { idea_id: 9, goal_id: 55, captured_by: 4, grade: 'full', completeness: 80 });
+  const r = await credits.awardIdeaTaskShipCredit(c, { taskId: 100, config: ON });
+  assert.equal(r.ideaId, 7);
+  assert.equal(c.goalAsked, 0);
+  assert.equal(c.credited.length, 1);
+});
+
+await test('a goal no idea was ratified into pays nothing', async () => {
+  const c = goalStubClient(null, null);
+  const r = await credits.awardIdeaTaskShipCredit(c, { taskId: 100, config: ON });
+  assert.equal(r.reason, 'no_source_idea');
+  assert.equal(c.goalAsked, 1);
+});
+
 console.log(`\nidea_task_ship_credit: ${passed} passed, ${failed} failed`);
 if (failed > 0) process.exit(1);

package/tests/profile_earnings.mjs

@@ -47,7 +47,7 @@ await test('a descent hop is told from a direct payout by the WRITER\'s own word
   const src = fs.readFileSync(path.join(ROOT, 'modules/economy/credits.js'), 'utf8');
   // the descent writer and the direct writer, by their own describe() lines
   const descent = src.match(/describe: \(p\) => `Task #\$\{taskId\} shipped \$\{depth\} hop[^\n]*/);
-  const direct = src.match(/describe: \(p\) => `Task #\$\{taskId\} shipped under idea[^\n]*/);
+  const direct = src.match(/describe: \(p\) => `Task #\$\{taskId\} shipped under [^\n]*/); // "under idea" or, since task 1004442, "under goal …, ratified from idea"
   assert.ok(descent && direct, 'both writers are where this test reads them');
   assert.ok(descent[0].includes(earnings.DESCENT_MARK.trim()), 'the descent writer says DESCENT_MARK');
   assert.ok(!direct[0].includes(earnings.DESCENT_MARK.trim()), 'and the direct one does not, or every idea payout would read as descent');