@bongos/core 1.21.8 → 1.21.10

package/docs/copy-registry.json

@@ -3,17 +3,17 @@
   "generator": "scripts/gds/copy-inventory.js",
   "goal": 1000074,
   "counts": {
-    "strings": 2436,
-    "unique_ids": 2106,
-    "certain": 2436,
+    "strings": 2417,
+    "unique_ids": 2091,
+    "certain": 2417,
     "heuristic": 0,
-    "duplicate_ids": 222
+    "duplicate_ids": 220
   },
   "surfaces": {
     "builders-hall": {
       "at": "modules/hall-ui/public",
       "files": 125,
-      "strings": 1769
+      "strings": 1751
     },
     "status-dashboard": {
       "at": "modules/status-ui/public",
@@ -23,7 +23,7 @@
     "landing": {
       "at": "modules/public-landing/public",
       "files": 6,
-      "strings": 567
+      "strings": 566
     }
   },
   "blind_spots": [
@@ -368,28 +368,6 @@
         "modules/public-landing/public/projects.html:883"
       ]
     },
-    {
-      "id": "ed3e9f97ed31",
-      "surface": "builders-hall",
-      "text": ", not a",
-      "occurrences": 3,
-      "at": [
-        "modules/hall-ui/public/studio.html:92",
-        "modules/hall-ui/public/thinking.html:40",
-        "modules/hall-ui/public/tweak-editor.html:49"
-      ]
-    },
-    {
-      "id": "20b0408512ae",
-      "surface": "builders-hall",
-      "text": ": the shell's top bar is the page's one",
-      "occurrences": 3,
-      "at": [
-        "modules/hall-ui/public/studio.html:92",
-        "modules/hall-ui/public/thinking.html:41",
-        "modules/hall-ui/public/tweak-editor.html:49"
-      ]
-    },
     {
       "id": "08afb1257b71",
       "surface": "builders-hall",
@@ -2422,15 +2400,6 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
-    {
-      "id": "1ee8125b806c",
-      "surface": "builders-hall",
-      "text": "(README \"Where the screens live\"; task 1004526 builds them). A pin opens the matter's short card (task 1004528 makes it act). The drawing is street-draw.js (the prototype's front-on kit, verbatim, as pure data) over city-draw.js (the glyphs and the seeded random, shared with the city); street.js reads the feeds and builds the nodes; street.css is the template's",
-      "file": "modules/hall-ui/public/street.html",
-      "line": 31,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "af615fa9f404",
       "surface": "builders-hall",
@@ -2440,15 +2409,6 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
-    {
-      "id": "544794f1ec8f",
-      "surface": "builders-hall",
-      "text": "(later in",
-      "file": "modules/hall-ui/public/index.html",
-      "line": 9,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "3ac2eb36ba97",
       "surface": "builders-hall",
@@ -2476,15 +2436,6 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
-    {
-      "id": "04e34924e1c4",
-      "surface": "builders-hall",
-      "text": ") to where its interior lives — /builders/street#building=",
-      "file": "modules/hall-ui/public/street.html",
-      "line": 30,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "c81e3a97b531",
       "surface": "builders-hall",
@@ -2575,33 +2526,6 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
-    {
-      "id": "ed3e9f97ed31",
-      "surface": "builders-hall",
-      "text": ", not a",
-      "file": "modules/hall-ui/public/studio.html",
-      "line": 92,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
-    {
-      "id": "ed3e9f97ed31",
-      "surface": "builders-hall",
-      "text": ", not a",
-      "file": "modules/hall-ui/public/thinking.html",
-      "line": 40,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
-    {
-      "id": "ed3e9f97ed31",
-      "surface": "builders-hall",
-      "text": ", not a",
-      "file": "modules/hall-ui/public/tweak-editor.html",
-      "line": 49,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "741e355954ac",
       "surface": "builders-hall",
@@ -2611,15 +2535,6 @@
       "origin": "html-text",
       "confidence": "certain"
     },
-    {
-      "id": "6025eb36b204",
-      "surface": "builders-hall",
-      "text": ", not the prototype's",
-      "file": "modules/hall-ui/public/city.html",
-      "line": 31,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "b31a6bd7edc5",
       "surface": "builders-hall",
@@ -2629,15 +2544,6 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
-    {
-      "id": "cc4fe2daf372",
-      "surface": "builders-hall",
-      "text": ", so the brand is a",
-      "file": "modules/hall-ui/public/goal-map.html",
-      "line": 66,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "c7c9b0afc38e",
       "surface": "builders-hall",
@@ -2647,15 +2553,6 @@
       "origin": "html-text",
       "confidence": "certain"
     },
-    {
-      "id": "7a8111edba0a",
-      "surface": "builders-hall",
-      "text": ", which is a containing block for its position: fixed layers (thinking.css), so the template's fixed layout is unchanged and simply measures from the stage instead of the window. The sky's heading is a",
-      "file": "modules/hall-ui/public/thinking.html",
-      "line": 37,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "24174ce79df3",
       "surface": "builders-hall",
@@ -2701,33 +2598,6 @@
       "origin": "html-text",
       "confidence": "certain"
     },
-    {
-      "id": "20b0408512ae",
-      "surface": "builders-hall",
-      "text": ": the shell's top bar is the page's one",
-      "file": "modules/hall-ui/public/studio.html",
-      "line": 92,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
-    {
-      "id": "20b0408512ae",
-      "surface": "builders-hall",
-      "text": ": the shell's top bar is the page's one",
-      "file": "modules/hall-ui/public/thinking.html",
-      "line": 41,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
-    {
-      "id": "20b0408512ae",
-      "surface": "builders-hall",
-      "text": ": the shell's top bar is the page's one",
-      "file": "modules/hall-ui/public/tweak-editor.html",
-      "line": 49,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "353fff36068f",
       "surface": "builders-hall",
@@ -2737,15 +2607,6 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
-    {
-      "id": "2a5aa36f4d29",
-      "surface": "builders-hall",
-      "text": "; the sky's first build made only the BRAND the header (the kit's top-bar-80px floor). In the hall the shell's top bar is the page's header, so the brand is a",
-      "file": "modules/hall-ui/public/thinking.html",
-      "line": 66,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "8ffdf4995e81",
       "surface": "builders-hall",
@@ -14851,15 +14712,6 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
-    {
-      "id": "c1367ee35fec",
-      "surface": "builders-hall",
-      "text": "and #district=",
-      "file": "modules/hall-ui/public/street.html",
-      "line": 31,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "754babaae931",
       "surface": "builders-hall",
@@ -15607,15 +15459,6 @@
       "origin": "html-text",
       "confidence": "certain"
     },
-    {
-      "id": "af0777cd098b",
-      "surface": "builders-hall",
-      "text": "is hardcoded back inside this",
-      "file": "modules/hall-ui/public/index.html",
-      "line": 60,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "d0e722302840",
       "surface": "builders-hall",
@@ -15625,15 +15468,6 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
-    {
-      "id": "aa530bd15088",
-      "surface": "builders-hall",
-      "text": "itself). The registry stays the single source of truth for what the hall shows; a fitness check (scripts/gds/fitness.js checkHallSectionRegistry) reds the build if a",
-      "file": "modules/hall-ui/public/index.html",
-      "line": 57,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "6b530a7007bc",
       "surface": "builders-hall",
@@ -16021,15 +15855,6 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
-    {
-      "id": "8e888f28b08f",
-      "surface": "builders-hall",
-      "text": "on the hall's tokens. The button is a link to /builders/street, the street's own hall page, which task 1004525 builds. It is an",
-      "file": "modules/hall-ui/public/city.html",
-      "line": 27,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "f5a9579bbc36",
       "surface": "builders-hall",
@@ -16318,15 +16143,6 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
-    {
-      "id": "594962dc9ec3",
-      "surface": "builders-hall",
-      "text": "s into the view containers below (falling back to",
-      "file": "modules/hall-ui/public/index.html",
-      "line": 56,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "2a42549b34ae",
       "surface": "builders-hall",
@@ -22942,15 +22758,6 @@
       "origin": "html-text",
       "confidence": "certain"
     },
-    {
-      "id": "c50f6ad6e51e",
-      "surface": "landing",
-      "text": "shipped on",
-      "file": "modules/public-landing/public/index.html",
-      "line": 634,
-      "origin": "html-text",
-      "confidence": "certain"
-    },
     {
       "id": "d06d9d2f5fb7",
       "surface": "landing",

package/docs/module-api-changelog.md

@@ -2843,5 +2843,9 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.21.6 with no explicit bump. run 37038340446. (task 1002620)
   1.21.8 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.21.7 with no explicit bump. run 37041143274. (task 1002620)
+  1.21.9 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.21.8 with no explicit bump. run 37042188671. (task 1002620)
+  1.21.10 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.21.9 with no explicit bump. run 37048132870. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/discord/board-broadcast.js

@@ -149,6 +149,8 @@ const CHANNEL = 'board_room';
 
 function subjectLabel(subjectType) {
   if (subjectType === 'genesis_stage') return 'A genesis stage'; // task 1004429
+  // task 1004529: a building's matter (rules_matter, people_matter, ...)
+  if (typeof subjectType === 'string' && subjectType.endsWith('_matter')) return 'A matter';
   return subjectType === 'constitutional_amendment' ? 'A constitutional amendment' : 'A Full Idea';
 }
 

package/modules/government/board.js

@@ -61,6 +61,8 @@ const { describeMembership } = require('./membership-predicate');
 // and variable names, and the name a constitution reads as.
 const charter = require('./charter');
 const recommendations = require('./recommendations');
+const decisionRules = require('./decision-rules');
+const decisionBoard = require('./decision-board');
 
 // ADR 0175 §5: the completeness bar a Full Idea must clear to reach the board.
 // Held equal to economy's IDEA_FULL_PASS_BAR by test — see the header.
@@ -296,7 +298,7 @@ async function castVote({ itemId, voterId, direction, reasonMd = null, sectionKe
   // owner's rule is that a self-vote confers no advantage.
   // Not even asked for an amendment — the carve-out means there is nothing to
   // learn, and the read is a query on the vote path.
-  const subjectAuthorId = authorRuleApplies(item.subject_type)
+  const subjectAuthorId = authorRuleApplies(item.subject_type, constitution)
     ? await db.getBoardItemAuthor(item)
     : null;
   const isSelfCast = subjectAuthorId != null && String(subjectAuthorId) === String(voterId);
@@ -389,12 +391,17 @@ async function castVote({ itemId, voterId, direction, reasonMd = null, sectionKe
 // Everything downstream reads the author through this: for an amendment the
 // deciding author is NULL, so the trigger and the tally behave exactly as they
 // did before task 1003273.
-const authorRuleApplies = (subjectType) => subjectType === 'full_idea';
-
-// The author id that the DECIDING rules should see: the real one for a full
-// idea, nobody for an amendment.
-const decidingAuthorId = (subjectType, authorId) =>
-  (authorRuleApplies(subjectType) ? authorId : null);
+// One more scope (task 1004529): a building's matter sat under SIGN-OFF, which
+// IS the author rule (someone who did not build it signs). Other matters are in
+// the amendment's position.
+const authorRuleApplies = (subjectType, constitution = null) =>
+  subjectType === 'full_idea'
+  || (decisionRules.isMatterSubject(subjectType) && !!constitution && constitution.rule === 'signoff');
+
+// The author id the DECIDING rules see: real for a full idea or a sign-off
+// matter, nobody for an amendment.
+const decidingAuthorId = (subjectType, authorId, constitution = null) =>
+  (authorRuleApplies(subjectType, constitution) ? authorId : null);
 
 const isAuthorVote = (v, authorId) =>
   authorId != null && String(v.voter_id) === String(authorId);
@@ -581,7 +588,7 @@ async function closeItem(item, { cause = 'vote' } = {}) {
   // the read stays where it always was — after the tally, only on a pass, for the
   // payload and the ratification karma. Same query count as before this task on
   // the amendment path, one extra on an idea close.
-  let authorId = authorRuleApplies(item.subject_type)
+  let authorId = authorRuleApplies(item.subject_type, constitution)
     ? await db.getBoardItemAuthor(item)
     : null;
   // Only `majority` needs the membership denominator; the absence-passes rules
@@ -596,7 +603,7 @@ async function closeItem(item, { cause = 'vote' } = {}) {
   const outcome = tallyOutcome(votes, {
     constitution, members,
     // Subject-typed: an amendment's proposer is not held to the author rule (§7).
-    authorId: decidingAuthorId(item.subject_type, authorId),
+    authorId: decidingAuthorId(item.subject_type, authorId, constitution),
   });
 
   // The payload's remaining reads (reads never ride a tx they don't need). Only a
@@ -616,16 +623,28 @@ async function closeItem(item, { cause = 'vote' } = {}) {
     : null;
   const payMoney = reward && typeof reward.awardIdeaGovernancePassCredit === 'function';
 
+  // Read BEFORE the close (task 1004529): a decision-rules amendment is written
+  // INSIDE the closing transaction, so a failed write rolls the close back and
+  // the sitting is retried. A board-block amendment still applies after commit.
+  const amendment = outcome === 'passed' && item.subject_type === 'constitutional_amendment'
+    ? await db.getAmendment(item.subject_id)
+    : null;
+  const rulesAmendment = !!amendment && amendment.kind === 'decision_rules';
+  let appliedDecisionRules = null;
+
   const closed = await db.closeBoardItem({
     itemId: item.id,
     outcome,
-    afterClose: payMoney
-      ? async (client) => {
-          credit = await reward.awardIdeaGovernancePassCredit(client, {
-            ideaId: item.subject_id,
-            authorId,
-            completenessScore,
-          });
+    afterClose: (payMoney || rulesAmendment)
+      ? async (client, closedRow) => {
+          if (payMoney) {
+            credit = await reward.awardIdeaGovernancePassCredit(client, {
+              ideaId: item.subject_id,
+              authorId,
+              completenessScore,
+            });
+          }
+          if (rulesAmendment) appliedDecisionRules = await decisionBoard.applyPassedDecisionRules(client, closedRow, amendment);
         }
       : null,
   });
@@ -633,8 +652,10 @@ async function closeItem(item, { cause = 'vote' } = {}) {
 
   // A genesis stage ratifies no authored work — closing it is the project's
   // decision that a stage is done, not a reward for the founder who put it up
-  // (task 1004429). Ideas and amendments pay exactly as before.
+  // (task 1004429). Ideas and amendments pay exactly as before; a building's
+  // matter pays nothing either (task 1004529).
   const authorKarma = outcome === 'passed' && closed.subject_type !== 'genesis_stage'
+    && !decisionRules.isMatterSubject(closed.subject_type)
     ? await awardAuthorRatifyKarma(closed)
     : null;
 
@@ -643,9 +664,8 @@ async function closeItem(item, { cause = 'vote' } = {}) {
   // failure, never silently absorbed. The apply is re-drivable from the passed
   // item + amendment rows. A returned amendment applies nothing.
   let appliedConstitution = null;
-  if (outcome === 'passed' && closed.subject_type === 'constitutional_amendment') {
+  if (outcome === 'passed' && closed.subject_type === 'constitutional_amendment' && !rulesAmendment) {
     try {
-      const amendment = await db.getAmendment(closed.subject_id);
       if (amendment) {
         appliedConstitution = governmentConfig.applyBoardAmendment(amendment.proposed);
       } else {
@@ -656,12 +676,21 @@ async function closeItem(item, { cause = 'vote' } = {}) {
     }
   }
 
+  // A PASSED building matter: the building acts where it can by itself (People
+  // giving or taking a custom rank, task 1004529), after the commit, loudly on
+  // failure — the passed row is the durable decision.
+  let acted = null;
+  if (outcome === 'passed' && decisionRules.isMatterSubject(closed.subject_type)) {
+    acted = await decisionBoard.actOnPassedMatter(closed);
+  }
+
   if (outcome === 'passed') {
     const payload = passPayload(closed, { authorId, completenessScore, passedAt: closed.closed_at });
     try {
       if (api.emitAsync) await api.emitAsync('board.item.passed', payload);
     } catch (_) { /* emitAsync isolates listener errors; nothing that moves credits subscribes */ }
     if (closed.subject_type === 'genesis_stage') await emitGenesisStagePassed(closed);
+    if (acted) await decisionBoard.announcePassedMatter(acted);
   }
 
   // R22's mirror event: BOTH outcomes, after commit, emitAsync. Separate from
@@ -678,6 +707,8 @@ async function closeItem(item, { cause = 'vote' } = {}) {
     closed: true, item: closed, outcome, cause, author_karma: authorKarma,
     ...(credit ? { credit } : {}),
     ...(appliedConstitution ? { applied_constitution: appliedConstitution } : {}),
+    ...(appliedDecisionRules ? { applied_decision_rules: appliedDecisionRules } : {}),
+    ...(acted ? { acted: acted.result } : {}),
   };
 }
 
@@ -692,7 +723,7 @@ async function maybeCloseAfterVote(itemId) {
   const members = await resolveBoardMembers(constitution);
   // task 1003273: the author is an input to the trigger, not just the tally — an
   // author's cast must never be the vote that ends the sitting.
-  const authorId = authorRuleApplies(item.subject_type)
+  const authorId = authorRuleApplies(item.subject_type, constitution)
     ? await db.getBoardItemAuthor(item)
     : null;
   if (!shouldCloseAfterVote({ constitution, votes, members, authorId })) {
@@ -866,6 +897,17 @@ async function proposeCharter({
   return out.ok ? { ...out, reads_as: readsAs } : out;
 }
 
+// ── who decides what (task 1004529, ADR 0363) ───────────────────────────────
+// The board side lives in decision-board.js; these wrappers add the window-open
+// nudge every open emits.
+const withOpenNudge = (fn) => async (args) => {
+  const out = await fn(args);
+  if (out.ok && out.item) await emitWindowOpened(out.item);
+  return out;
+};
+const proposeDecisionRules = withOpenNudge((a) => decisionBoard.proposeDecisionRules(a));
+const openMatter = withOpenNudge((a) => decisionBoard.openMatter(a));
+
 // ── the board's third subject: closing a genesis stage (task 1004429) ───────
 //
 // Spec decision D7 (docs/specs/bongos-v2-project-startup.md): a new project is
@@ -1071,9 +1113,10 @@ async function boardRoomView({ closedLimit = 20 } = {}) {
   const votes = await db.getVotesForItems(all.map((i) => i.id));
   const ideaIds = [...new Set(all.filter((i) => i.subject_type === 'full_idea').map((i) => i.subject_id))];
   const amendmentIds = [...new Set(all.filter((i) => i.subject_type === 'constitutional_amendment').map((i) => i.subject_id))];
-  const [ideas, amendments] = await Promise.all([
+  const [ideas, amendments, matterById] = await Promise.all([
     db.getIdeaSubjects(ideaIds),
     db.getAmendmentSubjects(amendmentIds),
+    decisionBoard.matterSubjectsById(all), // task 1004529: no query when no matter is on the board
   ]);
   const ideaById = new Map(ideas.map((r) => [String(r.id), r]));
   const amendmentById = new Map(amendments.map((r) => [String(r.id), r]));
@@ -1118,7 +1161,9 @@ async function boardRoomView({ closedLimit = 20 } = {}) {
             recommendation: r.recommendation ?? null,
           } : null;
         })()
-      : (() => { const r = amendmentById.get(String(item.subject_id)); return r ? { proposed: r.proposed, rationale_md: r.rationale_md, author_id: r.proposed_by == null ? null : String(r.proposed_by) } : null; })();
+      : decisionRules.isMatterSubject(item.subject_type)
+      ? decisionBoard.projectMatterSubject(matterById.get(String(item.subject_id)))
+      : (() => { const r = amendmentById.get(String(item.subject_id)); return r ? { proposed: r.proposed, rationale_md: r.rationale_md, ...(r.kind ? { kind: r.kind } : {}), author_id: r.proposed_by == null ? null : String(r.proposed_by) } : null; })();
     return {
       id: String(item.id),
       subject_type: item.subject_type,
@@ -1226,7 +1271,9 @@ async function constitutionView({ historyLimit = 50, type = null, headcount: ask
     closed_at: r.closed_at,
     outcome: r.outcome,
     decided_under: r.decided_under || null,
+    kind: r.kind || 'constitution',
   }));
+  const rulesTable = await decisionBoard.decisionRulesFor(live); // task 1004529; null if unreadable
   return {
     board: live,
     history,
@@ -1244,7 +1291,11 @@ async function constitutionView({ historyLimit = 50, type = null, headcount: ask
     // `historyLimit` in principle; a board with 50 amendments newer than its
     // last passed one is not a shape this system has, and the honest failure
     // there is a missed warning rather than a wrong one.
-    divergence: constitutionDivergence(live, history),
+    // Only board-block amendments say what the board block should be (a rules
+    // amendment changes the table, task 1004529).
+    divergence: constitutionDivergence(live, history.filter((h) => h.kind !== 'decision_rules')),
+    // Who decides what at each building, as today or set by a passed amendment.
+    decision_rules: decisionBoard.constitutionBlock(rulesTable),
     // The genesis charter + legislation stages' payload (task 1004427): every
     // form and variable by its real name with its plain explanation, and the
     // form the constitution in force reads as (or Custom). Pure — no query.
@@ -1400,6 +1451,14 @@ async function pendingVotesFor(builderId) {
 }
 
 module.exports = {
+  proposeDecisionRules,
+  openMatter,
+  decisionRulesView: (...a) => decisionBoard.decisionRulesView(...a),
+  decisionRulesWriteAllowed: decisionBoard.decisionRulesWriteAllowed,
+  applyPassedDecisionRules: decisionBoard.applyPassedDecisionRules,
+  validateMatterAction: decisionBoard.validateMatterAction,
+  checkActAlone: (...a) => decisionBoard.checkActAlone(...a),
+  authorRuleApplies,
   GENESIS_STAGES,
   PASS_RULE_WORDS,
   proposeCharter,