@bongos/core 1.21.66 → 1.21.68

package/tests/landing_page.mjs

@@ -35,6 +35,7 @@ import { test } from 'node:test';
 import assert from 'node:assert/strict';
 import fs from 'node:fs';
 import path from 'node:path';
+import vm from 'node:vm';
 import { fileURLToPath } from 'node:url';
 import { createRequire } from 'node:module';
 
@@ -566,15 +567,16 @@ test('the Projects band deep-links the hub\'s views; About and Docs are footer l
   assert.doesNotMatch(body.split('<main')[0], /aria-current/, 'the landing is none of those views');
   // the profile band: the person, My projects, Account, Sign out as the honest anchor.
   // Account fills the slot that waited for a settings page (task 1004259) and is
-  // apex-only, because /account is served only where platform-identity runs.
+  // apex-only, because /account is served only where platform-identity runs; so is
+  // Invitations, in the same region, for /invitations (task 1004276).
   assert.match(body, /<div class="menuBand" id="menuProfile" data-menu="profile" hidden>/);
   assert.match(body, /<p class="bandWho" id="bandWho"><\/p>/);
   assert.match(body, /<a class="bandT" href="\/projects\?view=mine">My projects<\/a>/);
-  assert.match(body, /<!--apex-only:start--><li class="bandCell"><a class="bandT" href="\/account">Account<\/a><\/li><!--apex-only:end-->/);
+  assert.match(body, /<!--apex-only:start--><li class="bandCell"><a class="bandT" href="\/invitations">Invitations<\/a><\/li><li class="bandCell"><a class="bandT" href="\/account">Account<\/a><\/li><!--apex-only:end-->/);
   assert.doesNotMatch(body, /class="bandSlot"/, 'the slot is filled, not kept beside its item');
   assert.match(body, /<a class="bandT signout" href="\/api\/bongos\/auth\/logout">Sign out<\/a>/);
   // a crawler reads every destination without scripting on
-  for (const copy of ['Sky', 'Table', 'Your projects', 'New project', 'About', 'Docs', 'My projects', 'Account', 'Sign out']) {
+  for (const copy of ['Sky', 'Table', 'Your projects', 'New project', 'About', 'Docs', 'My projects', 'Invitations', 'Account', 'Sign out']) {
     assert.ok(body.includes('>' + copy + '<'), `"${copy}" is only reachable with scripting on`);
   }
   // the menu container is .menuBand: .band is this page's own content sections
@@ -614,3 +616,123 @@ test('the retired gate assets (world/assets/clouds|creatures|plates) are gone
   // the chrome landing's own plates (task 1003298) live at assets/world/ and are untouched by this cleanup
   assert.ok(fs.existsSync(path.join(LANDING, 'assets', 'world', 'r2-bongos-chrome-b.jpg')), 'the chrome plate at assets/world/ is untouched (task 1003649 converts it separately)');
 });
+
+// ── the CLI download (task 1004257) ─────────────────────────────────────────
+// A door that only exists where a release does: /downloads/bongos/* mounts only when the
+// instance has config/bongos-cli.json, and cloudbongos.com had none when this shipped, so a
+// baked link would have been a door to a 404. The block is markup, hidden, and the release
+// feed is what opens it. The platform pick is RUN below in a vm, not read.
+
+const CLOSE = HTML.replace(/\r\n/g, '\n').split('<section class="band close">')[1].split('</section>')[0];
+const CODE_LF = CODE.replace(/\r\n/g, '\n');
+const CLI_JS = CODE_LF.slice(CODE_LF.indexOf('var CLI_NAMES'), CODE_LF.indexOf('box.hidden = false;\n  });') + 'box.hidden = false;\n  });'.length);
+
+test('the CLI block is markup in the closing band, hidden, with a door that has no target until the feed names one', () => {
+  assert.match(CLOSE, /<div class="cli" data-cli hidden>/, 'baked hidden: no release, no door');
+  const get = CLOSE.match(/<a class="door door--solo" data-cli-get([^>]*)>/);
+  assert.ok(get, 'the download door is a door');
+  assert.doesNotMatch(get[1], /href=/, 'no baked href: the page cannot know the release or the platform');
+  assert.match(get[1], /aria-describedby="cliFor"/, 'the door is described by the platform and version it picked');
+  assert.match(CLOSE, /<p class="label" id="cliFor" data-cli-for><\/p>/);
+  assert.match(CLOSE, /<p class="cliAlso" data-cli-also><\/p>/);
+  assert.ok(CLOSE.indexOf('data-cli') > CLOSE.indexOf('class="doorbar"'), 'it sits under the two doors, never beside them');
+  assert.doesNotMatch(HTML.split('<section class="hero">')[1].split('</section>')[0], /data-cli/, 'the hero keeps its two doors');
+  // [hidden] loses to any display rule on the element, so the container must carry none
+  assert.doesNotMatch(PAGE_CSS, /\n\.cli\{[^}]*display/, '.cli sets no display, or [hidden] stops hiding it');
+  assert.match(PAGE_CSS, /\.cliAlso a\{display:inline-block;min-height:24px;/, 'the platform links clear the 24px floor');
+});
+
+test('the CLI feed is the apex release redirect, and every link stays on this origin', () => {
+  assert.ok(CODE.includes("json('/downloads/bongos/latest.json')"), 'the page reads the release feed');
+  assert.match(CLI_JS, /get\.href = '\/downloads\/bongos\/' \+ pick;/);
+  assert.match(CLI_JS, /a\.href = '\/downloads\/bongos\/' \+ k;/);
+  assert.doesNotMatch(CLI_JS, /\.url\b/, 'never the release asset URL: the redirect is how a release bump stays one config file');
+  assert.doesNotMatch(CLI_JS, /innerHTML/);
+});
+
+// run the region in a vm over a DOM stub: the release feed in, the block's state out
+function cliRun({ feed, nav }) {
+  const el = (tag) => ({
+    tag, href: null, hidden: false, textContent: '', children: [], removed: false,
+    appendChild(c) { this.children.push(c); return c; },
+    remove() { this.removed = true; },
+  });
+  const get = el('a');
+  const forEl = el('p');
+  const also = el('p');
+  const box = el('div');
+  box.hidden = true;
+  box.querySelector = (s) => ({ '[data-cli-get]': get, '[data-cli-for]': forEl, '[data-cli-also]': also })[s];
+  let pending;
+  const sandbox = {
+    navigator: nav,
+    document: {
+      querySelector: (s) => (s === '[data-cli]' ? box : null),
+      createElement: el,
+      createTextNode: (t) => ({ tag: '#text', textContent: t }),
+    },
+    json: (url) => { assert.equal(url, '/downloads/bongos/latest.json'); pending = Promise.resolve(feed); return pending; },
+  };
+  vm.runInNewContext(CLI_JS + '\nthis.cliTarget = cliTarget;', sandbox);
+  return pending.then(() => ({ box, get, forEl, also, cliTarget: sandbox.cliTarget }));
+}
+const RELEASE = JSON.parse(fs.readFileSync(path.join(ROOT, 'modules', 'ui-design', 'kit', 'fixtures', 'bongos-cli-latest-sample.json'), 'utf8'));
+const MAC = { userAgent: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.6668.89 Safari/537.36', platform: 'MacIntel', maxTouchPoints: 0 };
+const IPHONE = { userAgent: 'Mozilla/5.0 (iPhone; CPU iPhone OS 17_5 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Mobile/15E148 Safari/604.1', platform: 'iPhone', maxTouchPoints: 5 };
+
+test('with a release, a Mac gets the Apple-silicon door and every other platform beside it', async () => {
+  const r = await cliRun({ feed: RELEASE, nav: MAC });
+  assert.equal(r.box.hidden, false);
+  assert.equal(r.get.removed, false);
+  assert.equal(r.get.href, '/downloads/bongos/mac-arm64');
+  assert.equal(r.forEl.textContent, 'macOS, Apple silicon · v0.4.2');
+  assert.equal(r.also.children[0].textContent, 'Also for');
+  assert.deepEqual(r.also.children.slice(1).map((a) => [a.href, a.textContent]), [
+    ['/downloads/bongos/mac-x64', 'macOS, Intel'],
+    ['/downloads/bongos/linux-x64', 'Linux, x64'],
+    ['/downloads/bongos/linux-arm64', 'Linux, ARM64'],
+    ['/downloads/bongos/win-x64', 'Windows'],
+  ]);
+});
+
+test('a phone gets no guess: no door, the whole list', async () => {
+  const r = await cliRun({ feed: RELEASE, nav: IPHONE });
+  assert.equal(r.box.hidden, false);
+  assert.equal(r.get.removed, true, 'a CLI cannot run on the device that is looking');
+  assert.equal(r.forEl.textContent, 'Download the CLI · v0.4.2');
+  assert.equal(r.also.children[0].textContent, 'For');
+  assert.equal(r.also.children.length, 6);
+});
+
+test('no release (the feed 404s, or answers nothing usable) leaves the block hidden', async () => {
+  for (const feed of [null, {}, { version: '1.0.0' }, { version: '1.0.0', assets: {} }, { assets: 'x' }]) {
+    const r = await cliRun({ feed, nav: MAC });
+    assert.equal(r.box.hidden, true, JSON.stringify(feed));
+    assert.equal(r.get.href, null);
+  }
+});
+
+test('a target key that is not a plain slug never becomes a link; a malformed version is dropped', async () => {
+  const feed = { version: '1.0.0<b>', assets: { '../../etc': {}, 'javascript:x': {}, 'Mac-ARM64': {}, 'linux-x64': {} } };
+  const r = await cliRun({ feed, nav: MAC });
+  assert.equal(r.get.removed, true, 'no Mac build in this release, so no door for a Mac');
+  assert.equal(r.forEl.textContent, 'Download the CLI');
+  assert.deepEqual(r.also.children.slice(1).map((a) => a.href), ['/downloads/bongos/linux-x64']);
+});
+
+test('the platform pick', async () => {
+  const { cliTarget } = await cliRun({ feed: null, nav: MAC });
+  const all = ['mac-arm64', 'mac-x64', 'linux-x64', 'linux-arm64', 'win-x64'];
+  const ua = (s, extra) => Object.assign({ userAgent: s, platform: '', maxTouchPoints: 0 }, extra);
+  assert.equal(cliTarget(MAC, all), 'mac-arm64', 'a Mac: Apple silicon, since a user agent cannot say');
+  assert.equal(cliTarget(MAC, ['mac-x64', 'linux-x64']), 'mac-x64', 'a release with only the Intel build still serves a Mac');
+  assert.equal(cliTarget(ua('Mozilla/5.0 (Windows NT 10.0; Win64; x64)', { platform: 'Win32' }), all), 'win-x64');
+  assert.equal(cliTarget(ua('Mozilla/5.0 (X11; Linux x86_64)', { platform: 'Linux x86_64' }), all), 'linux-x64');
+  assert.equal(cliTarget(ua('Mozilla/5.0 (X11; Linux aarch64)', { platform: 'Linux aarch64' }), all), 'linux-arm64');
+  assert.equal(cliTarget(ua('Mozilla/5.0 (X11; CrOS x86_64 14541.0.0)'), all), 'linux-x64', 'ChromeOS runs the Linux build');
+  assert.equal(cliTarget(ua('x', { userAgentData: { platform: 'macOS', mobile: false } }), all), 'mac-arm64', 'client hints are read first');
+  assert.equal(cliTarget(ua('Mozilla/5.0 (Linux; Android 14; Pixel 8) Mobile', { platform: 'Linux armv8l' }), all), null, 'Android says Linux and is not');
+  assert.equal(cliTarget(IPHONE, all), null);
+  assert.equal(cliTarget(Object.assign({}, MAC, { maxTouchPoints: 5 }), all), null, 'an iPad reports a Mac; touch gives it away');
+  assert.equal(cliTarget(ua('Mozilla/5.0 (Windows NT 10.0; Win64; x64)'), ['mac-arm64']), null, 'nothing built for this platform: no guess');
+});

package/tests/my_projects_surface.mjs

@@ -21,9 +21,10 @@
 //      audit could not confirm, so it is asserted here rather than described.
 //   3. WHAT WAS STILL MISSING. The invitations half had no caller anywhere — no
 //      surface fetched the invite list, so a builder holding an invitation could
-//      not act on it. Closed by task 1003774: the hub's /projects?view=mine now
-//      reads GET /my-projects/invites (idea 1000903). The pin below flipped from
-//      "no surface calls this" to "some surface does" for the same reason.
+//      not act on it. Closed by task 1003774, which put the list in the hub's
+//      /projects?view=mine (idea 1000903); task 1004276 moved it to the hub's own
+//      /invitations page. The pin below flipped from "no surface calls this" to
+//      "some surface does" for the same reason.
 //
 // Static reads only (no import of the app, no DB) → runs in the `unit` gate.
 //
@@ -116,10 +117,17 @@ test('an invitations surface exists — the hub reads GET /my-projects/invites (
 // dead end the moment a caller exists to press it. Each invite renders as a
 // way IN (a link to the project) instead — signing in there is the acceptance
 // act (task 1002969).
+// Both hub pages: /invitations holds the invite list now (task 1004276), and
+// /projects is where it lived and where a regression could put a caller back.
+const HUB_PAGES = ['modules/public-landing/public/invitations.html', 'modules/public-landing/public/projects.html'];
 test('the hub never calls the accept route — ADR 0335 retired that flip', () => {
-  const html = read('modules/public-landing/public/projects.html');
-  assert.doesNotMatch(html, /invites\/[^'"]*\/accept/,
-    'a hub caller of the accept route reopens the dead end ADR 0335 closed — render the invite as a link into the project instead');
+  for (const rel of HUB_PAGES) {
+    assert.doesNotMatch(read(rel), /invites\/[^'"]*\/accept/,
+      `${rel}: a hub caller of the accept route reopens the dead end ADR 0335 closed — render the invite as a link into the project instead`);
+  }
+  // the guard is only meaningful where the invite list is: it must be on one of these pages
+  assert.ok(HUB_PAGES.some((rel) => read(rel).includes("'/my-projects/invites'")),
+    'the invite list moved off both hub pages — point this guard at wherever it went');
 });
 
 // Task 1002818 (ADR 0353) finished the retirement on the server: the route is gone,

package/tests/public_landing_projects.mjs

@@ -521,28 +521,26 @@ test('a stamped asset still serves — the query string is not part of the filen
 // nowhere to live until now. loadMemberships() already fetched GET /my-projects
 // for the map's Apply button (R10, task 1002286) — this just renders the rest
 // of what that same read carries, plus the separate invites list.
-test('#view-mine reads the invitations list, alongside the building-on and join surfaces', async () => {
+// The invitations and the join-by-address field moved to their own page with task
+// 1004276 (the owner's call, ADR 0337 D5); tests/hub_invitations_page.mjs holds that
+// page as served. What stays here: building-on with Leave, and a door to the page.
+test('#view-mine keeps building-on with Leave, and points at /invitations for the invitations and the join field', async () => {
   const { body } = await request('/projects', 'game.test.local');
-  assert.match(body, /\/my-projects\/invites/, 'GET /my-projects/invites must be called');
-  assert.match(body, /id="invitesList"/);
   assert.match(body, /id="buildingList"/);
-  assert.match(body, /\/my-projects\/join/, 'the join-by-URL field must post to /my-projects/join');
-  assert.match(body, /id="joinOrigin"/);
-  assert.match(body, /id="joinNote"/, 'the applicant note (task 1002330) rides along, and stays optional');
   assert.match(body, /\/my-projects\/'\s*\+\s*encodeURIComponent/, 'Leave must address the project by its own client id');
-  assert.match(body, /origin = 'https:\/\/' \+ origin/,
-    'a bare host ("grove.cloudbongos.com") must be assumed https:// rather than sent as-is — the server\'s origin lookup is an exact match');
+  for (const gone of ['invitesList', 'guildInviteList', 'engageList', 'guildRequestList', 'joinOrigin', 'joinNote', 'joinBtn', 'mineInvites']) {
+    assert.doesNotMatch(body, new RegExp(`id="${gone}"`), `#${gone} moved to /invitations`);
+  }
+  assert.doesNotMatch(body, /\/my-projects\/invites/, 'the invitations are read on their own page now');
+  assert.match(body, /<h2 id="mineToInvitesH">Invitations<\/h2>\s*<p class="lede">[^<]*<a href="\/invitations">Open your invitations<\/a><\/p>/, 'the mine view says where they went');
+  assert.match(body, /\/my-projects\/join/, 'the map card’s Apply to join still posts the join relay');
 });
 
-test('an invite renders as a way INTO the project, never the retired accept flip (ADR 0335)', async () => {
+test('the hub never calls the retired accept flip (ADR 0335)', async () => {
   const { body } = await request('/projects', 'game.test.local');
   // the hub-only accept flip never admits anyone to the project's own instance
-  // (ADR 0335) — a caller of it here would reopen the exact dead end that ADR
-  // retired, so the invite's action is an outbound link instead
+  // (ADR 0335) — a caller of it here would reopen the exact dead end that ADR retired
   assert.doesNotMatch(body, /invites\/[^'"]*\/accept/, 'no caller of the retired hub accept route');
-  assert.match(body, /Open project/, 'the invite links into the project — signing in there is the acceptance act');
-  assert.match(body, /'\/my-projects\/invites\/' \+ encodeURIComponent\([^)]+\) \+ '\/decline'/,
-    'decline still works: it only clears the hub\'s own pending row');
 });
 
 test('the map card\'s Apply button reads as truly inert once applied, with a live status region (R10 fixups)', async () => {

package/tests/render_check.mjs

@@ -24,8 +24,9 @@ test('a shared asset reaches every page in its dir whose HTML names it', () => {
   // sky-data.js is shared by the two doors of one page (task 1004232): /thinking and /goal-map.
   assert.deepEqual(names(['modules/hall-ui/public/sky-data.js']), ['goal-map.states.json', 'thinking.states.json']);
   assert.deepEqual(names(['modules/hall-ui/public/text-fit.js']), ['goals.states.json']);
-  // the account page links the hub's sheet too since task 1004259, and the guild page since task 1002301
-  assert.deepEqual(names(['modules/public-landing/public/assets/cosmos.css']), ['account.states.json', 'guild.states.json', 'projects.states.json']);
+  // the account page links the hub's sheet too since task 1004259, the guild page since task 1002301,
+  // and the invitations page since task 1004276
+  assert.deepEqual(names(['modules/public-landing/public/assets/cosmos.css']), ['account.states.json', 'guild.states.json', 'invitations.states.json', 'projects.states.json']);
 });
 
 test('the page a builder changed comes before the pages a shared file reaches, so the render cap never drops it', () => {

package/tests/ui_design_kit.mjs

@@ -34,7 +34,7 @@ test('the platform floors are a pinned list — a floor cannot vanish quietly',
 });
 
 test('the shipped states files validate and sit beside the page they name', () => {
-  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/projects-empty.states.json', 'modules/public-landing/public/projects-dns-pending.states.json', 'modules/public-landing/public/projects-hall-live.states.json','modules/public-landing/public/index.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/account-private.states.json', 'modules/public-landing/public/guild.states.json', 'modules/hall-ui/public/ranks.states.json']) {
+  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/projects-empty.states.json', 'modules/public-landing/public/projects-dns-pending.states.json', 'modules/public-landing/public/projects-hall-live.states.json','modules/public-landing/public/index.states.json', 'modules/public-landing/public/index-cli.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/account-private.states.json', 'modules/public-landing/public/guild.states.json', 'modules/public-landing/public/invitations.states.json', 'modules/public-landing/public/invitations-empty.states.json', 'modules/public-landing/public/invitations-picker.states.json', 'modules/hall-ui/public/ranks.states.json']) {
     const json = readJson(rel);
     const v = lib.validateStatesFile(json);
     assert.deepEqual(v.errors, [], `${rel}: ${v.errors.join('; ')}`);
@@ -43,14 +43,14 @@ test('the shipped states files validate and sit beside the page they name', () =
   }
   // the apex is dark only (task 1003336): its states files name the one mode, and
   // render.js reads it as the default so a plain `--page /` never renders light
-  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/index.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/guild.states.json']) {
+  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/index.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/guild.states.json', 'modules/public-landing/public/invitations.states.json']) {
     assert.deepEqual(readJson(rel).modes, ['dark'], `${rel}: the apex renders dark only`);
     assert.equal(readJson(rel).modeQuery, false, `${rel}: no query walks a second mode`);
   }
 });
 
 test('the shipped probes files validate', () => {
-  for (const rel of ['modules/public-landing/public/projects.probes.json', 'modules/public-landing/public/index.probes.json', 'modules/public-landing/public/account.probes.json', 'modules/public-landing/public/guild.probes.json']) {
+  for (const rel of ['modules/public-landing/public/projects.probes.json', 'modules/public-landing/public/index.probes.json', 'modules/public-landing/public/account.probes.json', 'modules/public-landing/public/guild.probes.json', 'modules/public-landing/public/invitations.probes.json']) {
     const v = lib.validateProbesFile(readJson(rel));
     assert.deepEqual(v.errors, [], `${rel}: ${v.errors.join('; ')}`);
   }