@bongos/core 1.21.66 → 1.21.67

package/tests/my_projects_surface.mjs

@@ -21,9 +21,10 @@
 //      audit could not confirm, so it is asserted here rather than described.
 //   3. WHAT WAS STILL MISSING. The invitations half had no caller anywhere — no
 //      surface fetched the invite list, so a builder holding an invitation could
-//      not act on it. Closed by task 1003774: the hub's /projects?view=mine now
-//      reads GET /my-projects/invites (idea 1000903). The pin below flipped from
-//      "no surface calls this" to "some surface does" for the same reason.
+//      not act on it. Closed by task 1003774, which put the list in the hub's
+//      /projects?view=mine (idea 1000903); task 1004276 moved it to the hub's own
+//      /invitations page. The pin below flipped from "no surface calls this" to
+//      "some surface does" for the same reason.
 //
 // Static reads only (no import of the app, no DB) → runs in the `unit` gate.
 //
@@ -116,10 +117,17 @@ test('an invitations surface exists — the hub reads GET /my-projects/invites (
 // dead end the moment a caller exists to press it. Each invite renders as a
 // way IN (a link to the project) instead — signing in there is the acceptance
 // act (task 1002969).
+// Both hub pages: /invitations holds the invite list now (task 1004276), and
+// /projects is where it lived and where a regression could put a caller back.
+const HUB_PAGES = ['modules/public-landing/public/invitations.html', 'modules/public-landing/public/projects.html'];
 test('the hub never calls the accept route — ADR 0335 retired that flip', () => {
-  const html = read('modules/public-landing/public/projects.html');
-  assert.doesNotMatch(html, /invites\/[^'"]*\/accept/,
-    'a hub caller of the accept route reopens the dead end ADR 0335 closed — render the invite as a link into the project instead');
+  for (const rel of HUB_PAGES) {
+    assert.doesNotMatch(read(rel), /invites\/[^'"]*\/accept/,
+      `${rel}: a hub caller of the accept route reopens the dead end ADR 0335 closed — render the invite as a link into the project instead`);
+  }
+  // the guard is only meaningful where the invite list is: it must be on one of these pages
+  assert.ok(HUB_PAGES.some((rel) => read(rel).includes("'/my-projects/invites'")),
+    'the invite list moved off both hub pages — point this guard at wherever it went');
 });
 
 // Task 1002818 (ADR 0353) finished the retirement on the server: the route is gone,

package/tests/public_landing_projects.mjs

@@ -521,28 +521,26 @@ test('a stamped asset still serves — the query string is not part of the filen
 // nowhere to live until now. loadMemberships() already fetched GET /my-projects
 // for the map's Apply button (R10, task 1002286) — this just renders the rest
 // of what that same read carries, plus the separate invites list.
-test('#view-mine reads the invitations list, alongside the building-on and join surfaces', async () => {
+// The invitations and the join-by-address field moved to their own page with task
+// 1004276 (the owner's call, ADR 0337 D5); tests/hub_invitations_page.mjs holds that
+// page as served. What stays here: building-on with Leave, and a door to the page.
+test('#view-mine keeps building-on with Leave, and points at /invitations for the invitations and the join field', async () => {
   const { body } = await request('/projects', 'game.test.local');
-  assert.match(body, /\/my-projects\/invites/, 'GET /my-projects/invites must be called');
-  assert.match(body, /id="invitesList"/);
   assert.match(body, /id="buildingList"/);
-  assert.match(body, /\/my-projects\/join/, 'the join-by-URL field must post to /my-projects/join');
-  assert.match(body, /id="joinOrigin"/);
-  assert.match(body, /id="joinNote"/, 'the applicant note (task 1002330) rides along, and stays optional');
   assert.match(body, /\/my-projects\/'\s*\+\s*encodeURIComponent/, 'Leave must address the project by its own client id');
-  assert.match(body, /origin = 'https:\/\/' \+ origin/,
-    'a bare host ("grove.cloudbongos.com") must be assumed https:// rather than sent as-is — the server\'s origin lookup is an exact match');
+  for (const gone of ['invitesList', 'guildInviteList', 'engageList', 'guildRequestList', 'joinOrigin', 'joinNote', 'joinBtn', 'mineInvites']) {
+    assert.doesNotMatch(body, new RegExp(`id="${gone}"`), `#${gone} moved to /invitations`);
+  }
+  assert.doesNotMatch(body, /\/my-projects\/invites/, 'the invitations are read on their own page now');
+  assert.match(body, /<h2 id="mineToInvitesH">Invitations<\/h2>\s*<p class="lede">[^<]*<a href="\/invitations">Open your invitations<\/a><\/p>/, 'the mine view says where they went');
+  assert.match(body, /\/my-projects\/join/, 'the map card’s Apply to join still posts the join relay');
 });
 
-test('an invite renders as a way INTO the project, never the retired accept flip (ADR 0335)', async () => {
+test('the hub never calls the retired accept flip (ADR 0335)', async () => {
   const { body } = await request('/projects', 'game.test.local');
   // the hub-only accept flip never admits anyone to the project's own instance
-  // (ADR 0335) — a caller of it here would reopen the exact dead end that ADR
-  // retired, so the invite's action is an outbound link instead
+  // (ADR 0335) — a caller of it here would reopen the exact dead end that ADR retired
   assert.doesNotMatch(body, /invites\/[^'"]*\/accept/, 'no caller of the retired hub accept route');
-  assert.match(body, /Open project/, 'the invite links into the project — signing in there is the acceptance act');
-  assert.match(body, /'\/my-projects\/invites\/' \+ encodeURIComponent\([^)]+\) \+ '\/decline'/,
-    'decline still works: it only clears the hub\'s own pending row');
 });
 
 test('the map card\'s Apply button reads as truly inert once applied, with a live status region (R10 fixups)', async () => {

package/tests/render_check.mjs

@@ -24,8 +24,9 @@ test('a shared asset reaches every page in its dir whose HTML names it', () => {
   // sky-data.js is shared by the two doors of one page (task 1004232): /thinking and /goal-map.
   assert.deepEqual(names(['modules/hall-ui/public/sky-data.js']), ['goal-map.states.json', 'thinking.states.json']);
   assert.deepEqual(names(['modules/hall-ui/public/text-fit.js']), ['goals.states.json']);
-  // the account page links the hub's sheet too since task 1004259, and the guild page since task 1002301
-  assert.deepEqual(names(['modules/public-landing/public/assets/cosmos.css']), ['account.states.json', 'guild.states.json', 'projects.states.json']);
+  // the account page links the hub's sheet too since task 1004259, the guild page since task 1002301,
+  // and the invitations page since task 1004276
+  assert.deepEqual(names(['modules/public-landing/public/assets/cosmos.css']), ['account.states.json', 'guild.states.json', 'invitations.states.json', 'projects.states.json']);
 });
 
 test('the page a builder changed comes before the pages a shared file reaches, so the render cap never drops it', () => {

package/tests/ui_design_kit.mjs

@@ -34,7 +34,7 @@ test('the platform floors are a pinned list — a floor cannot vanish quietly',
 });
 
 test('the shipped states files validate and sit beside the page they name', () => {
-  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/projects-empty.states.json', 'modules/public-landing/public/projects-dns-pending.states.json', 'modules/public-landing/public/projects-hall-live.states.json','modules/public-landing/public/index.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/account-private.states.json', 'modules/public-landing/public/guild.states.json', 'modules/hall-ui/public/ranks.states.json']) {
+  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/projects-empty.states.json', 'modules/public-landing/public/projects-dns-pending.states.json', 'modules/public-landing/public/projects-hall-live.states.json','modules/public-landing/public/index.states.json', 'modules/public-landing/public/index-cli.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/account-private.states.json', 'modules/public-landing/public/guild.states.json', 'modules/public-landing/public/invitations.states.json', 'modules/public-landing/public/invitations-empty.states.json', 'modules/public-landing/public/invitations-picker.states.json', 'modules/hall-ui/public/ranks.states.json']) {
     const json = readJson(rel);
     const v = lib.validateStatesFile(json);
     assert.deepEqual(v.errors, [], `${rel}: ${v.errors.join('; ')}`);
@@ -43,14 +43,14 @@ test('the shipped states files validate and sit beside the page they name', () =
   }
   // the apex is dark only (task 1003336): its states files name the one mode, and
   // render.js reads it as the default so a plain `--page /` never renders light
-  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/index.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/guild.states.json']) {
+  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/index.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/guild.states.json', 'modules/public-landing/public/invitations.states.json']) {
     assert.deepEqual(readJson(rel).modes, ['dark'], `${rel}: the apex renders dark only`);
     assert.equal(readJson(rel).modeQuery, false, `${rel}: no query walks a second mode`);
   }
 });
 
 test('the shipped probes files validate', () => {
-  for (const rel of ['modules/public-landing/public/projects.probes.json', 'modules/public-landing/public/index.probes.json', 'modules/public-landing/public/account.probes.json', 'modules/public-landing/public/guild.probes.json']) {
+  for (const rel of ['modules/public-landing/public/projects.probes.json', 'modules/public-landing/public/index.probes.json', 'modules/public-landing/public/account.probes.json', 'modules/public-landing/public/guild.probes.json', 'modules/public-landing/public/invitations.probes.json']) {
     const v = lib.validateProbesFile(readJson(rel));
     assert.deepEqual(v.errors, [], `${rel}: ${v.errors.join('; ')}`);
   }