@bongos/core 1.21.65 → 1.21.67

package/tests/my_projects_surface.mjs

@@ -21,9 +21,10 @@
 //      audit could not confirm, so it is asserted here rather than described.
 //   3. WHAT WAS STILL MISSING. The invitations half had no caller anywhere — no
 //      surface fetched the invite list, so a builder holding an invitation could
-//      not act on it. Closed by task 1003774: the hub's /projects?view=mine now
-//      reads GET /my-projects/invites (idea 1000903). The pin below flipped from
-//      "no surface calls this" to "some surface does" for the same reason.
+//      not act on it. Closed by task 1003774, which put the list in the hub's
+//      /projects?view=mine (idea 1000903); task 1004276 moved it to the hub's own
+//      /invitations page. The pin below flipped from "no surface calls this" to
+//      "some surface does" for the same reason.
 //
 // Static reads only (no import of the app, no DB) → runs in the `unit` gate.
 //
@@ -116,10 +117,17 @@ test('an invitations surface exists — the hub reads GET /my-projects/invites (
 // dead end the moment a caller exists to press it. Each invite renders as a
 // way IN (a link to the project) instead — signing in there is the acceptance
 // act (task 1002969).
+// Both hub pages: /invitations holds the invite list now (task 1004276), and
+// /projects is where it lived and where a regression could put a caller back.
+const HUB_PAGES = ['modules/public-landing/public/invitations.html', 'modules/public-landing/public/projects.html'];
 test('the hub never calls the accept route — ADR 0335 retired that flip', () => {
-  const html = read('modules/public-landing/public/projects.html');
-  assert.doesNotMatch(html, /invites\/[^'"]*\/accept/,
-    'a hub caller of the accept route reopens the dead end ADR 0335 closed — render the invite as a link into the project instead');
+  for (const rel of HUB_PAGES) {
+    assert.doesNotMatch(read(rel), /invites\/[^'"]*\/accept/,
+      `${rel}: a hub caller of the accept route reopens the dead end ADR 0335 closed — render the invite as a link into the project instead`);
+  }
+  // the guard is only meaningful where the invite list is: it must be on one of these pages
+  assert.ok(HUB_PAGES.some((rel) => read(rel).includes("'/my-projects/invites'")),
+    'the invite list moved off both hub pages — point this guard at wherever it went');
 });
 
 // Task 1002818 (ADR 0353) finished the retirement on the server: the route is gone,

package/tests/public_landing_projects.mjs

@@ -521,28 +521,26 @@ test('a stamped asset still serves — the query string is not part of the filen
 // nowhere to live until now. loadMemberships() already fetched GET /my-projects
 // for the map's Apply button (R10, task 1002286) — this just renders the rest
 // of what that same read carries, plus the separate invites list.
-test('#view-mine reads the invitations list, alongside the building-on and join surfaces', async () => {
+// The invitations and the join-by-address field moved to their own page with task
+// 1004276 (the owner's call, ADR 0337 D5); tests/hub_invitations_page.mjs holds that
+// page as served. What stays here: building-on with Leave, and a door to the page.
+test('#view-mine keeps building-on with Leave, and points at /invitations for the invitations and the join field', async () => {
   const { body } = await request('/projects', 'game.test.local');
-  assert.match(body, /\/my-projects\/invites/, 'GET /my-projects/invites must be called');
-  assert.match(body, /id="invitesList"/);
   assert.match(body, /id="buildingList"/);
-  assert.match(body, /\/my-projects\/join/, 'the join-by-URL field must post to /my-projects/join');
-  assert.match(body, /id="joinOrigin"/);
-  assert.match(body, /id="joinNote"/, 'the applicant note (task 1002330) rides along, and stays optional');
   assert.match(body, /\/my-projects\/'\s*\+\s*encodeURIComponent/, 'Leave must address the project by its own client id');
-  assert.match(body, /origin = 'https:\/\/' \+ origin/,
-    'a bare host ("grove.cloudbongos.com") must be assumed https:// rather than sent as-is — the server\'s origin lookup is an exact match');
+  for (const gone of ['invitesList', 'guildInviteList', 'engageList', 'guildRequestList', 'joinOrigin', 'joinNote', 'joinBtn', 'mineInvites']) {
+    assert.doesNotMatch(body, new RegExp(`id="${gone}"`), `#${gone} moved to /invitations`);
+  }
+  assert.doesNotMatch(body, /\/my-projects\/invites/, 'the invitations are read on their own page now');
+  assert.match(body, /<h2 id="mineToInvitesH">Invitations<\/h2>\s*<p class="lede">[^<]*<a href="\/invitations">Open your invitations<\/a><\/p>/, 'the mine view says where they went');
+  assert.match(body, /\/my-projects\/join/, 'the map card’s Apply to join still posts the join relay');
 });
 
-test('an invite renders as a way INTO the project, never the retired accept flip (ADR 0335)', async () => {
+test('the hub never calls the retired accept flip (ADR 0335)', async () => {
   const { body } = await request('/projects', 'game.test.local');
   // the hub-only accept flip never admits anyone to the project's own instance
-  // (ADR 0335) — a caller of it here would reopen the exact dead end that ADR
-  // retired, so the invite's action is an outbound link instead
+  // (ADR 0335) — a caller of it here would reopen the exact dead end that ADR retired
   assert.doesNotMatch(body, /invites\/[^'"]*\/accept/, 'no caller of the retired hub accept route');
-  assert.match(body, /Open project/, 'the invite links into the project — signing in there is the acceptance act');
-  assert.match(body, /'\/my-projects\/invites\/' \+ encodeURIComponent\([^)]+\) \+ '\/decline'/,
-    'decline still works: it only clears the hub\'s own pending row');
 });
 
 test('the map card\'s Apply button reads as truly inert once applied, with a live status region (R10 fixups)', async () => {

package/tests/render_check.mjs

@@ -24,8 +24,9 @@ test('a shared asset reaches every page in its dir whose HTML names it', () => {
   // sky-data.js is shared by the two doors of one page (task 1004232): /thinking and /goal-map.
   assert.deepEqual(names(['modules/hall-ui/public/sky-data.js']), ['goal-map.states.json', 'thinking.states.json']);
   assert.deepEqual(names(['modules/hall-ui/public/text-fit.js']), ['goals.states.json']);
-  // the account page links the hub's sheet too since task 1004259, and the guild page since task 1002301
-  assert.deepEqual(names(['modules/public-landing/public/assets/cosmos.css']), ['account.states.json', 'guild.states.json', 'projects.states.json']);
+  // the account page links the hub's sheet too since task 1004259, the guild page since task 1002301,
+  // and the invitations page since task 1004276
+  assert.deepEqual(names(['modules/public-landing/public/assets/cosmos.css']), ['account.states.json', 'guild.states.json', 'invitations.states.json', 'projects.states.json']);
 });
 
 test('the page a builder changed comes before the pages a shared file reaches, so the render cap never drops it', () => {

package/tests/ui_design_kit.mjs

@@ -34,7 +34,7 @@ test('the platform floors are a pinned list — a floor cannot vanish quietly',
 });
 
 test('the shipped states files validate and sit beside the page they name', () => {
-  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/projects-empty.states.json', 'modules/public-landing/public/projects-dns-pending.states.json', 'modules/public-landing/public/projects-hall-live.states.json','modules/public-landing/public/index.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/account-private.states.json', 'modules/public-landing/public/guild.states.json', 'modules/hall-ui/public/ranks.states.json']) {
+  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/projects-empty.states.json', 'modules/public-landing/public/projects-dns-pending.states.json', 'modules/public-landing/public/projects-hall-live.states.json','modules/public-landing/public/index.states.json', 'modules/public-landing/public/index-cli.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/account-private.states.json', 'modules/public-landing/public/guild.states.json', 'modules/public-landing/public/invitations.states.json', 'modules/public-landing/public/invitations-empty.states.json', 'modules/public-landing/public/invitations-picker.states.json', 'modules/hall-ui/public/ranks.states.json']) {
     const json = readJson(rel);
     const v = lib.validateStatesFile(json);
     assert.deepEqual(v.errors, [], `${rel}: ${v.errors.join('; ')}`);
@@ -43,14 +43,14 @@ test('the shipped states files validate and sit beside the page they name', () =
   }
   // the apex is dark only (task 1003336): its states files name the one mode, and
   // render.js reads it as the default so a plain `--page /` never renders light
-  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/index.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/guild.states.json']) {
+  for (const rel of ['modules/public-landing/public/projects.states.json', 'modules/public-landing/public/index.states.json', 'modules/public-landing/public/account.states.json', 'modules/public-landing/public/guild.states.json', 'modules/public-landing/public/invitations.states.json']) {
     assert.deepEqual(readJson(rel).modes, ['dark'], `${rel}: the apex renders dark only`);
     assert.equal(readJson(rel).modeQuery, false, `${rel}: no query walks a second mode`);
   }
 });
 
 test('the shipped probes files validate', () => {
-  for (const rel of ['modules/public-landing/public/projects.probes.json', 'modules/public-landing/public/index.probes.json', 'modules/public-landing/public/account.probes.json', 'modules/public-landing/public/guild.probes.json']) {
+  for (const rel of ['modules/public-landing/public/projects.probes.json', 'modules/public-landing/public/index.probes.json', 'modules/public-landing/public/account.probes.json', 'modules/public-landing/public/guild.probes.json', 'modules/public-landing/public/invitations.probes.json']) {
     const v = lib.validateProbesFile(readJson(rel));
     assert.deepEqual(v.errors, [], `${rel}: ${v.errors.join('; ')}`);
   }

package/modules/hall-ui/public/profile-canonical.js

@@ -1,137 +0,0 @@
-// modules/hall-ui/public/profile-canonical.js — the canonical-profile wiring on
-// the hall's profile page (P08, task 1002804; ADR 0214, ADR 0171 D1,
-// profile-page spec Decision 1).
-//
-// ONE ANSWER, THREE BEHAVIOURS. A builder has exactly one canonical public
-// profile, at <hub>/u/<handle>. What this page does about that depends on which
-// instance is serving it, and the two cases are opposites:
-//
-//   * THE HUB serves the same person's canonical page itself, from the same
-//     database. Two URLs for one page on one host is the duplication Decision 1
-//     exists to end, so the numeric ?id= form REDIRECTS to the handle URL.
-//   * A FEDERATED INSTANCE shows its OWN rank, works and achievements here —
-//     genuinely different content — so it must not redirect. It stays the local
-//     view, declares the hub page canonical, and LINKS OUT to the cross-project
-//     record rather than inlining numbers it would have to keep fresh
-//     (ADR 0171 D1: an instance-side copy is stale the moment a builder hides).
-//   * A VANILLA INSTANCE has no hub. Nothing here does anything.
-//
-// A page cannot both redirect to a URL and declare it canonical, and it does not
-// have to: those are two different instances.
-//
-// IT IS ALL DARK TODAY, ON PURPOSE. `/u/<handle>` does not exist yet — the page
-// is goal 1000048 R14, and the ADR that fixes its PATH (R01) is unwritten. A
-// rel=canonical naming a 404 consolidates nothing and risks the one page that
-// works, so CANONICAL_PROFILE_PAGE_LIVE is false and every branch below is a
-// no-op. ADR 0214 D1 carries the argument.
-//
-// NOTHING HERE IS AUTHORITY (ADR 0016): a canonical URL is an address, never a
-// grant. And nothing here decides who is visible — the server already did that
-// by omitting `handle` for an account that is absent, provisional or private,
-// identically in all three cases (ADR 0214 D5).
-
-(() => {
-  'use strict';
-
-  // BOUNDARY-FORCED DUPLICATION (the ADR 0091 §2 pattern, as
-  // platform-identity.js already does for the display-name cap): a browser
-  // script cannot require modules/platform-identity/canonical-profile.js, so the
-  // two constants below MIRROR it. tests/canonical_profile_url.mjs reads both
-  // files and fails if they ever disagree, which is what keeps this a mirror
-  // rather than a second opinion. Flip the module's copy and this one together.
-  const CANONICAL_PROFILE_PAGE_LIVE = false;
-  const CANONICAL_PROFILE_PREFIX = '/u/';
-
-  // Same charset the module re-checks: a handle is about to be interpolated into
-  // an href and a <link rel=canonical>, so it is validated here too rather than
-  // trusted because it arrived over the wire.
-  const HANDLE_RE = /^[a-z0-9-]{1,39}$/;
-
-  // The hub apex, stamped server-side into a <meta> (never a script global, and
-  // never straight into an href — an empty value in an href would silently
-  // become a same-host relative URL claiming to be the hub). Absent or empty
-  // means "no hub", and every branch below then does nothing.
-  function hubOrigin() {
-    const meta = document.querySelector('meta[name="hub-origin"]');
-    const raw = ((meta && meta.getAttribute('content')) || '').trim().replace(/\/+$/, '');
-    if (!raw) return null;
-    // Bare https origin only — a canonical must never name a downgraded scheme,
-    // and a value carrying a path is not an origin.
-    try {
-      const url = new URL(raw);
-      if (url.protocol !== 'https:' || url.username || url.password) return null;
-      if (url.pathname !== '/' || url.search || url.hash) return null;
-      return url.origin;
-    } catch (err) { return null; }
-  }
-
-  // The canonical public profile URL, or null when we must not point anywhere:
-  // the page is not live, no hub is known, or the account has no public handle
-  // (absent / provisional / private — indistinguishable by design).
-  function canonicalProfileUrl(handle) {
-    if (!CANONICAL_PROFILE_PAGE_LIVE) return null;
-    const origin = hubOrigin();
-    if (!origin) return null;
-    const h = String(handle == null ? '' : handle).trim().toLowerCase();
-    if (!HANDLE_RE.test(h)) return null;
-    return `${origin}${CANONICAL_PROFILE_PREFIX}${h}`;
-  }
-
-  // "Am I the hub?" — the enabled-module set the server injects. `platform-
-  // identity` IS the hub flag rather than a proxy for it (src/platform-server.js
-  // says so), so this asks the instance what it is and nothing has to know the
-  // platform's hostname.
-  function isHub() {
-    const mods = window.__MODULES__;
-    return Array.isArray(mods) ? mods.includes('platform-identity') : !!(mods && mods['platform-identity']);
-  }
-
-  function setCanonicalLink(url) {
-    let link = document.querySelector('link[rel="canonical"]');
-    if (!link) {
-      link = document.createElement('link');
-      link.setAttribute('rel', 'canonical');
-      document.head.appendChild(link);
-    }
-    link.setAttribute('href', url);
-  }
-
-  // The visible link-out — ADR 0171 D1's federated render path. It reuses the
-  // page's existing cross-project section, which on a federated instance is
-  // empty and hidden (the response carries no cross_project key there), so the
-  // heading a reader already understands gets the link instead of numbers.
-  function renderLinkOut(url) {
-    const section = document.getElementById('xp-scroll');
-    const body = document.getElementById('xp-body');
-    if (!section || !body) return;
-    // Defence in depth, and honestly UNOBSERVABLE today: canonicalProfileUrl has
-    // already refused anything outside `https://<bare origin>/u/[a-z0-9-]{1,39}`,
-    // so no value reaching here can contain a character this changes. It is the
-    // second wall for the day someone loosens the handle charset — a mutation
-    // test cannot make it bite, and that is the point rather than a gap.
-    const escapeHtml = (window.OTB && window.OTB.escapeHtml) || ((s) => String(s));
-    body.innerHTML = `<p class="scroll__lede">This builder's work spans more than this project. `
-      + `<a href="${escapeHtml(url)}" rel="noopener">See the cross-project record</a>.</p>`;
-    section.hidden = false;
-  }
-
-  // render(data) — called by profile.js once the profile response is in hand.
-  // `data.handle` is present iff the builder has a PUBLICLY VISIBLE platform
-  // account; absent for no account, provisional and private alike, so nothing
-  // here can tell those apart and neither can a visitor watching it.
-  function render(data) {
-    const url = canonicalProfileUrl(data && data.handle);
-    if (!url) return;
-    if (isHub()) {
-      // The hub's numeric form is an address for a page the hub also serves at
-      // the canonical URL. `replace`, not `assign`: the numeric URL should not
-      // sit in history as a place Back returns to.
-      if (new URLSearchParams(location.search).get('id')) location.replace(url);
-      return;
-    }
-    setCanonicalLink(url);
-    renderLinkOut(url);
-  }
-
-  window.OTBCanonical = { render, canonicalProfileUrl, hubOrigin, isHub };
-})();