@bongos/core 1.21.63 → 1.21.65

package/docs/page-readings.json

@@ -5,7 +5,7 @@
   "adr": "0341 D3",
   "reread": "node scripts/gds/page-reader.js --stale",
   "how": ["Generated by node scripts/gds/page-reader.js (BV2.TW04, task 1004315; ADR 0341 D3). Do not hand-edit.","One entry per page of docs/page-inventory.json. Lines are in page order: the default state first, and a line only another state shows sits where that state shows it, with its state named.","placement: placed = a docs/copy-registry.json row renders it (file, line, string_id); shared = shell text every page of the surface carries (top bar, sidebar, footer), with its row when the registry has one; unplaced = the registry cannot place it (a rewrite becomes an engineer task, ADR 0341 D4).","text keeps {…} where the registry row has a hole, or where a value the page read from its API was filled in. A string that is only such data is counted under omitted.data, not listed.","reading_hash is over the non-shared lines (key, section, text); files_hash is over the page's inventory files. --check compares files_hash only and never opens a browser.","Rendered through the hall-preview harness (hall) and the ui-design kit stub (landing, status), at 1280x800 with the clock pinned, so a reading is the fixture world's page."],
-  "counts": {"pages":43,"lines":5036,"placed":1590,"shared":395,"unplaced":3051,"omitted_data":2497},
+  "counts": {"pages":43,"lines":5044,"placed":1595,"shared":395,"unplaced":3054,"omitted_data":2513},
   "pages": [
     {
       "id": "builders:atlas",
@@ -3823,10 +3823,10 @@
       "surface": "builders",
       "title": "Watch",
       "states_read": ["board","out","operations","security"],
-      "files_hash": "7194297c3ec32dce",
-      "reading_hash": "d2d6b075e14c0ad2",
-      "counts": {"lines":74,"placed":27,"shared":9,"unplaced":38},
-      "omitted": {"data":52},
+      "files_hash": "0b7766cc6b8efa03",
+      "reading_hash": "075b05aa7b88e75b",
+      "counts": {"lines":82,"placed":32,"shared":9,"unplaced":41},
+      "omitted": {"data":68},
       "notes": ["operations: an action failed (page.click: Timeout 6000ms exceeded.); read as it stood","security: an action failed (page.click: Timeout 6000ms exceeded.); read as it stood"],
       "lines": [
         {"key":"L0001","section":"skip link","text":"Skip to content","placement":"shared","file":"modules/hall-ui/public/shell.js","line":811,"string_id":"87cee78ca134"},
@@ -3838,71 +3838,79 @@
         {"key":"L0007","section":"top bar","text":"Ideating","placement":"shared"},
         {"key":"L0008","section":"top bar","text":"Governing","placement":"shared"},
         {"key":"L0009","section":"Watch","text":"Watch","placement":"unplaced"},
-        {"key":"L0010","section":"Watch","text":"System oversight: people, operations and security.","placement":"placed","file":"modules/hall-ui/public/watch.js","line":1364,"string_id":"4894b1d9b0de"},
-        {"key":"L0011","section":"Watch","text":"Access requests","placement":"placed","file":"modules/hall-ui/public/watch.html","line":46,"string_id":"996edffc1966"},
-        {"key":"L0012","section":"Watch","text":"pending, on the People tab","placement":"placed","file":"modules/hall-ui/public/watch.html","line":46,"string_id":"2fb1dad96280"},
-        {"key":"L0013","section":"Watch","text":"Security reports","placement":"placed","file":"modules/hall-ui/public/watch.html","line":47,"string_id":"ab8af800f2bb"},
-        {"key":"L0014","section":"Watch","text":"open, on the Security tab","placement":"placed","file":"modules/hall-ui/public/watch.html","line":47,"string_id":"4f279d68175f"},
-        {"key":"L0015","section":"Watch","text":"Stale claims","placement":"placed","file":"modules/hall-ui/public/watch.html","line":48,"string_id":"f2a4d855d82d"},
-        {"key":"L0016","section":"Watch","text":"builders, on the People tab","placement":"placed","file":"modules/hall-ui/public/watch.html","line":48,"string_id":"552e00198649"},
+        {"key":"L0010","section":"Watch","text":"System oversight: people, operations and security.","placement":"placed","file":"modules/hall-ui/public/watch.js","line":1450,"string_id":"4894b1d9b0de"},
+        {"key":"L0011","section":"Watch","text":"Access requests","placement":"placed","file":"modules/hall-ui/public/watch.html","line":49,"string_id":"996edffc1966"},
+        {"key":"L0012","section":"Watch","text":"pending, on the People tab","placement":"placed","file":"modules/hall-ui/public/watch.html","line":49,"string_id":"2fb1dad96280"},
+        {"key":"L0013","section":"Watch","text":"Security reports","placement":"placed","file":"modules/hall-ui/public/watch.html","line":50,"string_id":"ab8af800f2bb"},
+        {"key":"L0014","section":"Watch","text":"open, on the Security tab","placement":"placed","file":"modules/hall-ui/public/watch.html","line":50,"string_id":"4f279d68175f"},
+        {"key":"L0015","section":"Watch","text":"Stale claims","placement":"placed","file":"modules/hall-ui/public/watch.html","line":51,"string_id":"f2a4d855d82d"},
+        {"key":"L0016","section":"Watch","text":"builders, on the People tab","placement":"placed","file":"modules/hall-ui/public/watch.html","line":51,"string_id":"552e00198649"},
         {"key":"L0017","section":"Watch","text":"Sessions","placement":"unplaced"},
-        {"key":"L0018","section":"Watch","text":"recorded, on the Operations tab","placement":"placed","file":"modules/hall-ui/public/watch.html","line":49,"string_id":"f83f0a9d6b6a"},
+        {"key":"L0018","section":"Watch","text":"recorded, on the Operations tab","placement":"placed","file":"modules/hall-ui/public/watch.html","line":52,"string_id":"f83f0a9d6b6a"},
         {"key":"L0019","section":"Watch","text":"People","placement":"unplaced"},
         {"key":"L0020","section":"Watch","text":"Operations","placement":"unplaced"},
         {"key":"L0021","section":"Watch","text":"Security","placement":"unplaced"},
-        {"key":"L0022","section":"Access requests","text":"Access requests","placement":"placed","file":"modules/hall-ui/public/watch.html","line":46,"string_id":"996edffc1966"},
-        {"key":"L0023","section":"Access requests","text":"People asking to join. Approve or dismiss each request, re-read the ones you already decided, and take back an approval before that person has signed in.","placement":"placed","file":"modules/hall-ui/public/watch.html","line":62,"string_id":"a69aff719f1a"},
+        {"key":"L0022","section":"Access requests","text":"Access requests","placement":"placed","file":"modules/hall-ui/public/watch.html","line":49,"string_id":"996edffc1966"},
+        {"key":"L0023","section":"Access requests","text":"People asking to join. Approve or dismiss each request, re-read the ones you already decided, and take back an approval before that person has signed in.","placement":"placed","file":"modules/hall-ui/public/watch.html","line":65,"string_id":"a69aff719f1a"},
         {"key":"L0024","section":"Access requests","text":"Invite by GitHub username","placement":"placed","file":"modules/hall-ui/public/watch.js","line":295,"string_id":"24f9e88c21f6"},
         {"key":"L0025","section":"Access requests","text":"e.g. octocat","placement":"placed","file":"modules/hall-ui/public/watch.js","line":296,"string_id":"77b0b2b446a1","attr":"placeholder"},
-        {"key":"L0026","section":"Access requests","text":"Invite","placement":"unplaced","occurrences":3},
+        {"key":"L0026","section":"Access requests","text":"Invite","placement":"unplaced","occurrences":7},
         {"key":"L0027","section":"Access requests","text":"Admit someone before they ask — once invited, their sign-in gets in.","placement":"unplaced"},
         {"key":"L0028","section":"Access requests","text":"Show","placement":"placed","file":"modules/hall-ui/public/profile.js","line":793,"string_id":"a81ec73539ef"},
         {"key":"L0029","section":"Access requests","text":"Waiting","placement":"unplaced"},
         {"key":"L0030","section":"Access requests","text":"Admitted","placement":"unplaced"},
         {"key":"L0031","section":"Access requests","text":"Declined","placement":"unplaced"},
-        {"key":"L0032","section":"Access requests","text":"Name unvouched","placement":"placed","file":"modules/hall-ui/public/watch.js","line":397,"string_id":"5e8199266a8a","occurrences":2},
-        {"key":"L0033","section":"Access requests","text":"Asked {…}","placement":"placed","file":"modules/hall-ui/public/watch.js","line":517,"string_id":"b2656d0b2402","occurrences":2},
-        {"key":"L0034","section":"Access requests","text":"Dismiss","placement":"unplaced","occurrences":2},
-        {"key":"L0035","section":"Roster","text":"Roster","placement":"unplaced"},
-        {"key":"L0036","section":"Roster","text":"Every builder in {{worldName}} — rank, {{currency}}, karma, and active claims.","placement":"placed","file":"modules/hall-ui/public/watch.html","line":69,"string_id":"8690c6424585"},
-        {"key":"L0037","section":"Roster","text":"Builder","placement":"unplaced"},
-        {"key":"L0038","section":"Roster","text":"Rank","placement":"unplaced"},
-        {"key":"L0039","section":"Roster","text":"Credits","placement":"unplaced"},
-        {"key":"L0040","section":"Roster","text":"Karma","placement":"unplaced"},
-        {"key":"L0041","section":"Roster","text":"Active claims","placement":"unplaced"},
-        {"key":"L0042","section":"Roster","text":"Standing","placement":"unplaced"},
-        {"key":"L0043","section":"Roster","text":"Action","placement":"unplaced"},
-        {"key":"L0044","section":"Roster","text":"Offboard","placement":"unplaced","occurrences":3},
-        {"key":"L0045","section":"Roster","text":"stale","placement":"unplaced"},
-        {"key":"L0046","section":"Roster","text":"That's you","placement":"placed","file":"modules/hall-ui/public/watch.js","line":832,"string_id":"6e5a324b2972"},
-        {"key":"L0047","section":"Roster","text":"Reactivate","placement":"unplaced"},
-        {"key":"L0048","section":"Roster","text":"Your own row carries no controls. Nobody can change their own rank or standing — that guard is what stops the last {…} locking everyone out — so another {…} does it.","placement":"placed","file":"modules/hall-ui/public/watch.js","line":864,"string_id":"5e0ec4cd1cfe"},
-        {"key":"L0049","section":"Reviews by builder","text":"Reviews by builder","placement":"placed","file":"modules/hall-ui/public/watch.html","line":75,"string_id":"4e062d4f8d69"},
-        {"key":"L0050","section":"Reviews by builder","text":"How each builder's shipped work has been graded over the past thirty days.","placement":"placed","file":"modules/hall-ui/public/watch.html","line":76,"string_id":"0bab9286ea38"},
-        {"key":"L0051","section":"Reviews by builder","text":"Builder","placement":"unplaced"},
-        {"key":"L0052","section":"Reviews by builder","text":"Graded","placement":"unplaced"},
-        {"key":"L0053","section":"Reviews by builder","text":"Avg score","placement":"unplaced"},
-        {"key":"L0054","section":"Reviews by builder","text":"Pass rate","placement":"unplaced"},
-        {"key":"L0055","section":"Reviews by builder","text":"Last graded","placement":"unplaced"},
-        {"key":"L0056","section":"Reviews by builder","text":"Window: last 30 days.","placement":"unplaced"},
-        {"key":"L0057","section":"Review quality","text":"Review quality","placement":"placed","file":"modules/hall-ui/public/watch.html","line":82,"string_id":"f1b2b158c3b1"},
-        {"key":"L0058","section":"Review quality","text":"Grades across all recent shipped work — a rolling aggregate.","placement":"placed","file":"modules/hall-ui/public/watch.html","line":83,"string_id":"24d58d284952"},
-        {"key":"L0059","section":"Review quality","text":"Avg score","placement":"unplaced"},
-        {"key":"L0060","section":"Review quality","text":"Pass rate","placement":"unplaced"},
-        {"key":"L0061","section":"Review quality","text":"Sample size","placement":"unplaced"},
-        {"key":"L0062","section":"Review quality","text":"Threshold","placement":"unplaced"},
-        {"key":"L0063","section":"Review quality","text":"Per day: ships graded · avg score.","placement":"unplaced"},
-        {"key":"L0064","section":"footer","text":"Sign out","placement":"shared","file":"modules/hall-ui/public/shell.js","line":471,"string_id":"1883ad7f07fc"},
-        {"key":"L0065","section":"Review quality","text":"Builders hall · this session","placement":"placed","file":"modules/hall-ui/public/craft-mode.js","line":352,"string_id":"fd1903586e8e"},
-        {"key":"L0066","section":"What are you doing now?","text":"What are you doing now?","placement":"placed","file":"modules/hall-ui/public/craft-mode.js","line":353,"string_id":"60853319f290"},
-        {"key":"L0067","section":"What are you doing now?","text":"Pick one. You can switch any time from the top bar.","placement":"placed","file":"modules/hall-ui/public/craft-mode.js","line":354,"string_id":"4f87d5b17b54"},
-        {"key":"L0068","section":"What are you doing now?","text":"Building","placement":"unplaced"},
-        {"key":"L0069","section":"What are you doing now?","text":"{…} and {…}","placement":"placed","file":"modules/hall-ui/public/profile-nudge.js","line":77,"string_id":"56b00d773232","occurrences":3},
-        {"key":"L0070","section":"What are you doing now?","text":"Artistry","placement":"unplaced"},
-        {"key":"L0071","section":"What are you doing now?","text":"Ideating","placement":"unplaced"},
-        {"key":"L0072","section":"What are you doing now?","text":"Turn thoughts into ideas.","placement":"unplaced"},
-        {"key":"L0073","section":"What are you doing now?","text":"Governing","placement":"unplaced"},
-        {"key":"L0074","section":"What are you doing now?","text":"Ask me again next session","placement":"placed","file":"modules/hall-ui/public/craft-mode.js","line":357,"string_id":"fa86bf403775"}
+        {"key":"L0032","section":"Access requests","text":"Invite all 3","placement":"unplaced"},
+        {"key":"L0033","section":"Access requests","text":"{…} project{…}","placement":"placed","file":"modules/hall-ui/public/fleet.js","line":39,"string_id":"771bef3d31b5"},
+        {"key":"L0034","section":"Access requests","text":"Last {…} {…}, {…}","placement":"unplaced"},
+        {"key":"L0035","section":"Access requests","text":"Identity vouched","placement":"placed","file":"modules/hall-ui/public/watch.js","line":396,"string_id":"9e9f8a44276b","occurrences":4},
+        {"key":"L0036","section":"Access requests","text":"Asked {…}","placement":"placed","file":"modules/hall-ui/public/watch.js","line":517,"string_id":"b2656d0b2402","occurrences":6},
+        {"key":"L0037","section":"Access requests","text":"Dismiss","placement":"unplaced","occurrences":6},
+        {"key":"L0038","section":"Access requests","text":"Active recently","placement":"placed","file":"modules/hall-ui/public/watch.js","line":458,"string_id":"74cc57f76b42"},
+        {"key":"L0039","section":"Access requests","text":"Private account — this is all they share by applying.","placement":"placed","file":"modules/hall-ui/public/watch.js","line":459,"string_id":"92d8fad6dc91","occurrences":2},
+        {"key":"L0040","section":"Access requests","text":"This builder hides their cross-project record.","placement":"placed","file":"modules/hall-ui/public/watch.js","line":440,"string_id":"b7c288328f79"},
+        {"key":"L0041","section":"Access requests","text":"On their own","placement":"unplaced"},
+        {"key":"L0042","section":"Access requests","text":"Name unvouched","placement":"placed","file":"modules/hall-ui/public/watch.js","line":397,"string_id":"5e8199266a8a","occurrences":2},
+        {"key":"L0043","section":"Roster","text":"Roster","placement":"unplaced"},
+        {"key":"L0044","section":"Roster","text":"Every builder in {{worldName}} — rank, {{currency}}, karma, and active claims.","placement":"placed","file":"modules/hall-ui/public/watch.html","line":72,"string_id":"8690c6424585"},
+        {"key":"L0045","section":"Roster","text":"Builder","placement":"unplaced"},
+        {"key":"L0046","section":"Roster","text":"Rank","placement":"unplaced"},
+        {"key":"L0047","section":"Roster","text":"Credits","placement":"unplaced"},
+        {"key":"L0048","section":"Roster","text":"Karma","placement":"unplaced"},
+        {"key":"L0049","section":"Roster","text":"Active claims","placement":"unplaced"},
+        {"key":"L0050","section":"Roster","text":"Standing","placement":"unplaced"},
+        {"key":"L0051","section":"Roster","text":"Action","placement":"unplaced"},
+        {"key":"L0052","section":"Roster","text":"Offboard","placement":"unplaced","occurrences":3},
+        {"key":"L0053","section":"Roster","text":"stale","placement":"unplaced"},
+        {"key":"L0054","section":"Roster","text":"That's you","placement":"placed","file":"modules/hall-ui/public/watch.js","line":918,"string_id":"6e5a324b2972"},
+        {"key":"L0055","section":"Roster","text":"Reactivate","placement":"unplaced"},
+        {"key":"L0056","section":"Roster","text":"Your own row carries no controls. Nobody can change their own rank or standing — that guard is what stops the last {…} locking everyone out — so another {…} does it.","placement":"placed","file":"modules/hall-ui/public/watch.js","line":950,"string_id":"5e0ec4cd1cfe"},
+        {"key":"L0057","section":"Reviews by builder","text":"Reviews by builder","placement":"placed","file":"modules/hall-ui/public/watch.html","line":78,"string_id":"4e062d4f8d69"},
+        {"key":"L0058","section":"Reviews by builder","text":"How each builder's shipped work has been graded over the past thirty days.","placement":"placed","file":"modules/hall-ui/public/watch.html","line":79,"string_id":"0bab9286ea38"},
+        {"key":"L0059","section":"Reviews by builder","text":"Builder","placement":"unplaced"},
+        {"key":"L0060","section":"Reviews by builder","text":"Graded","placement":"unplaced"},
+        {"key":"L0061","section":"Reviews by builder","text":"Avg score","placement":"unplaced"},
+        {"key":"L0062","section":"Reviews by builder","text":"Pass rate","placement":"unplaced"},
+        {"key":"L0063","section":"Reviews by builder","text":"Last graded","placement":"unplaced"},
+        {"key":"L0064","section":"Reviews by builder","text":"Window: last 30 days.","placement":"unplaced"},
+        {"key":"L0065","section":"Review quality","text":"Review quality","placement":"placed","file":"modules/hall-ui/public/watch.html","line":85,"string_id":"f1b2b158c3b1"},
+        {"key":"L0066","section":"Review quality","text":"Grades across all recent shipped work — a rolling aggregate.","placement":"placed","file":"modules/hall-ui/public/watch.html","line":86,"string_id":"24d58d284952"},
+        {"key":"L0067","section":"Review quality","text":"Avg score","placement":"unplaced"},
+        {"key":"L0068","section":"Review quality","text":"Pass rate","placement":"unplaced"},
+        {"key":"L0069","section":"Review quality","text":"Sample size","placement":"unplaced"},
+        {"key":"L0070","section":"Review quality","text":"Threshold","placement":"unplaced"},
+        {"key":"L0071","section":"Review quality","text":"Per day: ships graded · avg score.","placement":"unplaced"},
+        {"key":"L0072","section":"footer","text":"Sign out","placement":"shared","file":"modules/hall-ui/public/shell.js","line":471,"string_id":"1883ad7f07fc"},
+        {"key":"L0073","section":"Review quality","text":"Builders hall · this session","placement":"placed","file":"modules/hall-ui/public/craft-mode.js","line":352,"string_id":"fd1903586e8e"},
+        {"key":"L0074","section":"What are you doing now?","text":"What are you doing now?","placement":"placed","file":"modules/hall-ui/public/craft-mode.js","line":353,"string_id":"60853319f290"},
+        {"key":"L0075","section":"What are you doing now?","text":"Pick one. You can switch any time from the top bar.","placement":"placed","file":"modules/hall-ui/public/craft-mode.js","line":354,"string_id":"4f87d5b17b54"},
+        {"key":"L0076","section":"What are you doing now?","text":"Building","placement":"unplaced"},
+        {"key":"L0077","section":"What are you doing now?","text":"{…} and {…}","placement":"placed","file":"modules/hall-ui/public/profile-nudge.js","line":77,"string_id":"56b00d773232","occurrences":3},
+        {"key":"L0078","section":"What are you doing now?","text":"Artistry","placement":"unplaced"},
+        {"key":"L0079","section":"What are you doing now?","text":"Ideating","placement":"unplaced"},
+        {"key":"L0080","section":"What are you doing now?","text":"Turn thoughts into ideas.","placement":"unplaced"},
+        {"key":"L0081","section":"What are you doing now?","text":"Governing","placement":"unplaced"},
+        {"key":"L0082","section":"What are you doing now?","text":"Ask me again next session","placement":"placed","file":"modules/hall-ui/public/craft-mode.js","line":357,"string_id":"fa86bf403775"}
       ]
     },
     {

package/modules/discord/db.js

@@ -79,6 +79,36 @@ async function countRecentDiscordBugFilings(builderId, sinceIso) {
   return rows[0].n;
 }
 
+// --- the #support answerer's ledger (task 1002534, ADR 0367) -----------------
+//
+// The bot's own builders row (migration 067, system_role='discord_bot'): the
+// principal an answer is booked to. The asker is never looked up.
+async function getBotPrincipalId() {
+  const { rows } = await pool.query(
+    `SELECT id FROM builders WHERE system_role = 'discord_bot' ORDER BY id LIMIT 1`
+  );
+  return rows.length ? Number(rows[0].id) : null;
+}
+
+// Month-to-date #support spend, the UTC calendar month, summed from the cost each
+// answer's audit row carries. The monthly cap reads this, so it survives a
+// restart. Throws on a DB error; the caller treats that as "no answer".
+// INDEXED: `route = $1 AND recorded_at >= <month start>` is exactly the shape of
+// migrations/033_audit_log.sql's idx_audit_log_route (route, recorded_at DESC), so
+// this reads one month of one route's rows, never a scan of the whole log. It
+// runs once per answer, after the free checks (rate limit, cap, concurrency).
+async function sumSupportSpendThisMonth(route = 'discord:support') {
+  const { rows } = await pool.query(
+    `SELECT COALESCE(SUM((request_body_redacted->>'cost_usd')::numeric), 0)::float8 AS usd
+       FROM audit_log
+      WHERE route = $1
+        AND surface = 'discord_bot'
+        AND recorded_at >= date_trunc('month', now() AT TIME ZONE 'UTC') AT TIME ZONE 'UTC'`,
+    [route]
+  );
+  return Number(rows[0].usd) || 0;
+}
+
 // --- the board mirror's own bookkeeping (R22 of goal 1000069) ----------------
 //
 // Which message announced which board item, so the close can be EDITED onto the
@@ -137,6 +167,8 @@ module.exports = {
   getDiscordLink,
   getDiscordLinks,
   countRecentDiscordBugFilings,
+  getBotPrincipalId,
+  sumSupportSpendThisMonth,
   recordApplause,
   recordBoardMessage,
   getBoardMessage,

package/modules/discord/discord-bot.js

@@ -471,6 +471,20 @@ async function start() {
       channelId: bugsChannelId, aggregator: bugAggregator, logLabel: 'bug handler',
     }));
 
+    // #support answers (task 1002534, ADR 0367): an @-mention in the pinned
+    // support channel gets a short answer from the public docs. Read-only, its
+    // own kill switch (DISCORD_SUPPORT_ENABLED) on top of this one, and a
+    // monthly spend cap. Everything lives in discord-support.js; it is the
+    // first feature that REPLIES through the gateway, so the bot needs Send
+    // Messages in that one channel.
+    const support = require('./discord-support').createLiveSupport({ client: c, db });
+    if (support.handler) {
+      c.on(Events.MessageCreate, support.handler);
+      log.info(`[discord-bot] answering @-mentions in #support (${support.channelId}), cap $${support.capUsd}/month.`);
+    } else {
+      log.info(`[discord-bot] #support answers are inert (${support.inertReason}).`);
+    }
+
     // Role-on-arrival (F7, ADR 0033 — the link-first onboarding gate's safety
     // net). The auto-join path (routes/auth.js) already sets the rank role at
     // add-time, so a builder who linked-then-joined is correct immediately. This