@bongos/core 1.21.49 → 1.21.51

package/modules/government/docket.js

@@ -338,7 +338,9 @@ function countStates(matters) {
 function homeLine(counts) {
   if (!counts.needs && !counts.moving) return 'nothing waits on you.';
   const parts = [];
-  if (counts.needs) parts.push(`${counts.needs} ${counts.needs === 1 ? 'matter waits' : 'matters wait'} on you`);
+  // with nothing on you but work still moving, the design says so first
+  // ("nothing waits on you · 2 moving"), task 1004531
+  parts.push(counts.needs ? `${counts.needs} ${counts.needs === 1 ? 'matter waits' : 'matters wait'} on you` : 'nothing waits on you');
   if (counts.moving) parts.push(`${counts.moving} moving`);
   return parts.join(' · ');
 }

package/modules/hall-ui/public/street.css

@@ -272,7 +272,12 @@ html[data-fullscreen="on"] .street-top { padding-right: 184px; }
 .inside-draft { display: flex; flex-direction: column; gap: 12px; padding: 14px 0 4px; border-top: 1px solid var(--street-rule); }
 .inside-draft[hidden] { display: none; }
 .inside-draft__change { gap: 6px; }
-.inside-draft__picks { display: grid; grid-template-columns: 1fr 1fr; gap: 12px; }
+.inside-draft__picks { display: grid; grid-template-columns: 1fr; gap: 12px; }
+/* who and how are one-tap chips (task 1004531); a long choice wraps inside its
+   chip. Scoped under .inside-draft so they outrank the desk chip rules below. */
+.inside-draft__chips { display: flex; flex-wrap: wrap; gap: 6px; }
+.inside-draft .inside-draft__chip { height: auto; min-height: 30px; padding: 5px 14px; white-space: normal; text-align: left; line-height: 1.3; }
+.inside-draft .inside-draft__chip--on { background: var(--ink); border-color: var(--ink); color: var(--bg); }
 .inside-draft__fixed { font-size: 14px; line-height: 1.45; color: var(--ink-soft); min-height: 36px; display: flex; align-items: center; }
 .inside-meter { display: flex; flex-direction: column; gap: 6px; }
 .inside-meter__track { height: 6px; border-radius: 999px; background: var(--street-wash); overflow: hidden; }
@@ -382,7 +387,6 @@ html[data-fullscreen="on"] .street-top { padding-right: 184px; }
 
 /* narrow: the drawing in its own sideways strip, the panel below it */
 @media (max-width: 899px) {
-  .inside-draft__picks { grid-template-columns: 1fr; }
   .inside { display: block; overflow-x: hidden; overflow-y: auto; }
   .inside-sizer { width: auto !important; height: auto !important; margin: 0; overflow: visible; }
   .inside-board { position: static; width: auto; height: auto; transform: none; display: flex; flex-direction: column; gap: 16px; padding: 8px 16px 24px; }

package/modules/hall-ui/public/street.js

@@ -90,6 +90,7 @@
   var desk = { done: {}, mine: {}, cleared: {}, order: {}, open: null, ask: null, busy: false, roomAsked: false, model: null };
   var TODAY_KEY = 'gov-desk-today';
   var today = { day: '', n: 0 };
+  var todayDrawn = null; // the count the meter's pips last drew: they are rebuilt only when it moves
 
   // ---------- light / dark ----------
   var chosen = null;
@@ -811,9 +812,13 @@
     var D = window.GovDesk, pipsEl = $('streetTodayPips');
     if (!D || !pipsEl) return;
     var t = D.todayPips(today.n);
+    setText('streetTodayN', t.text);
+    // the pips are rebuilt only when the count moves, so the newest pops once
+    // and a redraw neither replays nor cuts its pop short (task 1004531)
+    if (todayDrawn === today.n && pipsEl.children && pipsEl.children.length) return;
+    todayDrawn = today.n;
     clear(pipsEl);
     t.pips.forEach(function (p) { pipsEl.appendChild(node('span', 'street-today__pip' + (p.on ? ' street-today__pip--on' : '') + (p.fresh ? ' desk-pop' : ''))); });
-    setText('streetTodayN', t.text);
   }
 
   function pickFloor(i) {
@@ -850,8 +855,7 @@
       dr.d = A ? A.draftFor(st.key, c && c.board ? c : null) : { ok: false, reason: 'unread' };
       dr.rev++;
       drawDraft(true);
-      var who = $('insideDraftWho');
-      if (who && who.focus) who.focus();
+      focusDraft('insideDraftWho');
       return !!(dr.d && dr.d.ok);
     });
   }
@@ -868,26 +872,42 @@
     if (!dr) return;
     dr.rev++;
     drawDraft(true);
+    focusDraft(focusId);
+  }
+  // Focus one control of the draft; a group of chips takes it on its picked chip.
+  function focusDraft(focusId) {
     var el = focusId ? $(focusId) : null;
+    if (el && el.getAttribute && el.getAttribute('role') === 'radiogroup') {
+      var kids = el.children || [], pick = kids[0] || null;
+      for (var i = 0; i < kids.length; i++) if (kids[i].getAttribute('aria-checked') === 'true') { pick = kids[i]; break; }
+      el = pick;
+    }
     if (el && el.focus) el.focus();
   }
-  function draftSelect(id, list, value, onPick) {
-    var sel = node('select', 'mcard-form__select');
-    sel.setAttribute('id', id);
+  // A draft choice is one tap (the owner's line rule: choices are one-tap
+  // chips, task 1004531): a radio group of chips, the picked one filled.
+  function draftChips(id, list, value, onPick) {
+    var g = node('div', 'inside-draft__chips');
+    g.setAttribute('id', id);
+    g.setAttribute('role', 'radiogroup');
+    g.setAttribute('aria-labelledby', id + 'Label');
     list.forEach(function (o) {
-      var op = node('option', '', o.words);
-      op.setAttribute('value', o.value);
-      if (o.value === value) op.setAttribute('selected', '');
-      sel.appendChild(op);
+      var on = o.value === value;
+      var b = node('button', 'desk-chip desk-chip--choice inside-draft__chip' + (on ? ' inside-draft__chip--on' : ''), o.words);
+      b.setAttribute('type', 'button');
+      b.setAttribute('role', 'radio');
+      b.setAttribute('aria-checked', on ? 'true' : 'false');
+      b.setAttribute('data-value', o.value);
+      b.addEventListener('click', function () { if (!on) onPick(o.value); });
+      g.appendChild(b);
     });
-    sel.value = value == null ? '' : value;
-    sel.addEventListener('change', function () { onPick(sel.value); });
-    return sel;
+    return g;
   }
-  function draftField(labelText, forId, control) {
+  function draftField(labelText, forId, control, group) {
     var f = node('div', 'mcard-form');
-    var l = node(forId ? 'label' : 'span', 'mcard-form__label', labelText);
-    if (forId) l.setAttribute('for', forId);
+    var l = node(forId && !group ? 'label' : 'span', 'mcard-form__label', labelText);
+    if (forId && !group) l.setAttribute('for', forId);
+    if (group) l.setAttribute('id', forId + 'Label');
     f.appendChild(l);
     f.appendChild(control);
     return f;
@@ -925,13 +945,13 @@
     } else ch.appendChild(node('p', 'inside-note', 'This is how it works today. Pick who decides, or how, to change it.'));
     box.appendChild(ch);
     var picks = node('div', 'inside-draft__picks');
-    picks.appendChild(draftField('who decides', 'insideDraftWho', draftSelect('insideDraftWho', d.whoOptions, d.decided_by, function (v) {
+    picks.appendChild(draftField('who decides', 'insideDraftWho', draftChips('insideDraftWho', d.whoOptions, d.decided_by, function (v) {
       dr.d = A.pick(dr.d, 'who', v); dr.error = ''; bumpDraft('insideDraftWho');
-    })));
+    }), true));
     if (d.ruleOptions.length) {
-      picks.appendChild(draftField('how they decide', 'insideDraftRule', draftSelect('insideDraftRule', d.ruleOptions, d.rule, function (v) {
+      picks.appendChild(draftField('how they decide', 'insideDraftRule', draftChips('insideDraftRule', d.ruleOptions, d.rule, function (v) {
         dr.d = A.pick(dr.d, 'rule', v); dr.error = ''; bumpDraft('insideDraftRule');
-      })));
+      }), true));
     } else {
       picks.appendChild(draftField('how they decide', null, node('span', 'inside-draft__fixed', d.decided_by === 'nobody' ? 'nothing is decided until someone holds it' : 'decides alone, as today')));
     }
@@ -1210,6 +1230,8 @@
     card.pick = null;
     card.fresh = key === 'for' || key === 'object' ? 'you' : null;
     if (a.building && a.kind) card.answer = { building: a.building, matter: cv.key, kind: a.kind, at: Date.now() };
+    // a decision from a card is a decision today, as one from a desk row is (task 1004531)
+    if (recorded) { bumpToday(); drawToday(); }
     if (a.close) closeCard(true);
     else if (view.open) { fillCard(); var c = $('streetCardClose'); if (c && c.focus) c.focus(); }
     if (!recorded) return true;

package/modules/hall-ui/records/governor-street.md

@@ -47,3 +47,24 @@ Every building and every floor desk was walked in light, dark and at phone width
 - **The desk's toast is the board's**: an ink pill with the orange dot, low over the desk. The street's own toast is centred again (its enter animation had undone the centring).
 
 Left as found, on purpose: the six readings stay under a building (task 1004526 marks the building's own reading), the old month drawers stay under the desk, and the recording sign-off still goes to its page (an open owner choice).
+
+## The whole city, walked against the prototype (task 1004531)
+
+The UAT walkthrough of goal 1000125: open the home city, start governing, find what needs you, enter every building and district, decide a vote from its card and watch the city change, and draft an amendment from a building, in light and dark at 1440 and at phone width (390 px), side by side with `Street.dc.html` (the prototype), `Desks.dc.html` and `Ground.dc.html`, judged by the owner's line rule. The live site is behind its password gate, so the walk ran on the real pages in the hall preview harness (`--fixture-me`). **The real-vote step was done in the harness only**: the vote went to the harness's canned answer for `POST /government/board/items/:id/votes`, and the docket read after it was stubbed in the page to show what the server would now say; no vote was cast on the live site. The amendment was filed the same way (the page's `POST /government/board/decision-rules` answered in the page, the harness refuses writes). The district interior was walked over twelve stand-in tasks answered in the page, since the harness serves one task list for every goal. Screenshots stay out of the repo: they are in the session scratchpad, `walk-1004531/` (53 shots).
+
+What it found and fixed:
+
+- **The preview fixtures disagreed with themselves.** The docket fixture's counts, home line, per-building counts and fairness reading had been written for the first seven matters and never re-derived as later tasks added more, so the city said "3 matters wait on you", the street header 4, its pins 13, and Disputes read "0 open" under two matters that need you. `buildDocket` derives all four from the matters, so live they cannot disagree; the fixture now holds the same derivation, and `tests/hall_preview_governor_fixtures.mjs` holds it to it.
+- **Change how this works could not be walked.** The constitution fixture had no `decision_rules` block, so the drafter said it could not read how a building decides. It now carries the block the route serves (every building as today), and the same test drafts every building from it. The fixture scrubber had read a building's decided_by (gate, board, nobody) as a login; it keeps those words now.
+- **The drafter's choices were dropdowns.** Who decides and how they decide are one-tap chips now (the line rule: choices are one-tap chips): a labelled radio group each, the picked chip filled in ink, a long choice wrapping inside its chip, stacked one under the other so the chips have the panel's width. Focus lands on the picked chip after each pick.
+- **A vote from a street card did not count today.** The today meter only took a pip for an act on a desk row; a decision from a card is a decision today too, so a recorded card act now fills a pip (an act that records nothing, or is refused, does not).
+- **The meter's newest pip popped on every redraw** (any pick, the card closing, the docket read after an act), and the read after an act cut the pop short. The pips are drawn again only when the count moves, so the newest pops once, as on the board.
+- **The home line with nothing on you.** With nothing waiting on you but work still moving, the server said "2 moving"; the prototype says "nothing waits on you · 2 moving", and now so does the server (`homeLine`).
+
+Walked and matching, left as found: the city (pins, the one button, its line), the street (the order, the group brackets, one pin per building in its tier, the crates and the tester count pin, the six readings), every building's section, lift and panel, the card (its pager, the change, the seats and tally, counsel, the yes/no acts under the desk's words from task 1004566), the toast, and a district's road of work.
+
+Left on purpose, not counted as differences:
+
+- **The city sits inside the hall's shell** (sidebar and top bar). The prototype's home page carries only the wordmark, the switch, one button and one line; standalone hall pages were retired by task 1002868, and the city page adopted the shell after its record was written.
+- **The home line never says "pieces of work stuck at Review".** The prototype adds it while Review is a vacant lot; the city draws Review as held in this project (the header of `city-draw.js`), so the clause has nothing to stand on.
+- **Open owner choices met on the walk, untouched:** the "1" on a single-item pin, the light-mode legend hint wording, the recording sign-off going to its page, failed passed-vote actions on the record, a Discord update on withdraw, and the Work categories link.

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.49",
+  "version": "1.21.51",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.21.49",
+      "version": "1.21.51",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.49",
+  "version": "1.21.51",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -9062,5 +9062,17 @@
       "id": "1004575",
       "text": "New builders get setup steps that actually work end to end: the sign-in commands in Settings and the primer now run from a fresh copy of the project, the primer's terminal commands display properly, and the setup no longer lea"
     }
+  ],
+  "1.21.50": [
+    {
+      "id": "1004574",
+      "text": "The builders hall now tells newcomers one sign-in command, npx bongos setup, the same on Mac, Windows and Linux — and copying the setup commands now pastes them line by line instead of jammed onto one line."
+    }
+  ],
+  "1.21.51": [
+    {
+      "id": "1004531",
+      "text": "We walked the whole Governor City against its design, in light and dark and on a phone: the home city, the street, every building, a vote decided from its card, and an amendment drafted from a building. Fixes: drafting a chang"
+    }
   ]
 }

package/scripts/hall-preview/scrub-identity.js

@@ -63,6 +63,14 @@ const isEmailKey = (k) => k === 'email' || /_email$/.test(k);
 // `by` / `*_by` holds a builder ID almost everywhere (created_by, shipped_by); only a
 // non-numeric value is a login (sandbox_review.by, who approved a staged change).
 const isByKey = (k) => k === 'by' || /_by$/.test(k);
+// A building's `decided_by` in the decision table (government decision-rules.js)
+// is a word of its vocabulary, never a person: "gate" (as today), "board" (the
+// charter), "nobody" (vacant). A rank predicate has a colon and never looks like a
+// login. Task 1004531: the constitution fixture carries that table. Only on a
+// table ROW (it names its building in `area`), so a login that happens to be one
+// of the three words anywhere else is still scrubbed.
+const DECISION_WORDS = new Set(['gate', 'board', 'nobody']);
+const isDecisionWord = (k, v, obj) => k === 'decided_by' && DECISION_WORDS.has(v) && !!obj && typeof obj.area === 'string';
 const looksLikeLogin = (v) => /^[A-Za-z0-9](?:[A-Za-z0-9-]*[A-Za-z0-9])?$/.test(v) && !/^\d+$/.test(v);
 
 // The login a name-shaped key belongs to, or undefined when the key is not a person's
@@ -159,7 +167,7 @@ function createScrubber({ firstNumber = 1 } = {}) {
         const n = isPersonRecord ? self() : numberFor([`email:${value.toLowerCase()}`]);
         return `builder-${n}@example.com`;
       }
-      if (isByKey(key) && looksLikeLogin(value)) {
+      if (isByKey(key) && looksLikeLogin(value) && !isDecisionWord(key, value, obj)) {
         if (STAND_IN_LOGIN.test(value)) return value;
         return `builder-${numberFor([`login:${value.toLowerCase()}`])}`;
       }

package/src/module-api.js

@@ -75,7 +75,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.21.49'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.21.51'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/governor_docket.mjs

@@ -144,6 +144,8 @@ test('homeLine speaks the design\'s words', () => {
   assert.equal(docket.homeLine({ needs: 0, moving: 0, settled: 4 }), 'nothing waits on you.');
   assert.equal(docket.homeLine({ needs: 3, moving: 2, settled: 0 }), '3 matters wait on you · 2 moving');
   assert.equal(docket.homeLine({ needs: 1, moving: 0, settled: 0 }), '1 matter waits on you');
+  // the prototype's words when only moving work is left (task 1004531 walkthrough)
+  assert.equal(docket.homeLine({ needs: 0, moving: 2, settled: 1 }), 'nothing waits on you · 2 moving');
 });
 
 // ── 2. the board, per viewer ─────────────────────────────────────────────────

package/tests/hall_preview_governor_fixtures.mjs

@@ -0,0 +1,75 @@
+// tests/hall_preview_governor_fixtures.mjs — the hall preview's governor
+// fixtures hold the server's own invariants (task 1004531).
+//
+// The Governor City walkthroughs run on the hall preview harness, so its
+// fixtures are what the UAT record is judged on. Two had drifted from the
+// shapes the routes really serve:
+//   * the docket's counts, home line and per-building counts were written for
+//     the first seven matters and never re-derived as later tasks added more,
+//     so the city said "3 matters wait on you", the street header 4, and its
+//     pins 13 — buildDocket derives all three from the matters, so live they
+//     can never disagree; the fairness reading had drifted the same way, so
+//     Disputes read "0 open" under two matters that need you;
+//   * the constitution carried no decision_rules block, so "change how this
+//     works" could only say it could not read how a building decides.
+//
+// Run:  node --test tests/hall_preview_governor_fixtures.mjs
+
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import path from 'node:path';
+import { createRequire } from 'node:module';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const FX = path.join(ROOT, 'scripts/hall-preview/fixtures');
+const require = createRequire(import.meta.url);
+const docketLib = require(path.join(ROOT, 'modules/government/docket.js'));
+const DR = require(path.join(ROOT, 'modules/government/decision-rules.js'));
+const DB = require(path.join(ROOT, 'modules/government/decision-board.js'));
+const A = require(path.join(ROOT, 'modules/hall-ui/public/street-amend.js'));
+const fx = (name) => JSON.parse(fs.readFileSync(path.join(FX, name + '.json'), 'utf8'));
+
+// buildDocket's countStates, restated: every matter counted once in its state.
+function countStates(ms) {
+  const c = { needs: 0, moving: 0, settled: 0 };
+  for (const m of ms) c[m.state] += 1;
+  return c;
+}
+
+test('the docket fixture: counts and the home line are derived from its matters, as buildDocket derives them', () => {
+  const d = fx('government__docket');
+  assert.ok(d.matters.length > 7, 'the dense docket (task 1004569), not the first seven');
+  assert.deepEqual(d.counts, countStates(d.matters));
+  assert.equal(d.line, docketLib.homeLine(d.counts), 'the city line under start governing agrees with the street header');
+});
+
+test('the docket fixture: every building counts exactly the matters standing at it', () => {
+  const d = fx('government__docket');
+  for (const b of d.buildings) {
+    const here = d.matters.filter((m) => m.building === b.key);
+    assert.deepEqual(b.counts, countStates(here), b.key + ': the state line under the building agrees with its pins');
+    assert.deepEqual(b.matter_ids, here.map((m) => m.id), b.key + ': its matters, in docket order');
+  }
+  assert.equal(d.buildings.reduce((n, b) => n + b.matter_ids.length, 0), d.matters.length, 'every matter stands at one building');
+});
+
+test('the docket fixture: the fairness reading is derived from the matters at Disputes, as buildDocket derives it', () => {
+  // the reading's figure is the line under Disputes on the street, so a stale
+  // one says "0 open" under a building whose pin says two matters need you
+  const d = fx('government__docket');
+  const f = d.readings.find((r) => r.key === 'fairness');
+  const want = docketLib.fairnessReading(d.matters, d.sources);
+  assert.deepEqual({ value: f.value, figure: f.figure, line: f.line, hot: f.hot }, want);
+});
+
+test('the constitution fixture: it carries the decision_rules block the route serves, so every building can draft an amendment', () => {
+  const c = fx('government__constitution');
+  assert.deepEqual(c.decision_rules, JSON.parse(JSON.stringify(DB.constitutionBlock(DR.resolveAll([], { board: c.board })))), 'the server\'s own block for this board');
+  for (const area of c.decision_rules.areas.map((r) => r.area)) {
+    const d = A.draftFor(area, c);
+    assert.equal(d.ok, true, area + ': change how this works drafts');
+    assert.equal(A.check(d), 'Say why, so the council knows what it is voting on.', area + ': the draft is a real change, waiting only for the reason');
+  }
+});

package/tests/hall_preview_scrub.mjs

@@ -130,6 +130,11 @@ test('what is not a person is left exactly alone', () => {
   assert.equal(req.requests[0].created_by, '1000025', 'a numeric *_by is a builder id, not a login');
   assert.equal(req.tasks[0].credits_reward, 30, "a task's bounty is not anyone's balance");
   assert.equal(req.modules[0].author, 'Cloud Bongos', "a module's author credit names an organisation");
+  // the decision table's decided_by is a word of its vocabulary (task 1004531)
+  const table = s.scrub({ decision_rules: { areas: [{ area: 'charter', decided_by: 'board' }, { area: 'rules', decided_by: 'gate' }, { area: 'review', decided_by: 'nobody' }, { area: 'people', decided_by: 'rank:metic+' }] } });
+  assert.deepEqual(table.decision_rules.areas.map((a) => a.decided_by), ['board', 'gate', 'nobody', 'rank:metic+'], 'who decides a building is not a person');
+  assert.equal(s.scrub({ decided_by: 'Real-Person' }).decided_by.startsWith('builder-'), true, 'a login in decided_by is still scrubbed');
+  assert.equal(s.scrub({ id: '4', decided_by: 'gate' }).decided_by.startsWith('builder-'), true, 'off a table row, even a login spelled like a decision word is scrubbed');
 });
 
 test('scrubbing is a fixed point, and a new run numbers above the stand-ins already in use', () => {

package/tests/hall_street_amend.mjs

@@ -184,7 +184,12 @@ test('the markup: the draft lives under the button, hidden, and the model loads
   assert.ok(order[0] > 0 && order[0] < order[1] && order[1] < order[2], 'card, then the draft model, then the page');
   const css = read('street.css').replace(/\/\*[\s\S]*?\*\//g, '');
   assert.ok(css.includes('.inside-draft[hidden] { display: none; }'));
-  assert.match(css, /@media \(max-width: 899px\) \{\s*\.inside-draft__picks \{ grid-template-columns: 1fr; \}/, 'narrow: the picks stack');
+  assert.ok(css.includes('.inside-draft__picks { display: grid; grid-template-columns: 1fr; gap: 12px; }'), 'who, then how, stacked: the chips need the width (task 1004531)');
+  // the chips ride .desk-chip, which comes later in the sheet at one class: two
+  // classes are what let the wrap and the fill win (a single class lost in the browser)
+  assert.match(css, /\.inside-draft \.inside-draft__chip \{[^}]*white-space: normal;/, 'a long choice wraps inside its chip');
+  assert.match(css, /\.inside-draft \.inside-draft__chip--on \{ background: var\(--ink\);/, 'the picked chip is filled');
+  assert.ok(css.indexOf('.desk-chip--quiet, .desk-chip--choice {') > css.indexOf('.inside-draft .inside-draft__chip--on'), 'the desk rule still comes later, so the scope is what wins');
   assert.doesNotMatch(css.slice(css.indexOf('.inside-draft')), /#[0-9a-f]{3,8}\b/i, 'tokens only');
   assert.doesNotMatch(read('street.js'), /not built yet/);
 });
@@ -261,6 +266,8 @@ async function bootPage({ hash = '#building=review', cons = constitution(), answ
 
 test('change how this works opens the drafted amendment: struck, inserted, who, how, why', async () => {
   const p = await bootPage();
+  const chip = (id, v) => p.byId.get(id).kids.find((k) => k.attrs['data-value'] === v);
+  const picked = (id) => p.byId.get(id).kids.find((k) => k.attrs['aria-checked'] === 'true');
   const box = p.byId.get('insideDraft');
   assert.equal(box.hidden, true);
   await p.byId.get('insideAmend').fire('click')[0];
@@ -270,17 +277,23 @@ test('change how this works opens the drafted amendment: struck, inserted, who,
   const del = all(box).find((n) => n.tagName === 'del'), ins = all(box).find((n) => n.tagName === 'ins');
   assert.equal(del.textContent, 'whoever may mark work as meeting its checks, decides alone');
   assert.equal(ins.textContent, 'the archon rank, passes unless someone objects');
-  assert.equal(p.focused.el, p.byId.get('insideDraftWho'), 'focus lands on who decides');
-  assert.equal(p.byId.get('insideDraftWho').kids.length, 6);
-  assert.equal(p.byId.get('insideDraftRule').value, 'consent');
-  // a pick redraws the words and keeps focus where it was
+  assert.equal(p.focused.el, picked('insideDraftWho'), 'focus lands on the picked chip of who decides');
+  // every choice is a one-tap chip in a labelled radio group, never a select (task 1004531)
   const who = p.byId.get('insideDraftWho');
-  who.value = 'nobody';
-  who.fire('change');
+  assert.equal(who.attrs.role, 'radiogroup');
+  assert.ok(all(box).some((n) => n.attrs.id === 'insideDraftWhoLabel' && n._text === 'who decides'), 'the group is named by its label');
+  assert.ok(!all(box).some((n) => n.tagName === 'select'), 'no dropdowns');
+  assert.equal(who.kids.length, 6);
+  assert.ok(who.kids.every((k) => k.tagName === 'button' && k.attrs.role === 'radio'));
+  assert.equal(who.kids.filter((k) => k.attrs['aria-checked'] === 'true').length, 1, 'one picked');
+  assert.equal(picked('insideDraftRule').attrs['data-value'], 'consent');
+  // a pick is one tap: it redraws the words and keeps focus in the group
+  chip('insideDraftWho', 'nobody').fire('click');
   assert.equal(all(box).find((n) => n.tagName === 'ins').textContent, 'no one yet');
   assert.ok(!all(box).some((n) => n.attrs.id === 'insideDraftRule'), 'an empty building has no rule to pick');
   assert.match(textOf(box), /nothing is decided until someone holds it/);
-  assert.equal(p.focused.el.attrs.id, 'insideDraftWho');
+  assert.equal(p.focused.el, picked('insideDraftWho'));
+  assert.equal(p.focused.el.attrs['data-value'], 'nobody');
   // a feed landing mid-sentence leaves the draft alone
   const before = p.byId.get('insideDraftWhy');
   before.value = 'half a thought';

package/tests/hall_street_desk.mjs

@@ -894,3 +894,44 @@ test('walkthrough: a record item keeps its age, and what you did keeps its "now"
   assert.deepEqual(desk.record.map((x) => x.text), ['voted yes A returned id… · now', 'The new sign-up · live · 2d', 'Mira holds the Treasurer… · 3w', 'Today it went out · today']);
   assert.ok(desk.record.every((x) => x.text.length <= D.LIMITS.recordLen));
 });
+
+// ── the live walkthrough against the prototype (task 1004531) ─────────────────
+
+const AR = () => [matter({ id: 'access_requests:11', source: 'access_requests', building: 'people', state: 'needs', proposer: { name: 'Ana Ruiz' }, ref: { id: 11 } })];
+const settle = async () => { for (let i = 0; i < 5; i++) await new Promise((r) => setTimeout(r, 0)); };
+
+test('walkthrough 1004531: the newest pip pops once and keeps its node, so a redraw neither replays nor cuts the pop', async () => {
+  const p = await bootPage('#building=people', AR());
+  const pips = () => p.byId.get('streetTodayPips').children;
+  const before = pips()[0];
+  p.window.GovStreetPage.draw();
+  assert.equal(pips()[0], before, 'an unchanged count keeps the meter as it stands');
+  p.part('desk-rows').children[0].children[0].children[2].children[1].fire('click');
+  await settle();
+  assert.equal(p.byId.get('streetTodayN').textContent, '1 decided');
+  const fresh = pips()[0];
+  assert.notEqual(fresh, before, 'the count moved, so the pips were drawn again');
+  assert.match(fresh.className, /street-today__pip--on/);
+  assert.match(fresh.className, /desk-pop/, 'the newest pip pops');
+  p.window.GovStreetPage.draw();
+  assert.equal(pips()[0], fresh, 'the redraws after the act (the docket read again) leave the popping pip alone');
+});
+
+test('walkthrough 1004531: a decision from a street card is a decision today, as one from a desk row is', async () => {
+  const p = await bootPage('', AR());
+  p.window.GovStreetPage.openCard('access_requests:11');
+  await p.window.GovStreetPage.actOn('fine', {});
+  await settle();
+  assert.equal(p.sent.length, 1, 'the card sent its act');
+  assert.equal(p.byId.get('streetTodayN').textContent, '1 decided');
+  assert.equal(JSON.parse(p.store.get('gov-desk-today')).n, 1, 'the day keeps its count');
+  assert.match(p.byId.get('streetTodayPips').children[0].className, /street-today__pip--on desk-pop/);
+});
+
+test('walkthrough 1004531: a card act that records nothing takes no pip', async () => {
+  const p = await bootPage('', AR(), { refuse: true });
+  p.window.GovStreetPage.openCard('access_requests:11');
+  await p.window.GovStreetPage.actOn('fine', {});
+  await settle();
+  assert.equal(p.byId.get('streetTodayN').textContent, '0 decided', 'a refused act is not a decision');
+});