@bongos/core 1.21.47 → 1.21.48

package/tests/feedback_latest.mjs

@@ -1,122 +0,0 @@
-// tests/feedback_latest.mjs — /feedback's resolver works with no bongos-app/ source (task 1004356).
-//
-// scripts/gds/feedback-latest.js used to require bongos-app/src/handoff.js, which left
-// this repo when the desktop apps moved off-repo (ADR 0098), so the script crashed at
-// startup and /feedback was dead. resolveLatest + feedbackBaseDir now live in the script.
-// This pins the ADR 0087 `latest` contract against a temp base dir: latest.json wins,
-// the latest/ symlink is optional, and with neither the reader self-heals by scanning for
-// the newest dir holding a prompt.md. Frames come back as absolute paths, never bytes.
-//
-// Run:  node --test tests/feedback_latest.mjs
-
-import { test } from 'node:test';
-import assert from 'node:assert/strict';
-import { mkdtempSync, mkdirSync, writeFileSync, rmSync, utimesSync } from 'node:fs';
-import { spawnSync } from 'node:child_process';
-import { createRequire } from 'node:module';
-import os from 'node:os';
-import path from 'node:path';
-import { fileURLToPath } from 'node:url';
-
-const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
-const SCRIPT = path.join(ROOT, 'scripts', 'gds', 'feedback-latest.js');
-const { resolveLatest, feedbackBaseDir } = createRequire(import.meta.url)(SCRIPT);
-
-function tempBase(t) {
-  const base = mkdtempSync(path.join(os.tmpdir(), 'feedback-latest-'));
-  t.after(() => rmSync(base, { recursive: true, force: true }));
-  return base;
-}
-
-// A bundle dir as bundle.js writes it: prompt.md citing its frames by absolute path.
-function writeBundle(base, id, { frames = [], mtime } = {}) {
-  const dir = path.join(base, id);
-  mkdirSync(dir, { recursive: true });
-  const refs = frames.map((f) => `![${f}](${path.join(dir, f)})`).join('\n');
-  writeFileSync(path.join(dir, 'prompt.md'), `# Walkthrough ${id}\n\n${refs}\n`);
-  for (const f of frames) writeFileSync(path.join(dir, f), 'png');
-  if (mtime) utimesSync(path.join(dir, 'prompt.md'), mtime, mtime);
-  return dir;
-}
-
-test('the script no longer depends on the off-repo bongos-app source', () => {
-  assert.equal(feedbackBaseDir(), path.join(os.homedir(), 'CloudBongos', 'feedback'));
-  const r = spawnSync(process.execPath, [SCRIPT, '--json', '--base', path.join(os.tmpdir(), 'no-such-feedback-dir-1004356')], { encoding: 'utf8' });
-  assert.equal(r.status, 0, r.stderr);
-  assert.equal(JSON.parse(r.stdout).ok, false);
-});
-
-test('an empty or missing base dir resolves to null', async (t) => {
-  const base = tempBase(t);
-  assert.equal(await resolveLatest(base), null);
-  mkdirSync(path.join(base, 'not-a-bundle')); // a dir with no prompt.md is not a bundle
-  assert.equal(await resolveLatest(base), null);
-  assert.equal(await resolveLatest(path.join(base, 'missing')), null);
-});
-
-test('latest.json is authoritative over a newer dir', async (t) => {
-  const base = tempBase(t);
-  const old = writeBundle(base, '2026-09-01-a', { frames: ['f2.png', 'f1.png'], mtime: new Date('2026-09-01') });
-  writeBundle(base, '2026-09-02-b', { mtime: new Date('2026-09-02') });
-  writeFileSync(path.join(base, 'latest.json'), JSON.stringify({ id: '2026-09-01-a', dir: old }));
-
-  const latest = await resolveLatest(base);
-  assert.equal(latest.id, '2026-09-01-a');
-  assert.equal(latest.dir, old);
-  assert.equal(latest.promptPath, path.join(old, 'prompt.md'));
-  assert.match(latest.promptMarkdown, /# Walkthrough 2026-09-01-a/);
-  // In the order prompt.md cites them, absolute.
-  assert.deepEqual(latest.imagePaths, [path.join(old, 'f2.png'), path.join(old, 'f1.png')]);
-  for (const p of latest.imagePaths) assert.ok(path.isAbsolute(p));
-});
-
-test('a pointer naming only an id resolves under the base dir', async (t) => {
-  const base = tempBase(t);
-  const dir = writeBundle(base, 'only-id', { mtime: new Date('2026-09-01') });
-  writeBundle(base, 'newer', { mtime: new Date('2026-09-05') });
-  writeFileSync(path.join(base, 'latest.json'), JSON.stringify({ id: 'only-id' }));
-  assert.equal((await resolveLatest(base)).dir, dir);
-});
-
-test('a stale or corrupt pointer self-heals to the newest bundle', async (t) => {
-  const base = tempBase(t);
-  writeBundle(base, 'older', { mtime: new Date('2026-09-01') });
-  const newest = writeBundle(base, 'newest', { mtime: new Date('2026-09-03') });
-
-  writeFileSync(path.join(base, 'latest.json'), JSON.stringify({ id: 'deleted-bundle' }));
-  assert.equal((await resolveLatest(base)).dir, newest);
-
-  writeFileSync(path.join(base, 'latest.json'), '{not json');
-  assert.equal((await resolveLatest(base)).dir, newest);
-
-  rmSync(path.join(base, 'latest.json'));
-  assert.equal((await resolveLatest(base)).dir, newest);
-});
-
-test('unreferenced frames in the bundle are still listed; missing refs are dropped', async (t) => {
-  const base = tempBase(t);
-  const dir = writeBundle(base, 'b', { frames: ['cited.png'] });
-  mkdirSync(path.join(dir, 'frames'));
-  writeFileSync(path.join(dir, 'frames', 'extra.jpg'), 'jpg');
-  writeFileSync(path.join(dir, 'prompt.md'),
-    `![a](${path.join(dir, 'cited.png')})\n![gone](${path.join(dir, 'gone.png')})\n`);
-  const latest = await resolveLatest(base);
-  assert.deepEqual(latest.imagePaths, [path.join(dir, 'cited.png'), path.join(dir, 'frames', 'extra.jpg')]);
-});
-
-test('the CLI prints the prompt body and each frame path', (t) => {
-  const base = tempBase(t);
-  const dir = writeBundle(base, 'cli', { frames: ['shot.png'] });
-  writeFileSync(path.join(base, 'latest.json'), JSON.stringify({ id: 'cli', dir }));
-
-  const text = spawnSync(process.execPath, [SCRIPT, '--base', base], { encoding: 'utf8' });
-  assert.equal(text.status, 0, text.stderr);
-  assert.match(text.stdout, /# Walkthrough cli/);
-  assert.ok(text.stdout.split('\n').includes(path.join(dir, 'shot.png')));
-
-  const json = spawnSync(process.execPath, [SCRIPT, '--json', `--base=${base}`], { encoding: 'utf8' });
-  const out = JSON.parse(json.stdout);
-  assert.equal(out.ok, true);
-  assert.equal(out.id, 'cli');
-  assert.deepEqual(out.imagePaths, [path.join(dir, 'shot.png')]);
-});