@bongos/core 1.21.42 → 1.21.43

package/modules/hall-ui/public/tweak-editor.html

@@ -142,9 +142,9 @@
 
 <div id="toast" class="toast" role="status" aria-live="polite" data-visible="0"></div>
 
-<script src="/builders/shell-trail.js?v=2026-10-04-palette"></script>
-<script src="/builders/craft-mode.js?v=2026-10-04-palette"></script>
-<script src="/builders/shell.js?v=2026-10-04-palette"></script>
+<script src="/builders/shell-trail.js?v=2026-10-04-nolegacy"></script>
+<script src="/builders/craft-mode.js?v=2026-10-04-nolegacy"></script>
+<script src="/builders/shell.js?v=2026-10-04-nolegacy"></script>
 <script src="/builders/palette.js" defer></script>
 <script src="/builders/dom-utils.js?v=2026-06-23-contrib"></script>
 <script src="/builders/brand-holes.js?v=2026-09-29-aqfix"></script>

package/modules/hall-ui/public/watch.html

@@ -162,9 +162,9 @@
 
 <!-- The app shell (sidebar + top bar). Dependency-free; loaded FIRST so the
      chrome exists before the page script runs. -->
-<script src="/builders/shell-trail.js?v=2026-10-04-palette"></script>
-<script src="/builders/craft-mode.js?v=2026-10-04-palette"></script>
-<script src="/builders/shell.js?v=2026-10-04-palette"></script>
+<script src="/builders/shell-trail.js?v=2026-10-04-nolegacy"></script>
+<script src="/builders/craft-mode.js?v=2026-10-04-nolegacy"></script>
+<script src="/builders/shell.js?v=2026-10-04-nolegacy"></script>
 <!-- jump palette (Ctrl/Cmd-K). Optional by design: without it the shell's slot stays hidden. -->
 <script src="/builders/palette.js" defer></script>
 <!-- shared frontend toolkit (window.OTB) — loaded before watch.js, which pulls from it. -->

package/modules/hall-ui/public/work.html

@@ -171,9 +171,9 @@
 
 <!-- The app shell (sidebar + top bar + footer). Dependency-free; runs at parse
      time so the chrome exists before the deferred page scripts execute. -->
-<script src="/builders/shell-trail.js?v=2026-10-04-palette"></script>
-<script src="/builders/craft-mode.js?v=2026-10-04-palette"></script>
-<script src="/builders/shell.js?v=2026-10-04-palette"></script>
+<script src="/builders/shell-trail.js?v=2026-10-04-nolegacy"></script>
+<script src="/builders/craft-mode.js?v=2026-10-04-nolegacy"></script>
+<script src="/builders/shell.js?v=2026-10-04-nolegacy"></script>
 <!-- jump palette (Ctrl/Cmd-K). Optional by design: without it the shell's slot stays hidden. -->
 <script src="/builders/palette.js" defer></script>
 <!-- shared frontend toolkit (window.OTB) — loaded FIRST so work.js can pull from it. -->

package/modules/hall-ui/records/craft-mode.md

@@ -4,9 +4,9 @@ Covers: every shelled hall page (`craft-mode.js`, `shell.js`, `style.css`), and
 
 ## What it is
 
-- On entering the hall, once per browser session, a signed-in builder is asked **"What are you doing now?"**: Building, Artistry, Ideating, Governing, or **Legacy mode** (the owner's fifth choice, 2026-10-01: the hall exactly as it was). The approved prototype is the design canvas linked on the task; the doors carry its four scenes (the work desk, the night room, the sky, the governor city).
-- The answer is ONE attribute, `html[data-craft="building|artistry|ideating|governing|legacy"]`, readable by every hall page. Every change also fires `otb:craft` on `document` with `{ detail: { mode } }`, so a page can react without polling.
-- The top bar carries a switch with all five; pressing one changes the mode without a reload. Under 1180px it drops the words; at phone width only the current mode shows (or a "Choose your mode" button when there is none), and tapping it opens the picker.
+- On entering the hall, once per browser session, a signed-in builder is asked **"What are you doing now?"**: Building, Artistry, Ideating or Governing. A fifth choice, **Legacy mode** (2026-10-01: the hall exactly as it was), was removed in task 1004567 (owner, 2026-10-04: "builder has all those tabs anyways"); a browser that still has `legacy` stored reads it as no mode, because `valid()` ignores any id that is not a mode. The approved prototype is the design canvas linked on the task; the doors carry its four scenes (the work desk, the night room, the sky, the governor city).
+- The answer is ONE attribute, `html[data-craft="building|artistry|ideating|governing"]`, readable by every hall page. Every change also fires `otb:craft` on `document` with `{ detail: { mode } }`, so a page can react without polling.
+- The top bar carries a switch with all four; pressing one changes the mode without a reload. Under 1180px it drops the words; at phone width only the current mode shows (or a "Choose your mode" button when there is none), and tapping it opens the picker.
 - Artistry is pre-selected for a builder whose `main_discipline` is `artist` (or, with no main role, whose first craft is).
 
 ## The rules an edit here must keep
@@ -23,14 +23,14 @@ Covers: every shelled hall page (`craft-mode.js`, `shell.js`, `style.css`), and
 
 ## The nav follows the mode (task 1004493)
 
-- **Each craft has a named tab list**, `MODE_TABS` in `craft-mode.js`, by NAV id. `ALWAYS_TABS` is the owner's list of tabs no mode may hide (2026-10-01: Builders, NAV id `roster`, first), and every mode's list is `ALWAYS_TABS` plus its own. Legacy and no mode have no entry, so they show every tab, as before.
+- **Each craft has a named tab list**, `MODE_TABS` in `craft-mode.js`, by NAV id. `ALWAYS_TABS` is the owner's list of tabs no mode may hide (2026-10-01: Builders, NAV id `roster`, first), and every mode's list is `ALWAYS_TABS` plus its own. No mode has no entry, so it shows every tab, as before.
 - **Government shows only in Governing**, and outside that group Governing is the shortest list (Blockers, Board Room). Building is every tab except Government and the Board Room; Artistry is Studio, Goals, Your thinking; Ideating is Sky, Your thinking, Goals. The prototype names rooms that do not exist yet (Store, Page reviews, Treasury); a list names only real NAV items, and `tests/craft_mode_nav.mjs` requires every NAV item to sit in some mode.
 - **The mode only ever takes away, and never through `hidden`.** The access gate owns `hidden`; `applyNav()` marks what the mode leaves out with `[data-craft-off]`, which `style.css` hides. So a mode can never show a tab the gate hid, and switching mode just moves the attribute. A group head goes too once nothing under it shows.
 - **Two callers.** `apply()` runs it on every mode change (live, no reload), and `shell.js` `applyAccess` runs it right after its gate loop, so a later `/me` answer (a promotion, a permission) brings a head back with its tabs. Hidden tabs still open by their URL; nothing is enforced (ADR 0016).
 
 ## Each mode's look (task 1004495)
 
-- **Three modes wear a look; Building, Legacy and no mode wear none.** Artistry, Ideating and Governing each set `--craft` (where you are) and `--craft-on` (text on it) on `html[data-craft="<mode>"]`, with a dark twin on `html[data-theme="dark"][data-craft="<mode>"]` that also darkens the ground and tints the glass (Artistry, Ideating). Values and contrast are the direction's, `docs/design/craft-mode-direction.md`. No rule in `style.css` names `building` or `legacy`, and none matches any mode at all; `tests/craft_mode_looks.mjs` pins both, and re-measures every colour pair.
+- **Three modes wear a look; Building and no mode wear none.** Artistry, Ideating and Governing each set `--craft` (where you are) and `--craft-on` (text on it) on `html[data-craft="<mode>"]`, with a dark twin on `html[data-theme="dark"][data-craft="<mode>"]` that also darkens the ground and tints the glass (Artistry, Ideating). Values and contrast are the direction's, `docs/design/craft-mode-direction.md`. No rule in `style.css` names `building`, and none matches any mode at all; `tests/craft_mode_looks.mjs` pins both, and re-measures every colour pair.
 - **The accent stays the action colour.** `--craft` paints only the switch's current pill, the current tab (tint, icon, label, marker) and the top bar's hairline.
 - **Two pieces are drawn by `craft-mode.js` `applyLook()`, on every mode change:** the eyebrow beside `#topbar-title` (`LOOKS`: "the studio · night", "the sky", "the city"; hidden at <=640px, where it overflowed phones) and the scene plate under `.app-sidebar__brand` (40px closed rail, 64px open). The plate's markup IS `artHtml(mode)`, the picker's door art, exported rather than copied; light mode recolours it to each scene's day (the city is the dark one through `invert(1) hue-rotate(180deg)`). It does not animate.
 - **Always-present tabs widened** (owner, 2026-10-03): `ALWAYS_TABS` is Builders, Collab and Profile, so every mode keeps the You and Community groups.

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.42",
+  "version": "1.21.43",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.21.42",
+      "version": "1.21.43",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.42",
+  "version": "1.21.43",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -9016,5 +9016,11 @@
       "id": "1004568",
       "text": "Street cards are now only as tall as their words need. Long titles, reasons and lines are cut short with an ellipsis at a whole word, and the full text is one tap away under \"more\". The automation card no longer stretches: its"
     }
+  ],
+  "1.21.43": [
+    {
+      "id": "1004567",
+      "text": "Legacy mode is gone from the builders hall. The mode picker now offers four doors (Building, Artistry, Ideating, Governing) and the top-bar switch shows those four. Anyone who still had Legacy saved simply lands with no mode c"
+    }
   ]
 }

package/src/module-api.js

@@ -75,7 +75,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.21.42'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.21.43'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/craft_mode.mjs

@@ -1,7 +1,7 @@
 // tests/craft_mode.mjs — the hall's craft mode picker (task 1004492, goal 1000095 WA6).
 //
 // On entering the hall a picker asks once per session "What are you doing
-// now?" (Building, Artistry, Ideating, Governing, or Legacy mode); the answer is
+// now?" (Building, Artistry, Ideating or Governing); the answer is
 // html[data-craft], and a switch in the top bar changes it without a reload.
 // These cases boot the REAL shell-trail.js + craft-mode.js + shell.js in a DOM
 // stub, in the order every hall page loads them, and drive them the way a
@@ -142,7 +142,7 @@ function boot({ craft = true, session = {}, store = {}, throws = false, optOut =
     picker,
     signIn: (builder = { id: 7, rank: 'thetes' }) => shell.applyAccess({ authed: true, rank: builder.rank, builder }),
     signOut: () => shell.applyAccess({ authed: false }),
-    // Press a picker button: a door, Legacy, or the close button.
+    // Press a picker button: a door or the close button.
     pick(attr, value, { askAgain = true } = {}) {
       const p = picker();
       const box = p.querySelector('[data-craft-again]');
@@ -161,7 +161,7 @@ function boot({ craft = true, session = {}, store = {}, throws = false, optOut =
   };
 }
 
-const MODES = ['building', 'artistry', 'ideating', 'governing', 'legacy'];
+const MODES = ['building', 'artistry', 'ideating', 'governing'];
 const noSwitch = (html) => html.replace(/<div class="craft-switch[\s\S]*?<\/div>/, '');
 
 test('NO MODE IS THE HALL AS TODAY: with no mode chosen, nothing but the switch differs from a hall without craft modes', () => {
@@ -184,7 +184,8 @@ test('a signed-in builder is asked ONCE per session, and a reload does not ask a
   assert.match(html, /role="dialog" aria-modal="true"/);
   assert.match(html, /What are you doing now\?/);
   for (const m of ['building', 'artistry', 'ideating', 'governing']) assert.match(html, new RegExp(`data-craft-pick="${m}"`), `a ${m} door`);
-  assert.match(html, /data-craft-pick="legacy"[^>]*>Legacy mode/, 'Legacy mode is the fifth choice (owner, 2026-10-01)');
+  assert.equal([...html.matchAll(/data-craft-pick="/g)].length, 4, 'four doors and nothing else to pick');
+  assert.doesNotMatch(html, /legacy/i, 'Legacy mode is gone (owner, 2026-10-04: Building has all those tabs anyway)');
   p.escape();
   assert.equal(p.picker(), null, 'Escape closes it without choosing');
   assert.equal(p.mode(), undefined, 'and leaves the hall with no mode');
@@ -229,17 +230,33 @@ test('unticking "Ask me again next session" keeps the mode for later sessions',
   assert.equal(tomorrow.picker(), null, 'and nobody is asked');
 });
 
-test('THE HEADER SWITCH changes the mode without a reload, and offers all five', () => {
+test('THE HEADER SWITCH changes the mode without a reload, and offers the four crafts', () => {
   const p = boot();
   const opts = [...p.topbar.innerHTML.matchAll(/data-craft-opt="([a-z]+)"/g)].map((m) => m[1]);
-  assert.deepEqual(opts, MODES, 'the four crafts, then Legacy');
+  assert.deepEqual(opts, MODES, 'the four crafts, and no Legacy');
   p.press('artistry');
   assert.equal(p.mode(), 'artistry');
-  p.press('legacy');
-  assert.equal(p.mode(), 'legacy', 'anyone can go back to the old view at any time');
-  assert.deepEqual(p.pressed(), ['legacy']);
+  p.press('building');
+  assert.equal(p.mode(), 'building', 'anyone can switch at any time');
+  assert.deepEqual(p.pressed(), ['building']);
   assert.equal(p.location.reloads, 0, 'no navigation happened');
-  assert.equal(p.session['hall-craft'], 'legacy', 'and the session remembers it');
+  assert.equal(p.session['hall-craft'], 'building', 'and the session remembers it');
+});
+
+test('a browser that still has Legacy stored falls back to NO MODE (task 1004567)', () => {
+  const session = { 'hall-craft': 'legacy', 'hall-craft-asked': '1' };
+  const store = { 'hall-craft-keep': 'legacy' };
+  const p = boot({ session, store });
+  p.signIn();
+  assert.equal(p.mode(), undefined, 'no html[data-craft]: the hall with every tab');
+  assert.deepEqual(p.pressed(), [], 'no switch option lit');
+  assert.equal(p.picker(), null, 'this session already saw the picker, so it is not asked again');
+  const kept = boot({ store });
+  kept.signIn();
+  assert.equal(kept.mode(), undefined, 'a kept Legacy from an earlier session is no mode too');
+  assert.ok(kept.picker(), 'and a new session is asked to pick one of the four');
+  p.press('building');
+  assert.equal(p.mode(), 'building', 'and any of the four can be chosen from there');
 });
 
 test('on a phone the switch shows only the current mode, and tapping it opens the picker', () => {

package/tests/craft_mode_looks.mjs

@@ -3,7 +3,7 @@
 //
 // Artistry, Ideating and Governing each wear a look: --craft / --craft-on tokens
 // (light + dark twins) in style.css, the header eyebrow beside the page title and
-// the door's scene framed under the brand. Building, Legacy and no mode wear
+// the door's scene framed under the brand. Building and no mode wear
 // NOTHING — the hall as it always was. These cases run the REAL craft-mode.js over
 // a small DOM and read the REAL style.css, so a look that leaks into Building, a
 // plate that is a second copy of the art, or a colour that loses its contrast reds.
@@ -94,11 +94,11 @@ test('each looked mode frames its own door scene under the brand, and names itse
   }
 });
 
-test('BUILDING, LEGACY AND NO MODE WEAR NO LOOK: no plate, no eyebrow, and switching to them takes the look away', () => {
+test('BUILDING AND NO MODE WEAR NO LOOK: no plate, no eyebrow, and switching to them takes the look away', () => {
   const none = boot();
   assert.equal(none.root.dataset.craft, undefined);
   assert.equal(none.plates().length + none.marks().length, 0, 'no mode draws nothing');
-  for (const m of ['building', 'legacy']) {
+  for (const m of ['building']) {
     const p = boot({ 'hall-craft': m });
     assert.equal(p.plates().length + p.marks().length, 0, `${m} at boot draws nothing`);
     p.craft.choose('governing');
@@ -118,10 +118,10 @@ test('the art is drawn once: craft-mode.js has one artHtml and exports it', () =
 // Every selector in style.css that names a craft mode.
 const CRAFT_SELECTORS = [...CSS.matchAll(/data-craft="([a-z]+)"/g)].map((m) => m[1]);
 
-test('style.css names only the three looked modes — Building and Legacy have no rule at all', () => {
+test('style.css names only the three looked modes — Building has no rule at all', () => {
   assert.ok(CRAFT_SELECTORS.length >= 12, `found ${CRAFT_SELECTORS.length} craft selectors`);
   for (const m of CRAFT_SELECTORS) assert.ok(LOOKED.includes(m), `a rule names data-craft="${m}"`);
-  assert.doesNotMatch(CSS, /data-craft="(building|legacy)"/);
+  assert.doesNotMatch(CSS, /data-craft="building"/);
   assert.doesNotMatch(CSS, /data-craft\]/, 'no rule matches ANY mode, which would dress Building too');
 });
 

package/tests/craft_mode_nav.mjs

@@ -1,8 +1,8 @@
 // tests/craft_mode_nav.mjs — the hall nav follows the craft mode (task 1004493,
 // goal 1000095 WA6).
 //
-// Each craft mode shows only the tabs its craft needs; Legacy mode and no mode
-// show every tab, exactly as before. The owner's rule (2026-10-01): some tabs
+// Each craft mode shows only the tabs its craft needs; no mode
+// shows every tab, exactly as before. The owner's rule (2026-10-01): some tabs
 // stay in EVERY mode, Builders first among them, written down as ONE shared list
 // that each mode's list adds to; on 2026-10-03 Collab and Profile joined it. These cases boot the REAL shell-trail.js +
 // craft-mode.js + shell.js and read the sidebar the shell actually rendered, so a
@@ -157,15 +157,15 @@ test('Government shows only in Governing, and Governing is the shortest list', (
   assert.equal(Math.min(...lengths), lengths[CRAFTS.indexOf('governing')], 'outside its own Government group, Governing shows the fewest tabs');
 });
 
-test('NO MODE AND LEGACY ARE TODAY\'S NAV: every tab the gate allows, nothing marked', () => {
+test('NO MODE IS TODAY\'S NAV: every tab the gate allows, nothing marked — and a stored Legacy is no mode', () => {
   const none = boot();
   none.signIn();
   const all = none.showing();
   assert.deepEqual(all, NAV_IDS, 'an archon with no mode sees every tab');
   const legacy = boot({ session: { 'hall-craft': 'legacy' } });
   legacy.signIn();
-  assert.deepEqual(legacy.showing(), all, 'Legacy mode shows exactly the same');
-  assert.equal(legacy.craft.tabsFor('legacy'), null);
+  assert.equal(legacy.root.dataset.craft, undefined, 'Legacy was removed (task 1004567), so it reads as no mode');
+  assert.deepEqual(legacy.showing(), all, 'and shows exactly the same');
 });
 
 test('each mode shows its own tabs, and switching updates the nav live', () => {
@@ -178,8 +178,8 @@ test('each mode shows its own tabs, and switching updates the nav live', () => {
     for (const id of ['roster', 'collab', 'profile']) assert.ok(p.showing().includes(id), `${id} stays in ${m}`);
     assert.equal(p.headShowing('government'), m === 'governing', `the Government head shows only where its tabs do (${m})`);
   }
-  p.craft.choose('legacy');
-  assert.deepEqual(p.showing(), NAV_IDS, 'back to Legacy, every tab returns without a reload');
+  p.craft.choose('building');
+  assert.deepEqual(new Set(p.showing()), new Set(p.craft.tabsFor('building')), 'back to Building, its tabs return without a reload');
 });
 
 test('a mode never shows a tab the gate hid, and a later gate pass keeps the mode', () => {

package/tests/hall_tweak_editor.mjs

@@ -635,7 +635,7 @@ try {
     assert.match(HTML, /<body data-page="tweak-editor"[^>]*data-fullscreen-switch/);
     assert.equal((HTML.match(/<h1\b/g) || []).length, 1);
     assert.ok(HTML.indexOf('tweak-editor-lib.js') < HTML.indexOf('tweak-editor.js?'), 'the lib loads first');
-    assert.match(HTML, /shell\.js\?v=2026-10-04-palette/);
+    assert.match(HTML, /shell\.js\?v=2026-10-04-nolegacy/);
     assert.equal(/fonts\.googleapis\.com\/css/.test(HTML), false);
     for (const id of ['tw-bar', 'tw-counter', 'tw-open', 'tw-open-more', 'tw-divider', 'tw-openwrap', 'tw-open-menu', 'tw-open-tab', 'tw-open-split', 'tw-frame', 'tw-frame-view', 'tw-split-close', 'tw-download', 'tw-upload', 'tw-file', 'tw-submit', 'tw-paper', 'tw-doc', 'tw-notice', 'tw-done', 'tw-take', 'tw-pick', 'tw-picks', 'tw-refused', 'tw-refused-title', 'tw-refused-list', 'tw-refused-next', 'tw-refused-download', 'tw-refused-close']) {
       assert.ok(new RegExp(`id="${id}"`).test(HTML), `#${id} is in the markup`);

package/tests/page_notes_panel.mjs

@@ -79,7 +79,7 @@ test('THE PALETTE: in the top bar in Artistry alone, right before the switch, an
   assert.deepEqual(p.tools().map((t) => t.id), ['craft-tool-palette']);
   assert.equal(p.tools()[0].nextSibling, p.sw, 'it sits right before the mode switch');
   assert.equal(p.tools()[0].getAttribute('aria-label'), 'Write feedback on this page');
-  for (const m of ['building', 'ideating', 'governing', 'legacy']) {
+  for (const m of ['building', 'ideating', 'governing']) {
     p.craft.choose(m);
     assert.equal(p.tools().length, 0, `no palette in ${m}`);
   }