@bongos/core 1.21.41 → 1.21.43

package/tests/craft_mode_nav.mjs

@@ -1,8 +1,8 @@
 // tests/craft_mode_nav.mjs — the hall nav follows the craft mode (task 1004493,
 // goal 1000095 WA6).
 //
-// Each craft mode shows only the tabs its craft needs; Legacy mode and no mode
-// show every tab, exactly as before. The owner's rule (2026-10-01): some tabs
+// Each craft mode shows only the tabs its craft needs; no mode
+// shows every tab, exactly as before. The owner's rule (2026-10-01): some tabs
 // stay in EVERY mode, Builders first among them, written down as ONE shared list
 // that each mode's list adds to; on 2026-10-03 Collab and Profile joined it. These cases boot the REAL shell-trail.js +
 // craft-mode.js + shell.js and read the sidebar the shell actually rendered, so a
@@ -157,15 +157,15 @@ test('Government shows only in Governing, and Governing is the shortest list', (
   assert.equal(Math.min(...lengths), lengths[CRAFTS.indexOf('governing')], 'outside its own Government group, Governing shows the fewest tabs');
 });
 
-test('NO MODE AND LEGACY ARE TODAY\'S NAV: every tab the gate allows, nothing marked', () => {
+test('NO MODE IS TODAY\'S NAV: every tab the gate allows, nothing marked — and a stored Legacy is no mode', () => {
   const none = boot();
   none.signIn();
   const all = none.showing();
   assert.deepEqual(all, NAV_IDS, 'an archon with no mode sees every tab');
   const legacy = boot({ session: { 'hall-craft': 'legacy' } });
   legacy.signIn();
-  assert.deepEqual(legacy.showing(), all, 'Legacy mode shows exactly the same');
-  assert.equal(legacy.craft.tabsFor('legacy'), null);
+  assert.equal(legacy.root.dataset.craft, undefined, 'Legacy was removed (task 1004567), so it reads as no mode');
+  assert.deepEqual(legacy.showing(), all, 'and shows exactly the same');
 });
 
 test('each mode shows its own tabs, and switching updates the nav live', () => {
@@ -178,8 +178,8 @@ test('each mode shows its own tabs, and switching updates the nav live', () => {
     for (const id of ['roster', 'collab', 'profile']) assert.ok(p.showing().includes(id), `${id} stays in ${m}`);
     assert.equal(p.headShowing('government'), m === 'governing', `the Government head shows only where its tabs do (${m})`);
   }
-  p.craft.choose('legacy');
-  assert.deepEqual(p.showing(), NAV_IDS, 'back to Legacy, every tab returns without a reload');
+  p.craft.choose('building');
+  assert.deepEqual(new Set(p.showing()), new Set(p.craft.tabsFor('building')), 'back to Building, its tabs return without a reload');
 });
 
 test('a mode never shows a tab the gate hid, and a later gate pass keeps the mode', () => {

package/tests/governor_docket.mjs

@@ -399,7 +399,9 @@ test('the fence: a matter only when it needs a governor, and only a fence manage
   const off = autonomyDocket.fenceDocketMatters({ enabled: false, paused_reason: 'payments touched', goals: [{ goal_id: 1 }], updated_by: 3 }, true);
   assert.equal(off.length, 1);
   assert.equal(off[0].title, 'Unattended building is switched off');
-  assert.equal(off[0].where, 'automation · the switch · payments touched');
+  assert.equal(off[0].where, 'automation · the switch', 'the kicker is building · floor only (task 1004568)');
+  assert.equal(off[0].detail, 'payments touched', 'the reason rides in detail: the fact, and the more');
+  assert.equal(autonomyDocket.fenceDocketMatters({ enabled: false, goals: [] }, true)[0].detail, undefined, 'no reason, no detail');
   assert.equal(off[0].state, 'needs');
   assert.equal(autonomyDocket.fenceDocketMatters({ enabled: false, goals: [] }, false)[0].state, 'settled');
   assert.equal(autonomyDocket.fenceDocketMatters({ enabled: true, goals: [] }, true)[0].title, 'Unattended building is on, but no goal is allowed');

package/tests/hall_matter_card.mjs

@@ -507,6 +507,77 @@ test('the docket hands a matter its detail only as text, bounded, and only when
   }
 });
 
+// ── the compact card sizes to its words (task 1004568) ─────────────────────
+
+const allText = (n) => [n._text || ''].concat((n.children || []).map(allText)).join('\n');
+
+test('a very long reason stays within the compact card and is whole under more; the kicker is building · floor only', () => {
+  const docketJs = require(path.join(ROOT, 'modules/government/docket.js'));
+  const fence = require(path.join(ROOT, 'modules/autonomy/governor-docket.js'));
+  const reason = 'lars: stop runner for performance evaluation (2026-10-02) while the grader is rebuilt, then switch it back on once the new numbers are in and the owner has read them';
+  // the whole path: the autonomy module's matter, through the docket's normaliser, into the card
+  const raw = fence.fenceDocketMatters({ enabled: false, paused_reason: reason, goals: [], updated_by: 3, updated_at: '2026-10-02T10:00:00.000Z' }, true)[0];
+  const m = docketJs.normalizeMatter(raw, { source: 'autobongos_fence', building: 'automation' });
+  assert.equal(m.where, 'automation · the switch', 'the reason is not joined into the kicker');
+  const d = docket([m]);
+  const cv = D.cardFor(m.id, d, { now: NOW });
+  assert.equal(cv.where, 'automation · the switch');
+  assert.ok(cv.fact.length <= C.LINE.fact && /…$/.test(cv.fact), 'the fact is one line, cut, and says so: ' + cv.fact);
+  assert.ok(reason.startsWith(cv.fact.replace(/…$/, '')), 'the fact is the reason, cut');
+  assert.equal(reason.charAt(cv.fact.length - 1), ' ', 'never mid-word');
+  const { document } = fakeDom();
+  const shut = document.createElement('div');
+  C.render(document, shut, cv, { act() {}, openForm() {}, ask() {}, more() {}, pick() {} }, { more: false });
+  assert.ok(!allText(shut).includes(reason), 'the compact card does not carry the whole reason');
+  assert.equal(walk(shut, (n) => n.className === 'mcard-fact').length, 1, 'one fact line');
+  const open = document.createElement('div');
+  C.render(document, open, cv, { act() {}, openForm() {}, ask() {}, more() {}, pick() {} }, { more: true });
+  assert.ok(allText(open).includes(reason), 'more shows the reason whole');
+  // no reason, no fact
+  const bare = docketJs.normalizeMatter(fence.fenceDocketMatters({ enabled: false, goals: [] }, true)[0], { source: 'autobongos_fence', building: 'automation' });
+  assert.equal(D.cardFor(bare.id, docket([bare]), { now: NOW }).fact, '');
+});
+
+test('every part of the compact card is held to its line: the kicker, the title, the listed lines, a voice\'s reason', () => {
+  const long = (w) => Array.from({ length: 40 }, (_, i) => w + i).join(' ');
+  const m = matter({ id: 'blockers:9', source: 'blockers', building: 'review', rule: 'decide', where: long('where'), title: long('title'), detail: long('detail'), ref: { type: 'blocker', id: '9' } });
+  const cv = C.model({ docket: docket([m]), key: m.id, now: NOW });
+  for (const [k, n] of [['where', C.LINE.where], ['title', C.LINE.title], ['fact', C.LINE.fact]]) {
+    assert.ok(cv[k].length <= n && /…$/.test(cv[k]), k + ' is cut: ' + cv[k]);
+    const whole = long(k === 'fact' ? 'detail' : k);
+    assert.ok(whole.startsWith(cv[k].replace(/…$/, '')), k + ' keeps its own words');
+    assert.equal(whole.charAt(cv[k].length - 1), ' ', k + ' cut at a word, not inside one');
+  }
+  const words = cv.more.text.map((x) => x.words);
+  assert.ok(words.includes(long('title')), 'the whole title is under more');
+  assert.ok(words.includes(long('where').toLowerCase()), 'the whole kicker is under more');
+  assert.ok(words.includes(long('detail')), 'the whole detail is under more');
+  // the queue's listed lines and an objection's reason
+  const lines = C.compact({ where: '', title: '', fact: '', lines: [long('line')], voices: [{ side: 'against', by: 'Kai', words: long('because') }], more: null });
+  assert.ok(lines.lines[0].length <= C.LINE.line && lines.voices[0].words.length <= C.LINE.reason);
+  assert.deepEqual(lines.more.text.map((x) => x.words).sort(), [long('because'), long('line')].sort(), 'both whole under more');
+  // a text "more" already holds, shortened by its own bound, is not added twice
+  const huge = long('w').repeat(40);
+  assert.ok(huge.length > 4000, 'longer than more keeps');
+  const twice = C.compact({ where: '', title: huge, fact: '', lines: [], voices: [], more: { text: [{ label: '', words: huge.slice(0, 3999).trim() + '…' }], who: '', when: '', history: [] } });
+  assert.equal(twice.more.text.length, 1, 'no duplicate under more');
+  // short words are left alone, and add nothing to more
+  const short = C.compact({ where: 'review · blockers', title: 'Pick a host', fact: 'waits on you', lines: ['one'], voices: [], more: null });
+  assert.deepEqual([short.where, short.title, short.fact, short.lines, short.more], ['review · blockers', 'Pick a host', 'waits on you', ['one'], null]);
+});
+
+test('the card has no fixed height: no min-height on its parts, every one-line part is held to one line', () => {
+  const css = read('street-card.css') + read('street.css');
+  const rules = [...css.matchAll(/([^{}]*street-card[^{}]*)\{([^}]*)\}/g)];
+  for (const [, sel, body] of rules) if (!/__close/.test(sel)) assert.doesNotMatch(body, /(^|;)\s*(min-height|height)\s*:/, 'no fixed height on ' + sel.trim());
+  const card = read('street-card.css');
+  for (const sel of ['.street-card__head .street-label', '.mcard-fact', '.street-card__lines li']) {
+    const body = card.split(sel + ' {')[1];
+    assert.ok(body && /white-space: nowrap/.test(body.split('}')[0]) && /text-overflow: ellipsis/.test(body.split('}')[0]), sel + ' is one line');
+  }
+  assert.match(card, /\.street-card__title \{[^}]*-webkit-line-clamp: 3/);
+});
+
 // ── the Board Room names the new subjects ───────────────────────────────────
 
 test('the Board Room labels a building\'s matter as that building\'s matter, and a who-decides change as its own amendment', () => {

package/tests/hall_tweak_editor.mjs

@@ -635,7 +635,7 @@ try {
     assert.match(HTML, /<body data-page="tweak-editor"[^>]*data-fullscreen-switch/);
     assert.equal((HTML.match(/<h1\b/g) || []).length, 1);
     assert.ok(HTML.indexOf('tweak-editor-lib.js') < HTML.indexOf('tweak-editor.js?'), 'the lib loads first');
-    assert.match(HTML, /shell\.js\?v=2026-10-04-palette/);
+    assert.match(HTML, /shell\.js\?v=2026-10-04-nolegacy/);
     assert.equal(/fonts\.googleapis\.com\/css/.test(HTML), false);
     for (const id of ['tw-bar', 'tw-counter', 'tw-open', 'tw-open-more', 'tw-divider', 'tw-openwrap', 'tw-open-menu', 'tw-open-tab', 'tw-open-split', 'tw-frame', 'tw-frame-view', 'tw-split-close', 'tw-download', 'tw-upload', 'tw-file', 'tw-submit', 'tw-paper', 'tw-doc', 'tw-notice', 'tw-done', 'tw-take', 'tw-pick', 'tw-picks', 'tw-refused', 'tw-refused-title', 'tw-refused-list', 'tw-refused-next', 'tw-refused-download', 'tw-refused-close']) {
       assert.ok(new RegExp(`id="${id}"`).test(HTML), `#${id} is in the markup`);

package/tests/page_notes_panel.mjs

@@ -79,7 +79,7 @@ test('THE PALETTE: in the top bar in Artistry alone, right before the switch, an
   assert.deepEqual(p.tools().map((t) => t.id), ['craft-tool-palette']);
   assert.equal(p.tools()[0].nextSibling, p.sw, 'it sits right before the mode switch');
   assert.equal(p.tools()[0].getAttribute('aria-label'), 'Write feedback on this page');
-  for (const m of ['building', 'ideating', 'governing', 'legacy']) {
+  for (const m of ['building', 'ideating', 'governing']) {
     p.craft.choose(m);
     assert.equal(p.tools().length, 0, `no palette in ${m}`);
   }