@bongos/core 1.21.4 → 1.21.5

package/tests/projects_hub.mjs

@@ -283,9 +283,14 @@ test('/create is absorbed — the wizard lives here and the route only redirects
   const server = fs.readFileSync(path.join(ROOT, 'src', 'platform-server.js'), 'utf8');
   assert.match(server, /res\.redirect\(302, '\/projects\?view=new'/,
     '/create must 302 into the hub (302, not 301: the URL is an OAuth return target in the wild)');
-  for (const id of ['panel-gate', 'panel-name', 'panel-type', 'panel-home', 'panel-address', 'panel-review', 'panel-done']) {
+  // the six blended screens (task 1004504): every one is real markup, and the steps they
+  // folded in are gone rather than left behind as dead panels
+  for (const id of ['panel-gate', 'panel-fork', 'panel-what', 'panel-checks', 'panel-review', 'panel-look', 'panel-done']) {
     assert.match(HUB, new RegExp(`id="${id}"`), `the wizard's ${id} ships as real markup (C7)`);
   }
+  for (const id of ['panel-terms', 'panel-physics', 'panel-name', 'panel-type', 'panel-detail', 'panel-modules', 'panel-home', 'panel-address', 'panel-app']) {
+    assert.doesNotMatch(HUB, new RegExp(`id="${id}"`), `the retired ${id} is gone (task 1004504)`);
+  }
 });
 
 test('the wizard step indices stay coupled — data-next lands one past its own panel (task 1002772)', () => {
@@ -308,10 +313,10 @@ test('the wizard step indices stay coupled — data-next lands one past its own
   for (const m of HUB.matchAll(/data-back="(\d+)"/g)) {
     assert.ok(map[Number(m[1])], `data-back="${m[1]}" must point at a mapped panel`);
   }
-  // the rail numbers every step except the gate and the done panel
+  // the numbered rail is gone (task 1004504): no beat is left to drift from the map
   const beats = [...HUB.matchAll(/data-step="(\d+)"/g)].map((x) => Number(x[1]));
-  assert.equal(Math.max.apply(null, beats), Object.keys(map).length - 2,
-    'the rail shows every numbered step except gate and done');
+  assert.deepEqual(beats, [], 'no rail beat is left on the page');
+  assert.doesNotMatch(HUB, /class="steps"/, 'no <ol class="steps"> rail in the wizard');
 });
 
 test('the absorbed wizard sheds its two URL landmines — /gate/ and the whole-query strip', () => {
@@ -657,40 +662,59 @@ test('every per-step hook in show() still points at the panel it belongs to (ren
   const STEP = {};
   for (const m of map.matchAll(/(\d+):\s*'([a-z-]+)'/g)) STEP[m[2]] = Number(m[1]);
   const show = SCRIPT.slice(SCRIPT.indexOf('function show(step, moveFocus)'));
-  const body = show.slice(0, show.search(/\n\s*\/\* One delegated pair on the rail/));
-
-  assert.ok(body.includes(`if (step === ${STEP['panel-home']}) { syncHome();`),
-    'the repo probe fires on the Home panel');
-  assert.ok(body.includes(`if (step === ${STEP['panel-address']}) { checkSlugAvailable(); renderAddrPanel(); }`),
-    'the handle re-check fires on the Address panel');
-  assert.ok(body.includes(`if (step === ${STEP['panel-review']}) renderReview();`),
-    'the review is rendered on the Review panel');
-  assert.ok(body.includes(`'wizDone', step === ${STEP['panel-done']}`),
-    'the done panel is the one that takes the whole card');
-  // and the About panel claims no hook of its own — it has nothing to fetch
-  assert.ok(!body.includes(`if (step === ${STEP['panel-detail']})`),
-    'the optional step needs no side effect; adding one would give it a way to fail');
-});
-
-test('the About step is OFFERED by every form and can be walked past — the skip is a real control (task 1002334)', () => {
-  const about = (HUB.match(/<section class="panel" id="panel-detail"[\s\S]*?<\/section>/) || [''])[0];
-  assert.ok(about, '#panel-detail ships as real markup');
-  assert.match(about, /id="f-desc"/, 'it asks what the owner is building — the publish gate half');
-  assert.match(about, /id="teamCards"/, 'and who is building it — what the recommendations read');
-  // the skip must be its OWN button: "leave it blank and press Next" is an
-  // escape hatch the visitor has to infer, which is not an optional step
-  assert.match(about, /id="skipDetail"/, 'the skip is a control, not an inference');
-  assert.match(about, /Optional/, 'and the panel says so before it asks');
-  // the consequence of skipping is stated where the choice is made
-  assert.match(SCRIPT, /stays off the public map until it has one/,
-    'skipping names its cost (ADR 0182 D4), never leaves it to be discovered later');
-  // nothing in validateStep may gate the About step
+  const endAt = show.search(/\n\s*\$\('wizBack'\)\.addEventListener\('click'/);
+  assert.ok(endAt > 0, 'show() still ends where the one Back button is wired — re-point this slice if it moved');
+  const body = show.slice(0, endAt);
+
+  // task 1004504: the old Home / Address / App steps live as rows on the review, so their
+  // entry hooks moved there — one block, run on every entry to the review
+  const review = (body.match(new RegExp(`if \\(step === ${STEP['panel-review']}\\) \\{([\\s\\S]*?)\\n      \\}`)) || [, ''])[1];
+  assert.ok(review, 'the review screen has its own entry block');
+  assert.match(review, /syncHome\(\);/, 'the code row repaints its repo controls on the review');
+  assert.match(review, /if \(authKnown\) ensureRepoAccess\(\);/, 'the repo probe fires on the review, and never before /me settles');
+  assert.match(review, /checkSlugAvailable\(\); renderAddrPanel\(\);/, 'the handle re-check fires on the review (N10)');
+  assert.match(review, /syncAppStep\(\); syncRenderSetup\(\);/, 'the app row repaints its choice');
+  assert.match(review, /renderModules\(\);/, 'the extras row paints the picker');
+  assert.match(review, /paintSetup\(\);/, 'and the rows are painted on the review');
+  assert.ok(body.includes(`if (step === ${STEP['panel-fork']}) paintDoors();`),
+    'the fork repaints its two doors against the tick');
+  assert.ok(body.includes(`if (step === ${STEP['panel-checks']}) { physLoadAccountOnce(); paintChecks(); }`),
+    'the quick checks paint on the checks screen');
+  assert.ok(body.includes(`if (step === ${STEP['panel-look']}) { renderLook(); renderRecap(); }`),
+    'the look and the recap paint on the look screen, the one Create sits on');
+  // the room behind the wizard follows the screen, through one map keyed like panels
+  assert.match(body, /\$\('wizRoom'\)\.setAttribute\('data-screen', SCREEN\[step\]\);/, 'show() writes the room\'s data-screen');
+  const screens = (SCRIPT.match(/var SCREEN = \{([^}]*)\}/) || [, ''])[1];
+  assert.deepEqual([...screens.matchAll(/(\d+):/g)].map((m) => Number(m[1])), Object.values(STEP).sort((a, b) => a - b),
+    'SCREEN names every panel the map holds, and nothing else');
+  // and the done panel claims no hook of its own — renderDone runs from the create
+  assert.ok(!body.includes(`if (step === ${STEP['panel-done']})`),
+    'the done panel is painted by the create, not by a show() hook');
+});
+
+test('the About answers are OFFERED by every form and can be walked past (task 1002334; folded into the screens by task 1004504)', () => {
+  // the About step is gone (task 1004504): its sentence is the optional field on "What are
+  // you making?", and its team shape is a choice on the review's Team size row
+  assert.doesNotMatch(HUB, /id="panel-detail"|id="skipDetail"|id="detailSkipNote"/, 'no About panel and no skip button are left');
+  const what = (HUB.match(/<section class="panel" id="panel-what"[\s\S]*?<\/section>/) || [''])[0];
+  assert.ok(what, '#panel-what ships as real markup');
+  assert.match(what, /<input type="text" id="f-desc"/, 'it asks what the owner is building — the publish gate half');
+  // optional, and the consequence of filling it in is stated on the field itself
+  assert.match(what, /<span>In a sentence <small>\(optional — puts it on the public map\)<\/small><\/span>/,
+    'the field says it is optional and names what it is for (ADR 0182 D4), before it asks');
+  const team = (HUB.match(/<div class="setRow" data-row="team">[\s\S]*?<span class="acts">/) || [''])[0];
+  assert.match(team, /id="teamCards"/, 'and who is building it — what the recommendations read — on the Team size row');
+  // nothing in validateStep may gate the sentence: the screen asks only for the name and the kind
   const validate = SCRIPT.slice(SCRIPT.indexOf('function validateStep('));
   const map = SCRIPT.match(/var panels = \{([^}]*)\}/)[1];
-  const aboutStep = Number((map.match(/(\d+):\s*'panel-detail'/) || [, 0])[1]);
-  assert.ok(aboutStep > 0, 'the About panel is in the map');
-  assert.ok(!validate.slice(0, validate.indexOf('function ', 1)).includes(`if (step === ${aboutStep}) {`),
-    'the optional step has no validation clause — Next past an empty answer is the point');
+  const whatStep = Number((map.match(/(\d+):\s*'panel-what'/) || [, 0])[1]);
+  assert.ok(whatStep > 0, 'the What panel is in the map');
+  const fn = validate.slice(0, validate.indexOf('\n    function ', 1));
+  const clause = (fn.match(new RegExp(`if \\(step === ${whatStep}\\) \\{([\\s\\S]*?)\\n      \\}`)) || [, ''])[1];
+  assert.ok(clause, 'the What screen has a validation clause (name + kind)');
+  assert.match(clause, /state\.name\.trim\(\)/, 'the name is required');
+  assert.match(clause, /state\.projType/, 'the kind is required');
+  assert.doesNotMatch(clause, /description|teamShape/, 'the optional answers have no validation — Continue past an empty one is the point');
 });
 
 test('the About answers travel on the create request, and an empty one is OMITTED not blanked', () => {
@@ -701,11 +725,12 @@ test('the About answers travel on the create request, and an empty one is OMITTE
   assert.match(SCRIPT, /detail: createDetail\(\),/);
   assert.match(SCRIPT, /if \(state\.teamShape\) d\.team_shape = state\.teamShape;\r?\n\s*return Object\.keys\(d\)\.length \? d : undefined;/,
     'and an unanswered team shape is never guessed into the request');
-  // the review is the last screen before Create, so the skip's cost is restated there
-  const review = (SCRIPT.match(/function renderReview\(\)\s*\{([\s\S]*?)\n    \}/) || [, ''])[1];
-  assert.match(review, /off the public map until you add it/,
-    'the review row states the consequence rather than a bare dash');
-  assert.match(review, /\['About',/, 'and the About answer has a row of its own');
+  // task 1004504: the ledger review is gone; the review now confirms only the answers the
+  // wizard PREFILLED, and the sentence is never prefilled, so it has no row there — its
+  // cost is stated on its own field (pinned above)
+  assert.doesNotMatch(SCRIPT, /function renderReview\(|\$\('reviewList'\)/, 'no ledger review is left');
+  assert.match(SCRIPT, /var ROWS = \['code', 'address', 'app', 'extras', 'team', 'rewards', 'run'\];/,
+    'the review rows are the seven prefilled answers');
 });
 
 test('a renumbering of the wizard invalidates old drafts — the key carries the version', () => {
@@ -720,8 +745,9 @@ test('a renumbering of the wizard invalidates old drafts — the key carries the
   // task 1004417 put the front door's two screens (terms, fork) in front: the sixth renumbering
   // task 1004421 put the Look step between App and Review: the seventh
   // task 1004418 put planet physics right after the fork: the eighth
-  assert.equal(count, 14, 'gate + the front door\'s two + ten numbered steps + done — bump DRAFT_KEY when this changes');
-  assert.equal(key, 'cb-create-draft-v8', 'and the key moved with the physics step');
+  // task 1004504 blended the thirteen into six screens: the ninth
+  assert.equal(count, 7, 'gate + the six blended screens (fork, what, checks, review, look, done) — bump DRAFT_KEY when this changes');
+  assert.equal(key, 'cb-create-draft-v9', 'and the key moved with the six screens');
 });
 
 test('every row lays the same five parts — the ledger has no ragged row', () => {
@@ -2135,23 +2161,28 @@ test("its card is the planet section's twin: its own heading, the same channel,
 });
 
 /* ── the create wizard in the world (task 1003346; direction record §15, the pick: v1 the
-   rail above, the bongo pair kept). Two sheets carry it: cosmos.css draws the FRAME by scope
-   (#view-new), projects.html's own wizard block draws the wizard's structures. ── */
-test('the wizard takes the world by scope: no card ground, the six-step strip as the rail, the doors as pills (task 1003346)', () => {
+   rail above, the bongo pair kept; task 1004504 retired the rail and the pair for the night
+   room). Two sheets carry it: cosmos.css draws the FRAME by scope (#view-new), projects.html's
+   own wizard block draws the wizard's structures and the room behind them. ── */
+test('the wizard takes the world by scope: no card ground, no progress rail, the doors as pills (task 1003346; rail retired by task 1004504)', () => {
   const at = COSMOS.indexOf('THE CREATE WIZARD, IN THE WORLD');
   assert.ok(at > -1, 'the #view-new block exists in cosmos.css');
   const block = COSMOS.slice(at);
   assert.match(block, /#view-new \.card\{background:none;border-radius:0;box-shadow:none;/, 'no card ground');
-  // eight tracks since task 1004351 added the App step (seven since 1002339); the count is the
-  // rail's own, so it moves with the panels map rather than being a magic number
-  assert.match(block, /#view-new \.steps\{display:grid;grid-template-columns:repeat\(10,1fr\);/, 'the strip lays a track per numbered step');
-  assert.match(block, /#view-new \.steps li::before\{content:"";position:absolute;top:-4px;left:0;right:auto;width:7px;height:7px;/, 'the connector becomes the 7px dot');
-  assert.match(block, /#view-new \.steps li\.now::before\{background:var\(--accent\);border-color:var\(--accent\);outline:4px solid/, 'the lit step carries the accent and an outline halo');
-  assert.match(block, /#view-new \.panel h1\{font-weight:300;[^}]*text-transform:lowercase;/, 'the step title in the display voice, lowercase');
-  assert.match(block, /#view-new \.btn\{[^}]*text-transform:lowercase;[^}]*box-shadow:none;/, 'the doors are pills without a shadow');
+  // the strip that used to be the rail is gone with the rail (task 1004504), and so is the
+  // base .steps vocabulary it scoped over
+  assert.doesNotMatch(block, /#view-new \.steps/, 'no #view-new .steps rule is left in the wizard block');
+  assert.doesNotMatch(COSMOS, /(^|[\s,}])\.steps[\s{.:\[]/m, 'no .steps rule is left anywhere in cosmos.css');
+  // task 1004504: the design of record's light display weight, in sentence case
+  assert.match(block, /#view-new \.panel h1\{font-weight:200;[^}]*text-transform:none;/, 'the step title in the display voice, light and in sentence case');
+  assert.match(block, /#view-new \.btn\{[^}]*text-transform:none;[^}]*box-shadow:none;/, 'the doors are pills without a shadow, in sentence case');
   assert.match(block, /#view-new \.btn\.ghost\{[^}]*border:1px solid var\(--rule\);/, 'back and skip are hairline pills');
   assert.match(block, /#view-new #wizSignin\{background:var\(--ink\);color:var\(--bg\);/, 'the GitHub sign-in is the inverted pill');
-  assert.match(block, /#view-new \.bongos \.glow\{display:none;\}/, 'the bongo pair stays (the owner\'s one mark on every surface), its halo goes');
+  // the bongo pair left the wizard with the night room (task 1004504): no rule and no markup
+  assert.doesNotMatch(block, /\.bongos\b/, 'no bongo-pair rule is left in the wizard block');
+  assert.doesNotMatch(STYLE, /\.bongos\b/, 'nor in the page\'s own sheet');
+  const wizMarkup = HUB.slice(HUB.indexOf('<section id="view-new"'), HUB.indexOf('<footer class="foot"'));
+  assert.doesNotMatch(wizMarkup, /class="bongos/, 'and the wizard carries no bongo pair');
   assert.match(block, /#view-new \.panel \.lede a\{display:inline-block;padding:3px 0;min-height:24px;/, 'the done clause\'s link clears the 24px floor (the sheet\'s first problem)');
   assert.doesNotMatch(block, /box-shadow:(?!none)/, 'halos are outlines in the world, never box-shadow');
   assert.doesNotMatch(block, /#[0-9a-f]{3,8}\b/i, 'every colour is a token');
@@ -2161,13 +2192,16 @@ test('the wizard takes the world by scope: no card ground, the six-step strip as
    at the sheet's 900 while the wizard's fields, choice bands and review ledger folded at the
    page's 840 (cosmos's createSplit collapse), so between the two the rail was already three-up
    beside full-width bands. Both sheets now name the same width. ── */
-test('the wizard folds at one width: the rail\'s media rule sits at 840px with the bands, and no 900px rule is left in the #view-new block (task 1003538)', () => {
+test('the wizard folds at one width: no rail fold is left, and no 900px rule is left in the #view-new block (task 1003538; rail retired by task 1004504)', () => {
   const at = COSMOS.indexOf('THE CREATE WIZARD, IN THE WORLD');
   assert.ok(at > -1, 'the #view-new block exists in cosmos.css');
   const block = COSMOS.slice(at);
-  assert.match(block, /@media \(max-width:840px\)\{\s*#view-new \.steps\{grid-template-columns:repeat\(3,1fr\);/, 'the rail folds to three columns at 840, the width the bands fold at');
+  assert.doesNotMatch(block, /#view-new \.steps/, 'the rail and its 840 fold are gone (task 1004504)');
   assert.doesNotMatch(block, /@media \(max-width:900px\)/, 'no 900px rule is left in the wizard block');
-  assert.match(STYLE, /@media \(max-width:840px\)\{[\s\S]*?\.review\{grid-template-columns:1fr;/, 'the page\'s own wizard block still folds its bands and ledger at that same 840');
+  assert.match(STYLE, /@media \(max-width:840px\)\{\s*\.row2,\.choices\{grid-template-columns:1fr;\}[\s\S]*?\.typeCards\{grid-template-columns:1fr;\}/, 'the page\'s own wizard block still folds its bands at that same 840');
+  // the ledger review is gone (task 1004504); its rows stack at their own, narrower width
+  assert.doesNotMatch(STYLE, /\.review\{/, 'no .review ledger rule is left');
+  assert.match(STYLE, /@media \(max-width:560px\)\{\s*\.setRow\{grid-template-columns:minmax\(0,1fr\);/, 'the review\'s rows stack under 560');
 });
 
 test('the wizard\'s own structures wear the world: hairline fields, cells of one band, the review as a ledger, the human steps as a numbered ledger, the standup strip as the rail (task 1003346)', () => {
@@ -2180,8 +2214,10 @@ test('the wizard\'s own structures wear the world: hairline fields, cells of one
   assert.match(block, /\.tpill\[aria-pressed=true\]::before\{background:var\(--accent\);/, 'the chosen cell carries the dot');
   assert.match(block, /\.choices\{display:grid;grid-template-columns:1fr 1fr;gap:0;border-top:1px solid var\(--rule\);/, 'start fresh / adopt are two cells of one band');
   assert.match(block, /\.choice svg\{display:none;\}/, 'the dot is the mark, the icon leaves');
-  assert.match(block, /\.review\{list-style:none;display:grid;grid-template-columns:172px 1fr;/, 'the review is a ledger');
-  assert.match(block, /\.review li\{display:contents;\}/, 'renderReview\'s li markup stands; the grid lays its k and v');
+  // task 1004504: the review is one hairline column of rows to confirm, not a ledger of li
+  assert.match(block, /\.setRows\{margin:24px 0 0;border-top:1px solid var\(--rule\);\}/, 'the review\'s rows hang from one hairline');
+  assert.match(block, /\.setRow\{display:grid;grid-template-columns:120px minmax\(0,1fr\) auto;[^}]*border-bottom:1px solid var\(--rule\);\}/, 'each row is label · value · actions on its own hairline');
+  assert.doesNotMatch(block, /\.review( li)?\{/, 'the ledger\'s rules are gone with renderReview');
   assert.match(block, /\.humanSteps>li\{\s*display:grid;grid-template-columns:44px 1fr;/, 'the human steps are a numbered ledger');
   assert.match(block, /\.humanSteps>li>\*\{grid-column:2;/, 'every child of a step sits in the text column, never under the counter (the sheet\'s bug)');
   assert.match(block, /\.humanSteps>li\.sdone::before\{content:"done";/, 'a finished step reads DONE in the ok ink');
@@ -2190,8 +2226,15 @@ test('the wizard\'s own structures wear the world: hairline fields, cells of one
   assert.match(block, /\.doneHead \.tick\{display:none;\}/, 'the tick leaves; the rail says filed');
   assert.match(block, /\.addrBig code\{display:block;font-family:var\(--font-display\);/, 'the address stands in the display voice');
   assert.doesNotMatch(block, /linear-gradient/, 'no tinted plates');
-  assert.doesNotMatch(block, /box-shadow:(?!none)/, 'no box shadow in the wizard block');
-  assert.match(HUB, /<div class="nav">\s*<button type="button" class="btn ghost" data-back="11">← Back<\/button>\s*<button type="button" class="btn big" id="doCreate">Create my project<\/button>/, 'the review\'s doors sit on one row, back then the primary');
+  // the one exception is drawn, not chrome: the night room's moon glows in the window
+  // (task 1004504), and a control's halo is still an outline
+  const shadows = [...block.matchAll(/([^{}]*)\{[^}]*box-shadow:(?!none)/g)].map((m) => m[1].trim());
+  assert.deepEqual(shadows, ['#view-new .rmMoon'], 'no box shadow in the wizard block but the room\'s moon');
+  // no per-panel Back any more (task 1004504): one Back in the wizard's top row, and Create
+  // stands alone on the look screen
+  assert.doesNotMatch(HUB, /data-back="/, 'no per-panel back door is left');
+  assert.match(HUB, /<div class="wizTop">\s*<span class="wizEyebrow" id="wizEyebrow">New project<\/span>\s*<button type="button" class="wizBack" id="wizBack" hidden>← Back<\/button>\s*<\/div>/, 'one Back, beside the eyebrow');
+  assert.match(HUB, /<div class="nav">\s*<span><\/span>\s*<button type="button" class="btn big" id="doCreate">Create my project<\/button>/, 'the look screen\'s one door is Create');
   assert.match(HUB, /<h2 class="stepsHead" id="doneStepsHead">Your steps — the parts only you can play<\/h2>/, 'the steps heading is the label face by class, not an inline style (the id is where a skipped invite step hands focus on, task 1002346)');
   // what is enqueued is unchanged (ADR 0111): the filing body the control plane reads
   assert.match(SCRIPT, /body: JSON\.stringify\(\{\s*slug: state\.slug,/, 'the filing still carries the slug first');
@@ -2200,32 +2243,94 @@ test('the wizard\'s own structures wear the world: hairline fields, cells of one
   assert.match(SCRIPT, /onboard_mode: state\.mode === 'adopt' \? 'adopt' : 'greenfield'/, 'the onboard mode is unchanged');
   // the kit walks every step and files against the stub
   const states = JSON.parse(fs.readFileSync(path.join(LANDING, 'projects.states.json'), 'utf8')).states;
-  for (const s of ['type', 'about', 'modules', 'home', 'address', 'review', 'done']) assert.ok(states['in-new-' + s], `the ${s} step has a kit state`);
+  for (const s of ['fork-ticked', 'what', 'checks', 'review', 'review-extras', 'look', 'done']) assert.ok(states['in-new-' + s], `the ${s} screen has a kit state`);
   const probes = JSON.parse(fs.readFileSync(path.join(LANDING, 'projects.probes.json'), 'utf8')).probes;
-  assert.ok(probes.some((p) => /the wizard driver \(task 1003346\)/.test(p.name) && p.steps.some((st) => st[1] === '#doCreate')), 'the wizard driver files a project end to end');
-});
-
-test('the Modules step ships as real markup and is skippable like About (task 1002339)', () => {
-  const panel = (HUB.match(/<section class="panel" id="panel-modules"[\s\S]*?<\/section>/) || [''])[0];
-  assert.ok(panel, '#panel-modules ships as real markup, not built by script');
-  assert.match(panel, /id="modCards"/, 'the band the picker paints its rows into');
-  assert.match(panel, /class="typeCards"/, 'and it is the SAME band the type and team questions use — no new grammar');
-  assert.match(panel, /id="modCoreNote"/, 'the always-on core is stated on the panel');
-  // the skip must be its own control, not "leave it and press Next" — the rule
-  // task 1002334 wrote for the one other optional step
-  assert.match(panel, /id="skipModules"/, 'the skip is a control, not an inference');
-  assert.match(panel, /Optional/, 'and the panel says so before it asks');
-  // nothing in validateStep may gate it
-  const validate = SCRIPT.slice(SCRIPT.indexOf('function validateStep('));
-  const map = SCRIPT.match(/var panels = \{([^}]*)\}/)[1];
-  const modStep = Number((map.match(/(\d+):\s*'panel-modules'/) || [, 0])[1]);
-  assert.ok(modStep > 0, 'the Modules panel is in the map');
-  assert.ok(!validate.slice(0, validate.indexOf('function ', 1)).includes(`if (step === ${modStep}) {`),
-    'the optional step has no validation clause — Next past an untouched picker is the point');
+  assert.ok(probes.some((p) => /the wizard driver \(tasks? 1003346\b/.test(p.name) && p.steps.some((st) => st[1] === '#doCreate')), 'the wizard driver files a project end to end');
+  // a walk that clicks a panel the page no longer has stops dead at that click: every panel a
+  // state or probe names must be one of the screens (task 1004504 retired seven of them)
+  const live = new Set([...HUB.matchAll(/<section class="panel(?: on)?" id="(panel-[a-z]+)"/g)].map((m) => m[1]));
+  const walks = [...Object.entries(states).map(([n, s]) => [n, s.actions || s.steps || []]), ...probes.map((p) => [p.name, p.steps || []])];
+  for (const [name, steps] of walks) {
+    for (const st of steps) {
+      for (const m of String(st[1] || '').matchAll(/#(panel-[a-z]+)/g)) {
+        assert.ok(live.has(m[1]), `"${name}" walks #${m[1]}, which the page no longer has`);
+      }
+    }
+  }
+});
+
+/* ── the night room (task 1004504; the design of record docs/design/mocks/combined-onboarding/).
+   The studio's lofi room behind the whole wizard, in place of the plate, the planet and the
+   bongo pair. Decoration only, re-lit by the pack, and still under the kill switch. ── */
+test('the night room is decoration, lit only by the fifteen, and moves only when motion is welcome (task 1004504)', () => {
+  // real markup, hidden from assistive tech, carrying the screen show() writes
+  const tag = (HUB.match(/<div class="wizRoom" id="wizRoom"[^>]*>/) || [''])[0];
+  assert.ok(tag, '#wizRoom ships as real markup inside the new view');
+  assert.ok(HUB.indexOf('id="wizRoom"') > HUB.indexOf('<section id="view-new"'), 'and it lives inside #view-new');
+  assert.match(tag, /aria-hidden="true"/, 'the room is decoration: aria-hidden');
+  assert.match(tag, /data-screen="[a-z]+"/, 'it carries a data-screen for show() to move');
+  // every colour of its own is a mix of the pack's tokens, never a literal: a re-branded
+  // pack re-lights the room (C1/C2), and the tokens are scoped to the room, never :root
+  const rule = (STYLE.match(/#view-new \.wizRoom\{([^}]*)\}/) || [, ''])[1];
+  assert.ok(rule, 'the room\'s own rule exists in the page sheet');
+  const tokens = [...rule.matchAll(/(--rm-[a-z0-9-]+):([^;]+);/g)];
+  assert.ok(tokens.length >= 10, `the room declares its colours as --rm-* tokens, found ${tokens.length}`);
+  for (const [, name, value] of tokens) {
+    assert.ok(/^color-mix\(/.test(value.trim()) || /^rgba\(255,255,255,/.test(value.trim()),
+      `${name} must be a color-mix( of the fifteen or a white wash, not ${value.trim()}`);
+    assert.doesNotMatch(value.trim(), /^#/, `${name} has no hex literal of its own`);
+  }
+  // the room's other rules read those tokens (or a pack token), never a literal colour
+  const roomRules = [...STYLE.matchAll(/(#view-new \.(?:rm[A-Za-z0-9]+|wizRoom\[[^\]]*\])[^{]*)\{([^}]*)\}/g)];
+  assert.ok(roomRules.length > 10, 'the room\'s parts are styled in the page sheet');
+  for (const [, sel, body] of roomRules) {
+    assert.doesNotMatch(body.replace(/url\("data:[^"]*"\)/g, ''), /(?:background|color|border[a-z-]*|box-shadow|filter):[^;]*#[0-9a-f]{3,8}\b/i, `${sel.trim()} paints no literal colour`);
+  }
+  // the kill switch: the twinkle, the breathe, the float and the seed's growth all sit
+  // inside the no-preference block, and nothing in the room moves outside it
+  const mqAt = STYLE.indexOf('@media (prefers-reduced-motion:no-preference){');
+  assert.ok(mqAt > -1, 'the room\'s motion has a no-preference block');
+  let depth = 0, mqEnd = -1;
+  for (let i = STYLE.indexOf('{', mqAt); i < STYLE.length; i++) {
+    if (STYLE[i] === '{') depth++;
+    else if (STYLE[i] === '}' && --depth === 0) { mqEnd = i; break; }
+  }
+  const motion = STYLE.slice(mqAt, mqEnd);
+  for (const want of [/\.rmStar\{animation:rmTwinkle /, /\.rmGlow\{animation:rmBreathe /, /\.rmSeed img\{animation:rmFloat /, /@keyframes rmTwinkle\{/, /@keyframes rmBreathe\{/, /@keyframes rmFloat\{/]) {
+    assert.match(motion, want, `${want} lives inside the no-preference block`);
+  }
+  const outside = STYLE.slice(0, mqAt) + STYLE.slice(mqEnd);
+  assert.doesNotMatch(outside, /@keyframes rm|animation:rm/, 'no room animation outside the kill switch');
+  for (const [, sel, body] of [...outside.matchAll(/(#view-new \.(?:rm[A-Za-z0-9]+|wizRoom)[^{]*)\{([^}]*)\}/g)]) {
+    assert.doesNotMatch(body, /\b(?:animation|transition)\s*:/, `${sel.trim()} moves only inside the no-preference block`);
+  }
+});
+
+// the Modules step became the review's Extras row (task 1004504): the picker is the row's
+// own controls, moved in whole, so these pin the row as they pinned the panel
+const EXTRAS_ROW = (HUB.match(/<div class="setRow" data-row="extras">[\s\S]*?<span class="acts">/) || [''])[0];
+
+test('the extras picker ships as real markup on the review\'s Extras row and is a default you confirm, never a gate (tasks 1002339, 1004504)', () => {
+  assert.doesNotMatch(HUB, /id="panel-modules"|id="skipModules"/, 'no Modules panel and no skip button are left');
+  assert.ok(EXTRAS_ROW, 'the Extras row ships as real markup, not built by script');
+  assert.match(EXTRAS_ROW, /id="modCards"/, 'the band the picker paints its rows into');
+  assert.match(EXTRAS_ROW, /class="typeCards"/, 'and it is the SAME band the type and team questions use — no new grammar');
+  assert.match(EXTRAS_ROW, /id="modCoreNote"/, 'the always-on core is stated on the row');
+  // the suggested set is accepted by its own control — "Looks right" — never inferred
+  assert.match(HUB, /<div class="setRow" data-row="extras">[\s\S]*?<button type="button" class="rowOk" data-row-ok>Looks right<\/button><button type="button" class="rowChg" data-row-chg aria-expanded="false">Change<\/button>/,
+    'accepting the suggested set is a control, not an inference');
+  // confirming turns the shown set into an answer given; the row's validity never refuses it
+  const confirm = (SCRIPT.match(/function confirmRow\(key\) \{([\s\S]*?)\n    \}/) || [, ''])[1];
+  assert.match(confirm, /if \(key === 'extras' && starterBundles\) state\.modules = pickedModules\(\);/,'confirming the row is the answer — once the catalog has landed, never an empty list in its place');
+  const valid = (SCRIPT.match(/function rowValid\(key\) \{([\s\S]*?)\n    \}/) || [, ''])[1];
+  assert.ok(valid, 'rowValid() must exist');
+  assert.doesNotMatch(valid, /'extras'/, 'the extras row has no check that can refuse it — any set, even none, is an answer');
+  // and the kind is what the suggestion follows, so changing it asks again
+  assert.match(SCRIPT, /\/\* the suggested extras follow the kind, so the review asks about them again \*\/\s*unconfirm\(\['extras'\]\);/);
 });
 
 test('the picker\'s search ships as real markup, in the wizard\'s own field grammar (task 1002340)', () => {
-  const panel = (HUB.match(/<section class="panel" id="panel-modules"[\s\S]*?<\/section>/) || [''])[0];
+  const panel = EXTRAS_ROW;
   assert.match(panel, /<input type="text" id="modQ"[^>]*>/, 'the search is a real field, not one built by script');
   assert.match(panel, /id="modQ"[^>]*aria-label="Search the extras by name"/, 'and it is named for a screen reader');
   assert.match(panel, /id="modFilterNote"[^>]*aria-live="polite"/, 'the count under it is announced when it changes');
@@ -2272,9 +2377,11 @@ test('the picker\'s answer rides the create request, and an untouched picker sen
 test('the review names what the project will actually come with (task 1002339)', () => {
   // The picker is optional, so the last screen before Create must show the set
   // the owner is about to get — their picks, or the preselect they walked past.
-  const render = SCRIPT.slice(SCRIPT.indexOf('function renderReview()'));
-  const rows = render.slice(0, render.indexOf('$(\'reviewList\').innerHTML'));
-  assert.match(rows, /\['Extras', extrasRow\(\)\]/, 'the ledger carries an Extras row');
+  // task 1004504: the review is the row-by-row confirm, and its Extras row reads the picker
+  const text = SCRIPT.slice(SCRIPT.indexOf('function rowText(key)'));
+  const extras = text.slice(text.indexOf("if (key === 'extras')"), text.indexOf("if (key === 'team')"));
+  assert.ok(text.length && extras, 'rowText() and its extras arm must exist');
+  assert.match(extras, /return \{ v: lead, s: starterBundles \? extrasRow\(\) : '' \};/, 'the review carries an Extras row, its line the picker\'s own');
   // What that row SAYS has three cases (picked / preselect / catalog not loaded)
   // and they live with the picker's own rules, executed by
   // tests/projects_hub_module_picker.mjs. This pins that the review defers to them.
@@ -2289,7 +2396,7 @@ test('the kit stub answers the picker\'s read, so the panel renders in the desig
   const stub = fs.readFileSync(path.join(ROOT, 'modules', 'ui-design', 'kit', 'serve.js'), 'utf8');
   assert.match(stub, /rest === '\/provisioning\/starter-bundles'/, 'the stub serves the picker\'s read');
   const probes = JSON.parse(fs.readFileSync(path.join(LANDING, 'projects.probes.json'), 'utf8')).probes;
-  assert.ok(probes.some((p) => /the wizard driver \(task 1003346\)/.test(p.name)
-    && p.steps.some((st) => st[1] === '#panel-modules button[type=submit]')),
-  'and the end-to-end driver walks the new step rather than stopping at it');
+  assert.ok(probes.some((p) => /the wizard driver \(tasks? 1003346\b/.test(p.name)
+    && p.steps.some((st) => st[1] === '#reviewRows .setRow[data-row="extras"] [data-row-ok]')),
+  'and the end-to-end driver confirms the Extras row rather than stopping at it (task 1004504)');
 });

package/tests/projects_hub_app_status.mjs

@@ -257,7 +257,9 @@ test('a repaint never lands on top of an open Retry — from this watch or a fre
 });
 
 test('both surfaces use it: the done panel and the project page', () => {
-  assert.match(HUB, /if \(box\) watchApp\(instanceId, box, function \(\) \{ return state\.step === 13; \}, 5000\);/);
+  // the done panel is screen 6 of the six blended screens (task 1004504)
+  assert.match(HUB, /6: 'panel-done' \};/);
+  assert.match(HUB, /if \(box\) watchApp\(instanceId, box, function \(\) \{ return state\.step === 6; \}, 5000\);/);
   assert.match(HUB, /<div id="doneApp" hidden><\/div>/);
   assert.match(HUB, /<div class="card mSec" id="mAppCard" hidden>\n\s*<h2>Where its app runs<\/h2>\n\s*<div id="mApp"><\/div>/);
   assert.match(HUB, /loadAppStatus\(inst\.id \|\| asked, inst\);/);