@bongos/core 1.21.38 → 1.21.40

package/modules/hall-ui/public/street-card.states.json

@@ -1,5 +1,5 @@
 {
-  "_": "THE MATTER CARD THAT ACTS (task 1004528, goal 1000125) on the street page, through modules/ui-design/kit/render.js. Kept beside street.states.json rather than inside it, so the street and its interiors (task 1004526) and the card each own their states. The populated card needs the hall-preview harness, whose government__docket.json puts the review-seat amendment on the board source (board:47) and whose government__board__items.json carries its ballot (item 47), with a canned answer for a vote:\n\n  node scripts/hall-preview/server.js --port 4625 --fixture-me\n  node modules/ui-design/kit/render.js --states modules/hall-ui/public/street-card.states.json --base-in http://localhost:4625 --base-out http://localhost:4625\n\nAgainst the kit stub there is no docket and no pin, so these states are for the harness.",
+  "_": "THE MATTER CARD THAT ACTS (task 1004528, goal 1000125) on the street page, through modules/ui-design/kit/render.js. Kept beside street.states.json rather than inside it, so the street and its interiors (task 1004526) and the card each own their states. The populated card needs the hall-preview harness, whose government__docket.json puts the review-seat amendment on the board source (board:47) and whose government__board__items.json carries its ballot (item 47), with a canned answer for a vote:\n\n  node scripts/hall-preview/server.js --port 4625 --fixture-me\n  node modules/ui-design/kit/render.js --states modules/hall-ui/public/street-card.states.json --base-in http://localhost:4625 --base-out http://localhost:4625\n\nTask 1004566 adds a card per kind the docket carries (blocker, red-team report, core update, module re-check, a Full Idea and the review queue), each compact and with \"more\" open; the harness fixture carries them. Against the kit stub there is no docket and no pin, so these states are for the harness.",
   "page": "/builders/street",
   "surface": "hall-ui",
   "stub": {
@@ -31,6 +31,14 @@
           "wait",
           900
         ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
         [
           "click",
           ".street-pin[data-matter=\"board:47\"]"
@@ -52,19 +60,27 @@
     },
     "object": {
       "auth": true,
-      "_": "object pressed: the reason (on the record) and the part it objects to.",
+      "_": "no pressed: the desk row's one-tap reasons stand open under it (task 1004566).",
       "actions": [
         [
           "wait",
           900
         ],
         [
-          "click",
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
           ".street-pin[data-matter=\"board:47\"]"
         ],
         [
           "wait",
-          700
+          600
         ],
         [
           "click",
@@ -77,9 +93,8 @@
       ],
       "expect": {
         "visible": [
-          "#mcardReason",
-          "#mcardSection",
-          "[data-act=\"object-send\"]"
+          ".mcard-chips",
+          "[data-act=\"chip-scope\"]"
         ]
       }
     },
@@ -91,6 +106,14 @@
           "wait",
           900
         ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
         [
           "click",
           ".street-pin[data-matter=\"board:47\"]"
@@ -123,6 +146,14 @@
           "wait",
           900
         ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
         [
           "click",
           ".street-pin[data-matter=\"access_requests:7\"]"
@@ -147,6 +178,14 @@
           "wait",
           900
         ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
         [
           "click",
           ".street-pin[data-matter=\"override_requests:9\"]"
@@ -161,6 +200,455 @@
           "#streetCard"
         ]
       }
+    },
+    "blocker": {
+      "auth": true,
+      "_": "a blocker: decide by one of its options, which stand open (task 1004566), compact.",
+      "actions": [
+        [
+          "wait",
+          900
+        ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
+          ".street-pin[data-matter=\"blockers:11\"]"
+        ],
+        [
+          "wait",
+          600
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#streetCard",
+          "[data-act=\"decide\"]",
+          ".mcard-chips"
+        ],
+        "hidden": [
+          "#mcardMore"
+        ]
+      }
+    },
+    "blocker-more": {
+      "auth": true,
+      "_": "a blocker: decide by one of its options, which stand open (task 1004566), with more open in place: the full text, who and when, the record.",
+      "actions": [
+        [
+          "wait",
+          900
+        ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
+          ".street-pin[data-matter=\"blockers:11\"]"
+        ],
+        [
+          "wait",
+          600
+        ],
+        [
+          "click",
+          "[data-act=\"more\"]"
+        ],
+        [
+          "wait",
+          300
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#mcardMore"
+        ]
+      }
+    },
+    "report": {
+      "auth": true,
+      "_": "a red-team report: confirm or dispute (task 1004566), compact.",
+      "actions": [
+        [
+          "wait",
+          900
+        ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
+          ".street-pin[data-matter=\"redteam_reports:4\"]"
+        ],
+        [
+          "wait",
+          600
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#streetCard",
+          "[data-act=\"confirm\"]",
+          "[data-act=\"dispute\"]"
+        ],
+        "hidden": [
+          "#mcardMore"
+        ]
+      }
+    },
+    "report-more": {
+      "auth": true,
+      "_": "a red-team report: confirm or dispute (task 1004566), with more open in place: the full text, who and when, the record.",
+      "actions": [
+        [
+          "wait",
+          900
+        ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
+          ".street-pin[data-matter=\"redteam_reports:4\"]"
+        ],
+        [
+          "wait",
+          600
+        ],
+        [
+          "click",
+          "[data-act=\"more\"]"
+        ],
+        [
+          "wait",
+          300
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#mcardMore"
+        ]
+      }
+    },
+    "core": {
+      "auth": true,
+      "_": "the core update: the Release desk's core row, check then take (task 1004566), compact.",
+      "actions": [
+        [
+          "wait",
+          900
+        ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
+          ".street-pin[data-matter=\"core_update:1.21.20\"]"
+        ],
+        [
+          "wait",
+          600
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#streetCard",
+          "[data-act=\"take\"]",
+          "[data-act=\"check\"]"
+        ],
+        "hidden": [
+          "#mcardMore"
+        ]
+      }
+    },
+    "core-more": {
+      "auth": true,
+      "_": "the core update: the Release desk's core row, check then take (task 1004566), with more open in place: the full text, who and when, the record.",
+      "actions": [
+        [
+          "wait",
+          900
+        ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
+          ".street-pin[data-matter=\"core_update:1.21.20\"]"
+        ],
+        [
+          "wait",
+          600
+        ],
+        [
+          "click",
+          "[data-act=\"more\"]"
+        ],
+        [
+          "wait",
+          300
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#mcardMore"
+        ]
+      }
+    },
+    "recheck": {
+      "auth": true,
+      "_": "a module version that failed its security check: check it again, with a one-tap reason (task 1004566), compact.",
+      "actions": [
+        [
+          "wait",
+          900
+        ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
+          ".street-pin[data-matter=\"module_rechecks:7\"]"
+        ],
+        [
+          "wait",
+          600
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#streetCard",
+          "[data-act=\"recheck\"]"
+        ],
+        "hidden": [
+          "#mcardMore"
+        ]
+      }
+    },
+    "recheck-more": {
+      "auth": true,
+      "_": "a module version that failed its security check: check it again, with a one-tap reason (task 1004566), with more open in place: the full text, who and when, the record.",
+      "actions": [
+        [
+          "wait",
+          900
+        ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
+          ".street-pin[data-matter=\"module_rechecks:7\"]"
+        ],
+        [
+          "wait",
+          600
+        ],
+        [
+          "click",
+          "[data-act=\"more\"]"
+        ],
+        [
+          "wait",
+          300
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#mcardMore"
+        ]
+      }
+    },
+    "idea": {
+      "auth": true,
+      "_": "a Full Idea: vote yes or no here; its sections are under more (task 1004566), compact.",
+      "actions": [
+        [
+          "wait",
+          900
+        ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
+          ".street-pin[data-matter=\"board:41\"]"
+        ],
+        [
+          "wait",
+          600
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#streetCard",
+          "[data-act=\"for\"]",
+          "[data-act=\"object\"]"
+        ],
+        "hidden": [
+          "#mcardMore"
+        ]
+      }
+    },
+    "idea-more": {
+      "auth": true,
+      "_": "a Full Idea: vote yes or no here; its sections are under more (task 1004566), with more open in place: the full text, who and when, the record.",
+      "actions": [
+        [
+          "wait",
+          900
+        ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
+          ".street-pin[data-matter=\"board:41\"]"
+        ],
+        [
+          "wait",
+          600
+        ],
+        [
+          "click",
+          "[data-act=\"more\"]"
+        ],
+        [
+          "wait",
+          300
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#mcardMore"
+        ]
+      }
+    },
+    "queue": {
+      "auth": true,
+      "_": "the review queue: its first piece of work, signed off here (task 1004566), compact.",
+      "actions": [
+        [
+          "wait",
+          900
+        ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
+          ".street-pin[data-matter=\"queue\"]"
+        ],
+        [
+          "wait",
+          600
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#streetCard",
+          "[data-act=\"signoff\"]",
+          "[data-act=\"force\"]"
+        ],
+        "hidden": [
+          "#mcardMore"
+        ]
+      }
+    },
+    "queue-more": {
+      "auth": true,
+      "_": "the review queue: its first piece of work, signed off here (task 1004566), with more open in place: the full text, who and when, the record.",
+      "actions": [
+        [
+          "wait",
+          900
+        ],
+        [
+          "clickIfVisible",
+          "[data-craft-close]"
+        ],
+        [
+          "wait",
+          300
+        ],
+        [
+          "dispatchClick",
+          ".street-pin[data-matter=\"queue\"]"
+        ],
+        [
+          "wait",
+          600
+        ],
+        [
+          "click",
+          "[data-act=\"more\"]"
+        ],
+        [
+          "wait",
+          300
+        ]
+      ],
+      "expect": {
+        "visible": [
+          "#mcardMore"
+        ]
+      }
     }
   },
   "reducedMotion": {

package/modules/hall-ui/public/street-desk.js

@@ -121,9 +121,11 @@
     budget: 'set limit', unsign: 'undo',
     // task 1004564: the proposer takes back their own sitting before any vote
     withdraw: 'withdraw',
+    // task 1004566: a module version flagged by its security check, checked again
+    recheck: 'check again',
   });
   // What a row's chips ask, per act (a reason or an option is one tap, never text).
-  const ASKS = Object.freeze({ budget: 'monthly limit', unsign: 'why', decide: 'pick one', ratify_goal: 'which version', check: 'check', take_core: 'move to', rot: 'stale after', module_off: 'sure', invite: 'their GitHub name', object: 'why', force: 'why', switch_off: 'why', pause: 'why', deactivate: 'why', signoff: 'confirm', allow: 'which goal', tier: 'which tier', give: 'to whom', take: 'from whom' });
+  const ASKS = Object.freeze({ recheck: 'why', budget: 'monthly limit', unsign: 'why', decide: 'pick one', ratify_goal: 'which version', check: 'check', take_core: 'move to', rot: 'stale after', module_off: 'sure', invite: 'their GitHub name', object: 'why', force: 'why', switch_off: 'why', pause: 'why', deactivate: 'why', signoff: 'confirm', allow: 'which goal', tier: 'which tier', give: 'to whom', take: 'from whom' });
   // How a floor counts rows nobody is waiting on (desk rows), by its desk.
   const DESK_NOUNS = Object.freeze({
     'people.builders': 'builders', 'people.ranks': 'ranks', 'disputes.confirmed': 'to fix',
@@ -314,6 +316,49 @@
       .sort((a, b) => (b.needs - a.needs) || ((Date.parse(a.opened || 0) || 0) - (Date.parse(b.opened || 0) || 0)));
   }
 
+  // ---------- the street's card (task 1004566) ----------
+  // The card a pin opens, with the SAME acts as the desk row for the same item:
+  // the matter's row (rowOf), or the desk row that stands in for its source
+  // (`over`: the Release desk's core row, check then take). `row` goes on the
+  // card model, and the card draws its buttons and chips (street-card.js
+  // render) and sends each act with the row's own card. ONE action model: a
+  // card never offers what the desk does not, nor the other way round.
+  // The review queue's pin opens its first piece of work (needs-you first, then
+  // oldest); ctx.pick opens another of the queue in the same card.
+  // ctx { room, constitution, now, viewerId, goals (open), pick }
+  function standIn(docket, m) {
+    if (!docket || !Array.isArray(docket.desks)) return null;
+    for (const d of docket.desks) {
+      if (!d || d.status !== 'live' || !Array.isArray(d.rows)) continue;
+      const hit = d.rows.find((r) => r && r.over === m.source && r.building === m.building);
+      if (hit) return hit;
+    }
+    return null;
+  }
+  function cardFor(key, docket, ctx) {
+    const c = Object.assign({ docket: docket }, ctx || {});
+    let k = str(key);
+    let queue = null;
+    const all = docket && Array.isArray(docket.matters) ? docket.matters : [];
+    if (k === 'queue') {
+      const q = all.filter((m) => m && m.building === 'review' && stateOf(m) !== 'settled')
+        .sort((a, b) => ((stateOf(b) === 'needs') - (stateOf(a) === 'needs')) || ((Date.parse(a.opened_at || 0) || 0) - (Date.parse(b.opened_at || 0) || 0)));
+      if (!q.length) return null;
+      const pick = q.find((m) => str(m.id) === str(c.pick)) || q[0];
+      queue = { n: q.length, others: q.filter((m) => m !== pick).slice(0, LIMITS.chips).map((m) => ({ key: str(m.id), title: fit(m.title || m.short, LIMITS.fact) })) };
+      k = str(pick.id);
+    }
+    const cv = C && C.model ? C.model({ docket: docket, key: k, room: c.room, constitution: c.constitution, now: c.now || 0, viewerId: c.viewerId }) : null;
+    if (!cv) return null;
+    cv.queue = queue;
+    const m = all.find((x) => x && str(x.id) === k);
+    if (!m || cv.loading) return cv;
+    const over = standIn(docket, m);
+    const row = over ? deskRowOf(over, c) : rowOf(m, c);
+    if (row.actions.length) { cv.row = row; cv.readOnly = false; }
+    return cv;
+  }
+
   // ---------- the whole desk ----------
   // input { key, floor (index), docket, goals (open), now, room, constitution,
   //         viewerId, done {matterId: true}, mine [what you did here, newest
@@ -474,7 +519,7 @@
 
   const api = {
     LIMITS: LIMITS, ACT_WORDS: ACT_WORDS, ASKS: ASKS, DESK_NOUNS: DESK_NOUNS, CHIPS: CHIPS, NOUNS: NOUNS, CLEAR: CLEAR,
-    fit: fit, ageWord: ageWord, floorMatters: floorMatters, firstNeeds: firstNeeds, rowsFor: rowsFor, deskModel: deskModel, breaks: breaks, todayPips: todayPips, moved: moved,
+    fit: fit, ageWord: ageWord, floorMatters: floorMatters, firstNeeds: firstNeeds, rowsFor: rowsFor, cardFor: cardFor, deskModel: deskModel, breaks: breaks, todayPips: todayPips, moved: moved,
   };
   root.GovDesk = api;
   if (typeof module !== 'undefined' && module.exports) module.exports = api;

package/modules/hall-ui/public/street-inside.js

@@ -34,8 +34,6 @@
 //    the seat is drawn empty and says so, and the rule is the building's own
 //    matters' rule, else the design's default, named as the default
 //    (holderOf()).
-//  * On the table here: the docket's matters at this building. Each row opens
-//    the short card (GovStreet.cardFor(); task 1004528 makes it act).
 //  * The record: the building's history (docket.history: rulings, amendments,
 //    sign-offs, releases, payouts) and its matters, filed by month, one drawer
 //    a month, newest first.
@@ -176,7 +174,7 @@
   //   key  one of the nine civic keys
   //   b    the building, in civicInfo()'s shape: { group, name, holds, seats,
   //        who, rule, how, cap, growth, floors: [{ name, line, count, status,
-  //        lines }], record: [{ label, items }], onFile, table: [rows], annex }
+  //        lines }], record: [{ label, items }], onFile, annex }
   //   st   { floor, drawer, picks, vacant, reviewHeld, evening }
   // Everything the prototype's template binds, as data, plus `selFloor` and
   // `selDrawer`. The geometry is the prototype's to the pixel.
@@ -261,7 +259,6 @@
         : { key: s, init: s, bg: T.seatFor.bg, fg: T.seatFor.fg, border: 'none' };
     const g = City.glyph(b.rule, 9, 9, 16);
     const pct = Math.round(occ / cap * 100);
-    const table = Array.isArray(b.table) ? b.table : [];
     const f = b.floors[selFloor];
     const quietWord = f && QUIET[f.status] !== undefined ? ' · ' + (f.status === 'proposed' ? 'proposed' : QUIET[f.status]) : '';
     return {
@@ -269,7 +266,6 @@
       seats: b.seats.map(seatOf), whoText: b.who, gf: g.fill, gl: g.line, howText: b.how,
       fill: pct, fillColor: pct >= 80 ? '#fb9569' : T.line,
       growth: (vacant ? 'Not built yet. ' : occ + ' of ' + cap + ' floors in use. ') + b.growth,
-      hasTable: table.length > 0, table: table,
       openKicker: 'floor ' + (selFloor + 1) + (f && f.status === 'pending' ? ' · being decided' : quietWord),
       sym: f ? Object.assign(symbolPath(floorSymbol(f.name)), { c: '#fb9569' }) : { d: '', f: '', c: 'none' },
       flipA: ((st.picks || 0) % 2) === 0, flipB: ((st.picks || 0) % 2) === 1,
@@ -528,11 +524,6 @@
       if (!vacant && spec[2] && spec[2].held) fl.name = spec[2].held;
       return fl;
     });
-    const order = { needs: 0, moving: 1, settled: 2 };
-    const table = matters.slice().sort((a, b) => order[stateOf(a)] - order[stateOf(b)]).map((m) => {
-      const s = stateOf(m), when = S.whenWord(m.deadline, c.now);
-      return { key: String(m.id), matter: String(m.id), label: String(m.title || m.short || ''), status: s === 'needs' ? 'needs you' + (when ? ' · ' + when : '') : s === 'moving' ? 'moving' + (when ? ' · ' + when : '') : (when || 'settled'), state: s, color: s === 'needs' ? 'accent' : 'ink' };
-    });
     const history = docket && Array.isArray(docket.history) ? docket.history.filter((x) => x && x.building === key) : [];
     const record = recordOf(matters, c.now, history);
     return {
@@ -541,7 +532,7 @@
       growth: vacant ? plan.vacantGrowth : plan.growth,
       floors: floors, record: record,
       onFile: !docket ? 'the docket could not be read just now' : matters.length ? matters.length + (matters.length === 1 ? ' matter' : ' matters') + ' on the docket' + (history.length ? ' · ' + history.length + ' on the record' : '') : history.length ? history.length + ' on the record' : 'nothing on file yet',
-      table: table, annex: !vacant && floors.length >= plan.cap ? plan.annex : null, vacant: vacant,
+      annex: !vacant && floors.length >= plan.cap ? plan.annex : null, vacant: vacant,
     };
   }
 
@@ -558,9 +549,8 @@
     const docket = o.docket && Array.isArray(o.docket.matters) ? o.docket : null;
     const evening = !!docket && !(docket.counts && Number(docket.counts.needs) > 0);
     const bv = buildingView(T, o.key, b, { floor: o.floor, drawer: o.drawer, picks: o.picks, vacant: b.vacant, reviewHeld: !b.vacant, evening: evening, cleared: o.cleared });
-    bv.table = bv.table.map((r) => Object.assign({}, r, { color: r.color === 'accent' ? T.accentText : T.ink }));
     bv.key = o.key; bv.mode = mode; bv.vacant = b.vacant;
-    bv.label = b.name + ' in section: ' + b.floors.length + ' of ' + bv.cap + ' floors in use' + (bv.hasTable ? ', ' + bv.table.length + ' on the table' : '') + '.';
+    bv.label = b.name + ' in section: ' + b.floors.length + ' of ' + bv.cap + ' floors in use.';
     return bv;
   }