@bongos/core 1.21.29 → 1.21.31

package/tests/wizard_physics_more.mjs

@@ -184,9 +184,12 @@ function boot({ check = (body) => ({ stop: false, soft_limits: softLimitsFor(bod
     a: () => state.physics.answers,
     pick: (key, val) => q(`[data-phys="${key}"][data-val="${val}"]`)[0].click(),
     rowSays: (key) => [row(key).querySelector('[data-row-v]').textContent, row(key).querySelector('[data-row-s]').textContent],
-    ok: (key) => row(key).querySelector('[data-row-ok]').click(),
+    // a row's own check and confirmation, as the page's one "Looks right, continue" runs it
+    // per row (task 1004550): there is no per-row Looks right any more
+    ok: (key) => vm.runInContext(`confirmRow('${key}')`, sandbox),
+    // Edit opens a row; the same control reads Done while it is open, and confirms it
     change: (key) => row(key).querySelector('[data-row-chg]').click(),
-    use: (key) => row(key).querySelector('[data-row-use]').click(),
+    done: (key) => row(key).querySelector('[data-row-chg]').click(),
     isOpen: (key) => !row(key).querySelector('.opts').hidden,
     go: () => $('reviewGo'),
     settle: async () => { for (let i = 0; i < 4; i += 1) await tick(); },
@@ -343,9 +346,11 @@ test('Team size: one or many, a start count, and a guessed growth the founder co
   assert.deepEqual(w.rowSays('team'), ['4 people now', 'About 12 by month three · people you invite.']);
   w.state.teamShape = 'community'; w.run('paintSetup()');
   assert.equal(w.rowSays('team')[1], 'About 12 by month three · anyone can apply.');
-  w.use('team');
+  assert.equal(w.row('team').querySelector('[data-row-chg]').textContent, 'Done', 'an open row\'s one control reads Done');
+  w.done('team');
   assert.equal(w.state.confirmed.team, true);
-  assert.equal(w.isOpen('team'), false, 'Use this closes the row');
+  assert.equal(w.isOpen('team'), false, 'Done closes the row');
+  assert.equal(w.row('team').querySelector('[data-row-chg]').textContent, 'Edit');
 });
 
 test('changing the team re-asks the rows it moves: rewards and extras', async () => {
@@ -372,13 +377,13 @@ test('rewards are hidden for a solo founder: the real table hides the row, and t
   assert.equal(w.run("rowApplies('rewards')"), false, 'the REAL softLimitsFor hides reward_intents for one-and-one');
   assert.equal(w.row('rewards').hidden, true, 'and the row goes with it');
   assert.ok(!w.run('unconfirmedRows()').includes('rewards'), 'nothing to confirm for a question never asked');
-  assert.equal(w.go().textContent, 'Confirm 6 more', 'six rows apply');
+  assert.equal(w.run('unconfirmedRows()').length, 6, 'six rows apply');
   assert.equal(w.run('createDetail()').reward_intents, undefined);
   w.change('team');
   w.q('[data-phys-solo="many"]')[0].click();
   await w.settle();
   assert.equal(w.row('rewards').hidden, false, 'a team brings the question back, once the table is asked again');
-  assert.equal(w.go().textContent, 'Confirm 7 more');
+  assert.equal(w.run('unconfirmedRows()').length, 7);
 });
 
 test('rewards: a greyed option is disabled and leaves the list, and each reason is said once', async () => {
@@ -472,30 +477,46 @@ test('a demo\'s team, rewards and run are the demo\'s own: fixed, said plainly,
 });
 
 // ── confirming, and the locked Continue ──────────────────────────────────────
-test('the review locks Continue until every row that applies is confirmed, and validateStep opens the first one left', async () => {
+test('one "Looks right, continue" confirms every row that applies, each through its own check (task 1004550)', async () => {
   const w = await onReview({ builders_at_start: 3, builders_expected: 8 });
-  assert.equal(w.go().disabled, true);
-  assert.equal(w.go().textContent, 'Confirm 7 more');
-  assert.equal(w.run('validateStep(4)'), false);
-  assert.equal(w.isOpen('code'), true, 'the first unconfirmed row opens');
-  for (const [i, key] of ['code', 'address', 'app', 'extras', 'team', 'rewards'].entries()) {
-    w.ok(key);
-    assert.equal(w.state.confirmed[key], true, key);
-    assert.equal(w.row(key).querySelector('[data-row-ok]').textContent, 'Confirmed');
-    assert.equal(w.row(key).querySelector('[data-row-ok]').disabled, true);
-    assert.equal(w.go().textContent, `Confirm ${6 - i} more`);
-  }
+  assert.equal(w.go().disabled, false, 'Continue is never locked: it is the confirmation');
+  assert.equal(w.go().textContent, 'Looks right, continue');
+  assert.equal(w.row('code').querySelector('[data-row-ok]'), null, 'no row carries a Looks right of its own');
+  assert.equal(w.run('unconfirmedRows()').length, 7, 'nothing is confirmed before the founder says so');
+  assert.equal(w.run('validateStep(4)'), true, 'one Continue confirms them all');
+  for (const key of ['code', 'address', 'app', 'extras', 'team', 'rewards', 'run']) assert.equal(w.state.confirmed[key], true, key);
   assert.equal(w.state.modules && plain(w.state.modules).join(), 'discord', 'confirming the extras is the answer the create sends');
-  w.ok('run');
-  assert.equal(w.go().disabled, false);
-  assert.equal(w.go().textContent, 'Continue');
-  assert.equal(w.run('validateStep(4)'), true);
   w.change('team');
-  assert.equal(w.state.confirmed.team, undefined, 'Change takes a row back');
+  assert.equal(w.state.confirmed.team, undefined, 'Edit takes a row back');
   assert.equal(w.isOpen('team'), true);
-  assert.equal(w.go().textContent, 'Confirm 1 more');
+  assert.deepEqual(plain(w.run('unconfirmedRows()')), ['team']);
+  w.done('team');
+  assert.equal(w.isOpen('team'), false, 'Done closes it again');
+  assert.equal(w.state.confirmed.team, true, 'and Done is the answer');
+});
+
+test('Continue stops on the first row that fails its check, opened with its reason, and confirms nothing past it', async () => {
+  const w = await onReview({ builders_at_start: 3, builders_expected: 8 });
+  w.state.physics.answers.builders_at_start = 4; w.state.physics.answers.builders_expected = 2;   // fewer later than now
+  assert.equal(w.run('validateStep(4)'), false, 'Continue refuses');
+  assert.equal(w.isOpen('team'), true, 'the failing row opens');
+  assert.equal(w.state.confirmed.team, undefined);
+  assert.equal(w.state.confirmed.rewards, undefined, 'nothing after it is confirmed on the founder\'s behalf');
+  assert.equal(w.state.confirmed.code, true, 'the rows before it held, and stay confirmed');
+  assert.match(w.$('h-review').textContent, /Fix the row that’s open/);
+  assert.equal(w.$('h-review').className, 'hint err');
+});
+
+test('opening a row closes another open one whose answer holds, and leaves one that fails open', async () => {
+  const w = await onReview({ builders_at_start: 3, builders_expected: 8 });
+  w.change('code');
   w.change('team');
-  assert.equal(w.isOpen('team'), false, 'a second Change closes it again');
+  assert.equal(w.isOpen('code'), false, 'one row open at a time');
+  assert.equal(w.state.confirmed.code, true, 'closing it that way is the same as Done');
+  w.state.physics.answers.builders_expected = 1;   // fewer later than now: the team row fails
+  w.change('run');
+  assert.equal(w.isOpen('team'), true, 'a row that fails its check stays open');
+  assert.equal(w.isOpen('run'), true);
 });
 
 test('the prefills never overwrite a founder\'s own answer', () => {
@@ -578,7 +599,7 @@ test('a new owner walks from the quick checks through a fully confirmed review,
   w.ok('code'); w.ok('address'); w.ok('app'); w.ok('extras');
   w.change('team');
   w.q('[data-phys-solo="many"]')[0].click();
-  w.use('team');
+  w.done('team');
   await w.settle();
   assert.equal(w.state.confirmed.extras, undefined, 'the team moved the extras\' preselect, so that row is asked again');
   w.ok('extras');
@@ -586,16 +607,15 @@ test('a new owner walks from the quick checks through a fully confirmed review,
   w.change('rewards');
   w.pick('reward_intents', 'cash');
   w.pick('reward_intents', 'equity');
-  w.use('rewards');
+  w.done('rewards');
   w.change('run');
   w.pick('framing', 'open-source');
   await w.settle();
-  w.use('run');
+  w.done('run');
   assert.equal(w.state.confirmed.app, undefined, 'the framing moved the App hosting row');
   assert.equal(w.rowSays('app')[0], 'Runs on your own machines');
-  w.ok('app');
-  assert.equal(w.go().textContent, 'Continue');
-  assert.equal(w.run('validateStep(4)'), true);
+  assert.equal(w.run('validateStep(4)'), true, 'one Continue confirms the rest');
+  assert.equal(w.state.confirmed.app, true);
   const d = plain(w.run('createDetail()'));
   assert.deepEqual({ voice: d.voice, framing: d.framing, services: d.services, team: [d.builders_at_start, d.builders_expected], shape: d.team_shape, rewards: d.reward_intents },
     { voice: 'professional', framing: 'open-source', services: undefined, team: [2, 5], shape: 'small-team', rewards: ['cash', 'equity'] });
@@ -611,10 +631,14 @@ test('no path reaches Look without the founder confirming the address: a prefill
     assert.equal(w.row('address').querySelector('[data-row-chg]').hidden, false, `${label}: it can always be changed`);
     for (const key of ['code', 'app', 'extras', 'team', 'rewards', 'run']) if (w.run(`rowApplies('${key}')`)) w.ok(key);
     assert.deepEqual(plain(w.run('unconfirmedRows()')), ['address'], `${label}: every other row confirmed, the address still asked`);
-    assert.equal(w.go().disabled, true, `${label}: Continue stays locked`);
-    assert.equal(w.run('validateStep(4)'), false, `${label}: Continue refuses`);
+    // the address is on the page the founder confirms (task 1004550): only their own
+    // "Looks right, continue" — or Done on the row — confirms it, and its check still runs
+    w.run('validateAddress = function () { return false; }');
+    assert.equal(w.run('validateStep(4)'), false, `${label}: an address that fails its check refuses Continue`);
     assert.equal(w.isOpen('address'), true, `${label}: and opens the address row`);
-    w.use('address');
+    assert.equal(w.state.confirmed.address, undefined, `${label}: still unconfirmed`);
+    w.run('validateAddress = function () { return true; }');
+    w.done('address');
     assert.equal(w.state.confirmed.address, true, `${label}: choosing it is the answer`);
     assert.equal(w.run('validateStep(4)'), true, `${label}: then Continue goes on`);
   }

package/tests/wizard_six_screens.mjs

@@ -55,7 +55,7 @@ test('each screen opens with the mockup\'s own words', () => {
     ['panel-fork', 'You’re about to start a digital planet.', 'Try a small demo first, or start your real project.'],
     ['panel-what', 'What are you making?', null],
     ['panel-checks', 'A few quick checks.', 'These decide which legal and payout options we can offer.'],
-    ['panel-review', 'Check what we set up.', 'We filled these in from your answers. Confirm each one, or change it.'],
+    ['panel-review', 'Check what we set up.', 'We filled these in from your answers. Change anything that’s wrong.'],
     ['panel-look', 'Give it a look.', 'So builders always know which project they’re in.'],
   ];
   for (const [id, h, lede] of pairs) {
@@ -81,19 +81,21 @@ test('planet words survive only as the light touch: the fork and the alive momen
   assert.match(SCRIPT, /if \(inst\.last_verified_up\) \{\n\s*\/\*[^*]*\*\/\n\s*\$\('done-h'\)\.textContent =/, 'said only once the project has answered (Live is a verified claim)');
 });
 
-test('the review cannot be skipped: seven rows, each confirmed or changed, and a locked Continue', () => {
+test('the review cannot be skipped: seven rows, one Edit each, and one Continue that confirms them all (task 1004550)', () => {
   const p = panel('panel-review');
   const rows = [...p.matchAll(/<div class="setRow" data-row="([a-z]+)">/g)].map((m) => m[1]);
   assert.deepEqual(rows, ['code', 'address', 'app', 'extras', 'team', 'rewards', 'run']);
   for (const key of rows) {
     const r = (p.match(new RegExp(`<div class="setRow" data-row="${key}">[\\s\\S]*?<span class="acts">[^\\n]*\\n`)) || [''])[0];
-    assert.match(r, /<button type="button" class="rowOk" data-row-ok>Looks right<\/button><button type="button" class="rowChg" data-row-chg aria-expanded="false">Change<\/button>/, `${key}: Looks right and Change`);
-    assert.match(r, /<div class="opts" hidden>[\s\S]*<button type="button" class="btn small rowUse" data-row-use>Use this<\/button>/, `${key}: Change opens the row's own controls with Use this`);
+    assert.match(r, /<span class="acts"><button type="button" class="rowChg" data-row-chg aria-expanded="false">Edit<\/button><\/span>/, `${key}: one Edit, nothing else`);
+    assert.match(r, /<div class="opts" hidden>/, `${key}: Edit opens the row's own controls`);
   }
-  assert.match(p, /<button type="submit" class="btn" id="reviewGo" disabled>Confirm 7 more<\/button>/, 'Continue is baked locked');
-  assert.match(SCRIPT, /go\.textContent = left \? 'Confirm ' \+ left \+ ' more' : 'Continue';/, 'and says how many rows are left');
-  assert.match(SCRIPT, /if \(step === 4\) \{\n\s*var open = unconfirmedRows\(\);\n\s*if \(open\.length\) \{ openRow\(open\[0\]\); return false; \}/, 'Continue with a row left opens that row');
-  assert.match(SCRIPT, /if \(unconfirmedRows\(\)\.length\) \{ show\(4, true\); validateStep\(4\); return; \}/, 'and Create refuses until every row is confirmed');
+  assert.doesNotMatch(p, /data-row-ok|data-row-use|Use this/, 'no per-row Looks right and no Use this are left');
+  assert.match(p, /<button type="submit" class="btn" id="reviewGo">Looks right, continue<\/button>/, 'Continue is the one confirmation, never locked');
+  assert.match(SCRIPT, /if \(step === 4\) return confirmAllRows\(\);/, 'Continue confirms every row through its own check');
+  assert.match(SCRIPT, /if \(!confirmRow\(rows\[i\]\)\) \{/, 'and stops on the first that fails');
+  assert.match(SCRIPT, /if \(unconfirmedRows\(\)\.length\) \{ reopenReview\(\); return; \}/, 'and Create refuses until every row is confirmed');
+  assert.match(SCRIPT, /chg\.textContent = 'Done';/, 'an open row\'s control reads Done');
 });
 
 test('nothing the old steps could do is lost: their controls are moved whole into the rows', () => {