@bongos/core 1.21.175 → 1.21.176

package/tests/backfill_sessions.mjs

@@ -16,9 +16,9 @@ import os from 'node:os';
 import path from 'node:path';
 
 const require = createRequire(import.meta.url);
-const bf = require('../scripts/gds/backfill-sessions.js');
-const { encodeProjectPath } = require('../scripts/gds/ship.js');
-const { looksLikeGraderTranscript } = require('../scripts/gds/session-cost.js');
+const bf = require('../scripts/bongos/backfill-sessions.js');
+const { encodeProjectPath } = require('../scripts/bongos/ship.js');
+const { looksLikeGraderTranscript } = require('../scripts/bongos/session-cost.js');
 
 let passed = 0;
 let failed = 0;
@@ -39,7 +39,7 @@ const toolUse = (name, input) => ({ type: 'assistant', message: { content: [{ ty
 const toolResult = (text) => ({ type: 'user', message: { content: [{ type: 'tool_result', content: text }] } });
 
 test('extracts a shipped task from a ship.js invocation', () => {
-  const ids = bf.extractTaskIds([toolUse('Bash', { command: 'node scripts/gds/ship.js 681 --regrade' })]);
+  const ids = bf.extractTaskIds([toolUse('Bash', { command: 'node scripts/bongos/ship.js 681 --regrade' })]);
   assert.deepEqual(ids, [681]);
 });
 
@@ -79,7 +79,7 @@ test('dedupes and sorts across a multi-task session', () => {
   const entries = [
     asst('Claimed #284. Dispatching.'),
     asst('Claimed #270. Dispatching.'),
-    toolUse('Bash', { command: 'node scripts/gds/ship.js 284' }), // repeat of 284
+    toolUse('Bash', { command: 'node scripts/bongos/ship.js 284' }), // repeat of 284
     asst('Claimed #299.'),
   ];
   assert.deepEqual(bf.extractTaskIds(entries), [270, 284, 299]);
@@ -181,7 +181,7 @@ test('grader detection matches a NEW worker persona, not just the known four', (
 
 test('extracts a 7-digit task id from a ship.js invocation', () => {
   // {1,4} matched nothing on a live instance, so no modern session could ever pay.
-  const ids = bf.extractTaskIds([toolUse('Bash', { command: 'node scripts/gds/ship.js 1002471' })]);
+  const ids = bf.extractTaskIds([toolUse('Bash', { command: 'node scripts/bongos/ship.js 1002471' })]);
   assert.deepEqual(ids, [1002471]);
 });
 
@@ -194,7 +194,7 @@ test('extracts 7-digit ids from claim/release/Claimed markers', () => {
 test('7-digit ids survive extractTaskIds (the n < 10000 clamp is gone)', () => {
   // Widening TASK_MARKERS alone was not enough: the clamp dropped them again.
   const entries = [
-    toolUse('Bash', { command: 'node scripts/gds/ship.js 1002471' }),
+    toolUse('Bash', { command: 'node scripts/bongos/ship.js 1002471' }),
     asst('Claimed #284.'), // legacy 3-digit ids must still work
   ];
   assert.deepEqual(bf.extractTaskIds(entries), [284, 1002471]);
@@ -208,7 +208,7 @@ test('grader worker transcripts are detectable and would otherwise be paid', ()
   const file = path.join(dir, 'aaaaaaaa-0000-0000-0000-000000000000.jsonl');
   const graderPrompt =
     'You are the **Narc** — a specialist adversarial subagent for this project. ' +
-    'Review the diff shipped by node scripts/gds/ship.js 1002471 --summary "x".';
+    'Review the diff shipped by node scripts/bongos/ship.js 1002471 --summary "x".';
   try {
     fs.writeFileSync(file, JSON.stringify({ type: 'user', message: { role: 'user', content: graderPrompt } }) + '\n');
     assert.ok(looksLikeGraderTranscript(file), 'the grader worker prompt must be detected');

package/tests/backfill_subagent_rewards.mjs

@@ -17,7 +17,7 @@ import { makeRunner } from './helpers.mjs';
 const require = createRequire(import.meta.url);
 const {
   CLASSES, DEDUP_FIX_AT, classifySession, buildBackfillPlan, renderReport,
-} = require('../scripts/gds/backfill-subagent-rewards.js');
+} = require('../scripts/bongos/backfill-subagent-rewards.js');
 const {
   computeSessionTokenReward, sessionTrueCostUsd, awardSessionTokenReward,
 } = require('../modules/economy/credits.js');

package/tests/backfill_task_rewards.mjs

@@ -1,6 +1,6 @@
 // tests/backfill_task_rewards.mjs
 //
-// Unit tests for the PURE logic of scripts/gds/backfill-task-rewards.js
+// Unit tests for the PURE logic of scripts/bongos/backfill-task-rewards.js
 // (task 1672, ADR 0097) — the retroactive 0-reward drachmae backfill tool.
 //
 // Covered (NO DB, NO network):
@@ -25,7 +25,7 @@ const {
   computeTaskReward,
   netForBuilder,
   planForBuilder,
-} = require('../scripts/gds/backfill-task-rewards.js');
+} = require('../scripts/bongos/backfill-task-rewards.js');
 
 const { test, summary } = makeRunner();
 

package/tests/backlog_review.mjs

@@ -16,7 +16,7 @@ import { fileURLToPath } from 'node:url';
 
 const require = createRequire(import.meta.url);
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
-const br = require('../scripts/gds/backlog-review.js');
+const br = require('../scripts/bongos/backlog-review.js');
 
 const task = (over = {}) => ({
   id: 1, status: 'backlog', kind: 'feature', title: 't', created_at: '2026-01-01T00:00:00Z',
@@ -169,9 +169,9 @@ test('the API limit the script asks for is within the route cap of 1000', () =>
 
 // --- the skill names a command that exists and runs -----------------------
 
-test('SKILL.md names scripts/gds/backlog-review.js and that file loads and partitions', () => {
+test('SKILL.md names scripts/bongos/backlog-review.js and that file loads and partitions', () => {
   const skill = fs.readFileSync(path.join(ROOT, '.claude', 'skills', 'backlog-review', 'SKILL.md'), 'utf8');
-  assert.match(skill, /scripts\/gds\/backlog-review\.js/, 'the skill must name the script it runs');
+  assert.match(skill, /scripts\/(?:gds|bongos)\/backlog-review\.js/, 'the skill must name the script it runs');
   // Executed, not paraphrased: the module the prose points at really answers.
   const p = br.partitionBacklog([task({ id: 99 })]);
   assert.deepEqual(p.nod.map((t) => t.id), [99]);

package/tests/baseline_staleness.mjs

@@ -16,7 +16,7 @@ import { fileURLToPath } from 'node:url';
 
 const require = createRequire(import.meta.url);
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
-const bs = require(path.join(ROOT, 'scripts', 'gds', 'baseline-staleness.js'));
+const bs = require(path.join(ROOT, 'scripts', 'bongos', 'baseline-staleness.js'));
 
 const NOW = Date.parse('2026-08-24T00:00:00Z');
 const daysAgo = (n) => new Date(NOW - n * 86400000).toISOString();
@@ -193,7 +193,7 @@ test('LIVE: --update-baselines preserves the floors instead of overwriting them'
   // ({_comment: '<hardcoded>', metrics}), so one refresh silently destroyed both
   // the accumulated comment and every floor — and a lost floor turns a finished
   // metric into permanent weekly noise with its reason gone from the repo.
-  const rat = require(path.join(ROOT, 'scripts', 'gds', 'fitness-ratchets.js'));
+  const rat = require(path.join(ROOT, 'scripts', 'bongos', 'fitness-ratchets.js'));
   const before = JSON.parse(fs.readFileSync(rat.BASELINE_PATH, 'utf8'));
   assert.ok(before.floors && Object.keys(before.floors).length > 0, 'the shipped file must carry floors');
   // Simulate the writer's preserve step on a temp copy rather than running the

package/tests/bfg.mjs

@@ -18,7 +18,6 @@ const require = createRequire(import.meta.url);
 const bfg = require('../modules/sessions/bfg.js'); // carved → modules/sessions/ (BV1.R82 / ADR 0093 §1)
 const auth = require('../src/module-api'); // doorway: memory-module routes capture api.requireBuilder, so the stub must patch the doorway (BV1.R72 / ADR 0091)
 const memory = require('../modules/memory/memory.js');
-const db = require('../src/bongos/db.js');
 
 let passed = 0;
 let failed = 0;
@@ -230,7 +229,7 @@ const orig = {
   requireBfgPrincipal: auth.requireBfgPrincipal,
   listMemoryFiles: memory.listMemoryFiles,
   fetchMemoryFile: memory.fetchMemoryFile,
-  insertAuditLog: db.insertAuditLog,
+  insertAuditLog: auth.insertAuditLog,
 };
 const fixture = { session: { id: 9, system_role: 'bfg', rank: 'xenos' }, storeCalls: [], auditCalls: [], auditShouldThrow: false };
 
@@ -248,7 +247,10 @@ memory.fetchMemoryFile = async function (builderId, p) {
   if (p === 'missing.md') return null;
   return { path: p, content: 'hi', sha256: 'a', byte_len: 2, mtime: null, updated_at: 'now', created_at: 'now' };
 };
-db.insertAuditLog = async function (row) {
+// The route reaches the audit insert through the module doorway (`db = api` in
+// modules/memory/routes/memory.js), so the stub goes on the doorway — stubbing
+// src/bongos/db.js left the REAL insert in place, which needs Postgres (task 1004865).
+auth.insertAuditLog = async function (row) {
   await new Promise((r) => setImmediate(r));
   if (fixture.auditShouldThrow) throw new Error('audit down');
   fixture.auditCalls.push(row);
@@ -258,6 +260,10 @@ db.insertAuditLog = async function (row) {
 const express = require('express');
 const app = express();
 app.use(express.json());
+// Install res.fail() as the real app does — the routes answer every error through it
+// (task 1004865; the tests/memory_isolation.mjs idiom).
+const { attachFail } = require('../src/bongos/middleware/error-envelope.js');
+app.use(attachFail);
 app.use('/api/gds', buildMemoryRouter());
 const server = http.createServer(app);
 await new Promise((resolve) => server.listen(0, '127.0.0.1', resolve));
@@ -311,7 +317,7 @@ try {
     const res = await fetch(`${base}/memory/bfg/builders/42/file?path=notes.md`);
     assert.equal(res.status, 500);
     const body = await res.json();
-    assert.equal(body.error, 'audit_failed');
+    assert.equal(body.error.code, 'audit_failed');
     assert.ok(!('content' in body));
   });
 } finally {
@@ -320,7 +326,7 @@ try {
   auth.requireBfgPrincipal = orig.requireBfgPrincipal;
   memory.listMemoryFiles = orig.listMemoryFiles;
   memory.fetchMemoryFile = orig.fetchMemoryFile;
-  db.insertAuditLog = orig.insertAuditLog;
+  auth.insertAuditLog = orig.insertAuditLog;
 }
 
 console.log(`\n${passed} passed, ${failed} failed`);

package/tests/bfg_write.mjs

@@ -28,7 +28,7 @@ import url from 'node:url';
 const require = createRequire(import.meta.url);
 const auth = require('../src/module-api'); // doorway: memory-module routes capture api.requireBuilder, so the stub must patch the doorway (BV1.R72 / ADR 0091)
 const memory = require('../modules/memory/memory.js');
-const db = require('../src/bongos/db.js');
+const { attachFail } = require('../src/bongos/middleware/error-envelope.js');
 
 let passed = 0;
 let failed = 0;
@@ -54,6 +54,9 @@ function runGate(builder) {
     status(c) { code = c; return this; },
     json(b) { body = b; return this; },
   };
+  // The real gate answers through res.fail(), which the app installs on every response
+  // (attachFail). Decorate the fake the same way rather than re-implementing it (task 1004865).
+  attachFail(req, res, () => {});
   auth.requireBfgPrincipal(req, res, () => { nexted = true; });
   return { nexted, code, body };
 }
@@ -68,7 +71,7 @@ await t('an ARCHON token is REJECTED (403 not_bfg_principal) — the ADR 0026 §
   const r = runGate({ id: 1, rank: 'archon', system_role: null });
   assert.equal(r.nexted, false, 'an archon must NOT reach the write path');
   assert.equal(r.code, 403);
-  assert.equal(r.body.error, 'not_bfg_principal');
+  assert.equal(r.body.error.code, 'not_bfg_principal');
 });
 
 await t('a metic and a xenos are both rejected', () => {
@@ -214,7 +217,7 @@ const orig = {
   bfgWriteMemoryFile: memory.bfgWriteMemoryFile,
   storeMemoryFilesBatch: memory.storeMemoryFilesBatch,
   deleteMemoryFile: memory.deleteMemoryFile,
-  getBuilderById: db.getBuilderById,
+  getBuilderById: auth.getBuilderById,
   BFG_WRITE_ENABLED: process.env.BFG_WRITE_ENABLED,
 };
 
@@ -252,7 +255,10 @@ memory.deleteMemoryFile = async function stubDelete(builderId, p) {
   fixture.deleteCalls.push({ builderId, path: p });
   return p === 'bfg/gone.md' ? 0 : 1; // 0 = nothing to delete
 };
-db.getBuilderById = async function stubGet(id) {
+// The route reaches the builder lookup through the module doorway (`db = api` in
+// modules/memory/routes/memory.js), so the stub goes on the doorway — stubbing
+// src/bongos/db.js left the REAL lookup in place, which needs Postgres (task 1004865).
+auth.getBuilderById = async function stubGet(id) {
   if (Number(id) === fixture.target.id) return fixture.target;
   if (Number(id) === 999) return null;
   if (Number(id) === 500) return { id: 500, system_role: 'bfg' }; // another system principal
@@ -262,6 +268,9 @@ db.getBuilderById = async function stubGet(id) {
 const express = require('express');
 const app = express();
 app.use(express.json());
+// Install res.fail() as the real app does — the route answers every error through it,
+// in the { error: { code, message } } envelope (task 1004865).
+app.use(attachFail);
 app.use('/api/gds', buildMemoryRouter());
 const server = http.createServer(app);
 await new Promise((resolve) => server.listen(0, '127.0.0.1', resolve));
@@ -307,7 +316,7 @@ try {
     fixture.session = { id: 9, github_login: 'bfg-system', system_role: 'bfg', rank: 'xenos' };
     const res = await post('/memory/builders/42/bfg-write', VALID);
     assert.equal(res.status, 503);
-    assert.equal((await res.json()).error, 'bfg_write_disabled');
+    assert.equal((await res.json()).error.code, 'bfg_write_disabled');
     assert.equal(fixture.writeCalls.length, 0);
     process.env.BFG_WRITE_ENABLED = 'true';
   });
@@ -317,7 +326,7 @@ try {
     fixture.session = { id: 9, github_login: 'bfg-system', system_role: 'bfg', rank: 'xenos' };
     const res = await post('/memory/builders/9/bfg-write', VALID);
     assert.equal(res.status, 400);
-    assert.equal((await res.json()).error, 'bfg_cannot_write_self');
+    assert.equal((await res.json()).error.code, 'bfg_cannot_write_self');
     assert.equal(fixture.writeCalls.length, 0);
   });
 
@@ -325,7 +334,7 @@ try {
     reset();
     const res = await post('/memory/builders/500/bfg-write', VALID);
     assert.equal(res.status, 400);
-    assert.equal((await res.json()).error, 'target_is_system_principal');
+    assert.equal((await res.json()).error.code, 'target_is_system_principal');
     assert.equal(fixture.writeCalls.length, 0);
   });
 
@@ -340,7 +349,7 @@ try {
     reset();
     const res = await post('/memory/builders/42/bfg-write', { ...VALID, kind: 'nightmare' });
     assert.equal(res.status, 400);
-    assert.equal((await res.json()).error, 'bad_bfg_input');
+    assert.equal((await res.json()).error.code, 'bad_bfg_input');
     assert.equal(fixture.writeCalls.length, 0);
   });
 
@@ -378,7 +387,7 @@ try {
     reset();
     const res = await post('/memory/builders/42/bfg-write', { kind: 'correction', slug: 'x', body_md: 'b', rationale: 'r', karma_delta: 5 });
     assert.equal(res.status, 400);
-    assert.equal((await res.json()).error, 'bad_karma_delta');
+    assert.equal((await res.json()).error.code, 'bad_karma_delta');
     assert.equal(fixture.writeCalls.length, 0);
   });
 
@@ -386,7 +395,7 @@ try {
     reset();
     const res = await post('/memory/builders/42/bfg-write', { ...VALID, karma_delta: -1 });
     assert.equal(res.status, 400);
-    assert.equal((await res.json()).error, 'karma_delta_not_allowed');
+    assert.equal((await res.json()).error.code, 'karma_delta_not_allowed');
     assert.equal(fixture.writeCalls.length, 0);
   });
 
@@ -414,7 +423,7 @@ try {
   memory.bfgWriteMemoryFile = orig.bfgWriteMemoryFile;
   memory.storeMemoryFilesBatch = orig.storeMemoryFilesBatch;
   memory.deleteMemoryFile = orig.deleteMemoryFile;
-  db.getBuilderById = orig.getBuilderById;
+  auth.getBuilderById = orig.getBuilderById;
   if (orig.BFG_WRITE_ENABLED === undefined) delete process.env.BFG_WRITE_ENABLED;
   else process.env.BFG_WRITE_ENABLED = orig.BFG_WRITE_ENABLED;
 }

package/tests/blockers_hall.mjs

@@ -166,13 +166,23 @@ test('filing has no rank gate — any signed-in builder sees the File button, mi
     'the file form is mounted unconditionally, not behind an isReviewer()/rank check');
 });
 
-test('resolve/link controls mirror the SAME metic-or-archon floor the idea triage panel already uses — no floor of its own', () => {
-  assert.match(BLOCKERS_JS_SRC, /isReviewer\s*=\s*function\s*\(\)\s*\{\s*return viewer\.rank === 'metic' \|\| viewer\.rank === 'archon';\s*\}/);
-  assert.match(TASK_DETAIL_SRC, /kind === 'blocker' && r\.status === 'open' && \(rank === 'metic' \|\| rank === 'archon'\)/);
+// task 1004824: the routes gate on requirePermission('blocker.review'), which a
+// government can move off the metic floor, so BOTH surfaces mirror that atom
+// off /me.permissions — never a rank guess — and an unreadable map hides.
+test('resolve/link controls mirror the SAME blocker.review permission the routes check — no floor of their own', () => {
+  const ROUTES = readFileSync(join(ROOT, 'modules/ideas/routes/blockers.js'), 'utf8');
+  assert.match(ROUTES, /'\/blockers\/:id\/resolve', api\.requireBuilder, api\.requirePermission\('blocker\.review'\)/,
+    'the wall the page mirrors is still the blocker.review atom');
+  assert.match(BLOCKERS_JS_SRC, /isReviewer = function \(\) \{ return viewer\.mayReview === true; \}/);
+  assert.match(BLOCKERS_JS_SRC, /viewer = \{ mayReview: perms\['blocker\.review'\] === true \}/);
+  assert.match(TASK_DETAIL_SRC, /kind === 'blocker' && r\.status === 'open' && perms && perms\['blocker\.review'\] === true/);
+  assert.doesNotMatch(BLOCKERS_JS_SRC, /viewer\.rank === 'metic'/, 'no rank guess left behind');
+  const ME = readFileSync(join(ROOT, 'src/bongos/routes/me.js'), 'utf8');
+  assert.match(ME, /NAV_PERMISSION_ATOMS = Object\.freeze\(\[[^\]]*'blocker\.review'/, '/me must report the atom or the controls hide for everyone');
 });
 
 test('a 403 on resolve/link/file-link renders HONEST copy, not a silent no-op (the done-when, verbatim)', () => {
-  assert.match(BLOCKERS_JS_SRC, /err && err\.status === 403.*You need Metic\+ access to do that\./);
+  assert.match(BLOCKERS_JS_SRC, /err && err\.status === 403.*You can’t resolve or link blockers here\./);
   // The file-then-link flow specifically: a filer without blocker.review still
   // gets told the filing succeeded AND that linking needs a Metic+ — never a
   // swallowed catch that leaves them guessing whether anything happened.

package/tests/blockers_page_ui.mjs

@@ -31,6 +31,8 @@ import { makeRunner, makeEl, walk } from './helpers.mjs';
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
 const HALL = path.join(ROOT, 'modules/hall-ui/public');
 const HALL_KIT_SRC = fs.readFileSync(path.join(HALL, 'hall-kit.js'), 'utf8');
+// blockers.html loads hall-ask.js before blockers.js; a reviewer row is its card.
+const HALL_ASK_SRC = fs.readFileSync(path.join(HALL, 'hall-ask.js'), 'utf8');
 const BLOCKERS_JS_SRC = fs.readFileSync(path.join(HALL, 'blockers.js'), 'utf8');
 
 const require = createRequire(import.meta.url);
@@ -53,7 +55,11 @@ function fail(status, code, message) { return { status, ok: false, data: { error
 
 async function boot(opts = {}) {
   const {
+    // What GET /me reports for blocker.review (task 1004824 — the page mirrors
+    // the atom, not the rank). `permissions: null` models an unreadable map.
     rank = 'archon',
+    review = true,
+    permissions = undefined,
     rows = DEFAULT_ROWS,
     meDelayMs = 0,
     meFails = false,
@@ -76,7 +82,7 @@ async function boot(opts = {}) {
         if (meDelayMs) await tick(meDelayMs);
         requests.push({ method, path: p, body });
         if (meFails) return fail(401, 'auth_needed', 'sign in');
-        return ok({ builder: { id: 1, rank } });
+        return ok({ builder: { id: 1, rank }, permissions: permissions === undefined ? { 'blocker.review': review } : permissions });
       }
       requests.push({ method, path: p, body });
       if (method === 'POST' && url === '/blockers') {
@@ -133,12 +139,13 @@ async function boot(opts = {}) {
   };
   vm.createContext(sandbox);
   vm.runInContext(HALL_KIT_SRC, sandbox, { filename: 'hall-kit.js' });
+  vm.runInContext(HALL_ASK_SRC, sandbox, { filename: 'hall-ask.js' });
   vm.runInContext(BLOCKERS_JS_SRC, sandbox, { filename: 'blockers.js' });
   await settle();
 
   const body = () => documentObj.getElementById('blockers-body');
   const fileArea = () => documentObj.getElementById('blockers-file-area');
-  const rowsOf = () => body().querySelectorAll('.ov-row');
+  const rowsOf = () => [...body().querySelectorAll('li')].filter((el) => /(^|\s)(ov-row|hask)(\s|$)/.test(el.className || ''));
   const requestsTo = (method, re) => requests.filter((r) => r.method === method && re.test(r.path));
 
   // The FILE form's open/cancel buttons and its own submit carry a DIRECT
@@ -192,7 +199,7 @@ await test('the reverse order (viewer known first) already worked, and still doe
 });
 
 await test('a non-reviewer sees the row with no Resolve/Link controls at all', async () => {
-  const h = await boot({ rank: 'xenos' });
+  const h = await boot({ rank: 'xenos', review: false });
   const row = h.rowsOf()[0];
   assert.equal(row.querySelector('[data-resolve-open]'), null);
   assert.equal(row.querySelector('[data-link-open]'), null);
@@ -210,7 +217,7 @@ await test('a signed-out visitor (GET /me fails) sees the queue with no reviewer
 // ===========================================================================
 
 await test('filing alone (no task #) posts once and toasts the filed id', async () => {
-  const h = await boot({ rank: 'xenos' });
+  const h = await boot({ rank: 'xenos', review: false });
   h.click(h.fileOpenBtn());
   const form = h.fileForm();
   form.querySelector('#bf-title').value = 'Need a decision';
@@ -223,7 +230,7 @@ await test('filing alone (no task #) posts once and toasts the filed id', async
 });
 
 await test('filing WITH a task # does both in the one submit, and toasts success', async () => {
-  const h = await boot({ rank: 'xenos' });
+  const h = await boot({ rank: 'xenos', review: false });
   h.click(h.fileOpenBtn());
   const form = h.fileForm();
   form.querySelector('#bf-title').value = 'Need a decision';
@@ -236,13 +243,13 @@ await test('filing WITH a task # does both in the one submit, and toasts success
 });
 
 await test('a non-reviewer filer who names a task the link 403s on still gets an HONEST message — filing is not a silent no-op', async () => {
-  const h = await boot({ rank: 'xenos', linkResponse: fail(403, 'permission_forbidden', 'nope') });
+  const h = await boot({ rank: 'xenos', review: false, linkResponse: fail(403, 'permission_forbidden', 'nope') });
   h.click(h.fileOpenBtn());
   const form = h.fileForm();
   form.querySelector('#bf-title').value = 'Need a decision';
   form.querySelector('#bf-task-id').value = '5001';
   await h.submit(form);
-  assert.ok(h.toasts.some((t) => t === 'Blocker #900 filed. You need Metic+ access to do that.'),
+  assert.ok(h.toasts.some((t) => t === 'Blocker #900 filed. You can’t resolve or link blockers here.'),
     `expected the honest fallback, got: ${JSON.stringify(h.toasts)}`);
 });
 
@@ -308,7 +315,7 @@ await test('a 403 on resolve renders HONEST copy and leaves the form open — ne
   await h.settle();
   const form = h.body().querySelector('[data-resolve-form]');
   await h.submitRow(form);
-  assert.equal(form.querySelector('[data-err]').textContent, 'You need Metic+ access to do that.');
+  assert.equal(form.querySelector('[data-err]').textContent, 'You can’t resolve or link blockers here.');
 });
 
 await test('resolving through the shared #/blocker/N overlay (otb:blocker-resolved) reloads this page\'s queue too', async () => {
@@ -323,11 +330,48 @@ await test('resolving through the shared #/blocker/N overlay (otb:blocker-resolv
   assert.equal(after, before + 1, 'the queue re-fetched exactly once in response to the event');
 });
 
-await test('the sub-line reason prose has ONE source (blockers.html); JS never carries a copy (task 1003985)', () => {
+await test('no top block: the page head carries only its h1, and the JS writes no sub-line (task 1004824)', () => {
   const html = fs.readFileSync(path.join(HALL, 'blockers.html'), 'utf8');
-  // Wording is the artist's (page tweak, task 1004348); the invariant is the single source.
-  assert.match(html, /Any tasks awaiting the same block will unblock automatically on resolution/, 'the static sub-line keeps the prose');
-  assert.doesNotMatch(BLOCKERS_JS_SRC, /unblock automatically on resolution|gated at the owner level/, 'blockers.js must not duplicate the prose');
+  const head = html.slice(html.indexOf('class="page-head'), html.indexOf('</div>', html.indexOf('class="page-head')));
+  assert.doesNotMatch(head, /page-head__sub|blockers-sub/, 'the hidden head holds no tagline');
+  assert.doesNotMatch(BLOCKERS_JS_SRC, /blockers-sub|baseSub/, 'blockers.js no longer paints a sub-line');
+  assert.match(html, /class="scroll__h">Requires project owner fix</, 'the list is named the way Home names it');
+});
+
+// ===========================================================================
+// The controls follow the PERMISSION the server checks, never the rank (task 1004824)
+// ===========================================================================
+
+await test('an Archon WITHOUT blocker.review sees no Resolve/Link — the page mirrors the atom, not the rank', async () => {
+  const h = await boot({ rank: 'archon', review: false });
+  const row = h.rowsOf()[0];
+  assert.equal(row.querySelector('[data-resolve-open]'), null);
+  assert.equal(row.querySelector('[data-link-open]'), null);
+});
+
+await test('a Xenos the government granted blocker.review DOES get Resolve/Link', async () => {
+  const h = await boot({ rank: 'xenos', review: true });
+  const row = h.rowsOf()[0];
+  assert.ok(row.querySelector('[data-resolve-open]'));
+  assert.ok(row.querySelector('[data-link-open]'));
+});
+
+await test('an unreadable permissions map (null) hides the controls — never assumed held', async () => {
+  const h = await boot({ rank: 'archon', permissions: null });
+  assert.equal(h.rowsOf()[0].querySelector('[data-resolve-open]'), null);
+});
+
+await test('a reviewer row is the ask card with ONE decision; Link a task is a plain control', async () => {
+  const h = await boot({ review: true });
+  const card = h.rowsOf()[0];
+  assert.match(card.className, /(^|\s)hask(\s|$)/, 'the row is the shared ask card');
+  const chips = card.querySelectorAll('.hask__opt');
+  assert.equal(chips.length, 1, 'resolving is the only answer on the card');
+  assert.ok(chips[0].querySelector('[data-resolve-open]') || chips[0].attrs['data-resolve-open'], 'the one answer is Resolve it');
+  const link = card.querySelector('[data-link-open]');
+  assert.ok(link, 'Link a task is still offered to a reviewer');
+  assert.doesNotMatch(link.className, /hask__opt/, 'linking a task stays a plain button, not a card answer');
+  assert.equal(card.querySelectorAll('.hask__where').length, 0, 'the repeated "Waiting on the project owner" eyebrow is gone');
 });
 
 summary();

package/tests/bongos_dispatch.mjs

@@ -2,7 +2,7 @@
 //
 // DB-free unit test: it only inspects the static verb table and spawns the
 // help/unknown/bare paths (which return before touching the network). Picked up
-// automatically by scripts/gds/run-unit-tests.js (the `unit` gate).
+// automatically by scripts/bongos/run-unit-tests.js (the `unit` gate).
 import assert from 'node:assert/strict';
 import { test } from 'node:test';
 import { existsSync } from 'node:fs';
@@ -23,19 +23,19 @@ test('every required verb is registered', () => {
 
 test('every mapped script exists on disk (a typo cannot ship a dead verb)', () => {
   for (const [verb, def] of Object.entries(VERBS)) {
-    if (!def.script) continue; // special verbs (exec) dispatch without a backing scripts/gds/ file
+    if (!def.script) continue; // special verbs (exec) dispatch without a backing scripts/bongos/ file
     const p = path.join(GDS_DIR, def.script);
-    assert.ok(existsSync(p), `verb "${verb}" -> missing script scripts/gds/${def.script}`);
+    assert.ok(existsSync(p), `verb "${verb}" -> missing script scripts/bongos/${def.script}`);
   }
 });
 
 test('`bongos exec` runs a package script and refuses a path escape (ADR 0108 §3 / W3)', () => {
   const { resolveExecTarget } = bongos;
-  assert.ok(resolveExecTarget('scripts/gds/next-number.js'), 'a package-relative script resolves');
+  assert.ok(resolveExecTarget('scripts/bongos/next-number.js'), 'a package-relative script resolves');
   assert.equal(resolveExecTarget('/etc/passwd'), null, 'an absolute path is refused');
   assert.equal(resolveExecTarget('../../../etc/passwd'), null, 'a `..` escape is refused');
   // end-to-end: exec a harmless core script (next-number prints + exits 0)
-  const r = spawnSync(process.execPath, [BIN, 'exec', 'scripts/gds/next-number.js', '--json'], { encoding: 'utf8' });
+  const r = spawnSync(process.execPath, [BIN, 'exec', 'scripts/bongos/next-number.js', '--json'], { encoding: 'utf8' });
   assert.equal(r.status, 0, r.stderr);
   assert.match(r.stdout, /"migration"/, 'exec forwarded to the core script and returned its output');
   // refusal path exits 2 with guidance

package/tests/bongos_login.mjs

@@ -13,8 +13,8 @@ import path from 'node:path';
 import { fileURLToPath } from 'node:url';
 
 const require = createRequire(import.meta.url);
-const { normalizeInstanceBase, pollDecision } = require('../scripts/gds/login.js');
-const LOGIN_JS = path.join(path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..'), 'scripts', 'gds', 'login.js');
+const { normalizeInstanceBase, pollDecision } = require('../scripts/bongos/login.js');
+const LOGIN_JS = path.join(path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..'), 'scripts', 'bongos', 'login.js');
 
 test('normalizeInstanceBase adds https, strips trailing slashes + a pasted /api/bongos', () => {
   assert.equal(normalizeInstanceBase('example.com'), 'https://example.com');

package/tests/bug_attachment_audit.mjs

@@ -21,7 +21,7 @@ import assert from 'node:assert/strict';
 import { createRequire } from 'node:module';
 
 const require = createRequire(import.meta.url);
-const { describedAttachments, auditRows } = require('../scripts/gds/bug-attachment-audit.js');
+const { describedAttachments, auditRows } = require('../scripts/bongos/bug-attachment-audit.js');
 const { attachmentsDir } = require('../modules/discord/bug-attachments.js');
 const path = require('node:path');
 

package/tests/bug_attachment_recover.mjs

@@ -20,7 +20,7 @@ const require = createRequire(import.meta.url);
 const TMP = path.join(os.tmpdir(), `otb-bugrecover-${process.pid}`);
 process.env.BUG_ATTACHMENTS_DIR = TMP;
 const at = require('../modules/discord/bug-attachments.js');
-const rec = require('../scripts/gds/bug-attachment-recover.js');
+const rec = require('../scripts/bongos/bug-attachment-recover.js');
 
 let passed = 0, failed = 0;
 function t(name, fn) {
@@ -115,7 +115,7 @@ await t('recoverMessage: the attachment download keeps the CDN host allowlist',
 });
 
 await t('the audit no longer claims a lost file cannot be re-fetched, and points at this tool', async () => {
-  const src = await fs.readFile(new URL('../scripts/gds/bug-attachment-audit.js', import.meta.url), 'utf8');
+  const src = await fs.readFile(new URL('../scripts/bongos/bug-attachment-audit.js', import.meta.url), 'utf8');
   assert.ok(!/cannot be re-fetched/i.test(src));
   assert.match(src, /bug-attachment-recover\.js --missing/);
   const mod = await fs.readFile(new URL('../modules/discord/bug-attachments.js', import.meta.url), 'utf8');

package/tests/bug_triage.mjs

@@ -26,7 +26,7 @@ const require = createRequire(import.meta.url);
 // { ok, data, status } responses, and record every call for assertion.
 const calls = [];
 let responses = {};
-const cliLib = require('../scripts/gds/cli-lib.js');
+const cliLib = require('../scripts/bongos/cli-lib.js');
 cliLib.cliClient = async () => ({
   tasks: {
     getTasks: async (args) => { calls.push({ method: 'getTasks', args }); return responses.getTasks; },
@@ -35,8 +35,8 @@ cliLib.cliClient = async () => ({
   },
 });
 
-const { clusterRecords } = require('../scripts/gds/triage.js');
-const { listOpenBugTasks, mergeTaskInto, dismissTask, OPEN_STATUSES } = require('../scripts/gds/bug-triage.js');
+const { clusterRecords } = require('../scripts/bongos/triage.js');
+const { listOpenBugTasks, mergeTaskInto, dismissTask, OPEN_STATUSES } = require('../scripts/bongos/bug-triage.js');
 
 const { test, summary } = makeRunner();
 

package/tests/build_info.mjs

@@ -12,7 +12,7 @@ import { createRequire } from 'node:module';
 
 const require = createRequire(import.meta.url);
 const { resolveCommit } = require('../src/build-info.js');
-const { deployedCommitStatus } = require('../scripts/gds/ship.js');
+const { deployedCommitStatus } = require('../scripts/bongos/ship.js');
 
 let passed = 0;
 let failed = 0;