@bongos/core 1.21.174 → 1.21.175

package/modules/hall-ui/records/hall-ask-card.md

@@ -0,0 +1,24 @@
+# The city's ask card, in the hall — every action a builder answers in place (task 1004820)
+
+Criterion `wa6-hall-reads-like-home` of goal 1000095 (owner ask 2026-10-23): the buttons a builder acts
+on inside the hall use the card template the city view built (`street-deck.css` `.ask`, task 1004702).
+
+- **One builder, one sheet.** `hall-ask.js` (`window.OTBAsk.html`) draws the card — where it sits, the
+  question, what was said, each answer as a one-tap option chip with its result line — and
+  `hall-ask.css` styles it under its own `hask` prefix on the hall's tokens, light and twice dark. The
+  city keeps `.ask`; a page loading both never cascades one into the other.
+- **No second action path.** An option carries the same `data-*` the page's delegated handler already
+  read, so switching a row to the card changes how it looks, never what it calls. An option with `href`
+  is a link, for an act that needs its own panel (resolving a blocker opens its overlay).
+- **Where it is applied.** Home's attention inbox (join invitations, join requests, the nod, "was this
+  removed?", untouched work, and the blocker slice — which had NO action and now has "Resolve it"),
+  the Blockers page's closed reviewer rows (Resolve it / Link a task; the open forms are unchanged), and
+  the Board Room's vote (Vote yes / Object as the card's chips).
+- **Rows keep `.ginbox__item`**, because `OTBAttention.refresh()` counts them; `hall-ask.css` makes the
+  card's own box win over the ledger row.
+- **Wording follows the Home rebuild:** a question, not a label ("Join X?", "Let Ana join?"), and every
+  answer says what it does.
+
+Left for the page tasks of the same criterion (1004821–1004829), which each re-lay a whole page: the
+task page's lifecycle buttons, Goals' row claim/release, collab, gate, profile connections and the
+government forms.

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.174",
+  "version": "1.21.175",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.21.174",
+      "version": "1.21.175",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.174",
+  "version": "1.21.175",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -10130,5 +10130,11 @@
       "id": "1004819",
       "text": "Every version now has an artist review goal, holding all copywriting and Artist Studio work, with two standing checks: every page reviewed by an artist before the version closes, and every page simple to read and use. New page"
     }
+  ],
+  "1.21.175": [
+    {
+      "id": "1004820",
+      "text": "Actions in the hall now use the city's ask card: a question, then one big button per answer that says what it does. Home's inbox (join invites and requests, the nod, removals, stale work) and the Blockers page and Board Room v"
+    }
   ]
 }

package/src/module-api.js

@@ -75,7 +75,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.21.174'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.21.175'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/blockers_hall.mjs

@@ -54,7 +54,9 @@ test('goal-inbox.js renders blocker rows through the SHARED lib, not a re-implem
 });
 
 test('the blocker row carries .ginbox__item, so the card\'s count-pill and visibility include it', () => {
-  assert.match(GOAL_INBOX_SRC, /function blockerRowHtml[\s\S]*?class="ginbox__item"/);
+  // task 1004820: the row is the city's ask card, drawn by OTBAsk with the item class
+  assert.match(GOAL_INBOX_SRC, /function blockerRowHtml[\s\S]*?OTBAsk\.html\(\{[\s\S]*?cls: 'ginbox__item'/);
+  assert.match(GOAL_INBOX_SRC, /function blockerRowHtml[\s\S]*?label: 'Resolve it'/, 'the home blocker row is actionable');
 });
 
 test('the mount() boot sequence actually calls loadBlockers(), in its place in the order', () => {

package/tests/home_attention_cards.mjs

@@ -16,6 +16,7 @@ const require = createRequire(import.meta.url);
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
 const lib = require(path.join(ROOT, 'modules', 'ui-design', 'kit', 'lib.js'));
 const GOAL_INBOX = fs.readFileSync(path.join(ROOT, 'modules', 'hall-ui', 'public', 'goal-inbox.js'), 'utf8');
+const HALL_ASK = fs.readFileSync(path.join(ROOT, 'modules', 'hall-ui', 'public', 'hall-ask.js'), 'utf8');
 
 let browser = null;
 try { browser = await lib.launchBrowser(); } catch (e) { if (!(e instanceof lib.NoBrowserError)) throw e; }
@@ -48,6 +49,7 @@ async function bootInbox() {
   const page = await ctx.newPage();
   await page.setContent(PAGE);
   await page.addScriptTag({ content: STUBS });
+  await page.addScriptTag({ content: HALL_ASK }); // task 1004820: the rows are OTBAsk cards
   await page.addScriptTag({ content: GOAL_INBOX });
   await page.evaluate(() => window.__widget.mount(document.getElementById('attention-scroll')));
   await page.waitForFunction(() => document.querySelectorAll('.attn-card').length === 2);

package/tests/rot_inbox.mjs

@@ -593,14 +593,14 @@ test('the slice lands in the EXISTING attention card — never a new Home card',
 });
 
 test('rot rows carry .ginbox__item, so the card\'s count-pill and visibility include them', () => {
-  assert.match(GOAL_INBOX_SRC, /function rotRowHtml[\s\S]*?class="ginbox__item"/,
+  assert.match(GOAL_INBOX_SRC, /function rotRowHtml[\s\S]*?cls: 'ginbox__item'/,
     'a rot row that does not carry the shared item class would be invisible to OTBAttention.refresh()');
 });
 
 test('the client renders SERVER-declared verbs rather than a hardcoded button list', () => {
   assert.match(GOAL_INBOX_SRC, /\(Array\.isArray\(r\.verbs\) \? r\.verbs : \[\]\)\.map/,
     'the buttons must come from the row\'s verbs array — a hardcoded list is a second copy of the tier→verb mapping');
-  assert.match(GOAL_INBOX_SRC, /data-rot-path=/, 'each button carries the server-declared path');
+  assert.match(GOAL_INBOX_SRC, /'data-rot-path':/, 'each button carries the server-declared path');
 });
 
 test('row builders emit the CSS classes style.css actually defines, not ginbox__main/ginbox__acts (task 1003284)', () => {
@@ -610,10 +610,10 @@ test('row builders emit the CSS classes style.css actually defines, not ginbox__
     '.ginbox__main is undefined in style.css — with it the row title and sub-line run together inline instead of stacking');
   assert.doesNotMatch(GOAL_INBOX_SRC, /ginbox__acts\b/,
     '.ginbox__acts is undefined in style.css — with it the action button loses its flex sizing');
-  assert.match(GOAL_INBOX_SRC, /function nodRowHtml[\s\S]*?class="ginbox__body"[\s\S]*?class="ginbox__actions"/,
-    'nodRowHtml must emit the defined ginbox__body/ginbox__actions classes');
-  assert.match(GOAL_INBOX_SRC, /function rotRowHtml[\s\S]*?class="ginbox__body"[\s\S]*?class="ginbox__actions"/,
-    'rotRowHtml must emit the defined ginbox__body/ginbox__actions classes');
+  // task 1004820: the nod and rot rows are the city's ask card, whose classes hall-ask.css defines
+  for (const fn of ['nodRowHtml', 'rotRowHtml']) {
+    assert.match(GOAL_INBOX_SRC, new RegExp(`function ${fn}[\\s\\S]*?OTBAsk\\.html\\(`), `${fn} draws the ask card`);
+  }
 });
 
 test('the nod, removal and rot lists use the defined .ginbox list class, not ginbox__list (task 1003982)', () => {
@@ -635,6 +635,9 @@ test('rotRowHtml escapes the row href like every sibling field (task 1003631)',
   const start = GOAL_INBOX_SRC.indexOf('function rotRowHtml');
   const body = GOAL_INBOX_SRC.slice(start, GOAL_INBOX_SRC.indexOf('\n  }\n', start));
   assert.ok(start > 0, 'rotRowHtml exists');
-  assert.match(body, /href="\$\{escapeHtml\(href\)\}"/, 'href goes through escapeHtml');
+  // task 1004820: the href is handed to OTBAsk, which escapes every attribute
+  assert.match(body, /qHref: href/, 'href is handed to OTBAsk');
+  const ask = require('../modules/hall-ui/public/hall-ask.js');
+  assert.match(ask.html({ q: 'x', qHref: '/t?a="<b>' }), /href="\/t\?a=&quot;&lt;b&gt;"/, 'OTBAsk escapes the href');
   assert.doesNotMatch(body, /href="\$\{href\}"/, 'no raw href interpolation');
 });