@bongos/core 1.21.170 → 1.21.171

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.21.170",
-  "core_contract": "1.21.170",
-  "source_commit": "dd8ede0d02e94bf42ebeecabda31e50d04207496",
+  "core_version": "1.21.171",
+  "core_contract": "1.21.171",
+  "source_commit": "418b7346b2799fc4dabcb37cdec6ee5e35bfe89d",
   "source_ref": "HEAD",
-  "built_at": "2026-10-23T17:21:55.040Z",
+  "built_at": "2026-10-23T17:36:25.226Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 609,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 3831,
-  "tree_sha256": "e66d52e5a8929945674ce60631b73e08c435660bf0228c776306ec586cc77464",
+  "tree_sha256": "5c91b3622476a3b85881740bd79ae9654ed7c2580f183150aa266e127b023ede",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2927,7 +2927,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "69e717f42c7d4a55a1c985e886807078c1cc320c4650993ad7ecd5aba27d3d2c"
+      "sha256": "681bd3bde29fddb39088d942d359acd61ebf692b57b2e1bdd46ab9317a25b80a"
     },
     {
       "path": "docs/modules-contract.md",
@@ -3017,7 +3017,7 @@
     {
       "path": "docs/page-readings.json",
       "mode": "0000644",
-      "sha256": "60976ab4a0fa35bcdc1dcb4c14ddcd1221f7a6f98bd31f79c9b8bc458edb8ba8"
+      "sha256": "57d09e6a2963858978e3028ddf8335d2712d1cad381264340fd51036cfade08c"
     },
     {
       "path": "docs/project-context.template.md",
@@ -5627,7 +5627,7 @@
     {
       "path": "modules/hall-ui/public/brand-apply.js",
       "mode": "0000644",
-      "sha256": "0bc95cee336ca3c2f5c6666fe944100f01232c51a9f4d595ebdb410f8c514ed3"
+      "sha256": "311edb9f328f02ee1d30a3711a149f9e168dd7d3b7a83ab4403250653ef8a8fe"
     },
     {
       "path": "modules/hall-ui/public/brand-holes.js",
@@ -6522,7 +6522,7 @@
     {
       "path": "modules/hall-ui/public/sky-data.js",
       "mode": "0000644",
-      "sha256": "7d509c43ab2d09f9b50ff588e86bab7ccdad7d28fafad023a13b1080cc745c37"
+      "sha256": "a92f2804b755a0d4b3a28d4fdb9f8bc50e274cf04c4627b220f34c84a45a08ed"
     },
     {
       "path": "modules/hall-ui/public/sky-draw.js",
@@ -6542,7 +6542,7 @@
     {
       "path": "modules/hall-ui/public/sky-panel.js",
       "mode": "0000644",
-      "sha256": "257ec3fa3c0010d93ccddcb29e2ff0f635e566cd79a978307adfc89169ecaafe"
+      "sha256": "a34bc56a1ebe3c65282f9f2e1d36b1102eda4cbf5fc26192239281aec0bf8f81"
     },
     {
       "path": "modules/hall-ui/public/sky-tour.js",
@@ -7807,7 +7807,7 @@
     {
       "path": "modules/lifecycle/sky.js",
       "mode": "0000644",
-      "sha256": "8945c7d22f8d0a4a094013dd1aa02791bdaf547467451fd0e827b87cb5a5d4ff"
+      "sha256": "98011414e3e393667766a499bc8a7ad3f145d2c42563dca9ff6f35b8c4da16a2"
     },
     {
       "path": "modules/lifecycle/task-classifier.js",
@@ -10602,12 +10602,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "612aedb1a80183da059e896d4a3325c4672d4159009eda6329159b0cc23d9c34"
+      "sha256": "829b2b61f5ea654c0e6b28e1a8afb189f1c0144277a36d1296a0d8adab46667b"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "9a75c884c3bbd879707469af51cac45699ae093714ed9a2176d6a95bfbb954e0"
+      "sha256": "ddc6efda55ff0a4c999375dd67b7018f906d14104d932d745d607d9b43df9ff4"
     },
     {
       "path": "public-docs/index.html",
@@ -10627,7 +10627,7 @@
     {
       "path": "release-notes.json",
       "mode": "0000644",
-      "sha256": "bc246f86279741c379c800cd01e417876b45cd7b73adf48d0bb8c7204517376e"
+      "sha256": "f91ffba352e1b52333a16db4f2468e2f32ae7372a14292175b66272f5731dbd2"
     },
     {
       "path": "scripts/cron/style_guide_audit.sh",
@@ -13017,7 +13017,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "1792868060800cda8dd8d8f8426cd070d7083a0d5ae74f1b0964e238ccf79e4d"
+      "sha256": "12e9bdeef58e00243274a7711fc7a93f21c838698dafeb8a3b7680a572271bfd"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -14917,7 +14917,7 @@
     {
       "path": "tests/goal_map_page.mjs",
       "mode": "0000644",
-      "sha256": "b5f49ea9a5adf0cc1909b45ebcf78b6c9806504a4194c90587c5a522b5839460"
+      "sha256": "aa83961201bf3ff0757330b16a799b4de407d0cc2522282f18712dbf624a84ea"
     },
     {
       "path": "tests/goal_member_kinds.mjs",
@@ -15732,7 +15732,7 @@
     {
       "path": "tests/hall_sky.mjs",
       "mode": "0000644",
-      "sha256": "9a7eaea562272b7e06e07ac4251ee15aa4aeaa24180bc711c2dae4dd8a56fd8f"
+      "sha256": "f798b71ce6f21026afc89bbca1e35fca06919d38f56eca1f8d8cfc75b3e9ac85"
     },
     {
       "path": "tests/hall_states_regex_escapes.mjs",
@@ -17887,7 +17887,7 @@
     {
       "path": "tests/reward_mode_surfacing.mjs",
       "mode": "0000644",
-      "sha256": "ed3538eb724a939eeb0619d3b61e5bf1b8ac4f389030fb4551c3045840018300"
+      "sha256": "9d8e28d50abfb2b0e339f7b934a1ae230812340739bcdc13e4550f7e99d8659b"
     },
     {
       "path": "tests/role_responsibilities.mjs",
@@ -18462,7 +18462,7 @@
     {
       "path": "tests/sky_read.mjs",
       "mode": "0000644",
-      "sha256": "b9dced9cf04d54a59de637c91533083ea6f16d0d93304b13f1d40473d23895fe"
+      "sha256": "238538864553803ed21a6330bf5a3570d1da8bd2f691af45b9eec1773a3bd8cd"
     },
     {
       "path": "tests/smoke_dependencies_witness.mjs",

package/docs/module-api-changelog.md

@@ -3177,5 +3177,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.21.168 with no explicit bump. run 39992064615. (task 1002620)
   1.21.170 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.21.169 with no explicit bump. run 39994339257. (task 1002620)
+  1.21.171 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.21.170 with no explicit bump. run 39996371081. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/docs/page-readings.json

@@ -50,7 +50,7 @@
       "surface": "builders",
       "title": "Blockers",
       "states_read": ["default"],
-      "files_hash": "be570fb08f33cde4",
+      "files_hash": "f5bf3c2244e3fbdd",
       "reading_hash": "2b3fd98b7ba1bff6",
       "counts": {"lines":28,"placed":12,"shared":8,"unplaced":8},
       "omitted": {"data":9},
@@ -1141,7 +1141,7 @@
       "surface": "builders",
       "title": "The sky",
       "states_read": ["tour","sky","wells","ledger","full","full-back","out"],
-      "files_hash": "2dce7dcbe58dcf5d",
+      "files_hash": "5f2c2f22c2fc9dc6",
       "reading_hash": "b83eb8c92a23fd3c",
       "counts": {"lines":47,"placed":23,"shared":7,"unplaced":17},
       "omitted": {"data":8},
@@ -1201,7 +1201,7 @@
       "surface": "builders",
       "title": "Goals",
       "states_read": ["list","filters","cards","detail","dependencies","out","uat","uat-panel","author"],
-      "files_hash": "ca38b540196d951b",
+      "files_hash": "4f6f4eb5e9f00412",
       "reading_hash": "7aa1a6e1946dc077",
       "counts": {"lines":156,"placed":52,"shared":8,"unplaced":96},
       "omitted": {"data":268},
@@ -1326,7 +1326,7 @@
         {"key":"L0117","section":"Goals","text":"Version","placement":"unplaced"},
         {"key":"L0118","section":"Goals","text":"— any —","placement":"placed","file":"modules/hall-ui/public/hall-widgets.js","line":173,"string_id":"729d4ce22b99","occurrences":2},
         {"key":"L0119","section":"Goals","text":"Status","placement":"unplaced"},
-        {"key":"L0120","section":"Goals","text":"open","placement":"placed","file":"modules/hall-ui/public/approval-queue.js","line":164,"string_id":"9a803563c948","occurrences":16},
+        {"key":"L0120","section":"Goals","text":"open","placement":"placed","file":"modules/hall-ui/public/approval-queue.js","line":166,"string_id":"9a803563c948","occurrences":16},
         {"key":"L0121","section":"Goals","text":"Sort","placement":"unplaced"},
         {"key":"L0122","section":"Goals","text":"priority (version order)","placement":"unplaced"},
         {"key":"L0123","section":"Goals","text":"newest first","placement":"unplaced"},
@@ -1439,7 +1439,7 @@
       "surface": "builders",
       "title": "Builders' Hall",
       "states_read": ["home","standing","standing-karma","out","founding","genesis","decide","demo"],
-      "files_hash": "eb1e8c3a4621add8",
+      "files_hash": "e32eb071e46bec38",
       "reading_hash": "42dbab4f3948fe66",
       "counts": {"lines":117,"placed":63,"shared":10,"unplaced":44},
       "omitted": {"data":101},
@@ -1569,7 +1569,7 @@
       "surface": "builders",
       "title": "Idea",
       "states_read": ["record","missing"],
-      "files_hash": "5b7084faad7f4ded",
+      "files_hash": "7456ea53572161d4",
       "reading_hash": "c9f9a84ab844c704",
       "counts": {"lines":52,"placed":23,"shared":9,"unplaced":20},
       "omitted": {"data":18},
@@ -1609,7 +1609,7 @@
         {"key":"L0032","section":"Everything that fell out of it","text":"{…} and {…}","placement":"placed","file":"modules/hall-ui/public/profile-nudge.js","line":77,"string_id":"56b00d773232","state":"missing"},
         {"key":"L0033","section":"footer","text":"Sign out","placement":"shared","file":"modules/hall-ui/public/shell.js","line":520,"string_id":"1883ad7f07fc","state":"missing","occurrences":2},
         {"key":"L0034","section":"Everything that fell out of it","text":"Builders hall · this session","placement":"placed","file":"modules/hall-ui/public/craft-mode.js","line":674,"string_id":"fd1903586e8e","state":"missing"},
-        {"key":"L0035","section":"12A changelog every builder can read","text":"open","placement":"placed","file":"modules/hall-ui/public/approval-queue.js","line":164,"string_id":"9a803563c948"},
+        {"key":"L0035","section":"12A changelog every builder can read","text":"open","placement":"placed","file":"modules/hall-ui/public/approval-queue.js","line":166,"string_id":"9a803563c948"},
         {"key":"L0036","section":"12A changelog every builder can read","text":"had the thought · {…}","placement":"unplaced"},
         {"key":"L0037","section":"12A changelog every builder can read","text":"{…}/100 complete","placement":"placed","file":"modules/hall-ui/public/idea.js","line":87,"string_id":"c43050b62297"},
         {"key":"L0038","section":"12A changelog every builder can read","text":"{…} and {…}","placement":"placed","file":"modules/hall-ui/public/profile-nudge.js","line":77,"string_id":"56b00d773232","occurrences":4},
@@ -1719,7 +1719,7 @@
       "surface": "builders",
       "title": "Modules",
       "states_read": ["browse","search-empty","lens","details","out"],
-      "files_hash": "ce529d9f575606e5",
+      "files_hash": "6dc5460706966349",
       "reading_hash": "a17f501b72321b7b",
       "counts": {"lines":62,"placed":29,"shared":8,"unplaced":25},
       "omitted": {"data":106},
@@ -2325,7 +2325,7 @@
       "surface": "builders",
       "title": "Profile",
       "states_read": ["own","works","activity","activity-artist","activity-ideator","other","artist","ideator","out"],
-      "files_hash": "deca408267a32df9",
+      "files_hash": "82a35b34a5115325",
       "reading_hash": "8088d60a4e93bb91",
       "counts": {"lines":196,"placed":70,"shared":8,"unplaced":118},
       "omitted": {"data":197},
@@ -2721,7 +2721,7 @@
       "surface": "builders",
       "title": "Builders",
       "states_read": ["roster","artists","search","out"],
-      "files_hash": "38086c3c20a8cd6d",
+      "files_hash": "88e2f7aca1994346",
       "reading_hash": "5c7e507e9600e59c",
       "counts": {"lines":47,"placed":13,"shared":8,"unplaced":26},
       "omitted": {"data":60},
@@ -2781,7 +2781,7 @@
       "surface": "builders",
       "title": "Sessions",
       "states_read": ["ledger","out"],
-      "files_hash": "b5f59d12801a60d9",
+      "files_hash": "cd14ebd4d35e16bf",
       "reading_hash": "5c18aaed7f2e8e0f",
       "counts": {"lines":331,"placed":21,"shared":8,"unplaced":302},
       "omitted": {"data":303},
@@ -4021,7 +4021,7 @@
       "surface": "builders",
       "title": "Task",
       "states_read": ["record","from-goal","missing"],
-      "files_hash": "8200eeef7a793659",
+      "files_hash": "5535b9790b56985e",
       "reading_hash": "3e80d092af1d7e2c",
       "counts": {"lines":132,"placed":35,"shared":10,"unplaced":87},
       "omitted": {"data":75},
@@ -4166,7 +4166,7 @@
       "surface": "builders",
       "title": "Your thinking",
       "states_read": ["tour","sky","list","simple","full-idea","full","full-list","full-back","out"],
-      "files_hash": "f8061c0641b23730",
+      "files_hash": "a7b04635b758d676",
       "reading_hash": "532805c03c3a8a4c",
       "counts": {"lines":48,"placed":23,"shared":7,"unplaced":18},
       "omitted": {"data":8},
@@ -4263,7 +4263,7 @@
       "surface": "builders",
       "title": "Watch",
       "states_read": ["board","out","operations","security"],
-      "files_hash": "c3baec6343c9867a",
+      "files_hash": "3980ad82a03bc297",
       "reading_hash": "d698ac62c904aa65",
       "counts": {"lines":88,"placed":38,"shared":8,"unplaced":42},
       "omitted": {"data":166},
@@ -4364,7 +4364,7 @@
       "surface": "builders",
       "title": "Tasks",
       "states_read": ["ready","in-progress","backlog","completed","filters-open","out","founding"],
-      "files_hash": "2c4ec39162b32427",
+      "files_hash": "1dcb08711f496752",
       "reading_hash": "a425c7a090d8bf03",
       "counts": {"lines":125,"placed":54,"shared":8,"unplaced":63},
       "omitted": {"data":316},

package/modules/hall-ui/public/brand-apply.js

@@ -91,7 +91,7 @@
   // estimate with a "<Currency> Est." label; settled → the actual ledger payout
   // with a plain "<Currency>" label.
   //
-  // task 1002469 — on a cost-plus-only instance that second case is a LIE. The
+  // task 1002469 (superseded by task 1004781) — on a cost-plus-only instance that second case was a LIE. The
   // per-task estimate is never paid, so credits_awarded is 0 on every shipped
   // task, taskCreditValue's zero-fallback hands back the estimate, and the plain
   // label then presents that estimate as the actual payout. So the "Est."
@@ -105,18 +105,25 @@
   function taskCreditValue(task) {
     if (!task) return null;
     if (task.status === 'abandoned' || task.merged_into_task_id != null) return 0;
+    // task 1004781 — a settled task is worth what the ledger PAID for it and
+    // nothing else. It used to fall back to the estimate when the ledger held
+    // 0, and on a cost-plus-only instance that is every shipped task, so goal
+    // totals summed guesses as money (a goal read 3,373 for a builder paid
+    // 776). A settled 0 is the truth: the task itself paid nothing. Only
+    // unsettled work carries the estimate, and taskCreditLabel marks it "Est.".
+    // The decision the task asked for: estimates are KEPT, for live work only —
+    // they still rank claimable work (task-lib's best-value sort) and tell a
+    // builder roughly how big a task is — but they never reach a total.
     if (taskSettled(task)) {
       var awarded = Number(task.credits_awarded);
-      // Settled with a real ledger payout → show it. If a settled task has no
-      // ledger record (0 — legacy pre-ledger tasks, or reward-exempt), fall back
-      // to the estimate rather than showing a misleading "0".
-      if (isFinite(awarded) && awarded > 0) return awarded;
+      return isFinite(awarded) && awarded > 0 ? awarded : 0;
     }
     return task.credits_reward;
   }
   function taskCreditLabel(task, opts) {
+    // A settled figure is now always the actual payout (see taskCreditValue),
+    // so it takes the plain label on every reward mode; only an estimate is "Est.".
     var base = currencyLabel(opts);
-    if (!perTaskCredit()) return base + ' Est.';
     return taskSettled(task) ? base : base + ' Est.';
   }
 

package/modules/hall-ui/public/sky-data.js

@@ -142,15 +142,16 @@
   // The prototype read a snapshot (docs/design/mocks/sky/snapshot.js). Each
   // adaptor maps one real read onto the same field names, so the world below
   // is the prototype's world line for line.
+  const SETTLED = new Set(['confirmed', 'shipped']);
   function goalFromSky(g) {
     return {
       id: String(g.goal_id), title: g.title || 'A private goal', subtitle: g.subtitle || null, version: g.version_id, status: g.status,
       taskTotal: Number(g.task_total) || 0, taskDone: Number(g.task_done) || 0, createdAt: g.created_at || null,
       crit: (g.criteria || []).map((c) => ({ id: String(c.id), text: c.criterion_md || '', satisfied: c.satisfied === true, tasks: (c.task_ids || []).map(String), pendingReview: c.pending_review === true, uat: c.uat_state || null, uatLabel: uatLabel(c.uat_state), backendOnly: c.backend_only === true })),
-      // task 1004782 — abandoned (or merged-away) work carries no credits: it is listed, at zero, and never adds to a
-      // well's mass or a ring. A merged-away task is always abandoned (tasks.merged_into_task_id is CHECK-constrained to
-      // abandoned rows), so the status test covers both; /sky does not send the pointer.
-      tasks: (g.tasks || []).map((t) => ({ id: String(t.id), title: t.title || 'a task', status: t.status, credits: t.status === 'abandoned' || t.credits_reward == null ? 0 : Number(t.credits_reward), createdAt: t.created_on || null, sourceRef: t.idea_id != null ? String(t.idea_id) : null })),
+      // `credits` is what the ledger PAID — settled work only (task 1004781) — so a well's mass and a ring's weight are
+      // money paid. Live work carries its guess as `estimate`, shown "Est." and never added to a total. Abandoned (or
+      // merged-away, which is always abandoned — CHECK-constrained) work has neither (task 1004782).
+      tasks: (g.tasks || []).map((t) => ({ id: String(t.id), title: t.title || 'a task', status: t.status, credits: SETTLED.has(t.status) ? Number(t.credits_awarded) || 0 : 0, estimate: SETTLED.has(t.status) || t.status === 'abandoned' || t.credits_reward == null ? null : Number(t.credits_reward), createdAt: t.created_on || null, sourceRef: t.idea_id != null ? String(t.idea_id) : null })),
     };
   }
   const taskRow = (t) => ({ id: String(t.task_id ?? t.id), title: t.title || 'a task', status: t.status, goalId: t.goal_id != null ? String(t.goal_id) : null, origin: t.origin || null });

package/modules/hall-ui/public/sky-panel.js

@@ -98,7 +98,7 @@
       <div class="facts">
         ${g ? fact('well', esc(g.title)) : ''}
         ${crit ? fact('gates the ring', esc(plain(crit.text).slice(0, 90))) : g ? fact('gates the ring', 'none — outer orbit') : ''}
-        ${t.credits != null ? fact('credits', String(t.credits), true) : ''}
+        ${t.estimate != null ? fact('credits', `${t.estimate} <span class="lbl">Est.</span>`, true) : t.credits != null ? fact('credits paid', String(t.credits), true) : ''}
         ${t.createdAt ? fact('born', esc(t.createdAt)) : ''}
         ${t.sourceRef ? fact('born of a thought', `<a href="${HALL}/idea/${esc(t.sourceRef)}" target="_blank" rel="noopener">${esc(ideaTitle(t.sourceRef))}</a>`) : ''}
       </div>

package/modules/lifecycle/sky.js

@@ -44,6 +44,7 @@ const goalGraph = require('./goal-graph');
 const goalCategory = require('./goal-category');
 const { isPendingReview, uatState, uatReadColumnsSql } = require('./done-when');
 const { TERMINAL_STATUSES } = require('./task-status');
+const { CREDITS_AWARDED_SUBQUERY } = require('./db-tasks');
 
 const SKY_CACHE_TTL_MS = 60 * 1000;
 
@@ -92,9 +93,12 @@ async function skyRows({ versionId = null, viewerId = null, viewerIsArchon = fal
       // Compact by construction: no description, no value summary, no notes.
       // created_at is truncated to the DAY in SQL so the payload carries ten
       // characters per task, not twenty-seven, and the clock draws by day anyway.
+      // credits_awarded (task 1004781) is the shared settled-only payout subquery; its
+      // per-row lookup rides idx_credit_log_task (core_189), never a scan of the log.
       `SELECT t.id::text AS id, t.goal_id::text AS goal_id, t.title, t.status,
               t.credits_reward, t.created_at::date::text AS created_on,
-              CASE WHEN t.source_ref ~ '^idea:[0-9]+$' THEN substring(t.source_ref from 6) END AS idea_id
+              CASE WHEN t.source_ref ~ '^idea:[0-9]+$' THEN substring(t.source_ref from 6) END AS idea_id,
+              ${CREDITS_AWARDED_SUBQUERY} AS credits_awarded
          FROM tasks t
          JOIN goals g ON g.id = t.goal_id
         WHERE ($1::text IS NULL OR g.version_id = $1)
@@ -189,6 +193,9 @@ function shapeSky({ goals = [], edges = [], extras = [], criteria = [], tasks =
       title: visible ? t.title : null,
       status: t.status,
       credits_reward: t.credits_reward == null ? null : Number(t.credits_reward),
+      // task 1004781 — what the ledger actually paid (0 until settled), so the
+      // sky sizes a well by money paid, never by the estimate.
+      credits_awarded: t.credits_awarded == null ? 0 : Number(t.credits_awarded),
       created_on: t.created_on || null,
       idea_id: t.idea_id != null ? String(t.idea_id) : null,
     });

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.170",
+  "version": "1.21.171",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.21.170",
+      "version": "1.21.171",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.170",
+  "version": "1.21.171",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -10094,5 +10094,11 @@
       "id": "1003806",
       "text": "When a new module version is being tested, how it went for the testing projects now counts toward its quality score — and a handful of friendly testers can no longer outscore hundreds of real ones."
     }
+  ],
+  "1.21.171": [
+    {
+      "id": "1004781",
+      "text": "Credit figures in the hall now show money that was actually paid. A finished task shows its real payout instead of the old guess, so goal totals, member stats and the goal map stop adding up estimates as if they were earnings."
+    }
   ]
 }

package/src/module-api.js

@@ -75,7 +75,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.21.170'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.21.171'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/goal_map_page.mjs

@@ -60,14 +60,14 @@ function well(over = {}) {
       { id: '71', criterion_id: 'c2', criterion_md: 'The second ring is open', satisfied: false, pending_review: false, task_ids: ['501', '502'] },
     ],
     tasks: [
-      { id: '500', title: 'The task', status: 'shipped', credits_reward: 60, created_on: '2026-07-01', idea_id: '10' },
+      { id: '500', title: 'The task', status: 'shipped', credits_reward: 60, credits_awarded: 60, created_on: '2026-07-01', idea_id: '10' },
       { id: '501', title: 'A held task', status: 'active', credits_reward: 40, created_on: '2026-08-01', idea_id: null },
       { id: '502', title: 'A claimable task', status: 'ready', credits_reward: 30, created_on: '2026-08-02', idea_id: null },
     ],
     ...over,
   };
 }
-const tasksOf = (prefix, n, status, created = '2026-05-01') => Array.from({ length: n }, (_, i) => ({ id: `${prefix}${i}`, title: `task ${prefix}${i}`, status, credits_reward: 20, created_on: created, idea_id: null }));
+const tasksOf = (prefix, n, status, created = '2026-05-01') => Array.from({ length: n }, (_, i) => ({ id: `${prefix}${i}`, title: `task ${prefix}${i}`, status, credits_reward: 20, credits_awarded: status === 'shipped' ? 20 : 0, created_on: created, idea_id: null }));
 // A quiet well: nothing held, nothing landed this week.
 const quiet = (over = {}) => well({ goal_id: '9', title: 'A quiet well — nothing moves', task_total: 4, task_done: 4, criteria: [], tasks: tasksOf('9-', 4, 'shipped'), ...over });
 const settled = (over = {}) => well({ goal_id: '8', title: 'A settled system — it finished', status: 'achieved', task_total: 3, task_done: 3, tasks: tasksOf('8-', 3, 'shipped'), created_at: '2026-03-01T00:00:00.000Z', ...over });
@@ -142,7 +142,7 @@ await test('a goal is a well sized by its credits; settled and collapsed goals k
   assert.equal(o.mass, 60);
   assert.ok(Math.abs(a.r - o.r * 0.8) < 1e-9, 'a settled system is 0.8× the well it would have been');
   assert.ok(Math.abs(c.r - o.r * 0.5) < 1e-9, 'a collapsed goal is half');
-  const big = await boot({ sky: sky([well(same({ goal_id: '1' })), well({ ...same({ goal_id: '4' }), tasks: tasksOf('4-', 3, 'shipped').map((t) => ({ ...t, credits_reward: 400 })) })]) });
+  const big = await boot({ sky: sky([well(same({ goal_id: '1' })), well({ ...same({ goal_id: '4' }), tasks: tasksOf('4-', 3, 'shipped').map((t) => ({ ...t, credits_reward: 400, credits_awarded: 400 })) })]) });
   assert.ok(goal(big, '4').r > goal(big, '1').r, 'more credits, a bigger well');
 });
 
@@ -227,7 +227,7 @@ await test('EXPLORE IS ON BY DEFAULT: the sky asks where you begin, and the ledg
   assert.equal(p.el('start').hidden, false, '"where do you begin" is up');
   const opts = p.el('startOpts').querySelectorAll('button');
   assert.equal(opts[0].textContent, 'where my thoughts are');
-  assert.deepEqual(opts.slice(1, -1).map((b) => b.dataset.start), ['7', '9'], 'one door per open well, biggest first');
+  assert.deepEqual(opts.slice(1, -1).map((b) => b.dataset.start), ['9', '7'], 'one door per open well, biggest first (task 1004781: 7 weighs only the 60 it paid now)');
   assert.equal(opts.at(-1).textContent, 'show me everything');
   assert.equal(SKY.seen(goal(p, '7')), false, 'nothing is reached yet');
   p.key('l');
@@ -283,7 +283,7 @@ await test('THE LEDGER IS THE ACCESSIBLE PATH: every goal is a row, both directi
     assert.ok(rows.includes(SKY.esc(g.title)), `${g.title} is named whole`);
   }
   const rowOf = (id) => (new RegExp(`data-id="${id}"[\\s\\S]*?</button>`).exec(rows) || [''])[0];
-  assert.match(rowOf('7'), /alive · 1\/3 tasks · 130 cr · 1\/2 rings · waits on 1/, 'the waiting goal (alive: a task is held) counts what it waits on');
+  assert.match(rowOf('7'), /alive · 1\/3 tasks · 60 cr · 1\/2 rings · waits on 1/, 'the waiting goal (alive: a task is held) counts what it waits on');
   assert.match(rowOf('9'), /waited on by 1/, 'the goal waited on counts it the other way');
   assert.match(rowOf('8'), /settled/); assert.match(rowOf('6'), /collapsed/);
   const filters = p.el('filters').querySelectorAll('button').map((b) => [b.dataset.f, b.textContent.replace(/\s*\d+$/, '').trim()]);

package/tests/hall_sky.mjs

@@ -92,7 +92,7 @@ function well(over = {}) {
       { id: '71', criterion_id: 'c2', criterion_md: 'The second ring is open', satisfied: false, pending_review: false, task_ids: ['501', '502'] },
     ],
     tasks: [
-      { id: '500', title: 'The task', status: 'shipped', credits_reward: 60, created_on: '2026-07-01', idea_id: '10' },
+      { id: '500', title: 'The task', status: 'shipped', credits_reward: 60, credits_awarded: 6, created_on: '2026-07-01', idea_id: '10' },
       { id: '501', title: 'A held task', status: 'active', credits_reward: 40, created_on: '2026-08-01', idea_id: null },
       { id: '502', title: 'A claimable task', status: 'ready', credits_reward: 30, created_on: '2026-08-02', idea_id: null },
     ],
@@ -211,7 +211,18 @@ await test('the rings are the criteria, closing as each is satisfied and thick w
   const g = p.S().goalById.get('7');
   assert.equal(g.crit.length, 2);
   same(g.crit.map((c) => c.satisfied), [true, false]);
-  same(g.crit.map((c) => c.credits), [60, 70], 'a ring\'s credits are the credits of the tasks on it');
+  // task 1004781 — a ring weighs what its tasks were PAID: the shipped task paid 6 (its 60 was a guess), and
+  // the held and claimable tasks have paid nothing yet, so their estimates stay off the ring.
+  same(g.crit.map((c) => c.credits), [6, 0], 'a ring\'s credits are what the tasks on it were paid');
+  assert.equal(g.tasks.find((t) => t.id === '500').estimate, null, 'a settled task carries no estimate');
+  assert.equal(g.tasks.find((t) => t.id === '501').estimate, 40, 'live work keeps its estimate, apart from the total');
+  const SKY = p.SKY();
+  SKY.pick({ kind: 'task', ref: g.tasks.find((t) => t.id === '501') }, false);
+  assert.match(p.panel(), /40 <span class="lbl">Est\.<\/span>/, 'the panel labels a live task\'s figure as an estimate');
+  assert.doesNotMatch(p.panel(), /credits paid/);
+  SKY.pick({ kind: 'task', ref: g.tasks.find((t) => t.id === '500') }, false);
+  assert.match(p.panel(), /credits paid[\s\S]*?6/, 'and a settled task\'s as what it was paid');
+  assert.doesNotMatch(p.panel(), /Est\./);
   assert.equal(g.tasks.find((t) => t.id === '500').ci, 0, 'a task knows which ring it gates');
   assert.equal(g.tasks.find((t) => t.id === '500').sourceRef, '10', 'and which thought it was born of');
 });
@@ -230,8 +241,9 @@ await test('abandoned work is listed at zero and adds nothing to a well or its r
   const g = p.S().goalById.get('7');
   assert.equal(g.tasks.find((t) => t.id === '503').credits, 0, 'still listed, at zero');
   assert.equal(g.tasks.find((t) => t.id === '504').credits, 0, 'a merged-away task is listed at zero too');
-  assert.equal(g.credits, 130, 'the well\'s mass is the live work only (60 + 40 + 30)');
-  same(g.crit.map((c) => c.credits), [60, 70], 'and the ring it sat on is not thickened by it');
+  assert.equal(g.credits, 6, 'the well\'s mass is what was paid only');
+  same(g.crit.map((c) => c.credits), [6, 0], 'and the ring it sat on is not thickened by it');
+  assert.equal(g.tasks.find((t) => t.id === '503').estimate, null, 'abandoned work carries no estimate either');
 });
 
 await test('a private goal keeps its structure and none of its prose', async () => {

package/tests/reward_mode_surfacing.mjs

@@ -136,14 +136,27 @@ function loadBrandApply(rewardBlock) {
 const SHIPPED_TASK = { status: 'shipped', credits_awarded: 0, credits_reward: 60 };
 const READY_TASK = { status: 'ready', credits_reward: 60 };
 
-test('hall: cost-plus-only keeps "Est." on a SHIPPED task (the 60 is not a payout)', () => {
+// task 1004781 — a settled task shows what it was PAID, never its estimate:
+// the 60 is not a payout, so a shipped task with nothing in the ledger is 0,
+// and that 0 is an actual figure (plain label). Only live work is "Est.".
+test('hall: cost-plus-only shows a SHIPPED task as what it paid (0), not the 60 estimate', () => {
   const B = loadBrandApply(CPO);
-  assert.equal(B.taskCreditLabel(SHIPPED_TASK), 'credits Est.',
-    'dropping "Est." presents the unpaid estimate as the real payout');
+  assert.equal(B.taskCreditValue(SHIPPED_TASK), 0, 'the estimate must never stand in for a payout');
+  assert.equal(B.taskCreditLabel(SHIPPED_TASK), 'credits');
+  assert.equal(B.taskCreditValue({ ...SHIPPED_TASK, credits_awarded: 7 }), 7, 'a real payout shows as itself');
+  assert.equal(B.taskCreditValue(READY_TASK), 60, 'live work keeps its estimate');
   assert.equal(B.taskCreditLabel(READY_TASK), 'credits Est.');
   assert.equal(B.perTaskCredit(), false);
 });
 
+test('hall: a settled task never falls back to its estimate, on any reward mode', () => {
+  for (const mode of [CPO, PAYS, undefined]) {
+    const B = loadBrandApply(mode);
+    assert.equal(B.taskCreditValue(SHIPPED_TASK), 0);
+    assert.equal(B.taskCreditValue({ status: 'confirmed', credits_reward: 30 }), 0, 'no ledger figure ⇒ 0');
+  }
+});
+
 test('hall: a PAYING instance keeps the original settled/unsettled split', () => {
   const B = loadBrandApply(PAYS);
   assert.equal(B.taskCreditLabel(SHIPPED_TASK), 'credits', 'settled ⇒ plain label, unchanged');

package/tests/sky_read.mjs

@@ -56,14 +56,14 @@ await test('the shape: wells carry their criteria and their compact tasks; edges
   assert.equal(w1.created_at, '2026-09-01T00:00:00.000Z');
   // task 1004402: each ring also carries its UAT state + backend-only flag (ADR 0351).
   assert.deepEqual(w1.criteria, [{ id: '10', criterion_id: 'slug-10', criterion_md: 'Criterion 10', satisfied: false, backend_only: false, task_ids: ['100', '101'], pending_review: false, uat_state: 'open' }]);
-  assert.deepEqual(w1.tasks[0], { id: '100', title: 'Task 100', status: 'shipped', credits_reward: 30, created_on: '2026-09-02', idea_id: '555' });
+  assert.deepEqual(w1.tasks[0], { id: '100', title: 'Task 100', status: 'shipped', credits_reward: 30, credits_awarded: 0, created_on: '2026-09-02', idea_id: '555' });
   assert.equal(w1.tasks[1].idea_id, null, 'a task not born of an idea carries null, not an empty string');
   assert.deepEqual(out.goals[1].criteria[0].task_ids, [], 'a criterion with no linked task is an empty ring, not a missing one');
 });
 
 await test('nothing but the compact fields rides on a task — no description, no value summary, no notes', () => {
   const out = shapeSky({ goals: [g(1)], extras: [x(1)], tasks: [t(1, 1, { description: 'long prose', value_summary: 'more prose', notes: 'and more' })] });
-  assert.deepEqual(Object.keys(out.goals[0].tasks[0]).sort(), ['created_on', 'credits_reward', 'id', 'idea_id', 'status', 'title']);
+  assert.deepEqual(Object.keys(out.goals[0].tasks[0]).sort(), ['created_on', 'credits_awarded', 'credits_reward', 'id', 'idea_id', 'status', 'title']);
 });
 
 await test('a ring or a task under a goal that is not a well is dropped, not drawn to nowhere', () => {
@@ -177,6 +177,17 @@ await test('the criterion→task join is read ONCE for every goal-bearing criter
   assert.match(crit[0].sql, /LEFT JOIN tasks t\s+ON t\.id = tc\.task_id/, 'a criterion with no task still arrives (the rollup\'s LEFT JOIN)');
 });
 
+// task 1004781 — the sky sizes wells by what the ledger PAID, so the read
+// carries the payout (the shared subquery, settled-only) beside the estimate.
+await test('a task carries what the ledger paid for it, from the shared payout subquery', async () => {
+  const out = shapeSky({ goals: [g(1)], extras: [x(1)], tasks: [t(100, 1, { status: 'shipped', credits_awarded: '7' })] });
+  assert.equal(out.goals[0].tasks[0].credits_awarded, 7);
+  const pool = fakePool();
+  await skyRows({}, { pool });
+  const tq = pool.calls.find((c) => /FROM tasks t\s+JOIN goals g/.test(c.sql));
+  assert.match(tq.sql, /FROM credit_log cl[\s\S]*AS credits_awarded/);
+});
+
 await test('the task query is compact by construction: no description, no value_summary, and the date is truncated in SQL', async () => {
   const pool = fakePool();
   await skyRows({}, { pool });