@bongos/core 1.21.168 → 1.21.170

package/docs/copy-registry.json

@@ -3,9 +3,9 @@
   "generator": "scripts/gds/copy-inventory.js",
   "goal": 1000074,
   "counts": {
-    "strings": 2791,
-    "unique_ids": 2372,
-    "certain": 2791,
+    "strings": 2793,
+    "unique_ids": 2374,
+    "certain": 2793,
     "heuristic": 0,
     "duplicate_ids": 243
   },
@@ -13,7 +13,7 @@
     "builders-hall": {
       "at": "modules/hall-ui/public",
       "files": 150,
-      "strings": 1971
+      "strings": 1973
     },
     "status-dashboard": {
       "at": "modules/status-ui/public",
@@ -2260,8 +2260,8 @@
       "text": "highlighted: the words you changed",
       "occurrences": 2,
       "at": [
-        "modules/hall-ui/public/approval-queue.js:170",
-        "modules/hall-ui/public/approval-queue.js:183"
+        "modules/hall-ui/public/approval-queue.js:171",
+        "modules/hall-ui/public/approval-queue.js:184"
       ]
     },
     {
@@ -9437,7 +9437,7 @@
       "surface": "builders-hall",
       "text": "No render is attached to this page yet. /tweak attaches them when it applies a page; until then there is nothing to approve from, so send it back or wait.",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 135,
+      "line": 136,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9590,7 +9590,7 @@
       "surface": "builders-hall",
       "text": "No {…} render is attached to this page.",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 134,
+      "line": 135,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9608,7 +9608,7 @@
       "surface": "builders-hall",
       "text": "No {…} {…} render; showing {…} {…}.",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 139,
+      "line": 140,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10229,7 +10229,7 @@
       "surface": "builders-hall",
       "text": "Only the artist who wrote this page, or another artist, can approve it or send it back.",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 170,
+      "line": 171,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10499,7 +10499,7 @@
       "surface": "builders-hall",
       "text": "Opening the rendered page…",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 129,
+      "line": 130,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -13131,6 +13131,24 @@
       "origin": "html-title",
       "confidence": "certain"
     },
+    {
+      "id": "30b78bc382a1",
+      "surface": "builders-hall",
+      "text": "Submitted, not applied yet",
+      "file": "modules/hall-ui/public/approval-queue.js",
+      "line": 193,
+      "origin": "js-markup",
+      "confidence": "certain"
+    },
+    {
+      "id": "7d56be90cd16",
+      "surface": "builders-hall",
+      "text": "Submitted, not applied yet ({…})",
+      "file": "modules/hall-ui/public/approval-queue.js",
+      "line": 193,
+      "origin": "js-markup",
+      "confidence": "certain"
+    },
     {
       "id": "f79e1fb8ebd4",
       "surface": "builders-hall",
@@ -13802,7 +13820,7 @@
       "surface": "builders-hall",
       "text": "The hero line is too long on a phone.",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 176,
+      "line": 177,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -13973,7 +13991,7 @@
       "surface": "builders-hall",
       "text": "The page, rendered",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 200,
+      "line": 215,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -14054,7 +14072,7 @@
       "surface": "builders-hall",
       "text": "The renders could not be read just now. Close the queue and open it again.",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 130,
+      "line": 131,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -14405,7 +14423,7 @@
       "surface": "builders-hall",
       "text": "The words you changed",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 200,
+      "line": 215,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -14801,7 +14819,7 @@
       "surface": "builders-hall",
       "text": "This round changed no lines.",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 149,
+      "line": 150,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -15575,7 +15593,7 @@
       "surface": "builders-hall",
       "text": "What needs changing",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 176,
+      "line": 177,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -16763,7 +16781,7 @@
       "surface": "builders-hall",
       "text": "approval queue",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 194,
+      "line": 208,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -16772,7 +16790,7 @@
       "surface": "builders-hall",
       "text": "approve and ship",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 174,
+      "line": 175,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -17348,7 +17366,7 @@
       "surface": "builders-hall",
       "text": "highlighted: the words you changed",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 170,
+      "line": 171,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -17357,7 +17375,7 @@
       "surface": "builders-hall",
       "text": "highlighted: the words you changed",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 183,
+      "line": 184,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -18005,7 +18023,7 @@
       "surface": "builders-hall",
       "text": "open {…}",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 165,
+      "line": 166,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -18275,7 +18293,7 @@
       "surface": "builders-hall",
       "text": "send it back",
       "file": "modules/hall-ui/public/approval-queue.js",
-      "line": 181,
+      "line": 182,
       "origin": "js-markup",
       "confidence": "certain"
     },

package/docs/module-api-changelog.md

@@ -3173,5 +3173,9 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.21.166 with no explicit bump. run 39986992124. (task 1002620)
   1.21.168 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.21.167 with no explicit bump. run 39990468332. (task 1002620)
+  1.21.169 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.21.168 with no explicit bump. run 39992064615. (task 1002620)
+  1.21.170 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.21.169 with no explicit bump. run 39994339257. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/docs/modules-contract.md

@@ -394,6 +394,7 @@ Run `bongos upgrade` to confirm coreVersion compatibility, then `node scripts/gd
 - Gate: Metic+ (`module.submit`) for now. This is not `bongos module submit`, which proposes a module *into* core.
 - **A how-to is required** ([ADR 0347](adr/0347-every-store-module-ships-a-how-to.md)). `modules/<key>/HOWTO.md` is what a buyer reads — the store shows it as the module's page — so it is written for the person who installs the module, not for an AI working inside it (that is `CLAUDE.md`). It is plain Markdown: any AI or person can write it. Publish refuses the version unless it has these five level-2 headings, in any order and any case, each with some text under it: `## What it does`, `## Install and enable`, `## How to use it` (with one worked example), `## Configuration` ("None." is fine) and `## Limits and known issues` ("None known." is fine). HTML comments don't count as text, so the scaffold's prompts must be replaced. The refusal names each failing section. The check is one function, `checkHowto` in `scripts/gds/module-artifact.js`; the CLI runs it before uploading and the store runs it again on upload, so a hand-built upload can't skip it. `bongos module check` reports it as advice only — an upstream submit is not gated by it. Install and update don't re-check it, so a version published before the gate still installs. The file travels in the tarball, so its hash pins it to the version. An optional `howto.artifactUrl` in `module.json` (an `https://` link on `claude.ai`) is shown as an extra, never graded.
 - **Getting listed** (task 1003807, [ADR 0343](adr/0343-a-module-score-is-a-security-gate-then-an-average-of-visible-parts.md)). Publishing a version does not by itself put it in the store's catalog, `GET /store/modules`. The catalog shows each module's newest version, judged by its current score. It must pass the Security gate first; a version that failed it, or has not been checked yet, is not listed. A new version with no install or reliability data yet is listed with a **New** label and is not ranked; the floor does not apply to it until it has a real score. Every other version is listed only if its overall score is **at least 50 out of 100**. Below that it is not listed at all. The floor is fixed in Bongos itself (`QUALITY_FLOOR` in `src/bongos/module-listing.js`) and returned in the catalog response; no author or instance setting moves it, and changing it is an owner-approved, reviewed task.
+- **Tester feedback** (task 1003806, ADR 0344 D5). While a version is on the tester channel, what tester projects report about it becomes its Tester feedback part: the share of testers whose install worked and who hit no runtime errors, blended with ten neutral testers so a small sample cannot score high — `round(100 × (went well + 5) / (testers + 10))`. Reports from after the version left the tester channel, and the author's own, never count; under 3 testers it is not scored yet. The rule is `assessTesterFeedback` in `scripts/gds/module-assess-installs.js`.
 - **What a module is strong and weak at** (task 1003799, ADR 0343 D4). Each catalog entry also carries `parts` (the current result of Tests, Clean installs, Reliability, Tester feedback and How-to) and a reading of them: `strengths` (a part scored **80 or more**), `weaknesses` (a part scored **below the floor**) and `unmeasured` (a part with no score yet, which is never counted as weak). Each strength and weakness has a one-sentence `detail` saying what the number rests on. Security is not among them: every listed version has passed it. The reading is `readParts` in `src/bongos/module-listing.js`; the hall's Modules tab shows it in its "In the store" group, so two modules with the same overall score can be told apart.
 - **Sorting by a part** (task 1003800). `GET /store/modules?sort=<part>` orders the listed modules by one part a buyer cares about: `tests`, `install`, `reliability`, `tester_feedback` or `docs` (the response lists them as `sort_parts`, and says which one it applied as `sort`). Modules with a score for that part come first, highest first; a tie goes to the higher overall score, then the module key. A module with no score for that part goes last, so missing data never wins or loses a place on its own. New modules are not sorted: they are never ranked. Any other `sort` value is refused with a 400. Without `sort`, both lists are in key order. The rule is `sortByPart` in `src/bongos/module-listing.js`.
 - **Testing new versions first** (task 1003802, [ADR 0344](adr/0344-a-tester-is-a-project-that-opts-in-once.md) D1). A project can choose to get each new version of its modules before everyone else. It is the project that opts in, never one builder for someone else's project, and never by default. `GET /modules/testing` returns `{ tester, general_only, updated_at, updated_by }` to anyone signed in. `POST /modules/testing { tester: true|false }` switches it, and `POST /modules/:key/general-only { general_only: true|false }` keeps one module on the versions everyone gets while the rest are tested. Both writes take the `module.enable` permission, the same one that turns modules on and off. Both are reversible: switching testing off puts the project back on general versions from its next update, and a module's "general only" mark is kept if testing is switched off and on again. The choice is stored in the project's own settings (`modules.tester`, `modules.general_only`); anything that cannot be read counts as not testing. `testsVersionsOf` in `src/bongos/module-testing.js` is the one answer to "does this project get the tester version of this module", which installs and updates use (task 1003805). The hall's Modules tab has the switch in its "Testing new versions" group, and the general-only control in each module's details.
@@ -407,7 +408,7 @@ Run `bongos upgrade` to confirm coreVersion compatibility, then `node scripts/gd
 - Install never enables. Switch the module on from the hall's Modules tab.
 - **Every version's how-to is a page** (task 1004366). `GET /store/modules/:key/versions/:version/howto` reads the `HOWTO.md` from that version's own stored tarball, after the same hash check install runs, and returns it as text; the hall shows it at `/builders/modules?howto=<key>&version=<X.Y.Z>`, rendered through the hall's escaping markdown reader (`md-reader.js`) because the file is author-written. Any signed-in builder can read it without holding the module; a delisted module's how-to reads only for people who hold it. "Save as PDF" is the browser's own print, with a print sheet that keeps only the document. The optional `howto.artifactUrl` shows as "Also available as a Claude page". Install prints the link, and a Modules-tab row links it when the module on disk is a published store version. A version published before the gate has none and answers 404 `howto_missing`.
 - A module already on disk, in the instance's `modules/` or bundled with the core, is refused; moving one to a newer version is `update`. A module this core cannot mount is refused before download.
-- A delisted module cannot be acquired or downloaded. Channels are not checked yet: install and update hand out a version whatever its channel until task 1003805 lands.
+- A delisted module cannot be acquired or downloaded. **Install and update honour the channel** (task 1003805, [ADR 0344](adr/0344-a-tester-is-a-project-that-opts-in-once.md) D1/D2): a project that tests a module (`testsVersionsOf`) is handed the newest version on `tester` or `general`, every other project the newest on `general`, and nobody a `withdrawn` one (`servedChannels` in `src/bongos/module-store.js`). The acquire answer names the version's `channel`. Asking for an exact version off the project's channels, or downloading it, is refused with `version_not_on_channel` (409); a module with nothing on them yet answers `no_versions_on_channel` (404). `GET /store/modules/latest`, which `bongos upgrade` reads, counts only versions on those channels, so it reports what `bongos module update` would hand over. A project that stops testing keeps the tester version it has; its next update is the newest general one, and update only moves forward, so nothing is rolled back. Recording a version already placed (`POST …/acquired`) does not re-check the channel.
 
 `bongos module update <key> [--version X.Y.Z]` moves an installed store module forward through the same three calls, so a paid module and a free one take one identical path, and a module you already hold is never charged again (`tests/module_update.mjs` fails if a price-conditional branch appears).
 

package/docs/page-readings.json

@@ -3978,7 +3978,7 @@
       "surface": "builders",
       "title": "Studio",
       "states_read": ["home","out","flow","flow-pick","status","words-offer","words-edit","reviews","full","full-back","approvals","approvals-before","approvals-phone","approvals-note","approved","sent-back"],
-      "files_hash": "bd33b2df51b981d4",
+      "files_hash": "a072c3fdf156d639",
       "reading_hash": "55e9090fdd96a979",
       "counts": {"lines":30,"placed":16,"shared":6,"unplaced":8},
       "omitted": {"data":4},

package/modules/copy-desk/page-status.js

@@ -800,8 +800,40 @@ function approvalFor({ page, pageId, rounds, round, builderId, isArtist }) {
   };
 }
 
+// The submitted-but-unapplied rounds, oldest first, in the in-flight list's
+// own words (task 1004662's IN_FLIGHT.submitted), with how long each waited.
+function notAppliedFor({ byPage, invById, now }) {
+  const nowMs = now instanceof Date ? now.getTime() : Number(now);
+  const rows = [];
+  for (const [pageId, rounds] of byPage) {
+    const open = rounds.filter((r) => !TERMINAL.has(r.status));
+    const round = open.length ? open[open.length - 1] : null;
+    if (!round || roundState(round) !== 'submitted') continue;
+    const page = invById.get(pageId) || null;
+    const b = pages.parseBatchBlock(round.description);
+    const since = iso((b.ok && b.batch.submitted_at) || round.updated_at || round.created_at);
+    const ms = since ? nowMs - Date.parse(since) : null;
+    const surface = page ? page.surface : String(pageId).split(':')[0];
+    rows.push({
+      page_id: pageId,
+      surface,
+      surface_word: surfaceWord(surface),
+      title: page ? (page.title || page.id) : pageId,
+      path: page ? page.path || null : null,
+      task_id: String(round.id),
+      state: 'submitted',
+      state_word: IN_FLIGHT.submitted.word,
+      since,
+      waited_days: ms == null ? null : Math.max(0, Math.floor(ms / DAY_MS)),
+      line_count: b.ok ? b.batch.lines.length : 0,
+    });
+  }
+  rows.sort((a, b) => String(a.since || '').localeCompare(String(b.since || '')) || Number(a.task_id) - Number(b.task_id));
+  return { not_applied: rows, not_applied_count: rows.length };
+}
+
 // GET /copy-desk/approvals — the queue, "1 of 2".
-function composeApprovals({ inventory, tasks, builderId, crafts }) {
+function composeApprovals({ inventory, tasks, builderId, crafts, now = Date.now() }) {
   const byPage = indexRounds(tasks);
   const invById = new Map(((inventory && inventory.pages) || []).filter((p) => p && p.id).map((p) => [p.id, p]));
   const isArtist = (crafts || []).includes('artist');
@@ -825,6 +857,11 @@ function composeApprovals({ inventory, tasks, builderId, crafts }) {
     is_artist: isArtist,
     count: queue.length,
     queue,
+    // task 1004765: rounds SUBMITTED but not yet applied. They sat unseen for
+    // weeks because this queue listed only applied rounds; they are listed
+    // apart, never in `queue`, so nothing can approve or send back a page that
+    // has not been applied, and `count` (the studio door) stays reviewable only.
+    ...notAppliedFor({ byPage, invById, now }),
   };
 }
 

package/modules/hall-ui/public/approval-queue-lib.js

@@ -130,6 +130,20 @@
     };
   }
 
+  // task 1004765: a submitted round nobody has applied yet. Listed under the
+  // reviewable pages, marked so, with how long it has waited; it carries no
+  // verb, since there is no applied page to judge.
+  function notAppliedRow(r) {
+    const d = r && r.waited_days;
+    const waited = d == null ? '' : (d === 0 ? 'today' : `${d} day${d === 1 ? '' : 's'}`);
+    return {
+      task_id: String(r.task_id),
+      title: displayTitle(r),
+      mark: 'not applied yet',
+      line: `${r.state_word}${waited ? ` · waiting ${waited}` : ''}. The words are waiting to be applied, so there is nothing to approve yet.`,
+    };
+  }
+
   function noteProblem(note) {
     const n = String(note == null ? '' : note).replace(/\s+/g, ' ').trim();
     if (n.length < MIN_NOTE) return `Say what needs changing in at least ${MIN_NOTE} characters.`;
@@ -157,7 +171,7 @@
   const api = {
     PHASES, DEVICES, MODES, MIN_NOTE, MAX_NOTE,
     slotName, renderIndex, pickRender, hasAnyRender, displayTitle,
-    eyebrow, subLine, doorDetail, refusedWords, lineRow, noteProblem, approvedLine, sentBackLine,
+    eyebrow, subLine, doorDetail, refusedWords, lineRow, notAppliedRow, noteProblem, approvedLine, sentBackLine,
   };
   if (typeof window !== 'undefined') window.OTBApprovalQueueLib = api;
   if (typeof module !== 'undefined' && module.exports) module.exports = api;

package/modules/hall-ui/public/approval-queue.css

@@ -230,6 +230,15 @@ html.aq-open { overflow: hidden; }
 .aq-line__pinned { font-size: 13px; line-height: 1.45; color: var(--aq-link); overflow-wrap: anywhere; }
 .aq-lines__none { margin: 0; font-size: 14px; color: var(--aq-ink-faint); }
 
+/* task 1004765: submitted rounds not applied yet, below the reviewable page. */
+.aq-pending { padding: 14px 20px 18px; border-top: 1px solid var(--aq-rule); }
+.aq-pending__h { margin: 0 0 8px; font-size: 13px; font-weight: 600; color: var(--aq-ink-faint); }
+.aq-pending__list { list-style: none; margin: 0; padding: 0; display: flex; flex-direction: column; gap: 8px; }
+.aq-pending__row { display: flex; flex-wrap: wrap; gap: 4px 8px; font-size: 14px; }
+.aq-pending__title { font-weight: 600; }
+.aq-pending__mark { font-family: var(--aq-mono); font-size: 11px; letter-spacing: .08em; text-transform: uppercase; color: var(--aq-link); }
+.aq-pending__line { flex-basis: 100%; font-size: 13px; color: var(--aq-ink-faint); overflow-wrap: anywhere; }
+
 /* The decision row. */
 .aq-foot {
   display: flex;

package/modules/hall-ui/public/approval-queue.js

@@ -105,6 +105,7 @@
       state.loadError = null;
       state.loaded = true;
       state.queue = (res.data && res.data.queue) || [];
+      state.notApplied = (res.data && res.data.not_applied) || [];
       if (state.idx >= state.queue.length) state.idx = 0;
       tellCount();
     }
@@ -183,6 +184,19 @@
       return `<div class="aq-foot">${approve}${note}<span class="aq-hint">highlighted: the words you changed</span></div>${err}`;
     }
 
+    // task 1004765: submitted rounds nobody has applied, below the reviewable
+    // pages. The server lists them apart; the panel only words them, and gives
+    // them no approve or send-back verb.
+    function notAppliedHtml() {
+      const rows = (state.notApplied || []).map((r) => L.notAppliedRow(r));
+      if (!rows.length) return '';
+      return `<section class="aq-pending" aria-label="Submitted, not applied yet">
+          <h3 class="aq-pending__h">Submitted, not applied yet (${rows.length})</h3>
+          <ul class="aq-pending__list">${rows.map((r) => `
+            <li class="aq-pending__row" data-task="${esc(r.task_id)}"><span class="aq-pending__title">${esc(r.title)}</span> <span class="aq-pending__mark">${esc(r.mark)}</span><span class="aq-pending__line">${esc(r.line)}</span></li>`).join('')}</ul>
+        </section>`;
+    }
+
     function paint() {
       if (!state.open) return;
       const keepNote = document.getElementById('aq-note');
@@ -193,7 +207,8 @@
         const words = state.loadError || (state.loaded ? 'Nothing is waiting for you. A page appears here once /tweak has applied it and its grade has passed.' : 'Opening the Approval queue…');
         dialog.innerHTML = `
           <div class="aq-head"><span class="aq-eyebrow">approval queue</span><h2 class="aq-title" id="aq-title">${state.loaded ? 'Nothing waiting' : 'Approval queue'}</h2><span class="aq-head__gap"></span>${close}</div>
-          <div class="aq-body aq-body--empty"><div class="aq-frame"><p class="aq-frame__note">${esc(words)}</p></div></div>`;
+          <div class="aq-body aq-body--empty"><div class="aq-frame"><p class="aq-frame__note">${esc(words)}</p></div></div>
+          ${notAppliedHtml()}`;
         return;
       }
       loadRenders(item);
@@ -212,7 +227,8 @@
             ${linesHtml(item)}
           </aside>
         </div>
-        ${footHtml(item)}`;
+        ${footHtml(item)}
+        ${notAppliedHtml()}`;
       const note = document.getElementById('aq-note');
       if (note) { note.value = noteValue; }
     }

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.168",
+  "version": "1.21.170",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.21.168",
+      "version": "1.21.170",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.168",
+  "version": "1.21.170",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -10078,5 +10078,21 @@
       "id": "1004777",
       "text": "A page tweak that sits too long now tells someone. If a round waits too long for its artist's review, that artist gets a line in Needs attention on Home. If it waits to be applied or to go live, builders who can apply it get t"
     }
+  ],
+  "1.21.169": [
+    {
+      "id": "1003805",
+      "text": "Projects that test new module versions now actually get them first, and everyone else only gets versions that have passed testing. Turning testing off keeps what you have and moves you to the tested versions from your next upd"
+    }
+  ],
+  "1.21.170": [
+    {
+      "id": "1004765",
+      "text": "The Approval queue now also shows pages an artist submitted that nobody has applied yet, under the pages ready to review. Each is marked not applied yet and says how many days it has waited. They have no approve or send back b"
+    },
+    {
+      "id": "1003806",
+      "text": "When a new module version is being tested, how it went for the testing projects now counts toward its quality score — and a handful of friendly testers can no longer outscore hundreds of real ones."
+    }
   ]
 }

package/scripts/gds/module-assess-installs.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
-// scripts/gds/module-assess-installs.js — the Install and Reliability parts of a
-// module's assessment, worked out from what real installs report (task 1003793,
+// scripts/gds/module-assess-installs.js — the Install, Reliability and Tester
+// feedback parts of a module's assessment, worked out from what real installs report (task 1003793,
 // ADR 0343 D1; reports from core_273, signal rows into core_265).
 //
 // WHY these two parts. Tests and Docs are things an author writes; Install and
@@ -17,6 +17,21 @@
 //                  reported), over the last ERROR_DAY_WINDOW days.
 // No reports → no_data (ADR 0343 D3: left out of the average, never a zero).
 //
+// Tester feedback (task 1003806, ADR 0344 D5) is the same reports, narrowed to
+// the version's TESTER WINDOW: from the first time it went on the tester channel
+// to the first time it left it (promoted or withdrawn), or now while it is still
+// there. Only tester projects are served a tester version (ADR 0344 D1), so a
+// report inside that window is a tester's. A tester it went well for is one whose
+// install did not fail and who reported no runtime errors in the window.
+// Sample size has to weigh — two friendly testers must not outrank two hundred
+// real ones when a buyer sorts by this part — so the count is blended with
+// PRIOR_TESTERS imaginary testers it went half well for:
+//   Tester feedback = round(100 × (went well + PRIOR_TESTERS/2) / (testers + PRIOR_TESTERS)).
+// 3 of 3 → 62, 10 of 10 → 75, 200 of 200 → 98. MIN_HOLDERS applies here too.
+// An install report is one row per holder, re-stamped on each attempt, so a
+// tester who reinstalls after promotion leaves the window; error counts are per
+// day, so they are placed by their day, not by when they were sent.
+//
 // What the reports may contain is fixed by the owner's privacy posture and
 // enforced at intake (src/bongos/module-usage-reports.js): counts and short codes
 // only, and nothing from a holder who switched reporting off.
@@ -29,6 +44,7 @@
 const { ERROR_DAY_WINDOW } = require('../../src/bongos/module-usage-reports');
 
 const MIN_HOLDERS = 3;
+const PRIOR_TESTERS = 10;
 
 // The not-yet-scored outcomes, shared by both parts. Pure.
 function notYet(holders, what) {
@@ -67,8 +83,41 @@ function assessReliability(days = []) {
   };
 }
 
+// Tester feedback from what testers reported in the tester window: `installs` is
+// { holder_kind, holder_ref, ok, error_code } per holder, `days` the holder-days
+// as Reliability takes them. One verdict per tester, blended with the prior. Pure.
+function assessTesterFeedback({ installs = [], days = [] } = {}) {
+  const testers = new Map();
+  const of = (r) => {
+    const k = `${r.holder_kind}:${r.holder_ref}`;
+    if (!testers.has(k)) testers.set(k, { failed: false, errors: 0 });
+    return testers.get(k);
+  };
+  for (const r of installs) of(r).failed = !r.ok;
+  for (const d of days) of(d).errors += Number(d.error_count);
+  const all = [...testers.values()];
+  const n = all.length;
+  const wentWell = all.filter((t) => !t.failed && t.errors === 0).length;
+  const detail = {
+    testers: n, went_well: wentWell,
+    install_failed: all.filter((t) => t.failed).length,
+    with_errors: all.filter((t) => t.errors > 0).length,
+    errors: all.reduce((sum, t) => sum + t.errors, 0),
+    prior_testers: PRIOR_TESTERS,
+  };
+  if (n < MIN_HOLDERS) return { ...notYet(n, 'from the tester channel'), detail };
+  return {
+    outcome: 'scored',
+    score: Math.round((100 * (wentWell + PRIOR_TESTERS / 2)) / (n + PRIOR_TESTERS)),
+    sample_size: n,
+    reason: `it went well for ${wentWell} of ${n} testers (weighed against ${PRIOR_TESTERS} neutral ones, so a small sample cannot score high)`,
+    detail,
+  };
+}
+
 // The author's own reports never count. Shared by both reads.
-const NOT_AUTHOR = `NOT (r.holder_kind = 'builder' AND r.holder_ref = m.author_id::text)`;
+const notAuthor = (a) => `NOT (${a}.holder_kind = 'builder' AND ${a}.holder_ref = m.author_id::text)`;
+const NOT_AUTHOR = notAuthor('r');
 
 async function readReports(versionId, pool) {
   const { rows: latest } = await pool.query(
@@ -87,26 +136,62 @@ async function readReports(versionId, pool) {
   return { latest, days };
 }
 
+// The version's tester window, as SQL over its channel history (core_276): `t.start`
+// is when it first went on the tester channel, `t.stop` when it next left it (null
+// while it is still there). A version that was never a tester version has no row.
+const TESTER_WINDOW = `(SELECT s.start,
+          (SELECT min(c2.set_at) FROM store_module_version_channels c2
+            WHERE c2.version_id = $1 AND c2.channel <> 'tester' AND c2.set_at > s.start) AS stop
+     FROM (SELECT min(c1.set_at) AS start FROM store_module_version_channels c1
+            WHERE c1.version_id = $1 AND c1.channel = 'tester') s
+    WHERE s.start IS NOT NULL) t`;
+
+async function readTesterReports(versionId, pool) {
+  const { rows: installs } = await pool.query(
+    `SELECT ir.holder_kind, ir.holder_ref, ir.ok, ir.error_code
+       FROM module_install_reports ir
+       JOIN store_module_versions v ON v.id = ir.version_id
+       JOIN store_modules m ON m.module_key = v.module_key
+       CROSS JOIN ${TESTER_WINDOW}
+      WHERE ir.version_id = $1 AND ir.reported_at >= t.start AND (t.stop IS NULL OR ir.reported_at < t.stop)
+        AND ${notAuthor('ir')}`, [versionId]);
+  const { rows: days } = await pool.query(
+    `SELECT ec.holder_kind, ec.holder_ref, ec.error_count
+       FROM module_runtime_error_counts ec
+       JOIN store_module_versions v ON v.id = ec.version_id
+       JOIN store_modules m ON m.module_key = v.module_key
+       CROSS JOIN ${TESTER_WINDOW}
+      WHERE ec.version_id = $1 AND ec.day >= t.start::date AND (t.stop IS NULL OR ec.day <= t.stop::date)
+        AND ${notAuthor('ec')}`, [versionId]);
+  return { installs, days };
+}
+
 const sameResult = (cur, s) => !!cur && cur.outcome === s.outcome
   && (cur.score == null ? null : Number(cur.score)) === s.score
   && Number(cur.sample_size) === s.sample_size;
 
-// Re-score Install and Reliability for one version from its reports, append a
+const PARTS = ['install', 'reliability', 'tester_feedback'];
+
+// Re-score Install, Reliability and Tester feedback for one version from its reports, append a
 // signal row for each part whose result moved, then re-compose the overall score
 // (module-assess-score.js). Resolves { ok, written: [part…], score }.
 async function recordInstallSignals(versionId, { db } = {}) {
   const pool = db || require('../../src/bongos/pool').pool;
   const { latest, days } = await readReports(versionId, pool);
-  const next = { install: assessInstall(latest), reliability: assessReliability(days) };
+  const next = {
+    install: assessInstall(latest),
+    reliability: assessReliability(days),
+    tester_feedback: assessTesterFeedback(await readTesterReports(versionId, pool)),
+  };
 
   const { rows: current } = await pool.query(
     `SELECT DISTINCT ON (part) part, outcome, score, sample_size
-       FROM module_assessment_signals WHERE version_id = $1 AND part IN ('install', 'reliability')
+       FROM module_assessment_signals WHERE version_id = $1 AND part IN ('install', 'reliability', 'tester_feedback')
       ORDER BY part, measured_at DESC, id DESC`, [versionId]);
   const byPart = Object.fromEntries(current.map((r) => [r.part, r]));
 
   const written = [];
-  for (const part of ['install', 'reliability']) {
+  for (const part of PARTS) {
     const s = next[part];
     if (sameResult(byPart[part], s)) continue;
     await pool.query(
@@ -128,7 +213,7 @@ async function main(argv) {
     return 2;
   }
   const res = await recordInstallSignals(id);
-  for (const part of ['install', 'reliability']) {
+  for (const part of PARTS) {
     const s = res.signals[part];
     console.log(`${part}: ${s.outcome}${s.score != null ? ` ${s.score}/100` : ''} — ${s.reason}${res.written.includes(part) ? '' : ' (unchanged)'}`);
   }
@@ -140,4 +225,4 @@ if (require.main === module) {
   main(process.argv.slice(2)).then((code) => { process.exitCode = code; }, (e) => { console.error(e.stack || e.message); process.exitCode = 1; });
 }
 
-module.exports = { MIN_HOLDERS, assessInstall, assessReliability, recordInstallSignals };
+module.exports = { MIN_HOLDERS, PRIOR_TESTERS, assessInstall, assessReliability, assessTesterFeedback, recordInstallSignals };