@bongos/core 1.21.166 → 1.21.167

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.21.166",
-  "core_contract": "1.21.166",
-  "source_commit": "c4d8716b86d53f389c6da527bb87de93f0a41574",
+  "core_version": "1.21.167",
+  "core_contract": "1.21.167",
+  "source_commit": "e087b6d2f41d10e25be31761609651177061850c",
   "source_ref": "HEAD",
-  "built_at": "2026-10-23T15:34:52.230Z",
+  "built_at": "2026-10-23T15:52:17.311Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 609,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 3814,
-  "tree_sha256": "2d633356bb361cb11217958de19b741d1699b4abfe0cd60d26e136f81b6fee9d",
+  "tree_sha256": "ec373f78af61090a42811ad9c6b71df2746b19380a6f2d07249b78f9acda118b",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2927,7 +2927,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "3e472d1e3caf6daeb42a39b47765f9226739cbd9eed0bb7842ad902550656f00"
+      "sha256": "e57124018e15636bad9b69617eea091dff6a735c3726ea4d649b569edd700eca"
     },
     {
       "path": "docs/modules-contract.md",
@@ -3017,7 +3017,7 @@
     {
       "path": "docs/page-readings.json",
       "mode": "0000644",
-      "sha256": "00d1821b2b9be013319149445648b66d215c805d2da42ca38818707baaf137c0"
+      "sha256": "b7127988bff3e08f9e11eed84b13afb4e78a579f2d1949be20d9f6ca809555f1"
     },
     {
       "path": "docs/project-context.template.md",
@@ -5602,7 +5602,7 @@
     {
       "path": "modules/hall-ui/public/brand-apply.js",
       "mode": "0000644",
-      "sha256": "d4aaa610fd97ad1f562c8a7b8f23b7c1b3ed830a1f3b889d34430881bd9386de"
+      "sha256": "0bc95cee336ca3c2f5c6666fe944100f01232c51a9f4d595ebdb410f8c514ed3"
     },
     {
       "path": "modules/hall-ui/public/brand-holes.js",
@@ -6487,7 +6487,7 @@
     {
       "path": "modules/hall-ui/public/sky-data.js",
       "mode": "0000644",
-      "sha256": "22ac93686160db1faee19dd00ac81dc6bcb43d636190bb5e65fe57d028e0f196"
+      "sha256": "7d509c43ab2d09f9b50ff588e86bab7ccdad7d28fafad023a13b1080cc745c37"
     },
     {
       "path": "modules/hall-ui/public/sky-draw.js",
@@ -10562,12 +10562,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "bbe25be20ed790d91671be38801e7d859fe468698f858ca71183dbd135ab6305"
+      "sha256": "a978ed0a7cb1c290424af776e7b3404428938e8ce725c5bb73620a5c35c04be5"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "562881524369c0e53286a2c6b46f54babdbd7cd786dd05468cf95492917fe391"
+      "sha256": "d9212427ee860ec4fe3cf81e6ddd18f7a78ba0cecb56cd4c60fed7b17760b0c9"
     },
     {
       "path": "public-docs/index.html",
@@ -10587,7 +10587,7 @@
     {
       "path": "release-notes.json",
       "mode": "0000644",
-      "sha256": "82d369609b5daf53c636b4119e1cf50067f5a7639d5dff92282ecee16e9e7760"
+      "sha256": "eb8492bc0d110844d1ba29976a2c1f76b0d1c27b3fdb74d4057da83a22f70402"
     },
     {
       "path": "scripts/cron/style_guide_audit.sh",
@@ -12972,7 +12972,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "4fef371c7eadeaf1384badb1dfa8ea9ca7494ef71bd7f3228fa265532a3f6caa"
+      "sha256": "0c289c783bbe51aeacd424697726e7fd832da322852670fba91a3235d06fab4c"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -15662,7 +15662,7 @@
     {
       "path": "tests/hall_sky.mjs",
       "mode": "0000644",
-      "sha256": "7da2efcf097e1643390a419ac239085724c5f9e127e417c184a2ba20db60961f"
+      "sha256": "9a7eaea562272b7e06e07ac4251ee15aa4aeaa24180bc711c2dae4dd8a56fd8f"
     },
     {
       "path": "tests/hall_states_regex_escapes.mjs",
@@ -17802,7 +17802,7 @@
     {
       "path": "tests/reward_mode_surfacing.mjs",
       "mode": "0000644",
-      "sha256": "34bb386f994042067d9efa33e9b8840b0764bd4046541ccff9f1c7e4723fadf0"
+      "sha256": "ed3538eb724a939eeb0619d3b61e5bf1b8ac4f389030fb4551c3045840018300"
     },
     {
       "path": "tests/role_responsibilities.mjs",

package/docs/module-api-changelog.md

@@ -3169,5 +3169,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.21.164 with no explicit bump. run 39975834637. (task 1002620)
   1.21.166 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.21.165 with no explicit bump. run 39979397040. (task 1002620)
+  1.21.167 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.21.166 with no explicit bump. run 39981870842. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/docs/page-readings.json

@@ -50,7 +50,7 @@
       "surface": "builders",
       "title": "Blockers",
       "states_read": ["default"],
-      "files_hash": "7dbd80cb2bca71ee",
+      "files_hash": "be570fb08f33cde4",
       "reading_hash": "2b3fd98b7ba1bff6",
       "counts": {"lines":28,"placed":12,"shared":8,"unplaced":8},
       "omitted": {"data":9},
@@ -1141,7 +1141,7 @@
       "surface": "builders",
       "title": "The sky",
       "states_read": ["tour","sky","wells","ledger","full","full-back","out"],
-      "files_hash": "15da52ac5104be23",
+      "files_hash": "2dce7dcbe58dcf5d",
       "reading_hash": "b83eb8c92a23fd3c",
       "counts": {"lines":47,"placed":23,"shared":7,"unplaced":17},
       "omitted": {"data":8},
@@ -1201,7 +1201,7 @@
       "surface": "builders",
       "title": "Goals",
       "states_read": ["list","filters","cards","detail","dependencies","out","uat","uat-panel","author"],
-      "files_hash": "3c92f7510b9892a1",
+      "files_hash": "ca38b540196d951b",
       "reading_hash": "7aa1a6e1946dc077",
       "counts": {"lines":156,"placed":52,"shared":8,"unplaced":96},
       "omitted": {"data":268},
@@ -1326,7 +1326,7 @@
         {"key":"L0117","section":"Goals","text":"Version","placement":"unplaced"},
         {"key":"L0118","section":"Goals","text":"— any —","placement":"placed","file":"modules/hall-ui/public/hall-widgets.js","line":173,"string_id":"729d4ce22b99","occurrences":2},
         {"key":"L0119","section":"Goals","text":"Status","placement":"unplaced"},
-        {"key":"L0120","section":"Goals","text":"open","placement":"placed","file":"modules/hall-ui/public/approval-queue.js","line":163,"string_id":"9a803563c948","occurrences":16},
+        {"key":"L0120","section":"Goals","text":"open","placement":"placed","file":"modules/hall-ui/public/approval-queue.js","line":164,"string_id":"9a803563c948","occurrences":16},
         {"key":"L0121","section":"Goals","text":"Sort","placement":"unplaced"},
         {"key":"L0122","section":"Goals","text":"priority (version order)","placement":"unplaced"},
         {"key":"L0123","section":"Goals","text":"newest first","placement":"unplaced"},
@@ -1439,7 +1439,7 @@
       "surface": "builders",
       "title": "Builders' Hall",
       "states_read": ["home","standing","standing-karma","out","founding","genesis","decide","demo"],
-      "files_hash": "bd2d971d778cd48e",
+      "files_hash": "eb1e8c3a4621add8",
       "reading_hash": "42dbab4f3948fe66",
       "counts": {"lines":117,"placed":63,"shared":10,"unplaced":44},
       "omitted": {"data":101},
@@ -1569,7 +1569,7 @@
       "surface": "builders",
       "title": "Idea",
       "states_read": ["record","missing"],
-      "files_hash": "e68507a3c7ca7a73",
+      "files_hash": "5b7084faad7f4ded",
       "reading_hash": "c9f9a84ab844c704",
       "counts": {"lines":52,"placed":23,"shared":9,"unplaced":20},
       "omitted": {"data":18},
@@ -1609,7 +1609,7 @@
         {"key":"L0032","section":"Everything that fell out of it","text":"{…} and {…}","placement":"placed","file":"modules/hall-ui/public/profile-nudge.js","line":77,"string_id":"56b00d773232","state":"missing"},
         {"key":"L0033","section":"footer","text":"Sign out","placement":"shared","file":"modules/hall-ui/public/shell.js","line":520,"string_id":"1883ad7f07fc","state":"missing","occurrences":2},
         {"key":"L0034","section":"Everything that fell out of it","text":"Builders hall · this session","placement":"placed","file":"modules/hall-ui/public/craft-mode.js","line":674,"string_id":"fd1903586e8e","state":"missing"},
-        {"key":"L0035","section":"12A changelog every builder can read","text":"open","placement":"placed","file":"modules/hall-ui/public/approval-queue.js","line":163,"string_id":"9a803563c948"},
+        {"key":"L0035","section":"12A changelog every builder can read","text":"open","placement":"placed","file":"modules/hall-ui/public/approval-queue.js","line":164,"string_id":"9a803563c948"},
         {"key":"L0036","section":"12A changelog every builder can read","text":"had the thought · {…}","placement":"unplaced"},
         {"key":"L0037","section":"12A changelog every builder can read","text":"{…}/100 complete","placement":"placed","file":"modules/hall-ui/public/idea.js","line":87,"string_id":"c43050b62297"},
         {"key":"L0038","section":"12A changelog every builder can read","text":"{…} and {…}","placement":"placed","file":"modules/hall-ui/public/profile-nudge.js","line":77,"string_id":"56b00d773232","occurrences":4},
@@ -1719,7 +1719,7 @@
       "surface": "builders",
       "title": "Modules",
       "states_read": ["browse","search-empty","lens","details","out"],
-      "files_hash": "c9996ddbee9567d3",
+      "files_hash": "ce529d9f575606e5",
       "reading_hash": "a17f501b72321b7b",
       "counts": {"lines":62,"placed":29,"shared":8,"unplaced":25},
       "omitted": {"data":106},
@@ -2325,7 +2325,7 @@
       "surface": "builders",
       "title": "Profile",
       "states_read": ["own","works","activity","activity-artist","activity-ideator","other","artist","ideator","out"],
-      "files_hash": "38414fb9f52b4e90",
+      "files_hash": "deca408267a32df9",
       "reading_hash": "8088d60a4e93bb91",
       "counts": {"lines":196,"placed":70,"shared":8,"unplaced":118},
       "omitted": {"data":197},
@@ -2721,7 +2721,7 @@
       "surface": "builders",
       "title": "Builders",
       "states_read": ["roster","artists","search","out"],
-      "files_hash": "9192c4aba7c8bfa4",
+      "files_hash": "38086c3c20a8cd6d",
       "reading_hash": "5c7e507e9600e59c",
       "counts": {"lines":47,"placed":13,"shared":8,"unplaced":26},
       "omitted": {"data":60},
@@ -2781,7 +2781,7 @@
       "surface": "builders",
       "title": "Sessions",
       "states_read": ["ledger","out"],
-      "files_hash": "ccf102d700e3ed76",
+      "files_hash": "b5f59d12801a60d9",
       "reading_hash": "5c18aaed7f2e8e0f",
       "counts": {"lines":331,"placed":21,"shared":8,"unplaced":302},
       "omitted": {"data":303},
@@ -4021,7 +4021,7 @@
       "surface": "builders",
       "title": "Task",
       "states_read": ["record","from-goal","missing"],
-      "files_hash": "2f71abd2691c4ff7",
+      "files_hash": "8200eeef7a793659",
       "reading_hash": "3e80d092af1d7e2c",
       "counts": {"lines":132,"placed":35,"shared":10,"unplaced":87},
       "omitted": {"data":75},
@@ -4166,7 +4166,7 @@
       "surface": "builders",
       "title": "Your thinking",
       "states_read": ["tour","sky","list","simple","full-idea","full","full-list","full-back","out"],
-      "files_hash": "f292dc1056724b23",
+      "files_hash": "f8061c0641b23730",
       "reading_hash": "532805c03c3a8a4c",
       "counts": {"lines":48,"placed":23,"shared":7,"unplaced":18},
       "omitted": {"data":8},
@@ -4263,7 +4263,7 @@
       "surface": "builders",
       "title": "Watch",
       "states_read": ["board","out","operations","security"],
-      "files_hash": "9d2b66bc6a2228be",
+      "files_hash": "c3baec6343c9867a",
       "reading_hash": "d698ac62c904aa65",
       "counts": {"lines":88,"placed":38,"shared":8,"unplaced":42},
       "omitted": {"data":166},
@@ -4364,7 +4364,7 @@
       "surface": "builders",
       "title": "Tasks",
       "states_read": ["ready","in-progress","backlog","completed","filters-open","out","founding"],
-      "files_hash": "5a4959f6cb73ad9f",
+      "files_hash": "2c4ec39162b32427",
       "reading_hash": "a425c7a090d8bf03",
       "counts": {"lines":125,"placed":54,"shared":8,"unplaced":63},
       "omitted": {"data":316},

package/modules/hall-ui/public/brand-apply.js

@@ -100,8 +100,11 @@
     var s = task && task.status;
     return s === 'confirmed' || s === 'shipped';
   }
+  // task 1004782 — an abandoned (or merged-away) task earns nothing and is
+  // owed nothing, so it is worth 0 wherever a total adds it up.
   function taskCreditValue(task) {
     if (!task) return null;
+    if (task.status === 'abandoned' || task.merged_into_task_id != null) return 0;
     if (taskSettled(task)) {
       var awarded = Number(task.credits_awarded);
       // Settled with a real ledger payout → show it. If a settled task has no

package/modules/hall-ui/public/sky-data.js

@@ -147,7 +147,10 @@
       id: String(g.goal_id), title: g.title || 'A private goal', subtitle: g.subtitle || null, version: g.version_id, status: g.status,
       taskTotal: Number(g.task_total) || 0, taskDone: Number(g.task_done) || 0, createdAt: g.created_at || null,
       crit: (g.criteria || []).map((c) => ({ id: String(c.id), text: c.criterion_md || '', satisfied: c.satisfied === true, tasks: (c.task_ids || []).map(String), pendingReview: c.pending_review === true, uat: c.uat_state || null, uatLabel: uatLabel(c.uat_state), backendOnly: c.backend_only === true })),
-      tasks: (g.tasks || []).map((t) => ({ id: String(t.id), title: t.title || 'a task', status: t.status, credits: t.credits_reward == null ? 0 : Number(t.credits_reward), createdAt: t.created_on || null, sourceRef: t.idea_id != null ? String(t.idea_id) : null })),
+      // task 1004782 — abandoned (or merged-away) work carries no credits: it is listed, at zero, and never adds to a
+      // well's mass or a ring. A merged-away task is always abandoned (tasks.merged_into_task_id is CHECK-constrained to
+      // abandoned rows), so the status test covers both; /sky does not send the pointer.
+      tasks: (g.tasks || []).map((t) => ({ id: String(t.id), title: t.title || 'a task', status: t.status, credits: t.status === 'abandoned' || t.credits_reward == null ? 0 : Number(t.credits_reward), createdAt: t.created_on || null, sourceRef: t.idea_id != null ? String(t.idea_id) : null })),
     };
   }
   const taskRow = (t) => ({ id: String(t.task_id ?? t.id), title: t.title || 'a task', status: t.status, goalId: t.goal_id != null ? String(t.goal_id) : null, origin: t.origin || null });

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.166",
+  "version": "1.21.167",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.21.166",
+      "version": "1.21.167",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.166",
+  "version": "1.21.167",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -10050,5 +10050,11 @@
       "id": "1004786",
       "text": "Settings no longer shows a broken image-generation key card on projects without the art tools. Before, builders were told their free art coverage had ended and to add a key, but the card could never load, so there was nowhere"
     }
+  ],
+  "1.21.167": [
+    {
+      "id": "1004782",
+      "text": "Goals no longer count abandoned work in their credit totals. Will goal drops by 241 credits of dropped tasks; across the project about 20,000 credits of abandoned estimates stop inflating goal sizes in the sky map and goal pag"
+    }
   ]
 }

package/src/module-api.js

@@ -75,7 +75,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.21.166'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.21.167'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/hall_sky.mjs

@@ -216,6 +216,24 @@ await test('the rings are the criteria, closing as each is satisfied and thick w
   assert.equal(g.tasks.find((t) => t.id === '500').sourceRef, '10', 'and which thought it was born of');
 });
 
+await test('abandoned work is listed at zero and adds nothing to a well or its ring (task 1004782)', async () => {
+  const base = well();
+  const p = await boot({ sky: sky([well({
+    criteria: [{ ...base.criteria[0], task_ids: ['500', '504'] }, { ...base.criteria[1], task_ids: ['501', '502', '503'] }],
+    tasks: [
+      ...base.tasks,
+      { id: '503', title: 'A dropped task', status: 'abandoned', credits_reward: 500, created_on: '2026-08-03', idea_id: null },
+      // merged away: the DB only allows merged_into_task_id on an abandoned row, so this is its whole shape
+      { id: '504', title: 'A task folded into 500', status: 'abandoned', merged_into_task_id: '500', credits_reward: 90, created_on: '2026-08-04', idea_id: null },
+    ],
+  })]) });
+  const g = p.S().goalById.get('7');
+  assert.equal(g.tasks.find((t) => t.id === '503').credits, 0, 'still listed, at zero');
+  assert.equal(g.tasks.find((t) => t.id === '504').credits, 0, 'a merged-away task is listed at zero too');
+  assert.equal(g.credits, 130, 'the well\'s mass is the live work only (60 + 40 + 30)');
+  same(g.crit.map((c) => c.credits), [60, 70], 'and the ring it sat on is not thickened by it');
+});
+
 await test('a private goal keeps its structure and none of its prose', async () => {
   const p = await boot({ sky: sky([well({ goal_id: '8', title: null, subtitle: null, criteria: [{ id: '80', criterion_id: 'c1', criterion_md: null, satisfied: false, pending_review: false, task_ids: [] }], tasks: [{ id: '800', title: null, status: 'ready', credits_reward: 10, created_on: '2026-08-01', idea_id: null }] })]) });
   const g = p.S().goalById.get('8');

package/tests/reward_mode_surfacing.mjs

@@ -164,5 +164,17 @@ test('hall: the tooltip names the mode and what actually pays', () => {
   assert.match(note, /guide, not a payout/i);
 });
 
+// task 1004782 — abandoned and merged-away tasks are worth 0 wherever a total
+// adds them up, on every reward mode.
+test('hall: an abandoned or merged-away task is worth 0, whatever its estimate', () => {
+  for (const mode of [CPO, PAYS, undefined]) {
+    const B = loadBrandApply(mode);
+    assert.equal(B.taskCreditValue({ status: 'abandoned', credits_reward: 60 }), 0);
+    assert.equal(B.taskCreditValue({ status: 'abandoned', credits_reward: 60, credits_awarded: 12 }), 0);
+    assert.equal(B.taskCreditValue({ status: 'ready', credits_reward: 60, merged_into_task_id: 9 }), 0);
+    assert.equal(B.taskCreditValue(READY_TASK), 60, 'live work keeps its value');
+  }
+});
+
 console.log(`\nreward_mode_surfacing: ${passed} passed, ${failed} failed`);
 process.exit(failed ? 1 : 0);