@bongos/core 1.21.165 → 1.21.167

package/modules/hall-ui/public/hall-render.js

@@ -722,20 +722,19 @@
     if (window.OTBAttention && typeof window.OTBAttention.refresh === 'function') window.OTBAttention.refresh();
   }
 
-  // task 1003464: the greeting IS Home's one h1 (the mock opens with it), and
-  // the sub-line is the live status sentence — how far the version is and
-  // whether there is anything to do — the one line a returning builder needs.
-  // Each half renders as its data lands; the line stays hidden until one has.
-  const SMALL_NUMBERS = ['', 'one', 'two', 'three', 'four', 'five', 'six', 'seven', 'eight', 'nine', 'ten', 'eleven', 'twelve'];
+  // task 1003464: the greeting IS Home's one h1 (the mock opens with it).
+  // task 1004780: it has no sub-line any more. The version tab under the banner
+  // shows how far the version is and Next up shows the ready work, so a sentence
+  // repeating both was redundant (owner, 2026-10-23).
   const greetingWord = (hour) => (hour < 12 ? 'Good morning' : (hour < 18 ? 'Good afternoon' : 'Good evening'));
-  // The version the sentence is about: the one being built with the most work in it.
+  // The version the tab is about: the one being built with the most work in it.
   function currentVersion(progress) {
     const rows = progress && Array.isArray(progress.progress) ? progress.progress : [];
     return rows.filter((r) => r && r.status === 'building')
       .sort((a, b) => (Number(b.total_count) || 0) - (Number(a.total_count) || 0))[0] || null;
   }
-  // task 1004774: the version tab under the Home banner — the same version the
-  // sub-line names, drawn as a bar. Hidden while no version is being built.
+  // task 1004774: the version tab under the Home banner, drawn as a bar.
+  // Hidden while no version is being built.
   function renderVersionTab(v) {
     const tab = document.getElementById('home-version');
     if (!tab) return;
@@ -752,26 +751,11 @@
   }
   function renderGreeting() {
     const h1 = document.getElementById('hall-h1');
-    const sub = document.getElementById('hall-sub');
     const builder = ctx.lastMeState && ctx.lastMeState.builder;
     if (h1 && builder) {
       h1.textContent = `${greetingWord(new Date().getHours())}, ${builder.display_name || builder.github_login || 'builder'}`;
     }
-    const v = currentVersion(ctx.lastProgressState);
-    renderVersionTab(v);
-    if (!sub) return;
-    const parts = [];
-    if (v) parts.push(`${v.version_id} is ${Math.round(Number(v.percent_complete) || 0)} percent complete.`);
-    const n = ctx.lastClaimableCount;
-    if (typeof n === 'number') {
-      if (n === 0) parts.push('Nothing is claimable right now.');
-      else {
-        const word = n < SMALL_NUMBERS.length ? SMALL_NUMBERS[n] : fmtNum(n);
-        parts.push(`${word.charAt(0).toUpperCase()}${word.slice(1)} ${n === 1 ? 'task is' : 'tasks are'} claimable right now.`);
-      }
-    }
-    sub.textContent = parts.join(' ');
-    sub.hidden = parts.length === 0;
+    renderVersionTab(currentVersion(ctx.lastProgressState));
   }
   const ONBOARDING_STAGE_ORDER = [
     'auth_complete',

package/modules/hall-ui/public/index.html

@@ -42,12 +42,11 @@
            (one-header-main-h1 — never a second one). The static text is the no-JS /
            signed-out fallback and what brand-apply.js writes the hall's name into;
            hall-render.js renderGreeting turns it into "Good morning, <name>" once
-           /me answers, and fills the sub-line — the live status sentence (how far
-           the version is, whether anything is claimable) — hidden until it has
-           something to say. The label voice is the board's own (.page-head--board). -->
+           /me answers. It has no sub-line (task 1004780): the version tab and Next
+           up already say how far the version is and what is ready. The label voice
+           is the board's own (.page-head--board). -->
       <div class="page-head page-head--board page-head--hall">
         <h1 id="hall-h1" class="page-head__h">Builders' Hall</h1>
-        <p id="hall-sub" class="page-head__sub" hidden></p>
         <!-- task 1004774: Standing left the Home band for this chip. At rest it
              shows the avatar and rank. On hover or keyboard focus the chip itself
              widens to the left into the top of the card, and only the facts below

package/modules/hall-ui/public/settings.js

@@ -1030,6 +1030,10 @@
       renderArtKeyBanner(artKeyNeedItem(me));
       const res = await api.request('GET', `${API}/me/art-key/own`);
       if (res.status === 401) { toAuth(); return; }
+      // 404: the art pipeline is not installed, so there is no key to add here —
+      // keep the section (and any banner) hidden rather than show a reload error
+      // (task 1004786).
+      if (res.status === 404) { renderArtKeyBanner(null); return; }
       if (!res.ok) throw new Error(`art-key GET → ${res.status}`);
       renderArtKeyCard(res.data);
       wireArtKeyCard();

package/modules/hall-ui/public/sky-data.js

@@ -147,7 +147,10 @@
       id: String(g.goal_id), title: g.title || 'A private goal', subtitle: g.subtitle || null, version: g.version_id, status: g.status,
       taskTotal: Number(g.task_total) || 0, taskDone: Number(g.task_done) || 0, createdAt: g.created_at || null,
       crit: (g.criteria || []).map((c) => ({ id: String(c.id), text: c.criterion_md || '', satisfied: c.satisfied === true, tasks: (c.task_ids || []).map(String), pendingReview: c.pending_review === true, uat: c.uat_state || null, uatLabel: uatLabel(c.uat_state), backendOnly: c.backend_only === true })),
-      tasks: (g.tasks || []).map((t) => ({ id: String(t.id), title: t.title || 'a task', status: t.status, credits: t.credits_reward == null ? 0 : Number(t.credits_reward), createdAt: t.created_on || null, sourceRef: t.idea_id != null ? String(t.idea_id) : null })),
+      // task 1004782 — abandoned (or merged-away) work carries no credits: it is listed, at zero, and never adds to a
+      // well's mass or a ring. A merged-away task is always abandoned (tasks.merged_into_task_id is CHECK-constrained to
+      // abandoned rows), so the status test covers both; /sky does not send the pointer.
+      tasks: (g.tasks || []).map((t) => ({ id: String(t.id), title: t.title || 'a task', status: t.status, credits: t.status === 'abandoned' || t.credits_reward == null ? 0 : Number(t.credits_reward), createdAt: t.created_on || null, sourceRef: t.idea_id != null ? String(t.idea_id) : null })),
     };
   }
   const taskRow = (t) => ({ id: String(t.task_id ?? t.id), title: t.title || 'a task', status: t.status, goalId: t.goal_id != null ? String(t.goal_id) : null, origin: t.origin || null });

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.165",
+  "version": "1.21.167",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.21.165",
+      "version": "1.21.167",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.165",
+  "version": "1.21.167",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -10040,5 +10040,21 @@
       "id": "1004771",
       "text": "Artist review is now a small tab on the right edge of every hall page in artist mode. Hover the tab and the review panel slides out; move the cursor back onto the page and it tucks away, keeping your draft. The page stays scro"
     }
+  ],
+  "1.21.166": [
+    {
+      "id": "1004780",
+      "text": "Home's greeting stands on its own: the \"BONGOS-V2 is 83 percent complete. 150 tasks are claimable right now.\" line under \"Good morning\" is gone, because the version bar and the ready-work list beside it already say both."
+    },
+    {
+      "id": "1004786",
+      "text": "Settings no longer shows a broken image-generation key card on projects without the art tools. Before, builders were told their free art coverage had ended and to add a key, but the card could never load, so there was nowhere"
+    }
+  ],
+  "1.21.167": [
+    {
+      "id": "1004782",
+      "text": "Goals no longer count abandoned work in their credit totals. Will goal drops by 241 credits of dropped tasks; across the project about 20,000 credits of abandoned estimates stop inflating goal sizes in the sky map and goal pag"
+    }
   ]
 }

package/src/bongos/routes/me.js

@@ -569,6 +569,9 @@ module.exports = function buildMeRouter() {
         rank: builder?.rank,
         ownKeySet: !!(geminiKeyRow && geminiKeyRow.enc),
         sharedKeyConfigured: artSharedKeyConfigured(),
+        // task 1004786: the art-pipeline module provides this port when enabled;
+        // without it there are no key routes, so the need is not raised.
+        artPipeline: seams.hasProvider('art.sharedKeyConfigured'),
         // founding grace (task 1002739 / direction §5.6): a newborn instance's
         // founder gets a welcome roster, not a coverage nag. The module owns the
         // policy (window length, copy); we pass the raw facts.

package/src/module-api.js

@@ -75,7 +75,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.21.165'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.21.167'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/hall_board_world.mjs

@@ -244,12 +244,15 @@ const hallRenderJs = read('hall-render.js');
 const buildersJs = read('builders.js');
 const goalInboxJs = read('goal-inbox.js');
 
-test('the greeting IS the page\'s one h1, in the board\'s label voice, with a sub-line beside it', () => {
+test('the greeting IS the page\'s one h1, in the board\'s label voice, with no sub-line under it', () => {
   const h1s = indexHtml.match(/<h1\b/g) || [];
   assert.equal(h1s.length, 1, 'one-header-main-h1: the greeting must BECOME the h1, never add a second');
-  assert.match(indexHtml, /<div class="page-head page-head--board page-head--hall">\s*<h1 id="hall-h1" class="page-head__h">Builders' Hall<\/h1>\s*<p id="hall-sub" class="page-head__sub" hidden><\/p>/,
-    'the h1 is visible (no sr-only), keeps the id brand-apply.js writes into, and the sub-line ships hidden');
+  assert.match(indexHtml, /<div class="page-head page-head--board page-head--hall">\s*<h1 id="hall-h1" class="page-head__h">Builders' Hall<\/h1>/,
+    'the h1 is visible (no sr-only) and keeps the id brand-apply.js writes into');
   assert.doesNotMatch(indexHtml, /id="hall-h1" class="sr-only"/, 'the sr-only h1 is gone');
+  // task 1004780 (owner): the status sentence repeated the version tab and Next up, so it went.
+  assert.doesNotMatch(indexHtml, /id="hall-sub"/, 'no status line under the greeting');
+  assert.doesNotMatch(hallRenderJs, /hall-sub|claimable right now/, 'and nothing renders one');
 });
 
 test('the band ends level: no align-items on the grid, so the two cards stretch', () => {
@@ -300,28 +303,18 @@ test('the system notices are inbox LINES, first in the card, and counted by its
   }
 });
 
-test('the greeting reads /me, the public progress and the claimable feed, and builders.js feeds all three', () => {
+test('the greeting reads /me and the public progress (for the version tab), and builders.js feeds both', () => {
   assert.match(buildersJs, /getJSON\(`\$\{API\}\/public\/progress`\)/, 'Home fetches the public progress once');
-  // The count comes off the SAME Next-up response — one request, not a second
-  // fetch. It reads `claimable_total` rather than the length of the returned array,
-  // because that request is now bounded (?limit=2, task 1003545): the array holds two
-  // rows and the total holds the whole rank-scoped queue. Asserting the derivation
-  // rather than one literal expression is deliberate — the previous version pinned
-  // `resp.claimable.length`, which read as a requirement to download the feed.
-  assert.match(buildersJs, /lastClaimableCount = Number\.isFinite\(claimableTotal\)/,
-    'the claimable feed Home already fetches for Next-up answers the count');
-  assert.match(buildersJs, /const claimableTotal = Number\(resp && resp\.claimable_total\);/,
-    'and it takes the count from the response total, so a bounded read still knows it');
   assert.doesNotMatch(buildersJs, /getJSON\(`\$\{API\}\/tasks\/claimable`/,
-    'no unbounded claimable fetch on Home — the count must never cost the whole queue');
+    'no unbounded claimable fetch on Home');
   assert.match(buildersJs, /get lastProgressState\(\)/, 'the renderer reads progress through a getter, so it cannot freeze at boot');
-  assert.match(buildersJs, /get lastClaimableCount\(\)/, 'and the count the same way');
-  assert.equal((buildersJs.match(/renderGreeting\(\)/g) || []).length, 3, 'rendered after /me, after progress and after the claimable feed — each half as it lands');
+  assert.doesNotMatch(buildersJs, /lastClaimableCount/, 'the greeting no longer needs the claimable count (task 1004780)');
+  assert.equal((buildersJs.match(/renderGreeting\(\)/g) || []).length, 2, 'rendered after /me and after progress — each as it lands');
 });
 
 // Boot hall-render.js against a stub DOM and a ctx of getters (the way
 // builders.js builds it) and read what the greeting and the card actually say.
-function bootHallRender({ me, progress = null, claimable = null, leaderboard = [] }) {
+function bootHallRender({ me, progress = null, leaderboard = [] }) {
   const els = new Map();
   const makeEl = () => ({
     dataset: {}, style: {}, textContent: '', hidden: false, _html: '', innerHTML: '',
@@ -359,7 +352,7 @@ function bootHallRender({ me, progress = null, claimable = null, leaderboard = [
     instanceRepo: null, newcomerGated: false,
     get lastMeState() { return me; }, get lastCostState() { return me.cost || null; }, get lastKarmaState() { return me.karma || null; },
     get lastNeedsState() { return me.needs || null; }, get lastRebaseState() { return me.needs_rebase_tasks || null; },
-    get lastProgressState() { return progress; }, get lastClaimableCount() { return claimable; },
+    get lastProgressState() { return progress; },
   };
   const api = windowObj.OTBHallRender(ctx);
   api.lbState.rows = leaderboard;
@@ -375,30 +368,16 @@ const ME = {
 const LEADERBOARD = [{ github_login: 'a', total_credits: 20000 }, { github_login: 'percy', total_credits: 14441 }, { github_login: 'b', total_credits: 3 }, { github_login: 'c', total_credits: 1 }];
 const PROGRESS = { progress: [{ version_id: 'BONGOS-V1', status: 'building', total_count: 605, percent_complete: 75 }, { version_id: 'V2', status: 'planning', total_count: 9000, percent_complete: 0 }] };
 
-test('RUN: the greeting names the builder, and the sub-line says how far the version is and what is claimable', () => {
-  const { api, el } = bootHallRender({ me: ME, progress: PROGRESS, claimable: 5 });
+test('RUN: the greeting names the builder, and the version tab carries how far the version is', () => {
+  const { api, el } = bootHallRender({ me: ME, progress: PROGRESS });
   api.renderGreeting();
   assert.match(el('hall-h1').textContent, /^Good (morning|afternoon|evening), Percy Jackson$/);
-  assert.equal(el('hall-sub').textContent, 'BONGOS-V1 is 75 percent complete. Five tasks are claimable right now.');
-  assert.equal(el('hall-sub').hidden, false);
-});
-
-test('RUN: each half of the sentence renders as its data lands, and the line hides with neither', () => {
+  assert.equal(el('home-version-name').textContent, 'BONGOS-V1', 'the building version, not the bigger planning one');
+  assert.equal(el('home-version-pct').textContent, '75% complete');
+  assert.equal(el('home-version').hidden, false);
   const none = bootHallRender({ me: ME });
   none.api.renderGreeting();
-  assert.equal(none.el('hall-sub').hidden, true, 'nothing to say yet');
-  const onlyProgress = bootHallRender({ me: ME, progress: PROGRESS });
-  onlyProgress.api.renderGreeting();
-  assert.equal(onlyProgress.el('hall-sub').textContent, 'BONGOS-V1 is 75 percent complete.');
-  const zero = bootHallRender({ me: ME, progress: PROGRESS, claimable: 0 });
-  zero.api.renderGreeting();
-  assert.match(zero.el('hall-sub').textContent, /Nothing is claimable right now\.$/);
-  const one = bootHallRender({ me: ME, claimable: 1 });
-  one.api.renderGreeting();
-  assert.equal(one.el('hall-sub').textContent, 'One task is claimable right now.');
-  const many = bootHallRender({ me: ME, claimable: 63 });
-  many.api.renderGreeting();
-  assert.equal(many.el('hall-sub').textContent, '63 tasks are claimable right now.');
+  assert.equal(none.el('home-version').hidden, true, 'no progress yet: no tab');
 });
 
 test('RUN: the Standing card carries the three facts, the place as "2nd of 4", and no banner', () => {

package/tests/hall_sky.mjs

@@ -216,6 +216,24 @@ await test('the rings are the criteria, closing as each is satisfied and thick w
   assert.equal(g.tasks.find((t) => t.id === '500').sourceRef, '10', 'and which thought it was born of');
 });
 
+await test('abandoned work is listed at zero and adds nothing to a well or its ring (task 1004782)', async () => {
+  const base = well();
+  const p = await boot({ sky: sky([well({
+    criteria: [{ ...base.criteria[0], task_ids: ['500', '504'] }, { ...base.criteria[1], task_ids: ['501', '502', '503'] }],
+    tasks: [
+      ...base.tasks,
+      { id: '503', title: 'A dropped task', status: 'abandoned', credits_reward: 500, created_on: '2026-08-03', idea_id: null },
+      // merged away: the DB only allows merged_into_task_id on an abandoned row, so this is its whole shape
+      { id: '504', title: 'A task folded into 500', status: 'abandoned', merged_into_task_id: '500', credits_reward: 90, created_on: '2026-08-04', idea_id: null },
+    ],
+  })]) });
+  const g = p.S().goalById.get('7');
+  assert.equal(g.tasks.find((t) => t.id === '503').credits, 0, 'still listed, at zero');
+  assert.equal(g.tasks.find((t) => t.id === '504').credits, 0, 'a merged-away task is listed at zero too');
+  assert.equal(g.credits, 130, 'the well\'s mass is the live work only (60 + 40 + 30)');
+  same(g.crit.map((c) => c.credits), [60, 70], 'and the ring it sat on is not thickened by it');
+});
+
 await test('a private goal keeps its structure and none of its prose', async () => {
   const p = await boot({ sky: sky([well({ goal_id: '8', title: null, subtitle: null, criteria: [{ id: '80', criterion_id: 'c1', criterion_md: null, satisfied: false, pending_review: false, task_ids: [] }], tasks: [{ id: '800', title: null, status: 'ready', credits_reward: 10, created_on: '2026-08-01', idea_id: null }] })]) });
   const g = p.S().goalById.get('8');

package/tests/home_attention_cards.mjs

@@ -97,8 +97,12 @@ test('closing natively (Escape) also returns the slice, so a reopen still finds
   const { ctx, page } = await bootInbox();
   await page.click('[data-attn-open="attention-blockers"]');
   await page.keyboard.press('Escape');
-  await page.waitForFunction(() => !document.getElementById('attention-dialog').open);
-  const back = await page.evaluate(() => !!document.querySelector('#attention-slices > #attention-blockers'));
+  // `open` turns false at once, but the dialog's `close` EVENT (which moves the slice home) is
+  // queued after it, so wait for the slice itself rather than for `open` (task 1004780 — reading
+  // straight after `open` flipped raced the event and failed CI about half the time).
+  const back = await page.waitForFunction(
+    () => !document.getElementById('attention-dialog').open && !!document.querySelector('#attention-slices > #attention-blockers'),
+    null, { timeout: 3000 }).then(() => true, () => false);
   assert.equal(back, true, 'the dialog close event moves the slice home');
   await page.click('[data-attn-open="attention-blockers"]');
   const rows = await page.evaluate(() => document.querySelectorAll('#attention-dialog-body .ginbox__item').length);

package/tests/reward_mode_surfacing.mjs

@@ -164,5 +164,17 @@ test('hall: the tooltip names the mode and what actually pays', () => {
   assert.match(note, /guide, not a payout/i);
 });
 
+// task 1004782 — abandoned and merged-away tasks are worth 0 wherever a total
+// adds them up, on every reward mode.
+test('hall: an abandoned or merged-away task is worth 0, whatever its estimate', () => {
+  for (const mode of [CPO, PAYS, undefined]) {
+    const B = loadBrandApply(mode);
+    assert.equal(B.taskCreditValue({ status: 'abandoned', credits_reward: 60 }), 0);
+    assert.equal(B.taskCreditValue({ status: 'abandoned', credits_reward: 60, credits_awarded: 12 }), 0);
+    assert.equal(B.taskCreditValue({ status: 'ready', credits_reward: 60, merged_into_task_id: 9 }), 0);
+    assert.equal(B.taskCreditValue(READY_TASK), 60, 'live work keeps its value');
+  }
+});
+
 console.log(`\nreward_mode_surfacing: ${passed} passed, ${failed} failed`);
 process.exit(failed ? 1 : 0);

package/tests/settings_art_key_absent.mjs

@@ -0,0 +1,137 @@
+// tests/settings_art_key_absent.mjs — the image-generation key card on a project
+// with no art pipeline (task 1004786).
+//
+// The key routes (/me/art-key/*) left the core with the art-pipeline module, but
+// the Settings card and the art_key need stayed. On cloudbongos.com — which has
+// no art pipeline — every builder past Xenos was told "your free art coverage has
+// ended, add your key", and the card the nudge pointed at could never load, so
+// there was nowhere to add one. Two halves, both pinned here:
+//
+//   - builder-needs: with the art pipeline absent (ctx.artPipeline === false) the
+//     art_key need is not raised at all — nothing to nag about, nothing to add;
+//   - settings.js: a 404 from GET /me/art-key/own means the routes are not
+//     installed, so the section stays hidden instead of showing a reload error.
+//     A real failure (500) still shows the error.
+//
+// Pure vm + file-read (no DB/network) — runs in the DB-free unit gate.
+import { strict as assert } from 'node:assert';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { createRequire } from 'node:module';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/settings.js'), 'utf8');
+const ME = fs.readFileSync(path.join(ROOT, 'src/bongos/routes/me.js'), 'utf8');
+const needs = createRequire(import.meta.url)('../modules/builder-settings/builder-needs.js');
+
+let passed = 0, failed = 0;
+async function t(name, fn) {
+  try { await fn(); passed++; console.log(`  ok  ${name}`); }
+  catch (e) { failed++; console.error(`  FAIL ${name}\n       ${e.message}`); }
+}
+
+function makeEl() {
+  return {
+    hidden: false, textContent: '', value: '', disabled: false, href: '', className: '',
+    dataset: {}, style: {}, children: [], _html: '',
+    set innerHTML(v) { this._html = String(v); }, get innerHTML() { return this._html; },
+    addEventListener() {}, appendChild(c) { return c; },
+    append() {}, prepend() {}, remove() {}, setAttribute() {}, removeAttribute() {}, getAttribute() { return null; },
+    querySelector() { return null; }, querySelectorAll() { return []; }, closest() { return null; },
+    classList: { add() {}, remove() {}, toggle() {}, contains() { return false; } },
+    focus() {},
+  };
+}
+
+// Boot the real settings.js; GET /me/art-key/own answers with `artKeyStatus`.
+async function boot(artKeyStatus) {
+  const els = new Map();
+  const $ = (sel) => { if (!els.has(sel)) els.set(sel, makeEl()); return els.get(sel); };
+  // The markup ships both hidden (settings.html), so the stub starts them hidden.
+  $('#art-key').hidden = true;
+  $('#artkey-banner').hidden = true;
+  const builder = { id: 4, github_login: 'b4', rank: 'thetes', preferred_disciplines: ['engineer'] };
+  const me = { builder, needs: { items: [needs.artKeyNeed({ rank: 'thetes' })] } };
+  const api = {
+    async request(method, url) {
+      if (method === 'GET' && url === '/api/bongos/me') return { status: 200, ok: true, data: me };
+      if (method === 'GET' && url === '/api/bongos/me/art-key/own') {
+        return artKeyStatus === 200
+          ? { status: 200, ok: true, data: { set: false, storage_configured: true } }
+          : { status: artKeyStatus, ok: false, data: null };
+      }
+      return { status: 404, ok: false, data: null };
+    },
+  };
+  const escapeHtml = (s) => String(s).replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
+  const document = {
+    getElementById: (id) => $(`#${id}`), createElement: () => makeEl(),
+    dispatchEvent() {}, addEventListener() {}, querySelector: () => null, querySelectorAll: () => [],
+  };
+  const window = {
+    __BRANDING__: {}, __MODULES__: { enabled: {} },
+    BongosClient: { createClient: () => api },
+    OTB: {
+      $, escapeHtml, toast() {}, disciplines: () => ['engineer'], roleLabel: (d) => d,
+      hubOrigin: () => null, settingsPanels: () => [],
+    },
+    OTBKit: { emptyStateHtml: (m) => m, makeSectionRail: () => ({ refresh() {}, activate() {} }) },
+    location: { hash: '', pathname: '/settings', search: '', assign() {} },
+    scrollTo() {}, confirm: () => false, addEventListener() {},
+  };
+  const sandbox = {
+    window, document, console: { log() {}, warn() {}, error() {}, info() {} },
+    history: { replaceState() {} }, URLSearchParams, setTimeout, clearTimeout,
+  };
+  sandbox.globalThis = sandbox;
+  vm.createContext(sandbox);
+  vm.runInContext(SRC, sandbox, { filename: 'settings.js' });
+  for (let i = 0; i < 12; i++) await new Promise((r) => setImmediate(r));
+  return $;
+}
+
+console.log('\nthe art_key need without an art pipeline:');
+
+await t('artPipeline: false raises no art_key need at any rank', () => {
+  for (const rank of ['xenos', 'thetes', 'metic', 'archon']) {
+    assert.equal(needs.artKeyNeed({ rank, artPipeline: false }), null, rank);
+    const r = needs.computeNeeds({ rank, artPipeline: false });
+    assert.ok(!r.items.some((n) => n.id === 'art_key'), rank);
+  }
+});
+
+await t('with the pipeline present (or unstated) the need is unchanged', () => {
+  assert.equal(needs.artKeyNeed({ rank: 'thetes', artPipeline: true }).state, 'action_needed');
+  assert.equal(needs.artKeyNeed({ rank: 'thetes' }).state, 'action_needed');
+});
+
+await t('/me tells computeNeeds whether the art pipeline is installed', () => {
+  const call = ME.slice(ME.indexOf('settings.computeNeeds({'), ME.indexOf('isFoundingOwner'));
+  assert.match(call, /artPipeline:/);
+});
+
+console.log('\nthe Settings card:');
+
+await t('routes not installed (404) → the section stays hidden, no reload error', async () => {
+  const $ = await boot(404);
+  assert.equal($('#art-key').hidden, true);
+  assert.equal($('#artkey-banner').hidden, true);
+  assert.doesNotMatch($('#artkey-card').innerHTML, /could not be loaded/);
+});
+
+await t('a real failure (500) still shows the error', async () => {
+  const $ = await boot(500);
+  assert.equal($('#art-key').hidden, false);
+  assert.match($('#artkey-card').innerHTML, /could not be loaded/);
+});
+
+await t('routes present → the key box renders', async () => {
+  const $ = await boot(200);
+  assert.equal($('#art-key').hidden, false);
+  assert.match($('#artkey-card').innerHTML, /id="artkey-input"/);
+});
+
+console.log(`\n${passed} passed, ${failed} failed`);
+process.exit(failed ? 1 : 0);