@bongos/core 1.21.164 → 1.21.166

package/modules/hall-ui/public/page-notes.js

@@ -19,7 +19,7 @@
   var MAX_IMAGES = 8;
   var TYPES = ['image/png', 'image/jpeg', 'image/gif', 'image/webp'];
 
-  var sheet = null, returnFocus = null, state = null, saveTimer = null, pollTimer = null;
+  var sheet = null, returnFocus = null, state = null, saveTimer = null, pollTimer = null, docked = false;
 
   function esc(s) {
     return String(s == null ? '' : s).replace(/[&<>"']/g, function (c) {
@@ -101,11 +101,45 @@
   }
 
   // ---------- the sheet ----------
+  // The tab wears the Review button's own palette glyph (craft-mode.js ICONS
+  // artistry), drawn here too because the public site has no craft-mode.js.
+  var PALETTE_SVG = '<svg class="pn__tab-icon" viewBox="0 0 16 16" fill="none" stroke="currentColor" stroke-width="1.4" stroke-linecap="round" stroke-linejoin="round" aria-hidden="true">' +
+    '<path d="M8 2a6 6 0 1 0 0 12c.9 0 1.4-.6 1.4-1.3 0-.8-.6-1-.6-1.7 0-.6.5-1 1.2-1h1.6A2.4 2.4 0 0 0 14 7.6C14 4.5 11.3 2 8 2Z"/><path d="M5 6.2h.01M7.6 4.6h.01M10.4 5.2h.01M4.6 9h.01" stroke-width="2.2"/></svg>';
+  // The Review mode row: which experience the hall wears while the artist
+  // reviews it (craft-mode.js review mode). Hall only: the public site has no
+  // modes, so it draws nothing there.
+  function craft() { var c = window.OTBCraftMode; return c && c.experiences && c.review ? c : null; }
+  function modesHtml() {
+    var c = craft();
+    if (!c) return '';
+    var on = c.reviewing();
+    return '<div class="pn__modes" role="group" aria-label="Review mode">' +
+      '<span class="pn__modes-h">Review mode</span>' +
+      c.experiences().map(function (x) {
+        return '<button class="pn__mode" type="button" data-pn-mode="' + esc(x.id) + '" aria-pressed="' + (on === x.id ? 'true' : 'false') + '">' +
+          c.iconHtml(x.id, 'pn__mode-icon') + '<span>' + esc(x.short) + '</span></button>';
+      }).join('') +
+      (on ? '<button class="pn__mode pn__mode--stop" type="button" data-pn-mode="">Stop reviewing</button>' : '') +
+    '</div>';
+  }
+  function paintModes() {
+    var row = sheet && sheet.querySelector('#pn-modes');
+    if (row) row.innerHTML = modesHtml();
+  }
+  // Two shapes. Docked (dock(), the hall's artist mode, task 1004771): a
+  // non-modal region at the right edge behind a tab. Opened (open(), e.g. the
+  // public site's Artist review button): the modal sheet over a scrim it was.
   function shellHtml(p) {
-    return '<div class="pn__panel" role="dialog" aria-modal="true" aria-labelledby="pn-title">' +
+    return (docked
+      ? '<button class="pn__tab" type="button" data-pn-tab aria-expanded="true" aria-controls="pn-panel" aria-label="Hide the review panel">' +
+          PALETTE_SVG +
+          '<svg class="pn__tab-chev" viewBox="0 0 16 16" fill="none" stroke="currentColor" stroke-width="1.6" stroke-linecap="round" stroke-linejoin="round" aria-hidden="true"><path d="M6 3l5 5-5 5"/></svg></button>' +
+        '<div class="pn__panel" id="pn-panel" role="region" aria-labelledby="pn-title">'
+      : '<div class="pn__panel" role="dialog" aria-modal="true" aria-labelledby="pn-title">') +
       '<div class="pn__head">' +
         '<p class="pn__eyebrow">Artist review · ' + esc(p.title) + '</p>' +
         '<h2 class="pn__title" id="pn-title">What should this page be?</h2>' +
+        '<div id="pn-modes">' + modesHtml() + '</div>' +
         '<button class="pn__close" type="button" data-pn-close aria-label="Close">' +
           '<svg viewBox="0 0 18 18" fill="none" stroke="currentColor" stroke-width="1.6" stroke-linecap="round" aria-hidden="true"><path d="M5 5l8 8M13 5l-8 8"/></svg></button>' +
       '</div>' +
@@ -285,10 +319,18 @@
   }
 
   function onClick(e) {
-    if (e.target === sheet) { close(); return; }
+    if (!docked && e.target === sheet) { close(); return; }
     var btn = e.target.closest && e.target.closest('button');
     if (!btn) return;
-    if (btn.hasAttribute('data-pn-close')) close();
+    if (btn.hasAttribute('data-pn-tab')) toggle();
+    else if (btn.hasAttribute('data-pn-mode')) {
+      var c = craft(), id = btn.getAttribute('data-pn-mode');
+      if (c) { if (id) c.review(id); else c.stopReview(); }
+      paintModes();
+    }
+    // Docked, the X tucks the panel away like Escape: removing it would take
+    // the tab, the reviewer's only way back in, with it.
+    else if (btn.hasAttribute('data-pn-close')) { if (docked) toggle(true); else close(); }
     else if (btn.hasAttribute('data-pn-submit')) submit();
     else if (btn.hasAttribute('data-pn-note')) showNote(btn.getAttribute('data-pn-note'));
     else if (btn.hasAttribute('data-pn-back') || btn.hasAttribute('data-pn-new')) {
@@ -298,6 +340,13 @@
   }
   function onKey(e) {
     if (!sheet) return;
+    // Docked, the panel is not modal: the page behind it stays scrollable and
+    // reachable, and Escape inside it tucks it away behind its tab, draft kept.
+    if (docked) {
+      if (e.key === 'Escape' && sheet.contains(document.activeElement)) { e.preventDefault(); toggle(true); }
+      return;
+    }
+    // Opened, it is the modal sheet: Escape closes it, Tab stays inside it.
     if (e.key === 'Escape') { e.preventDefault(); close(); return; }
     if (e.key !== 'Tab') return;
     var f = Array.prototype.slice.call(sheet.querySelectorAll('button, textarea, input, a[href]')).filter(function (x) { return !x.disabled; });
@@ -305,20 +354,46 @@
     if (e.shiftKey && document.activeElement === f[0]) { e.preventDefault(); f[f.length - 1].focus(); }
     else if (!e.shiftKey && document.activeElement === f[f.length - 1]) { e.preventDefault(); f[0].focus(); }
   }
-  function mountSheet() {
+  // Slide the panel off the right edge, leaving only its tab, or bring it back.
+  // `quiet` (docking) moves no focus. A docked panel opens its draft only
+  // the first time it is shown, so artist mode costs no request until then.
+  function toggle(collapse, quiet) {
+    if (!sheet) return;
+    var on = typeof collapse === 'boolean' ? collapse : !sheet.classList.contains('pn--collapsed');
+    sheet.classList.toggle('pn--collapsed', on);
+    var tab = sheet.querySelector('[data-pn-tab]');
+    if (tab) {
+      tab.setAttribute('aria-expanded', on ? 'false' : 'true');
+      tab.setAttribute('aria-label', on ? 'Show the review panel' : 'Hide the review panel');
+      if (on && !quiet) tab.focus();
+    }
+    if (on) save();
+    else if (state.pending) { state.pending = false; openDraft(); }
+  }
+  // `dock` mounts the docked shape quietly (no focus moved); otherwise the modal sheet.
+  function mountSheet(dock) {
     if (sheet) return false;
-    returnFocus = document.activeElement;
+    docked = !!dock;
+    returnFocus = docked ? null : document.activeElement;
     state = { note: null, images: [], list: [] };
     sheet = document.createElement('div');
-    sheet.className = 'pn';
+    sheet.className = docked ? 'pn pn--dock' : 'pn';
     sheet.id = 'page-notes';
     sheet.innerHTML = shellHtml(page());
     sheet.addEventListener('click', onClick);
+    if (docked) {
+      // A mouse peeks (owner, 2026-10-23): over the tab the panel opens, and the
+      // moment the pointer leaves the panel it tucks away again, draft kept.
+      // Touch and keyboard keep the tab's click, which a hover cannot replace.
+      sheet.querySelector('[data-pn-tab]').addEventListener('pointerenter', function (e) { if (e.pointerType === 'mouse') toggle(false, true); });
+      sheet.addEventListener('pointerleave', function (e) { if (e.pointerType === 'mouse') toggle(true, true); });
+    } else {
+      document.documentElement.classList.add('pn-open');
+    }
     document.addEventListener('keydown', onKey, true);
     document.body.appendChild(sheet);
-    document.documentElement.classList.add('pn-open');
     var c = sheet.querySelector('[data-pn-close]');
-    if (c) c.focus();
+    if (c && !docked) c.focus();
     return true;
   }
   function close() {
@@ -328,14 +403,24 @@
     document.removeEventListener('keydown', onKey, true);
     if (sheet.parentNode) sheet.parentNode.removeChild(sheet);
     sheet = null;
+    docked = false;
     document.documentElement.classList.remove('pn-open');
     if (returnFocus && returnFocus.focus) { try { returnFocus.focus(); } catch (_) { /* gone */ } }
     returnFocus = null;
   }
 
   window.OTBPageNotes = {
-    open: function () { if (mountSheet()) openDraft(); },
-    openNote: function (id) { if (mountSheet()) refreshList().then(function () { return showNote(id); }); },
+    open: function () { if (mountSheet()) openDraft(); else if (docked) toggle(false); },
+    // Artist mode (craft-mode.js, task 1004771): the panel waits at the right
+    // edge, tucked behind its tab; already there, it repaints its mode row.
+    dock: function () {
+      if (mountSheet(true)) { state.pending = true; toggle(true, true); }
+      else paintModes();
+    },
+    openNote: function (id) {
+      if (!mountSheet() && docked) { state.pending = false; toggle(false); }
+      refreshList().then(function () { return showNote(id); });
+    },
     close: close,
     configure: configure,
     ideaHref: ideaHref,

package/modules/hall-ui/public/settings.js

@@ -1030,6 +1030,10 @@
       renderArtKeyBanner(artKeyNeedItem(me));
       const res = await api.request('GET', `${API}/me/art-key/own`);
       if (res.status === 401) { toAuth(); return; }
+      // 404: the art pipeline is not installed, so there is no key to add here —
+      // keep the section (and any banner) hidden rather than show a reload error
+      // (task 1004786).
+      if (res.status === 404) { renderArtKeyBanner(null); return; }
       if (!res.ok) throw new Error(`art-key GET → ${res.status}`);
       renderArtKeyCard(res.data);
       wireArtKeyCard();

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.164",
+  "version": "1.21.166",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.21.164",
+      "version": "1.21.166",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.164",
+  "version": "1.21.166",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -10034,5 +10034,21 @@
       "id": "1004774",
       "text": "Home got the owner's reshuffle: a slimmer banner with the version's progress bar under it; your picture and rank at the top right, opening on hover into your standing card with a View full profile link; every Needs-attention s"
     }
+  ],
+  "1.21.165": [
+    {
+      "id": "1004771",
+      "text": "Artist review is now a small tab on the right edge of every hall page in artist mode. Hover the tab and the review panel slides out; move the cursor back onto the page and it tucks away, keeping your draft. The page stays scro"
+    }
+  ],
+  "1.21.166": [
+    {
+      "id": "1004780",
+      "text": "Home's greeting stands on its own: the \"BONGOS-V2 is 83 percent complete. 150 tasks are claimable right now.\" line under \"Good morning\" is gone, because the version bar and the ready-work list beside it already say both."
+    },
+    {
+      "id": "1004786",
+      "text": "Settings no longer shows a broken image-generation key card on projects without the art tools. Before, builders were told their free art coverage had ended and to add a key, but the card could never load, so there was nowhere"
+    }
   ]
 }

package/src/bongos/routes/me.js

@@ -569,6 +569,9 @@ module.exports = function buildMeRouter() {
         rank: builder?.rank,
         ownKeySet: !!(geminiKeyRow && geminiKeyRow.enc),
         sharedKeyConfigured: artSharedKeyConfigured(),
+        // task 1004786: the art-pipeline module provides this port when enabled;
+        // without it there are no key routes, so the need is not raised.
+        artPipeline: seams.hasProvider('art.sharedKeyConfigured'),
         // founding grace (task 1002739 / direction §5.6): a newborn instance's
         // founder gets a welcome roster, not a coverage nag. The module owns the
         // policy (window length, copy); we pass the raw facts.

package/src/module-api.js

@@ -75,7 +75,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.21.164'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.21.166'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/craft_review_mode.mjs

@@ -1,9 +1,10 @@
 // tests/craft_review_mode.mjs — artist review mode (task 1004686, goal 1000095).
 //
-// Owner ask, 2026-10-09: hovering the Review button in Artistry opens a menu of
-// the four experiences (Ideator, Governing, Building, Artistry); picking one
-// puts the artist into review mode on that mode's view, and graffiti is painted
-// across the top bar's empty space while it lasts. These cases run the REAL
+// Owner ask, 2026-10-09: the artist picks one of the four experiences (Ideator,
+// Governing, Building, Artistry) and reviews the hall in that mode's view, with
+// graffiti across the top bar's empty space while it lasts. Since task 1004771
+// the choice lives in the docked review panel's own Review mode row
+// (page-notes.js; tests/page_notes_panel.mjs runs that row), not a top-bar menu. These cases run the REAL
 // craft-mode.js (and, when it is loaded, the real craft-review.js) over a small
 // DOM, and read the real craft-review.css for the motion rules.
 import assert from 'node:assert/strict';
@@ -83,7 +84,7 @@ function boot({ session = {}, store = {}, narrow = false } = {}) {
   head.onAppend = (tag) => {
     loaded.push(tag.src);
     if (/craft-review\.js/.test(tag.src)) vm.runInContext(REVIEW, sandbox, { filename: 'craft-review.js' });
-    else window.OTBPageNotes = { open: () => opened.push('open'), openNote: () => {} };
+    else window.OTBPageNotes = { open: () => opened.push('open'), openNote: () => {}, dock: () => opened.push('dock'), close: () => opened.push('close') };
     tag.onload();
   };
   vm.runInContext(CRAFT, sandbox, { filename: 'craft-mode.js' });
@@ -93,107 +94,43 @@ function boot({ session = {}, store = {}, narrow = false } = {}) {
   return {
     craft: window.OTBCraftMode, root, topbar, side, sw, title, loaded, opened, session, byId, docListeners,
     tools: () => all(side).filter((n) => n.hasAttribute('data-craft-tool')).map((n) => n.id.replace('craft-tool-', '')),
-    menu: () => byId('craft-review-menu'),
-    menuOpen: () => !!byId('craft-review-menu') && !byId('craft-review-menu').hasAttribute('hidden'),
-    // A click on a menu item: the menu's own listener reads the button off the target.
-    pick: (attrs) => byId('craft-review-menu').fire('click', { target: { closest: () => ({ getAttribute: (k) => (k in attrs ? attrs[k] : null) }) } }),
   };
 }
 const artist = () => ({ 'hall-craft': 'artistry', 'hall-craft-asked': '1' });
 
-test('THE SPLIT PILL: in Artistry, Review rides a group with a review-mode chevron and a closed menu', () => {
+test('NO TOP-BAR REVIEW BUTTON: in Artistry the bar holds Edit words alone, and no review-mode menu', async () => {
   const p = boot({ session: artist() });
-  const pill = p.byId('craft-review');
-  assert.ok(pill, 'the group exists');
-  assert.equal(p.byId('craft-tool-palette').parentNode, pill, 'Review sits in it');
-  const more = p.byId('craft-review-more');
-  assert.equal(more.parentNode, pill);
-  assert.equal(more.getAttribute('aria-haspopup'), 'menu');
-  assert.equal(more.getAttribute('aria-expanded'), 'false');
-  assert.equal(more.getAttribute('aria-controls'), 'craft-review-menu');
-  assert.equal(p.menu().getAttribute('role'), 'menu');
-  assert.ok(p.menu().hasAttribute('hidden'), 'the menu starts closed');
+  await flush();
+  assert.deepEqual(p.tools(), ['paintbrush'], 'the review panel docks at the edge instead (task 1004771)');
+  assert.equal(p.byId('craft-review'), null, 'no split pill');
+  assert.equal(p.byId('craft-review-menu'), null, 'no menu');
+  assert.deepEqual(p.opened, ['dock']);
   assert.equal(p.byId('craft-graffiti'), null, 'no wall until a review starts');
   assert.equal(p.root.getAttribute('data-craft-review'), null);
-  for (const m of ['building', 'ideating', 'governing']) {
-    p.craft.choose(m);
-    assert.equal(p.byId('craft-review'), null, `no Review pill in ${m}`);
-  }
-});
-
-test('THE MENU: write feedback first, then the four experiences in the owner\'s order and words', () => {
-  const p = boot({ session: artist() });
-  p.byId('craft-review-more').click({ detail: 1 });
-  assert.ok(p.menuOpen(), 'the chevron opens it');
-  assert.equal(p.byId('craft-review-more').getAttribute('aria-expanded'), 'true');
-  const html = p.menu().innerHTML;
-  const labels = [...html.matchAll(/<span>([^<]+)<\/span>/g)].map((m) => m[1]);
-  assert.deepEqual(labels, ['Write feedback on this page', 'Ideator experience', 'Governing experience', 'Building experience', 'Artistry experience']);
-  assert.deepEqual([...html.matchAll(/data-review-pick="([a-z]+)"/g)].map((m) => m[1]), ['ideating', 'governing', 'building', 'artistry']);
-  assert.equal((html.match(/role="menuitemradio" aria-checked="true"/g) || []).length, 0, 'nothing is checked before a review');
-  assert.doesNotMatch(html, /Stop reviewing/, 'no way out of a review that has not started');
-  p.byId('craft-review-more').click({ detail: 1 });
-  assert.ok(!p.menuOpen(), 'the chevron closes it again');
-});
-
-test('HOVER opens it for a mouse, never for a touch, and leaving closes it after a beat', async () => {
-  const p = boot({ session: artist() });
-  const pill = p.byId('craft-review');
-  pill.fire('pointerenter', { pointerType: 'touch' });
-  assert.ok(!p.menuOpen(), 'a touch is not a hover');
-  pill.fire('pointerenter', { pointerType: 'mouse' });
-  assert.ok(p.menuOpen(), 'a mouse over the pill opens the menu');
-  pill.fire('pointerleave', { pointerType: 'mouse' });
-  assert.ok(p.menuOpen(), 'it stays a beat, so the pointer can reach the menu');
-  pill.fire('pointerenter', { pointerType: 'mouse' });
-  await new Promise((r) => setTimeout(r, 260));
-  assert.ok(p.menuOpen(), 'coming back in cancels the close');
-  pill.fire('pointerleave', { pointerType: 'mouse' });
-  await new Promise((r) => setTimeout(r, 260));
-  assert.ok(!p.menuOpen(), 'and leaving for good closes it');
-});
-
-test('CLICKING Review still opens the feedback panel; on a phone a tap opens the menu instead', async () => {
-  const p = boot({ session: artist() });
-  p.byId('craft-tool-palette').click({ detail: 1 });
-  await flush();
-  assert.deepEqual(p.opened, ['open'], 'the feedback doc opens, as before');
-  assert.ok(!p.menuOpen());
-  const phone = boot({ session: artist(), narrow: true });
-  phone.byId('craft-tool-palette').click({ detail: 1 });
-  await flush();
-  assert.deepEqual(phone.opened, [], 'no panel on the tap');
-  assert.ok(phone.menuOpen(), 'the menu instead (a phone has no hover)');
-  phone.pick({ 'data-review-act': 'write' });
-  await flush();
-  assert.deepEqual(phone.opened, ['open'], 'and its first line opens the feedback doc');
+  assert.deepEqual(JSON.parse(JSON.stringify(p.craft.experiences().map((x) => x.label))), ['Ideator experience', 'Governing experience', 'Building experience', 'Artistry experience'], 'the four, in the owner\'s order and words, for the review panel row');
 });
 
 test('PICKING an experience: the hall wears that mode, the artist keeps the Review tools, and the wall goes up', async () => {
   const p = boot({ session: artist() });
-  p.byId('craft-review-more').click({ detail: 1 });
-  p.pick({ 'data-review-pick': 'governing' });
-  assert.ok(!p.menuOpen(), 'the menu closes on a pick');
+  p.craft.review('governing');
   assert.equal(p.root.dataset.craft, 'governing', 'the hall wears Governing: its tabs, look and tallies follow');
   assert.equal(p.root.getAttribute('data-craft-review'), 'governing');
   assert.equal(p.craft.current(), 'governing');
   assert.equal(p.craft.reviewing(), 'governing');
   assert.equal(p.session['hall-craft'], 'artistry', 'the artist\'s own mode stays Artistry');
   assert.equal(p.session['hall-craft-review'], 'governing', 'the review lasts the session');
-  assert.deepEqual(p.tools(), ['palette', 'paintbrush'], 'Review and Edit words stay in the bar');
-  assert.ok(p.byId('craft-tool-palette').classList.contains('craft-tool--reviewing'));
+  assert.deepEqual(p.tools(), ['paintbrush'], 'Edit words stays in the bar');
+  await flush();
+  assert.ok(p.opened.filter((x) => x === 'dock').length >= 2, 'the docked panel is told again, so its mode row repaints');
   const wall = p.byId('craft-graffiti');
   assert.ok(wall, 'the graffiti wall is up');
   assert.equal(wall.parentNode, p.topbar, 'in the top bar');
   assert.equal(wall.nextSibling, p.side, 'in the empty space before the controls');
   assert.equal(wall.getAttribute('aria-hidden'), 'true', 'decorative');
   await flush();
-  assert.deepEqual(p.loaded, ['/builders/craft-review.js?v=2026-10-09-test'], 'the wall\'s script loads on demand, at craft-mode.js\'s version');
+  assert.ok(p.loaded.includes('/builders/craft-review.js?v=2026-10-09-test'), 'the wall\'s script loads on demand, at craft-mode.js\'s version');
   assert.equal((wall.innerHTML.match(/class="gx-tag /g) || []).length, 6, 'six doodles');
   assert.doesNotMatch(wall.innerHTML, /<text/, 'scribbles, not words (owner, 2026-10-09)');
-  p.byId('craft-review-more').click({ detail: 1 });
-  assert.match(p.menu().innerHTML, /aria-checked="true" data-review-pick="governing"/, 'the menu checks the live experience');
-  assert.match(p.menu().innerHTML, /data-review-act="stop"/, 'and offers a way out');
 });
 
 test('IT LASTS THE SESSION: a reload keeps the review; a new session starts without one', () => {
@@ -215,7 +152,7 @@ test('IT LASTS THE SESSION: a reload keeps the review; a new session starts with
 test('REVIEWING Ideating shows its own tool too, marked a guest so a tiny phone can fold it away', () => {
   const p = boot({ session: artist() });
   p.craft.review('ideating');
-  assert.deepEqual(p.tools(), ['palette', 'paintbrush', 'lightbulb'], 'the artist\'s tools, then the experience\'s own, in order');
+  assert.deepEqual(p.tools(), ['paintbrush', 'lightbulb'], 'the artist\'s tool, then the experience\'s own, in order');
   assert.ok(p.byId('craft-tool-lightbulb').classList.contains('craft-tool--guest'));
   assert.ok(!p.byId('craft-tool-paintbrush').classList.contains('craft-tool--guest'));
   p.craft.choose('ideating');
@@ -227,13 +164,11 @@ test('ENDING it: Stop reviewing, or any mode from the switch, puts the artist ba
   const p = boot({ session: artist() });
   p.craft.review('building');
   assert.equal(p.root.dataset.craft, 'building');
-  p.byId('craft-review-more').click({ detail: 1 });
-  p.pick({ 'data-review-act': 'stop' });
+  p.craft.stopReview();
   assert.equal(p.root.dataset.craft, 'artistry', 'Stop reviewing is back in Artistry');
   assert.equal(p.root.getAttribute('data-craft-review'), null);
   assert.equal(p.byId('craft-graffiti'), null, 'the wall comes down');
   assert.equal(p.session['hall-craft-review'], undefined, 'and the session forgets it');
-  assert.ok(!p.byId('craft-tool-palette').classList.contains('craft-tool--reviewing'));
   p.craft.review('governing');
   p.craft.choose('artistry');
   assert.equal(p.craft.reviewing(), null, 'choosing a mode from the switch, even Artistry, ends a review');
@@ -242,25 +177,7 @@ test('ENDING it: Stop reviewing, or any mode from the switch, puts the artist ba
   p.craft.choose('governing');
   assert.equal(p.root.dataset.craft, 'governing');
   assert.equal(p.root.getAttribute('data-craft-review'), null, 'Governing chosen for real is not a review');
-  assert.equal(p.byId('craft-review'), null, 'and carries no Review pill');
-});
-
-test('THE KEYS: arrows move through the menu, Escape closes it, an outside click closes it', () => {
-  const p = boot({ session: artist() });
-  p.byId('craft-review-more').click({ detail: 1 });
-  assert.equal(p.docListeners.click && p.docListeners.click.size, 1, 'an open menu listens for a click outside');
-  p.menu().fire('keydown', { key: 'Escape' });
-  assert.ok(!p.menuOpen(), 'Escape closes it');
-  assert.equal(p.docListeners.click.size, 0, 'and stops listening');
-  p.byId('craft-review-more').fire('keydown', { key: 'ArrowDown' });
-  assert.ok(p.menuOpen(), 'ArrowDown on the chevron opens it');
-  [...p.docListeners.click][0]({ target: p.title });
-  assert.ok(!p.menuOpen(), 'a click elsewhere closes it');
-  p.byId('craft-tool-palette').fire('keydown', { key: 'ArrowDown' });
-  assert.ok(p.menuOpen(), 'ArrowDown on Review opens it too');
-  assert.match(CRAFT, /e\.key === 'ArrowUp'/);
-  assert.match(CRAFT, /e\.key === 'Home'/);
-  assert.match(CRAFT, /e\.key === 'End'/);
+  assert.ok(p.opened.includes('close'), 'and the review panel leaves with Artistry');
 });
 
 test('THE WALL is scribbled in CSS only, in ink alone, and stands still under reduced motion', () => {

package/tests/hall_board_world.mjs

@@ -244,12 +244,15 @@ const hallRenderJs = read('hall-render.js');
 const buildersJs = read('builders.js');
 const goalInboxJs = read('goal-inbox.js');
 
-test('the greeting IS the page\'s one h1, in the board\'s label voice, with a sub-line beside it', () => {
+test('the greeting IS the page\'s one h1, in the board\'s label voice, with no sub-line under it', () => {
   const h1s = indexHtml.match(/<h1\b/g) || [];
   assert.equal(h1s.length, 1, 'one-header-main-h1: the greeting must BECOME the h1, never add a second');
-  assert.match(indexHtml, /<div class="page-head page-head--board page-head--hall">\s*<h1 id="hall-h1" class="page-head__h">Builders' Hall<\/h1>\s*<p id="hall-sub" class="page-head__sub" hidden><\/p>/,
-    'the h1 is visible (no sr-only), keeps the id brand-apply.js writes into, and the sub-line ships hidden');
+  assert.match(indexHtml, /<div class="page-head page-head--board page-head--hall">\s*<h1 id="hall-h1" class="page-head__h">Builders' Hall<\/h1>/,
+    'the h1 is visible (no sr-only) and keeps the id brand-apply.js writes into');
   assert.doesNotMatch(indexHtml, /id="hall-h1" class="sr-only"/, 'the sr-only h1 is gone');
+  // task 1004780 (owner): the status sentence repeated the version tab and Next up, so it went.
+  assert.doesNotMatch(indexHtml, /id="hall-sub"/, 'no status line under the greeting');
+  assert.doesNotMatch(hallRenderJs, /hall-sub|claimable right now/, 'and nothing renders one');
 });
 
 test('the band ends level: no align-items on the grid, so the two cards stretch', () => {
@@ -300,28 +303,18 @@ test('the system notices are inbox LINES, first in the card, and counted by its
   }
 });
 
-test('the greeting reads /me, the public progress and the claimable feed, and builders.js feeds all three', () => {
+test('the greeting reads /me and the public progress (for the version tab), and builders.js feeds both', () => {
   assert.match(buildersJs, /getJSON\(`\$\{API\}\/public\/progress`\)/, 'Home fetches the public progress once');
-  // The count comes off the SAME Next-up response — one request, not a second
-  // fetch. It reads `claimable_total` rather than the length of the returned array,
-  // because that request is now bounded (?limit=2, task 1003545): the array holds two
-  // rows and the total holds the whole rank-scoped queue. Asserting the derivation
-  // rather than one literal expression is deliberate — the previous version pinned
-  // `resp.claimable.length`, which read as a requirement to download the feed.
-  assert.match(buildersJs, /lastClaimableCount = Number\.isFinite\(claimableTotal\)/,
-    'the claimable feed Home already fetches for Next-up answers the count');
-  assert.match(buildersJs, /const claimableTotal = Number\(resp && resp\.claimable_total\);/,
-    'and it takes the count from the response total, so a bounded read still knows it');
   assert.doesNotMatch(buildersJs, /getJSON\(`\$\{API\}\/tasks\/claimable`/,
-    'no unbounded claimable fetch on Home — the count must never cost the whole queue');
+    'no unbounded claimable fetch on Home');
   assert.match(buildersJs, /get lastProgressState\(\)/, 'the renderer reads progress through a getter, so it cannot freeze at boot');
-  assert.match(buildersJs, /get lastClaimableCount\(\)/, 'and the count the same way');
-  assert.equal((buildersJs.match(/renderGreeting\(\)/g) || []).length, 3, 'rendered after /me, after progress and after the claimable feed — each half as it lands');
+  assert.doesNotMatch(buildersJs, /lastClaimableCount/, 'the greeting no longer needs the claimable count (task 1004780)');
+  assert.equal((buildersJs.match(/renderGreeting\(\)/g) || []).length, 2, 'rendered after /me and after progress — each as it lands');
 });
 
 // Boot hall-render.js against a stub DOM and a ctx of getters (the way
 // builders.js builds it) and read what the greeting and the card actually say.
-function bootHallRender({ me, progress = null, claimable = null, leaderboard = [] }) {
+function bootHallRender({ me, progress = null, leaderboard = [] }) {
   const els = new Map();
   const makeEl = () => ({
     dataset: {}, style: {}, textContent: '', hidden: false, _html: '', innerHTML: '',
@@ -359,7 +352,7 @@ function bootHallRender({ me, progress = null, claimable = null, leaderboard = [
     instanceRepo: null, newcomerGated: false,
     get lastMeState() { return me; }, get lastCostState() { return me.cost || null; }, get lastKarmaState() { return me.karma || null; },
     get lastNeedsState() { return me.needs || null; }, get lastRebaseState() { return me.needs_rebase_tasks || null; },
-    get lastProgressState() { return progress; }, get lastClaimableCount() { return claimable; },
+    get lastProgressState() { return progress; },
   };
   const api = windowObj.OTBHallRender(ctx);
   api.lbState.rows = leaderboard;
@@ -375,30 +368,16 @@ const ME = {
 const LEADERBOARD = [{ github_login: 'a', total_credits: 20000 }, { github_login: 'percy', total_credits: 14441 }, { github_login: 'b', total_credits: 3 }, { github_login: 'c', total_credits: 1 }];
 const PROGRESS = { progress: [{ version_id: 'BONGOS-V1', status: 'building', total_count: 605, percent_complete: 75 }, { version_id: 'V2', status: 'planning', total_count: 9000, percent_complete: 0 }] };
 
-test('RUN: the greeting names the builder, and the sub-line says how far the version is and what is claimable', () => {
-  const { api, el } = bootHallRender({ me: ME, progress: PROGRESS, claimable: 5 });
+test('RUN: the greeting names the builder, and the version tab carries how far the version is', () => {
+  const { api, el } = bootHallRender({ me: ME, progress: PROGRESS });
   api.renderGreeting();
   assert.match(el('hall-h1').textContent, /^Good (morning|afternoon|evening), Percy Jackson$/);
-  assert.equal(el('hall-sub').textContent, 'BONGOS-V1 is 75 percent complete. Five tasks are claimable right now.');
-  assert.equal(el('hall-sub').hidden, false);
-});
-
-test('RUN: each half of the sentence renders as its data lands, and the line hides with neither', () => {
+  assert.equal(el('home-version-name').textContent, 'BONGOS-V1', 'the building version, not the bigger planning one');
+  assert.equal(el('home-version-pct').textContent, '75% complete');
+  assert.equal(el('home-version').hidden, false);
   const none = bootHallRender({ me: ME });
   none.api.renderGreeting();
-  assert.equal(none.el('hall-sub').hidden, true, 'nothing to say yet');
-  const onlyProgress = bootHallRender({ me: ME, progress: PROGRESS });
-  onlyProgress.api.renderGreeting();
-  assert.equal(onlyProgress.el('hall-sub').textContent, 'BONGOS-V1 is 75 percent complete.');
-  const zero = bootHallRender({ me: ME, progress: PROGRESS, claimable: 0 });
-  zero.api.renderGreeting();
-  assert.match(zero.el('hall-sub').textContent, /Nothing is claimable right now\.$/);
-  const one = bootHallRender({ me: ME, claimable: 1 });
-  one.api.renderGreeting();
-  assert.equal(one.el('hall-sub').textContent, 'One task is claimable right now.');
-  const many = bootHallRender({ me: ME, claimable: 63 });
-  many.api.renderGreeting();
-  assert.equal(many.el('hall-sub').textContent, '63 tasks are claimable right now.');
+  assert.equal(none.el('home-version').hidden, true, 'no progress yet: no tab');
 });
 
 test('RUN: the Standing card carries the three facts, the place as "2nd of 4", and no banner', () => {

package/tests/home_attention_cards.mjs

@@ -97,8 +97,12 @@ test('closing natively (Escape) also returns the slice, so a reopen still finds
   const { ctx, page } = await bootInbox();
   await page.click('[data-attn-open="attention-blockers"]');
   await page.keyboard.press('Escape');
-  await page.waitForFunction(() => !document.getElementById('attention-dialog').open);
-  const back = await page.evaluate(() => !!document.querySelector('#attention-slices > #attention-blockers'));
+  // `open` turns false at once, but the dialog's `close` EVENT (which moves the slice home) is
+  // queued after it, so wait for the slice itself rather than for `open` (task 1004780 — reading
+  // straight after `open` flipped raced the event and failed CI about half the time).
+  const back = await page.waitForFunction(
+    () => !document.getElementById('attention-dialog').open && !!document.querySelector('#attention-slices > #attention-blockers'),
+    null, { timeout: 3000 }).then(() => true, () => false);
   assert.equal(back, true, 'the dialog close event moves the slice home');
   await page.click('[data-attn-open="attention-blockers"]');
   const rows = await page.evaluate(() => document.querySelectorAll('#attention-dialog-body .ginbox__item').length);