@bongos/core 1.21.163 → 1.21.165

package/modules/hall-ui/public/style.css

@@ -4565,3 +4565,98 @@ html.palette-open { overflow: hidden; }
 .gr-cat { display: inline-flex; align-items: baseline; gap: 5px; margin-left: 8px; padding: 1px 8px; border: 1px solid var(--rule-soft); border-radius: 999px; font-size: 11px; font-weight: 600; letter-spacing: .01em; color: var(--ink-soft); background: var(--surface-2); vertical-align: baseline; white-space: nowrap; }
 .gr-cat--inherited { font-weight: 550; color: var(--ink-faint); }
 .gr-cat__from { font-style: normal; font-weight: 500; font-size: 10px; color: var(--ink-faint); opacity: .85; }
+
+/* ---- Home reshuffle (task 1004774; mock docs/design/mocks/hall/home/v1.html) ----
+   A slimmer banner pulled up under the greeting, the version as a progress tab
+   under it, Standing as a chip at the top right with a hover card, the
+   Needs-attention slices as cards that open a window, and Your work beside
+   Recently shipped. */
+body[data-page="home"] .page-head--hall { position: relative; margin: 0 0 12px; padding-right: 180px; }
+body[data-page="home"] .stat-tile { padding: 12px 22px; min-height: 0; gap: 4px; }
+body[data-page="home"] .stat-tile__num { font-size: clamp(20px, 2vw, 26px); }
+body[data-page="home"] #home-stats .stat-row { border-bottom-left-radius: 0; border-bottom-right-radius: 0; }
+
+.version-tab {
+  display: flex; align-items: center; gap: 14px; min-height: 24px;
+  padding: 10px 22px; color: var(--ink); text-decoration: none;
+  background: var(--glass); border: 1px solid var(--glass-edge); border-top: 0;
+  border-radius: 0 0 var(--radius) var(--radius);
+}
+.version-tab:hover { text-decoration: none; background: var(--glass-strong); }
+.version-tab[hidden] { display: none; }
+.version-tab__name { font-weight: 600; white-space: nowrap; }
+.version-tab__bar { flex: 1; height: 8px; border-radius: 4px; background: var(--rule-soft); overflow: hidden; }
+.version-tab__fill { display: block; height: 100%; width: 0; background: var(--accent); border-radius: 4px; }
+.version-tab__pct { color: var(--ink-soft); font-size: 13px; white-space: nowrap; font-variant-numeric: tabular-nums; }
+
+.hall-standing { position: absolute; top: 0; right: 0; height: 44px; outline: none; }
+.hall-standing[hidden] { display: none; }
+/* The chip IS the top of the card: anchored at the right, it grows LEFT as the
+   name slides in, and only .hall-standing__more drops down below it. */
+.hall-standing__card {
+  position: absolute; top: 0; right: 0; z-index: 20; min-width: 0;
+  background: var(--bg-card); border-radius: 22px; padding: 4px 6px 4px 4px;
+  transition: min-width .2s ease, border-radius .2s ease, padding .2s ease, box-shadow .2s ease;
+}
+.hall-standing__card .home-who { gap: 8px; padding: 0; }
+.hall-standing__card .home-who__avatar { width: 36px; height: 36px; }
+.hall-standing__card .home-who__meta {
+  max-width: 0; opacity: 0; overflow: hidden; white-space: nowrap;
+  transition: max-width .2s ease, opacity .2s ease;
+}
+.hall-standing__more {
+  max-height: 0; overflow: hidden; opacity: 0;
+  transition: max-height .25s ease, opacity .2s ease;
+}
+.hall-standing__more .home-facts { margin-top: 12px; }
+.hall-standing__more .card-foot { margin: 12px 0 0; }
+.hall-standing:hover .hall-standing__card,
+.hall-standing:focus-within .hall-standing__card {
+  min-width: 300px; border-radius: var(--radius); padding: 14px 16px 16px;
+  box-shadow: 0 12px 40px rgba(0, 0, 0, .35);
+}
+.hall-standing:hover .home-who__meta,
+.hall-standing:focus-within .home-who__meta { max-width: 200px; opacity: 1; }
+.hall-standing:hover .hall-standing__more,
+.hall-standing:focus-within .hall-standing__more { max-height: 420px; opacity: 1; }
+.hall-standing:focus-visible .hall-standing__card { outline: 2px solid var(--focus); outline-offset: 2px; }
+
+.attn-cards { display: grid; grid-template-columns: repeat(auto-fill, minmax(220px, 1fr)); gap: 12px; }
+.attn-card {
+  display: flex; flex-direction: column; align-items: flex-start; gap: 6px; min-height: 100px;
+  padding: 16px 18px; text-align: left; font: inherit; color: var(--ink); cursor: pointer;
+  background: var(--glass); border: 1px solid var(--glass-edge); border-radius: var(--radius);
+}
+.attn-card:hover { border-color: var(--accent); }
+.attn-card__n { font-family: var(--font-display); font-size: 30px; font-weight: 300; line-height: 1; font-variant-numeric: tabular-nums; }
+.attn-card__t { font-weight: 600; }
+.attn-card__s { margin-top: auto; font-size: 12px; color: var(--ink-soft); }
+.attn-dialog {
+  width: min(640px, calc(100vw - 32px)); max-height: 80vh; padding: 22px 24px; overflow: auto;
+  background: var(--bg-card); color: var(--ink); border: 0; border-radius: var(--radius);
+}
+.attn-dialog::backdrop { background: var(--scrim); }
+.attn-dialog__head { display: flex; align-items: center; gap: 12px; margin-bottom: 8px; }
+.attn-dialog__h { flex: 1; margin: 0; font-family: var(--font-display); font-weight: 500; font-size: 20px; }
+.attn-dialog__x { min-width: 32px; min-height: 32px; background: none; border: 0; color: var(--ink-soft); font-size: 22px; cursor: pointer; }
+.attn-dialog__body .ginbox__sec-h { display: none; }
+
+.home-split { display: grid; grid-template-columns: 1fr 1fr; gap: 24px; align-items: start; }
+.home-split__col { min-width: 0; }
+.home-split > .home-split__col[hidden] + .home-split__col { grid-column: 1 / -1; }
+
+@media (max-width: 760px) {
+  body[data-page="home"] .page-head--hall { padding-right: 0; }
+  .hall-standing { position: relative; display: block; margin-top: 10px; }
+  .hall-standing__card { left: 0; right: auto; }
+  .hall-standing:hover .hall-standing__card,
+  .hall-standing:focus-within .hall-standing__card { min-width: min(300px, calc(100vw - 32px)); }
+  .home-split { grid-template-columns: 1fr; }
+}
+/* With Standing gone from the band, a lone card there (Goals) takes the row. */
+.view-zone--band > .scroll:only-child { grid-column: 1 / -1; }
+/* The Standing hover card's stat row: four figures in a 2x2 grid, label over number. */
+.home-facts--grid { grid-template-columns: 1fr 1fr; gap: 10px 14px; padding: 12px 0; border-top: 1px solid var(--rule-soft); border-bottom: 1px solid var(--rule-soft); }
+.home-facts--grid > div { display: flex; flex-direction: column; gap: 2px; }
+.home-facts--grid dt, .home-facts--grid dd { border-top: 0; padding: 0; text-align: left; }
+.home-facts--grid dd { font-family: var(--font-display); font-size: 20px; font-weight: 300; }

package/modules/hall-ui/public/task-detail.js

@@ -450,6 +450,12 @@
       var priOptions = [1, 2, 3, 4, 5].map(function (p) {
         return '<option value="' + p + '"' + (p === pri ? ' selected' : '') + '>P' + p + '</option>';
       }).join('');
+      // A create with no discipline the server cannot infer from the wording is
+      // refused (task 1002988), so the builder names the craft here. Engineer is
+      // the default, the same fallback bug routing uses (ideas/inbox.js).
+      var craftOptions = [['engineer', 'Engineer'], ['artist', 'Artist'], ['ideator', 'Ideator'], ['ui', 'UI']].map(function (c) {
+        return '<option value="' + c[0] + '"' + (c[0] === 'engineer' ? ' selected' : '') + '>' + c[1] + '</option>';
+      }).join('');
       box.innerHTML =
         '<form class="td-form" data-form="promote">'
         + '<label class="td-field td-field--wide"><span>Title</span>'
@@ -457,6 +463,7 @@
         + '<label class="td-field td-field--wide"><span>Version</span><select name="version">' + options + '</select></label>'
         + '<label class="td-field td-field--wide"><span>Goal</span><select name="goal" data-goal-select>' + goalOptions + '</select></label>'
         + '<label class="td-field"><span>Priority</span><select name="priority">' + priOptions + '</select></label>'
+        + '<label class="td-field"><span>Craft</span><select name="discipline">' + craftOptions + '</select></label>'
         + '<label class="td-field"><span>Estimate (min)</span>'
         + '<input type="number" name="est" min="0" max="100000" step="5" placeholder="—"></label>'
         + '<label class="td-field"><span>Reward</span>'
@@ -504,6 +511,7 @@
         title: title,
         description: body + provenance,
         priority: Number(form.priority.value) || 3,
+        discipline: (form.discipline && form.discipline.value) || 'engineer',
         source: 'idea_inbox',
         source_ref: 'idea:' + idea.id,
       };

package/modules/hall-ui/records/home-reshuffle.md

@@ -0,0 +1,31 @@
+# The Home reshuffle — slim banner, version tab, Standing chip, attention cards with windows (task 1004774)
+
+The owner's Builders' Hall feedback (idea 1001262), home-page half, built to the approved mock at
+[`docs/design/mocks/hall/home/v1.html`](../../../docs/design/mocks/hall/home/v1.html).
+
+- **Banner + version tab.** The stat row is slimmer (`body[data-page="home"]` overrides), and under it
+  `#home-version` draws the version the greeting's sub-line names, from the same `currentVersion()`
+  read — `renderVersionTab` in `hall-render.js`. Hidden while nothing is being built.
+- **Standing is a chip, not a card.** The `home-standing` widget is gone; `#hall-standing` sits in the
+  page head (it is chrome, not a `<section class="scroll">`, so the registry rule is untouched). The
+  card it opens on hover or keyboard focus is still `#home-standing-body`, filled by `renderProfile`.
+  The place row reads "Leaderboard place" — the owner asked for no "on the board" wording. The chip
+  IS the top of the card (owner, 2026-10-23): at rest it shows the avatar and rank with no text and
+  no link, and on hover or focus it widens LEFT as the name slides in, while only
+  `.hall-standing__more` (the facts and a "View full profile" link to /profile) drops down below it.
+- **Needs attention is cards.** Every slice still renders into its own div exactly as before, kept in
+  the hidden `#attention-slices`. `OTBAttention.refresh()` rebuilds one card per non-empty slice from
+  the slice's heading (title, count pill = the server total, the `.ginbox__sub` note). Opening a card
+  MOVES the slice div into `#attention-dialog`, which sits inside the widget host — so the delegated
+  click handler still sees every button and no slice needed a second action path. Closing moves it back.
+  `tests/home_attention_cards.mjs` runs the real file in a browser: card totals, open, X, Escape, and a
+  window whose slice empties while open.
+- **Goals card** lost its subtitle, and its foot is one "Browse goals" link; the "not joined" line shows only when you have joined none.
+- **Next up is five rows**, level with the five Recently shipped rows, asked for AND capped client-side.
+- **Renamed:** "Stuck on the owner" → "Requires project owner fix"; "Going quiet" → "Things not moving".
+- **Your work beside Recently shipped** — `.home-split` in the `home-recent` widget; shipped takes the
+  full row when Next up is hidden, and both stack under 760px.
+
+Not built, because the data does not exist yet: the "Tasks you are blocking in other goals"
+(requested / total) card, and the any-owner / main-owner split on "Requires project owner fix" —
+blockers carry no addressee today.

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.163",
+  "version": "1.21.165",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.21.163",
+      "version": "1.21.165",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.21.163",
+  "version": "1.21.165",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -10020,5 +10020,25 @@
       "id": "1004773",
       "text": "The Private option on the account page now opens with the artist line \"you are a ninja.\", and still tells people Private hides their page from everyone, them included."
     }
+  ],
+  "1.21.164": [
+    {
+      "id": "1004772",
+      "text": "Promoting an idea from the home page's Triage button no longer fails with \"discipline was not supplied\". The Promote form now has a Craft choice (Engineer by default), so every promoted idea becomes a task."
+    },
+    {
+      "id": "1004775",
+      "text": "Approved page tweaks now land on their own. When two rounds were applied from the same main, the second used to hit a conflict in the page readings file and wait for a person; that file now merges page by page, so the second r"
+    },
+    {
+      "id": "1004774",
+      "text": "Home got the owner's reshuffle: a slimmer banner with the version's progress bar under it; your picture and rank at the top right, opening on hover into your standing card with a View full profile link; every Needs-attention s"
+    }
+  ],
+  "1.21.165": [
+    {
+      "id": "1004771",
+      "text": "Artist review is now a small tab on the right edge of every hall page in artist mode. Hover the tab and the review panel slides out; move the cursor back onto the page and it tucks away, keeping your draft. The page stays scro"
+    }
   ]
 }

package/scripts/gds/copy-apply.js

@@ -458,17 +458,73 @@ function applyBatchToSources({ batch, registry, readSource }) {
   return { applied: applied.sort(byOrder).map(({ order, ...rest }) => rest), refused, sources };
 }
 
+// findPinningTests({ applied, listTests, readFile }) -> [{ key, tests: [rel…] }]
+//
+// Task 1004775. A test that asserts a line's OLD words verbatim goes red the
+// moment the round lands, which used to surface only in CI, after the artist had
+// approved, and needed a person. So at APPLY time every applied line's old text is
+// searched for in the test files (tests/ and every module's own tests folder), and each test that
+// still carries it is named in the applied block and shown in the Approval queue.
+// Nothing is edited: a test may be guarding what the words MEAN, and only a person
+// can tell that apart from a test that pins the wording alone.
+//
+// The needle is the line's old text; where it has {…} holes, its longest literal
+// run between them, and a needle under MIN_PIN_NEEDLE characters is skipped (a
+// two-word label matches half the suite and would name nothing useful).
+const MIN_PIN_NEEDLE = 12;
+const PIN_TEST_RE = /\.(mjs|cjs|js)$/;
+
+function pinNeedle(text) {
+  const runs = String(text == null ? '' : text).split('{…}').map((s) => s.trim());
+  const longest = runs.reduce((a, b) => (b.length > a.length ? b : a), '');
+  return longest.length >= MIN_PIN_NEEDLE ? longest : null;
+}
+
+function listTestFiles({ root = REPO_ROOT, fsImpl = fs } = {}) {
+  const out = [];
+  const walk = (rel) => {
+    let ents;
+    try { ents = fsImpl.readdirSync(path.join(root, rel), { withFileTypes: true }); } catch { return; }
+    for (const e of ents) {
+      const r = `${rel}/${e.name}`;
+      if (e.isDirectory()) { if (e.name !== 'node_modules' && e.name !== 'fixtures') walk(r); } else if (PIN_TEST_RE.test(e.name)) out.push(r);
+    }
+  };
+  walk('tests');
+  let mods = [];
+  try { mods = fsImpl.readdirSync(path.join(root, 'modules'), { withFileTypes: true }); } catch { mods = []; }
+  for (const m of mods) if (m.isDirectory()) walk(`modules/${m.name}/tests`);
+  return out.sort();
+}
+
+function findPinningTests({ applied, listTests = listTestFiles, readFile = (rel) => fs.readFileSync(path.join(REPO_ROOT, rel), 'utf8') }) {
+  const wants = (applied || []).map((a) => ({ key: a.key, needle: pinNeedle(a.before) })).filter((w) => w.needle);
+  if (!wants.length) return [];
+  const hits = new Map();
+  for (const rel of listTests()) {
+    let src;
+    try { src = readFile(rel); } catch { continue; }
+    for (const w of wants) {
+      if (!src.includes(w.needle)) continue;
+      if (!hits.has(w.key)) hits.set(w.key, []);
+      hits.get(w.key).push(rel);
+    }
+  }
+  return wants.filter((w) => hits.has(w.key)).map((w) => ({ key: w.key, tests: hits.get(w.key) }));
+}
+
 // The ```page-tweak-applied``` block's content, from the page's NEW reading.
 // lines_after is the non-shared lines' texts: shared shell lines are left out of
 // drift on both sides (D8, builder pick 7), so they must be left out here too or
 // every one of them would read as "removed" on the next drift check.
-function appliedBlockFor({ pageId, readingPage, refused, appliedAt }) {
+function appliedBlockFor({ pageId, readingPage, refused, appliedAt, pinnedTests = [] }) {
   return {
     page_id: pageId,
     applied_at: appliedAt,
     reading_hash_after: readingPage ? readingPage.reading_hash : null,
     lines_after: readingPage ? (readingPage.lines || []).filter((l) => l && l.placement !== 'shared').map((l) => String(l.text)) : [],
     refused: (refused || []).map((x) => ({ key: x.key, code: x.code })),
+    ...(pinnedTests && pinnedTests.length ? { pinned_tests: pinnedTests.map((p) => ({ key: p.key, tests: p.tests.slice() })) } : {}),
   };
 }
 
@@ -564,7 +620,10 @@ async function batchMain({ taskId, batchFile, dryRun, pageId = null, now = () =>
     return 4;
   }
   const readingPage = (deps.readingFor || ((id) => readingFor(id, { readFile })))(batch.page_id);
-  const block = appliedBlockFor({ pageId: batch.page_id, readingPage, refused: result.refused, appliedAt: now() });
+  const oldText = new Map(batch.lines.map((l) => [l.key, l.before]));
+  const pinnedTests = (deps.findPinningTests || findPinningTests)({ applied: result.applied.map((a) => ({ key: a.key, before: oldText.get(a.key) })) });
+  for (const p of pinnedTests) log(`  ${p.key} the old words are still asserted by: ${p.tests.join(', ')} (update the test or it fails once this lands)`);
+  const block = appliedBlockFor({ pageId: batch.page_id, readingPage, refused: result.refused, appliedAt: now(), pinnedTests });
   if (batchFile) {
     log('copy-apply --batch: the page-tweak-applied block (a --batch-file run writes no task):');
     log(pages.composeAppliedBlock(block));
@@ -684,6 +743,10 @@ module.exports = {
   applyBatchToSources,
   appliedBlockFor,
   batchMain,
+  // task 1004775: tests that still assert a rewritten line's old words.
+  findPinningTests,
+  listTestFiles,
+  pinNeedle,
   surfaceRootFor,
   checkPatchPath,
   locateOccurrence,

package/scripts/gds/git-merge-regen.js

@@ -115,6 +115,8 @@ const REGENERABLE = new Set([
   'docs/session-log-index.md',
   'docs/copy-inventory.md',
   'docs/copy-registry.json',
+  // task 1004775: merged per page (page-reader.js mergeReadingDocs), see the rule below.
+  'docs/page-readings.json',
   ...G.NESTED_DIRS.map((d) => `${d}/CLAUDE.md`),
   ...API_DOC_FILES,
   ...API_CLIENT_FILES,
@@ -170,6 +172,18 @@ function regenerateResolved(relpath, { base = '', ours = '', theirs = '' } = {})
   if (relpath === 'docs/copy-registry.json') {
     return { content: `${JSON.stringify(CI.buildRegistry(), null, 2)}\n`, ok: true };
   }
+  // docs/page-readings.json (task 1004775): one entry per page, and a re-read needs a
+  // browser no merge has. Two approved page-tweak rounds re-read DIFFERENT pages and
+  // both rewrite the top counts line, so every pair conflicted and the second round
+  // stranded for a person. Merge it per page from the three sides and recompute the
+  // counts (page-reader.js mergeReadingDocs). Unlike the scans above it reads the
+  // merge sides, not the tree, so it is not provisional; a page BOTH sides re-read
+  // differently is a real conflict and stays one.
+  if (relpath === 'docs/page-readings.json') {
+    const PR = require('./page-reader');
+    const m = PR.mergeReadingDocs({ base, ours, theirs });
+    return m.ok ? { content: m.content, ok: true } : { content: null, ok: false };
+  }
   if (relpath === 'docs/copy-inventory.md') {
     return { content: CI.renderReport(CI.buildRegistry()), ok: true };
   }

package/scripts/gds/page-reader.js

@@ -600,6 +600,50 @@ function mergeReadings(inventory, previous, fresh) {
   return inventory.pages.map((p) => byId.get(p.id)).filter(Boolean);
 }
 
+// mergeReadingDocs({ base, ours, theirs }) -> { ok, content, conflicted }
+//
+// The merge rule for docs/page-readings.json (task 1004775). Two approved page
+// tweak rounds branched from the same main each re-read THEIR page, and both
+// rewrite the top `counts` line — so git conflicts on every pair, and the second
+// round stranded as unresolvable_conflict until a person merged it by hand. A
+// re-read needs a browser, which a merge never has, but it does not need one: the
+// file is one entry per page, so the merge is per page. A page only one side
+// changed takes that side's reading; a page both changed the same way takes it; a
+// page both changed DIFFERENTLY is a real conflict (two rounds re-read one page —
+// their source files conflict too) and is named, never guessed. The summary counts
+// are recomputed from the merged pages and the whole file re-serialized, so the
+// result is byte-for-byte what the reader itself would write for those pages.
+// Pages keep ours' order; a page only theirs has goes where theirs had it.
+function mergeReadingDocs({ base, ours, theirs }) {
+  const parse = (s) => { try { return s && String(s).trim() ? JSON.parse(s) : { pages: [] }; } catch { return null; } };
+  const b = parse(base), o = parse(ours), t = parse(theirs);
+  if (!b || !o || !t) return { ok: false, content: null, conflicted: ['(unreadable json)'] };
+  const map = (d) => new Map((d.pages || []).map((p) => [p.id, p]));
+  const B = map(b), O = map(o), T = map(t);
+  const same = (x, y) => JSON.stringify(x === undefined ? null : x) === JSON.stringify(y === undefined ? null : y);
+  const order = [...O.keys()];
+  for (const id of T.keys()) {
+    if (order.includes(id)) continue;
+    const at = (t.pages || []).findIndex((p) => p.id === id);
+    const prev = at > 0 ? t.pages[at - 1].id : null;
+    const i = prev ? order.indexOf(prev) : -1;
+    order.splice(i + 1, 0, id);
+  }
+  const pages = [];
+  const conflicted = [];
+  for (const id of order) {
+    const bv = B.get(id), ov = O.get(id), tv = T.get(id);
+    let pick;
+    if (same(ov, tv)) pick = ov;
+    else if (same(ov, bv)) pick = tv;
+    else if (same(tv, bv)) pick = ov;
+    else { conflicted.push(id); continue; }
+    if (pick) pages.push(pick);
+  }
+  if (conflicted.length) return { ok: false, content: null, conflicted };
+  return { ok: true, content: serialize(buildDoc(pages)), conflicted: [] };
+}
+
 function loadPrevious() {
   try { return readJsonFile(READINGS_REL); } catch { return null; }
 }
@@ -671,6 +715,8 @@ module.exports = {
   filesHash, readingHash, buildMatcher, placeText, collectStrings, holeData,
   mergeStates, assembleReading, serialize, buildDoc, checkReadings, planRenders,
   captureInPage, mergeReadings,
+  // task 1004775: the merge driver's per-page rule for docs/page-readings.json.
+  mergeReadingDocs,
   // task 1004322: /tweak renders the page the reader reads, through the same harness.
   startHarness, SURFACE_MODULE, PINNED_CLOCK,
 };

package/src/module-api.js

@@ -75,7 +75,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.21.163'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.21.165'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/conflict_resolve.mjs

@@ -591,7 +591,13 @@ test('1003546 every REGENERABLE artifact has a producer, and every producer is i
       .map((p) => [p, 'scripts/gds/gen-api-client.js']),
   ]);
 
+  // task 1004775 — docs/page-readings.json is merged per page FROM THE THREE MERGE
+  // SIDES (page-reader.js mergeReadingDocs), never by scanning the tree, so the
+  // driver's result is already final; its only producer opens a browser, which the
+  // server never has. It is the one REGENERABLE entry with no post-merge generator.
+  const MERGED_FROM_SIDES = new Set(['docs/page-readings.json']);
   for (const p of regen.REGENERABLE) {
+    if (MERGED_FROM_SIDES.has(p)) continue;
     const producer = PRODUCED_BY.get(p);
     assert.ok(producer, `REGENERABLE knows ${p} but this test has no producer for it — name the generator that writes it`);
     assert.ok(

package/tests/craft_review_mode.mjs

@@ -1,9 +1,10 @@
 // tests/craft_review_mode.mjs — artist review mode (task 1004686, goal 1000095).
 //
-// Owner ask, 2026-10-09: hovering the Review button in Artistry opens a menu of
-// the four experiences (Ideator, Governing, Building, Artistry); picking one
-// puts the artist into review mode on that mode's view, and graffiti is painted
-// across the top bar's empty space while it lasts. These cases run the REAL
+// Owner ask, 2026-10-09: the artist picks one of the four experiences (Ideator,
+// Governing, Building, Artistry) and reviews the hall in that mode's view, with
+// graffiti across the top bar's empty space while it lasts. Since task 1004771
+// the choice lives in the docked review panel's own Review mode row
+// (page-notes.js; tests/page_notes_panel.mjs runs that row), not a top-bar menu. These cases run the REAL
 // craft-mode.js (and, when it is loaded, the real craft-review.js) over a small
 // DOM, and read the real craft-review.css for the motion rules.
 import assert from 'node:assert/strict';
@@ -83,7 +84,7 @@ function boot({ session = {}, store = {}, narrow = false } = {}) {
   head.onAppend = (tag) => {
     loaded.push(tag.src);
     if (/craft-review\.js/.test(tag.src)) vm.runInContext(REVIEW, sandbox, { filename: 'craft-review.js' });
-    else window.OTBPageNotes = { open: () => opened.push('open'), openNote: () => {} };
+    else window.OTBPageNotes = { open: () => opened.push('open'), openNote: () => {}, dock: () => opened.push('dock'), close: () => opened.push('close') };
     tag.onload();
   };
   vm.runInContext(CRAFT, sandbox, { filename: 'craft-mode.js' });
@@ -93,107 +94,43 @@ function boot({ session = {}, store = {}, narrow = false } = {}) {
   return {
     craft: window.OTBCraftMode, root, topbar, side, sw, title, loaded, opened, session, byId, docListeners,
     tools: () => all(side).filter((n) => n.hasAttribute('data-craft-tool')).map((n) => n.id.replace('craft-tool-', '')),
-    menu: () => byId('craft-review-menu'),
-    menuOpen: () => !!byId('craft-review-menu') && !byId('craft-review-menu').hasAttribute('hidden'),
-    // A click on a menu item: the menu's own listener reads the button off the target.
-    pick: (attrs) => byId('craft-review-menu').fire('click', { target: { closest: () => ({ getAttribute: (k) => (k in attrs ? attrs[k] : null) }) } }),
   };
 }
 const artist = () => ({ 'hall-craft': 'artistry', 'hall-craft-asked': '1' });
 
-test('THE SPLIT PILL: in Artistry, Review rides a group with a review-mode chevron and a closed menu', () => {
+test('NO TOP-BAR REVIEW BUTTON: in Artistry the bar holds Edit words alone, and no review-mode menu', async () => {
   const p = boot({ session: artist() });
-  const pill = p.byId('craft-review');
-  assert.ok(pill, 'the group exists');
-  assert.equal(p.byId('craft-tool-palette').parentNode, pill, 'Review sits in it');
-  const more = p.byId('craft-review-more');
-  assert.equal(more.parentNode, pill);
-  assert.equal(more.getAttribute('aria-haspopup'), 'menu');
-  assert.equal(more.getAttribute('aria-expanded'), 'false');
-  assert.equal(more.getAttribute('aria-controls'), 'craft-review-menu');
-  assert.equal(p.menu().getAttribute('role'), 'menu');
-  assert.ok(p.menu().hasAttribute('hidden'), 'the menu starts closed');
+  await flush();
+  assert.deepEqual(p.tools(), ['paintbrush'], 'the review panel docks at the edge instead (task 1004771)');
+  assert.equal(p.byId('craft-review'), null, 'no split pill');
+  assert.equal(p.byId('craft-review-menu'), null, 'no menu');
+  assert.deepEqual(p.opened, ['dock']);
   assert.equal(p.byId('craft-graffiti'), null, 'no wall until a review starts');
   assert.equal(p.root.getAttribute('data-craft-review'), null);
-  for (const m of ['building', 'ideating', 'governing']) {
-    p.craft.choose(m);
-    assert.equal(p.byId('craft-review'), null, `no Review pill in ${m}`);
-  }
-});
-
-test('THE MENU: write feedback first, then the four experiences in the owner\'s order and words', () => {
-  const p = boot({ session: artist() });
-  p.byId('craft-review-more').click({ detail: 1 });
-  assert.ok(p.menuOpen(), 'the chevron opens it');
-  assert.equal(p.byId('craft-review-more').getAttribute('aria-expanded'), 'true');
-  const html = p.menu().innerHTML;
-  const labels = [...html.matchAll(/<span>([^<]+)<\/span>/g)].map((m) => m[1]);
-  assert.deepEqual(labels, ['Write feedback on this page', 'Ideator experience', 'Governing experience', 'Building experience', 'Artistry experience']);
-  assert.deepEqual([...html.matchAll(/data-review-pick="([a-z]+)"/g)].map((m) => m[1]), ['ideating', 'governing', 'building', 'artistry']);
-  assert.equal((html.match(/role="menuitemradio" aria-checked="true"/g) || []).length, 0, 'nothing is checked before a review');
-  assert.doesNotMatch(html, /Stop reviewing/, 'no way out of a review that has not started');
-  p.byId('craft-review-more').click({ detail: 1 });
-  assert.ok(!p.menuOpen(), 'the chevron closes it again');
-});
-
-test('HOVER opens it for a mouse, never for a touch, and leaving closes it after a beat', async () => {
-  const p = boot({ session: artist() });
-  const pill = p.byId('craft-review');
-  pill.fire('pointerenter', { pointerType: 'touch' });
-  assert.ok(!p.menuOpen(), 'a touch is not a hover');
-  pill.fire('pointerenter', { pointerType: 'mouse' });
-  assert.ok(p.menuOpen(), 'a mouse over the pill opens the menu');
-  pill.fire('pointerleave', { pointerType: 'mouse' });
-  assert.ok(p.menuOpen(), 'it stays a beat, so the pointer can reach the menu');
-  pill.fire('pointerenter', { pointerType: 'mouse' });
-  await new Promise((r) => setTimeout(r, 260));
-  assert.ok(p.menuOpen(), 'coming back in cancels the close');
-  pill.fire('pointerleave', { pointerType: 'mouse' });
-  await new Promise((r) => setTimeout(r, 260));
-  assert.ok(!p.menuOpen(), 'and leaving for good closes it');
-});
-
-test('CLICKING Review still opens the feedback panel; on a phone a tap opens the menu instead', async () => {
-  const p = boot({ session: artist() });
-  p.byId('craft-tool-palette').click({ detail: 1 });
-  await flush();
-  assert.deepEqual(p.opened, ['open'], 'the feedback doc opens, as before');
-  assert.ok(!p.menuOpen());
-  const phone = boot({ session: artist(), narrow: true });
-  phone.byId('craft-tool-palette').click({ detail: 1 });
-  await flush();
-  assert.deepEqual(phone.opened, [], 'no panel on the tap');
-  assert.ok(phone.menuOpen(), 'the menu instead (a phone has no hover)');
-  phone.pick({ 'data-review-act': 'write' });
-  await flush();
-  assert.deepEqual(phone.opened, ['open'], 'and its first line opens the feedback doc');
+  assert.deepEqual(JSON.parse(JSON.stringify(p.craft.experiences().map((x) => x.label))), ['Ideator experience', 'Governing experience', 'Building experience', 'Artistry experience'], 'the four, in the owner\'s order and words, for the review panel row');
 });
 
 test('PICKING an experience: the hall wears that mode, the artist keeps the Review tools, and the wall goes up', async () => {
   const p = boot({ session: artist() });
-  p.byId('craft-review-more').click({ detail: 1 });
-  p.pick({ 'data-review-pick': 'governing' });
-  assert.ok(!p.menuOpen(), 'the menu closes on a pick');
+  p.craft.review('governing');
   assert.equal(p.root.dataset.craft, 'governing', 'the hall wears Governing: its tabs, look and tallies follow');
   assert.equal(p.root.getAttribute('data-craft-review'), 'governing');
   assert.equal(p.craft.current(), 'governing');
   assert.equal(p.craft.reviewing(), 'governing');
   assert.equal(p.session['hall-craft'], 'artistry', 'the artist\'s own mode stays Artistry');
   assert.equal(p.session['hall-craft-review'], 'governing', 'the review lasts the session');
-  assert.deepEqual(p.tools(), ['palette', 'paintbrush'], 'Review and Edit words stay in the bar');
-  assert.ok(p.byId('craft-tool-palette').classList.contains('craft-tool--reviewing'));
+  assert.deepEqual(p.tools(), ['paintbrush'], 'Edit words stays in the bar');
+  await flush();
+  assert.ok(p.opened.filter((x) => x === 'dock').length >= 2, 'the docked panel is told again, so its mode row repaints');
   const wall = p.byId('craft-graffiti');
   assert.ok(wall, 'the graffiti wall is up');
   assert.equal(wall.parentNode, p.topbar, 'in the top bar');
   assert.equal(wall.nextSibling, p.side, 'in the empty space before the controls');
   assert.equal(wall.getAttribute('aria-hidden'), 'true', 'decorative');
   await flush();
-  assert.deepEqual(p.loaded, ['/builders/craft-review.js?v=2026-10-09-test'], 'the wall\'s script loads on demand, at craft-mode.js\'s version');
+  assert.ok(p.loaded.includes('/builders/craft-review.js?v=2026-10-09-test'), 'the wall\'s script loads on demand, at craft-mode.js\'s version');
   assert.equal((wall.innerHTML.match(/class="gx-tag /g) || []).length, 6, 'six doodles');
   assert.doesNotMatch(wall.innerHTML, /<text/, 'scribbles, not words (owner, 2026-10-09)');
-  p.byId('craft-review-more').click({ detail: 1 });
-  assert.match(p.menu().innerHTML, /aria-checked="true" data-review-pick="governing"/, 'the menu checks the live experience');
-  assert.match(p.menu().innerHTML, /data-review-act="stop"/, 'and offers a way out');
 });
 
 test('IT LASTS THE SESSION: a reload keeps the review; a new session starts without one', () => {
@@ -215,7 +152,7 @@ test('IT LASTS THE SESSION: a reload keeps the review; a new session starts with
 test('REVIEWING Ideating shows its own tool too, marked a guest so a tiny phone can fold it away', () => {
   const p = boot({ session: artist() });
   p.craft.review('ideating');
-  assert.deepEqual(p.tools(), ['palette', 'paintbrush', 'lightbulb'], 'the artist\'s tools, then the experience\'s own, in order');
+  assert.deepEqual(p.tools(), ['paintbrush', 'lightbulb'], 'the artist\'s tool, then the experience\'s own, in order');
   assert.ok(p.byId('craft-tool-lightbulb').classList.contains('craft-tool--guest'));
   assert.ok(!p.byId('craft-tool-paintbrush').classList.contains('craft-tool--guest'));
   p.craft.choose('ideating');
@@ -227,13 +164,11 @@ test('ENDING it: Stop reviewing, or any mode from the switch, puts the artist ba
   const p = boot({ session: artist() });
   p.craft.review('building');
   assert.equal(p.root.dataset.craft, 'building');
-  p.byId('craft-review-more').click({ detail: 1 });
-  p.pick({ 'data-review-act': 'stop' });
+  p.craft.stopReview();
   assert.equal(p.root.dataset.craft, 'artistry', 'Stop reviewing is back in Artistry');
   assert.equal(p.root.getAttribute('data-craft-review'), null);
   assert.equal(p.byId('craft-graffiti'), null, 'the wall comes down');
   assert.equal(p.session['hall-craft-review'], undefined, 'and the session forgets it');
-  assert.ok(!p.byId('craft-tool-palette').classList.contains('craft-tool--reviewing'));
   p.craft.review('governing');
   p.craft.choose('artistry');
   assert.equal(p.craft.reviewing(), null, 'choosing a mode from the switch, even Artistry, ends a review');
@@ -242,25 +177,7 @@ test('ENDING it: Stop reviewing, or any mode from the switch, puts the artist ba
   p.craft.choose('governing');
   assert.equal(p.root.dataset.craft, 'governing');
   assert.equal(p.root.getAttribute('data-craft-review'), null, 'Governing chosen for real is not a review');
-  assert.equal(p.byId('craft-review'), null, 'and carries no Review pill');
-});
-
-test('THE KEYS: arrows move through the menu, Escape closes it, an outside click closes it', () => {
-  const p = boot({ session: artist() });
-  p.byId('craft-review-more').click({ detail: 1 });
-  assert.equal(p.docListeners.click && p.docListeners.click.size, 1, 'an open menu listens for a click outside');
-  p.menu().fire('keydown', { key: 'Escape' });
-  assert.ok(!p.menuOpen(), 'Escape closes it');
-  assert.equal(p.docListeners.click.size, 0, 'and stops listening');
-  p.byId('craft-review-more').fire('keydown', { key: 'ArrowDown' });
-  assert.ok(p.menuOpen(), 'ArrowDown on the chevron opens it');
-  [...p.docListeners.click][0]({ target: p.title });
-  assert.ok(!p.menuOpen(), 'a click elsewhere closes it');
-  p.byId('craft-tool-palette').fire('keydown', { key: 'ArrowDown' });
-  assert.ok(p.menuOpen(), 'ArrowDown on Review opens it too');
-  assert.match(CRAFT, /e\.key === 'ArrowUp'/);
-  assert.match(CRAFT, /e\.key === 'Home'/);
-  assert.match(CRAFT, /e\.key === 'End'/);
+  assert.ok(p.opened.includes('close'), 'and the review panel leaves with Artistry');
 });
 
 test('THE WALL is scribbled in CSS only, in ink alone, and stands still under reduced motion', () => {