@bongos/core 1.21.157 → 1.21.159

package/tests/module_store_publish.mjs

@@ -195,6 +195,7 @@ test('store: a key or version that could escape the store dir is refused before
 // A fake pg pool: `state` is the registry, answers are computed from it.
 function fakeDb(state = { modules: {}, versions: [] }) {
   const log = [];
+  state.channels = state.channels || [];
   const client = {
     async query(sql, params = []) {
       log.push(sql.trim().split(/\s+/).slice(0, 2).join(' '));
@@ -211,6 +212,10 @@ function fakeDb(state = { modules: {}, versions: [] }) {
         const row = { id: state.versions.length + 1, module_key: params[0], version: params[1] };
         state.versions.push(row); return { rows: [row] };
       }
+      if (/^INSERT INTO store_module_version_channels/.test(sql)) {
+        state.channels.push({ version_id: params[0], channel: params[1], reason: params[2], set_by: params[3] });
+        return { rows: [] };
+      }
       return { rows: [] };
     },
     release() {},
@@ -256,6 +261,33 @@ test('registry: a version is published once, and never older than the latest', a
   assert.equal(ok.ok, true, 'numeric, not string, ordering: 1.10.0 > 1.2.0');
 });
 
+// Task 1003803, ADR 0344 D2: every new version, first release or update, lands on
+// the tester channel. Publish takes no channel at all, so there is no flag to omit
+// or misspell; reaching everyone is the promotion gate's later act (task 1003804).
+test('channel: a first release lands on tester, recorded with who published it', async () => {
+  const db = fakeDb();
+  const r = await store.publishVersion(input(), { db: db.pool });
+  assert.equal(r.ok, true);
+  assert.equal(r.channel, 'tester');
+  assert.deepEqual(db.state.channels, [{ version_id: 1, channel: 'tester', reason: 'new_version', set_by: 7 }]);
+});
+
+test('channel: an update lands on tester too, never straight to general', async () => {
+  const state = { modules: { weather: { module_key: 'weather', author_id: 7, status: 'listed' } },
+    versions: [{ id: 1, module_key: 'weather', version: '1.1.0' }] };
+  const db = fakeDb(state);
+  const r = await store.publishVersion(input({ channel: 'general' }), { db: db.pool });
+  assert.equal(r.ok, true);
+  assert.equal(r.channel, 'tester', 'a channel named by the caller is not a way past testers');
+  assert.deepEqual(db.state.channels.map((c) => c.channel), ['tester']);
+});
+
+test('channel: a refused publish records no channel', async () => {
+  const db = fakeDb({ modules: { weather: { module_key: 'weather', author_id: 7, status: 'listed' } }, versions: [] });
+  await store.publishVersion(input({ builderId: 8 }), { db: db.pool });
+  assert.deepEqual(db.state.channels, []);
+});
+
 test('registry: if putting the file in place fails, the row is rolled back', async () => {
   const db = fakeDb();
   await assert.rejects(