@bongos/core 1.21.114 → 1.21.116

package/tests/instance_db_migrated_on_code_move.mjs

@@ -32,7 +32,7 @@ const tenant = { slug: 'charter', db_name: 'charter_db', hosting_shape: 'co-tena
 
 test('bongos upgrade migrates before it restarts, and only --skip-migrate opts out', () => {
   const src = fs.readFileSync(path.join(ROOT, 'scripts/gds/upgrade.js'), 'utf8');
-  const migrate = src.indexOf('const mig = runMigrate(instanceDir, run, opts.migrateAs || null);');
+  const migrate = src.indexOf('const mig = await runMigrate(instanceDir, run, opts.migrateAs || null);'); // async since task 1004734 (teed output)
   const restart = src.lastIndexOf('restartService({ service: opts.service, restartCmd: opts.restartCmd }');
   assert.ok(migrate > 0, 'the upgrade flow runs migrate');
   assert.ok(restart > migrate, 'the restart that makes new code live comes AFTER migrate');
@@ -47,7 +47,7 @@ test('bongos upgrade migrates before it restarts, and only --skip-migrate opts o
   // provisioned since task 1003369, and the wrong one cannot connect at all: the project's
   // database is owned by its own Postgres login role with CONNECT revoked from PUBLIC.
   // Asserting the CALL SITE, not just the helper — the helper was never the gap.
-  assert.match(src, /const mig = runMigrate\(instanceDir, run, opts\.migrateAs \|\| null\);/,
+  assert.match(src, /const mig = await runMigrate\(instanceDir, run, opts\.migrateAs \|\| null\);/,
     'the migrate step is handed --migrate-as, not left on whoever the move happens to be');
   assert.equal(`bash ${CORE_MIGRATE_SCRIPT}`, INSTANCE_MIGRATE_SCRIPT, 'migrate is the instance scaffold script, i.e. the core migrate.sh');
 });

package/tests/projects_hub_pre_uat.mjs

@@ -701,12 +701,14 @@ test('the rail\'s way-back handlers left with it, the repo picker is honest ARIA
   // delegated handlers and their CSS must not linger as dead code
   assert.doesNotMatch(SCRIPT, /railEl|data-goto/, 'no delegated rail handler is left');
   assert.doesNotMatch(COSMOS, /\.steps li\[role=button\]/, 'and no rail-button CSS');
-  assert.doesNotMatch(HUB, /role="listbox"/);
+  // the page's one real listbox is the country field's combobox (task 1004671); the repo
+  // picker stays a labelled group of rows
+  assert.deepEqual([...HUB.matchAll(/<[^>]*role="listbox"[^>]*>/g)].map((m) => (m[0].match(/id="([^"]+)"/) || [])[1]), ['physCountryList']);
   assert.doesNotMatch(SCRIPT, /role="option"/);
   assert.match(HUB, /<div id="ghList" class="ghlist" role="group" aria-label="Your repositories"><\/div>/, 'the label survives the listbox role');
   assert.match(SCRIPT, /class="ghrow" data-full="' \+ esc\(r\.full_name\) \+ '" aria-current="' \+ \(r\.full_name === sel\) \+ '"/, 'the chosen row is aria-current');
   assert.match(HUB, /\.ghrow\[aria-current=true\]\{/, 'and painted through it');
-  assert.doesNotMatch(HUB, /aria-selected/, 'aria-selected went with the option role');
+  assert.doesNotMatch(SCRIPT.match(/[^\n]*class="ghrow"[^\n]*/)[0], /aria-selected/, 'aria-selected went with the repo picker\'s option role');
   assert.match(SCRIPT, /if \(ev\.key !== 'Escape' \|\| \$\('ghList'\)\.hidden\) return;\n\s*ev\.stopPropagation\(\);\n\s*\$\('ghSearch'\)\.focus\(\);\n\s*closeRepoList\(\);/, 'Escape closes the list after handing focus back');
   assert.match(SCRIPT, /if \(ev\.relatedTarget && !\$\('ghAdopt'\)\.contains\(ev\.relatedTarget\)\) closeRepoList\(\);/, 'focus leaving the picker closes it; a null relatedTarget is left alone');
   assert.match(fn('openCard'), /\$\('cardScrim'\)\.hidden = false;\n\s*pageInert\(true\);\n\s*\$\('cardClose'\)\.focus\(\);/);

package/tests/upgrade_migrate.mjs

@@ -23,6 +23,9 @@ import { mkdtempSync, mkdirSync, writeFileSync, readFileSync, realpathSync, syml
 import { tmpdir } from 'node:os';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
+import { EventEmitter } from 'node:events';
+// ESM named imports: knip credits a CJS export only when a test imports it this way.
+import { migrateError, migrateFailureDetail, teeSpawn } from '../scripts/gds/upgrade-migrate.js';
 
 const require = createRequire(import.meta.url);
 const { migratePlan, CORE_MIGRATE_SCRIPT } = require('../scripts/gds/upgrade-migrate.js');
@@ -193,3 +196,81 @@ test('the real fallback command resolves the project as its instance root, despi
   const blind = rootsOf(execFileSync('bash', [CORE_MIGRATE_SCRIPT, '--print-roots'], { cwd: dir, env: base, encoding: 'utf8' }));
   assert.notEqual(blind.INSTANCE_ROOT, dir, 'without INIT_CWD pinned, a stray value decides which project is migrated');
 });
+
+// ── a failed migrate names its migration and psql's ERROR line (task 1004734) ──────────
+// Seen 2026-10-14: toast's move 1.21.20 → 1.21.115 rolled back and the hub kept only
+// "migrate failed (exit 3)". Which file and which error were in the box's journal alone.
+const FAKE_DSN = ['postgres://app', 'Sup3rS3cretPassw0rd@db.internal/prod'].join(':');
+const MIGRATE_OUT = 'skip   core_001_base (already applied)\napply  core_998_ok\napply  core_999_x\n';
+const PSQL_ERR = `psql:node_modules/@bongos/core/migrations/core_999_x.sql:7: ERROR:  check constraint "tasks_kind_check" of relation "tasks" is violated by some row ${FAKE_DSN}\n`;
+
+function failingMigrateRun(calls, opts = {}) {
+  const base = recordingRun(calls, opts);
+  return (cmd, args = [], o = {}) => {
+    if ((cmd === 'bash' && args[0] === CORE_MIGRATE_SCRIPT) || (cmd === 'npm' && args[0] === 'run' && args[1] === 'migrate')) {
+      calls.push({ line: `${cmd} ${args.join(' ')}`.trim(), opts: o });
+      return { status: 3, stdout: MIGRATE_OUT, stderr: PSQL_ERR };
+    }
+    return base(cmd, args, o);
+  };
+}
+
+test('runMigrate: a failing migration comes back with its file name and psql\'s ERROR line', async () => {
+  const mig = await u.runMigrate(adoptedProject(), failingMigrateRun([]));
+  assert.equal(mig.ok, false);
+  assert.equal(mig.code, 3);
+  const error = migrateError(mig);
+  assert.match(error, /^migrate failed \(exit 3\)/, 'the prefix upgrade-outcome.js keys on is unchanged');
+  assert.match(error, /core_999_x/, 'names the migration that was being applied when it stopped');
+  assert.doesNotMatch(error, /core_998_ok/, 'and not an earlier one that applied cleanly');
+  assert.match(error, /ERROR: +check constraint "tasks_kind_check" of relation "tasks" is violated by some row/);
+  assert.doesNotMatch(error, /Sup3rS3cretPassw0rd/, 'a credential in the error never reaches the hub');
+});
+
+test('migrateFailureDetail scrubs secrets and caps the length', () => {
+  const d = migrateFailureDetail(`apply  core_999_x\nERROR:  bad value ${FAKE_DSN} ${'x'.repeat(5000)}\n`);
+  assert.doesNotMatch(d, /Sup3rS3cretPassw0rd/);
+  assert.ok(d.length <= 400, `capped (${d.length})`);
+  assert.match(d, /core_999_x/);
+  assert.equal(migrateFailureDetail('npm error code 1\n'), '', 'nothing recognisable adds nothing');
+  assert.match(migrateFailureDetail('psql:/x/migrations/core_5_y.sql:3: ERROR:  boom\n'), /core_5_y.*ERROR: +boom/, 'psql\'s own file prefix stands in for a missing apply line');
+});
+
+test('a full upgrade whose migrate fails reports the migration, the error, and a CHECK-violation class', async () => {
+  const dir = adoptedProject({ installed: '1.19.312' });
+  const res = await u.runUpgrade(
+    { to: '1.19.1029', registry: true, instance: dir, service: 'mercury', healthCheck: false },
+    {
+      log: () => {}, err: () => {},
+      run: failingMigrateRun([], { dir, installTo: '1.19.1029' }),
+      materialize: () => ({ skills: 0 }), regenerateApiArtifacts: () => ({ ok: true, ran: [] }),
+      databaseUrl: '', pgDatabase: '',
+    },
+  );
+  assert.equal(res.ok, false);
+  assert.match(res.error, /^migrate failed \(exit 3\) at core_999_x: ERROR: +check constraint "tasks_kind_check"/);
+  const outcome = require('../scripts/gds/upgrade-outcome.js');
+  assert.equal(outcome.upgradeReason(res), 'migrate_check_violation');
+  assert.equal(outcome.classifyFailure('migrate_check_violation').class, 'unknown', 'existing rows break the new rule: a person decides, never an unattended retry');
+});
+
+test('teeSpawn streams the child\'s output live AND keeps it for the failure report', async () => {
+  const pipe = () => Object.assign(new EventEmitter(), { setEncoding() {} });
+  let child;
+  const spawnImpl = (cmd, args, opts) => {
+    child = Object.assign(new EventEmitter(), { stdout: pipe(), stderr: pipe(), opts });
+    return child;
+  };
+  const out = [], err = [];
+  const p = teeSpawn('bash', ['m.sh'], { cwd: '/x' }, { spawnImpl, out: { write: (c) => out.push(c) }, err: { write: (c) => err.push(c) } });
+  child.stdout.emit('data', 'apply  core_999_x\n');
+  assert.deepEqual(out, ['apply  core_999_x\n'], 'written through as it arrives, not after the child exits');
+  child.stderr.emit('data', 'ERROR:  boom\n');
+  assert.deepEqual(err, ['ERROR:  boom\n']);
+  child.emit('close', 3);
+  const r = await p;
+  assert.equal(r.status, 3);
+  assert.match(r.output, /apply {2}core_999_x[\s\S]*ERROR: {2}boom/);
+  assert.deepEqual(child.opts.stdio, ['inherit', 'pipe', 'pipe']);
+  assert.equal(child.opts.cwd, '/x');
+});

package/tests/wizard_physics.mjs

@@ -126,7 +126,7 @@ test('every choice the questions offer is an answer the server accepts', () => {
   const checks = HUB.slice(HUB.indexOf('id="checksMain"'), HUB.indexOf('id="checksStop"'));
   assert.deepEqual([...new Set([...checks.matchAll(/data-phys="([a-z_]+)"/g)].map((m) => m[1]))], ['minors_on_board', 'builder_geography', 'entity'],
     'the quick checks ask about under-18s, where builders will be and who is behind it in the mockup’s order');
-  assert.match(checks, /<select id="physCountry">/, 'and where you are');
+  assert.match(checks, /<select id="physCountry" aria-labelledby="physCountryLbl">/, 'and where you are (the select the searchable list picks for, task 1004671)');
   const seen = [...panel.matchAll(/data-phys="([a-z_]+)" data-val="([^"]+)"/g)];
   assert.ok(seen.length >= 20, 'the questions\' choices');
   for (const [, key, raw] of seen) {

package/tests/wizard_physics_more.mjs

@@ -608,3 +608,136 @@ test('the address is on every path, the demo\'s too: never a fixed row, always c
     assert.equal(w.run('firstInvalidRow()'), null, `${label}: then Create goes on`);
   }
 });
+
+// ── "Where are you?" as a searchable list (task 1004671) ─────────────────────
+// The combobox only picks for the hidden select, so everything that reads the select
+// (the region, the screen, the draft, the fill, what Create sends) is the same path.
+const key = (k) => ({ key: k, preventDefault() {}, stopPropagation() {} });
+function typeCountry(w, text) {
+  w.$('physCountryIn').value = text;
+  w.$('physCountryIn').listeners.input();
+}
+const shownCodes = (w) => plain(w.run('cboxShown.map(function (i) { return i.code; })'));
+
+test('the country starts at the United States, in a combobox in front of the select', () => {
+  const w = boot();
+  w.run('physDefaults(); paintChecks();');
+  assert.equal(w.a().home_country, 'US', 'the default answer is the United States');
+  assert.equal(w.$('physCountry').value, 'US', 'on the select everything reads');
+  assert.equal(w.$('physCountryIn').value, 'United States', 'and said by name in the field');
+  assert.equal(w.$('physRegionField').hidden, false, 'so the state field is there from the start');
+  assert.equal(w.$('physCountry').hidden, true, 'the script hides the plain select');
+  assert.equal(w.$('physCountryBox').hidden, false, 'and shows the searchable field');
+  const input = w.$('physCountryIn'), list = w.$('physCountryList');
+  assert.equal(input.getAttribute('role'), 'combobox');
+  assert.equal(input.getAttribute('aria-controls'), 'physCountryList');
+  assert.equal(input.getAttribute('aria-expanded'), 'false');
+  assert.equal(list.getAttribute('role'), 'listbox');
+  assert.equal(list.hidden, true, 'closed until asked');
+  // a choice taken back stays taken back, and the last project's answers still win
+  const cleared = boot();
+  cleared.run('phys().answers.home_country = null; physDefaults();');
+  assert.equal(cleared.a().home_country, null);
+  const filled = boot({ draft: {} });
+  filled.run('phys(); physDefaults(); physAccountAnswers = { home_country: "NL" };');
+  filled.$('physFromAccount').click();
+  assert.equal(filled.a().home_country, 'NL', 'the fill replaces the default');
+  assert.equal(filled.$('physCountryIn').value, 'Netherlands');
+});
+
+test('typing filters the list, ignoring case and accents, the closest names first', () => {
+  const w = boot();
+  w.run('physDefaults(); paintChecks();');
+  w.$('physCountryIn').listeners.click();
+  assert.equal(w.$('physCountryList').hidden, false, 'a click opens the whole list');
+  assert.equal(w.$('physCountryIn').getAttribute('aria-expanded'), 'true');
+  assert.ok(shownCodes(w).length > 200, 'every country');
+  assert.equal(w.$('physCountryIn').getAttribute('aria-activedescendant'), 'physCountryOpt-US', 'on the one already chosen');
+  typeCountry(w, 'NETH');
+  assert.deepEqual(shownCodes(w), ['NL', 'BQ'], 'case does not matter; the name that starts with it first, then Caribbean Netherlands');
+  typeCountry(w, 'cote');
+  assert.deepEqual(shownCodes(w), ['CI'], 'nor accents (Côte d’Ivoire)');
+  typeCountry(w, 'curacao');
+  assert.deepEqual(shownCodes(w), ['CW']);
+  typeCountry(w, 'ger');
+  assert.equal(shownCodes(w)[0], 'DE', 'a name that starts with it leads');
+  assert.ok(shownCodes(w).includes('NG') && shownCodes(w).includes('DZ'), 'then names with it inside');
+  typeCountry(w, 'usa');
+  assert.equal(shownCodes(w)[0], 'US');
+  typeCountry(w, 'zzz');
+  assert.deepEqual(shownCodes(w), []);
+  assert.equal(w.$('physCountryNone').hidden, false, 'nothing matches, and it says so');
+  assert.equal(w.$('physCountryIn').getAttribute('aria-activedescendant'), null);
+  // every option is a node with its name as text, never markup
+  const opts = w.$('physCountryList').children.filter((c) => c.getAttribute('data-code'));
+  assert.ok(opts.length > 200);
+  const nl = opts.find((c) => c.getAttribute('data-code') === 'NL');
+  assert.equal(nl.textContent, 'Netherlands');
+  assert.equal(nl.getAttribute('role'), 'option');
+  assert.equal(nl.getAttribute('id'), 'physCountryOpt-NL');
+  assert.doesNotMatch(SCRIPT.slice(SCRIPT.indexOf('function cboxFold('), SCRIPT.indexOf('function physCountryChanged(')), /innerHTML/);
+});
+
+test('arrow keys move through the list, Enter picks, Escape puts the country back', () => {
+  const w = boot();
+  w.run('physDefaults(); paintChecks();');
+  const input = w.$('physCountryIn');
+  typeCountry(w, 'ger');
+  assert.equal(input.getAttribute('aria-activedescendant'), 'physCountryOpt-DE');
+  input.listeners.keydown(key('ArrowDown'));
+  const second = shownCodes(w)[1];
+  assert.equal(input.getAttribute('aria-activedescendant'), 'physCountryOpt-' + second);
+  input.listeners.keydown(key('ArrowUp'));
+  assert.equal(input.getAttribute('aria-activedescendant'), 'physCountryOpt-DE');
+  input.listeners.keydown(key('Enter'));
+  assert.equal(w.a().home_country, 'DE', 'Enter picks');
+  assert.equal(w.$('physCountry').value, 'DE');
+  assert.equal(input.value, 'Germany');
+  assert.equal(w.$('physCountryList').hidden, true, 'and closes the list');
+  assert.equal(input.getAttribute('aria-expanded'), 'false');
+  typeCountry(w, 'fra');
+  input.listeners.keydown(key('Escape'));
+  assert.equal(w.a().home_country, 'DE', 'Escape changes nothing');
+  assert.equal(input.value, 'Germany', 'and puts the chosen name back');
+  assert.equal(w.$('physCountryList').hidden, true);
+  input.listeners.keydown(key('ArrowDown'));
+  assert.equal(w.$('physCountryList').hidden, false, 'ArrowDown opens it again');
+  assert.equal(input.getAttribute('aria-activedescendant'), 'physCountryOpt-DE');
+  typeCountry(w, 'France');
+  input.listeners.blur();
+  assert.equal(w.a().home_country, 'FR', 'leaving with a whole name typed picks it');
+  typeCountry(w, 'fr');
+  input.listeners.blur();
+  assert.equal(w.a().home_country, 'FR', 'leaving half way keeps the country');
+  assert.equal(input.value, 'France');
+});
+
+test('a country picked from the list runs the select\'s own path: the region, the screen and what Create sends', async () => {
+  const w = boot();
+  w.run('physDefaults(); paintChecks();');
+  w.a().home_region = 'US-CA';
+  typeCountry(w, 'canada');
+  const ca = w.$('physCountryList').children.find((c) => c.getAttribute('data-code') === 'CA');
+  ca.click();
+  assert.equal(w.a().home_country, 'CA');
+  assert.equal(w.a().home_region, null, 'a state of another country is dropped');
+  assert.equal(w.$('physRegionField').hidden, false, 'a country with provinces asks for one');
+  assert.ok(w.$('physRegion').children.some((o) => o.value === 'CA-ON'));
+  typeCountry(w, 'netherlands');
+  w.$('physCountryList').children.find((c) => c.getAttribute('data-code') === 'NL').click();
+  assert.equal(w.$('physRegionField').hidden, true, 'and one without does not');
+  await w.settle();
+  const asked = w.fetched.filter((f) => f.url.includes('physics-check')).map((f) => f.body.detail.home_country);
+  assert.deepEqual(asked, ['CA', 'NL'], 'each pick asks the table again, with the code');
+  // the same code the select path sends
+  const viaSelect = boot();
+  viaSelect.run('physDefaults(); paintChecks();');
+  viaSelect.$('physCountry').value = 'NL';
+  viaSelect.$('physCountry').listeners.change();
+  assert.deepEqual(plain(w.run('createDetail()')), plain(viaSelect.run('createDetail()')), 'Create sends exactly what the select sends');
+  assert.equal(plain(w.run('createDetail()')).home_country, 'NL');
+  // and untouched, Create sends the default
+  const untouched = boot();
+  untouched.run('physDefaults(); paintChecks();');
+  assert.equal(plain(untouched.run('createDetail()')).home_country, 'US');
+});