@bongos/core 1.21.106 → 1.21.107

package/tests/autopickup_cap_db.mjs

@@ -0,0 +1,115 @@
+// tests/autopickup_cap_db.mjs — the auto-pickup cap holds under a race, against a
+// REAL Postgres (task 1004677 / BV2.TW19a, ADR 0371 D5).
+//
+// tests/autopickup_cap.mjs proves the refusal ladder DB-free. What it cannot prove
+// is the claim this file exists for: two runners racing for the LAST slot cannot
+// both get it. That is a property of pg_advisory_xact_lock plus the count running
+// inside the claim's transaction, so it needs a real database and two real
+// connections.
+//
+// It SELF-SKIPS (exit 0) with no reachable Postgres, and is listed in
+// run-unit-tests.js's INTEGRATION set so the DB-free lane never runs it. It builds
+// throwaway `tasks` and `claims` tables, so point it at a scratch database.
+//
+// Run:  DATABASE_URL=postgres://... node tests/autopickup_cap_db.mjs
+
+import pg from 'pg';
+import fs from 'node:fs';
+import path from 'node:path';
+import url from 'node:url';
+import { createRequire } from 'node:module';
+import { strict as assert } from 'node:assert';
+
+const require = createRequire(import.meta.url);
+const pool = new pg.Pool({ connectionString: process.env.DATABASE_URL || undefined });
+
+try {
+  await pool.query('SELECT 1');
+} catch (e) {
+  console.log(`autopickup_cap_db.mjs SKIPPED — no reachable Postgres (${e.code || e.message}). Set DATABASE_URL to run.`);
+  await pool.end().catch(() => {});
+  process.exit(0);
+}
+const { rows: realRows } = await pool.query(`SELECT to_regclass('public.builders') IS NOT NULL AS has_builders`);
+if (realRows[0].has_builders) {
+  console.log('autopickup_cap_db.mjs SKIPPED — this database has a `builders` table, so it is not a scratch DB.');
+  await pool.end().catch(() => {});
+  process.exit(0);
+}
+
+let passed = 0, failed = 0;
+async function t(name, fn) {
+  try { await fn(); passed++; console.log(`  ok  ${name}`); }
+  catch (e) { failed++; console.log(`  FAIL ${name}\n     ${e.message}`); }
+}
+
+await pool.query(`
+  CREATE TABLE IF NOT EXISTS schema_migrations (version text PRIMARY KEY);
+  CREATE TABLE IF NOT EXISTS tasks (id bigint PRIMARY KEY, source text);
+  CREATE TABLE IF NOT EXISTS claims (
+    id bigserial PRIMARY KEY, task_id bigint, builder_id bigint,
+    claimed_at timestamptz DEFAULT now(), released_at timestamptz);
+`);
+const HERE = path.dirname(url.fileURLToPath(import.meta.url));
+await pool.query(fs.readFileSync(path.join(HERE, '..', 'migrations', 'core_275_claims_auto_pickup.sql'), 'utf8'));
+
+const { autoPickupRefusal, countThisMonth } = require('../modules/lifecycle/autopickup.js');
+
+async function reset() {
+  await pool.query('TRUNCATE claims, tasks');
+  await pool.query(`INSERT INTO tasks (id, source) VALUES (1,'page-tweak'),(2,'page-tweak'),(3,'page-tweak'),(4,'manual')`);
+}
+
+// One marked claim the way claimTask makes it: BEGIN, the gate (which takes the
+// lock and counts), the insert, COMMIT. `pause` holds the transaction open after
+// the count so the other racer's count is forced to happen while it is in flight.
+async function markedClaim(taskId, settings, pause = 0) {
+  const client = await pool.connect();
+  try {
+    await client.query('BEGIN');
+    const refusal = await autoPickupRefusal(client, { id: taskId, source: 'page-tweak' }, settings);
+    if (refusal) { await client.query('ROLLBACK'); return refusal.code; }
+    if (pause) await new Promise((r) => setTimeout(r, pause));
+    await client.query('INSERT INTO claims (task_id, builder_id, auto_pickup) VALUES ($1, 1, TRUE)', [taskId]);
+    await client.query('COMMIT');
+    return 'claimed';
+  } catch (e) {
+    await client.query('ROLLBACK').catch(() => {});
+    throw e;
+  } finally { client.release(); }
+}
+
+await t('core_275 adds a nullable auto_pickup column', async () => {
+  const { rows } = await pool.query(`SELECT is_nullable, data_type FROM information_schema.columns WHERE table_name='claims' AND column_name='auto_pickup'`);
+  assert.equal(rows[0].data_type, 'boolean');
+  assert.equal(rows[0].is_nullable, 'YES');
+});
+
+await t('two runners racing for the last slot: exactly one wins', async () => {
+  await reset();
+  await pool.query(`INSERT INTO claims (task_id, builder_id, auto_pickup) VALUES (3, 1, TRUE)`); // cap 2, one used
+  const settings = { mode: 'on', cap: 2 };
+  const results = await Promise.all([markedClaim(1, settings, 300), markedClaim(2, settings, 300)]);
+  assert.deepEqual(results.sort(), ['AUTO_PICKUP_CAP_REACHED', 'claimed'], JSON.stringify(results));
+  assert.equal(await countThisMonth(pool), 2);
+});
+
+await t('a round applied twice automatically refuses a third marked claim', async () => {
+  await reset();
+  const settings = { mode: 'on', cap: 20 };
+  assert.equal(await markedClaim(1, settings), 'claimed');
+  assert.equal(await markedClaim(1, settings), 'claimed');
+  assert.equal(await markedClaim(1, settings), 'AUTO_PICKUP_ROUND_LIMIT');
+});
+
+await t('unmarked claims and last month\'s marked claims do not count', async () => {
+  await reset();
+  await pool.query(`INSERT INTO claims (task_id, builder_id, auto_pickup, claimed_at) VALUES
+    (1, 1, NULL, now()), (2, 1, FALSE, now()), (3, 1, TRUE, date_trunc('month', now()) - interval '1 day'),
+    (4, 1, TRUE, now())`); // task 4 is not a page tweak
+  assert.equal(await countThisMonth(pool), 0);
+});
+
+await pool.end();
+console.log(`\n${passed} passed, ${failed} failed`);
+process.exit(failed ? 1 : 0); // the doorway's own pool would otherwise hold the process open

package/tests/government_act_alone_buildings.mjs

@@ -242,6 +242,7 @@ const BAD = 'x';
 const REQUESTS = {
   'PATCH /project-settings/rot-days': ['PATCH', '/project-settings/rot-days', { days: 'soon' }],
   'PATCH /project-settings/ship-mode': ['PATCH', '/project-settings/ship-mode', { mode: 'sometimes' }],
+  'PATCH /project-settings/tweak-autopickup': ['PATCH', '/project-settings/tweak-autopickup', { mode: 'sometimes' }],
   'PATCH /work-categories/:id': ['PATCH', `/work-categories/${BAD}`, {}],
   'POST /security/reports/:id/confirm': ['POST', `/security/reports/${BAD}/confirm`, {}],
   'POST /security/reports/:id/dispute': ['POST', `/security/reports/${BAD}/dispute`, {}],